Re: [RFC PATCH v3] pci: Concurrency issue during pci enable bridge

2017-08-16 Thread Srinath Mannam
Hi Bjorn, Thank you for the feedback. My comments are in lined. On Wed, Aug 16, 2017 at 7:13 PM, Bjorn Helgaas wrote: > On Fri, Aug 04, 2017 at 08:27:28PM +0530, Srinath Mannam wrote: >> Concurrency issue is observed during pci enable bridge called >> for multiple pci devices in

Re: [RFC PATCH] pci: Concurrency issue in NVMe Init through PCIe switch

2017-05-29 Thread Srinath Mannam
Hi Bjorn, On Sat, May 27, 2017 at 12:57 AM, Bjorn Helgaas wrote: > Hi Srinath, > > Thanks for chasing this down! It must have been a real hassle to find > this. > > On Mon, May 08, 2017 at 08:39:50PM +0530, Srinath Mannam wrote: >> We found a concurrency issue in NVMe

[RFC PATCH v2] pci: Concurrency issue in NVMe Init through PCIe switch

2017-05-30 Thread Srinath Mannam
read value 0 and ready to write 2 and 4. After last point final value in PCI_COMMAND register is 4 instead of 6. Place 2: CPU 0: 1. Done Atomic increment dev->enable_cnt in pci_enable_device_flags Signed-off-by: Srinath Mannam --- Changes since v1: - Used mutex to syncroni

Re: [PATCH v3 2/2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-08-03 Thread Srinath Mannam
Hi Adrian Hunter, Thank you very much for your review and feedback. I will do the change and update next patch set. Regards, Srinath. On Fri, Aug 3, 2018 at 6:47 PM, Adrian Hunter wrote: > On 30/07/18 09:15, Srinath Mannam wrote: >> Add ACPI support to all IPROC SDHCI varients >

[PATCH v4 2/2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-08-05 Thread Srinath Mannam
Add ACPI support to all IPROC SDHCI varients Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vladimir Olovyannikov --- drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-iproc.c | 59 -- 2 files

[PATCH v4 1/2] mmc: sdhci-pltfm: Convert DT properties to generic device properties

2018-08-05 Thread Srinath Mannam
From: Adrian Hunter Convert DT properties to generic device properties so that drivers can get properties from DT or ACPI. Signed-off-by: Adrian Hunter Tested-by: Srinath Mannam --- drivers/mmc/host/sdhci-pltfm.c | 68 +- drivers/mmc/host/sdhci-pltfm.h

[PATCH v4 0/2] Add ACPI support to IPROC SDHCI

2018-08-05 Thread Srinath Mannam
e properties Adrian Hunter (1): mmc: sdhci-pltfm: Convert DT properties to generic device properties Srinath Mannam (1): mmc: host: iproc: Add ACPI support to IPROC SDHCI drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-iproc.c | 59 drivers/mm

Re: [PATCH v2 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-06-21 Thread Srinath Mannam
Hi Rob, Please find my comments for the reason to have multiple DT nodes. On Thu, Jun 21, 2018 at 1:22 AM, Rob Herring wrote: > On Mon, Jun 18, 2018 at 02:01:17PM +0530, Srinath Mannam wrote: >> From: Pramod Kumar >> >> Add binding document for supported thermal implemen

[PATCH v3 0/3] Stingray thermal driver support

2018-08-09 Thread Srinath Mannam
These patches adds the stingray thermal driver and its corresponding DT nodes with documentation. Changes from v2: - All stingray TMON DT nodes are combine together into single. Temperature registers are combined into one mem resource. brcm,tmon-mask parameter has available TMONs mask va

[PATCH v3 2/3] arm64: dts: stingray: Add Stingray Thermal DT support.

2018-08-09 Thread Srinath Mannam
From: Pramod Kumar Add DT nodes for thermal zones memory base address to read temperature. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 13 + 1 file changed

[PATCH v3 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-08-09 Thread Srinath Mannam
From: Pramod Kumar Add binding document for supported thermal implementation in Stingray. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- .../bindings/thermal/brcm,sr-thermal.txt | 23 ++ 1 file

[PATCH v3 3/3] thermal: broadcom: Add Stingray thermal driver

2018-08-09 Thread Srinath Mannam
From: Pramod Kumar Adds stingray thermal driver to monitor six thermal zones temperature and trips at critical temperature. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vikram Prakash --- drivers/thermal/Kconfig

Re: [1/2] dt-bindings: phy: Add stingray usb phy documentation

2018-08-13 Thread Srinath Mannam
Hi JC, On Tue, Aug 14, 2018 at 7:24 AM, Jayachandran C wrote: > Hi Srinath, Ray, > > On Fri, Jul 07, 2017 at 06:37:04PM +0530, Srinath Mannam wrote: >> Add DT binding document for stingray usb phy driver. >> >> Signed-off-by: Srinath Mannam >> Reviewed-by:

Re: [PATCH v4 2/2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-08-14 Thread Srinath Mannam
Hi Ulf Hansson, Please kindly provide your inputs. Regards, Srinath. On Mon, Aug 6, 2018 at 12:13 PM, Hunter, Adrian wrote: > Acked-by: Adrian Hunter > >> -Original Message----- >> From: Srinath Mannam [mailto:srinath.man...@broadcom.com] >> Sent: Sunday, Augus

Re: [PATCH] watchdog: sp805: Add clock-frequency property

2018-07-25 Thread Srinath Mannam
:12 AM, Guenter Roeck wrote: > On 07/23/2018 01:37 AM, Srinath Mannam wrote: >> >> Use clock-frequency property given in _DSD object >> of ACPI device to calculate Watchdog rate as binding >> clock devices are not available as device tree. >> >> Note: The

[PATCH v2] watchdog: sp805: Add clock-frequency property

2018-07-25 Thread Srinath Mannam
Use clock-frequency property given in _DSD object of ACPI device to calculate Watchdog rate as binding clock devices are not available as device tree. Note: There is no formal review process for _DSD properties Signed-off-by: Srinath Mannam Reviewed-by: Guenter Roeck Reviewed-by: Ray Jui

Re: [PATCH] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-25 Thread Srinath Mannam
Hi Ulf Hansson, Kindly review this patch. Thank you, Regards, Srinath. On Tue, Jul 17, 2018 at 10:15 PM, Srinath Mannam wrote: > Add ACPI support to all IPROC SDHCI varients > > Signed-off-by: Srinath Mannam > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Rev

Re: [PATCH] watchdog: sp805: Add clock-frequency property

2018-07-25 Thread Srinath Mannam
Hi Guenter, Thank you.. I sent next version patch with modification. Regards, Srinath. On Thu, Jul 26, 2018 at 10:39 AM, Guenter Roeck wrote: > On 07/25/2018 09:47 PM, Srinath Mannam wrote: >> >> Hi Guenter, >> >> It was my mistake sorry for that. I thought to add

[PATCH] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC

2018-07-26 Thread Srinath Mannam
Add ACPI identifier HID for UART DW 8250 on Broadcom SoCs to match the HID passed through ACPI tables to enable UART controller. Signed-off-by: Srinath Mannam Reviewed-by: Vladimir Olovyannikov Tested-by: Vladimir Olovyannikov Reviewed-by: Ray Jui --- drivers/tty/serial/8250/8250_dw.c | 1

Re: [PATCH] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC

2018-07-27 Thread Srinath Mannam
Hi Andy, Thank you very much for quick review. I will address your comment and send next patch set. Regards, Srinath. On Fri, Jul 27, 2018 at 2:04 PM, Andy Shevchenko wrote: > On Fri, 2018-07-27 at 09:31 +0530, Srinath Mannam wrote: >> Add ACPI identifier HID for UART DW 8250 on Broa

[PATCH v2] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC

2018-07-27 Thread Srinath Mannam
Add ACPI identifier HID for UART DW 8250 on Broadcom SoCs to match the HID passed through ACPI tables to enable UART controller. Signed-off-by: Srinath Mannam Reviewed-by: Vladimir Olovyannikov Tested-by: Vladimir Olovyannikov Reviewed-by: Ray Jui Reviewed-by: Andy Shevchenko --- drivers

Re: [PATCH] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-27 Thread Srinath Mannam
Hi Adrian Hunter, Thank you very much for review and feedback. Please find my comments inline.. On Fri, Jul 27, 2018 at 11:50 AM, Adrian Hunter wrote: > On 17/07/18 19:45, Srinath Mannam wrote: >> Add ACPI support to all IPROC SDHCI varients >> >> Signed-off-by: Srinath M

Re: [PATCH] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-27 Thread Srinath Mannam
Hi Adrian Hunter, Thank you very much for your inputs. I will send next patch set with all your suggested modifications. Regards, Srinath. On Fri, Jul 27, 2018 at 4:45 PM, Adrian Hunter wrote: > On 27/07/18 11:59, Srinath Mannam wrote: >> Hi Adrian Hunter, >> >> Thank you

Re: [PATCH v2] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC

2018-07-28 Thread Srinath Mannam
Hi Greg k-h Sorry for my mistake, I will send v3 patchset with details of V1 and V2 changes. Regards, Srinath. On Sat, Jul 28, 2018 at 8:24 PM, Greg Kroah-Hartman wrote: > On Fri, Jul 27, 2018 at 02:12:50PM +0530, Srinath Mannam wrote: >> Add ACPI identifier HID for UART DW 8250 on

[PATCH v3] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC

2018-07-28 Thread Srinath Mannam
Add ACPI identifier HID for UART DW 8250 on Broadcom SoCs to match the HID passed through ACPI tables to enable UART controller. Signed-off-by: Srinath Mannam Reviewed-by: Vladimir Olovyannikov Tested-by: Vladimir Olovyannikov Reviewed-by: Ray Jui Reviewed-by: Andy Shevchenko --- Changes

[PATCH v2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-28 Thread Srinath Mannam
Add ACPI support to all IPROC SDHCI varients Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vladimir Olovyannikov --- Changes from v1: - Removed sdhci_iproc_data array change and add directly into of and acpi id tables. - Add a change to get

Re: [PATCH v2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-29 Thread Srinath Mannam
tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Srinath-Mannam/mmc-host-iproc-Add-ACPI-support-to-IPROC-SDHCI/20180729-003026 > base: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next > config: i

Re: [PATCH v2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-29 Thread Srinath Mannam
Hi Adrian Hunter, Thank you for the confirmation. I will send patch series now. Regards, Srinath. On Mon, Jul 30, 2018 at 11:40 AM, Adrian Hunter wrote: > On 30/07/18 09:02, Srinath Mannam wrote: >> Hi Adrian Hunter, >> >> Auto build error came to this patch, becaus

[PATCH v3 2/2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-07-29 Thread Srinath Mannam
Add ACPI support to all IPROC SDHCI varients Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vladimir Olovyannikov --- drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-iproc.c | 63 +- 2 files

[PATCH v3 0/2] Add ACPI support to IPROC SDHCI

2018-07-29 Thread Srinath Mannam
property read change. - Used sdhci_get_property to get properties. - Verified with patch given by Adrian Hunter mmc: sdhci-pltfm: Convert DT properties to generic device properties Adrian Hunter (1): mmc: sdhci-pltfm: Convert DT properties to generic device properties Srinath Mannam (1)

[PATCH v3 1/2] mmc: sdhci-pltfm: Convert DT properties to generic device properties

2018-07-29 Thread Srinath Mannam
From: Adrian Hunter Convert DT properties to generic device properties so that drivers can get properties from DT or ACPI. Signed-off-by: Adrian Hunter Tested-by: Srinath Mannam --- drivers/mmc/host/sdhci-pltfm.c | 68 +- drivers/mmc/host/sdhci-pltfm.h

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-18 Thread Srinath Mannam
Hi Alex, On Tue, Jul 17, 2018 at 8:52 PM, Alex Williamson wrote: > On Fri, 13 Jul 2018 10:26:17 +0530 > Srinath Mannam wrote: > >> By default all BARs map with VMA access permissions >> as pgprot_noncached. >> >> In ARM64 pgprot_noncached is MT_DEVICE_nGnRnE

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-19 Thread Srinath Mannam
HI Alex, On Thu, Jul 19, 2018 at 2:55 AM, Alex Williamson wrote: > On Thu, 19 Jul 2018 00:05:18 +0530 > Srinath Mannam wrote: > >> Hi Alex, >> >> On Tue, Jul 17, 2018 at 8:52 PM, Alex Williamson >> wrote: >> > On Fri, 13 Jul 2018 10:26:17 +0530 >>

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-19 Thread Srinath Mannam
HI Alex, On Thu, Jul 19, 2018 at 8:42 PM, Alex Williamson wrote: > On Thu, 19 Jul 2018 20:17:11 +0530 > Srinath Mannam wrote: > >> HI Alex, >> >> On Thu, Jul 19, 2018 at 2:55 AM, Alex Williamson >> wrote: >> > On Thu, 19 Jul 2018 00:05:18 +0530 >

Re: [RFC PATCH v3] watchdog: sp805: Add clock-frequency property

2018-07-22 Thread Srinath Mannam
Hi Guenter, I will send the updated patch.. Thank you. Regards, Srinath. On Sat, Jul 21, 2018 at 8:08 PM, Guenter Roeck wrote: > On 07/10/2018 01:44 AM, Srinath Mannam wrote: >> >> When using ACPI node, binding clock devices are >> not available as device tree, So clock-

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-23 Thread Srinath Mannam
On Sat, Jul 21, 2018 at 1:57 AM, Alex Williamson wrote: > On Thu, 19 Jul 2018 21:49:48 +0530 > Srinath Mannam wrote: > >> HI Alex, >> >> On Thu, Jul 19, 2018 at 8:42 PM, Alex Williamson >> wrote: >> > On Thu, 19 Jul 2018 20:17:11 +0530 >

[PATCH] watchdog: sp805: Add clock-frequency property

2018-07-23 Thread Srinath Mannam
Use clock-frequency property given in _DSD object of ACPI device to calculate Watchdog rate as binding clock devices are not available as device tree. Note: There is no formal review process for _DSD properties Signed-off-by: Srinath Mannam Signed-off-by: Guenter Roeck Reviewed-by: Guenter

Re: [RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-08-01 Thread Srinath Mannam
are if (arch_can_pci_mmap_wc() && (pci_resource_flags(pdev, index) & IORESOURCE_PREFETCH)) vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); else vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); Please provide your feedback. Thank you. On Mon, Jul 23,

Re: [PATCH v3 2/2] mmc: host: iproc: Add ACPI support to IPROC SDHCI

2018-08-01 Thread Srinath Mannam
Hi Adrian Hunter, Kindly provide your review comments and feedback. Thank you. Regards, Srinath. On Mon, Jul 30, 2018 at 11:45 AM, Srinath Mannam wrote: > Add ACPI support to all IPROC SDHCI varients > > Signed-off-by: Srinath Mannam > Reviewed-by: Ray Jui > Reviewed-by

Re: [PATCH v2 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-07-12 Thread Srinath Mannam
Hi Rob, I have provided my inputs for the purpose of having multiple nodes. Please get back if you have any comments or suggestions. Regards, Srinath. On Tue, Jul 3, 2018 at 4:15 PM, Srinath Mannam wrote: > Hi Rob, > > Kindly provide your feedback. > > Regards, > Srinath.

[RFC PATCH] vfio/pci: map prefetchble bars as writecombine

2018-07-12 Thread Srinath Mannam
from doing unaligned access. In CMB NVMe drives PREFETCHABLE bars are required to map as MT_NORMAL_NC to do unaligned access. Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Vikram Prakash --- drivers/vfio/pci/vfio_pci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

RE: [RFC PATCH] nvme: avoid race-conditions when enabling devices

2018-03-23 Thread Srinath Mannam
; Srinath Mannam Subject: Re: [RFC PATCH] nvme: avoid race-conditions when enabling devices > On Wed, Mar 21, 2018 at 05:10:56PM +0100, Marta Rybczynska wrote: >> >> The problem may happen also with other device doing its probe and >> nvme running its workqueue (and we pro

[PATCH v4 0/3] Stingray thermal driver support

2018-09-27 Thread Srinath Mannam
These patches adds the stingray thermal driver and its corresponding DT nodes with documentation. Changes from v3 - Addressed Daniel lezcano comments. - Elaborated commit description of thermal driver patch. - Added brcm,max-crit-temp DT parameter. Changes from v2: - All stingray TMON DT

[PATCH v4 3/3] thermal: broadcom: Add Stingray thermal driver

2018-09-27 Thread Srinath Mannam
d-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vikram Prakash --- drivers/thermal/Kconfig | 3 +- drivers/thermal/broadcom/Kconfig | 9 ++ drivers/thermal/broadcom/Makefile | 1 + drivers/thermal/broadcom/sr-thermal.c

[PATCH v4 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-09-27 Thread Srinath Mannam
From: Pramod Kumar Add binding document for supported thermal implementation in Stingray. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- .../bindings/thermal/brcm,sr-thermal.txt | 25 ++ 1 file

[PATCH v4 2/3] arm64: dts: stingray: Add Stingray Thermal DT support.

2018-09-27 Thread Srinath Mannam
From: Pramod Kumar Add DT nodes for thermal zones memory base address to read temperature. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 14 ++ 1 file changed

Re: [PATCH 0/3] Stingray usb phy driver support

2018-11-28 Thread Srinath Mannam
Hi Vijay, Could you please help to review and provide your comments to this patch series when you have time? Thank you, Regards, Srinath. On Tue, Nov 13, 2018 at 9:43 AM Srinath Mannam wrote: > > These patches add stingray usb phy driver and its > corresponding DT nodes with docu

Re: [PATCH 2/3] phy: sr-usb: Add stingray usb phy driver

2018-11-29 Thread Srinath Mannam
Hi Kishon, Thank you for review.. Please find my answers below in line. On Thu, Nov 29, 2018 at 3:55 PM Kishon Vijay Abraham I wrote: > > Hi, > > On 13/11/18 9:43 AM, Srinath Mannam wrote: > > This driver supports all versions of stingray SS and HS > > USB phys. >

Re: [PATCH 2/3] phy: sr-usb: Add stingray usb phy driver

2018-11-29 Thread Srinath Mannam
Hi Kishon, Thank you for more information. Please find my answers below in line. On Fri, Nov 30, 2018 at 9:56 AM Kishon Vijay Abraham I wrote: > > Hi, > > On 29/11/18 6:31 PM, Srinath Mannam wrote: > > Hi Kishon, > > > > Thank you for review.. Please

[PATCH 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2018-11-12 Thread Srinath Mannam
] | | | | --- --- | | | | | [SS-PHY0] [HS-PHY0][SS-PHY1] [HS-PHY2] [HS-PHY1] [SS-PHY0/HS-PHY0] and [SS-PHY1/HS-PHY1] are combo PHYs of version1 category has both SS and HS PHYs.. [HS-PHY2] is HS PHY of version2 category. Signed-off-by: Srinath Mannam Reviewed-by: Florian

[PATCH 2/3] phy: sr-usb: Add stingray usb phy driver

2018-11-12 Thread Srinath Mannam
This driver supports all versions of stingray SS and HS USB phys. In version 1 is combo phy contain both SS and HS phys in a common IO space. In version 2 a single HS phy. These phys support both xHCI host driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam Reviewed

[PATCH 1/3] dt-bindings: phy: Add binding document for stingray usb phy

2018-11-12 Thread Srinath Mannam
Add DT binding document for stingray usb phy. Signed-off-by: Srinath Mannam Reviewed-by: Florian Fainelli Reviewed-by: Scott Branden --- .../bindings/phy/brcm,stingray-usb-phy.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

[PATCH 0/3] Stingray usb phy driver support

2018-11-12 Thread Srinath Mannam
These patches add stingray usb phy driver and its corresponding DT nodes with documentation. All patches are based on Linux-4.19. Srinath Mannam (3): dt-bindings: phy: Add binding document for stingray usb phy phy: sr-usb: Add stingray usb phy driver arm64: dts: Add USB DT nodes for

Re: [PATCH v5 0/3] Stingray thermal driver support

2018-12-04 Thread Srinath Mannam
Hi, Could you please provide your feedback to this patch series? Regards, Srinath. On Thu, Nov 8, 2018 at 3:45 AM Florian Fainelli wrote: > > > > On 10/16/2018 8:11 AM, Srinath Mannam wrote: > > These patches adds the stingray thermal driver and its > > corresponding DT

[PATCH v2 2/3] phy: sr-usb: Add stingray usb phy driver

2018-12-03 Thread Srinath Mannam
This driver supports all versions of stingray SS and HS USB phys. In version 1 is combo phy contain both SS and HS phys in a common IO space. In version 2 a single HS phy. These phys support both xHCI host driver and BDC Broadcom device controller driver. Signed-off-by: Srinath Mannam Reviewed

[PATCH v2 1/3] dt-bindings: phy: Add binding document for stingray usb phy

2018-12-03 Thread Srinath Mannam
Add DT binding document for stingray usb phy. Signed-off-by: Srinath Mannam Reviewed-by: Florian Fainelli Reviewed-by: Scott Branden --- .../bindings/phy/brcm,stingray-usb-phy.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 Documentation

[PATCH v2 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2018-12-03 Thread Srinath Mannam
] | | | | --- --- | | | | | [SS-PHY0] [HS-PHY0][SS-PHY1] [HS-PHY2] [HS-PHY1] [SS-PHY0/HS-PHY0] and [SS-PHY1/HS-PHY1] are combo PHYs of version1 category has both SS and HS PHYs.. [HS-PHY2] is HS PHY of version2 category. Signed-off-by: Srinath Mannam Reviewed-by: Florian

[PATCH v2 0/3] Stingray usb phy driver support

2018-12-03 Thread Srinath Mannam
These patches add stingray usb phy driver and its corresponding DT nodes with documentation. All patches are based on Linux-4.19. Changes from v1: - Addressed Kishon review comments - phy init call return value handle Srinath Mannam (3): dt-bindings: phy: Add binding document for

[RFC PATCH] ACPI: bus: match of_device_id using acpi device

2018-07-03 Thread Srinath Mannam
: Srinath Mannam --- drivers/acpi/bus.c | 23 +++ include/linux/acpi.h | 10 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 84b4a62..e676bf7 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -830,6 +830,29

Re: [PATCH v2 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-07-03 Thread Srinath Mannam
Hi Rob, Kindly provide your feedback. Regards, Srinath. On Fri, Jun 22, 2018 at 11:21 AM, Srinath Mannam wrote: > Hi Rob, > > Please find my comments for the reason to have multiple DT nodes. > > On Thu, Jun 21, 2018 at 1:22 AM, Rob Herring wrote: >> On Mon, Jun 18, 201

Re: [RFC PATCH] watchdog: sp805: Add clock-frequency property

2018-07-08 Thread Srinath Mannam
Hi Guenter, Thank you for the clarification.. Please find my comments. On Sun, Jul 8, 2018 at 11:36 PM, Guenter Roeck wrote: > On 07/06/2018 01:18 AM, Srinath Mannam wrote: >> >> Hi Guenter, >> >> Thank you very much for your feedback. Please find my comments. >&g

[RFC PATCH v2] watchdog: sp805: Add clock-frequency property

2018-07-09 Thread Srinath Mannam
When using ACPI node, binding clock devices are not available as device tree, So clock-frequency property given in _DSD object of ACPI device is used to calculate Watchdog rate. Signed-off-by: Srinath Mannam --- drivers/watchdog/sp805_wdt.c | 34 ++ 1 file

Re: [RFC PATCH v2] watchdog: sp805: Add clock-frequency property

2018-07-10 Thread Srinath Mannam
Hi Guenter, Thank you for your feedback. Please find my answers in lined. On Mon, Jul 9, 2018 at 7:15 PM, Guenter Roeck wrote: > On 07/09/2018 03:19 AM, Srinath Mannam wrote: >> >> When using ACPI node, binding clock devices are >> not available as device tree, So clock-

Re: [RFC PATCH v2] watchdog: sp805: Add clock-frequency property

2018-07-10 Thread Srinath Mannam
Hi Guenter, I missed your comment about "Clearing wdt->clk is useless." I will remove that line. Regards, Srinath. On Tue, Jul 10, 2018 at 1:27 PM, Srinath Mannam wrote: > Hi Guenter, > > Thank you for your feedback. Please find my answers in lined. > > On Mon, Jul

[RFC PATCH v3] watchdog: sp805: Add clock-frequency property

2018-07-10 Thread Srinath Mannam
When using ACPI node, binding clock devices are not available as device tree, So clock-frequency property given in _DSD object of ACPI device is used to calculate Watchdog rate. Signed-off-by: Srinath Mannam --- drivers/watchdog/sp805_wdt.c | 35 +-- 1 file

Re: [RFC PATCH v3] watchdog: sp805: Add clock-frequency property

2018-07-11 Thread Srinath Mannam
Guenter Roeck wrote: > On Tue, Jul 10, 2018 at 02:14:39PM +0530, Srinath Mannam wrote: >> When using ACPI node, binding clock devices are >> not available as device tree, So clock-frequency >> property given in _DSD object of ACPI device is >> used to calculate Watchdog r

Re: ACPI support in common clock framework

2018-06-26 Thread Srinath Mannam
Hi Rafael, Stephen, Thank you so much for detailed inputs. In our platform, all HW clocks are accessed (enable/disable/set rate) in Linux through common clock framework (drivers/clk/) using clock nodes exported by device tree. To manage our HW clocks operations (enable/disable/set rate) we have d

[PATCH 0/3] Stingray thermal driver support

2018-05-27 Thread Srinath Mannam
These patches adds the stingray thermal driver and its corresponding DT nodes with documentation. Pramod Kumar (3): dt-bindings: thermal: Add binding document for SR thermal arm64: dts: stingray: Add Stingray Thermal DT support. thermal: broadcom: Add Stingray thermal driver .../bindings/t

[PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-05-27 Thread Srinath Mannam
From: Pramod Kumar Add binding document for supported thermal implementation in Stingray. Signed-off-by: Pramod Kumar Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Srinath Mannam --- .../bindings/thermal/brcm,sr-thermal.txt | 45 ++ 1 file

[PATCH 3/3] thermal: broadcom: Add Stingray thermal driver

2018-05-27 Thread Srinath Mannam
From: Pramod Kumar This commit adds stingray thermal driver to monitor six thermal zones temperature and trips at critical temperature. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vikram Prakash --- drivers/thermal

[PATCH 2/3] arm64: dts: stingray: Add Stingray Thermal DT support.

2018-05-27 Thread Srinath Mannam
From: Pramod Kumar Add DT nodes for thermal zones memory base address to read temperature. Signed-off-by: Pramod Kumar Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Srinath Mannam --- .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 37 ++ 1 file

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-06-18 Thread Srinath Mannam
Hi, Please let me know if you have any comments to this patch. If not can you please accept this patch. Regards, Srinath. On Mon, Jun 4, 2018 at 11:36 AM, Srinath Mannam wrote: > Hi Rob Herring, > > Please find my comments in line.. > > On Fri, Jun 1, 2018 at 7:59 PM, Rob Herrin

[PATCH v2 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-06-18 Thread Srinath Mannam
From: Pramod Kumar Add binding document for supported thermal implementation in Stingray. Signed-off-by: Pramod Kumar Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Srinath Mannam --- .../bindings/thermal/brcm,sr-thermal.txt | 45 ++ 1 file

[PATCH v2 3/3] thermal: broadcom: Add Stingray thermal driver

2018-06-18 Thread Srinath Mannam
From: Pramod Kumar Adds stingray thermal driver to monitor six thermal zones temperature and trips at critical temperature. Signed-off-by: Pramod Kumar Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Vikram Prakash --- drivers/thermal/Kconfig

[PATCH v2 2/3] arm64: dts: stingray: Add Stingray Thermal DT support.

2018-06-18 Thread Srinath Mannam
From: Pramod Kumar Add DT nodes for thermal zones memory base address to read temperature. Signed-off-by: Pramod Kumar Reviewed-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Srinath Mannam --- .../arm64/boot/dts/broadcom/stingray/stingray.dtsi | 37 ++ 1 file

[PATCH v2 0/3] Stingray thermal driver support

2018-06-18 Thread Srinath Mannam
These patches adds the stingray thermal driver and its corresponding DT nodes with documentation. Pramod Kumar (3): dt-bindings: thermal: Add binding document for SR thermal arm64: dts: stingray: Add Stingray Thermal DT support. thermal: broadcom: Add Stingray thermal driver .../bindings/t

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-06-01 Thread Srinath Mannam
Hi Rob Herring, Thank you for the review. Please find my answers inline.. On Thu, May 31, 2018 at 10:18 PM, Rob Herring wrote: > On Mon, May 28, 2018 at 11:11:22AM +0530, Srinath Mannam wrote: >> From: Pramod Kumar >> >> Add binding document for supported thermal implemen

Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal

2018-06-03 Thread Srinath Mannam
Hi Rob Herring, Please find my comments in line.. On Fri, Jun 1, 2018 at 7:59 PM, Rob Herring wrote: > On Fri, Jun 1, 2018 at 3:51 AM, Srinath Mannam > wrote: >> Hi Rob Herring, >> >> Thank you for the review. >> Please find my answers inline.. >> >

Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device

2018-07-03 Thread Srinath Mannam
return -EINVAL; + } + iproc_data = match->data; host = sdhci_pltfm_init(pdev, iproc_data->pdata, sizeof(*iproc_host)); Regards, Srinath. On Tue, Jul 3, 2018 at 11:11 PM, Andy Shevchenko wrote: > On Tue, Jul 3, 2018 at 12:22 PM, Srinath Mannam > wrote: >> This p

Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device

2018-07-04 Thread Srinath Mannam
Hi Sudeep, Andy, Thank you for all the valuable information and knowledge. Regards, Srinath. On Wed, Jul 4, 2018 at 3:08 PM, Sudeep Holla wrote: > > > On 04/07/18 10:32, Andy Shevchenko wrote: >> On Wed, Jul 4, 2018 at 6:37 AM, Srinath Mannam >> wrote: >>> Hi S

[RFC PATCH] watchdog: sp805: Add clock-frequency property

2018-07-04 Thread Srinath Mannam
When using ACPI node, binding clock devices are not available as device tree, So clock-frequency property given in _DSD object of ACPI device is used to calculate Watchdog rate. Signed-off-by: Srinath Mannam --- drivers/watchdog/sp805_wdt.c | 29 - 1 file changed, 24

Re: [RFC PATCH] watchdog: sp805: Add clock-frequency property

2018-07-06 Thread Srinath Mannam
Hi Guenter, Thank you very much for your feedback. Please find my comments. On Thu, Jul 5, 2018 at 8:58 PM, Guenter Roeck wrote: > On 07/04/2018 08:22 PM, Srinath Mannam wrote: >> >> When using ACPI node, binding clock devices are >> not available as device tree, So clock-

ACPI support in common clock framework

2018-06-12 Thread Srinath Mannam
Hi Michael, Stephen, We are adding ACPI support in our Linux based platform. At present our clock hierarchy using common clock framework through DTS. Now we required ACPI support in common clock framework to upgrade our platform. For example, clk_get API called in many drivers to get clock device

Requirement to get BAR pci_bus_address in user space

2018-06-14 Thread Srinath Mannam
Hi Bjorn, We observed an issue in NVMe CMD cards in SPDK NVMe libraries. Similar issue fixed with "nvme-pci: Use PCI bus address for data/queues in CMB" commit in nvme kernel driver. As per the fix, pci_bus_address of CMB bar is required to program to NVMe cards. We need to implement similar fix

Re: Requirement to get BAR pci_bus_address in user space

2018-06-14 Thread Srinath Mannam
++ Alex Williamson, kvm, Hi Christoph, Thank you for quick reply. If we want to add this in vfio then I think we need to do the same in uio case also. As I mentioned in previous mail, in the current implementation resource information (address and size) is gathering from resource named file cre

Re: Requirement to get BAR pci_bus_address in user space

2018-06-14 Thread Srinath Mannam
fix is required in SPDK library also. So, We need a mechanism to get pci_bus_address in user space libraries to address this issue. Regards, Srinath. On Thu, Jun 14, 2018 at 4:03 PM, wrote: > On 2018-06-14 06:29, Srinath Mannam wrote: >> >> ++ Alex Williamson, kvm, >> >>

Re: ACPI support in common clock framework

2018-06-14 Thread Srinath Mannam
Thank you Andy, Regards, Srinath. On Wed, Jun 13, 2018 at 1:43 PM, Andy Shevchenko wrote: > +Cc: Rafael, ACPI ML > > On Wed, Jun 13, 2018 at 7:14 AM, Srinath Mannam > wrote: >> Hi Michael, Stephen, >> >> We are adding ACPI support in our Linux based platform. >

Re: Requirement to get BAR pci_bus_address in user space

2018-06-14 Thread Srinath Mannam
Thank you very much Alex and Ben for all the details. Please find my comments in lined.. On Fri, Jun 15, 2018 at 1:34 AM, Walker, Benjamin wrote: > On Thu, 2018-06-14 at 08:50 -0600, Alex Williamson wrote: >> On Thu, 14 Jun 2018 16:18:15 +0530 >> Srinath Mannam wrote: >&g

[RFC PATCH 2/3] iommu/dma: IOVA reserve for PCI host reserve address list

2018-12-11 Thread Srinath Mannam
. Signed-off-by: Srinath Mannam --- drivers/iommu/dma-iommu.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 511ff9a..346da81 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma-iommu.c @@ -220,6 +220,14 @@ static

[RFC PATCH 3/3] PCI: iproc: Add dma reserve resources to host

2018-12-11 Thread Srinath Mannam
r IOVA address ranges. Signed-off-by: Srinath Mannam --- drivers/pci/controller/pcie-iproc.c | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c index 3160e93..43e465a 100644 --- a/d

[RFC PATCH 1/3] PCI: Add dma-resv window list

2018-12-11 Thread Srinath Mannam
add resource entries to this list based on requirements. Few hosts can't use all inbound address, so those address regions will be add to this list to avoid IOMMU mapping. Signed-off-by: Srinath Mannam --- drivers/pci/probe.c | 3 +++ include/linux/pci.h | 1 + 2 files changed, 4 inser

[RFC PATCH 0/3] PCIe Host request to reserve IOVA

2018-12-11 Thread Srinath Mannam
er of those SOCs has to list all address ranges which have to reserve their IOVA address into PCIe host bridge resource entry list. IOMMU framework will reserve these IOVAs while initializing IOMMU domain. This patch set is based on Linux-4.19-rc1. Srinath Mannam (3): PCI: Add dma-resv window list

Re: [RFC PATCH 3/3] PCI: iproc: Add dma reserve resources to host

2018-12-13 Thread Srinath Mannam
Hi Oza, Thank you for the review. Please find my comments in lined. On Thu, Dec 13, 2018 at 11:33 AM wrote: > > On 2018-12-12 11:16, Srinath Mannam wrote: > > IPROC host has the limitation that it can use > > only those address ranges given by dma-ranges > > property as

[PATCH v2 0/3] PCIe Host request to reserve IOVA

2018-12-13 Thread Srinath Mannam
ments. Srinath Mannam (3): PCI: Add dma-resv window list iommu/dma: IOVA reserve for PCI host reserve address list PCI: iproc: Add dma reserve resources to host drivers/iommu/dma-iommu.c | 8 ++ drivers/pci/controller/pcie-iproc.c | 51 - driver

[PATCH v2 1/3] PCI: Add dma-resv window list

2018-12-13 Thread Srinath Mannam
dress ranges will be add to this list to avoid IOMMU mapping. While initializing IOMMU domain of PCI EPs connected to that host bridge IOVAs for this given list of address ranges will be reserved. Signed-off-by: Srinath Mannam Based-on-patch-by: Oza Pawandeep --- drivers/pci/probe.c | 3 +++ in

[PATCH v2 2/3] iommu/dma: IOVA reserve for PCI host reserve address list

2018-12-13 Thread Srinath Mannam
. Signed-off-by: Srinath Mannam Based-on-patch-by: Oza Pawandeep --- drivers/iommu/dma-iommu.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 511ff9a..346da81 100644 --- a/drivers/iommu/dma-iommu.c +++ b/drivers/iommu/dma

[PATCH v2 3/3] PCI: iproc: Add dma reserve resources to host

2018-12-13 Thread Srinath Mannam
00, 0x1 - 0x8, 0x10 - 0x80 and 0x100 - 0x. are not allowed to use as inbound addresses. So that we need to add these address ranges to dma_resv list to reserve corresponding IOVA address ranges. Signed-off-by: Srinath Mannam Based-on-pa

Re: [PATCH v6 1/3] dt-bindings: thermal: Add binding document for SR thermal

2019-01-06 Thread Srinath Mannam
Hi Rob, Thank you for the note. I will take care from next time onward. Thanks & Regards, Srinath. On Thu, Jan 3, 2019 at 10:31 PM Rob Herring wrote: > > On Thu, 3 Jan 2019 14:25:32 +0530, Srinath Mannam wrote: > > From: Pramod Kumar > > > > Add binding do

Re: [PATCH v5 0/3] Stingray thermal driver support

2019-01-01 Thread Srinath Mannam
inelli wrote: > > > > > > On 04/12/2018 19:17, Srinath Mannam wrote: > > > > > > > > Hi, > > > > > > > > Could you please provide your feedback to this patch series? > > > Rui or Eduardo can we get either one of you to review the th

Re: [PATCH v5 2/3] thermal: broadcom: Add Stingray thermal driver

2019-01-02 Thread Srinath Mannam
Hi Eduardo Valentin, Thank you for the review. I will address your comments in next patchset. Please find my comments in lined. On Thu, Jan 3, 2019 at 1:33 AM Eduardo Valentin wrote: > > On Tue, Oct 16, 2018 at 08:41:19PM +0530, Srinath Mannam wrote: > > From: Pramod Kumar > >

  1   2   3   >