if (ret < 0) {
- /* "opp-hz" is optional for devices like power domains. */
- if (!opp_table->is_genpd) {
- dev_err(dev, "%s: opp-hz not found\n", __func__);
- goto free_opp;
- }
+ if
ation.
Reviewed-by: Sibi Sankar
Signed-off-by: Georgi Djakov
---
v7:
New patch.
...
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
Hey Georgi,
On 2020-04-24 21:24, Georgi Djakov wrote:
In addition to clocks and regulators, some devices can scale the
bandwidth
of their on-chip interconnect - for example between CPU and DDR memory.
Add
support for that, so that platforms which support it can make use of
it.
Signed-off-by:
both.
Reviewed-by: Sibi Sankar
Signed-off-by: Georgi Djakov
---
v7:
* Addressed review comments from Viresh.
v2:
https://lore.kernel.org/r/20190423132823.7915-5-georgi.dja...@linaro.org
drivers/opp/core.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/driver
On 2020-04-24 21:24, Georgi Djakov wrote:
This is the same as the traditional of_icc_get() function, but the
difference is that it takes index as an argument, instead of name.
Reviewed-by: Sibi Sankar
Signed-off-by: Georgi Djakov
---
v7:
* Addressed review comments from Sibi.
* Re-based
Hey Georgi,
Apart from the Matthias's comments
ran into a few issues during testing.
On 2020-04-24 21:24, Georgi Djakov wrote:
The OPP bindings now support bandwidth values, so add support to parse
it
from device tree and store it into the new dev_pm_opp_icc_bw struct,
which
is part of the de
Hey Viresh,
Thanks for taking time to review
the series.
On 2020-05-05 10:15, Viresh Kumar wrote:
On 05-05-20, 01:52, Sibi Sankar wrote:
Add and export 'dev_pm_opp_update_voltage' to update the voltage of an
opp for a given frequency. This will be useful to update the opps with
vol
On 2020-05-05 10:26, Viresh Kumar wrote:
On 05-05-20, 01:52, Sibi Sankar wrote:
Add support for setting tags on icc paths associated with
the opp_table.
Signed-off-by: Sibi Sankar
---
drivers/opp/of.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
Maybe
On 2020-05-05 10:20, Viresh Kumar wrote:
On 05-05-20, 01:52, Sibi Sankar wrote:
Add support to parse optional OPP table attached to the cpu node when
the OPP bandwidth values are populated. This allows for scaling of
DDR/L3 bandwidth levels with frequency change.
Signed-off-by: Sibi Sankar
On 2020-05-05 03:33, Saravana Kannan wrote:
On Mon, May 4, 2020 at 1:24 PM Sibi Sankar
wrote:
Add and export 'dev_pm_opp_get_path_count' to get the icc path count
associated with the device.
This is not related to OPP. You should add this helper function to ICC
framework?
yes it
On 2020-06-01 16:31, Viresh Kumar wrote:
On 29-05-20, 17:00, Sibi Sankar wrote:
> > +static int qcom_cpufreq_update_opp(struct device *cpu_dev,
> > +unsigned long freq_khz,
> > +unsigned long volt)
> > +{
uot;)
Cc: sta...@vger.kernel.org
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c
index 111a442c993c4..fd6fd36268d93 100644
--- a/drivers/remoteproc/qcom_q6v5.c
+++ b/drive
Remove the redundant running state, as an equivalent is maintained in
the common q6v5 resource handling helpers.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
b/drivers/remoteproc
Evan,
Thanks for taking time to review
the series.
On 2020-06-02 23:14, Evan Green wrote:
On Tue, Jun 2, 2020 at 9:33 AM Sibi Sankar
wrote:
Sometimes the stop triggers a watchdog rather than a stop-ack. Update
the running state to false on requesting stop to skip the watchdog
instead.
Error
Hey Pradeep,
Thanks for the patch.
On 2020-06-03 14:39, Pradeep P V K wrote:
Interconnect bandwidth scaling support is now added as a
part of OPP [1]. So, make sure interconnect driver is ready
before handling interconnect scaling.
This change is based on
[1] [Patch v8] Introduce OPP bandwidth
On 2020-06-04 16:43, p...@codeaurora.org wrote:
Hi Sibi,
Thanks for the review!!
On 2020-06-03 17:22, Sibi Sankar wrote:
Hey Pradeep,
Thanks for the patch.
On 2020-06-03 14:39, Pradeep P V K wrote:
Interconnect bandwidth scaling support is now added as a
part of OPP [1]. So, make sure
On 2020-06-03 15:37, govi...@codeaurora.org wrote:
Hi Mani,
On 2020-06-03 05:57, Manivannan Sadhasivam wrote:
On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote:
On Tue, Jun 2, 2020 at 12:40 PM John Stultz
wrote:
> On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote:
> > On Mon, Ju
On 2020-06-04 22:39, Matthias Kaehlcke wrote:
On Thu, Jun 04, 2020 at 04:44:42PM +0530, Pradeep P V K wrote:
Interconnect bandwidth scaling support is now added as a
part of OPP [1]. So, make sure interconnect driver is ready
before handling interconnect scaling.
This change is based on
[1] [Pa
On 2020-06-04 04:03, Evan Green wrote:
On Tue, Jun 2, 2020 at 10:29 PM Sibi Sankar
wrote:
Evan,
Thanks for taking time to review
the series.
On 2020-06-02 23:14, Evan Green wrote:
> On Tue, Jun 2, 2020 at 9:33 AM Sibi Sankar
> wrote:
>>
>> Sometimes the stop triggers a wa
that's what we are actually doing
Reviewed-by: Sibi Sankar
+ ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL);
+ if (ret)
+ goto bus_clk_disable;
+
msm_host->opp_table = dev_pm_opp_set_clkname(&pdev->dev, "core");
Add SC7180 to cpufreq-dt-platdev blacklist since the actual scaling is
handled by the 'qcom-cpufreq-hw' driver.
Reviewed-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Sibi Sankar
---
v6:
* No change
v5:
* Picked up R-b from Amit
v4:
* Updated commit message
Add and export 'dev_pm_opp_set_bw' to set the bandwidth
levels associated with an OPP.
Signed-off-by: Sibi Sankar
---
v6:
* Pass NULL to _set_opp_bw
v5:
https://lkml.org/lkml/2020/5/27/7
* Rework the patch based on ^^
v4:
https://patchwork.kernel.org/patch/11019737/
* Pass dev
ps://lore.kernel.org/lkml/20190410102429.r6j6brm5kspmqxc3@vireshk-i7/
https://lore.kernel.org/lkml/20190410112516.gnh77jcwawvld6et@vireshk-i7/
* Dropped cpufreq-map passive governor
Sibi Sankar (5):
cpufreq: blacklist SDM845 in cpufreq-dt-platdev
cpufreq: blacklist SC7180 in cpufreq-dt-platdev
O
Add SDM845 to cpufreq-dt-platdev blacklist since the actual scaling is
handled by the 'qcom-cpufreq-hw' driver.
Reviewed-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
Signed-off-by: Sibi Sankar
---
v6:
* No change
v5:
* Picked up R-b from Amit
v4:
* Updated commit message
Add support to parse optional OPP table attached to the cpu node when
the OPP bandwidth values are populated. This allows for scaling of
DDR/L3 bandwidth levels with frequency change.
Signed-off-by: Sibi Sankar
---
v6:
* Add global flag to distinguish between voltage update and opp add.
Use
Disable fast switch when the opp-tables required for scaling DDR/L3
are populated.
Signed-off-by: Sibi Sankar
---
v6:
* No change
v5:
* Drop dev_pm_opp_get_path_count [Saravana]
drivers/cpufreq/qcom-cpufreq-hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Hey Will,
On 2020-05-11 23:25, Sibi Sankar wrote:
The modem remote processor has two access paths to DDR. One path is
directly connected to DDR and another path goes through an SMMU. The
SMMU path is configured to be a direct mapping because it's used by
various peripherals in the
On 2020-09-03 12:23, Viresh Kumar wrote:
On 31-08-20, 09:41, ansuels...@gmail.com wrote:
On 31-08-20, Sibi wrote:
> On 2020-08-24 16:10, Viresh Kumar wrote:
> > +Vincent/Saravana/Sibi
> >
> > On 21-08-20, 16:00, Ansuel Smith wrote:
> >> This adds Krait Cache scaling support using the cpufreq not
an earlier loop.
However req is a stack variable and its initial value
is undefined.
So initialize req to 0.
Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart
helpers")
Tom,
Thanks for the patch.
Reviewed-by: Sibi Sankar
Signed-off-by: Tom Rix
---
driver
On 2020-08-17 14:14, Ulf Hansson wrote:
On Thu, 13 Aug 2020 at 19:26, Sibi Sankar wrote:
On 2020-08-13 18:04, Ulf Hansson wrote:
> On Wed, 12 Aug 2020 at 19:03, Sibi Sankar wrote:
>>
>> Uffe,
>> Thanks for taking time to review the
>> series!
>>
>>
On 2020-08-24 16:10, Viresh Kumar wrote:
+Vincent/Saravana/Sibi
On 21-08-20, 16:00, Ansuel Smith wrote:
This adds Krait Cache scaling support using the cpufreq notifier.
I have some doubt about where this should be actually placed (clk or
cpufreq)?
Also the original idea was to create a dedica
On 2020-08-13 18:04, Ulf Hansson wrote:
On Wed, 12 Aug 2020 at 19:03, Sibi Sankar wrote:
Uffe,
Thanks for taking time to review the
series!
On 2020-08-12 15:15, Ulf Hansson wrote:
> On Tue, 11 Aug 2020 at 21:03, Sibi Sankar wrote:
>>
>> This is for power domains which needs
Add DDR/L3 bandwidth votes for the pro variant of SC7180 SoC, as it support
frequencies upto 2.5 GHz.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
b/arch/arm64/boot/dts/qcom
The modem firmware memory requirements vary between 32M/140M on
no-lte/lte skus respectively, so fixup the modem memory region
to reflect the requirements.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 4
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
Tweak the DDR/L3 bandwidth votes on the lite variant of the SC7180 SoC
since the gold cores only support frequencies upto 2.1 GHz.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sc7180-lite.dtsi | 14 ++
1 file changed, 14 insertions(+)
create mode 100644 arch/arm64/boot
starting its sleep sequence.
The application processor powers off these power domains only if the
co-processor has crashed or powered off and remains unaltered during
system suspend/resume.
Signed-off-by: Sibi Sankar
---
V2:
* Add more info in commit msg and description [Uffe/Kevin/Stephen
model this behavior.
Signed-off-by: Sibi Sankar
---
V2:
* Use the renamed flags
* Drop R-b/T-b
drivers/soc/qcom/qcom_aoss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index ed2c687c16b31..da763ac6bca2f 100644
--- a/drivers/soc
On 2020-07-09 19:59, Bjorn Andersson wrote:
On Wed 08 Jul 19:22 PDT 2020, Steev Klimaszewski wrote:
On 7/2/20 3:46 PM, Sibi Sankar wrote:
> Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs.
>
> Signed-off-by: Sibi Sankar
> ---
Hi Sibi,
Bjorn asked me
On 2020-10-17 04:29, Doug Anderson wrote:
Hi,
On Thu, Oct 15, 2020 at 10:53 AM Sibi Sankar
wrote:
Tweak the DDR/L3 bandwidth votes on the lite variant of the SC7180 SoC
since the gold cores only support frequencies upto 2.1 GHz.
Signed-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom
Hey Chris,
Thanks for the patch.
On 2020-11-03 08:49, Chris Lew wrote:
Not all upcoming usecases will have an interface to allow the aoss
driver to hook onto. Expose the send api and create a get function to
enable drivers to send their own messages to aoss.
Signed-off-by: Chris Lew
---
drive
The application processor accessing the MBA region after assigning it to
the remote Q6 would lead to an XPU violation. Fix this by un-mapping the
MBA region post firmware copy and MBA text log dumps.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 37
Fix the sparse warnings reported by the kernel test bot by replacing
ioremap calls with memremap.
Reported-by: kernel test robot
Signed-off-by: Sibi Sankar
---
I'll send out the patches to convert ioremap to memremap on other
qc remoteproc drivers once I get a chance to test them.
dr
, but the phandle arguments could contain an additional data,
such
as tag information. Let's create another callback xlate_extended() for
the
cases where providers want also populate the tagging data.
Signed-off-by: Georgi Djakov
Tested-by: Sibi Sankar
Reviewed-by: Sibi Sankar
--
On 2020-07-23 18:39, Georgi Djakov wrote:
Use the qcom_icc_xlate_extended() in order to parse tags, that are
specified as an additional arguments to the path endpoints in DT.
Signed-off-by: Georgi Djakov
Tested-by: Sibi Sankar
Reviewed-by: Sibi Sankar
---
drivers/interconnect/qcom
On 2020-07-23 18:39, Georgi Djakov wrote:
Increase the number of interconnect-cells, as now we can include
the tag information. The consumers can specify the path tag as an
additional argument to the endpoints.
Tested-by: Sibi Sankar
Reviewed-by: Sibi Sankar
https://patchwork.kernel.org
_GPL(qcom_icc_set);
+struct icc_node_data *qcom_icc_xlate_extended(struct of_phandle_args *spec, void *data)
+{
+ struct icc_node_data *ndata;
+ struct icc_node *node;
+
+ if (!spec)
+ return ERR_PTR(-EINVAL);
+
you could probably skip ^^ check
Tested-by: Sibi Sa
Add modem debug policy support which will enable coredumps and live
debug support when the msadp firmware is present on secure devices.
Signed-off-by: Sibi Sankar
---
v2:
* Use request_firmware_direct [Bjorn]
* Use Bjorn's template to show if debug policy is present
* Add size che
size check to prevent memcpy out of bounds [Bjorn]
* Don't dump logs in mba_reclaim path [Bjorn]
* Move has_mba_logs check to q6v5_dump_mba_logs [Bjorn]
* SDM845 mss was incorrectly marked to support mba logs
* Drop patch 3 where mba text logs are added to imem for now
Sibi Sankar (2):
On SC7180 the MBA firmware stores the bootup text logs in a 4K segment
at the beginning of the MBA region. Add support to extract the logs
which will be useful to debug mba boot/authentication issues.
Signed-off-by: Sibi Sankar
---
V2:
* Don't dump logs in mba_reclaim path [Bjorn]
*
data. This
outdated data may actually keep the path still enabled and prevent the
device from going into lower power states.
Reported-by: Atul Dhudase
Fixes: 7d374b209083 ("interconnect: Add helpers for enabling/disabling
a path")
Signed-off-by: Georgi Djakov
---
Reviewed-by: Sib
On 2020-07-14 22:48, Mathieu Poirier wrote:
On Thu, Jul 09, 2020 at 01:31:54PM -0700, Rishabh Bhatnagar wrote:
From: Sibi Sankar
In order to land inline coredump support for mss, the dump_segment
function would need to support granularities less than the segment
size. This is achieved by
On 2020-07-14 22:48, Mathieu Poirier wrote:
On Thu, Jul 09, 2020 at 01:31:54PM -0700, Rishabh Bhatnagar wrote:
From: Sibi Sankar
In order to land inline coredump support for mss, the dump_segment
function would need to support granularities less than the segment
size. This is achieved by
function.
Signed-off-by: Rishabh Bhatnagar
Reviewed-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 11 ++-
drivers/remoteproc/remoteproc_coredump.c | 160
+++
include/linux/remoteproc.h | 21 +++-
3 files changed, 166 insertions(+), 26
On 2020-07-28 08:08, Jonathan Marek wrote:
These two bindings are almost identical, so combine them into one. This
will make it easier to add the sm8150 and sm8250 interconnect bindings.
Signed-off-by: Jonathan Marek
Reviewed-by: Sibi Sankar
---
.../{qcom,sdm845.yaml => qcom,rpmh.y
On 2020-07-28 08:08, Jonathan Marek wrote:
The Qualcomm SM8150 platform has several bus fabrics that could be
controlled and tuned dynamically according to the bandwidth demand.
Signed-off-by: Jonathan Marek
Reviewed-by: Rob Herring
Reviewed-by: Sibi Sankar
---
.../bindings/interconnect
On 2020-07-28 08:08, Jonathan Marek wrote:
The Qualcomm SM8250 platform has several bus fabrics that could be
controlled and tuned dynamically according to the bandwidth demand.
Signed-off-by: Jonathan Marek
Reviewed-by: Rob Herring
Reviewed-by: Sibi Sankar
---
.../bindings/interconnect
and generated from downstream dts.
Signed-off-by: Jonathan Marek
Reviewed-by: Sibi Sankar
---
drivers/interconnect/qcom/Kconfig | 10 +
drivers/interconnect/qcom/Makefile | 2 +
drivers/interconnect/qcom/sm8150.c | 635 +
drivers/interconnect/qcom/sm8150.h
and generated from downstream dts.
Signed-off-by: Jonathan Marek
Reviewed-by: Sibi Sankar
---
drivers/interconnect/qcom/Kconfig | 10 +
drivers/interconnect/qcom/Makefile | 2 +
drivers/interconnect/qcom/sm8250.c | 651 +
drivers/interconnect/qcom/sm8250.h
;;
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ aggre2_noc: interconnect@170 {
+ compatible = "qcom,sm8150-aggre2-noc";
+ re
On 2020-07-28 08:08, Jonathan Marek wrote:
Add the interconnect dts nodes for sm8250.
Signed-off-by: Jonathan Marek
Reviewed-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 82
1 file changed, 82 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom
Hey Jonathan,
Thanks for the patch! Please use the
suggested register space definitions
instead.
On 2020-07-13 21:11, Jonathan Marek wrote:
Add the interconnect dts nodes for sm8250.
Signed-off-by: Jonathan Marek
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 82
1 f
Hey Jonathan,
Thanks for the patch! Please use the
suggested register space definitions
instead.
On 2020-07-13 21:11, Jonathan Marek wrote:
Add the interconnect dts nodes for sm8150.
Signed-off-by: Jonathan Marek
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 82
1 f
Hey Jonathan,
Thanks for the patch!
On 2020-07-13 21:11, Jonathan Marek wrote:
Add driver for the Qualcomm interconnect buses found in SM8150 based
platforms. The topology consists of several NoCs that are controlled by
a remote processor that collects the aggregated bandwidth for each
master-sl
Hey Jonathan,
Thanks for the patch!
On 2020-07-13 21:11, Jonathan Marek wrote:
Add driver for the Qualcomm interconnect buses found in SM8250 based
platforms. The topology consists of several NoCs that are controlled by
a remote processor that collects the aggregated bandwidth for each
master-sl
On 2020-07-24 20:06, Jonathan Marek wrote:
On 7/24/20 10:13 AM, Sibi Sankar wrote:
Hey Jonathan,
Thanks for the patch! Please use the
suggested register space definitions
instead.
Thanks for the suggestions, I was unsure what to use for the sizes.
The reg field is unused by the upstream
On 2020-07-22 09:24, Bjorn Andersson wrote:
On Tue 21 Jul 04:29 PDT 2020, Sibi Sankar wrote:
Add modem debug policy support which will enable coredumps and live
debug support when the msadp firmware is present on secure devices.
Signed-off-by: Sibi Sankar
---
v2:
* Use
t mba logs
* Drop patch 3 where mba text logs are added to imem
Sibi Sankar (3):
remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load
remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before
load
remoteproc: qcom_q6v5_mss: Add modem debug policy support
drivers/
sysfs_kf_write+0x58/0x80
kernfs_fop_write+0x140/0x230
vfs_write+0xc4/0x208
ksys_write+0x74/0xf8
__arm64_sys_write+0x24/0x30
...
Fixes: 051fb70fd4ea4 ("remoteproc: qcom: Driver for the self-authenticating
Hexagon v5")
Cc: sta...@vger.kernel.org
Signed-off-by: Sibi Sankar
---
drivers/
Add modem debug policy support which will enable coredumps and live
debug support when the msadp firmware is present on secure devices.
Signed-off-by: Sibi Sankar
---
v3:
* Fix dp_fw leak and create a separate func for dp load [Bjorn]
* Reset dp_size on mba_reclaim
v2:
* Use
r for the self-authenticating
Hexagon v5")
Cc: sta...@vger.kernel.org
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
b/drivers/remoteproc/qcom_q6v5_mss.c
index 4e7
On 2020-07-11 09:07, Rakesh Pillai wrote:
-Original Message-
From: Doug Anderson
Sent: Friday, July 10, 2020 1:36 AM
To: Rakesh Pillai
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
; Evan Green ;
Andy Gross ; Bjorn Andersson
; Rob Herring ; linux-
arm-msm ; LKML ; Sibi
On secure devices there exists a race condition which could lock the MSS
CONFIG AHB bus thus preventing access to BOOT_STATUS register during SSR.
Switch to polling the MSS_STATUS register with an additional 10 us delay
to reliably track boot completion.
Signed-off-by: Sibi Sankar
---
drivers
Update MBA text logs location/size in IMEM to aid tools extract
them after ramdump collection.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
b/drivers/remoteproc/qcom_q6v5_mss.c
index
Add modem debug policy support which will enable coredumps and live
debug support when the msadp firmware is present on secure devices.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers
On SC7180 the MBA firmware stores the bootup text logs in a 4K segment
at the beginning of the MBA region. Add support to extract the logs
which will be useful to debug mba boot/authentication issues.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 41
The series adds support for the following modem debug features:
* Modem debug policy which enables coredumps/live debug on secure devices
* MBA text logs extraction on SC7180 SoCs
Sibi Sankar (3):
remoteproc: qcom_q6v5_mss: Add modem debug policy support
remoteproc: qcom_q6v5_mss: Add MBA
On 2020-07-16 19:13, Manivannan Sadhasivam wrote:
Hi Sibi,
On Thu, Jul 16, 2020 at 06:06:29PM +0530, Sibi Sankar wrote:
On SC7180 the MBA firmware stores the bootup text logs in a 4K segment
at the beginning of the MBA region. Add support to extract the logs
which will be useful to debug mba
ned-off-by: Sibi Sankar
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 -
arch/arm64/boot/dts/qcom/sc7180.dtsi| 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 860fc4658b8b1..26cc4913d3ddc 10
Hey Bjorn,
Thanks for taking time to review
the series.
On 2020-07-17 10:11, Bjorn Andersson wrote:
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote:
Add modem debug policy support which will enable coredumps and live
debug support when the msadp firmware is present on secure devices.
Signed
On 2020-07-17 10:27, Bjorn Andersson wrote:
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote:
On SC7180 the MBA firmware stores the bootup text logs in a 4K segment
at the beginning of the MBA region. Add support to extract the logs
which will be useful to debug mba boot/authentication issues
On 2020-07-17 10:29, Bjorn Andersson wrote:
On Thu 16 Jul 05:36 PDT 2020, Sibi Sankar wrote:
Update MBA text logs location/size in IMEM to aid tools extract
them after ramdump collection.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 3 +++
1 file changed, 3 insertions
undergoing
recovery at the same time. This patch adds inline coredump
functionality that avoids extra memory usage. This requires
recovery to be halted until data is read by userspace and free
function is called.
Signed-off-by: Rishabh Bhatnagar
Reviewed-by: Sibi Sankar
Tested-by: Sibi Sankar
ded in the next
patch.
Signed-off-by: Rishabh Bhatnagar
Tested-by: Sibi Sankar
Reviewed-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 10 +-
drivers/remoteproc/remoteproc_coredump.c | 5 +++--
include/linux/remoteproc.h | 5 +++--
3 files changed, 11
On 2020-08-25 23:23, Bjorn Andersson wrote:
On Tue 25 Aug 02:20 CDT 2020, Stephen Boyd wrote:
Quoting Bjorn Andersson (2020-08-24 09:42:12)
> On Fri 21 Aug 14:41 PDT 2020, Stephen Boyd wrote:
[..]
> > I find it odd that this is modeled as a power domain instead of some
> > Qualcomm specific me
On 2020-09-22 01:26, Stephen Boyd wrote:
Quoting Rafael J. Wysocki (2020-09-21 09:18:17)
On Fri, Aug 21, 2020 at 10:49 PM Sibi Sankar
wrote:
>
> Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the
> status of the PM domain unaltered during suspend/resume respective
), db(27), tl(160), i(1), el(1)
failed to decode incoming message
PDR: tms/servreg get domain list txn wait failed: -14
PDR: service lookup for tms/servreg failed: -14
Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")
Reported-by: Rishabh Bhatnagar
Signed-of
Currently the coredump debugfs entry takes in "disable" to set the
coredump state to "disabled". Let's just accept the expected state
instead.
Fixes: 3afdc59e43904 ("remoteproc: Add coredump debugfs entry")
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/
Stephen,
Thanks for taking time to review the
series.
On 2020-09-16 22:47, Stephen Boyd wrote:
Quoting Sibi Sankar (2020-09-16 07:52:52)
On secure devices which support warm reset, the MBA firmware requires
access to the modem region to clear them out. Hence provide Q6 access
to this region
On secure devices which support warm reset, the MBA firmware requires
access to the modem region to clear them out. Hence provide Q6 access
to this region before MBA boot. This will be a nop during a modem SSR.
Signed-off-by: Sibi Sankar
---
V3:
* Fixup comment style [Stephen]
V2:
* Fixup
In order to land inline coredump support for mss, the dump_segment
function would need to support granularities less than the segment
size. This is achieved by replacing mask based tracking with size.
Signed-off-by: Sibi Sankar
---
drivers/remoteproc/qcom_q6v5_mss.c | 15 +++
1 file
start helpers")
Reported-by: Rishabh Bhatnagar
Signed-off-by: Sibi Sankar
---
I couldn't find the previous patch on patchworks. Resending the patch
since it would need to land on stable trees as well
drivers/soc/qcom/pdr_interface.c | 4 +++-
1 file changed, 3 insertions(+), 1 de
Reviewed-by: Mathieu Poirier
Reviewed-by: Sibi Sankar
Tested-by: Sibi Sankar
---
drivers/remoteproc/Makefile | 1 +
drivers/remoteproc/remoteproc_core.c | 191
-
drivers/remoteproc/remoteproc_coredump.c | 204
memset(dest, 0xff, segment->size);
+ memset(dest, 0xff, cp_size);
}
https://patchwork.kernel.org/patch/11637157/
To deal with chunk sizes lesser
than the segment size I've sent
a patch. With ^^ you would need
to the following as well on top
of that:
qproc->current_du
oc *rproc = filp->private_data;
+ const char *buf = rproc_coredump_str[rproc->dump_conf];
Nit: It would be nice to have a
line feed after the string.
Tested-by: Sibi Sankar
Reviewed-by: Sibi Sankar
+
+ return simple_read_from_buffer(userbuf, count, ppos, buf,
strlen(buf));
+}
+
+/*
+ *
APR client incorrectly prints out "ret" variable on pdr_add_lookup failure,
it should be printing the error value returned by the lookup instead.
Fixes: 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality")
Signed-off-by: Sibi Sankar
---
drivers/soc/qcom/
On secure devices which support warm reset, the modem subsystem requires
access to the mpss region to clear them out. Hence assign the mpss region
to Q6 before MBA cold boot. This will be a nop during a modem SSR.
Signed-off-by: Sibi Sankar
---
I didn't want to add any new flags for warm
Hey Bjorn,
Thanks for taking time to review the
patch.
On 2020-09-15 20:48, Bjorn Andersson wrote:
On Tue 15 Sep 07:34 UTC 2020, Sibi Sankar wrote:
Currently the coredump debugfs entry takes in "disable" to set the
coredump state to "disabled". Let's just accept t
On secure devices which support warm reset, the MBA firmware requires
access to the modem region to clear them out. Hence provide Q6 access
to this region before MBA boot. This will be a nop during a modem SSR.
Signed-off-by: Sibi Sankar
---
V2:
* Fixup comments as suggested by Bjorn
Fix the discrepancy observed between accepted input and read back value
while disabling remoteproc coredump through the coredump debugfs entry.
Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry")
Cc: sta...@vger.kernel.org
Signed-off-by: Sibi Sankar
---
V2:
* Fixup comm
system as a set of
power-domains.
Tested-by: Sibi Sankar
Reviewed-by: Sibi Sankar
Reviewed-by: Douglas Anderson
Reviewed-by: Vinod Koul
Tested-by: Sai Prakash Ranjan
Signed-off-by: Bjorn Andersson
---
Changes since v8:
- ret => time_left
- static const the clk_init_data
drivers/
401 - 500 of 519 matches
Mail list logo
