Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

Hi, Did you read this? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO Thanks, Shyam > This patch fixes the following checkpatch.pl issue at multiple lines: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Sumit P

[PATCH 1/1] Staging: emxx_udc: emxx_udc: fixed coding style issue

fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Shyam Saini --- drivers/staging/emxx_udc/emxx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b

[PATCH 1/1] Staging: comedi: comedi_fops.c: Fixed coding style issue

Fixed following checkpatch.pl warnings WARNING: Prefer WRITE_ONCE(, ) over ACCESS_ONCE() = WARNING: Prefer READ_ONCE() over ACCESS_ONCE() Signed-off-by: Shyam Saini --- drivers/staging/comedi/comedi_fops.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Signed-off-by: Shyam Saini --- drivers/staging/rdma/hfi1/sdma.c | 30 +++--- 1 file changed, 15 insertions(+), 1

[PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Signed-off-by: Shyam Saini --- drivers/staging/rdma/hfi1/rc.c | 12 ++-- drivers/staging/rdma/hfi1/ruc.c | 6 +++--- 2 files changed

[PATCH 525/525] Staging: Wilc1000: Fixed coding style ether_addr_copy

Fixed following warning detected by checkpatch.pl: warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addressesare __aligned(2) Signed-off-by: Shyam Saini --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 25 +++ 1 file changed, 12 insertions(+), 13

[PATCH] Staging: android: timed_gpio: fixed bare use of 'unsigned'

'unsigned int gpio' is added in place of 'unsigned gpio' Signed-off-by: Shyam Saini --- drivers/staging/android/timed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c in

[PATCH] cxgb4: Remove redundant memset before memcpy

The region set by the call to memset, immediately overwritten by the subsequent call to memcpy and thus makes the memset redundant Signed-off-by: Shyam Saini --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4

Re: [PATCH] cxgb4: Remove redundant memset before memcpy

On Fri, Jan 13, 2017 at 04:57:14PM +0100, Tobias Klauser wrote: > On 2017-01-13 at 10:52:49 +0100, Shyam Saini wrote: > > The region set by the call to memset, immediately overwritten by the > > subsequent call to memcpy and thus makes the memset redundant > > > >

[PATCH] cxgb4: Remove redundant memset before memcpy

de of the loop. Signed-off-by: Shyam Saini --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c index cbd68a8..c902635 100644 --- a/drivers/net/ethernet/chelsio

[PATCH] staging: rtl8192e: rtl8192e: Remove NULL test before vfree

vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree. Signed-off-by: Shyam Saini --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH] rtl8188eu: core: Remove NULL test before vfree

vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree(). Signed-off-by: Shyam Saini --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 1/1] gpu: drm: gma500: Use vma_pages()

Replace explicit computation of vma page count by a call to vma_pages() Signed-off-by: Shyam Saini --- drivers/gpu/drm/gma500/framebuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index

[PATCH 1/1] arch: alpha: kernel: Use vma_pages()

Replace explicit computation of vma page count by a call to vma_pages() Signed-off-by: Shyam Saini --- arch/alpha/kernel/pci-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c index 92c0d46..652449e

[PATCH 1/1] cdrom: Remove unused variable using Coccinelle

The variable tocuse is initialized but never used otherwise. semantic patch used for this change is as follows: // @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) // Signed-off-by: Shyam Saini --- drivers/cdrom/gdrom.c | 4 +---

Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()

On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote: > On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini > wrote: > > > > Replace explicit computation of vma page count by a call to > > vma_pages() > Hi, I already have this patch in the "queue" from: >

[PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

Remove the explicit NULL comparison and rewrite in a compact form using Coccinelle Signed-off-by: shyam saini --- drivers/staging/i4l/pcbit/callbacks.c | 4 ++-- drivers/staging/i4l/pcbit/capi.c | 18 +- drivers/staging/i4l/pcbit/drv.c | 14 +++--- drivers

[PATCH 1/1] staging: i4l: pcbit: Remove explicit NULL comparison

Remove the explicit NULL comparison and rewrite in a compact form using Coccinelle Signed-off-by: shyam saini --- drivers/staging/i4l/pcbit/callbacks.c | 4 ++-- drivers/staging/i4l/pcbit/capi.c | 18 +- drivers/staging/i4l/pcbit/drv.c | 14 +++--- drivers

Re: Pause a process execution from external program

Hi Pintu, > Hi All, > I was just wondering if this is possible in the Linux world. > My requirement is: > For some reason, I want to halt/pause the execution (for some > specified time) of a running process/thread (at some location), > without modified the source, may be by firing some events/sig

[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'

Fixed following checkpatch warning WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Shyam Saini --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

Remove the explicit NULL comparison and rewrite in a compact form and fixed switch case indentation issue. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

Fixed checkpatch coding style issues Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..01f3067

[PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 01f3067

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

Fixed switch case indentation issue and void function return statement issue Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging

[PATCH 1/1] Staging: vt6655: Remove explicit NULL comparison using Coccinelle

Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: shyam saini --- drivers/staging/vt6655/rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 890d108..7e69bc9 100644

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > > Remove the explicit NULL comparison and rewrite in a compact form. > > > > Signed-off-by: shyam saini > > --- > >  drivers/staging/

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote: > > > > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > > > > > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > &g

[v1 0/3] Properly handle module_kboject creation

to fix [1] and [2] issues. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=96a1a2412acb [2] https://lore.kernel.org/lkml/20250130225803.321004-1-shyamsa...@linux.microsoft.com/ Thanks, Shyam Shyam Saini (3): kernel: param: rename lo

[v1 1/3] kernel: param: rename locate_module_kobject

() to lookup_or_create_module_kobject(), to better describe its operations. This doesn't change anything functionality wise. Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- kernel/params.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/params.c b/kerne

[v1 3/3] drivers: base: handle module_kboject creation

x this issue by letting module_add_driver() handle module_kobject creation itself. Fixes: 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- drivers/base/module.c | 13 + 1 f

[v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

Move the following to module.h to allow common usages: - lookup_or_create_module_kobject() - to_module_attr - to_module_kobject This makes lookup_or_create_module_kobject() as inline. Signed-off-by: Shyam Saini --- include/linux/module.h | 39 +++ kernel

Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

Hi Everyone, On Wed, Feb 05, 2025 at 09:43:12AM +0100, Rasmus Villemoes wrote: > On Mon, Feb 03 2025, Shyam Saini wrote: > > > Move the following to module.h to allow common usages: > > - lookup_or_create_module_kobject() > > - to_module_attr > > - to_mod

[v2 3/3] drivers: base: handle module_kobject creation

x this issue by letting module_add_driver() handle module_kobject creation itself. Fixes: 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- drivers/base/module.c | 13 + 1 f

[v2 2/3] kernel: refactor and globalize lookup_or_create_module_kobject()

s from the function and add its declaration in module.h - Mark this function as "__modinit". To facilitate this, move the __modinit macro construct to module.h Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- include/linux/module.h | 8 +++ kernel/

[v2 1/3] kernel: param: rename locate_module_kobject

operations. This doesn't change anything functionality wise. Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- kernel/params.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/params.c b/kernel/params.c index 0074d29c9b80..4b43baaf7c83 100644 --- a/k

[v2 0/3] Properly handle module_kobject creation

ect creation and population of module_kset list to fix [1] and [2] issues. - Link: https://lore.kernel.org/lkml/2025020405.1611510-1-shyamsa...@linux.microsoft.com/ Changes in RFC: Reverts commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_

[PATCH v3 3/4] kernel: globalize lookup_or_create_module_kobject()

Signed-off-by: Shyam Saini --- include/linux/module.h | 2 ++ kernel/params.c| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/module.h b/include/linux/module.h index 12f8a7d4fc1c..aeaaf9e068eb 100644 --- a/include/linux/module.h +++ b/include/linux/module.h

[PATCH v3 0/4] Properly handle module_kobject creation

quot;kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Shyam Saini (4): kernel: param: rename locate_module_kobject kernel: refactor lookup_or_create_module_kobject() kernel: globalize lookup_or_create_module_kobject() drivers: base: handle module_kobjec

[PATCH v3 4/4] drivers: base: handle module_kobject creation

x this issue by letting module_add_driver() handle module_kobject creation itself. Fixes: 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- drivers/base/module.c | 13 + 1 f

[PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

non __init code, where using BUG_ON for allocation failure handling is not acceptable. Since we are here, also start using IS_ENABLED instead of #ifdef construct. Suggested-by: Thomas Weißschuh Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- kernel/params.c | 41

[PATCH v3 1/4] kernel: param: rename locate_module_kobject

operations. This doesn't change anything functionality wise. Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- kernel/params.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/params.c b/kernel/params.c index 0074d29c9b80..4b43baaf7c83 100644 --- a/k

Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

Hi Petr, Thank you for the reviews On Tue, Feb 25, 2025 at 09:33:10AM +0100, Petr Pavlu wrote: > On 2/21/25 11:42, Rasmus Villemoes wrote: > > On Thu, Feb 13 2025, Petr Pavlu wrote: > > > >> On 2/11/25 22:48, Shyam Saini wrote: > >>> In the unlikely ev

[PATCH v4 0/4] Properly handle module_kobject creation

Reverts commit 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Shyam Saini (4): kernel: param: rename locate_module_kobject kernel: refactor lookup_or_create_module_kobject() kernel: globalize lookup_or_create_module_kobject() drive

[PATCH v4 4/4] drivers: base: handle module_kobject creation

x this issue by letting module_add_driver() handle module_kobject creation itself. Fixes: 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Cc: sta...@kernel.org Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- drivers/base/module.c |

[PATCH v4 1/4] kernel: param: rename locate_module_kobject

operations. This doesn't change anything functionality wise. Fixes: 96a1a2412acb ("kernel/params.c: defer most of param_sysfs_init() to late_initcall time") Cc: sta...@kernel.org Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- kernel/params.c | 6 +++--- 1 file change

[PATCH v4 2/4] kernel: refactor lookup_or_create_module_kobject()

ggested-by: Thomas Weißschuh Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- kernel/params.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/kernel/params.c b/kernel/params.c index a2441ce059ae..787662663e34 100644 --

[PATCH v4 3/4] kernel: globalize lookup_or_create_module_kobject()

ernel/params.c: defer most of param_sysfs_init() to late_initcall time") Cc: sta...@kernel.org Suggested-by: Rasmus Villemoes Signed-off-by: Shyam Saini --- include/linux/module.h | 2 ++ kernel/params.c| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/

Re: [PATCH v4 0/4] Properly handle module_kobject creation

Hi Petr, On Wed, Mar 05, 2025 at 10:55:03AM +0100, Petr Pavlu wrote: > On 2/27/25 19:49, Shyam Saini wrote: > > Hi Everyone, > > > > This patch series fixes handling of module_kobject creation. > > A driver expect module_kset list populated with its corresponding >

Re: [PATCH v4 0/4] Properly handle module_kobject creation

Hi Greg, > On 2/27/25 19:49, Shyam Saini wrote: > > Hi Everyone, > > > > This patch series fixes handling of module_kobject creation. > > A driver expect module_kset list populated with its corresponding > > module_kobject to create its /sys/module//drivers >