Re: [PATCH] hfsplus/hfsplus_fs.h: Remove unnecessary struct declaration

2021-04-07 Thread Shyam Prasad N
Reviewed-by: Shyam Prasad N On Wed, Apr 7, 2021 at 1:28 AM Wan Jiabing wrote: > > struct hfs_btree is defined at 73rd line. > The declaration here is unnecessary. Remove it. > > Signed-off-by: Wan Jiabing > --- > fs/hfsplus/hfsplus_fs.h | 1 - > 1 file changed, 1 dele

Re: [EXTERNAL] re: cifs: Retain old ACEs when converting between mode bits and ACL.

2021-02-24 Thread Shyam Prasad N
linux-next with Coverity had detected a potential null > pointer dereference with the following commit: > > commit f5065508897a922327f32223082325d10b069ebc > Author: Shyam Prasad N > Date: Fri Feb 12 04:38:43 2021 -0800 > > cifs: Retain old ACEs when converting between mode

Re: [PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-18 Thread Shyam Prasad N
Minor comments inline... On Fri, Dec 18, 2020 at 2:30 AM Boris Protopopov wrote: > > Fix passing of the additional security info via version > operations. Force new open when getting SACL and avoid > reuse of files that were previously open without > sufficient privileges to access SACLs. > > Sig

Re: [PATCH] Add support for getting and setting SACLs

2020-12-02 Thread Shyam Prasad N
Hi Boris, At a high level, the changes look good to me. Will go through the changes in more detail tomorrow morning. On a related note, we may need more test coverage in this area. Can you please share your testing output against your changes? Or even better, if you can contribute some xfstests f

Re: [PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-07 Thread Shyam Prasad N
Hi Vincent, The reason for rejecting the request maybe a number of things like: corrupted request, stale request (for some old session), or for a wrong handle. I don't think we should treat any of these cases as a success. Also, from the MS-SMB2 documentation: https://docs.microsoft.com/en-us/ope