Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti
On Monday 03 September 2012 07:32 PM, Shubhrajyoti D wrote: > Currently in omap2_mcspi_txrx_dma has the rx I meant tx here will resend. please ignore this patch > and the rx support > interleaved. Make the rx related code in omap2_mcspi_rx_dma > and the tx related code omap2_mcsp

Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core

2012-09-11 Thread Shubhrajyoti
On Saturday 08 September 2012 11:34 PM, Aaro Koskinen wrote: > -static struct platform_device *omap_wdt_dev; > - > static unsigned timer_margin; > module_param(timer_margin, uint, 0); > MODULE_PARM_DESC(timer_margin, "initial watchdog timeout (in seconds)"); > > -static unsigned int wdt_trgr_p

Re: [PATCH v4 00/21] OMAP UART Patches

2012-09-11 Thread Shubhrajyoti
On Sunday 09 September 2012 12:34 AM, Felipe Balbi wrote: >> In addition, IMO, if this was only tested on Panda (as suggested by >> > earlier cover letters), it really should not have been merged until it >> > got some broader testing. > Shubhro's got his Tested-by tag. I believe he tested on beagl

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-11 Thread Shubhrajyoti
On Wednesday 12 September 2012 08:51 AM, Mark Brown wrote: > On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote: >> > Currently in omap2_mcspi_txrx_dma the tx and the rx support is >> > interleaved. Make the rx related code in omap2_mcspi_rx_dma >>

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-12 Thread Shubhrajyoti
On Wednesday 12 September 2012 07:09 PM, Felipe Balbi wrote: > seems to be working fine (at least from my quick tests) > > Tested-by: Felipe Balbi Thanks Felipe. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: > + writel(~PHY_PD, phy->control_dev); > + /* XXX: add proper documentation for this delay */ > + mdelay(200); Do you need this to be busy? -- To unsubscribe from this list: se

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 03:16 PM, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: >> On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >>> + writel(~PHY_PD, phy->control_dev); >>> +

Re: [PATCHv4 0/6] media: convert to c99 format

2012-09-23 Thread Shubhrajyoti
On Tuesday 18 September 2012 05:52 PM, Shubhrajyoti D wrote: > The series tries to convert the i2c_msg to c99 struct. > This may avoid issues like below if someone tries to add an > element to the structure. > http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html > &

Re: [PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti
On Tuesday 25 September 2012 04:25 PM, Felipe Balbi wrote: >> +.buf = &addr >> > + }, >> > + {/* setup read ptr */ > should this comment be /* read date */ ?? yes missed that . will update -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCHv3 0/7] rtc: convert to c99 format

2012-09-25 Thread Shubhrajyoti
On Tuesday 25 September 2012 05:39 PM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 25, 2012 at 05:01:59PM +0530, Shubhrajyoti D wrote: >> The series tries to convert the i2c_msg to c99 struct. >> This may avoid issues like below if someone tries to add a >> structure. >

Re: [PATCH v4 5/5] MFD: ti_tscadc: add suspend/resume functionality

2012-09-25 Thread Shubhrajyoti
On Wednesday 26 September 2012 10:50 AM, Patil, Rachna wrote: > This patch adds support for suspend/resume of > TSC/ADC MFDevice. this should be merged with the patch adding support else we may end up in a case where patch a does the runtime calls and the call back handlers added later. > > Signed

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-09-06 Thread Shubhrajyoti
On Thursday 06 September 2012 12:32 PM, NeilBrown wrote: > From: NeilBrown > Subject: [PATCH] OMAP GPIO - don't wake from suspend unless requested. > > Current kernel will wake from suspend on an event on any active > GPIO even if enable_irq_wake() wasn't called. > > There are two reasons that the

Re: [PATCH] spi: omap2-mcspi: Fix the error handling in probe

2012-08-02 Thread Shubhrajyoti
On Wednesday 01 August 2012 08:37 PM, Guenter Roeck wrote: > On Wed, Aug 01, 2012 at 03:06:28PM +0530, Shubhrajyoti D wrote: >> The kfree() is taken care of by the spi core (spi_master_release() function) >> that is called once the last reference to the underlying struct dev

Re: [PATCH 2/3] spi: omap2-mcspi: Remove the macro MOD_REG_BIT

2012-08-21 Thread Shubhrajyoti
Hi Felipe, Thanks for the review On Tuesday 21 August 2012 02:35 PM, Felipe Balbi wrote: > On Tue, Aug 21, 2012 at 11:47:43AM +0530, Shubhrajyoti D wrote: >> Remove the macro MOD_REG_BIT instead make the bit field modifications >> directly. This deletes a branch operation in case

Re: [PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support

2012-09-17 Thread Shubhrajyoti
eview. Acked-by: Shubhrajyoti D > drivers/spi/spi-omap2-mcspi.c |8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > index b2fb141..9502566 100644 > --- a/drivers/spi/spi-omap2-mcspi.c > +++ b/drivers/sp

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti
On Tuesday 18 September 2012 07:15 AM, Ryan Mallon wrote: >> , > Putting the whole initialiser on one line is a bit ugly. Any reason not > to expand it over multiple lines as the previous patch (and majority of > other drivers) does? Will do that. -- To unsubscribe from this list: sen

Re: [PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti
On Tuesday 18 September 2012 07:21 AM, Ryan Mallon wrote: > Actually, I wonder if it is useful to have something like:. Read and write differ only in the flag also it will be a deviation from what $SUBJECT would warrant. So could be a separate patch. > > #define I2C_WRITE(_addr, _buf, _len)

Re: [PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti
On Tuesday 18 September 2012 07:14 AM, Ryan Mallon wrote: > On 17/09/12 23:58, Shubhrajyoti D wrote: >> Convert the struct i2c_msg initialization to C99 format. This makes >> maintaining and editing the code simpler. Also helps once other fields >> like transferre

Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support

2012-09-18 Thread Shubhrajyoti
On Tuesday 18 September 2012 05:31 PM, Matt Porter wrote: > Adds pinctrl support to support OMAP platforms that boot from DT > and rely on pinctrl support to set pinmuxes. looks good Acked-by: Shubhrajyoti D > Signed-off-by: Matt Porter > --- > drivers/spi/spi-omap2

Re: [PATCHv3 5/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti
On Tuesday 18 September 2012 05:12 PM, Felipe Balbi wrote: > On Tue, Sep 18, 2012 at 05:14:31PM +0530, Shubhrajyoti D wrote: >> > Convert the struct i2c_msg initialization to C99 format. This makes >> > maintaining and editing the code simpler. Also helps on

Re: [PATCH 2/3] OMAP i2c: pinctrl-ify i2c-omap.c

2012-09-19 Thread Shubhrajyoti
On Wednesday 19 September 2012 09:37 PM, Pantelis Antoniou wrote: > #include > +#include > +#include err.h include may be removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH] mfd: Convert struct i2c_msg initialization to C99 format

2012-09-19 Thread Shubhrajyoti
On Wednesday 19 September 2012 04:58 PM, Samuel Ortiz wrote: >> drivers/mfd/88pm860x-i2c.c | 14 -- >> > 1 files changed, 12 insertions(+), 2 deletions(-) > Patch applied, thanks. thanks. > > Cheers, > Samuel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH] spi: omap2-mcspi: In case of dma errors fall back to pio

2012-08-07 Thread Shubhrajyoti
On Tuesday 07 August 2012 01:17 PM, Tony Lindgren wrote: >> }; > Don't you need to check separately for rx and tx dma? There's a slight > chance that you get a channel for one but not for the other.. In that case I treat it as non usable and fall back to pio. Are you suggesting that let one chann

Re: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver

2012-10-01 Thread Shubhrajyoti
On Monday 01 October 2012 04:31 PM, Sourav Poddar wrote: > +smsc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct smsc *smsc = dev_get_drvdata(pdev->dev.parent); > + struct input_dev *input; > + struct smsc_keypad *kp; > + int ret = 0, err

Re: spi/omap2: mark omap2_mcspi_master_setup as __devinit

2012-07-19 Thread Shubhrajyoti
annotation. > > The fix is obviously to mark the omap2_mcspi_master_setup function as > __devinit, rather than __init. Acked-by: Shubhrajyoti D mailto:shubhrajy...@ti.com>> Thanks for the patch. Apologies for breaking in one my patch series. > > Signed-off-by: Arnd Bergmann

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti D
t; to "foo *bar"] warn for the rx and tx variables. Only a cleanup no functional change. Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 256 +++-- 1 files changed, 144 insertions(+), 112 deletions(-) diff --git a/drivers/spi

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti D
t; to "foo *bar"] warn for the rx and tx variables. Only a cleanup no functional change. Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 256 +++-- 1 files changed, 144 insertions(+), 112 deletions(-) diff --git a/drivers/spi

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-10 Thread Shubhrajyoti D
t; to "foo *bar"] warn for the rx and tx variables. Only a cleanup no functional change. Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 256 +++-- 1 files changed, 144 insertions(+), 112 deletions(-) diff --git a/drivers/spi

[PATCH] ARM: OMAP: rx51: Fix a section mismatch warn

2012-09-12 Thread Shubhrajyoti D
, *_sht, *_ops, *_probe, *_probe_one, *_console Reported-by: Wolfram Sang Signed-off-by: Shubhrajyoti D --- arch/arm/mach-omap2/board-rx51-peripherals.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-02 Thread Shubhrajyoti Datta
On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires wrote: > From: Benjamin Tissoires > > Microsoft published the protocol specification of HID over i2c: > http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx > > This patch introduces an implementation of this protocol. > > This

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Shubhrajyoti Datta
On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires wrote: > Hi, > > thanks also for the review. Two in the same day! I was about to send a > ping on that patch ;-) > > On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta > wrote: >> On Fri, Sep 14, 2012 at 7:11 PM, b

[PATCHv2 7/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-em3027.c | 17 ++--- 1 files changed, 14 insertions

[PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++ 1 files changed, 22

[PATCHv2 4/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. while at it also fix a checkpatch warn WARNING: sizeof rs5c->buf should be sizeof(rs5c->buf) Signed-off-by: Shubhr

[PATCHv2 2/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-x1205.c | 92 +++--- 1

[PATCHv2 5/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-pcf8563.c | 13 +++-- 1 files changed, 11 insertions(+), 2

[PATCHv2 6/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-isl1208.c | 20 1 files changed, 16

[PATCHv2 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-s35390a.c | 13 +++-- 1 files changed, 11 insertions(+), 2

[PATCHv2 0/7] rtc: convert to c99 format

2012-09-24 Thread Shubhrajyoti D
/cocci@diku.dk/msg02753.html Shubhrajyoti D (7): rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc

[PATCHv2 6/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-isl1208.c | 20 1 files changed, 16

[PATCHv2 5/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-pcf8563.c | 13 +++-- 1 files changed, 11 insertions(+), 2

[PATCHv2 7/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-em3027.c | 17 ++--- 1 files changed, 14 insertions

[PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++ 1 files changed, 22

[PATCHv2 0/7] rtc: convert to c99 format

2012-09-25 Thread Shubhrajyoti D
/cocci@diku.dk/msg02753.html Resending with Andrew Morton in cc for review as it was suggested to me. Shubhrajyoti D (7): rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99

[PATCHv2 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-s35390a.c | 13 +++-- 1 files changed, 11 insertions(+), 2

[PATCHv2 4/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. while at it also fix a checkpatch warn WARNING: sizeof rs5c->buf should be sizeof(rs5c->buf) Signed-off-by: Shubhr

[PATCHv2 2/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-x1205.c | 92 +++--- 1

[PATCHv3 7/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-em3027.c | 17 ++--- 1 files changed, 14 insertions

[PATCHv3 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++ 1 files changed, 22

[PATCHv3 5/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-pcf8563.c | 13 +++-- 1 files changed, 11 insertions(+), 2

[PATCHv3 4/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. while at it also fix a checkpatch warn WARNING: sizeof rs5c->buf should be sizeof(rs5c->buf) Signed-off-by: Shubhr

[PATCHv3 2/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-x1205.c | 92 +++--- 1

[PATCHv3 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-s35390a.c | 13 +++-- 1 files changed, 11 insertions(+), 2

[PATCHv3 0/7] rtc: convert to c99 format

2012-09-25 Thread Shubhrajyoti D
/cocci@diku.dk/msg02753.html Resending with Andrew Morton in cc for review as it was suggested to me. Fix a typo in the comments that crept in. Shubhrajyoti D (7): rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert

[PATCHv3 6/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-isl1208.c | 20 1 files changed, 16

Re: [PATCH] i2c: omap: adopt pinctrl support

2012-10-17 Thread Shubhrajyoti Datta
c.15: Driver omap_i2c requests probe deferral > [0.484466] Advanced Linux Sound Architecture Driver Initialized. > > [4.746917] omap_i2c i2c.15: bus 4 rev2.4.0 at 100 kHz > [4.755279] gpiochip_find_base: found new base at 477 > [4.761169] gpiochip_add: registered GPIOs 477 to 500 on d

[PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti D
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait for the tx to complete. Reported-and-tested-by: Sørensen, Stefan Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 39

[PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti D
The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] changed the wait_for_completion order. Move the wait so that the rx doesnot wait for the tx to complete. Reported-and-tested-by: Sørensen, Stefan Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c | 39

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 2:33 PM, Mark Brown wrote: > On Tue, Nov 06, 2012 at 02:30:19PM +0530, Shubhrajyoti D wrote: >> The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] >> changed the wait_for_completion order. Move the wait so that the >> rx doesnot wait f

Re: [PATCH] spi: omap2-mcspi: Reorder the wait_for_completion for tx

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 2:52 PM, Mark Brown wrote: > On Tue, Nov 06, 2012 at 02:47:27PM +0530, Shubhrajyoti D wrote: >> The commit d7b4394e[Cleanup the omap2_mcspi_txrx_dma function] >> changed the wait_for_completion order. Move the wait so that the >> rx doesnot wait f

[PATCH] spi: omap2-mcspi: Fix the redifine warning

2012-11-18 Thread Shubhrajyoti D
Fix the below warning drivers/spi/spi-omap2-mcspi.c:336:34: warning: symbol 'tx' shadows an earlier one drivers/spi/spi-omap2-mcspi.c:327:12: originally declared here So delete the u8 tx as it is assigned and not used(resigned afterwards). Signed-off-by: Shubhrajyoti D --- drive

[PATCH] spi: omap2-mcspi: Fix the error handling in probe

2012-08-01 Thread Shubhrajyoti D
device_put in some of the error paths. Cc: Guenter Roeck Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 7d46b15..b5035e2 100644

[PATCH] spi: omap2-mcspi: Fix the error handling in probe

2012-08-02 Thread Shubhrajyoti D
device_put in some of the error paths. Acked-by: Guenter Roeck Reported-by: Guenter Roeck Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c

[PATCHv2 2/3] spi: omap2-mcspi: Remove the macro MOD_REG_BIT

2012-08-21 Thread Shubhrajyoti D
Remove the macro MOD_REG_BIT instead make the bit field modifications directly. This deletes a branch operation in cases where the the set is predecided. While at it optimise two sequential bit clear in one step. Acked-by: Felipe Balbi Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2

[PATCHv2 0/3] spi: omap2-mcspi: spi cleanups

2012-08-21 Thread Shubhrajyoti D
commit 23dcfa61bac244e1200ff9ad19c6e9144dcb6bb5: Merge branch 'akpm' (Andrew's patch-bomb) (2012-08-21 17:22:22 -0700) are available in the git repository at: git://gitorious.org/linus-tree/linus-tree.git for_3.6/spi Shubhrajyoti D (3): spi: omap2-mcspi: Call pm_runt

[PATCHv2 3/3] spi: omap2-mcspi: At remove dont use the runtime_autosuspend calls

2012-08-21 Thread Shubhrajyoti D
At remove we shouldnt be using the autosuspend timeout as we are calling pm_runtime_disable immediately after. Acked-by: Felipe Balbi Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-omap2

[PATCHv2 1/3] spi: omap2-mcspi: Call pm_runtime_* functions directly

2012-08-21 Thread Shubhrajyoti D
Call the pm_runtime functions directly making room for possible pm optimisations. Also the runtime functions aren't just about enabling and disabling of clocks though it does enable clocks also. Acked-by: Felipe Balbi Signed-off-by: Shubhrajyoti D --- drivers/spi/spi-omap2-mcspi.c |

Re: [PATCHv2 0/3] spi: omap2-mcspi: spi cleanups

2012-08-22 Thread Shubhrajyoti Datta
On Wed, Aug 22, 2012 at 10:29 PM, Mark Brown wrote: > On Wed, Aug 22, 2012 at 11:35:11AM +0530, Shubhrajyoti D wrote: >> This patch does the following >> >> Calls the pm_runtime_* functions directly. >> Remove the MOD_REG_BIT macro usage thereby removiing un-needed br

[PATCH 7/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-x1205.c | 28

[PATCH 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++ 1 files

[PATCH 4/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-pcf8563.c |4 ++-- 1 files changed, 2

[PATCH 2/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-em3027.c |6 +++--- 1 files changed, 3 insertions

[PATCH 0/7] rtc: convert to c99 format

2012-09-17 Thread Shubhrajyoti D
://www.mail-archive.com/cocci@diku.dk/msg02753.html Shubhrajyoti D (7): rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99 format rtc: Convert struct i2c_msg initialization to C99

[PATCH 6/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-s35390a.c |4 ++-- 1 files changed, 2

[PATCH 5/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-rs5c372.c |2 +- 1 files changed, 1

[PATCH 3/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-isl1208.c |6 +++--- 1 files changed, 3 insertions

[PATCH 1/2] input: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/input/joystick/as5011.c |6 +++--- 1 files

[PATCH 2/2] input: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/input/touchscreen/cy8ctmg110_ts.c |4 ++-- 1

[PATCH 0/2] input: convert to c99 format

2012-09-17 Thread Shubhrajyoti D
://www.mail-archive.com/cocci@diku.dk/msg02753.html Checkpatch warn of more than 80 chars have been ignored. Shubhrajyoti D (2): input: Convert struct i2c_msg initialization to C99 format input: Convert struct i2c_msg initialization to C99 format drivers/input/joystick/as5011.c |6

[PATCH 2/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/msp3400-driver.c | 12 ++-- 1

[PATCH 0/6] media: input: convert to c99 format

2012-09-17 Thread Shubhrajyoti D
://www.mail-archive.com/cocci@diku.dk/msg02753.html Checkpatch warn of more than 80 chars have been ignored. Shubhrajyoti D (6): media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to C99

[PATCH 5/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/saa7706h.c |4 ++-- 1 files changed

[PATCH 6/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/si470x/radio-si470x-i2c.c | 12

[PATCH 4/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/radio-tea5764.c |6 +++--- 1 files

[PATCH 1/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/ks0127.c |4 ++-- 1 files changed, 2

[PATCH 3/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/tvaudio.c |4 ++-- 1 files changed, 2

[PATCH] mfd: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Thanks to Julia Lawall for automating the conversion Signed-off-by: Shubhrajyoti D --- drivers/mfd/88pm860x-i2c.c

[PATCH] matroxfb: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Thanks to Julia Lawall for automating the conversion Signed-off-by: Shubhrajyoti D --- the cocci file was posted

[PATCHv2 1/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/ks0127.c | 14 -- 1 files

[PATCHv2 0/6] media: convert to c99 format

2012-09-18 Thread Shubhrajyoti D
://www.mail-archive.com/cocci@diku.dk/msg02753.html Shubhrajyoti D (6): media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to

[PATCHv2 5/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/saa7706h.c | 16 ++-- 1

[PATCHv2 6/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/msp3400-driver.c | 42

[PATCHv2 3/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/radio-tea5764.c | 14 +++--- 1

[PATCHv2 4/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/si470x/radio-si470x-i2c.c | 24

[PATCHv2 2/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/tvaudio.c | 14 -- 1 files

Re: [PATCHv2 6/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti Datta
On Tue, Sep 18, 2012 at 3:26 PM, Venu Byravarasu wrote: >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Shubhrajyoti D >> Sent: Tuesday, September 18, 2012 3:21 PM >> To: lin

[PATCHv3 0/6] media: convert to c99 format

2012-09-18 Thread Shubhrajyoti D
://www.mail-archive.com/cocci@diku.dk/msg02753.html Changelogs - Remove the zero inititialisation of the flags. Shubhrajyoti D (6): media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to C99 format media: Convert struct i2c_msg initialization to

[PATCHv3 5/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/radio/saa7706h.c | 15 +-- 1

[PATCHv3 2/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/tvaudio.c | 13 +++-- 1 files

[PATCHv3 4/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-18 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/media/i2c/msp3400-driver.c | 40

  1   2   3   >