Re: [v2 PATCH] arm64: replace read_lock to rcu lock in call_break_hook

2015-10-05 Thread Shi, Yang
On 10/1/2015 3:15 PM, Shi, Yang wrote: On 10/1/2015 2:27 PM, Paul E. McKenney wrote: On Thu, Oct 01, 2015 at 01:53:51PM -0700, Shi, Yang wrote: On 10/1/2015 10:08 AM, Steven Rostedt wrote: On Thu, 1 Oct 2015 09:37:37 -0700 Yang Shi wrote: BUG: sleeping function called from invalid context

Re: [PATCH] arm64: replace read_lock to rcu lock in call_break_hook

2015-10-01 Thread Shi, Yang
On 10/1/2015 8:07 AM, Catalin Marinas wrote: On Wed, Sep 30, 2015 at 03:59:04PM -0700, Yang Shi wrote: diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c index cebf786..eb520d0 100644 --- a/arch/arm64/kernel/debug-monitors.c +++ b/arch/arm64/kernel/debug-monito

Re: [v2 PATCH] arm64: replace read_lock to rcu lock in call_break_hook

2015-10-01 Thread Shi, Yang
On 10/1/2015 10:08 AM, Steven Rostedt wrote: On Thu, 1 Oct 2015 09:37:37 -0700 Yang Shi wrote: BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:917 in_atomic(): 0, irqs_disabled(): 128, pid: 342, name: perf 1 lock held by perf/342: #0: (break_hook_lock){+.+..

Re: [v2 PATCH] arm64: replace read_lock to rcu lock in call_break_hook

2015-10-01 Thread Shi, Yang
On 10/1/2015 2:27 PM, Paul E. McKenney wrote: On Thu, Oct 01, 2015 at 01:53:51PM -0700, Shi, Yang wrote: On 10/1/2015 10:08 AM, Steven Rostedt wrote: On Thu, 1 Oct 2015 09:37:37 -0700 Yang Shi wrote: BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:917

Re: [PATCH] perf: change samples type to unsigned long long

2015-10-02 Thread Shi, Yang
On 10/2/2015 12:10 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 02, 2015 at 04:08:38PM -0300, Arnaldo Carvalho de Melo escreveu: Em Tue, Sep 29, 2015 at 02:49:43PM -0700, Yang Shi escreveu: When run "perf record -e", the number of samples showed up is wrong on some 32 bit systems, i.e. power

Re: [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP

2016-04-14 Thread Shi, Yang
On 4/14/2016 1:47 AM, Will Deacon wrote: On Wed, Apr 13, 2016 at 05:54:12PM -0700, Yang Shi wrote: SCHED_MC and SCHED_SMT are pointless when SMP is disabled. Although SMP is rarely disabled for ARM64, it looks more consistent to have such depend in Kconfig. You can't disable CONFIG_SMP for arm

Re: [PATCH] locktorture: make verbose writable and control stats print

2016-04-15 Thread Shi, Yang
On 4/15/2016 4:26 PM, Paul E. McKenney wrote: On Fri, Apr 15, 2016 at 01:28:11PM -0700, Yang Shi wrote: When building locktorture test into kernel image, it keeps printing out stats information even though there is no lock type specified. There is already verbose parameter to control print, but

Re: [PATCH] locktorture: make verbose writable and control stats print

2016-04-15 Thread Shi, Yang
On 4/15/2016 5:09 PM, Paul E. McKenney wrote: On Fri, Apr 15, 2016 at 04:45:32PM -0700, Shi, Yang wrote: On 4/15/2016 4:26 PM, Paul E. McKenney wrote: On Fri, Apr 15, 2016 at 01:28:11PM -0700, Yang Shi wrote: When building locktorture test into kernel image, it keeps printing out stats

Re: [BUG linux-next] Kernel panic found with linux-next-20160414

2016-04-28 Thread Shi, Yang
On 4/27/2016 1:14 AM, Hugh Dickins wrote: On Wed, 20 Apr 2016, Shi, Yang wrote: On 4/20/2016 1:01 AM, Hugh Dickins wrote: On Tue, 19 Apr 2016, Shi, Yang wrote: Hi folks, When I ran ltp on linux-next-20160414 on my ARM64 machine, I got the below kernel panic: Unable to handle kernel paging

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-29 Thread Shi, Yang
On 4/22/2016 2:48 AM, Kirill A. Shutemov wrote: On Thu, Apr 21, 2016 at 03:56:07PM -0700, Shi, Yang wrote: On 4/21/2016 12:30 AM, Kirill A. Shutemov wrote: On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote: Hi folks, I didn't realize pmd_* functions are protect

[BUG] Null pointer dereference when freeing pages on 4.6-rc6

2016-05-05 Thread Shi, Yang
Hi folks, When I enable the below kernel configs on 4.6-rc6, I came across null pointer deference issue in boot stage. CONFIG_SPARSEMEM CONFIG_DEFERRED_STRUCT_PAGE_INIT CONFIG_DEBUG_PAGEALLOC CONFIG_PAGE_EXTENSION CONFIG_DEBUG_VM The splat is: BUG: unable to handle kernel NULL pointer deref

Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG

2016-05-09 Thread Shi, Yang
On 5/5/2016 4:49 AM, Michal Hocko wrote: On Wed 04-05-16 10:01:37, Yang Shi wrote: Now we have IS_ENABLED helper to check if a Kconfig option is enabled or not, so ZONE_DMA_FLAG sounds no longer useful. And, the use of ZONE_DMA_FLAG in slab looks pointless according to the comment [1] from Joha

Re: [v2 PATCH] mm: move page_ext_init after all struct pages are initialized

2016-05-20 Thread Shi, Yang
On 5/20/2016 6:16 AM, Michal Hocko wrote: On Thu 19-05-16 15:13:26, Yang Shi wrote: [...] diff --git a/init/main.c b/init/main.c index b3c6e36..2075faf 100644 --- a/init/main.c +++ b/init/main.c @@ -606,7 +606,6 @@ asmlinkage __visible void __init start_kernel(void) initrd_start

Re: [PATCH] mm: page_is_guard return false when page_ext arrays are not allocated yet

2016-05-20 Thread Shi, Yang
On 5/19/2016 7:40 PM, Joonsoo Kim wrote: 2016-05-20 2:18 GMT+09:00 Shi, Yang : On 5/18/2016 5:28 PM, Joonsoo Kim wrote: Vlastiml, thanks for ccing me on original bug report. On Wed, May 18, 2016 at 03:23:45PM -0700, Yang Shi wrote: When enabling the below kernel configs

Re: [v2 PATCH] mm: move page_ext_init after all struct pages are initialized

2016-05-23 Thread Shi, Yang
On 5/23/2016 12:31 AM, Michal Hocko wrote: On Fri 20-05-16 08:41:09, Shi, Yang wrote: On 5/20/2016 6:16 AM, Michal Hocko wrote: On Thu 19-05-16 15:13:26, Yang Shi wrote: [...] diff --git a/init/main.c b/init/main.c index b3c6e36..2075faf 100644 --- a/init/main.c +++ b/init/main.c @@ -606,7

Re: [PATCH] mm: make CONFIG_DEFERRED_STRUCT_PAGE_INIT depends on !FLATMEM explicitly

2016-05-23 Thread Shi, Yang
On 5/23/2016 11:22 AM, Michal Hocko wrote: On Mon 23-05-16 09:54:31, Yang Shi wrote: Per the suggestion from Michal Hocko [1], CONFIG_DEFERRED_STRUCT_PAGE_INIT should be incompatible with FLATMEM, make this explicitly in Kconfig. I guess the changelog could benefit from some clarification. Wha

Re: [PATCH] mm: fix build problems from lookup_page_ext

2016-05-24 Thread Shi, Yang
Hi Arnd, Thanks a lot for the patch. My bad, sorry for the inconvenience. I omitted the specific page_idle change is for 32 bit only. And, my host compiler looks old which is still 4.8 so it might not catch the warning. I will update my compiler. Regards, Yang On 5/24/2016 3:08 AM, Arnd B

Re: [PATCH] mm: page_is_guard return false when page_ext arrays are not allocated yet

2016-05-24 Thread Shi, Yang
On 5/23/2016 10:37 PM, Joonsoo Kim wrote: On Fri, May 20, 2016 at 10:00:06AM -0700, Shi, Yang wrote: On 5/19/2016 7:40 PM, Joonsoo Kim wrote: 2016-05-20 2:18 GMT+09:00 Shi, Yang : On 5/18/2016 5:28 PM, Joonsoo Kim wrote: Vlastiml, thanks for ccing me on original bug report. On Wed, May 18

Re: [BUG] Null pointer dereference when freeing pages on 4.6-rc6

2016-05-18 Thread Shi, Yang
On 5/16/2016 5:44 AM, Vlastimil Babka wrote: [+CC Joonsoo based on git blame] On 05/05/2016 11:13 PM, Shi, Yang wrote: Hi folks, When I enable the below kernel configs on 4.6-rc6, I came across null pointer deference issue in boot stage. CONFIG_SPARSEMEM CONFIG_DEFERRED_STRUCT_PAGE_INIT

Re: [PATCH] mm: page_is_guard return false when page_ext arrays are not allocated yet

2016-05-19 Thread Shi, Yang
On 5/18/2016 5:28 PM, Joonsoo Kim wrote: Vlastiml, thanks for ccing me on original bug report. On Wed, May 18, 2016 at 03:23:45PM -0700, Yang Shi wrote: When enabling the below kernel configs: CONFIG_DEFERRED_STRUCT_PAGE_INIT CONFIG_DEBUG_PAGEALLOC CONFIG_PAGE_EXTENSION CONFIG_DEBUG_VM kernel

Re: [PATCH] mm: move page_ext_init after all struct pages are initialized

2016-05-19 Thread Shi, Yang
On 5/19/2016 3:30 PM, Andrew Morton wrote: On Thu, 19 May 2016 14:29:05 -0700 Yang Shi wrote: When DEFERRED_STRUCT_PAGE_INIT is enabled, just a subset of memmap at boot are initialized, then the rest are initialized in parallel by starting one-off "pgdatinitX" kernel thread for each node X. I

Re: [PATCH] mm: move page_ext_init after all struct pages are initialized

2016-05-19 Thread Shi, Yang
On 5/19/2016 4:21 PM, Andrew Morton wrote: On Thu, 19 May 2016 15:35:15 -0700 "Shi, Yang" wrote: On 5/19/2016 3:30 PM, Andrew Morton wrote: On Thu, 19 May 2016 14:29:05 -0700 Yang Shi wrote: When DEFERRED_STRUCT_PAGE_INIT is enabled, just a subset of memmap at boot are initial

Re: [PATCH] Fixing compilation error from file include/linux/page_idle.h

2016-05-25 Thread Shi, Yang
On 5/25/2016 3:11 AM, shakilk1...@gmail.com wrote: From: shakil khan Thanks for the patch, this issue had been fixed by Arnd. Yang --- include/linux/page_idle.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/page_idle.h b/include/linux/page_

Re: [PATCH] mm: use early_pfn_to_nid in register_page_bootmem_info_node

2016-05-25 Thread Shi, Yang
On 5/25/2016 3:23 PM, Andrew Morton wrote: On Wed, 25 May 2016 14:00:07 -0700 Yang Shi wrote: register_page_bootmem_info_node() is invoked in mem_init(), so it will be called before page_alloc_init_late() if CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. But, pfn_to_nid() depends on memmap which

Re: [PATCH] mm: check the return value of lookup_page_ext for all call sites

2016-05-26 Thread Shi, Yang
On 5/25/2016 5:37 PM, Minchan Kim wrote: On Tue, May 24, 2016 at 11:58:11AM +0900, Minchan Kim wrote: On Mon, May 23, 2016 at 10:16:08AM -0700, Yang Shi wrote: Per the discussion with Joonsoo Kim [1], we need check the return value of lookup_page_ext() for all call sites since it might return N

Re: [PATCH] arm64: kasan: instrument user memory access API

2016-05-27 Thread Shi, Yang
On 5/27/2016 4:02 AM, Andrey Ryabinin wrote: On 05/26/2016 09:43 PM, Yang Shi wrote: The upstream commit 1771c6e1a567ea0ba20a4ffe68a1419fd8ef ("x86/kasan: instrument user memory access API") added KASAN instrument to x86 user memory access API, so added such instrument to ARM64 too. Teste

Re: [PATCH] arm64: kasan: instrument user memory access API

2016-05-27 Thread Shi, Yang
On 5/27/2016 10:46 AM, Mark Rutland wrote: On Fri, May 27, 2016 at 09:34:03AM -0700, Shi, Yang wrote: On 5/27/2016 4:02 AM, Andrey Ryabinin wrote: On 05/26/2016 09:43 PM, Yang Shi wrote: The upstream commit 1771c6e1a567ea0ba20a4ffe68a1419fd8ef ("x86/kasan: instrument user memory a

Re: [PATCH] mm: check the return value of lookup_page_ext for all call sites

2016-05-27 Thread Shi, Yang
On 5/27/2016 1:11 AM, Minchan Kim wrote: On Fri, May 27, 2016 at 03:08:39PM +0900, Joonsoo Kim wrote: On Fri, May 27, 2016 at 02:14:32PM +0900, Minchan Kim wrote: On Thu, May 26, 2016 at 04:15:28PM -0700, Shi, Yang wrote: On 5/25/2016 5:37 PM, Minchan Kim wrote: On Tue, May 24, 2016 at 11:58

Re: [PATCH] mm: check the return value of lookup_page_ext for all call sites

2016-05-27 Thread Shi, Yang
On 5/27/2016 1:02 PM, Andrew Morton wrote: On Thu, 26 May 2016 16:15:28 -0700 "Shi, Yang" wrote: I hope we consider this direction, too. Yang, Could you think about this? Thanks a lot for the suggestion. Sorry for the late reply, I was busy on preparing patches. I do agree

Re: [BUG linux-next] kernel NULL pointer dereference on linux-next-20160420

2016-04-26 Thread Shi, Yang
Did some preliminary investigation on this one. The problem is the cc->freepages list is empty, but cc->nr_freepages > 0, it looks the list and nr_freepages get out-of-sync somewhere. Any hint is appreciated. Thanks, Yang On 4/21/2016 5:38 PM, Shi, Yang wrote: Hi folks, I did

Re: [BUG] set_pte_at: racy dirty state clearing warning

2016-04-27 Thread Shi, Yang
On 4/21/2016 1:49 AM, Catalin Marinas wrote: On Wed, Apr 20, 2016 at 04:01:39PM -0700, Shi, Yang wrote: When I enable memory comact via # echo 1 > /proc/sys/vm/compact_memory I got the below WARNING: set_pte_at: racy dirty state clearing: 0x006899371bd3 -> 0x006899

Re: [PATCH net-next] bpf: arm64: remove callee-save registers use for tmp registers

2016-05-16 Thread Shi, Yang
On 5/16/2016 4:45 PM, Z Lim wrote: Hi Yang, On Mon, May 16, 2016 at 4:09 PM, Yang Shi wrote: In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for tmp registers, which are callee-saved registers. This leads to variable size of JIT prologue and epilogue. The latest blinding

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-12 Thread Shi, Yang
On 11/11/2015 4:39 AM, Will Deacon wrote: On Wed, Nov 11, 2015 at 12:12:56PM +, Will Deacon wrote: On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote: On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: aarch64 doesn't have native store immediate instruction, such operation Actually, aa

Re: [PATCH 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

2015-11-13 Thread Shi, Yang
On 11/12/2015 7:28 PM, Z Lim wrote: On Thu, Nov 12, 2015 at 1:57 PM, Yang Shi wrote: Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP in prologue in order to get the correct stack backtrace. However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to change

Re: [PATCH] arm64: reenable interrupt when handling ptrace breakpoint

2015-12-16 Thread Shi, Yang
On 12/16/2015 3:13 AM, Will Deacon wrote: On Tue, Dec 15, 2015 at 04:18:08PM -0800, Yang Shi wrote: The kernel just send out a SIGTRAP signal when handling ptrace breakpoint in debug exception, so it sounds safe to have interrupt enabled if it is not disabled by the parent process. Is this act

Re: [PATCH] writeback: initialize m_dirty to avoid compile warning

2015-11-18 Thread Shi, Yang
On 11/18/2015 1:53 AM, Arnd Bergmann wrote: On Tuesday 17 November 2015 15:38:55 Andrew Morton wrote: On Fri, 13 Nov 2015 10:26:41 -0800 Yang Shi wrote: When building kernel with gcc 5.2, the below warning is raised: mm/page-writeback.c: In function 'balance_dirty_pages.isra.10': mm/page-wri

Re: [PATCH] writeback: initialize m_dirty to avoid compile warning

2015-11-18 Thread Shi, Yang
On 11/18/2015 10:11 AM, Tejun Heo wrote: Hello, On Tue, Nov 17, 2015 at 03:38:55PM -0800, Andrew Morton wrote: --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1542,7 +1542,7 @@ static void balance_dirty_pages(struct address_space *mapping, for (;;) { unsigned lo

Re: [PATCH] writeback: initialize m_dirty to avoid compile warning

2015-11-18 Thread Shi, Yang
On 11/18/2015 10:33 AM, Tejun Heo wrote: Hello, On Wed, Nov 18, 2015 at 10:27:32AM -0800, Shi, Yang wrote: This was the main reason the code was structured the way it is. If cgroup writeback is not enabled, any derefs of mdtc variables should trigger warnings. Ugh... I don't know. Com

Re: [PATCH] arm64: restore bogomips information in /proc/cpuinfo

2015-11-18 Thread Shi, Yang
On 11/18/2015 10:47 AM, Will Deacon wrote: Hello, On Wed, Nov 18, 2015 at 10:15:05AM -0800, Yang Shi wrote: As what Pavel Machek reported [1], some userspace applications depend on bogomips showed by /proc/cpuinfo. Although there is much less legacy impact on aarch64 than arm, but it does brea

Re: [PATCH] writeback: initialize m_dirty to avoid compile warning

2015-11-18 Thread Shi, Yang
On 11/18/2015 10:55 AM, Andrew Morton wrote: On Wed, 18 Nov 2015 10:39:23 -0800 "Shi, Yang" wrote: On 11/18/2015 10:33 AM, Tejun Heo wrote: Hello, On Wed, Nov 18, 2015 at 10:27:32AM -0800, Shi, Yang wrote: This was the main reason the code was structured the way it is. If cgroup

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Shi, Yang
On 11/18/2015 12:56 AM, Zi Shen Lim wrote: During code review, I noticed we were passing a bad buffer pointer to bpf_load_pointer helper function called by jitted code. Point to the buffer allocated by JIT, so we don't silently corrupt other parts of the stack. Signed-off-by: Zi Shen Lim ---

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Shi, Yang
On 11/18/2015 1:41 PM, Z Lim wrote: On Wed, Nov 18, 2015 at 1:07 PM, Shi, Yang wrote: On 11/18/2015 12:56 AM, Zi Shen Lim wrote: emit_a64_mov_i64(r3, size, ctx); - emit(A64_ADD_I(1, r4, fp, MAX_BPF_STACK), ctx); + emit(A64_SUB_I(1, r4, fp

Re: [V2 PATCH] arm64: restore bogomips information in /proc/cpuinfo

2015-11-19 Thread Shi, Yang
On 11/19/2015 9:59 AM, Catalin Marinas wrote: On Wed, Nov 18, 2015 at 10:48:55AM -0800, Yang Shi wrote: As what Pavel Machek reported [1], some userspace applications depend on bogomips showed by /proc/cpuinfo. Although there is much less legacy impact on aarch64 than arm, but it does break lib

Re: [RESEND PATCH] arm64: bpf: add 'store immediate' instruction

2015-12-01 Thread Shi, Yang
On 11/30/2015 2:24 PM, Yang Shi wrote: aarch64 doesn't have native store immediate instruction, such operation has to be implemented by the below instruction sequence: Load immediate to register Store register Signed-off-by: Yang Shi CC: Zi Shen Lim Had email exchange offline with Zi Shen L

Re: [PATCH 1/7] trace/events: Add gup trace events

2015-12-01 Thread Shi, Yang
On 12/1/2015 3:56 PM, Steven Rostedt wrote: On Tue, 1 Dec 2015 15:06:11 -0800 Yang Shi wrote: page-faults events record the invoke to handle_mm_fault, but the invoke may come from do_page_fault or gup. In some use cases, the finer event count mey be needed, so add trace events support for: _

Re: [PATCH 1/7] trace/events: Add gup trace events

2015-12-01 Thread Shi, Yang
On 12/1/2015 4:18 PM, Steven Rostedt wrote: On Tue, 01 Dec 2015 16:07:44 -0800 "Shi, Yang" wrote: On 12/1/2015 3:56 PM, Steven Rostedt wrote: On Tue, 1 Dec 2015 15:06:11 -0800 Yang Shi wrote: page-faults events record the invoke to handle_mm_fault, but the invoke may

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-02 Thread Shi, Yang
On 12/2/2015 3:36 PM, Dave Hansen wrote: On 12/02/2015 02:53 PM, Yang Shi wrote: diff --git a/mm/gup.c b/mm/gup.c index deafa2c..10245a4 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRACE_POINTS +#include + #include #include This needs

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-02 Thread Shi, Yang
On 12/2/2015 4:11 PM, Shi, Yang wrote: On 12/2/2015 3:36 PM, Dave Hansen wrote: On 12/02/2015 02:53 PM, Yang Shi wrote: diff --git a/mm/gup.c b/mm/gup.c index deafa2c..10245a4 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRACE_POINTS +#include

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-03 Thread Shi, Yang
On 12/2/2015 8:13 PM, Steven Rostedt wrote: On Wed, 2 Dec 2015 15:36:50 -0800 Dave Hansen wrote: On 12/02/2015 02:53 PM, Yang Shi wrote: diff --git a/mm/gup.c b/mm/gup.c index deafa2c..10245a4 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -13,6 +13,9 @@ #include #include +#define CREATE_TRAC

Re: [PATCH V2 1/7] trace/events: Add gup trace events

2015-12-03 Thread Shi, Yang
On 12/2/2015 8:07 PM, Steven Rostedt wrote: On Wed, 2 Dec 2015 14:53:27 -0800 Yang Shi wrote: page-faults events record the invoke to handle_mm_fault, but the invoke may come from do_page_fault or gup. In some use cases, the finer event count mey be needed, so add trace events support for: _

Re: [PATCH V2 2/7] mm/gup: add gup trace points

2015-12-03 Thread Shi, Yang
On 12/3/2015 11:06 AM, Steven Rostedt wrote: On Thu, 03 Dec 2015 10:36:18 -0800 "Shi, Yang" wrote: called directly that calls these functions internally and the tracepoint can trap the return value. This will incur more changes in other subsystems (futex, kvm, etc), I'm no

Re: [V2 PATCH] sparc64/gup: check address scope legitimacy

2015-12-03 Thread Shi, Yang
On 12/3/2015 12:38 PM, Sam Ravnborg wrote: Hi Yang. On Wed, Nov 25, 2015 at 02:45:43PM -0800, Yang Shi wrote: Check if user address is accessible in atomic version __get_user_pages_fast() before walking the page table. And, check if end > start in get_user_pages_fast(), otherwise fallback to sl

Re: [PATCH] arm64: add HAVE_LATENCYTOP_SUPPORT config

2015-12-14 Thread Shi, Yang
Hi folks, I tried to enable latencytop for arm64 and came across this discussion, so any plan about when this will get merged into mainline? 4.5 merge window? Thanks, Yang On 11/10/2015 3:34 AM, Heiko Carstens wrote: From: Will Deacon Date: Tue, 10 Nov 2015 11:10:04 + Subject: [PATCH]

Re: [PATCH] arm64: restore bogomips information in /proc/cpuinfo

2015-11-25 Thread Shi, Yang
On 11/25/2015 7:16 AM, Nicolas Pitre wrote: On Wed, 25 Nov 2015, Jon Masters wrote: On 11/18/15, 1:15 PM, Yang Shi wrote: As what Pavel Machek reported [1], some userspace applications depend on bogomips showed by /proc/cpuinfo. Although there is much less legacy impact on aarch64 than arm,

Re: [PATCH] sparc64/gup: check address scope legitimacy

2015-11-25 Thread Shi, Yang
On 11/25/2015 4:26 PM, kbuild test robot wrote: Hi Yang, [auto build test ERROR on v4.4-rc2] [also build test ERROR on next-20151124] url: https://github.com/0day-ci/linux/commits/Yang-Shi/sparc64-gup-check-address-scope-legitimacy/20151126-065342 config: sparc64-allnoconfig (attached as .c

Re: [PATCH v3 2/7] mm/gup: add gup trace points

2015-12-08 Thread Shi, Yang
On 12/8/2015 12:25 PM, Steven Rostedt wrote: On Tue, 8 Dec 2015 11:39:50 -0800 Yang Shi wrote: For slow version, just add trace point for raw __get_user_pages since all slow variants call it to do the real work finally. Signed-off-by: Yang Shi --- mm/gup.c | 8 1 file changed, 8

Re: [PATCH v4 3/7] x86: mm/gup: add gup trace points

2015-12-09 Thread Shi, Yang
On 12/9/2015 1:07 PM, Steven Rostedt wrote: On Wed, 9 Dec 2015 09:29:20 -0800 Yang Shi wrote: Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Signed-off-by: Yang Shi --- arch/x86/mm/gup.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/m

Re: [PATCH] ppc64: select HAVE_CONTEXT_TRACKING by default

2016-01-04 Thread Shi, Yang
Hi folks, Any comment on this is appreciated. Thanks, Yang On 12/9/2015 2:43 PM, Yang Shi wrote: The functionality of context tracking has been implemented by PPC64 and HAVE_CONTEXT_TRACKING was selected by pseries by default. Actually, it is applicale to all PPC64 platforms, so select it in

Re: [PATCH] arm64: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

2016-02-08 Thread Shi, Yang
On 2/8/2016 3:46 AM, Mark Rutland wrote: Hi, On Fri, Feb 05, 2016 at 03:50:18PM -0800, Yang Shi wrote: To enable UBSAN on arm64, ARCH_HAS_UBSAN_SANITIZE_ALL need to be selected. Basic kernel bootup test is passed on arm64 with CONFIG_UBSAN_SANITIZE_ALL enabled. Signed-off-by: Yang Shi ---

Re: [PATCH] arm64: disable kasan when accessing frame->fp in unwind_frame

2016-02-08 Thread Shi, Yang
On 2/8/2016 12:51 AM, Andrey Ryabinin wrote: On 02/06/2016 02:04 AM, Yang Shi wrote: #include #include @@ -64,7 +65,9 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame) return -EINVAL; frame->sp = fp + 0x10; + kasan_disable_cur

Re: [RFC V5] Add gup trace points support

2016-02-08 Thread Shi, Yang
. -- Steve On Wed, 13 Jan 2016 10:14:24 -0800 "Shi, Yang" wrote: On 1/12/2016 12:10 PM, Steven Rostedt wrote: On Tue, 12 Jan 2016 12:00:54 -0800 "Shi, Yang" wrote: Hi Steven, Any more comments on this series? How should I proceed it? The tracing part looks fine to me. Now

Re: [PATCH v2] arm64: disable kasan when accessing frame->fp in unwind_frame

2016-02-09 Thread Shi, Yang
On 2/9/2016 8:54 AM, Will Deacon wrote: On Mon, Feb 08, 2016 at 09:13:09AM -0800, Yang Shi wrote: When boot arm64 kernel with KASAN enabled, the below error is reported by kasan: BUG: KASAN: out-of-bounds in unwind_frame+0xec/0x260 at addr ffc064d57ba0 Read of size 8 by task pidof/499 page:

Re: [PATCH v2] arm64: disable kasan when accessing frame->fp in unwind_frame

2016-02-09 Thread Shi, Yang
On 2/9/2016 9:23 AM, Will Deacon wrote: On Tue, Feb 09, 2016 at 09:17:12AM -0800, Shi, Yang wrote: On 2/9/2016 8:54 AM, Will Deacon wrote: On Mon, Feb 08, 2016 at 09:13:09AM -0800, Yang Shi wrote: When boot arm64 kernel with KASAN enabled, the below error is reported by kasan: BUG: KASAN

Re: [PATCH v2] arm64: disable kasan when accessing frame->fp in unwind_frame

2016-02-09 Thread Shi, Yang
On 2/9/2016 9:31 AM, Shi, Yang wrote: On 2/9/2016 9:23 AM, Will Deacon wrote: On Tue, Feb 09, 2016 at 09:17:12AM -0800, Shi, Yang wrote: On 2/9/2016 8:54 AM, Will Deacon wrote: On Mon, Feb 08, 2016 at 09:13:09AM -0800, Yang Shi wrote: When boot arm64 kernel with KASAN enabled, the below

Very low responsiveness for pstore ftrace

2016-02-09 Thread Shi, Yang
Hi folks, I'm newbie to pstore. I just did a quick try for pstore ftrace. But, I experience very serious responsiveness problem. When running "echo 1 > /sys/kernel/debug/pstore/record_ftrace", it took a couple of minutes to return (here return means to get prompt back) on my arm64 machine (8 A

Re: [PATCH] scsi: fdomain: add missing CONFIG_ to PCMCIA

2016-02-09 Thread Shi, Yang
On 2/9/2016 3:25 PM, One Thousand Gnomes wrote: On Tue, 9 Feb 2016 14:16:49 -0800 Yang Shi wrote: There are some "#ifdef PCMCIA" in the driver code, but all of them missed CONFIG_ prefix. Correct PCMCIA to CONFIG_PCMCIA. Signed-off-by: Yang Shi NAK. This breaks the driver completely Rea

Re: [RFC PATCH] kernfs: create raw version kernfs_path_len and kernfs_path

2016-02-26 Thread Shi, Yang
On 2/26/2016 10:56 AM, Steven Rostedt wrote: On Fri, 26 Feb 2016 10:15:05 -0800 Yang Shi wrote: commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback tracepoints to report cgroup") made writeback tracepoints report cgroup writeback, but it may trigger the below bug on -

Re: [RFC PATCH] kernfs: create raw version kernfs_path_len and kernfs_path

2016-02-26 Thread Shi, Yang
On 2/26/2016 11:37 AM, Shi, Yang wrote: On 2/26/2016 10:56 AM, Steven Rostedt wrote: On Fri, 26 Feb 2016 10:15:05 -0800 Yang Shi wrote: commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback tracepoints to report cgroup") made writeback tracepoints rep

Re: [RFC PATCH] kernfs: create raw version kernfs_path_len and kernfs_path

2016-02-26 Thread Shi, Yang
On 2/26/2016 11:59 AM, Shi, Yang wrote: On 2/26/2016 11:37 AM, Shi, Yang wrote: On 2/26/2016 10:56 AM, Steven Rostedt wrote: On Fri, 26 Feb 2016 10:15:05 -0800 Yang Shi wrote: commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback tracepoints to report cgroup&q

Re: [RFC PATCH] kernfs: create raw version kernfs_path_len and kernfs_path

2016-02-26 Thread Shi, Yang
On 2/26/2016 12:15 PM, Steven Rostedt wrote: On Fri, 26 Feb 2016 11:59:40 -0800 "Shi, Yang" wrote: BTW, it sounds this is not the only point where kernfs_node could be updated, __kernfs_remove should need synchronize_sched too. Question is, can the kernfs of a cgroup be removed

Re: [RFC V2 PATCH] kernfs: create raw version kernfs_path_len and kernfs_path

2016-02-26 Thread Shi, Yang
On 2/26/2016 3:01 PM, Greg KH wrote: On Fri, Feb 26, 2016 at 01:47:39PM -0800, Yang Shi wrote: commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback tracepoints to report cgroup") made writeback tracepoints report cgroup writeback, but it may trigger the below bug on -rt

Re: [RFC PATCH] writeback: move list_lock down into the for loop

2016-02-29 Thread Shi, Yang
On 2/29/2016 7:06 AM, Michal Hocko wrote: On Fri 26-02-16 08:46:25, Yang Shi wrote: The list_lock was moved outside the for loop by commit e8dfc30582995ae12454cda517b17d6294175b07 ("writeback: elevate queue_io() into wb_writeback())", however, the commit log says "No behavior change", so it soun

Re: [RFC V2 PATCH] kernfs: create raw version kernfs_path_len and kernfs_path

2016-02-29 Thread Shi, Yang
On 2/27/2016 3:51 AM, Tejun Heo wrote: Hello, On Sat, Feb 27, 2016 at 6:45 AM, Thomas Gleixner wrote: It can be, but we can print out the ino and userland can match that up with path if necessary. Wouldn't be cgroup id the better choice? AFAIK we aren't exposing cgroup id to userland anywh

Re: [PATCH] writeback: call writeback tracepoints withoud holding list_lock in wb_writeback()

2016-02-25 Thread Shi, Yang
On 2/24/2016 6:40 PM, Steven Rostedt wrote: On Wed, 24 Feb 2016 14:47:23 -0800 Yang Shi wrote: commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback tracepoints to report cgroup") made writeback tracepoints report cgroup writeback, but it may trigger the below bug on -r

Re: [PATCH] writeback: call writeback tracepoints withoud holding list_lock in wb_writeback()

2016-02-25 Thread Shi, Yang
On 2/25/2016 11:54 AM, Steven Rostedt wrote: On Thu, 25 Feb 2016 11:38:48 -0800 "Shi, Yang" wrote: On 2/24/2016 6:40 PM, Steven Rostedt wrote: On Wed, 24 Feb 2016 14:47:23 -0800 Yang Shi wrote: commit 5634cc2aa9aebc77bc862992e7805469dcf83dac ("writeback: update writeback

Re: [PATCH] writeback: call writeback tracepoints withoud holding list_lock in wb_writeback()

2016-02-25 Thread Shi, Yang
On 2/25/2016 3:31 PM, Steven Rostedt wrote: On Thu, 25 Feb 2016 15:16:54 -0800 "Shi, Yang" wrote: Actually, regardless whether this is the right fix for the splat, it makes me be wondering if the spin lock which protects the whole for loop is really necessary. It sounds feasible

Re: [PATCH] writeback: call writeback tracepoints withoud holding list_lock in wb_writeback()

2016-02-25 Thread Shi, Yang
On 2/25/2016 3:47 PM, Shi, Yang wrote: On 2/25/2016 3:31 PM, Steven Rostedt wrote: On Thu, 25 Feb 2016 15:16:54 -0800 "Shi, Yang" wrote: Actually, regardless whether this is the right fix for the splat, it makes me be wondering if the spin lock which protects the whole for loop

Re: [BUG linux-next] Kernel panic found with linux-next-20160414

2016-04-20 Thread Shi, Yang
On 4/20/2016 1:01 AM, Hugh Dickins wrote: On Tue, 19 Apr 2016, Shi, Yang wrote: Hi folks, When I ran ltp on linux-next-20160414 on my ARM64 machine, I got the below kernel panic: Unable to handle kernel paging request at virtual address ffc007846000 pgd = ffc01e21d000

[BUG linux-next] KASAN bug is raised on linux-next-20160414 with huge tmpfs on

2016-04-20 Thread Shi, Yang
Hi folks, When I run the below test on my ARM64 machine with NFS mounted rootfs, I got KASAN bug report. The test runs well if mnt is not mounted with "huge=1". # mount -t tmpfs -o huge=1 tmpfs /mnt # cp -a /opt/ltp /mnt/ BUG: KASAN: use-after-free in nfs_readdir+0x2c4/0x848 at addr 800

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-20 Thread Shi, Yang
Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this change. Before I fix all the affected architectures code, I want to check if you guys think this change is worth or not? Thanks, Yang On 4/20/2016 11:24 AM,

[BUG] set_pte_at: racy dirty state clearing warning

2016-04-20 Thread Shi, Yang
Hi Will and Catalin, When I enable memory comact via # echo 1 > /proc/sys/vm/compact_memory I got the below WARNING: set_pte_at: racy dirty state clearing: 0x006899371bd3 -> 0x006899371fd3 [ cut here ] WARNING: CPU: 5 PID: 294 at ./arch/arm64/include/asm/pgtab

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-21 Thread Shi, Yang
On 4/21/2016 12:30 AM, Kirill A. Shutemov wrote: On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote: Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this change. Before I fix all the affected architec

Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

2016-04-21 Thread Shi, Yang
On 4/21/2016 2:15 AM, Hugh Dickins wrote: On Wed, 20 Apr 2016, Shi, Yang wrote: Hi folks, I didn't realize pmd_* functions are protected by CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this change. Before I fix all the affected architectures code, I want to che

[BUG linux-next] kernel NULL pointer dereference on linux-next-20160420

2016-04-21 Thread Shi, Yang
Hi folks, I did the below test with huge tmpfs on linux-next-20160420: # mount -t tmpfs huge=1 tmpfs /mnt # cd /mnt Then clone linux kernel Then I got the below bug, such test works well on non-huge tmpfs. BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] release

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-18 Thread Shi, Yang
Hi Kirill, Finally, I got some time to look into and try yours and Hugh's patches, got two problems. 1. A quick boot up test on my ARM64 machine with your v7 tree shows some unexpected error: systemd-journald[285]: Failed to save stream data /run/systemd/journal/streams/8:16863: No space l

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Shi, Yang
On 4/19/2016 7:33 AM, Jerome Marchand wrote: On 04/19/2016 12:55 AM, Shi, Yang wrote: 2. I ran my THP test (generated a program with 4MB text section) on both x86-64 and ARM64 with yours and Hugh's patches (linux-next tree), I got the program execution time reduced by ~12% on x86-64, it

KASAN can't change FRAME_WARN

2016-04-19 Thread Shi, Yang
Hi Andrey, When I enable KASAN for 4.5 and 4.6 (I didn't try with older versions), I got FRAME_WARN warning for frame size exceeds 2048 bytes. Then I found the kconfig looks like: range 0 8192 default 0 if KASAN default 1024 if !64BIT default 2048 if 64BIT In my understanding, FRAME_WARN sho

[BUG linux-next] Kernel panic found with linux-next-20160414

2016-04-19 Thread Shi, Yang
Hi folks, When I ran ltp on linux-next-20160414 on my ARM64 machine, I got the below kernel panic: Unable to handle kernel paging request at virtual address ffc007846000 pgd = ffc01e21d000 [ffc007846000] *pgd=, *pud= Internal error: Oops: 9647 [#

Re: [PATCHv7 00/29] THP-enabled tmpfs/shmem using compound pages

2016-04-19 Thread Shi, Yang
On 4/19/2016 9:50 AM, Andrea Arcangeli wrote: Hello, On Mon, Apr 18, 2016 at 03:55:44PM -0700, Shi, Yang wrote: Hi Kirill, Finally, I got some time to look into and try yours and Hugh's patches, got two problems. One thing that come to mind to test is this: qemu with -machine accel=kvm

Warning triggered by lockdep checks for sock_owned_by_user on linux-next-20160420

2016-04-22 Thread Shi, Yang
Hi David, When I ran some test on a nfs mounted rootfs, I got the below warning with LOCKDEP enabled on linux-next-20160420: WARNING: CPU: 9 PID: 0 at include/net/sock.h:1408 udp_queue_rcv_skb+0x3d0/0x660 Modules linked in: CPU: 9 PID: 0 Comm: swapper/9 Tainted: G D 4.6.0-rc4-next-2016

Re: Warning triggered by lockdep checks for sock_owned_by_user on linux-next-20160420

2016-04-25 Thread Shi, Yang
On 4/22/2016 9:50 PM, Eric Dumazet wrote: On Fri, 2016-04-22 at 21:02 -0700, Shi, Yang wrote: Hi David, When I ran some test on a nfs mounted rootfs, I got the below warning with LOCKDEP enabled on linux-next-20160420: WARNING: CPU: 9 PID: 0 at include/net/sock.h:1408 udp_queue_rcv_skb+0x3d0

Re: [linux-next PATCH] sched: cgroup: enable interrupt before calling threadgroup_change_begin

2016-04-25 Thread Shi, Yang
On 4/23/2016 2:14 AM, Peter Zijlstra wrote: On Fri, Apr 22, 2016 at 08:56:28PM -0700, Yang Shi wrote: When kernel oops happens in some kernel thread, i.e. kcompactd in the test, the below bug might be triggered by the oops handler: What are you trying to fix? You already oopsed the thing is wr

Re: [linux-next PATCH] sched: cgroup: enable interrupt before calling threadgroup_change_begin

2016-04-25 Thread Shi, Yang
On 4/25/2016 10:35 AM, Shi, Yang wrote: On 4/23/2016 2:14 AM, Peter Zijlstra wrote: On Fri, Apr 22, 2016 at 08:56:28PM -0700, Yang Shi wrote: When kernel oops happens in some kernel thread, i.e. kcompactd in the test, the below bug might be triggered by the oops handler: What are you trying

Re: [PATCH] panic: lockdep: correct lock debugging state check

2016-04-26 Thread Shi, Yang
On 4/26/2016 5:39 AM, Peter Zijlstra wrote: On Mon, Apr 25, 2016 at 08:36:37PM -0700, Yang Shi wrote: When kernel oops happens, lock debugging is turned off by debug_locks_off() in oops_enter() via calling __debug_locks_off() which set debug_locks to 0 via xchg(). But, calling to __debug_locks_o

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

2015-11-06 Thread Shi, Yang
On 11/6/2015 8:25 AM, Will Deacon wrote: On Fri, Nov 06, 2015 at 04:21:09PM +, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: FRAME_

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

2015-11-06 Thread Shi, Yang
On 11/6/2015 9:35 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: On 11/6/2015 8:25 AM, Will Deacon wrote: However, the patch would allow one to disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc though). No, it doesn't. Act

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

2015-11-06 Thread Shi, Yang
On 11/6/2015 9:51 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: On 11/6/2015 9:35 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: On 11/6/2015 8:25 AM, Will Deacon wrote: However, the patch would allow one to

Re: [PATCH] arm64: bpf: fix JIT stack setup

2015-11-06 Thread Shi, Yang
Please ignore this one, forgot to cc to linux-arm-kernel list. Sorry for the inconvenience. Yang On 11/6/2015 9:34 PM, Yang Shi wrote: ARM64 JIT used FP (x29) as eBPF fp register, but FP is subjected to change during function call so it may cause the BPF prog stack base address change too. Wh

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Shi, Yang
On 11/2/2015 12:59 AM, Thomas Gleixner wrote: On Sun, 1 Nov 2015, Alexei Starovoitov wrote: On Sat, Oct 31, 2015 at 09:47:36AM -0400, Steven Rostedt wrote: On Fri, 30 Oct 2015 17:03:58 -0700 Alexei Starovoitov wrote: On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: When running bpf

Re: [PATCH] bpf: convert hashtab lock to raw lock

2015-11-02 Thread Shi, Yang
On 10/31/2015 11:37 AM, Daniel Borkmann wrote: On 10/31/2015 02:47 PM, Steven Rostedt wrote: On Fri, 30 Oct 2015 17:03:58 -0700 Alexei Starovoitov wrote: On Fri, Oct 30, 2015 at 03:16:26PM -0700, Yang Shi wrote: When running bpf samples on rt kernel, it reports the below warning: BUG: sleepi

  1   2   >