Re: [PATCH v2 07/12] ARM: imx: depend MXC debug board on 3DS machines

2014-12-30 Thread Sergei Shtylyov
Hello. On 12/30/2014 2:32 AM, Stefan Agner wrote: Depend the MXC debug board on machines which actually support it. Signed-off-by: Stefan Agner --- This configuration appeared lonely when I enabled ARCH_MULTI_V7M. Afaik, the selection of it only makes sense with one of the supported boards.

Re: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use

2014-12-30 Thread Sergei Shtylyov
Hello. On 12/30/2014 1:55 PM, Andrew Jackson wrote: From: Andrew Jackson Some I2S clocks may require some time to get the clock ready for operation and so need to be prepared before they are enabled. So, prepare the clock as well as enabling it, but combine the two through clk_prepare_enabl

Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

2014-12-30 Thread Sergei Shtylyov
Hello. On 12/30/2014 03:20 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout does not return negative values so the tests for <= 0 are not needed and the case differentiation in the error handling path unnecessary. I decided to verify your statement and I saw that it seems wrong. d

Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

2014-12-30 Thread Sergei Shtylyov
On 12/30/2014 09:28 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout does not return negative values so the tests for <= 0 are not needed and the case differentiation in the error handling path unnecessary. I decided to verify your statement and I saw that it seems wrong. do_wait_

[PATCH v2] clk-rcar-gen2: ADSP clock support

2014-12-30 Thread Sergei Shtylyov
er... Based on the original patch by Konstantin Kozhevnikov . Signed-off-by: Sergei Shtylyov --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock support patch posted last week. Changes in version 2: - swapped &

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2014-12-31 Thread Sergei Shtylyov
Hello. On 12/31/2014 11:20 AM, Fu, Zhonghui wrote: From e34419970a07bfcd365f9c66bdfa552188a0cd26 Mon Sep 17 00:00:00 2001 From: Zhonghui Fu Date: Mon, 29 Dec 2014 21:25:31 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2 SDIO functions, and PM core

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

2015-01-23 Thread Sergei Shtylyov
Hello. On 1/23/2015 12:26 PM, Mohammad Jamal wrote: This patch solves the coding style issues such as space after , s/after/before/? and removes the blank lines Extra blank lines, you mean? Signed-off-by: Mohammad Jamal --- drivers/net/ieee802154/cc2520.c |6 ++ 1 file

Re: [PATCH 1/3] hyperv: netvsc.c: fixup-of-wait_for_completion_timeout-return-type

2015-01-25 Thread Sergei Shtylyov
Hello. On 1/25/2015 2:03 PM, Nicholas Mc Guire wrote: You probably want to replace hyphens with spaces in the subject of this and other patches. And you're not fixing the return type of wait_for_completion_timeout(), you're fixing the variables to match this type. Signed-off-by: Nicho

Re: [PATCH v2 04/12] pm: at91: move the copying the sram function to the sram initializationi phase

2015-01-26 Thread Sergei Shtylyov
Hello. On 1/26/2015 12:40 PM, Wenyou Yang wrote: To decrease the suspend time, move the copying the sram function to the sram initialization phase, instead of every time go to suspend. Signed-off-by: Wenyou Yang Acked-by: Alexandre Belloni --- arch/arm/mach-at91/pm.c |7 +++ 1 f

Re: [PATCH 2/7] pm: at91: pm_suspend: add the WFI support for ARMv7

2015-01-26 Thread Sergei Shtylyov
Hello. On 1/26/2015 1:06 PM, Wenyou Yang wrote: Signed-off-by: Wenyou Yang --- arch/arm/mach-at91/pm_suspend.S | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S in

Re: [PATCH] vhost/net: length miscalculation

2015-01-07 Thread Sergei Shtylyov
Hello. On 01/07/2015 11:55 AM, Michael S. Tsirkin wrote: commit 8b38694a2dc8b18374310df50174f1e4376d6824 vhost/net: virtio 1.0 byte swap had this chunk: - heads[headcount - 1].len += datalen; + heads[headcount - 1].len = cpu_to_vhost32(vq, len - datalen); This adds datalen w

Re: [PATCH net-next] Driver: Vmxnet3: Reinitialize vmxnet3 backend on wakeup from hibernate

2015-01-07 Thread Sergei Shtylyov
Hello. On 01/07/2015 08:56 PM, Shrikrishna Khare wrote: Failing to reinitialize on wakeup results in loss of network connectivity for vmxnet3 interface. Signed-off-by: Srividya Murali Signed-off-by: Shrikrishna Khare Reviewed-by: Shreyas N Bhatewara --- drivers/net/vmxnet3/vmxnet3_drv.c

Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding

2015-01-09 Thread Sergei Shtylyov
Hello. On 1/8/2015 10:40 PM, Baruch Siach wrote: Signed-off-by: Baruch Siach --- .../bindings/interrupt-controller/digicolor-ic.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

Re: [PATCH net-next v2 1/8] r8169:change rtl8168dp jumbo frame patch

2015-01-09 Thread Sergei Shtylyov
Hello. On 1/9/2015 6:25 PM, Chunhao Lin wrote: RTL8168DP jumbo frame patch is the same as RTL8168C. So, for RTL8168DP, change to use RTL8168C jumbo frame patch. Also reomve uncessary function s/reomve uncessary/remove unnecessary/. "r8168dp_hw_jumbo_enable" and "r8168dp_hw_jumbo_disable"

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2015 08:21 PM, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 53

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2015 11:45 PM, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code >from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 5

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-12 Thread Sergei Shtylyov
chip has 2 SDIO functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel Acked-by: Sergei Shtylyov Signed-off-by: Zhonghui Fu --- drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 21

Re: [PATCH] gianfar: correct the bad expression while writing bit-pattern

2015-01-12 Thread Sergei Shtylyov
Hello. On 1/12/2015 10:43 AM, Sanjeev Sharma wrote: This patch correct the bad expression while writing the bit-pattern from software's buffer to hardware registers. Signed-off-by: Sanjeev Sharma --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] net: wireless: atmel: Remove open-coded and wrong strcasecmp

2015-01-16 Thread Sergei Shtylyov
Hello. On 01/16/2015 04:28 PM, Rasmus Villemoes wrote: The kernel's string library does in fact have strcasecmp, at least since ded220bd8f08. Moreover, this open-coded version is in fact Please also specify that commit's summary line in parens. wrong: If the strings only differ in their

Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity

2015-01-17 Thread Sergei Shtylyov
Hello. On 1/16/2015 4:44 AM, Yijing Wang wrote: Use pci_scan_root_bus() instead of pci_create_root_bus() + pci_scan_child_bus() for simplicity. Signed-off-by: Yijing Wang --- drivers/pci/host/pcie-designware.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/

[PATCH] driver core: use *switch* statement in really_probe()

2015-01-17 Thread Sergei Shtylyov
There are series of comparisons of the 'ret' variable on the failure path of really_probe(), so the *switch* statement seems more appropriate there. Signed-off-by: Sergei Shtylyov --- The patch is against the 'driver-core-next' branch of Greg KH's 'driver-

Re: [PATCH] clk-gate: fix bit # check in clk_register_gate()

2015-01-17 Thread Sergei Shtylyov
ned-off-by: Sergei Shtylyov Applied to clk-next. Thanks! Is this causing a visible regression for you? It is not a new bug so I'd prefer to send it though clk-next unless something is blowing up on your end. No, nothing, I don't even call this function (was using composite cl

Re: [PATCH v3 03/13] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

2015-01-27 Thread Sergei Shtylyov
Hello. On 1/27/2015 8:53 AM, Wenyou Yang wrote: From: Peter Rosin The DDRSDR controller fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2 self-refresh spec is equivalent to LPDDR1, and is co

Re: [PATCH net-next v1 05/18] net: tx4939: use __ethtool_get_ksettings

2015-01-27 Thread Sergei Shtylyov
Hello. On 1/27/2015 4:36 AM, David Decotigny wrote: From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) I don't think "net: " prefix applies here. And you should have CC'ed li

Re: [PATCH 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-01-27 Thread Sergei Shtylyov
Hello. On 01/27/2015 04:47 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton Add the binding documentation for the JZ47xx OHCI controller. Signed-off-by: Paul Burton Signed-off-by: Zubair Lutfullah Kakakhel --- The jz4740 is platform only at the moment. But DT support is bei

Re: [PATCH] Smack: fix netfilter Makefile entry

2015-01-28 Thread Sergei Shtylyov
Hello. On 01/28/2015 07:12 PM, Arnd Bergmann wrote: The newly added Smack support for netfilter secmark has its own Kconfig symbol, but the actual implementation is conditionally built on another symbol. It is possible for CONFIG_NETFILTER and SECURITY_SMACK to both be enabled, but NETWORK_S

Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-28 Thread Sergei Shtylyov
Hello. On 1/28/2015 8:58 AM, Peter Hung wrote: This patch implement CMSPAR in set_termios, and fix some warnning from checkpatch.pl Please don't try to do 2 unrelated things in one patch. Signed-off-by: Peter Hung --- drivers/usb/serial/f81232.c | 21 +++-- 1 file ch

Re: [PATCH 5/5] ARM: dts: brcmstb: add nodes for SATA controller and PHY

2015-03-19 Thread Sergei Shtylyov
Hello. On 3/19/2015 4:23 AM, Brian Norris wrote: Signed-off-by: Brian Norris --- Light dependency on: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/331921.html for the surrounding text. arch/arm/boot/dts/bcm7445.dtsi | 36 1 file

Re: [PATCH] Bluetooth: Fix use after free in l2cap_chan_timeout

2015-03-19 Thread Sergei Shtylyov
Hello. On 3/19/2015 11:19 AM, Harish Jenny K N wrote: There is a potential use after free in bt_sock_poll when a socket gets killed without getting unlinked from accept_q. Hence added code to unlink from accpept_q by calling teardown before freeing the socket for channel type L2CAP_CHAN_CONN_OR

Re: [PATCH] net: dsa: make NET_DSA manually selectable from the config

2015-03-22 Thread Sergei Shtylyov
Hello. On 3/21/2015 4:31 AM, Mathieu Olivari wrote: Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers s/Change/Commit/, perhaps? And please also specify that commit's summary line in parens. depend on NET_DSA rather than selecting them. However, as the only way to s

Re: [PATCH 6/6] RDS: don't trust the LL_SEND_FULL bit

2015-04-02 Thread Sergei Shtylyov
Hello. On 4/2/2015 4:50 PM, Sowmini Varadhan wrote: We are seeing connections stuck with the LL_SEND_FULL bit getting set and never cleared. This changes RDS to stop trusting the LL_SEND_FULL bit and kick krdsd after any time we see -ENOMEM from the ring allocation code. Original patch by C

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Sergei Shtylyov
Hello. On 4/22/2015 1:14 PM, Jason A. Donenfeld wrote: Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone c

Re: [PATCH] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-24 Thread Sergei Shtylyov
Hello. On 4/23/2015 10:17 PM, Murali Karicheri wrote: Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri -

Re: [PATCH] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-24 Thread Sergei Shtylyov
On 04/24/2015 06:18 PM, Murali Karicheri wrote: Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri --- dr

Re: [PATCH] cdc-acm: prevent infinite loop when parsing CDC headers.

2015-04-14 Thread Sergei Shtylyov
Hello. On 4/13/2015 7:20 PM, Sergei Shtylyov wrote: Phil and I found out a problem with commit: 7e860a6e ("cdc-acm: add sanity checks") It added some sanity checks to ignore potential garbage in CDC headers but also introduced a potential infinite loop. This can happen at

Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

2015-04-16 Thread Sergei Shtylyov
Hello. On 04/16/2015 09:38 PM, Vivien Didelot wrote: Since commit da4759c, sysfs will only use the permissions returned by Please also specify that commit's summary line in parens. is_visible, instead of OR'ing them with the default file mode. This allows us to declare temp1_max with

Re: [PATCH] net: mdio-gpio: support access that may sleep

2015-04-24 Thread Sergei Shtylyov
On 04/24/2015 06:56 PM, Florian Fainelli wrote: Some systems using mdio-gpio may use gpio on message based busses, which require sleeping (e.g. gpio from an I2C I/O expander). Since this driver does not use IRQ handler, it is safe to use the _cansleep suffixed gpio accessors. Signed-off-by

Re: [PATCH 1/4] devicetree: add binding documentation for the AR7100 SPI controller

2015-04-24 Thread Sergei Shtylyov
Hello. On 04/24/2015 05:19 PM, Alban Bedel wrote: Signed-off-by: Alban Bedel --- .../devicetree/bindings/spi/spi-ath79.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-ath79.txt diff --git a/Document

Re: [PATCH] net: mdio-gpio: support access that may sleep

2015-04-24 Thread Sergei Shtylyov
On 04/24/2015 08:36 PM, Florian Fainelli wrote: Some systems using mdio-gpio may use gpio on message based busses, which require sleeping (e.g. gpio from an I2C I/O expander). Since this driver does not use IRQ handler, it is safe to use the _cansleep suffixed gpio accessors. Signed-off-by

Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

2015-04-26 Thread Sergei Shtylyov
Hello. On 4/26/2015 12:41 PM, Yunzhi Li wrote: rk3288-firefly board use the dwc2 usb otg controller as a host controller and the device mode not used, so the dr_mode should be "host" then the dwc2 usb otg controller will work at host only mode Signed-off-by: Yunzhi Li --- arch/arm/b

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sergei Shtylyov
Hello. On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the So you've first changed the method prototype and follow up with the changes to the actual implementations? That's backward. I'm afraid such changes can't be done piecemeal

Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-28 Thread Sergei Shtylyov
Hello. On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote: Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory One "commit" is enough. :-) And please also specify that commit's summary in parens. allocation in the packet send path. This commit introduced a bug since i

Re: [PATCH 07/14] devicetree: Add bindings for the ATH79 PLL controllers

2015-04-17 Thread Sergei Shtylyov
On 04/17/2015 05:24 PM, Alban Bedel wrote: Signed-off-by: Alban Bedel --- .../devicetree/bindings/clock/qca,ath79-pll.txt| 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qca,ath79-pll.txt diff --git a/Documentat

Re: [PATCH 04/14] devicetree: Add bindings for the ATH79 interrupt controllers

2015-04-17 Thread Sergei Shtylyov
Hello. On 04/17/2015 05:24 PM, Alban Bedel wrote: Signed-off-by: Alban Bedel --- .../interrupt-controller/qca,ath79-cpu-intc.txt| 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/qca,ath79-cpu-intc.t

Re: [PATCH v2 03/12] devicetree: Add bindings for the ATH79 DDR controllers

2015-04-19 Thread Sergei Shtylyov
Hello. On 4/19/2015 3:57 PM, Alban Bedel wrote: The DDR controller of the ARxxx and AR9xxx famillies provides an interface to flush the FIFO between various devices and the DDR. This is mainly used by the IRQ controller to flush the FIFO before running the interrupt handler of such devices.

Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

2015-04-20 Thread Sergei Shtylyov
Hello. On 4/20/2015 8:57 AM, Baolin Wang wrote: This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec, and also introduces the conversion methods: itimerspec64_to_itimerspec() and itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year. "To" not

Re: [PATCH] pinctrl: mediatek: mtk-common: initialize unmask

2015-04-20 Thread Sergei Shtylyov
Hello. On 04/20/2015 02:15 PM, Colin King wrote: From: Colin Ian King cppcheck detected an unitialized variable: Uninitialized. [drivers/pinctrl/mediatek/pinctrl-mtk-common.c:897]: (error) Uninitialized variable: unmask unmask should be initialized to zero to ensure unmasking o

Re: [PATCH] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-09 Thread Sergei Shtylyov
Hello. On 4/8/2015 9:59 PM, Brian Norris wrote: When working on another SATA driver that uses libahci_platform, I noticed an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() -> ata_

Re: [PATCH V3 5/6] dts: msm8974: Add blsp2_bam dma node

2015-04-11 Thread Sergei Shtylyov
Hello. On 04/11/2015 10:09 AM, Sricharan R wrote: Signed-off-by: Sricharan R --- arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index e265ec1..2

Re: [PATCH] cdc-acm: prevent infinite loop when parsing CDC headers.

2015-04-13 Thread Sergei Shtylyov
Hello. On 04/13/2015 06:24 PM, Quentin Casasnovas wrote: Phil and I found out a problem with commit: 7e860a6e ("cdc-acm: add sanity checks") It added some sanity checks to ignore potential garbage in CDC headers but also introduced a potential infinite loop. This can happen at the fir

Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.

2012-07-17 Thread Sergei Shtylyov
Hello. On 16-07-2012 20:46, Denis Turischev wrote: Intense-PC is Compulab's mini-desktop with Intel Panther Point chipset. Unconditional ports switching provided by function usb_enable_xhci_ports() leads to surprising results, after shutdown system powered-on again after a few seconds. On Wi

Re: [PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 12:10, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/

Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread Sergei Shtylyov
Hello. On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi

Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier()

2015-05-28 Thread Sergei Shtylyov
Hello. On 5/28/2015 1:00 PM, Wang Long wrote: Remove automatic variable 'err' in register_netevent_notifier() and return the return value of atomic_notifier_chain_register() directly. s/return value/result/, in order to avoid tautology. Signed-off-by: Wang Long [...] WBR, Sergei -- T

Re: [PATCH net-next] Increase limit of macvtap queues

2015-06-13 Thread Sergei Shtylyov
Hello. On 06/12/2015 04:30 PM, Pankaj Gupta wrote: Macvtap should be compatible with tuntap for maximum number of queues. '1059590254fa9dce9cafc4f07d1103dbec415e76' removes Please also specify that commit's summary line in parens. the limitation and increases number of queues in tuntap.

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2015 10:10 PM, Julien Grall wrote: Append 0x to all %x in order to avoid while reading when there is other decimal value in the log. Also replace some of the hexadecimal print to decimal to uniformize the format with netfront. Signed-off-by: Julien Grall Cc: Wei Liu Cc:

Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-16 Thread Sergei Shtylyov
Hello. On 06/17/2015 01:09 AM, Joe Perches wrote: Append 0x to all %x in order to avoid while reading when there is other decimal value in the log. [] @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct xenvif_queue *queue, if (unlikely(queue->grant_tx_handle[pe

Re: [PATCH 1/3] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-06-22 Thread Sergei Shtylyov
Hello. On 06/22/2015 05:42 PM, Phil Edworthy wrote: These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy --- drivers/usb/renesas_usbhs/common.h | 2 ++ drivers/usb/renesas_usbhs/mod.c| 3 +++ drivers/us

Re: [PATCH 3/3] arm: koelsch: make USB0 perform Host/Function switching

2015-06-22 Thread Sergei Shtylyov
Hello. On 06/22/2015 05:42 PM, Phil Edworthy wrote: Both USB Host (pci0) and Function (USBHS) drivers are enabled. The USB PHY driver determines which IP block should be connected based on vbus and id signals read via gpios. Signed-off-by: Phil Edworthy --- arch/arm/boot/dts/r8a7791-koels

Re: [PATCH 3/3] arm: koelsch: make USB0 perform Host/Function switching

2015-06-22 Thread Sergei Shtylyov
Hello. On 06/22/2015 08:43 PM, Sergei Shtylyov wrote: Both USB Host (pci0) and Function (USBHS) drivers are enabled. The USB PHY driver determines which IP block should be connected based on vbus and id signals read via gpios. Signed-off-by: Phil Edworthy --- arch/arm/boot/dts/r8a7791

Re: [PATCH -next] MIPS: traps: Add missing include file

2015-06-05 Thread Sergei Shtylyov
implicit declaration of function 'kgdb_ll_trap' ... but not about this one. when building mips:allmodconfig. Fixes: 05155ddc2617 ("MIPS: get rid of 'kgdb_early_setup' cruft") Cc: Sergei Shtylyov Acked-by: Sergei Shtylyov Signed-off-by: Guenter Roeck

Re: [PATCH v2 3/3] net/phy: micrel: Center FLP timing at 16ms

2015-06-05 Thread Sergei Shtylyov
Hello. On 06/05/2015 10:55 PM, Jaeden Amero wrote: Link failures have been observed when using the KSZ9031 with HP 1810-8G and HP 1910-8G network switches. Center the FLP timing at 16ms to help avoid intermittent link failures. From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, se

Re: [PATCH 4/6] ARM: dts; pxa: add embedded pxa camera capture interface

2015-06-06 Thread Sergei Shtylyov
Hello. On 06/07/2015 12:09 AM, Robert Jarzmik wrote: The pxa27x SoCs have an embedded camera host controller. Add the description to the family description. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi | 17 + 1 file changed, 17 insertions(+) diff --

Re: [PATCH v3 5/6] i2c: at91: print hardware version

2015-06-02 Thread Sergei Shtylyov
Hello. On 6/2/2015 4:18 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-at91.c b/driver

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-02 Thread Sergei Shtylyov
Hello. On 06/02/2015 06:41 PM, Laurent Pinchart wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it again. :-( How abou

Re: [PATCH 1/2] clk: at91: add a new compatible string for Flexcom in the DT documentation

2015-06-02 Thread Sergei Shtylyov
Hello. On 06/02/2015 07:49 PM, Cyrille Pitchen wrote: This patches documents the new bindings for the Flexcom clock, which will be introduced by Atmel sama5d2x chips. Signed-off-by: Cyrille Pitchen --- .../devicetree/bindings/clock/at91-clock.txt | 20 1 file

Re: [PATCH v4 03/12] devicetree: Add bindings for the ATH79 DDR controllers

2015-05-31 Thread Sergei Shtylyov
Hello. On 5/31/2015 2:52 AM, Alban Bedel wrote: The DDR controller of the ARxxx and AR9xxx families provides an interface to flush the FIFO between various devices and the DDR. This is mainly used by the IRQ controller to flush the FIFO before running the interrupt handler of such devices. S

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2015 01:00 AM, Colin King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Dereference, not "deference". No, it doesn't. It calculates the address of the 'isp1760_request::req' instead, there

Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-01 Thread Sergei Shtylyov
Hello. On 6/1/2015 1:41 AM, Colin Ian King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer deference on req. Dereference, not "deference". Shall I send v2 for this stupid typo then? Definitely, especially as your chang

Re: [Patch v3 11/36] sh, irq: Use helper irq_data_get_irq_handler_data() to hide irq_desc details

2015-06-01 Thread Sergei Shtylyov
Hello. On 6/1/2015 11:05 AM, Jiang Liu wrote: Use helper function irq_data_get_irq_handler_data() to hide irq_desc implementation details. I'm only seeing calls to irq_{get|set}_handler_data() below... Signed-off-by: Jiang Liu --- drivers/sh/intc/virq.c | 12 +++- 1 file ch

Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null

2015-06-01 Thread Sergei Shtylyov
Hello. On 6/1/2015 1:43 AM, Colin King wrote: From: Colin Ian King If kzalloc returns null then isp1760_ep_alloc_request performs a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it again. :-( Detected with sm

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-09 Thread Sergei Shtylyov
Hello. On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Sergei Shtylyov
Hello. On 6/10/2015 11:05 AM, Ludovic Desroches wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses

Re: [PATCH 4/5] usb: dwc3: ep0: Add chained TRB support

2015-06-10 Thread Sergei Shtylyov
Hello. On 06/10/2015 12:18 PM, Kishon Vijay Abraham I wrote: Add chained TRB support to ep0. Now TRB's can be chained just by invoking _dwc3_ep0_start_trans_ with 'chain' parameter set to true. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/ep0.c| 16 +--- d

Re: [PATCH 3/5] usb: dwc3; ep0: Modify _dwc3_ep0_start_trans_ API to take 'chain' parameter

2015-06-10 Thread Sergei Shtylyov
Hello. On 06/10/2015 12:18 PM, Kishon Vijay Abraham I wrote: No functional change. Added a new parameter in _dwc3_ep0_start_trans_ to indicate whether the TRB is a chained TRB or last TRB. This is in preparation for adding chained TRB support for ep0. Signed-off-by: Kishon Vijay Abraham I -

Re: [PATCH 2/5] usb: dwc3: ep0: preparation for handling non maxpacket aligned transfers > 512

2015-06-10 Thread Sergei Shtylyov
On 06/10/2015 12:18 PM, Kishon Vijay Abraham I wrote: No functional change. This is in preparation for handling non maxpacket aligned transfers greater than bounce buffer size. This is basically to avoid code duplication when using chained TRB transfers to handle non maxpacket aligned transfers

Re: [PATCH v2 6/6] ARM: dts: pxa: add the usb host controller

2015-06-19 Thread Sergei Shtylyov
Hello. On 06/19/2015 09:38 PM, Robert Jarzmik wrote: Add the usb host controller to pxa27x and pxa3xx. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi | 8 arch/arm/boot/dts/pxa3xx.dtsi | 8 2 files changed, 16 insertions(+) diff --git a/arch/arm/boo

Re: [PATCH 30/31] timerfd: convert to ->poll_mask

2018-05-22 Thread Sergei Shtylyov
Hello! On 05/22/2018 02:31 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/timerfd.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/fs/timerfd.c b/fs/timerfd.c > index cdad49da3ff7..d84a2bee4f82 100644 > --- a/fs/tim

Re: [PATCH 6/6] scsi: Check sense buffer size at build time

2018-05-23 Thread Sergei Shtylyov
Hello! On 5/22/2018 9:15 PM, Kees Cook wrote: To avoid introducing problems like those fixed in commit f7068114d45e ("sr: pass down correctly sized SCSI sense buffer"), this creates a macro wrapper for scsi_execute() that verifies the size of the sense buffer similar to what was done for comman

Re: [PATCH v2 3/3] usb: typec: fusb302: Fix debugfs issue

2018-05-23 Thread Sergei Shtylyov
Hello! On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > Removing the "fusb302" debugfs directory when unloading > the driver. That allows the driver to be loaded more then > ones. The directory will not get actually removed until it s/ones/once/? > is empty, so only after the last instance h

Re: [PATCH v2 1/3] usb: roles: intel_xhci: Always allow user control

2018-05-23 Thread Sergei Shtylyov
On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > Trying to determine the USB port type with this mux is very > difficult. To simplify the situation, always allowing user s/allowing/allow/? Else the statement doesn't parse for me. :-) > control, even if the port is USB Type-C port. > > Signed

Re: [RFC v4 5/5] virtio_ring: enable packed ring

2018-05-16 Thread Sergei Shtylyov
On 5/16/2018 11:37 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index de3839f3621a..b158692263b0 100644 --- a/drivers/virtio/virtio_ring.c +++ b

Re: [RFC v4 5/5] virtio_ring: enable packed ring

2018-05-16 Thread Sergei Shtylyov
On 05/16/2018 01:21 PM, Tiwei Bie wrote: >>> Signed-off-by: Tiwei Bie >>> --- >>> drivers/virtio/virtio_ring.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c >>> index de3839f3621a..b158692263b0 100644 >>> --- a/driv

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

2018-05-16 Thread Sergei Shtylyov
- if (dev->of_node) { > - ret = of_mdiobus_register(mdp->mii_bus, dev->of_node); > - } else { > - if (pd->phy_irq > 0) > - mdp->mii_bus->irq[pd->phy] = pd->phy_irq; > - > - ret = mdiobus_re

Re: [PATCH] netfilter: nf_ct_helper: Fix possible panic when nf_conntrack_helper_unregister is used in an unloadable module

2019-03-01 Thread Sergei Shtylyov
Hello! On 01.03.2019 8:56, Su Yanjun wrote: From: Su Yanjun Because nf_conntrack_helper_unregister maybe used in an unloadable module, it uses 'synchronize_rcu' which may cause kernel panic. According to the artical: Article? RCU and Unloadable Modules https://lwn.net/Articles/217484/

Re: [PATCH v10 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD controller driver

2019-04-15 Thread Sergei Shtylyov
The patch name is somewhat misleading -- there's no "MFD controller". On 04/15/2019 10:37 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF MFD controller. > > Signed-off-by: Mason Yang [...] > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 26ad646..7914349 1006

Re: [PATCH v3 0/5] MTD: Add Initial Hyperbus support

2019-04-18 Thread Sergei Shtylyov
Hello! On 04/17/2019 08:24 PM, Vignesh Raghavendra wrote: >> Vignesh Raghavendra (5): >>mtd: cfi_cmdset_0002: Add support for polling status register >>dt-bindings: mtd: Add binding documentation for HyperFlash >>mtd: Add support for HyperBus memory devices >>dt-bindings: mtd: Add

Re: [PATCH v10 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-04-18 Thread Sergei Shtylyov
Hello! On 04/18/2019 08:55 AM, masonccy...@mxic.com.tw wrote: >> > > > Document the bindings used by the Renesas R-Car Gen3 RPC-IF >> MFD controller. >> > > > >> > > > Signed-off-by: Mason Yang >> > > > --- >> > > > .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 37 + >> > > ++

Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

2019-03-12 Thread Sergei Shtylyov
On 03/12/2019 01:41 PM, LABBE Corentin wrote: >>> When playing with a virtual SPARC machine with qemu, I found that the >>> IDE emulated device was not probing with the ata/pata_oldpiix driver. >> >>Correctly, it should probe with ata_piix, >> >>> But with the old ide/piix, it was probed.> >>

Re: [PATCH 4/9] drivers: ata: ahci_xgene: use devm_platform_ioremap_resource()

2019-03-12 Thread Sergei Shtylyov
Hello! On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > drivers/ata/ahci_xgene.c | 21 +++-- >

Re: [PATCH 9/9] drivers: ata: sata_rcar: use devm_platform_ioremap_resource()

2019-03-12 Thread Sergei Shtylyov
On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [RFC PATCH v2 3/5] mtd: Add support for Hyperbus memory devices

2019-03-26 Thread Sergei Shtylyov
On 25.03.2019 23:13, Sergei Shtylyov wrote: Cypress' Hyperbus is Low Signal Count, High Performance Double Data Rate It's HyperBus, according to the spec... Bus interface between a host system master and one or more slave interfaces. Hyperbus is used to connect micr

Re: [RFC PATCH v2 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-03-26 Thread Sergei Shtylyov
On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. > > Add basic support for the IP without DMA. Second ChipSelect is not > suppo

Re: [RFC PATCH 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-02-25 Thread Sergei Shtylyov
Hello! On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. Are you sure you posted the _complete_ driver?

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-25 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Cypress HyperBus is Low Signal Count, High Performance Double Data Rate Bus > interface between a host system master and one or more slave interfaces. > HyperBus is used to connect microprocessor, microcontroller, or ASIC > d

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-25 Thread Sergei Shtylyov
On 02/25/2019 09:21 PM, Vignesh R wrote: [...] >>> HyperBus specification can be found at[1] >>> HyperFlash datasheet can be found at[2] >>> >>> [1] https://www.cypress.com/file/213356/download >>> [2] https://www.cypress.com/file/213346/download >>> [3] http://www.ti.com/lit/ug/spruid7b/spruid7b

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-26 Thread Sergei Shtylyov
On 02/26/2019 01:26 PM, Vignesh R wrote: >> [...] > HyperBus specification can be found at[1] > HyperFlash datasheet can be found at[2] > > [1] https://www.cypress.com/file/213356/download > [2] https://www.cypress.com/file/213346/download > [3] http://www.ti.com/lit/ug/sp

Re: [RFC PATCH 3/5] mtd: Add support for Hyperbus memory devices

2019-02-26 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Cypress HyperBus is Low Signal Count, High Performance Double Data Rate Bus > interface between a host system master and one or more slave interfaces. > HyperBus is used to connect microprocessor, microcontroller, or ASIC > d

Re: [RFC PATCH 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller

2019-02-26 Thread Sergei Shtylyov
On 02/19/2019 09:36 AM, Vignesh R (by way of Boris Brezillon ) wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. > > Add basic support for the IP without DMA. Second ChipS

Re: [PATCH] usb: host: ehci: remove casting dma_alloc_coherent

2021-02-04 Thread Sergei Shtylyov
Hello! On 04.02.2021 10:17, Xu Wang wrote: Remove casting the values returned by dma_alloc_coherent. I'm not seeing any casting, I'm seeing a trailing space removed. Signed-off-by: Xu Wang --- drivers/usb/host/ehci-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

<    5   6   7   8   9   10   11   12   13   14   >