Re: [PATCH 12/18] Thermal/int340x: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
On 1/6/2018 4:10 AM, Dan Williams wrote: Static analysis reports that 'trip' may be a user controlled value that is used as a data dependency to read '*temp' from the 'd->aux_trips' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction

Re: [PATCH 15/18] vfs, fdtable: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
On 1/6/2018 4:11 AM, Dan Williams wrote: Expectedly, static analysis reports that 'fd' is a user controlled value that is used as a data dependency to read from the 'fdt->fd' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction stream

Re: [PATCH 14/18] ipv4: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
On 1/6/2018 4:11 AM, Dan Williams wrote: Static analysis reports that 'offset' may be a user controlled value that is used as a data dependency reading from a raw_frag_vec buffer. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction stream tha

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
On 1/6/2018 4:11 AM, Dan Williams wrote: Static analysis reports that 'index' may be a user controlled value that is used as a data dependency reading 'rt' from the 'platform_label' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction

Re: net: memory leak in socket

2018-01-10 Thread Sergei Shtylyov
Hello! On 1/9/2018 11:53 PM, Al Viro wrote: Argh... Got broken by "make sock_alloc_file() do sock_release() on failures" - cleanup after sock_map_fd() failure got pulled all the way into sock_alloc_file(), but it used to serve the case when sock_map_fd() failed *before* getting to sock_alloc_

Re: [PATCH v6 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-27 Thread Sergei Shtylyov
Hello! On 3/27/2018 10:33 AM, jacopo mondi wrote: [...] Document Thine THC63LVD1024 LVDS decoder device tree bindings. Signed-off-by: Jacopo Mondi Reviewed-by: Andrzej Hajda Reviewed-by: Niklas Söderlund --- .../bindings/display/bridge/thine,thc63lvd1024.txt | 66 +++ 1 fi

Re: [PATCH 1/6] rhashtable: improve documentation for rhashtable_walk_peek()

2018-03-27 Thread Sergei Shtylyov
Hello! On 3/27/2018 2:33 AM, NeilBrown wrote: The documentation for rhashtable_walk_peek() wrong. It claims to return the *next* entry, whereas it in fact returns the *previous* entry. However if no entries have yet been returned - or if the iterator was reset due to a resize event, then rhash

Re: [PATCH] usbip: vhci_hcd: check rhport before using in vhci_hub_control()

2018-04-06 Thread Sergei Shtylyov
Hello! On 4/6/2018 1:31 AM, Shuah Khan wrote: Validate !rhport < 0 before using it to access port_status array. Why '!'? Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/usbip/vhci_hcd.c b/driver

Re: [PATCH 1/2] ide: pdc202xx_new: Replace mdelay with usleep_range in detect_pll_input_clock

2018-04-11 Thread Sergei Shtylyov
Hello! On 4/11/2018 10:52 AM, Jia-Ju Bai wrote: detect_pll_input_clock() is never called in atomic context. detect_pll_input_clock() is only called by init_chipset_pdcnew(), which is set as ".init_chipset" in struct ide_port_info. This function is not called in atomic context. Despite never g

Re: [PATCH v2 1/1] usb: musb: gadget: misplaced out of bounds check

2018-03-20 Thread Sergei Shtylyov
Hello! On 3/20/2018 5:27 AM, Heinrich Schuchardt wrote: musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- v2 Only the 4 low bits of epnum are relevant for indexing. --- d

Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support

2018-04-10 Thread Sergei Shtylyov
On 04/10/2018 01:54 PM, Jacopo Mondi wrote: > From: Niklas Söderlund > > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > the it to the LVDS output of the DU. > > Signed-off-by: Niklas Söderlund > Signed-off-by: Jacopo Mondi > Reviewed-by: Laurent Pinchart > > --- >

Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support

2018-04-10 Thread Sergei Shtylyov
On 04/10/2018 03:13 PM, jacopo mondi wrote: >>> From: Niklas Söderlund >>> >>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect >>> the it to the LVDS output of the DU. >>> >>> Signed-off-by: Niklas Söderlund >>> Signed-off-by: Jacopo Mondi >>> Reviewed-by: Laurent Pinchar

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

2018-03-08 Thread Sergei Shtylyov
Hello! On 03/08/2018 01:50 AM, Brad Mouring wrote: > If multiple phys share the same interrupt (e.g. a multi-phy chip), > the first device registered is the only one checked as phy_interrupt > will always return IRQ_HANDLED if the first phydev is not halted. > Move the interrupt check into phy_in

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

2018-03-08 Thread Sergei Shtylyov
On 03/08/2018 10:41 PM, Sergei Shtylyov wrote: >> If multiple phys share the same interrupt (e.g. a multi-phy chip), >> the first device registered is the only one checked as phy_interrupt >> will always return IRQ_HANDLED if the first phydev is not halted. >> Move

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

2018-03-08 Thread Sergei Shtylyov
On 03/08/2018 01:50 AM, Brad Mouring wrote: > If multiple phys share the same interrupt (e.g. a multi-phy chip), > the first device registered is the only one checked as phy_interrupt > will always return IRQ_HANDLED if the first phydev is not halted. > Move the interrupt check into phy_interrupt

Re: [PATCH 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Sergei Shtylyov
Hello! On 3/8/2018 6:24 PM, Jacopo Mondi wrote: The R-Car V3M Eagle board includes a transparent LVDS decoder, connected to the on-chip LVDS encoder output on one side and to HDMI encoder ADV7511w on the other one. As the decoder does not need any configuration it has been so-far omitted from

Re: [PATCH v2 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-09 Thread Sergei Shtylyov
On 03/09/2018 04:51 PM, Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent LVDS decoder, connected > to the on-chip LVDS encoder output on one side and to HDMI encoder > ADV7511w on the other one. > > As the decoder does not need any configuration it has been so-far > omitted

Re: [PATCH] net: ipv6: xfrm6_state: remove VLA usage

2018-03-09 Thread Sergei Shtylyov
Hello! On 03/09/2018 03:21 PM, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed[1]. > > Signed-off-by: Andreas Christoforou > --- > net/ipv6/xfrm6_state.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/net/ipv6/xfrm6_stat

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread Sergei Shtylyov
Hello! On 03/09/2018 04:25 PM, Mohammed Gamal wrote: > Commit 009f766 intended to filter multicast/broadcast, however At least 12 digits needed here, and the summary line too, just like you do for the Fixes: tag. > the NDIS filter wasn't set properly in non-promiscuous modes, > which resulte

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread Sergei Shtylyov
On 03/09/2018 09:37 PM, Sergei Shtylyov wrote: >> Commit 009f766 intended to filter multicast/broadcast, however > >At least 12 digits needed here, and the summary line too, just like you do > for the Fixes: tag. > >> the NDIS filter wasn't set properly in no

Re: [PATCH/RFC 1/2] PM / wakeup: Add callback for wake-up change notification

2018-03-14 Thread Sergei Shtylyov
On 03/14/2018 02:26 PM, Geert Uytterhoeven wrote: > Add a callback to inform a device that his wake-up setting has been s/his/its/. > changed. This allows a device to synchronize device configuration with > an external user action. > > E.g. on systems using a Rohm BD9571MWV PMIC and a toggl

Re: [PATCH v3 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-14 Thread Sergei Shtylyov
On 03/13/2018 05:30 PM, Jacopo Mondi wrote: > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > output decoder. > > Signed-off-by: Jacopo Mondi [...] > diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c > b/drivers/gpu/drm/bridge/thc63lvd1024.c > new file mode 100644 > ind

Re: [PATCH v3 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-14 Thread Sergei Shtylyov
On 03/14/2018 09:04 PM, jacopo mondi wrote: >>> Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel >>> output decoder. >>> >>> Signed-off-by: Jacopo Mondi >> [...] >>> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c >>> b/drivers/gpu/drm/bridge/thc63lvd1024.c >>> new file m

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Sergei Shtylyov
Hello! On 11/21/2018 04:04 PM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? > Signed-off-by: Ya

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-22 Thread Sergei Shtylyov
On 21.11.2018 18:33, Frank Lee wrote: of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? Hi Sergei: Yeah,this is a typo.

Re: [PATCH AUTOSEL 4.19 15/68] batman-adv: Expand merged fragment buffer for full packet

2018-11-29 Thread Sergei Shtylyov
Hello! On 11/29/2018 08:55 AM, Sasha Levin wrote: > From: Sven Eckelmann > > [ Upstream commit d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60 ] > > The complete size ("total_size") of the fragmented packet is stored in the > fragment header and in the size of the fragment chain. When the fragments >

Re: [PATCH v3 2/2] dt-binding: spi: Document Renesas R-Car Gen3 RPC controller bindings

2018-12-07 Thread Sergei Shtylyov
Hello! On 12/07/2018 02:13 PM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC controller. > > Signed-off-by: Mason Yang > --- > .../devicetree/bindings/spi/spi-renesas-rpc.txt| 38 > ++ > 1 file changed, 38 insertions(+) > create mode 100

Re: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-07 Thread Sergei Shtylyov
Hello! I'd already started the v2 driver review before you posted v3, so here goes... On 12/03/2018 12:18 PM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC SPI controller. > > Signed-off-by: Mason Yang [...] > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renes

Re: [PATCH v3 0/2] spi: Add Renesas R-Car Gen3 RPC SPI driver

2018-12-09 Thread Sergei Shtylyov
On 12/07/2018 02:13 PM, Mason Yang wrote: > This Renesas R-Car Gen3 RPC SPI driver is based on Boris's new > spi-mem direct mapping read/write mode [1][2]. > > v3 patch is according to Marek and Geert's comments including: > 1) soc_device_mach() to set up RPC_PHYCNT_STRTIM. > 2) get_unaligned() >

Re: [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs

2018-12-03 Thread Sergei Shtylyov
Hello! On 03.12.2018 6:45, Yu Chen wrote: This patch adds binding descriptions to support the dwc3 controller on HiSilicon SoCs and boards like the HiKey960. Cc: Greg Kroah-Hartman Cc: Rob Herring Cc: Mark Rutland Cc: John Stultz Signed-off-by: Yu Chen --- .../devicetree/bindings/usb/dw

Re: [PATCH] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Sergei Shtylyov
Hello! On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+)

Re: [PATCH v2] ipvlan: flush arp table when mac address changed

2018-05-14 Thread Sergei Shtylyov
Hello. On 5/14/2018 12:22 PM, liuq...@huawei.com wrote: From: Keefe Liu When master device's mac has been changed, the commit <32c10bbfe914> "ipvlan: always use the current L2 addr of the master" makes the IPVlan devices's mac changed commit 32c10bbfe914 ("ipvlan: always use the current L2

Re: [PATCH 4.16 020/279] dt-bindings: net: ravb: Add support for r8a77965 SoC

2018-06-18 Thread Sergei Shtylyov
device tree bindings documentation. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman Acked-by: Sergei Shtylyov Signed-off-by: Rob Herring Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- Documentation/devicetree/bindings/net/renesas

Re: [PATCH] signal/sh: Stop gcc warning about an impossible case in do_divide_error

2018-05-30 Thread Sergei Shtylyov
Hello! On 5/29/2018 6:00 PM, Eric W. Biederman wrote: Geert Uytterhoeven reported: HOSTLD scripts/mod/modpost CC arch/sh/kernel/traps_32.o arch/sh/kernel/traps_32.c: In function 'do_divide_error': arch/sh/kernel/traps_32.c:606:17: error: 'code' may be used uninitialized in this f

Re: [PATCH] usb: gadget: add error handling for platform_get_resource_byname

2018-06-12 Thread Sergei Shtylyov
Hello! On 6/12/2018 7:32 AM, Zhouyang Jia wrote: When platform_get_resource_byname fails, the lack of error-handling code may cause unexpected results. What results? This patch adds error-handling code after calling platform_get_resource_byname. Signed-off-by: Zhouyang Jia --- driver

Re: [PATCH] arch/sh: use slow path for get_user_pages_fast() on SMP

2018-06-15 Thread Sergei Shtylyov
Hello! On 06/15/2018 06:52 PM, Thomas Petazzoni wrote: > The fast path of get_user_pages_fast() disables IRQs and then does: > > - gup_pud_range() >- gup_pmd_range() > - gup_pte_range() >- flush_dcache_page() > > However, flush_dcache_page() makes a smp_call_function(), and us

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Sergei Shtylyov
On 08/18/2018 09:16 AM, zhong jiang wrote: > We should use NULL to compare with pointer-typed value rather than > 0. The issue is detected with the help of Coccinelle. Your description stopped to match the patch in v2. Actually, this X == NULL to !x preference is largely spocific to netdev

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Sergei Shtylyov
On 08/18/2018 07:15 PM, Joe Perches wrote: >>> We should use NULL to compare with pointer-typed value rather than >>> 0. The issue is detected with the help of Coccinelle. >> >>Your description stopped to match the patch in v2. >>Actually, this X == NULL to !x preference is largely spocif

Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0

2018-08-18 Thread Sergei Shtylyov
On 08/18/2018 06:53 PM, Sergei Shtylyov wrote: >> We should use NULL to compare with pointer-typed value rather than >> 0. The issue is detected with the help of Coccinelle. > >Your description stopped to match the patch in v2. And your subject as well... >Actu

Re: [PATCH v3 2/2] dt-binding: spi: Document Renesas R-Car Gen3 RPC controller bindings

2018-12-12 Thread Sergei Shtylyov
Hello! Should be "dt-bindings: " in the subject... MBR, Sergei

Re: [PATCH v3 2/2] dt-binding: spi: Document Renesas R-Car Gen3 RPC controller bindings

2018-12-12 Thread Sergei Shtylyov
On 12/07/2018 02:13 PM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC controller. > > Signed-off-by: Mason Yang > --- > .../devicetree/bindings/spi/spi-renesas-rpc.txt| 38 > ++ > 1 file changed, 38 insertions(+) > create mode 100644 Docu

Re: [PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-13 Thread Sergei Shtylyov
On 12/07/2018 02:13 PM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC SPI controller. > > Signed-off-by: Mason Yang > --- > drivers/spi/Kconfig | 6 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-renesas-rpc.c | 776 >

Re: [PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-17 Thread Sergei Shtylyov
Hello! On 12/17/2018 10:42 AM, masonccy...@mxic.com.tw wrote: >> > +static int rpc_spi_io_xfer(struct rpc_spi *rpc, >> > +const void *tx_buf, void *rx_buf) >> > +{ >> > + u32 smenr, smcr, data, pos = 0; >> > + int ret = 0; >> > + >> > + regmap_write(rpc->regmap, RPC_CMNCR, RPC_C

Re: [PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-18 Thread Sergei Shtylyov
On 12/17/2018 10:42 AM, masonccy...@mxic.com.tw wrote: >> > +static int rpc_spi_io_xfer(struct rpc_spi *rpc, >> > +const void *tx_buf, void *rx_buf) >> > +{ >> > + u32 smenr, smcr, data, pos = 0; >> > + int ret = 0; >> > + >> > + regmap_write(rpc->regmap, RPC_CMNCR, RPC_CMNCR_MD

Re: [PATCH] usb: dwc3: gadget: fix miss isoc issue introduced by IRQ latency

2018-12-14 Thread Sergei Shtylyov
Hello! On 12/14/2018 07:32 PM, Zeng Tao wrote: > If it's a busy system, some times when we start an isoc transfer, the > framenumber get from the event buffer may be already elasped, in this Frame number? Else my spell checker trips. :-) > case, we will get all the packets dropped due to mi

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a774c0 SoC

2018-12-14 Thread Sergei Shtylyov
On 12/13/2018 11:18 PM, Fabrizio Castro wrote: > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

2018-12-10 Thread Sergei Shtylyov
Hello! On 12/10/2018 04:46 PM, Corentin Labbe wrote: > When playing with a virtual SPARC machine with qemu, I found that the > IDE emulated device was not probing with the ata/pata_oldpiix driver. Correctly, it should probe with ata_piix, > But with the old ide/piix, it was probed.> > This

Re: [PATCH 1/6] driver core: Introduce device_iommu_mapped() function

2018-12-11 Thread Sergei Shtylyov
Hello! On 12/11/2018 04:43 PM, Joerg Roedel wrote: > From: Joerg Roedel > > Some places in the kernel check the iommu_group pointer in > 'struct device' in order to find ot whether a device is > mapped by an IOMMU. > > This is not good way to make this check, as the pointer will > be moved to

Re: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-11 Thread Sergei Shtylyov
Hello! On 12/11/2018 12:26 PM, masonccy...@mxic.com.tw wrote: [...] >>I'd already started the v2 driver review before you posted v3, so >> here goes... >> >> On 12/03/2018 12:18 PM, Mason Yang wrote: >> >>> Add a driver for Renesas R-Car Gen3 RPC SPI controller. >>> >>> Signed-off-by: Mason Y

Re: [PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-11 Thread Sergei Shtylyov
On 12/07/2018 02:13 PM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC SPI controller. > > Signed-off-by: Mason Yang [...] > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c > new file mode 100644 > index 000..cec5669 > --- /dev/null > +++ b/drivers/spi

Re: [PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-21 Thread Sergei Shtylyov
Hello! On 12/21/2018 04:30 AM, masonccy...@mxic.com.tw wrote: >> > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c >> > new file mode 100644 >> > index 000..cec5669 >> > --- /dev/null >> > +++ b/drivers/spi/spi-renesas-rpc.c >> > @@ -0,0 +1,776 @@ >> [...] >> > +sta

Re: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-22 Thread Sergei Shtylyov
Hello! On 12/21/2018 01:46 PM, masonccy...@mxic.com.tw wrote: >> >>> +static ssize_t rpc_spi_mem_dirmap_write(struct spi_mem_dirmap_desc >> >>> *desc, >> >>> + u64 offs, size_t len, const void *buf) >> >>> +{ >> >>> + struct rpc_spi *rpc = spi_master_get_devdata(desc->mem->spi->m

Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

2018-12-22 Thread Sergei Shtylyov
Hello! On 21.12.2018 23:57, Florian Westphal wrote: skb->sp doesn't exist anymore in the next-next tree, so mips defconfig It's net-next. :-) no longer builds. Use helper instead to reset the secpath. Not even compile tested. Cc: Greg Kroah-Hartman Reported-by: Guenter Roeck Fixes:

Re: [PATCH v4 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2019-01-04 Thread Sergei Shtylyov
Hello! On 01/03/2019 09:35 AM, masonccy...@mxic.com.tw wrote: [...] >> >> > +#define RPC_CMNCR_MOIIO3(val) (((val) & 0x3) << 22) >> >> > +#define RPC_CMNCR_MOIIO2(val) (((val) & 0x3) << 20) >> >> > +#define RPC_CMNCR_MOIIO1(val) (((val) & 0x3) << 18) >> >> > +#define RPC_CMNCR_MOIIO0(val)

Re: [PATCH v4 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC controller bindings

2018-12-24 Thread Sergei Shtylyov
Hello! On 24.12.2018 9:52, Mason Yang wrote: Document the bindings used by the Renesas R-Car Gen3 RPC controller. Signed-off-by: Mason Yang --- .../devicetree/bindings/spi/spi-renesas-rpc.txt| 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentatio

Re: [PATCH][V2] drivers/net: appletalk/cops: remove redundant if statement and mask

2018-12-25 Thread Sergei Shtylyov
On 24.12.2018 22:41, Colin King wrote: From: Colin Ian King The two different assignments for pkt_len are actually the same and so the if statement is redundant and can be removed. Masking a u8 return value from inb() with 0xFF is also redundant and can also be emoved. Removed. :-) Sim

Re: [PATCH v4 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-25 Thread Sergei Shtylyov
On 12/24/2018 09:52 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC SPI controller. > > Signed-off-by: Mason Yang > --- > drivers/spi/Kconfig | 6 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-renesas-rpc.c | 788 >

Re: [PATCH v4 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-26 Thread Sergei Shtylyov
Hello! On 12/26/2018 07:24 AM, masonccy...@mxic.com.tw wrote: >> [...] >> > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c >> > new file mode 100644 >> > index 000..6dd739a >> > --- /dev/null >> > +++ b/drivers/spi/spi-renesas-rpc.c >> > @@ -0,0 +1,788 @@ [...] >>

Re: [PATCH v4 0/2] spi: Add Renesas R-Car Gen3 RPC SPI driver

2018-12-27 Thread Sergei Shtylyov
On 12/24/2018 09:52 AM, Mason Yang wrote: > Hi Mark, > This Renesas R-Car Gen3 RPC SPI driver is based on Boris's new > spi-mem direct mapping read/write mode [1][2]. Against which repo/branch these pathes were generated? MBR, Sergei

Re: [PATCH] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-29 Thread Sergei Shtylyov
Hello! On 10/29/2018 11:04 AM, Yi Wang wrote: 'onecell' is malloced in clk_boston_setup(), but not be freed Is not freed. before leaving from the error handling cases. Signed-off-by: Yi Wang [...] MBR, Sergei

Re: [PATCH 6/8] usbnet: smsc95xx: fix memcpy for accessing rx-data

2018-10-12 Thread Sergei Shtylyov
Hello! On 12.10.2018 11:34, Ben Dooks wrote: Change the RX code to use get_unaligned_le32() instead of the combo of memcpy and cpu_to_le32s(&var). le32_to_cpus(), actually. Signed-off-by: Ben Dooks --- drivers/net/usb/smsc95xx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

2018-10-04 Thread Sergei Shtylyov
Hello! On 10/3/2018 8:23 PM, Maksym Kokhan wrote: CONFIG_BUILTIN_DTB selection is duplicated in menu "Machine selection" under MIPS_MALTA. Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT") Signed-off-by: Maksym Kokhan Signed-off-by: Andrii Bordunov --- arch/mips/Kconfig | 1 -

Re: [PATCH v3 4/7] ata: ahci_sunxi: use xxxsetbitsi_le32 functions

2018-10-24 Thread Sergei Shtylyov
Hello! Typo in the subject: s/xxxsetbitsi/xxxsetbits/. On 24.10.2018 10:35, Corentin Labbe wrote: This patch converts ahci_sunxi to use xxxsetbits_le32 functions Signed-off-by: Corentin Labbe [...] MBR, Sergei

Re: [PATCH] ata: pata_rb532: Add OF support and make COMPILE_TESTable

2021-04-20 Thread Sergei Shtylyov
Hello! On 4/20/21 5:04 PM, Thomas Bogendoerfer wrote: > Add OF support for switching RB532 do device tree possible. I couldnb't parse that. :-) > By removing > the not needed asm/mach-rc32434/rb.h include the driver could be > compile tested now. I think it's a separte issue worth its own

Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-14 Thread Sergei Shtylyov
Hello! On 15.02.2021 5:38, Daehwan Jung wrote: It seems pm_runtime_put calls runtime_idle callback not runtime_suspend callback. It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend. Signed-off-by: Daehwan Jung --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed,

Re: [PATCH] MIPS: octeon: Add __raw_copy_[from|to|in]_user symbols

2021-04-09 Thread Sergei Shtylyov
Hello! On 09.04.2021 0:48, Thomas Bogendoerfer wrote: Cavium Octeon has it's own memcpy implementation and also need the change Its. :-) done in commit 04324f44cb69 ("MIPS: Remove get_fs/set_fs"). Fixes: 04324f44cb69 ("MIPS: Remove get_fs/set_fs") Reported-by: kernel test robot Signed-

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-08 Thread Sergei Shtylyov
Hello, I wrote: Sergei Shtylyov wrote: The patch was 4/4 of course. :-< Probably I was too esctatic about the code. ;-) Or rarher me. :-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-cal

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-08 Thread Sergei Shtylyov
ven't got something much better then uour original approach (AKA Occam's razor :-). Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> Farewell! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-24 Thread Sergei Shtylyov
Once I quothed: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. This one not looking to pretty -- I've geve some thought on how to beautify all these switch fallthoughs but haven't

Re: [PATCH] ahci: Add MCP79 support to AHCI driver

2007-09-24 Thread Sergei Shtylyov
Hello. Peer Chen wrote: Code change, remove some Device IDs. Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0 -0400 +++ linux-2.6.23-rc7/drivers/ata/ahci.c 2007-09-24 10:08:03.0 -0400 @@ -472,6 +472,14 @@

[PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-09-29 Thread Sergei Shtylyov
with his consent, also adding the method callout to ide_rate_filter(); - install the method for all chips to only return empty mask if a SATA drive is detected on HPT372{AN]/374 chips... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- This patch is against the current Linus' t

[PATCH 1/2] pdc202xx_new: fix PCI refcounting

2007-08-19 Thread Sergei Shtylyov
The driver erroneously "lets go" the mate IDE chip in init_setup_pdc20270() when ide_setup_pci_devices() call succeeds -- fix this, and drop a couple of useless assignments in this function while at it... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- This patch is aga

[PATCH 2/2] pdc202xx_new: switch to using pci_get_slot() (take 2)

2007-08-19 Thread Sergei Shtylyov
eing fixed up (just like hpt366.c does) and "beautify" this whole function as well as init_setup_pdc20276()... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- This patch is against the current Linus' tree, it has only been compile tested since I do not have PDC2027x c

[PATCH 1/4] ide: add ide_dev_is_sata() helper

2007-08-19 Thread Sergei Shtylyov
Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- This is against the current Linus tr

[PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 2)

2007-08-19 Thread Sergei Shtylyov
de_dma_filter() method to behave correctly; - move the HPT370[A] cases below the HPT36x case for consistency. While at it, replace the explicit UltraDMA mode masks with ATA_UDMA* constants all over the driver... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- This is against the cur

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 2)

2007-08-24 Thread Sergei Shtylyov
I'll cook it up. For now, I'm going to drop this part Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied ... with imminent recast. :-) --- This is against the current Linus tree and unfortunately I was able to only compile test it since that tree gives MODPOST

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper

2007-08-24 Thread Sergei Shtylyov
Hello, I wrote: Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> [...] Index: linux-2.6/d

[PATCH 1/4] ide: add ide_dev_is_sata() helper (take 2)

2007-08-25 Thread Sergei Shtylyov
Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- This version doesn't flip the MSB, it

[PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 2)

2007-08-25 Thread Sergei Shtylyov
rtunately I was able to only compile test it since that tree gives MODPOST warning and dies early on bootup. Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> drivers/ide/pci/hpt366.c | 78 --- 1 files changed, 40 insertions(+), 38 deletions(-)

[PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 3)

2007-08-25 Thread Sergei Shtylyov
de_dma_filter() method to behave correctly; - move the HPT370[A] cases below the HPT36x case for consistency... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- Argh! I've managed to put = instead of &= here and there, so please disregard the take #2... :-/ This version doesn&#

[PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Sergei Shtylyov
river. The Vbus status signals are also wired to GPIOs (however, we're not currently intested in them), the OFFVBUS# signal is controlled by the host controllers, there's also the SHDN# signal wired to GPIO, which should be high for normal operation. Signed-off-by: Sergei Shtylyov ---

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2014 4:46 AM, Chanwoo Choi wrote: I reviewed this patch quickly. This driver has just two gpio without any registers for IP. Because there are no registers. I wonder whether MAX3355E is separate chip to detect external connector Yes. I thought my description has mad

Re: [PATCH v2] clk-rcar-gen2: ADSP clock support

2015-01-05 Thread Sergei Shtylyov
ing is non-linear, so can't be supported by that driver... Based on the original patch by Konstantin Kozhevnikov . Signed-off-by: Sergei Shtylyov --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock suppo

[PATCH v3] clk-rcar-gen2: RCAN clock support

2015-01-05 Thread Sergei Shtylyov
be supported by that driver... Signed-off-by: Sergei Shtylyov --- Changes in version 3: - added the USB_EXTAL clock reference to the binding document. Changes in version 2: - switched to using the composite clock driver with the fixed factor and gated clock component drivers; - remove

Re: [PATCH v3] clk-rcar-gen2: RCAN clock support

2015-01-05 Thread Sergei Shtylyov
Hello. On 01/05/2015 11:10 PM, Sergei Shtylyov wrote: Add the RCAN clock support to the R-Car generation 2 CPG driver. This clock gets derived from the USB_EXTAL clock, dividing it by 6. The layout of the RCANCKCR register is similar to those of the clocks supported by the 'clk

[PATCH v4] clk-rcar-gen2: RCAN clock support

2015-01-05 Thread Sergei Shtylyov
be supported by that driver... Signed-off-by: Sergei Shtylyov Acked-by: Geert Uytterhoeven --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo. Changes in version 4: - added Geert's ACK. Changes in version 3: - added the USB_

Re: [PATCH_V3] dm9000: Add regulator and reset support to dm9000

2015-01-06 Thread Sergei Shtylyov
Hello. On 1/6/2015 2:15 PM, Zubair Lutfullah Kakakhel wrote: In boards, the dm9000 chip's power and reset can be controlled by gpio. It makes sense to add them to the dm9000 driver and let dt be used to enable power and reset the phy. Signed-off-by: Zubair Lutfullah Kakakhel Signed-off-b

Re: [PATCH] video: vt8500lcdfb: remove unneeded continue

2015-01-06 Thread Sergei Shtylyov
Hello. On 01/06/2015 03:45 PM, Sudip Mukherjee wrote: continue is not needed at the end of a for loop Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/vt8500lcdfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500l

[PATCH v2] clk-rcar-gen2: ADSP clock support

2015-01-06 Thread Sergei Shtylyov
er... Based on the original patch by Konstantin Kozhevnikov . Signed-off-by: Sergei Shtylyov --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock support patch reposted yesterday. Changes in version 3: - f

[PATCH v3 resend] clk-rcar-gen2: ADSP clock support

2015-01-06 Thread Sergei Shtylyov
er... Based on the original patch by Konstantin Kozhevnikov . Signed-off-by: Sergei Shtylyov --- Re-sending with the correct version tag... The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock support patch reposted yeste

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-04 Thread Sergei Shtylyov
Hello. On 12/4/2014 3:06 PM, Thierry Reding wrote: From: Thierry Reding Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on failure") broke platforms that rely on deferred probing to order probing of PHY and host controller drivers. The reason is that the commit simply

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-04 Thread Sergei Shtylyov
On 12/4/2014 4:22 PM, Thierry Reding wrote: From: Thierry Reding Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on failure") broke platforms that rely on deferred probing to order probing of PHY and host controller drivers. The reason is that the commit simply propagat

Re: [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Sergei Shtylyov
Hello. On 12/04/2014 09:39 PM, Joe Stringer wrote: ndo_gso_check() was recently introduced to allow NICs to report the offloading support that they have on a per-skb basis. Add an implementation for this driver which checks for IPIP, GRE, UDP tunnels. Signed-off-by: Joe Stringer --- v3: Dro

Re: [RFC][PATCH 07/13] iov_iter.c: get rid of bvec_copy_page_{to,from}_iter()

2014-12-05 Thread Sergei Shtylyov
Hello. On 12/4/2014 11:23 PM, Al Viro wrote: Looks like you've erred in the subject as you seem to be getting rid of copy_page_{to|from}_iter_bvec() instead of bvec_copy_page_{to|from}_iter()... From: Al Viro Just have copy_page_{to,from}_iter() fall back to kmap_atomic + copy_{to,fro

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 1:43 AM, David Cohen wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) Can't the host driver still control Vbus? (3) Plat

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 10:57 PM, David Cohen wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) Can't the host driver still control Vbus? I ca

Re: [PATCH] clk-rcar-gen2: RCAN clock support

2014-12-23 Thread Sergei Shtylyov
Hello. On 07/31/2014 12:23 AM, Sergei Shtylyov wrote: Add RCAN clock support to the R-Car generation 2 CPG driver. This clock gets derived from the USB_EXTAL clock by dividing it by 6. The layout of RCANCKCR register is close to those of the clocks supported by the 'clk-div6' driv

[PATCH] clk-gate: fix bit # check in clk_register_gate()

2014-12-24 Thread Sergei Shtylyov
In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit # should be no higher than 15, however the corresponding check is obviously off- by-one. Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK") Signed-off-by: Sergei Shtylyov --- The patch is against L

[PATCH v2] clk-rcar-gen2: RCAN clock support

2014-12-24 Thread Sergei Shtylyov
be supported by that driver... Signed-off-by: Sergei Shtylyov --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo. Changes in version 2: - switched to using the composite clock driver with the fixed factor and gated clock component drive

[PATCH] clk-rcar-gen2: ADSP clock support

2014-12-25 Thread Sergei Shtylyov
er... Based on the original patch by Konstantin Kozhevnikov . Signed-off-by: Sergei Shtylyov --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock support posted yesterday. Documentation/devicetree/bindings/clock/

<    4   5   6   7   8   9   10   11   12   13   >