Re: [PATCH 1/1] ide: ide-generic, add another device exception

2007-06-04 Thread Sergei Shtylyov
Hello. Jiri Slaby wrote: diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c index f2c5a14..0d51a11 100644 --- a/drivers/ide/pci/generic.c +++ b/drivers/ide/pci/generic.c @@ -198,32 +198,41 @@ static ide_pci_device_t generic_chipsets[] __devinitdata = { static int __devinit gen

Re: [PATCH 1/1] ide: ide-generic, add another device exception

2007-06-04 Thread Sergei Shtylyov
Hello. Jiri Slaby wrote: diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c index f2c5a14..0d51a11 100644 --- a/drivers/ide/pci/generic.c +++ b/drivers/ide/pci/generic.c @@ -198,32 +198,41 @@ static ide_pci_device_t generic_chipsets[] __devinitdata = { static int __devinit gener

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-05 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: The log of a typical IDE reset is available here: http://petra.hos.u-szeged.hu/~wildy/syslog.gz This was the worst case: the IDE bus was resetted during the system boot. Could you try setting HPT374_ALLOW_ATA133_6 to 0 in drivers/ide/pci/hpt366.

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-05 Thread Sergei Shtylyov
Hello, I wrote: I felt inspired by this explanation (thanks!) and took a look at hpt374-opensource-v2.10 vendor driver. Here is something interesting: glbdata.c: ... #ifdef CLOCK_66MHZ ULONG setting370_66[] = { 0xd029d5e, 0xd029d26, 0xc829ca6, 0xc829c84, 0xc829c62, 0x2

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-05 Thread Sergei Shtylyov
Hello, I wrote: This looks promising. Using a vanilla 2.6.22-rc3 I was able to reproduce the problem within a few seconds. With the above modification the machine is running under heavy disk I/O without problems since 30 minutes... Did it fix the problem for good? It seems so far. There h

[PATCH pata-2.6 fix] hpt366: disallow Ultra133 for HPT374

2007-06-06 Thread Sergei Shtylyov
Eliminate UltraATA/133 support for HPT374 -- the chip isn't capable of this mode according to the manual, and doesn't even seem to tolerate 66 MHz DPLL clock... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- drivers/ide/pci/hpt366.c |8 1 files changed, 4

Re: [PATCH pata-2.6 fix] hpt366: disallow Ultra133 for HPT374

2007-06-07 Thread Sergei Shtylyov
Andrew Morton wrote: Eliminate UltraATA/133 support for HPT374 -- the chip isn't capable of this mode according to the manual, and doesn't even seem to tolerate 66 MHz DPLL clock... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- drivers/ide/pci/hpt366.c |8

Re: HPT374 IDE problem with 2.6.21.* kernels

2007-06-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Sergei, do we need to disallow UDMA6 completely on HPT734 or is it only an issue with some problematic devices (=> blacklist)? Note that I didn't change what the old code was doing in this regard -- although the HPT374 spec does *not* say that UDMA6 is suppo

Re: [PATCH 5/5] via82cxxx: backport short cables support from pata_via.c

2007-06-26 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Backport short cables support from pata_via.c. This patch should allow UDMA > 2 modes on Acer Ferrari 3400. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - To u

Re: [PATCH 3/5] alim15x3: backport short cables support from pata_ali.c

2007-06-26 Thread Sergei Shtylyov
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/5] piix: backport short cables support from ata_piix.c

2007-06-26 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Backport short cables support from ata_piix.c. This patch should allow UDMA > 2 modes on: - Acer 5602WLMi - Acer 3682WLMi - Asus W5F - Acer Aspire 2023WLMi Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyo

Re: [PATCH 4/5] sis5513: backport short cables support from pata_sis.c

2007-06-26 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Backport short cables support from pata_sis.c. This patch should allow UDMA > 2 modes on ASUS A6K. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> Index: b/drivers/id

Re: 2.6.22-rc6-mm1

2007-06-29 Thread Sergei Shtylyov
Hello. Mariusz Kozlowski wrote: allmodconfig on powerpc (iMac g3) fails due to git-kgdb.patch. allmodconfig defaults should be changed? CC arch/powerpc/kernel/kgdb.o arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected in .config. Unselect one of them.

Re: [1/2] 2.6.22-rc6: known regressions v2

2007-06-29 Thread Sergei Shtylyov
Hello. Michal Piotrowski wrote: IDE Subject: 2.6.22-rcX: hda: lost interrupt References : http://lkml.org/lkml/2007/6/29/121 Submitter : David Chinner <[EMAIL PROTECTED]> Status : unknown Probing IDE interface ide0... hda: probing with STATUS(0xa0) instead of ALTSTATUS(0x58)

Re: [BUG] ide dma_timer_expiry, then hard lockup

2007-06-29 Thread Sergei Shtylyov
Hello, I wrote: I've got a hard lockup in the ide subsystem, probably due to some irq spew or something like that. I've just bought a brand new Maxtor 320GB disk driver for the insane price of $70 US to replace another failing drive. It works well under light load; I was able to copy about 6

[PATCH pata-2.6 fix] hpt366: use correct enablebits for HPT36x

2007-06-29 Thread Sergei Shtylyov
The HPT36x chips finally turned out to have the channel enable bits -- however, badly implemented. Make use of them despite it's probably only going to burden the driver's code -- assuming both channels are always enabled by the HighPoint BIOS anyway... Signed-off-by: Sergei Shtyly

Re: 2.6.22-rc6-mm1

2007-07-02 Thread Sergei Shtylyov
Hello. Jason Wessel wrote: allmodconfig on powerpc (iMac g3) fails due to git-kgdb.patch. allmodconfig defaults should be changed? CC arch/powerpc/kernel/kgdb.o arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB selected in .config. Unselect one of them. make[1]:

Re: [PATCH] pata_hpt3x3: Major reworking and testing

2007-07-03 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: http://www.linuxhq.com/kernel/v2.3/10/drivers/block/hpt343.c Does anybody have DOS driver for HPT343? Google doesn't have it... I have the drivers for HPT34[35] -- tried dissassembling them some years ago... Thanks, Bart MBR, Sergei - To un

Re: [PATCH] pata_hpt3x3: Major reworking and testing

2007-07-04 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Does anybody have DOS driver for HPT343? Google doesn't have it... I have the drivers for HPT34[35] -- tried dissassembling them some years ago... /me wants I tried sending binaries as is but GMail bounced them off. :-/ Will try to tar a

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: Yes, on some implementations there can be other conditions that make a decrementer exception go away; there is no contradiction here (thankfully). My wording was sloppy. Some CPUs have the DEC exceptions basically edge triggered (yeah I know for examp

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Sergei Shtylyov
Hello. Matt Sealey wrote: I haven't looked at all the new clock/timer code, is there any utility in having support for more than one clock source? Of course, you may register as many as you like. Sure, but is there any utility in registering more than the decrementer on PPC? Not

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Sergei Shtylyov
Hello, I wrote: Yes, on some implementations there can be other conditions that make a decrementer exception go away; there is no contradiction here (thankfully). My wording was sloppy. Some CPUs have the DEC exceptions basically edge triggered (yeah I know for example? it sucks). That

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Sergei Shtylyov
Hello. Albert Cahalan wrote: I haven't looked at all the new clock/timer code, is there any utility in having support for more than one clock source? Of course, you may register as many as you like. Sure, but is there any utility in registering more than the decrementer on PPC? Not yet

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Sergei Shtylyov
Daniel Walker wrote: I haven't looked at all the new clock/timer code, is there any utility in having support for more than one clock source? There is if the main clocksource has some issues where it can't be used. You mean, having more than one clocksource is *useful* in this case? O

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Sergei Shtylyov
Hello. Daniel Walker wrote: Well, the decrementer frequency may change, at least in theory (if the bus clock changes). Does that happen very often? Never, I hope. :-) Daniel WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

[PATCH 2.6.21-rt7] PowerPC: kill cpu_khz reference

2007-05-23 Thread Sergei Shtylyov
Remove forgotten reference to 'cpu_khz' which have been removed for PowerPC in 2.6.21-rt7... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- The irony here is that it was me who sent a patch to add that line. :-) Index: linux-2.6/arch/power

Re: [BUG] 2.6.21.1: ide-pci is not finding ide controller.

2007-05-23 Thread Sergei Shtylyov
Hello. Linas Vepstas wrote: I've got a rather old x86 box that I'm booting 2.6.21.1 on; this kernel is not finding an ide controller on it. The motherboard has 4 ide controllers total; two olde-fashioned ones (PIIX4, using the original 40-pin IDE ribbon cable) and two You should have s

Re: [BUG] 2.6.21.1: ide-pci is not finding ide controller.

2007-05-23 Thread Sergei Shtylyov
Hello. Alan Cox wrote: I've got a rather old x86 box that I'm booting 2.6.21.1 on; this kernel is not finding an ide controller on it. HPT366 fixes were posted here earlier. It doesn't in fact have reliable enable bits. HPT36x either didn't have them yet or they were located in differen

[PATCH 2.6.21-rt7] PowerPC: fix clockevents for classic CPUs

2007-05-24 Thread Sergei Shtylyov
CPU in periodic mode since the event reprogramming has been delegated to the timer subsystem. Also, as the classic decrementer doesn't have periodic mode, make set_mode() method for this case completely empty. While at it, add a switch case for CLOCK_EVT_MODE_RESUME to hush the warning. Signe

Re: [PATCH 10/13] sl82c105: add ->speedproc support

2007-03-14 Thread Sergei Shtylyov
Hello, I wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] sl82c105: add ->speedproc support * add sl82c105_tunepio() wrapper for sl82c105_tune_drive() (just to get the error value) * add sl82c105_tune_chipset() (->speedproc method) for setting transfer mode Thanks for the patch!

Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Sergei Shtylyov
Hello. Akira Iguchi wrote: It's bool and it depends on BLK_DEV_IDE => should depend on BLK_DEV_IDE=y Hm, why I'm seeing module_init() in the driver? :-) And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on BLK_DEV_IDEDMA_PCI. IMHO, that driver shouldn't be in drivers/

Re: [patch 1/6 -rt] powerpc 2.6.20-rt8: add preemption checks for NEED_RESCHED_DELAYED.

2007-03-16 Thread Sergei Shtylyov
Hello. Tsutomu OWA wrote: To add preemption checks for the NEED_RESCHED_DELAYED flag. diff -rup linux-rt8/arch/powerpc/kernel/idle.c rt/arch/powerpc/kernel/idle.c --- linux-rt8/arch/powerpc/kernel/idle.c2007-02-20 14:30:38.0 +0900 +++ rt/arch/powerpc/kernel/idle.c 200

Re: 2.6.21-rc6-mm1 ATA HPT37x regression

2007-04-17 Thread Sergei Shtylyov
Hello. John Stoffel wrote: I was just testing out 2.6.21-rc6-mm1 to test some Cyclades patches and I noticed that my HPT302 (rev1) controller with a pair of 120gb WD disks are not longer detected and I get the following in the dmesg logs: [ 148.121490] hpt37x: DPLL did not stabilize.

Re: 2.6.21-rc6-mm1 ATA HPT37x regression

2007-04-17 Thread Sergei Shtylyov
John Stoffel wrote: I was just testing out 2.6.21-rc6-mm1 to test some Cyclades patches and I noticed that my HPT302 (rev1) controller with a pair of 120gb WD disks are not longer detected and I get the following in the dmesg logs: [ 148.121490] hpt37x: DPLL did not stabilize. Where befor

Re: Permanent Kgdb integration into the kernel - lets get with it.

2007-04-17 Thread Sergei Shtylyov
Hello. Randy Dunlap wrote: In spite of kgdb, shouldn't it have that \n anyways in case some other code gets added in the future after the macro? Or are you saying that there should never be any code ever after that macro? Sure if there is mainline code added after that macro we add the \n. Bu

Re: Permanent Kgdb integration into the kernel - lets get with it.

2007-04-17 Thread Sergei Shtylyov
Randy Dunlap wrote: In spite of kgdb, shouldn't it have that \n anyways in case some other code gets added in the future after the macro? Or are you saying that there should never be any code ever after that macro? Sure if there is mainline code added after that macro we add the \n. But onl

Re: 2.6.21-rc6-mm1 ATA HPT37x regression

2007-04-17 Thread Sergei Shtylyov
Hello. John Stoffel wrote: Ok, so do I need to do anything special with the next -mm release and the next version? Well, let Alan decide that (2Alan: and I said that HPT code is bogus :-). Alan> Try drivers/ide/pci/hpt366 - if that works grab a dmesg and let Alan> me know. It means that

Re: [BUG] 2.6.21-rc7 hpt366 driver broken

2007-04-18 Thread Sergei Shtylyov
Hello. Mike Mattie wrote: I have added Sergei Shtylyov to the address list after seeing his recent posts on hpt366 issues, and the git changelog for the hpt366.c driver. I am very confident that I have pinpointed the defect in the driver. Indeed you have. Thank you. [ Cc's added,

[PATCH pata-2.6 fix queue] hpt366: fix kernel oops with HPT302N

2007-04-18 Thread Sergei Shtylyov
The driver crashes the kernel on HPT302N chips due to the missing initializer for 'hpt302n.settings' having been unfortunately overlooked so far. :-< Much thanks to Mike Mattie for pin-pointing the reason of crash. Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- Postin

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-19 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the "ide: fix UDMA/MWDMA/SWDMA masks" patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very patch seems to be breaking fil

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-19 Thread Sergei Shtylyov
Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the "ide: fix UDMA/MWDMA/SWDMA masks" patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-19 Thread Sergei Shtylyov
Hello, I wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the "ide: fix UDMA/MWDMA/SWDMA masks" patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very patch seems to be

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-20 Thread Sergei Shtylyov
Hello, I wrote: [PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the "ide: fix UDMA/MWDMA/SWDMA masks" patch. I'm now trying to rewrite hpt366.c to benefit more from these patches... and alas, this very patch seems to be breaking filtering (at least) in t

Re: [PATCH 14/15] ide: rework the code for selecting the best DMA transfer mode

2007-04-20 Thread Sergei Shtylyov
Hello, I wrote: Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -513,43 +513,31 @@ static int check_in_drive_list(ide_drive return 0; } -static u8 hpt3xx_ratemask(ide_dr

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-04-20 Thread Sergei Shtylyov
Hello, once I wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void * since ide_hwif_t.ide_dma_host_on is called either when drive->using_dma == 1 or when return value is discarded make it void, also drop "ide_" prefix * make __ide_dma_host_on() void and drop "__" prefix BTW, it wo

Re: [PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks

2007-04-22 Thread Sergei Shtylyov
* fix UDMA masks to match with chipset specific *_ratemask() (alim15x3, hpt366, serverworks and siimage drivers need UDMA mask filtering method - done in the next patch) v2: * piix: fix cable detection for 82801AA_1 and 82372FB_1 [ Noticed by Sergei Shtylyov <[EMAIL PROTECTED]>. ] * cmd6

[PATCH pata-2.6 fix queue] aec62xx: fix PIO/DMA setup issues

2007-04-22 Thread Sergei Shtylyov
supporting SWDMA modes; - stop hooking ide_dma_timeout() method as the handler clearly doesn't fit for the task... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- Warning: the patch has only been compile tested (the driver was on the way of some cleanup -- that's why

Re: Fw: HPT366: 2.6.21 breaks HPT366 detection on boot

2007-05-04 Thread Sergei Shtylyov
Hello. Andrew Morton wrote: fyi.. (followup on-list if so inclined, please) Begin forwarded message: Date: Fri, 4 May 2007 18:44:18 +0200 From: Michal Kepien <[EMAIL PROTECTED]> To: The Linux Kernel Mailing List Subject: HPT366: 2.6.21 breaks HPT366 detection on boot Hi there all kern

[PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

2007-05-04 Thread Sergei Shtylyov
HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- Michal, sorry for unintended breakage, please verify the patch... :-) drivers/ide/pci/hpt366.c |7 ++- 1 files

Re: [PATCH pata-2.6 fix queue] hpt366: don't check enablebits for HPT36x

2007-05-05 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: HPT36x chip don't seem to have the channel enable bits, so prevent the IDE core from checking them... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> applied I'm getting "403 Forbidden" trying to browse this patch

Re: [PATCH 10/13] sl82c105: add ->speedproc support

2007-03-15 Thread Sergei Shtylyov
Hello. Russell King wrote: I wonder is there are some W83C554 users anywhere -- that chipset also supports UltraDMA... Sergei, ARM Netwinder machines are running hard disk IDE on SL82c105. Could you send me the actual source file to try (or a patch)? That's actually a W83C553 which doe

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-24 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Since I think that it's worth to have it in 2.6.21-final and respin didn't happen I did the required changes myself (it also turned out that I missed few things during initial review), then applied the patch... Please let my know whether you are fine w

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Sergei Shtylyov
Hello. Suleiman Souhlal wrote: It is possible for the timer expiry function to run even though the request has already been handled: ide_timer_expiry() only checks that the handler is not NULL, but it is possible that we have handled a request (thus clearing the handler) and then started a new

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Sergei Shtylyov
Hello. Suleiman Souhlal wrote: It is possible for the timer expiry function to run even though the request has already been handled: ide_timer_expiry() only checks that the handler is not NULL, but it is possible that we have handled a request (thus clearing the handler) and then started a new

Re: PATCH 2.6.20 11/14; CRIS architecture update - IDE driver

2007-04-23 Thread Sergei Shtylyov
Hello. Mikael Starvik wrote: The attached patch updates the CRIS IDE driver. Signed-off-by: Mikael Starvik <[EMAIL PROTECTED] > Please attach the patch as text/plain and clean it from the whitespace noise. :-/ /Mikael MBR, Sergei - To unsubscribe from this

Re: [PATCH] sl82c105: Switch to ref counting API

2007-04-23 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Not sure how this one got missed in the great purge some time ago but it did. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/ide/pci/sl82c105.c linux-2.6.21-rc6-mm1/dri

[PATCH 2.6.21-rc6-rt0] ns2cyc() result fix

2007-04-25 Thread Sergei Shtylyov
ely to return a correct result on such machines because of the shift result truncation. Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- I'm also uncertain about 'preempt_max_latency' and 'preempt_thresh' variables being declared as 'unsigned long'

Re: htpt366 PCI latency value is really high

2007-04-26 Thread Sergei Shtylyov
Hello. Mike Mattie wrote: while hunting down some latency problems I found something quite odd. The latency reported by lspci -v for the HTP203N card is enormous. 00:09.0 RAID bus controller: Triones Technologies, Inc. HPT302/302N (rev 02) Subsystem: Triones Technologies, Inc. Unknown device

Re: htpt366 PCI latency value is really high

2007-04-28 Thread Sergei Shtylyov
Hello. Alan Cox wrote: There are many reasons a card would default to a higher level, but in the end it is basically tuning the card for a server application. A warning that some cards default to high PCI latency values; settings that can interfere with latency sensitive devices such as soun

Re: [PATCH] pata_cmd640: CMD640 PCI support

2007-03-03 Thread Sergei Shtylyov
Hello. Jeff Garzik wrote: +/* The second channel has shared timings and the setup timing is + messy to switch to merge it for worst case */ +if (ap->port_no && pair) { +struct ata_timing p; +ata_timing_compute(pair, pair->pio_mode, &p, T, 1); +ata_timing_me

Re: [PATCH] pata_cmd640: CMD640 PCI support

2007-03-03 Thread Sergei Shtylyov
Alan Cox wrote: +if (t.active > 16) +t.active = 16; Erm, clamping active time is not a right thing to do. Right thing to do was to bail out. I didn't do it in the legacy driver rewrite though... As far as I can work out its a "can't happen" +pci_read_config_byte(pd

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] pdc202xx_old: rewrite mode programming code This patch is based on the documentation (I would like to thank Promise for it) and also partially on the older vendor driver. Rewrite mode programming code: * fix XFER_MW_DMA0 timings (they were

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] pdc202xx_old: rewrite mode programming code This patch is based on the documentation (I would like to thank Promise for it) and also partially on the older vendor driver. Rewrite mode programming code: * fix XFER_MW_DMA0 timings (they wer

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Sergei Shtylyov
Hello, I wrote: official == same as in the docs and vendor driver :-) Erm, those look a bit doubtful... I believe that they are correct - please see explanations below. Yeah, sorry about that. Only SWDMA timings are suspicious. Hm, too early to say sorry. I was hasty/distacte

Re: [patch 0/6 -rt] powerpc 2.6.20-rt8: fix boot/runtime errors/warnings for PowerPC(ppc64)

2007-03-07 Thread Sergei Shtylyov
Tsutomu OWA wrote: Hi Ingo, Please consider for inclusion in your rt tree. This series of patches fixes boot and runntime errors/warnings for powerpc (esp. 64 bit). This applies to linux-2.6.20, patch-2.6.20-rt8 and previous my patch set; http://ozlabs.org/pipermail/linuxppc-dev/2007

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Tsutomu OWA wrote: --- linux-rt8/arch/powerpc/kernel/irq.c 2007-02-20 14:30:38.0 +0900 +++ rt/arch/powerpc/kernel/irq.c2007-03-05 18:54:34.0 +0900 @@ -392,7 +392,7 @@ EXPORT_SYMBOL(do_softirq); #ifdef CONFIG_PPC_MERGE static LIST_HEAD(irq_hosts); -static spin

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: --- linux-rt8/arch/powerpc/kernel/irq.c 2007-02-20 14:30:38.0 +0900 +++ rt/arch/powerpc/kernel/irq.c2007-03-05 18:54:34.0 +0900 @@ -392,7 +392,7 @@ EXPORT_SYMBOL(do_softirq); #ifdef CONFIG_PPC_MERGE static LIST_HEAD(irq_hosts); -stat

Re: v2.6.19-rt6, yum/rpm

2007-03-07 Thread Sergei Shtylyov
Hello, I wrote: could you resend them to me please? Seeing that GENERIC_TIME has been thrown out from the -rt patch, [...] hm, i did that accidentally during a rebase. That was certainly not meant to be a persistent condition. ok, the delta below is what i've managed to restore from yo

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-03-06 Thread Sergei Shtylyov
Hello. Greg KH wrote: 3x59x-fix-pci-resource-management.patch causes the following compile error with CONFIG_PCI=n: <-- snip --> ... CC drivers/net/3c59x.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In function 'vortex_init_one': /home/bunk/linux/kernel

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: I've already sent a patch fixing this one (along with many others) a month ago: http://ozlabs.org/pipermail/linuxppc-dev/2007-February/031164.html I wonder iof it was ever considered... :-/ The entire patch description was just this: Convert the sp

Re: [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones.

2007-03-07 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: As I said, this was intended for the -rt patch, hence the question was for Ingo. I CC'ed the list just to keep people here in a loop. OK, fair enough, but I still think the patch description was inadequate. In the -rt context, I would at least expect to see s

Re: [RFC] [patch 5/6] powerpc 2.6.20-rt8: fix a boot error for handle_percpu_irq

2007-03-07 Thread Sergei Shtylyov
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - I found a pile of e-mail started by Sergei Shtylyov on linuxppc-dev regarding this. Subject: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers From: Sergei Shtylyov <[EMAIL PROTECTED]> Date: Sun, 19 Nov 2006 22:43

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-03-26 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void * since ide_hwif_t.ide_dma_host_on is called either when drive->using_dma == 1 or when return value is discarded make it void, also drop "ide_" prefix * make __ide_dma_host_on() void and drop "__" pref

Re: [ PATCH] Add suspend/resume for HPET was: Re: [3/6] 2.6.21-rc4: known regressions

2007-03-29 Thread Sergei Shtylyov
Hello. Maxim wrote: --- This adds support of suspend/resume on i386 for HPET The part after usually "---" gets cut off, the patch description and signoff should actially *precede* it. Signed-off-by: Maxim Levitsky <[EMAIL PROTECTED]> diff --git a/arch/i386/kernel/hpet.c b/arch/i386/k

[PATCH] clockchips.h: kernel-doc fix

2007-05-02 Thread Sergei Shtylyov
Fix misnamed fields of 'struct clock_event_device' in the kernel-doc comment. Convert the acronyms to uppercase, while at it... Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- include/linux/clockchips.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(

Re: [PATCH net] e1000e: fix PTP on e1000_pch_lpt variants

2016-07-20 Thread Sergei Shtylyov
Hello. On 7/19/2016 11:25 PM, Jarod Wilson wrote: I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed. Switching from an if to a select, b

Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

2016-07-21 Thread Sergei Shtylyov
Hello. On 07/21/2016 09:41 PM, tom.t...@gmail.com wrote: From: Tom Yan 1. Removed a repeated bit masking in ata_mselect_control() 2. Moved `wce`/`d_sense` assignment below the page validity checks 3. Added/Removed empty lines where appropriate Signed-off-by: Tom Yan Perhaps Tejun is OK

Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread Sergei Shtylyov
Hello. On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff fro

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

2016-09-20 Thread Sergei Shtylyov
Hello. On 9/20/2016 12:21 AM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- Changes in v2: - Remove rtc DT node label Haven't you also renamed the node? arch/mips/boot/dts/mti/m

Re: [PATCH v2 6/6] MIPS: Deprecate VPE Loader

2016-09-20 Thread Sergei Shtylyov
Hello. On 9/20/2016 11:47 AM, Matt Redfearn wrote: The MIPS remote processor driver (CONFIG_MIPS_RPROC) provides a more standard mechanism for using one or more VPs as coprocessors running separate firmware. Here we deprecate this mechanism before it is removed. Signed-off-by: Matt Redfearn

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

2016-09-20 Thread Sergei Shtylyov
On 9/20/2016 1:34 PM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- Changes in v2: - Remove rtc DT node label Haven't you also renamed the node? Hi Sergei, Yes, strictly speaking

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

2016-09-20 Thread Sergei Shtylyov
Hello. On 9/20/2016 9:30 AM, Joel Stanley wrote: On Aspeed SoC with a direct PHY connection (non-NSCI), we receive continual PHYSTS interrupts: [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CH

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

2016-09-22 Thread Sergei Shtylyov
Hello. On 9/21/2016 10:48 PM, Harman Kalra wrote: Looks like your patch summary and description got merged together in the subject. Signed-off-by: Harman Kalra [...] MBR, Sergei

Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

2016-09-22 Thread Sergei Shtylyov
Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang Add the dts property for the capability if TRGMII supported on GAMC0 Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) dif

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-22 Thread Sergei Shtylyov
Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. and adds a variable trgmii inside mtk_mac as the indication to make the difference between the MAC conne

Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

2016-09-22 Thread Sergei Shtylyov
On 09/22/2016 01:44 PM, Sergei Shtylyov wrote: Looks like your patch summary and description got merged together in the subject. Also, the subject (summary) should contain driver name as a prefix: "pata_at91: Use ..." Signed-off-by: Harman Kalra [...] MBR, Sergei

Re: [PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-22 Thread Sergei Shtylyov
hy are you sending an incremental patch? Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang [...] MBR, Sergei

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-22 Thread Sergei Shtylyov
Hello. On 09/22/2016 03:22 PM, David Miller wrote: By default, GMAC0 is connected to built-in switch called MT7530 through the proprietary interface called Turbo RGMII (TRGMII). TRGMII also supports well for RGMII as generic external PHY uses but requires some slight changes to the setup of TRG

Re: [PATCH] clk: renesas: build clk-rcar-gen2.o for R8A7792

2016-06-20 Thread Sergei Shtylyov
Hello. On 06/20/2016 06:43 PM, Arnd Bergmann wrote: The newly added support for R8A7792 causes build failures because we try to call rcar_gen2_clocks_init but that is not built into the kernel: arch/arm/mach-shmobile/built-in.o: In function `rcar_gen2_timer_init': :(.init.text+0x3b0): undefine

Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

2016-06-21 Thread Sergei Shtylyov
Hello. On 6/21/2016 6:56 AM, Yisen Zhuang wrote: From: Jun He When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and read new fbd_num to start new receive cycle. It recomputes cycle num is fbd_num minus clean_count, actually this cycle num is too big because it drop out rece

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2016 6:32 AM, Sean Wang wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. .. deleted What? Why? switch (of_get_phy_mode(np)) { + case PHY_INTERFACE_MODE_TRGMII: +

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-23 Thread Sergei Shtylyov
Hello. On 9/23/2016 3:13 AM, David Miller wrote: Despite my comments? Sigh... Sorry, I thought he had addressed your feedback in v2. IIRC, I had only commented to v2, not v1. I'll wait longer next time. Thank you. :-) MBR, Sergei

Re: [PATCH net-next 07/15] rxrpc: Fix accidental cancellation of scheduled resend by ACK parser

2016-09-23 Thread Sergei Shtylyov
Hello. On 09/23/2016 06:16 PM, David Howells wrote: When rxrpc_input_soft_acks() is parsing the soft-ACKs from an ACK packet, it updates the Tx packet annotations in the annotation buffer. If a soft-ACK is an ACK, then we overwrite unack'd, nak'd or to-be-retransmitted states and that is fine;

Re: [PATCH net-next 08/15] rxrpc: Fix call timer

2016-09-23 Thread Sergei Shtylyov
On 09/23/2016 06:16 PM, David Howells wrote: Fix the call timer in the following ways: (1) If call->resend_at or call->ack_at are before or equal to the current time, then ignore that timeout. (2) If call->expire_at is before or equal to the current time, then don't set the timer a

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actual

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be declard

Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces

2016-09-25 Thread Sergei Shtylyov
Hello. On 9/25/2016 2:15 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 25 Sep 2016 12:50:21 +0200 Do not use curly brackets at eight source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring --- drivers/isdn/capi/capidrv.c | 30 +

Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses

2016-09-26 Thread Sergei Shtylyov
Hello. On 09/26/2016 06:44 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 26 Sep 2016 17:03:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. WARNING: sizeo

Re: [PATCH] net: thunderx: correct bound check in nic_config_loopback

2016-07-31 Thread Sergei Shtylyov
Hello. On 7/31/2016 5:49 AM, Levin, Alexander wrote: Off by one in nic_config_loopback would access an invalid arrat variable when Array? vf id == MAX_LMAC. Signed-off-by: Sasha Levin [...] MBR, Sergei

Re: [PATCH 1/1] dsa: b53: remove redundant if

2016-07-31 Thread Sergei Shtylyov
Hello. On 7/31/2016 10:42 AM, Heinrich Schuchardt wrote: For pdata == null the code leaves with an error. There is need to check the condition again. No need, you mean? Signed-off-by: Heinrich Schuchardt [...] MBR, Sergei

<    2   3   4   5   6   7   8   9   10   11   >