Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread Sergei Shtylyov
On 23-05-2013 10:01, Ravi Babu wrote: The am33xx platforms suppors dual musb instance which need two instances of usb-phy. Add dual instance usb-phy DT bindings for am333x platform. Signed-off-by: Ravi Babu --- arch/arm/boot/dts/am33xx.dtsi | 17 + 1 files changed, 17 in

Re: [net-next RFC 3/8] macvtap: introduce macvtap_get_vlan()

2013-05-23 Thread Sergei Shtylyov
Hello. On 23-05-2013 7:12, Jason Wang wrote: Factor out the device holding logic to a macvtap_get_vlan(), this will be also used by multiqueue API. Signed-off-by: Jason Wang --- drivers/net/macvtap.c | 26 +++--- 1 files changed, 19 insertions(+), 7 deletions(-)

Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread Sergei Shtylyov
Hello. On 05/23/2013 09:13 PM, B, Ravi wrote: + phy1: usbphy-gs70@44e10620 { + compatible = "ti,dsps-usbphy"; + reg = <0x44e10620 0x8 + 0x44e10648 0x4>; + reg-names = "phy_ctrl","phy_w

Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread Sergei Shtylyov
Hello. On 05/23/2013 09:07 PM, B, Ravi wrote: removed unused nop xceiv (un_)register API's from all musb platform drivers Since when are they unused? Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller. Usb_get_phy() is used to get the

Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-24 Thread Sergei Shtylyov
Hello. On 24-05-2013 9:34, B, Ravi wrote: removed unused nop xceiv (un_)register API's from all musb platform drivers Since when are they unused? Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller. Usb_get_phy() is used to get the

Re: [PATCH] usbfs: Increase arbitrary limit for USB 3 isopkt length

2013-05-24 Thread Sergei Shtylyov
Hello. On 24-05-2013 12:47, Federico Manzan wrote: Increase the current arbitrary limit for isocronous packet size to a value large enough to account for USB 3.0 super bandwidth streams, bMaxBurst (0~15 allowed, 1~16 packets) bmAttributes (bit 1:0, mult 0~2, 1~3 packets) so the size max for one

Re: [PATCH 1/3] drivers: regulator: palmas: add an API to set/clear the switch bit on SMPS10

2013-05-24 Thread Sergei Shtylyov
Hello. On 24-05-2013 18:31, Kishon Vijay Abraham I wrote: From: Graeme Gregory Added an API to set/clear the switch bit on SMPS10 which can be used by palmas usb. The switch bit should be set in order for palmas to supply VBUS and is needed when OMAP is acting as USB HOST. Signed-off-by:

Re: [PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 4:49, Laurent Pinchart wrote: From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c |

Re: [PATCH v3 2/9] media: davinci: vpif: Convert to devm_* api

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/p

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: From: Lad, Prabhakar Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to channel objects to remove() ca

Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-26 Thread Sergei Shtylyov
Hello. On 26-05-2013 17:17, atom...@redhat.com wrote: From: Aaron Tomlin Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless

Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 0:35, Aaro Koskinen wrote: When booting a new board for the first time, the console is flooded with "Unknown board" messages. This is not really helpful. Board type is not going to change after the boot, so it's sufficient to print the warning only once. Signed-off-by: A

Re: [PATCH v8, part3 12/14] mm: correctly update zone->mamaged_pages

2013-05-27 Thread Sergei Shtylyov
On 26-05-2013 17:38, Jiang Liu wrote: Typo in the subject: s/mamaged_pages/managed_pages/. Enhance adjust_managed_page_count() to adjust totalhigh_pages for highmem pages. And change code which directly adjusts totalram_pages to use adjust_managed_page_count() because it adjusts totalram_pag

Re: [PATCH 2/2] USB: hcd: only unmap the actual completed DMA buffer

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 20:13, Ming Lei wrote: This patch only unmap the actual completed DMA buffer instead of the whole transfer buffer. Who will unmap the rest of the buffer? It is common to see only part of DMA transfer is completed, especially in case of DMA_FROM_DEVICE because the le

Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once

2013-05-27 Thread Sergei Shtylyov
On 27-05-2013 14:19, Sergei Shtylyov wrote: When booting a new board for the first time, the console is flooded with "Unknown board" messages. This is not really helpful. Board type is not going to change after the boot, so it's sufficient to print the warning only once. Sign

Re: [Patch v1] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Sergei Shtylyov
Hello. On 26-05-2013 20:28, Sergei Shtylyov wrote: From: Aaron Tomlin Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 0:19, atom...@redhat.com wrote: From: Aaron Tomlin Since v1: - Removed unnecessary parentheses The "changes since version X" section should typically go after --- tearline, else the mainatiner will have to edit your patch before applying. ---8<--- Failed G

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Sergei Shtylyov
Hello. On 22-05-2013 7:30, Libo Chen wrote: when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei It seems you've actually replaced "fail" with "faild", not "fails". Si

Re: [PATCH] net/core/sock.c: add missing VSOCK string in af_family_*_key_strings

2013-05-28 Thread Sergei Shtylyov
Hello. On 28-05-2013 19:02, Federico Vaga wrote: The three arrays of strings: af_family_kay_strings, s/kay/key/. Maybe whoever applies this could fix the typo... af_family_slock_key_strings and af_family_clock_key_strings have not VSOCK's string Signed-off-by: Federico Vaga WBR, Se

Re: [PATCH net-next] audit: pass int* to nlmsg_next

2013-03-29 Thread Sergei Shtylyov
Hello. On 29-03-2013 1:31, Alexandru Copot wrote: Commit 941912133025926307c7a65b203fa38403b1063a Please also specify the summary line of that commit in parens (or however you like). With that, you can add my: Acked-by: Sergei Shtylyov replaced the macros NLMSG_NEXT with calls to

Re: [PATCH v2] [libata] Fix HDIO_DRIVE_CMD ioctl sense data check

2013-03-29 Thread Sergei Shtylyov
Hello. On 03/29/2013 08:12 PM, Gwendal Grignou wrote: commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 Please, also specify that commit's summary line in parens (or however you like). changed the sense key used for returning task registers, but HDIO_DRIVE_CMD ioctl was not changed accor

Re: [PATCH net-next 7/7] r8169: fix could not dump registers

2013-04-01 Thread Sergei Shtylyov
Hello. On 01-04-2013 17:55, Hayes Wang wrote: For new version of Fedora and Ubuntu, we see all 0xff when dumping the hw regs through ethtool. Using a loop to read registers could fix it. Signed-off-by: Hayes Wang --- drivers/net/ethernet/realtek/r8169.c | 6 +- 1 file changed, 5 inse

Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set

2013-03-07 Thread Sergei Shtylyov
Hello. On 07-03-2013 7:26, Wenyou Yang wrote: commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e Please also specify the summary line of that commit in parens (or however you like). cause the atmel spi probing failure. Signed-off-by: Wenyou Yang Cc: spi-devel-gene...@lists.sourceforg

Re: [PATCH] usb: serial: Add Rigblaster Advantage to device table

2013-03-07 Thread Sergei Shtylyov
Hello. On 03/08/2013 01:01 AM, Steve Conklin wrote: The Rigblaster Advantage is an amateur radio interface sold by West Mountain Radio. It contains a cp210x serial interface but the device ID is not in the driver. Wrap your changelog lines at about 76 (80 max) characters please. Signed

Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread Sergei Shtylyov
Hello. On 08-03-2013 16:53, oskar.and...@sonymobile.com wrote: From: Truls Bengtsson The udc_irq service runs the isr_tr_complete_handler which in turn "nukes" the endpoints, including a call to rndis_response_complete, if appropriate. If the rndis_msg_parser fails here, an error will be pr

Re: [PATCH] ARM: imx: fix typo "DEBUG_IMX50_IMX53_UART"

2013-03-11 Thread Sergei Shtylyov
Hello. On 11-03-2013 17:16, Paul Bolle wrote: Signed-off-by: Paul Bolle --- 0) Tested by grepping the tree. 1) Typo was added in commit f8c95fe6d9adad72fc7bce90f4ab68d119f50c5b ("ARM: imx: support DEBUG_LL uart port selection for all i.MX SoCs"). Looking at that patch and at the tree makes

Re: [PATCH] pci: use newly introduced devm_ioremap_resource()

2013-03-11 Thread Sergei Shtylyov
Hello. On 03/11/2013 06:24 PM, Silviu-Mihai Popescu wrote: Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be

Re: [PATCH 06/22] ARM: LPAE: use phys_addr_t in alloc_init_pud()

2012-08-01 Thread Sergei Shtylyov
Hello. On 01-08-2012 3:04, Cyril Chemparathy wrote: From: Vitaly Andrianov This patch fixes the alloc_init_pud() function to use phys_addr_t instead of unsigned long when passing in the phys argument. This is an extension to commit 97092e0c56830457af0639f6bd904537a150ea4a, which Ple

Re: [PATCH 1/4] arm/dts: omap5-evm: Add I2C support

2012-08-03 Thread Sergei Shtylyov
Hello. On 08/03/2012 04:38 PM, Sourav Poddar wrote: > Add I2C data node in omap5 device tree file. > Tested on omap5430 sdp. > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > Acked-by: Felipe Balbi > Signed-off-by: Sourav Poddar > --- > arch/arm/boot/dts/omap5.dtsi | 35

Re: [PATCH 6/6] i2c: davinci: use devm_ functions

2012-08-27 Thread Sergei Shtylyov
Hello. On 08/25/2012 09:41 PM, Julia Lawall wrote: > From: Julia Lawall > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remo

Re: [PATCH v4 12/24] xen/arm: introduce CONFIG_XEN on ARM

2012-09-17 Thread Sergei Shtylyov
Hello. On 17-09-2012 14:57, Stefano Stabellini wrote: Changes in v2: - mark Xen guest support on ARM as EXPERIMENTAL. Signed-off-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk --- arch/arm/Kconfig | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread Sergei Shtylyov
Hello. On 17-09-2012 14:37, Vipul Kumar Samar wrote: clk_{un}prepare is mandatory for platforms using common clock framework. Add clk_{un}prepare() support for spi-pl022 runtime PM. Signed-off-by: Vipul Kumar Samar [...] @@ -2342,10 +2342,13 @@ static int pl022_runtime_suspend(struct dev

Re: [PATCH] usbhid: call report_fixup before comparing descriptors

2012-09-18 Thread Sergei Shtylyov
Hello. On 18-09-2012 0:05, Kevin Daughtridge wrote: hid_post_reset checks the stored report descriptor against what is currently returned by the device. An HID driver's report_fixup method may have changed the stored descriptor, however, creating false positives. These leave some devices nonfun

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Sergei Shtylyov
Hello. On 19-09-2012 6:36, Kevin Daughtridge wrote: The dev_rdesc member of the hid_device structure is meant to store the original report descriptor received from the device, but it is currently passed to any report_fixup method before it is copied to the rdesc member. This patch moves the kme

Re: [PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>

Re: [PATCH 7/9] ht6560b: use driver name for resource allocation

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH 1/5] ide: remove PIO "downgrade" quirk

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: No need for it nowadays Since which moment, could you elaborate so remove quirk code from ide_get_best_pio_mode() and IDE_HFLAG_PIO_DOWNGRADE host flag. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from th

Re: [PATCH 2/4] ide-disk: add missing printk() KERN_* levels

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [PATCH 8/9] qd65xx: return error value in qd_probe()

2008-02-18 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Return error value in qd_probe() and use it in qd65xx_init() instead of checking ide_hwifs[].chipset. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe fr

Re: [PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>

Re: [PATCH 4/5] ide-generic: use ide_find_port()

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> Index: b/drivers/ide/i

Re: [PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: There are no changes to the resulting drivers/ide/ide-disk.o binary file (md5sum-s after and before the patch match). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: CONFIG_BLK_DEV_4DRIVES deserves its own host driver: * Add drivers/ide/legacy/ide-4drives.c and move "4drives" support there. * Add ide-4drives.o in the link order after all other legacy host drivers enabled by "ide0=" options (they all are mutually exclu

Re: [Kgdb-bugreport] [PATCH 4/5] KGDB-8250: refactor configuration

2008-02-06 Thread Sergei Shtylyov
Hello. Jan Kiszka wrote: Sorry, previous version was missing some __init[data] attributes which were dropped in an intermediate stage. Here comes an updated patch: <---snip---> This major refactoring of the quite complex kgdb8250 configuration does the following: - ensures that static

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Sergei Shtylyov
<[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-07 Thread Sergei Shtylyov
patch? Replacing printk() with BUG_ON() and also removing BUG_ON() from ide_execute_command()? OK, will do... Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line &

Re: [PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-07 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Factor out cable detection to palm_bk3710_cable_detect(). Cc: Anton Salnikov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Index: b/drivers/ide/arm/palm_bk3710.c

Re: [PATCH 3/5] ide: remove ide_setup_ports()

2008-02-07 Thread Sergei Shtylyov
iej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordom

Re: [PATCH 05/18] ide: factor out cable detection from ide_init_port()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Factor out cable detection from ide_init_port() to ide_port_cable_detect(). * Move ide_port_cable_detect() call to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECT

Re: [PATCH 02/18] ide: fix ide_find_port()

2008-02-08 Thread Sergei Shtylyov
only user of ide_find_port() which needs such fixup). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [PATCH] pdc202xx_old: always enable burst mode

2008-02-08 Thread Sergei Shtylyov
AIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-08 Thread Sergei Shtylyov
ization. Cc: Anton Salnikov <[EMAIL PROTECTED]> Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 08/18] ide: move ide_port_setup_devices() call to ide_device_add_all()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move ide_port_setup_devices() call from init_irq() to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECT

Re: [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Probe port _after_ it is fully initialized. Hm, I thought the usual sequence is vice versa: you first probe and then initialize. :-) Cc: Anton Salnikov <[EMAIL PROTECTED]> Cc: Sergei Shtylyov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zo

Re: [PATCH] ide: remove ->hold field from ide_hwif_t (take 2)

2008-02-09 Thread Sergei Shtylyov
gt; Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/3] ide-tape: remove never executed code

2008-02-09 Thread Sergei Shtylyov
ere should be no functional changes caused by this patch. Cc: Borislav Petkov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "un

Re: ide/arm/bast-ide.c compile error

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove 'ide_hwif_t **hwif' argument from bastide_register() (together with write-only ifs[]). Cc: Adrian Bunk <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>

Re: [PATCH 06/18] ide: factor out code unregistering devices from ide_unregister()

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Factor out code unregistering devices from ide_unregister() to ide_port_unregister_devices(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this li

Re: [PATCH 07/18] ide: factor out devices init from ide_init_port_data()

2008-02-09 Thread Sergei Shtylyov
Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH] USB: plusb: Add support for PL-2501

2012-07-23 Thread Sergei Shtylyov
Hello. On 22-07-2012 21:42, kyak wrote: From: Mikhail Peselnik This patch adds support for PL-2501 by adding the appropriate USB ID's. This chip is used in several USB 'Easy Trasfer' Cables. Signed-off-by: Mikhail Peselnik Tested-by: Mikhail Peselnik --- Now with proper sign-offs and r

Re: [PATCH 4/5] scsi: pm: use runtime resume callback if available

2012-07-23 Thread Sergei Shtylyov
Hello. On 07/23/2012 10:49 AM, Aaron Lu wrote: > When runtime resume a scsi device, if the device's driver has > implemented runtime resume callback, use that instead of the resume > callback. > sr driver needs this to properly do different things for system resume > and runtime resume. > Signe

Re: [PATCH 1/2] xhci: provide usb_disable_xhci_ports function for Intel chipsets.

2012-07-23 Thread Sergei Shtylyov
Hello. On 07/23/2012 03:46 PM, Denis Turischev wrote: > Some devices with Intel Panther Point chipset may require switchover > usb ports from XHCI back to EHCI controller before shutdown. > Overwise various BIOS bugs related to power management may be > triggered. > Signed-off-by: Denis Turische

Re: [PATCH 2/6] ARM: davinci: remove rtc kicker release

2012-07-24 Thread Sergei Shtylyov
Hello. On 23-07-2012 17:42, Afzal Mohammed wrote: rtc-omap driver is now capable of handling kicker mechanism, hence remove kicker handling at platform level, instead provide proper device name so that driver can handle kicker mechanism by itself Signed-off-by: Afzal Mohammed --- arch/arm

Re: [PATCH v2 1/6] rtc: omap: kicker mechanism support

2012-07-25 Thread Sergei Shtylyov
Hello. On 25-07-2012 10:12, Afzal Mohammed wrote: OMAP RTC IP can have kicker feature. This prevents spurious writes to register. To write to registers kicker lock has to be released. Procedure to do it as follows, 1. write to kick0 register, 0x83e70b13 2. write to kick1 register, 0x95a4f1e0

Re: [PATCH v2 6/6] arm/dts: am33xx rtc node

2012-07-25 Thread Sergei Shtylyov
Hello. On 25-07-2012 10:12, Afzal Mohammed wrote: Add AM33xx rtc node. Signed-off-by: Afzal Mohammed --- v2: Use compatible as ti,da830-rtc instead of ti,am1808-rtc arch/arm/boot/dts/am33xx.dtsi |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/a

Re: [PATCH v2 6/6] arm/dts: am33xx rtc node

2012-07-25 Thread Sergei Shtylyov
Hello. On 07/25/2012 06:09 PM, Mohammed, Afzal wrote: >>> + rtc@44e3e000 { >> Address postfix in the node name without "reg" property? > As per [1], "The unit-address is included if the node describes > a device with an address". Which in this case it doesn't. > Here even tho

Re: [PATCH 03/13] ide: Potential null pointer dereference in ide_queue_pc_tail()

2012-08-17 Thread Sergei Shtylyov
Hello. On 09.08.2012 18:13, Alan Cox wrote: On Thu, 9 Aug 2012 17:55:20 +0400 Marina Makienko wrote: The function blk_get_request() can return NULL in some cases. There are checks on it if function is called with argumetns one of which is GFP_ATOMIC/GFP_NOIO/etc. If system couldn't find re

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Sergei Shtylyov
Hello. On 21-08-2012 8:06, manoj.i...@canonical.com wrote: From: Manoj Iyer USB 3.0 devices show up as high-speed devices on powerup, after an s3 cycle they are correctly recognized as SuperSpeed. At powerup unconditionally switch the port to xHCI like we do when we resume from suspend.

Re: [PATCH] usb: twl6030-usb: variable otg not declared in twl6030_usbotg_irq() in linux-next

2012-07-11 Thread Sergei Shtylyov
Hello. On 10-07-2012 10:32, Gerard Snitselaar wrote: commit ff9cce82 added back 2 lines that were removed by commit c83a8542 Please also specify the summaries of those 2 commits in parens. causing build of twl6030-usb to get an error due to otg being referenced, but not declared. This pa

Re: [PATCH] usb: musb: core: Add missing newline character

2013-01-21 Thread Sergei Shtylyov
Hello. On 01/21/2013 05:52 PM, Kishon Vijay Abraham I wrote: > No functional change. Just added a missing newline character. > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/usb/musb/musb_core.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/usb/musb/

Re: [PATCH 13/15] drivers/usb/musb/omap2430.c: adjust duplicate test

2013-01-21 Thread Sergei Shtylyov
On 21-01-2013 17:02, Julia Lawall wrote: From: Julia Lawall Delete successive tests to the same location. Data is the just previously allocated and tested value. Test the result of the allocation made here instead. A simplified version of the semantic match that finds this problem is as

Re: [PATCH v2 2/2] ARM: davinci: enable SRAM ping ping buffering on DA850

2012-10-12 Thread Sergei Shtylyov
Hello. On 11-10-2012 23:33, Matt Porter wrote: Passes the DA850 shared SRAM gen_pool to the McASP driver and enables the ping-pong buffer DMA support. Here "ping-pong is correct but the subject have a typo. Signed-off-by: Matt Porter WBR, Sergei -- To unsubscribe from this list: sen

Re: [PATCH] USB: select USB_ARCH_HAS_EHCI for MXS

2013-01-10 Thread Sergei Shtylyov
Hello. On 01/10/2013 06:35 PM, Maxime Ripard wrote: > Commit 09f6ffde introduced a dependency on USB_EHCI_HCD for the chipidea Please also specify the summary of that commit in parens (or however you like). > USB host driver, that in turns depends on USB_ARCH_HAS_EHCI. > If this symbol is

Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-10 Thread Sergei Shtylyov
Hello. On 01/10/2013 07:51 PM, Roger Quadros wrote: > We use "vcc" as the supply name for the PHY's power supply. > The power supply will be enabled during .init() and disabled > during .shutdown() > Signed-off-by: Roger Quadros > --- > drivers/usb/otg/nop-usb-xceiv.c | 18 ++

Re: [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed

2013-01-14 Thread Sergei Shtylyov
Hello. On 14-01-2013 6:04, Tony Prisk wrote: Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EBUSY rather than -ENOMEM. Not really well justifie

Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part of control module

2013-01-15 Thread Sergei Shtylyov
Hello. On 15-01-2013 12:42, Kishon Vijay Abraham I wrote: A seperate driver has been added to handle the usb part of control module. A device for the above driver is created here, using the register address information to be used by the driver for powering on the PHY and for writing to the mail

Re: [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core

2012-09-30 Thread Sergei Shtylyov
Hello. On 28-09-2012 14:53, Kishon Vijay Abraham I wrote: Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I [...] diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 08a5738..0c17a7a 100

Re: [PATCH v2 6/7] usb: dwc3-omap: Minor fixes to get dt working

2012-10-01 Thread Sergei Shtylyov
Hello. On 01-10-2012 12:25, Kishon Vijay Abraham I wrote: Includes few minor fixes in dwc3-omap like populating the compatible string in a correct way, extracting the utmi-mode property properly and changing the index of get_irq since irq of core is removed from hwmod entry. Also updated the do

Re: [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed

2013-01-16 Thread Sergei Shtylyov
Hello. On 15-01-2013 8:58, Tony Prisk wrote: Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EBUSY rather than -EADDRNOTAVAIL. You meant "-EADDR

Re: [PATCH v6 11/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap()

2013-01-16 Thread Sergei Shtylyov
Hello. On 01/16/2013 05:43 PM, Roger Quadros wrote: > Use devm_ variants of kzalloc and ioremap. Also clean up error path. > Signed-off-by: Roger Quadros [...] > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > index 061366d..0f190b6 100644 > --- a/drivers/mfd/omap-usb-

Re: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2013-01-16 Thread Sergei Shtylyov
Hello. On 01/16/2013 05:43 PM, Roger Quadros wrote: > Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-tll.c | 36 +++- > 1 files changed, 11 insertions(+), 25 deletions(-) > d

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Sergei Shtylyov
Hello. On 17-01-2013 14:46, Linus Walleij wrote: wrote: This patch converts the module to use clk_prepare_enable and clk_disable_unprepare variants as required by common clock framework. Without this the system crash during probe function. Signed-off-by: Fabio Baltieri Acked-by: L

Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part of control module

2013-01-17 Thread Sergei Shtylyov
Hello. On 01/15/2013 05:26 PM, kishon wrote: >> On 15-01-2013 12:42, Kishon Vijay Abraham I wrote: >>> A seperate driver has been added to handle the usb part of control >>> module. A device for the above driver is created here, using the register >>> address information to be used by the driver

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Sergei Shtylyov
Ravnborg <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] IDE: Coding Style fixes to drivers/ide/pci/it8213.c

2008-02-25 Thread Sergei Shtylyov
Paolo Ciarrocchi wrote: File is now error free, only a few WARNING: line over 80 characters are left. Compile tested. Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: s

Re: USB: option: Add MEDIATEK product ids

2012-07-06 Thread Sergei Shtylyov
On 07/06/2012 05:50 PM, gaosen wrote: > From 86fcd5bb701bd927d588386c480c37784d10040a Mon Sep 17 00:00:00 2001 > From: Gaosen Zhang > Date: Fri, 6 Jul 2012 21:44:10 +0800 > Subject: [PATCH 1/1] USB: option: Add MEDIATEK product ids > Signed-off-by: Gaosen Zhang > --- > drivers/usb/serial/optio

Re: [PATCH] drivers: xhci: fix incorrect bit test

2013-01-08 Thread Sergei Shtylyov
Hello. On 08-01-2013 7:39, Nickolai Zeldovich wrote: Fix incorrect bit test that originally showed up in 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'. Please also specify the summary of that commit in parens (or however you like). Signed-off-by: Nickolai Zeldovich

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2013-01-08 Thread Sergei Shtylyov
Hello. On 09/11/2012 01:09 PM, Kishon Vijay Abraham I wrote: > Added device tree support for omap musb driver and updated the > Documentation with device tree binding information. > Signed-off-by: Kishon Vijay Abraham I Belated comments to the patch which didn't pass my message size filter

Re: [PATCH 2/3] ide-pmac: macio resource freeing bugfix

2008-01-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Release DMA resource before zeroing pmif. Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this l

Re: [PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

2008-01-09 Thread Sergei Shtylyov
HNY. :-) Bartlomiej Zolnierkiewicz wrote: * Move wait_hwif_ready() documentation before this function. * Fix trailing whitespaces. * s/wait-for-busy/wait-for-non-busy/ * Remove no longer valid comment about the current code behavior. * Docbook-ize it. * Rename wait_hwif_ready() t

Re: [PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

2008-01-09 Thread Sergei Shtylyov
(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Oops, forgot to stamp: Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

Re: Peculiar out-of-sync boot log lines

2007-12-07 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: DMA reporting and validity checking fixes (take 2) * ide_xfer_verbose() fixups: - beautify returned mode names - fix PIO5 reporting - make it return 'const char *' * Change printk() level from KERN_DEBUG to KERN_INFO in ide_find_d

Re: [PATCH 08/16] ide: remove ->nice0 and ->nice2 fields from ide_drive_t

2008-01-22 Thread Sergei Shtylyov
lt;[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read th

Re: [PATCH 07/16] ide: convert ->straight8 field in ide_hwif_t to bit flag

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH 10/16] ide: use __ide_set_handler() in ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Use __ide_set_handler() in ide_execute_command(). While at it: * Fix whitespace damage in ide_execute_command(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR,

Re: [PATCH 12/16] ide: remove set_transfer()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH 06/16] ide: remove unused ->auto_poll field from ide_hwif_t

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [PATCH 04/16] ide-cris: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [PATCH 01/16] ide-tape: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [PATCH 02/16] ide-scsi: use ide_execute_command()

2008-01-22 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

<    1   2   3   4   5   6   7   8   9   10   >