Re: [PATCH] ARM: fix debug prints relevant to PCI devices

2014-06-04 Thread Sergei Shtylyov
Hello. On 06/04/2014 11:17 PM, Vidya Sagar wrote: As per PCIe spec, fast back-to-back transactions feature is not applicable to PCIe devices. Hence, do not print that fast back-to-back trasactions are disabled when there is a PCIe device found on the bus Signed-off-by: Vidya Sagar --- arc

Re: [PATCH] net: Revert "fib_trie: use seq_file_net rather than seq->private"

2014-06-04 Thread Sergei Shtylyov
On 06/05/2014 02:02 AM, Sasha Levin wrote: This reverts commit 30f38d2fdd79f13fc929489f7e6e517b4a4bfe63. fib_triestat is surrounded by a big lie: while it claims that it's a seq_file (fib_triestat_seq_open, fib_triestat_seq_show), it isn't: static const struct file_operations fib_t

Re: [PATCH] Fixes two memory leaks in drivers/clk/sunxi/clk-sunxi.c

2014-06-14 Thread Sergei Shtylyov
Hello. On 06/14/2014 05:47 AM, Nick wrote: Please sign off on your patches, they can't applied otherwise. diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 4264834..07b45d1 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -41,9

Re: [PATCH] Frees gate after if statement in clk-sunxi.c

2014-06-14 Thread Sergei Shtylyov
On 06/14/2014 10:11 PM, Nick wrote: Signed-off-by: Nick --- drivers/clk/sunxi/clk-sunxi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 4264834..6f4fc51 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/su

Re: [PATCH] Missing return check against Null for return value of netdev_alloc_dev_skb()

2014-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2014 12:27 AM, Nick Krause wrote: From 62b0d77a1430f74b7f5c008c5e8bec11604b33b0 Mon Sep 17 00:00:00 2001 From: Nick Date: Sun, 15 Jun 2014 16:16:14 -0400 Subject: [PATCHv2] Fixes return logic of function of pch_gbe_alloc_tx_buffers() Here is the fixed patch changed return type

Re: [PATCH] net: tile: fix unused variable warning

2014-06-16 Thread Sergei Shtylyov
Hello. On 06/16/2014 09:14 PM, Chris Metcalf wrote: 'i' is unused in tile_net_dev_init() after commit d581ebf5a1f. Please also specify that commit's summary line in parens. Signed-off-by: Chris Metcalf WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-24 Thread Sergei Shtylyov
Hello. On 06/24/2014 07:51 PM, Chen, Alvin wrote: From: Bryan O'Donoghue This patch is to enable USB host controller for Intel Quark X1000. Add pci quirks to adjust the packet buffer in/out threshold value, and ensure EHCI packet buffer i/o threshold value is reconfigured to half. Sign

Re: [PATCH 2/4] usb: host: xhci-plat: Add support to get PHYs

2014-06-24 Thread Sergei Shtylyov
Hello. On 06/10/2014 12:22 AM, Julius Werner wrote: diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index 9ffecd5..453d89e 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1582,6 +1582,9 @@ struct xhci_hcd { u32 port_status_u0;

Re: [PATCH v7 1/7] phy: add a driver for the Berlin SATA PHY

2014-06-25 Thread Sergei Shtylyov
Hello. On 06/23/2014 05:39 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. The mode selection can let us think this PHY can be configured to fit other purposes. But there are reasons to think the SATA mode will be the only one usable: the PHY r

Re: [PATCH 2/4] phy: miphy365x: Add MiPHY365x header file for DT x Driver defines

2014-06-25 Thread Sergei Shtylyov
Hello. On 05/22/2014 05:53 PM, Lee Jones wrote: This provides the shared header file which will be reference from both the MiPHY365x driver and its associated Device Tree node(s). Cc: Kishon Vijay Abraham I Acked-by: Mark Rutland Acked-by: Alexandre Torgue Signed-off-by: Lee Jones ---

Re: [PATCH 3/3] net: ethoc: document OF bindings

2014-01-27 Thread Sergei Shtylyov
Hello. On 27-01-2014 18:10, Rob Herring wrote: Signed-off-by: Max Filippov --- .../devicetree/bindings/net/opencores-ethoc.txt| 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/opencores-ethoc.txt diff --git a/Docu

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Sergei Shtylyov
Hello. On 01/28/2014 01:29 AM, xypron.g...@gmx.de wrote: From: Heinrich Schuchardt p is freed if NULL. This is not an issue. p is leaked if second calloc fails. Signed-off-by: Heinrich Schuchardt --- drivers/staging/usbip/userspace/libsrc/names.c |2 +- 1 file changed, 1 ins

Re: [RFC PATCH] net: ipv4: move inetpeer garbage collector work to power efficient workqueue

2014-01-31 Thread Sergei Shtylyov
Hello. On 31-01-2014 3:40, Zoran Markovic wrote: From: Shaibal Dutta Garbage collector work does not have to be bound to the CPU that scheduled it. By moving work to the power-efficient workqueue, the selection of CPU executing the work is left to the scheduler. This extends idle residency

Re: [PATCH v3 5/5] can: sja1000: of: add reg-io-width property for 8, 16 and 32-bit register access

2014-01-31 Thread Sergei Shtylyov
Hello. On 31-01-2014 17:34, Florian Vaussard wrote: Add the 'reg-io-width' property for 8, 16 and 32-bit access, like what is currently done with IORESOURCE_MEM_{8,16,32}BIT for non-OF boot. Signed-off-by: Florian Vaussard --- drivers/net/can/sja1000/sja1000_platform.c | 16 ++

Re: [PATCH 02/34] bnx2x: Use pci_enable_msix_range()

2014-01-31 Thread Sergei Shtylyov
Hello. On 01/31/2014 06:08 PM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces.

Re: [PATCH 12/34] e1000e: Use pci_enable_msix_range()

2014-01-31 Thread Sergei Shtylyov
Hello. On 01/31/2014 06:08 PM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces.

Re: [PATCH 17/34] ixgbevf: Use pci_enable_msix_range()

2014-01-31 Thread Sergei Shtylyov
On 01/31/2014 06:08 PM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Sign

Re: [PATCH 18/34] mlx4: Use pci_enable_msix_range()

2014-01-31 Thread Sergei Shtylyov
Hello. On 01/31/2014 06:08 PM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces.

Re: [PATCH 20/34] myri10ge: Use pci_enable_msix_range()

2014-01-31 Thread Sergei Shtylyov
Hello. On 01/31/2014 06:08 PM, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces.

Re: [PATCH v3 3/5] ASoC: tda998x: add DT documentation of the tda998x CODEC

2014-02-01 Thread Sergei Shtylyov
Hello. On 01-02-2014 20:48, Jean-Francois Moine wrote: This patch adds the DT documentation of the NXP TDA998x CODEC. Signed-off-by: Jean-Francois Moine --- Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 17 + 1 file changed, 17 insertions(+) diff --git a/Docu

Re: [PATCH v3 0/6] IIO pulse capture support for TI ECAP

2014-02-05 Thread Sergei Shtylyov
Hello. On 02/05/2014 10:01 PM, Matt Porter wrote: [...] This series adds support for PWM capture devices within IIO and adds a TI ECAP IIO driver. PWM capture devices are supported using a new IIO "pulse" channel type. The IIO ECAP driver implements interrupt driven triggered buffer capt

Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Sergei Shtylyov
Hello. On 09-12-2013 15:21, srinivas kandagatla wrote: +static int sun7i_gmac_init(struct platform_device *pdev) +{ + struct resource *res; + struct device *dev = &pdev->dev; + void __iomem *addr = NULL; + struct plat_stmmacenet_data *plat_dat = NULL; No need to ini

Re: [PATCH] net-tg3: Initialize REG_BASE_ADDR at PCI config offset 120 to 0

2013-12-09 Thread Sergei Shtylyov
Hello. On 12/09/2013 10:22 PM, Natarajan Gurumoorthy wrote: Michael, We had crashes when the PCI config space got scanned via /sys/devices/pci/../config. I agree that this fix will not help if the scan happens before the tg3 driver gets loaded. Then perhaps a better place

Re: [PATCH] irqchip: Renesas IRQC driver

2013-12-11 Thread Sergei Shtylyov
Hello. On 02/27/2013 11:15 AM, Magnus Damm wrote: From: Magnus Damm Magnus, explain me one thing about your driver please. This patch adds a driver for external IRQ pins connected to the IRQC hardware block on recent SoCs from Renesas. The IRQC hardware block is used together with more

Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup

2013-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2013 08:59 PM, Mariusz Ceier wrote: When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't, emac_dev_mcast_set should only enable RX of multicasts and reset MACHASH registers. It does this, but afterwards it either sets up multicast MACs filtering or disables RX of

Re: [PATCH] ARM: dts: am4372: Add McASP nodes

2013-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2013 01:45 PM, Peter Ujfalusi wrote: Add nodes for McASP0 and McASP1 for AM43xx. Signed-off-by: Peter Ujfalusi --- arch/arm/boot/dts/am4372.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boo

Re: [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c

2013-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2013 02:08 PM, Rashika Kheria wrote: Include appropriate header file ide-cd.h in ide-cd_verbose.c because function ide_cd_log_error() has its prototype declaration in ide-cd.h. Also, include linux/ide.h because it contains certain declarations necessary for including ide-cd.h.

Re: [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c

2013-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2013 08:54 PM, Borislav Petkov wrote: The two proposed patches here are extremely low risk, don't actually change the compiled code in any way like some of those did, and fix real compiler warnings. Considering the fact that IDE is about to be deleted (unless something embedd

Re: [PATCH v2 1/3] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 3:55, Apelete Seketeli wrote: Add defconfig for the Ben NanoNote handheld computer which is built around QI_LB60 board and Ingenic JZ4740 MIPS SoC. Signed-off-by: Apelete Seketeli --- arch/mips/configs/qi_lb60_defconfig | 188 +++ 1 f

Re: [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c

2013-12-18 Thread Sergei Shtylyov
On 12/17/2013 10:06 PM, Borislav Petkov wrote: You're right in your doubting: there are quite a lot of drivers used by embedded platforms that nobody has bothered to convert to libata thus far. Hold on, what does that mean? IDE is back from the dead and used only for embedded stuff? Like

Re: [PATCH v2 1/3] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2013 07:00 PM, Apelete Seketeli wrote: Add defconfig for the Ben NanoNote handheld computer which is built around QI_LB60 board and Ingenic JZ4740 MIPS SoC. Signed-off-by: Apelete Seketeli --- arch/mips/configs/qi_lb60_defconfig | 188 +++

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 06:45 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 07:38 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 07:48 PM, Alan Stern wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy of making all headers self-contained, and then only including headers

Re: [PATCH] sh: fix kernel build error

2013-11-13 Thread Sergei Shtylyov
Hello. On 11/13/2013 05:38 PM, Wanlong Gao wrote: arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs': arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration] arch/sh/kernel/kgdb.c:242:23: error: derefere

Re: [PATCH] sh: fix kernel build error

2013-11-14 Thread Sergei Shtylyov
Hello. On 14-11-2013 4:26, Wanlong Gao wrote: arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs': arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration] arch/sh/kernel/kgdb.c:242:23: error: dereferenci

Re: [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h

2014-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2014 03:18 PM, Rashika Kheria wrote: Rectify typing error while including the guard for the header file xdi_msg.h so that proper guard is wrapped around the file to prevent it from being included more than once. Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett

Re: [PATCH v2] SUNRPC: Allow one callback request to be received from two sk_buff

2014-02-08 Thread Sergei Shtylyov
Hello. On 08-02-2014 6:29, shaobingqing wrote: In current code, there only one struct rpc_rqst is prealloced. If one callback request is received from two sk_buff, the xprt_alloc_bc_request would be execute two times with the same transport->xid. The first time xprt_alloc_bc_request will alloc

Re: [PATCH net] hyperv: Fix the carrier status setting

2014-02-10 Thread Sergei Shtylyov
Hello. On 10-02-2014 5:07, Haiyang Zhang wrote: Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_drv.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hy

Re: [PATCH RFCv2 5/6] net: phy: suspend unused PHYs on mdio_bus in late_initcall

2013-12-04 Thread Sergei Shtylyov
Hello. On 12/04/2013 06:44 PM, Sebastian Hesselbarth wrote: Since phy_attach ensures PHYs are resumed, we can now suspend all PHYs that have no attached netdev after initcalls. Signed-off-by: Sebastian Hesselbarth --- Changelog: RFCv1->RFCv2: - only check for phydev->attached_dev and let ph

Re: [PATCH v3 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

2013-12-05 Thread Sergei Shtylyov
Hello. On 12/05/2013 12:54 PM, Boris BREZILLON wrote: Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON Acked-by: Nicolas Ferre Signed-off-by: Alan Stern --- dr

Re: [PATCH v4 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource

2013-12-08 Thread Sergei Shtylyov
Hello. On 12/08/2013 06:02 PM, Boris BREZILLON wrote: Replace the request_mem_region + ioremap calls by the devm_ioremap_resource call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON Acked-by: Nicolas Ferre Signed-off-by: Alan Stern --- drive

Re: [PATCH, RFC 21/30] isdn: divert, hysdn: fix interruptible_sleep_on race

2014-01-02 Thread Sergei Shtylyov
Hello. On 02-01-2014 16:07, Arnd Bergmann wrote: These two drivers use identical code for their procfs status file handling, which contains a small race against status data becoming available while reading the file. This uses wait_event_interruptible instead to fix this particular race and e

Re: [PATCH, RFC 21/30] isdn: divert, hysdn: fix interruptible_sleep_on race

2014-01-02 Thread Sergei Shtylyov
Hello. On 01/02/2014 07:48 PM, Arnd Bergmann wrote: diff --git a/drivers/isdn/divert/divert_procfs.c b/drivers/isdn/divert/divert_procfs.c index fb4f1ba..1c5dc34 100644 --- a/drivers/isdn/divert/divert_procfs.c +++ b/drivers/isdn/divert/divert_procfs.c @@ -86,12 +86,13 @@ isdn_divert_read(stru

Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

2014-01-03 Thread Sergei Shtylyov
Hello. On 03-01-2014 7:11, Libo Chen wrote: dev_forward_skb will clear skb->sk, so we need save classid before that, otherwise the skb can not be under control by net_cls. Signed-off-by: Libo Chen --- drivers/net/veth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

Re: [PATCH] rds: prevent dereference of a NULL device in rds_iw_laddr_check

2013-12-20 Thread Sergei Shtylyov
Hello. On 12/21/2013 02:18 AM, Sasha Levin wrote: Binding might result in a NULL device which is later dereferenced without checking. Signed-off-by: Sasha Levin --- net/rds/iw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rds/iw.c b/net/rds/iw.c index 7826

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2013 15:28, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Michal Ostrowski Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ding Tianhong --- drivers/net/ppp/pppoe.c | 5 +++-- 1 file changed, 3 inse

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

2013-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2013 20:35, Joe Perches wrote: [] diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c [] @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net) static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b) { - r

Re: [PATCH v3 08/19] ozwpan: slight optimization of addr compare

2013-12-25 Thread Sergei Shtylyov
Hello. On 25-12-2013 7:28, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Rupesh Gujare Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tan Xiaojun Signed-off-by: Ding Tianhong --- drivers/s

Re: [PATCH v3 13/19] media: dvb_core: slight optimization of addr compare

2013-12-25 Thread Sergei Shtylyov
Hello. On 25-12-2013 7:29, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Yang Yingliang Signed-off-by: Ding Tianhong --- drivers/media/dvb-cor

Re: [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare

2013-12-26 Thread Sergei Shtylyov
Hello. On 26-12-2013 15:41, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal_unaligned instead of memcmp. Cc: Larry Finger Cc: Chaoming Li Cc: John W. Linville Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: We

Re: [PATCH net-next 02/20] net: bnx2x: slight optimization of addr compare

2013-12-27 Thread Sergei Shtylyov
Hello. On 27-12-2013 10:48, Ding Tianhong wrote: Use the possibly more efficient ether_addr_equal or ether_addr_equal_unaligned to instead of memcmp. Cc: Ariel Elior Signed-off-by: Ding Tianhong --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c| 10 -- drivers/net/ethernet/

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-28 Thread Sergei Shtylyov
Hello. On 28-12-2013 10:17, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: "David S. Miller" Signed-off-by: Ding Tianhong --- drivers/net/ethernet/packetengines/yellowfin.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr

2013-12-28 Thread Sergei Shtylyov
Hello. On 12/28/2013 06:18 PM, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: "David S. Miller" Signed-off-by: Ding Tianhong --- drivers/net/ethernet/packetengines/yellowfin.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletio

Re: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-21 Thread Sergei Shtylyov
On 08/21/2014 06:12 AM, Hayes Wang wrote: [...] r8152b_disable_aldps(tp); - rtl_clear_bp(tp); Why leave 2 empty lines? One is enough. The next patch would use another fucntion at the same location. I skip removing the empty line and re-adding it again. Is that better

Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/21/2014 09:50 PM, Addy Ke wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one transaction, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or equal 32 bytes at a time. Test on pinky board, elan receive 158 bytes d

Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/21/2014 10:19 PM, Dan Murphy wrote: DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. Adding dt binding for this part Signed-off-by: Dan Murphy --- .../devicetree/bindings/input/ti,drv2667.txt | 18 ++ 1 file changed, 18 insertions(+)

Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description

2014-08-21 Thread Sergei Shtylyov
Hello. On 08/21/2014 10:19 PM, Dan Murphy wrote: DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. Adding dt binding for this part Signed-off-by: Dan Murphy --- .../devicetree/bindings/input/ti,drv2667.txt | 18 ++ 1 file changed, 18 insertions(+)

Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description

2014-08-21 Thread Sergei Shtylyov
On 08/21/2014 11:14 PM, Murphy, Dan wrote: [...] DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. Adding dt binding for this part Signed-off-by: Dan Murphy --- .../devicetree/bindings/input/ti,drv2667.txt | 18 ++ 1 file changed, 18 insertions(

Re: [PATCH v3 6/9] usb: allow to supply the PHY in the drivers when using HCD

2014-08-22 Thread Sergei Shtylyov
Hello. On 08/22/2014 07:50 PM, Antoine Ténart wrote: This patch modify the generic code handling PHYs to allow them to be supplied from the drivers. This adds checks to ensure no PHY was already there when looking for one in the generic code. This also makes sure we do not modify its state in t

Re: [PATCH v3 6/9] usb: allow to supply the PHY in the drivers when using HCD

2014-08-22 Thread Sergei Shtylyov
On 08/22/2014 08:53 PM, Sergei Shtylyov wrote: This patch modify the generic code handling PHYs to allow them to be supplied from the drivers. This adds checks to ensure no PHY was already there when looking for one in the generic code. This also makes sure we do not modify its state in the

Re: [RFC v3 2/2] usb: phy: Temporarily hold timed wakeup source on charger and disconnect events

2014-09-08 Thread Sergei Shtylyov
Hello. On 9/8/2014 2:10 PM, Kiran Kumar Raparthy wrote: From: Todd Poynor usb: phy: Temporarily hold timed wakeup source on charger and disconnect events No need to duplicate the summary. It temporarily holds a timed wakeup source on USB disconnect events, to allow What "it"?

Re: [PATCH] rtc: pcf8563: fix uninitialized use warning

2014-09-08 Thread Sergei Shtylyov
Hello. On 9/8/2014 12:42 AM, Arnd Bergmann wrote: gcc-4.9 found a potential condition under which the 'pending' variable may be used uninitialized: drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_irq': drivers/rtc/rtc-pcf8563.c:173:5: warning: 'pending' may be used uninitialized in this fun

Re: [PATCH] rtc: pcf8563: fix uninitialized use warning

2014-09-08 Thread Sergei Shtylyov
On 9/8/2014 7:22 PM, Arnd Bergmann wrote: diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 5a197d9dc7e7..3a6f994c4da8 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -167,7 +167,7 @@ static irqreturn_t pcf8563_irq(int irq, void *dev_id) ch

Re: [PATCHv2] rtc: pcf8563: fix uninitialized use warning

2014-09-08 Thread Sergei Shtylyov
ooses not to inline the entire call chain. Checking for any non-zero value in the interrupt handler as well is just as correct and lets the compiler know what we are doing, without needing a bogus initialization. As pointed out by Sergei Shtylyov, the same code section contains another bu

Re: [RFC v3 2/2] usb: phy: Temporarily hold timed wakeup source on charger and disconnect events

2014-09-08 Thread Sergei Shtylyov
Hello. On 9/8/2014 2:55 PM, Kiran Raparthy wrote: From: Todd Poynor mailto:toddpoy...@google.com>> usb: phy: Temporarily hold timed wakeup source on charger and disconnect events No need to duplicate the summary. It temporarily holds a timed wake

Re: [RFC 1/4] net: allow large number of rx queues

2014-08-18 Thread Sergei Shtylyov
Hello. On 08/18/2014 05:37 PM, Pankaj Gupta wrote: netif_alloc_rx_queues() uses kcalloc() to allocate memory for "struct netdev_queue *_rx" array. If we are doing large rx queue allocation kcalloc() might fail, so this patch does a fallback to vzalloc(). Similar implementation is done for tx qu

Re: [PATCH RESEND v2 7/7] ARM: dts: vf610-twr: Add USB support

2014-08-18 Thread Sergei Shtylyov
Hello. On 08/19/2014 12:07 AM, Stefan Agner wrote: Add USB support for Freescale Vybrid tower. The USB hosts over-current protection signal is not connected is not connected to the PHY's over- Yes, we all understood that it's not connected, no need to repeat. ;-) current protection, henc

Re: [PATCH v4 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-20 Thread Sergei Shtylyov
Hello. On 8/20/2014 9:46 AM, Robert Baldyga wrote: This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. Signed-off-by: Robert Baldyga [...] diff --git a/include/uapi/linux/usb/functionfs.h b/inc

Re: [PATCH net-next 3/4] r8152: remove clear_bp function

2014-08-20 Thread Sergei Shtylyov
Hello. On 8/20/2014 12:58 PM, Hayes Wang wrote: The functions are used to update the firmware. Move the actions into the firmware files. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/net/usb/r8

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-20 Thread Sergei Shtylyov
Hello. On 08/20/2014 07:54 PM, Felipe Balbi wrote: Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded ttyGS string. This macro was mostly used in a few debug/warning messages and a lot of hardcoded ttyGS existed beneath. It may have been used for rena

Re: [PATCH] clk-rcar-gen2: RCAN clock support

2014-09-03 Thread Sergei Shtylyov
Hello. On 07/31/2014 12:23 AM, Sergei Shtylyov wrote: Add RCAN clock support to the R-Car generation 2 CPG driver. This clock gets derived from the USB_EXTAL clock by dividing it by 6. The layout of RCANCKCR register is close to those of the clocks supported by the 'clk-div6' driv

Re: [PATCH v4 4/9] usb: rename phy to usb_phy in HCD

2014-09-03 Thread Sergei Shtylyov
Hello. On 09/03/2014 11:40 AM, Antoine Tenart wrote: The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Signed-off-by: Antoine Tenart Acked-by: Alan Stern I'm going to steal this patch and post it along with the HCD

Re: [PATCH v4 4/9] usb: rename phy to usb_phy in HCD

2014-09-03 Thread Sergei Shtylyov
Hello. On 09/03/2014 11:40 AM, Antoine Tenart wrote: The USB PHY member of the HCD structure is renamed to 'usb_phy' and modifications are done in all drivers accessing it. Signed-off-by: Antoine Tenart Acked-by: Alan Stern --- drivers/usb/chipidea/host.c | 2 +- drivers/usb/core/hcd

[PATCH v5 0/2] Add generic PHY support to USB HCD

2014-09-04 Thread Sergei Shtylyov
Hello. This patchset is against the usb-next' branch of Greg KH's 'usb.git' repo. Here I add support for the generic PHY to the 'struct usb_hcd' (having to rename the existing 'phy' field to 'usb_phy' beforehand). This was mainly intended to be used with the PCI OHCI/EHCI drivers and also xHCI

[PATCH v5 1/2] usb: rename phy to usb_phy in HCD

2014-09-04 Thread Sergei Shtylyov
lvstest.c' file, resolved rejects caused by patch reordering, updated changelog.] Signed-off-by: Sergei Shtylyov Acked-by: Alan Stern --- Changes in version 5: - imported the patch from Antoine Tenart's series; - added missing 'drivers/usb/misc/lvstest.c' file; - resolved rejects caus

[PATCH v5 2/2] usb: hcd: add generic PHY support

2014-09-04 Thread Sergei Shtylyov
Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov Signed-off-by: Yoshihiro Shimoda --- Changes in version 5: - renamed the new 'gen_phy' field of '

Re: [PATCH] clk-rcar-gen2: RCAN clock support

2014-09-05 Thread Sergei Shtylyov
er but has no divider field, and so can't be supported by that driver... Signed-off-by: Sergei Shtylyov --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo. drivers/clk/shmobile/clk-rcar-gen2.c | 99 +

Re: [PATCH] clk-rcar-gen2: RCAN clock support

2014-09-05 Thread Sergei Shtylyov
On 09/05/2014 01:17 PM, Geert Uytterhoeven wrote: Add RCAN clock support to the R-Car generation 2 CPG driver. This clock gets derived from the USB_EXTAL clock by dividing it by 6. The layout of RCANCKCR register is close to those of the clocks supported by the 'clk-div6' driver but has no divid

Re: [PATCH RFC 1/3] DT: add binding for MXS regulator

2014-09-07 Thread Sergei Shtylyov
Hello. On 9/7/2014 3:37 PM, Stefan Wahren wrote: This patch adds the Device tree bindings for the Freescale MXS on-chip regulators. Signed-off-by: Stefan Wahren --- .../bindings/regulator/mxs-regulator.txt | 38 ++ 1 file changed, 38 insertions(+) create m

Re: [PATCH 1/1] USB: Add device quirk for ASUS T100 Base Station keyboard

2014-08-29 Thread Sergei Shtylyov
Hello. On 8/29/2014 8:26 AM, Lu Baolu wrote: This full-speed USB device generates spurious remote wakeup event as soon as USB_DEVICE_REMOTE_WAKEUP feature is set. As the result, Linux can't enter system suspend and S0ix power saving modes once this keyboard is used. This patch tries to intro

Re: [PATCH] net: sh_eth: fix driver dependencies

2014-09-01 Thread Sergei Shtylyov
Hello. On 9/1/2014 5:15 PM, Bartlomiej Zolnierkiewicz wrote: Renesas SuperH Ethernet support should be available only on Renesas ARM SoCs and SuperH architecture. Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Kyungmin Park Cc: Simon Horman Cc: Magnus Damm --- drivers/net/ethernet/

Re: [PATCH] usb: renesas_usbhs: fix driver dependencies

2014-09-01 Thread Sergei Shtylyov
Hello. On 9/1/2014 5:14 PM, Bartlomiej Zolnierkiewicz wrote: Renesas USBHS controller support should be available only on Renesas ARM SoCs and SuperH architecture. Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Kyungmin Park Cc: Simon Horman Cc: Magnus Damm --- drivers/usb/renesas_

Re: [PATCH v2] net: sh_eth: fix driver dependencies

2014-09-01 Thread Sergei Shtylyov
On 09/01/2014 06:25 PM, Bartlomiej Zolnierkiewicz wrote: Renesas SuperH Ethernet support should be available only on Renesas ARM SoCs and SuperH architecture. Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Kyungmin Park Cc: Simon Horman Cc: Magnus Damm Acked-by: Sergei Shtylyov

Re: [PATCH net-next 2/2] r8152: use eth_hw_addr_random

2014-09-02 Thread Sergei Shtylyov
Hello. On 9/2/2014 1:55 PM, Hayes Wang wrote: If the hw doesn't have a valid MAC address, give a random one and set it to the hw. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff

Re: [PATCH] VMXNET3: Check for map error in vmxnet3_set_mc

2014-09-02 Thread Sergei Shtylyov
Hello. On 09/02/2014 08:30 PM, Andy King wrote: We should check if the map of the table actually succeeds, and also free resources accordingly. This fixes the kernel panic reported by Tetsuo Handa. There's "Reported-by:" line for that. Version bumped to 1.2.1.0 Acked-by: Shelley Gong

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Sergei Shtylyov
Hello. On 8/6/2014 5:56 PM, Koehrer Mathias (ETAS/ESW5) wrote: With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in t

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Sergei Shtylyov
On 8/6/2014 6:27 PM, Koehrer Mathias (ETAS/ESW5) wrote: With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in this case.

Re: [PATCH net-next] xen-netback: Fix vif->disable handling

2014-08-06 Thread Sergei Shtylyov
Hello. On 08/06/2014 11:33 PM, Zoltan Kiss wrote: In the patch called "xen-netback: Turn off the carrier if the guest is not able to receive" new branches were introduced to this if statement, risking that a queue with non-zero id can reenable the disabled interface. Signed-off-by: Zoltan Ki

Re: Issue with commit 33c133cc7598e60976a phy: IRQ cannot be shared

2014-08-14 Thread Sergei Shtylyov
Hello. On 8/14/2014 10:31 AM, leroy christophe wrote: I have an hardware with two ethernet interfaces, and with the two PHYs inside the same component INTEL LXT973 which has only one interrupt. I also have another hardware with two ethernet interfaces and two independant PHYs. But the two PHYs

Re: Issue with commit 33c133cc7598e60976a phy: IRQ cannot be shared

2014-08-15 Thread Sergei Shtylyov
Hello. On 08/15/2014 01:10 PM, christophe leroy wrote: I have an hardware with two ethernet interfaces, and with the two PHYs inside the same component INTEL LXT973 which has only one interrupt. I also have another hardware with two ethernet interfaces and two independant PHYs. But the two PHYs

Re: [PATCH] net: phy: smsc: move smsc_phy_config_init reset part in a soft_reset function

2014-08-15 Thread Sergei Shtylyov
Hello. On 08/15/2014 11:52 AM, Gwenhael Goavec-Merou wrote: On the one hand, phy_device.c provides a generic reset function if the phy driver does not provide a soft_reset pointer. This generic reset does not take into account the state of the phy, with a potential failure if the phy is in powe

Re: [PATCH v5 3/5] usb: host: ehci-st: Add ehci-st devicetree bindings documentation

2014-08-15 Thread Sergei Shtylyov
Hello. On 08/15/2014 06:03 PM, Peter Griffin wrote: This patch documents the device tree bindings required for the ehci on-chip controller found in ST consumer electronics SoC's. Signed-off-by: Peter Griffin --- Documentation/devicetree/bindings/usb/ehci-st.txt | 39 ++

Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec

2014-08-01 Thread Sergei Shtylyov
Hello. On 01-08-2014 9:22, Peter Ujfalusi wrote: The board uses aic3106 for audio. Signed-off-by: Peter Ujfalusi --- arch/arm/boot/dts/da850-evm.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts i

Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec

2014-08-01 Thread Sergei Shtylyov
Hello. On 08/01/2014 05:02 PM, Peter Ujfalusi wrote: I do. We should follow the standard consistently. Why not call the node "sound-codec"? Well, there is _zero_ cases when the audio codec node is named as "sound-codec" in linux-next but we have wm, tlv, twl, max etc.

Re: [PATCH] dma: at_hdmac: fix invalid remaining bytes detection

2014-08-01 Thread Sergei Shtylyov
Hello. On 08/01/2014 02:03 PM, Alexandre Belloni wrote: Found using smatch: drivers/dma/at_hdmac.c:299 atc_get_bytes_left() warn: unsigned 'atchan->remain_desc' is never less than zero. Signed-off-by: Alexandre Belloni --- drivers/dma/at_hdmac.c | 12 +++- 1 file changed, 7 inser

Re: [PATCH] scatterlist.h: Change CONFIG_DEBUG_SG for ifdef statement in sg_set_bf

2014-08-03 Thread Sergei Shtylyov
Hello. On 03-08-2014 6:56, Nicholas Krause wrote: This changes the ifdef statement in sg_set_bg to !CONFIG_DEBUG_SG in order to avoid a bug with xhci dequence/enquence functions. dequeue/enqueue? Signed-off-by: Nicholas Krause --- include/linux/scatterlist.h | 2 +- 1 file changed,

Re: [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY

2014-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2014 12:53 PM, Sebastian Hesselbarth wrote: From: Antoine Ténart Internal FastEthernet PHY on BG2Q is connected via MII, add a corresponding phy-connection-type property. Tested-by: Antoine Ténart Signed-off-by: Sebastian Hesselbarth --- Cc: "David S. Miller" Cc: "Anto

Re: [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY

2014-10-21 Thread Sergei Shtylyov
On 10/21/2014 3:46 PM, Sebastian Hesselbarth wrote: From: Antoine Ténart Internal FastEthernet PHY on BG2Q is connected via MII, add a corresponding phy-connection-type property. Tested-by: Antoine Ténart Signed-off-by: Sebastian Hesselbarth --- Cc: "David S. Miller" Cc: "Antoine Ténar

Re: [PATCH] ARM: davinci: Remove redundant casts

2014-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2014 06:53 PM, Rasmus Villemoes wrote: These casts to char* are unnecessary and slightly confusing, since both operands actually have type const char*. Both operands of what? Typecast only has 1 operand. :-) Signed-off-by: Rasmus Villemoes WBR, Sergei -- To unsubscri

<    9   10   11   12   13   14   15   16   17   18   >