Re: [PATCH v2] usb: ohci/uhci - add soft dependencies on ehci_pci

2013-09-10 Thread Sergei Shtylyov
Hello. On 09/11/2013 01:30 AM, Tom Gundersen wrote: Support for specifying soft dependencies in the modules themselves was introduced in commit 7cb14ba. Please also specify that commit's summary line in parens. In Arch we have always been shipping a module.d(5) fragment ordering ohci/uhc

Re: drivers/net/ethernet/nvidia/forcedeth.c saved_config_space[size] access patch

2013-09-11 Thread Sergei Shtylyov
Hello. On 09/09/2013 03:39 AM, Marc Weber wrote: 1) VER3 and _MAX are of same size: #define NV_PCI_REGSZ_VER3 0x604 #define NV_PCI_REGSZ_MAX0x604 2) It looks like there is a case where VER3 get's assigned to register_size: if (id->driver_data & (DE

Re: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls

2013-10-09 Thread Sergei Shtylyov
remaining shdma_free_irq() calls. Tested-by: Simon Horman Reported-by: Simon Horman Signed-off-by: Sergei Shtylyov Vinod, could you consider taking this and the following patch as a fix for v3.12? Vinod, may I ask when these regression (induced by you) fixes gets merged? WBR, Ser

Re: [PATCH V2 4/6] vhost_net: determine whether or not to use zerocopy at one time

2013-08-30 Thread Sergei Shtylyov
Hello. On 08/30/2013 08:29 AM, Jason Wang wrote: Currently, even if the packet length is smaller than VHOST_GOODCOPY_LEN, if upend_idx != done_idx we still set zcopy_used to true and rollback this choice later. This could be avoided by determine zerocopy once by checking all conditions at one t

Re: [PATCH 1/7] Drop support for Renesys H8/300 (h8300) architecture

2013-08-30 Thread Sergei Shtylyov
Hello. On 08/30/2013 08:40 PM, Guenter Roeck wrote: Subject typo: it's Renesas, not Renesys, according to the MAINTAINERS entry. H8/300 has been dead for several years, and the kernel for it has not compiled for ages. Drop support for it. Signed-off-by: Guenter Roeck WBR, Sergei -- T

Re: [PATCH v3] dma: add driver for R-Car HPB-DMAC

2013-08-30 Thread Sergei Shtylyov
Hello. On 08/25/2013 12:33 AM, Sergei Shtylyov wrote: From: Max Filippov Add support for HPB-DMAC found in Renesas R-Car SoCs, using 'shdma-base' DMA driver framework. Based on the original patch by Phil Edworthy . Signed-off-by: Max Filippov [Sergei: removed useles

Re: Fix style in s3c-hsotg.c

2013-09-02 Thread Sergei Shtylyov
Hello. On 09/02/2013 05:58 PM, Pavel Machek wrote: checkpatch.pl has some valid complaints about style in s3c-hsotg.c : macro with if should be really enclosed in do {} while, and puts is going to be slightly faster. Here's suggested patch. I don't have the hardware, so it is completely unte

Re: [PATCH v2 5/5] ARM: shmobile: lager: (DEVEL) add CPUFreq support

2013-09-26 Thread Sergei Shtylyov
Hello. On 09/26/2013 09:21 PM, Guennadi Liakhovetski wrote: The Lager board uses a DA9210 voltage regulator to supply DVFS power to the CA15 cores on the r8a7790 SoC. This patch adds CPUFreq support for that board using the cpufreq-cpu0 driver. Signed-off-by: Guennadi Liakhovetski --- v2

Re: [PATCH] USB: gadget: f_fs: fix error handling

2013-09-27 Thread Sergei Shtylyov
Hello. On 09/27/2013 02:28 PM, Robert Baldyga wrote: This patch add missing error check in ffs_func_bind() function, after ffs_do_descs() funcion call for hs descriptors. Without this check it's s/funcion/function/. Perhaps it's worth expanding "hs" to "high speed" for clarity? possib

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Sergei Shtylyov
Hello. On 28-09-2013 15:13, Xiangliang Yu wrote: If device is attached to port multiplier, the detection process look like this: ahci_hardreset(link, class, deadline) if (class == ATA_DEV_PMP) { sata_pmp_attach(dev)/* will enable FBS */ sata_p

Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

2013-09-22 Thread Sergei Shtylyov
Hello. On 09/19/2013 05:05 PM, Roger Quadros wrote: From: Balaji T K Some platforms have a PHY hooked up to the SATA controller. The PHY needs to be initialized and powered up for SATA to work. We do that using the PHY framework. [Roger Q] Cleaned up. CC: Tejun Heo Signed-off-by: Bal

Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

2013-09-22 Thread Sergei Shtylyov
Hello. On 09/22/2013 08:58 PM, Tejun Heo wrote: From: Balaji T K Some platforms have a PHY hooked up to the SATA controller. The PHY needs to be initialized and powered up for SATA to work. We do that using the PHY framework. [Roger Q] Cleaned up. CC: Tejun Heo Signed-off-by: Balaji

Re: [RFC PATCH 15/15] arm: dts: dra7: add sata node

2013-09-22 Thread Sergei Shtylyov
On 09/20/2013 02:19 PM, Roger Quadros wrote: From: Balaji T K Add support for sata controller. [Roger Q] Clean up. CC: Benoit Cousson Signed-off-by: Balaji T K Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7.dtsi | 49 +++ 1 fi

Re: [PATCH V2] wireless: rtlwifi: Replace variable with a brake

2013-09-22 Thread Sergei Shtylyov
Hello. On 09/22/2013 11:50 PM, Peter Senna Tschudin wrote: You have a typo in the subject -- "brake" is a device to stop a vehicle. :-) This patch removes the variable continual, and change the while loop to break when efuse_data == 0xFF. Tested by compilation only. CC: Joe Perches S

Re: [PATCH] pata_isapnp: Don't use invalid I/O ports

2013-09-23 Thread Sergei Shtylyov
Hello. On 23-09-2013 1:42, Tejun Heo wrote: The test for 2nd I/O port validity is broken (reversed): On devices with no control port, the driver attempts to use invalid port 0, resulting in logs full of bad_io_access errors. On devices with control port, the driver does not use it. Signed-of

Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

2013-09-23 Thread Sergei Shtylyov
Hello. On 23-09-2013 11:37, Roger Quadros wrote: Not sure why you asked -- I'm not using this driver, neither I'm Well, you have better grip of what's going on in the embedded world than me. I'm mostly curious whether adding dependency on PHY is okay. There is no hard dependency on p

Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

2013-09-23 Thread Sergei Shtylyov
Hello. On 23-09-2013 1:51, Tejun Heo wrote: Not sure why you asked -- I'm not using this driver, neither I'm Well, you have better grip of what's going on in the embedded world than me. I'm mostly curious whether adding dependency on PHY is okay. This driver already supports option

Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

2013-09-23 Thread Sergei Shtylyov
Hello. On 09/23/2013 01:48 AM, Tejun Heo wrote: @@ -37,6 +37,7 @@ #include #include +#include struct phy; should suffice. Unless it's actually likely to cause inclusion loop, I think it's better to include the header than adding explicit declarations. Apparently, tastes

Re: [PATCH] ipvs: improved SH fallback strategy

2013-09-23 Thread Sergei Shtylyov
Hello. On 09/23/2013 03:51 PM, Alexander Frolkin wrote: Improve the SH fallback realserver selection strategy. With sh and sh-fallback, if a realserver is down, this attempts to distribute the traffic that would have gone to that server evenly among the remaining servers. Signed-off-by: A

[PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls

2013-09-25 Thread Sergei Shtylyov
an Signed-off-by: Sergei Shtylyov --- The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo. drivers/dma/sh/rcar-hpbdma.c |2 -- 1 file changed, 2 deletions(-) Index: sla

[PATCH 2/2] rcar-hpbdma: add parameter to set_slave() method

2013-09-25 Thread Sergei Shtylyov
_addr' field to 'struct hpb_dmae_chan', conditionally assign it in set_slave() method, and return in slave_addr() method. Signed-off-by: Sergei Shtylyov --- The patch is against 'fixes-3.12' branch of Vinod Koul's 'slave-dma.git' repo. drivers/dma/sh/rca

Re: [PATCH] [v2] sata_fsl: add workaround for data length mismatch on freescale V2 controller

2012-09-06 Thread Sergei Shtylyov
Hello. On 06-09-2012 8:28, Shaohui Xie wrote: The freescale V2 SATA controller checks if the received data length matches the programmed length 'ttl', if not, it assumes that this is an error. In ATAPI, the 'ttl' is based on max allocation length and not the actual data transfer length, control

Re: [PATCH] USB: XHCI: xhci-ring: Remove unused dma address calculation in inc_enq and inc_deq function

2012-09-07 Thread Sergei Shtylyov
Hello. On 06-09-2012 19:47, Girish Verma wrote: Resending patch with latest kernel code: That comment should have been put after the --- tear line. In xhci-ring.c, function inc_enq and inc_deq calculate the dma address of trb but never used. Signed-off-by: Girish Verma --- driver

Re: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller

2012-09-10 Thread Sergei Shtylyov
Hello. On 10-09-2012 6:53, Xie Shaohui-B21989 wrote: + /* Workaround for data length mismatch errata */ + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) { + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) { + qc = ata_qc_from_tag(ap, tag); +

Re: [PATCH 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp

2012-10-05 Thread Sergei Shtylyov
Hello. On 05-10-2012 12:07, Kishon Vijay Abraham I wrote: Platfrom device for ocp2scp is created using omap_device_build in devices file. This is used for both omap4(musb) and omap5(dwc3). Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/devices.c | 72

Re: [PATCH v6] Enable USB peripheral mode on dm365 EVM

2012-10-10 Thread Sergei Shtylyov
Hello. On 10-10-2012 14:33, Constantine Shulyupin wrote: From: Constantine Shulyupin Sets USB PHY clock source to 24 MHz clock and call USB configuration from board initialization. Tested with OTG configuration, usb gadget g_zero on DM365 EVM connected to PC. References: Definition of USB

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Sergei Shtylyov
Hello. On 11/30/2012 01:56 PM, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] ata_piix: re-oder code and remove prototypes You meant "re-order", I think. > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > Jeff, please a

Re: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform_driver()

2012-12-06 Thread Sergei Shtylyov
Hello. On 12/05/2012 04:34 AM, Wenyou Yang wrote: > Using module_platform_driver() replaces module_init() and module_exit() > and makes the code simpler. > Signed-off-by: Wenyou Yang > Cc: w...@iguana.be > Cc: linux-watch...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/wa

Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree

2012-12-11 Thread Sergei Shtylyov
Hello. On 11-12-2012 14:58, Julia Lawall wrote: From: Julia Lawall The function at91_dt_node_to_map is ultimately called by the function pinctrl_get, which is an exported function. Since it is possible that this function is not called from within a probe function, for safety, the kfree is

Re: [PATCH] drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree

2012-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2012 04:08 PM, Julia Lawall wrote: >>> From: Julia Lawall >>> The function at91_dt_node_to_map is ultimately called by the function >>> pinctrl_get, which is an exported function. Since it is possible that this >>> function is not called from within a probe function, for safety

Re: [PATCH] ARM: tegra: Implement 6395/1 for Tegra

2012-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2012 05:27 PM, Peter De Schrijver wrote: > This patch implements ARM linux patch 6395/1 for Tegra. See commit > 1a8e41cd672f894bbd74874eac601e6cedf838fb for details. You should give some details in this commit too, like specifying that commit summary in parens. > Signed-off-b

Re: [PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT

2012-12-26 Thread Sergei Shtylyov
Hello. On 12/26/2012 09:42 PM, Dongjin Kim wrote: > This patch support to get interrupt resource from device tree as well as > platform device if ehci node is defined in device tree and it's irq is > described. > Signed-off-by: Dongjin Kim > --- > drivers/usb/host/ehci-s5p.c |8 +++- >

Re: [PATCH fix-3.8] video: vt8500: Fix X crash when initializing framebuffer.

2012-12-28 Thread Sergei Shtylyov
Hello. On 12/27/2012 03:25 AM, Tony Prisk wrote: > This patch adds support for .fb_check_var which is required when > X attempts to initialize the framebuffer. The only supported > resolution is the native resolution of the LCD panel, so we test > against the resolution supplied from the DT panel

Re: [PATCH v5 13/22] mfd: omap-usb-host: override number of ports from platform data

2013-01-03 Thread Sergei Shtylyov
Hello. On 02-01-2013 19:00, Roger Quadros wrote: Both OMAP4 and 5 exhibit the same revision ID in the REVISION register but they have different number of ports i.e. 2 and 3 respectively. So we can't rely on REVISION register for number of ports on OMAP5 and depend on platform data (or device tr

Re: [PATCH RESEND v3.7.0] Add AHCI support for Enmotus Bobcat device.

2013-01-03 Thread Sergei Shtylyov
Hello. On 01/03/2013 09:35 PM, Hugh Daschbach wrote: > Silicon does not support standard AHCI BAR assignment. Add > vendor/device exception to force BAR 2. > Signed-off-by: Hugh Daschbach > --- > Previously sent 14 Dec 2012. Any feedback? > Thanks, > Hugh > drivers/ata/ahci.c | 6 ++ >

Re: [PATCH 2/2] Revert "nohz: Fix idle ticks in cpu summary line of /proc/stat" (commit 7386cdbf2f57ea8cff3c9fde93f206e58b9fe13f).

2013-01-04 Thread Sergei Shtylyov
Hello. On 04-01-2013 6:58, Srivatsa Vaddagiri wrote: With offline cpus no longer beeing seen in nohz mode (ts->idle_active=0), we don't need the check for cpu_online() introduced in commit 7386cdbf. Offline Please also specify the summary of that commit in parens (or however you like).

Re: [PATCH 2/2] Revert "nohz: Fix idle ticks in cpu summary line of /proc/stat" (commit 7386cdbf2f57ea8cff3c9fde93f206e58b9fe13f).

2013-01-04 Thread Sergei Shtylyov
Hello. On 01/04/2013 10:29 PM, Srivatsa Vaddagiri wrote: >>> With offline cpus no longer beeing seen in nohz mode (ts->idle_active=0), we >>> don't need the check for cpu_online() introduced in commit 7386cdbf. Offline >>Please also specify the summary of that commit in parens (or >> however

Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95

2013-01-05 Thread Sergei Shtylyov
On 12/22/2012 08:52 PM, Sergei Shtylyov wrote: >> please respin this patch with a real commit log. >And then, when referring to commit ID that broke da8xx.c don't forget to > also > specify the commit summmary in parens (or however you like). Also, please s/davinci/d

Re: [PATCH v2] usb: phy: using kzalloc instead of kmalloc

2012-12-20 Thread Sergei Shtylyov
Hello. On 20-12-2012 12:25, Venu Byravarasu wrote: As Tegra PHY driver open is using kmalloc, changing it to kzalloc. This description doesn't make sense. Signed-off-by: Venu Byravarasu WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/2] don't wait on disk to start on resume

2012-12-22 Thread Sergei Shtylyov
Hello. On 21-12-2012 8:35, Derek Basehore wrote: We no longer wait for the disk to spin up in sd_resume. It now enters the request to spinup the disk into the elevator and returns. A function is scheduled under the scsi_sd_probe_domain to wait for the command to spinup the disk to complete. Th

Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95

2012-12-22 Thread Sergei Shtylyov
Hello. On 21-12-2012 13:06, Felipe Balbi wrote: please respin this patch with a real commit log. And then, when referring to commit ID that broke da8xx.c don't forget to also specify the commit summmary in parens (or however you like). Signed-off-by: Mikhail Kshevetskiy WBR, Sergei

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-22 Thread Sergei Shtylyov
Hello. On 18-12-2012 21:34, Tony Prisk wrote: Resend to include mailing lists. Such remarks should be placed under --- tear line, not in the changelog. Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk CC: Kyungmin Park CC: Tomasz Stanislawski CC: lin

Re: [PATCH] MIPS: MSP71xx: Move include files

2012-12-24 Thread Sergei Shtylyov
Hello. On 24-12-2012 8:53, Shane McDonald wrote: Now that Yosemite's gone we can move the MSP71xx include files one level up. Signed-off-by: Shane McDonald --- .../asm/mach-pmcs-msp71xx/cpu-feature-overrides.h | 22 + arch/mips/include/asm/mach-pmcs-msp71xx/gpio.h | 46 ++ .../

Re: [PATCH] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Sergei Shtylyov
Hello. On 16-11-2012 10:37, Kishon Vijay Abraham I wrote: commit 392142 Please specify thta commit summary in parens. moved event buffer allocation out of dwc3_core_init() but event buffer allocation uses the cached copy of hwparams to determine the number of event buffers and the cachin

Re: [PATCH v2] usb: dwc3: core: move dwc3_cache_hwparams before dwc3_alloc_event_buffers

2012-11-16 Thread Sergei Shtylyov
Hello. On 16-11-2012 16:45, Kishon Vijay Abraham I wrote: commit 392142 (moved event buffer allocation out of dwc3_core_init()). But The actual summary is "usb: dwc3: core: move event buffer allocation out of dwc3_core_init()". event buffer allocation uses the cached copy of hwparams t

Re: [PATCH 1/5] ARM: at91: at91sam9x5 RTC is not compatible with at91rm9200 one

2013-04-19 Thread Sergei Shtylyov
Hello. On 18-04-2013 17:01, Nicolas Ferre wrote: Due to a bug with RTC IMR, we cannot consider at91sam9x5 RTC compatible with the previous one. Modify DT compatibility string, even if the driver is not yet modified to take it into account. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dt

Re: [PATCH 1/5] ARM: at91: at91sam9x5 RTC is not compatible with at91rm9200 one

2013-04-19 Thread Sergei Shtylyov
On 19-04-2013 18:05, Nicolas Ferre wrote: Due to a bug with RTC IMR, we cannot consider at91sam9x5 RTC compatible with the previous one. Modify DT compatibility string, even if the driver is not yet modified to take it into account. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91s

Re: [PATCH net] macvlan: don't touch promisc without passthrough

2013-06-12 Thread Sergei Shtylyov
Hello. On 12-06-2013 15:34, Michael S. Tsirkin wrote: commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way Please also specify that commit's summary line in parens. to control NOPROMISC macvlan flag through netlink. However, with a non passthrough device we don't s

Re: [PATCH 03/31] mips/kvm: Fix 32-bitisms in kvm_locore.S

2013-06-14 Thread Sergei Shtylyov
Hello. On 14-06-2013 17:09, Ralf Baechle wrote: diff --git a/arch/mips/kvm/kvm_locore.S b/arch/mips/kvm/kvm_locore.S index dca2aa6..e86fa2a 100644 --- a/arch/mips/kvm/kvm_locore.S +++ b/arch/mips/kvm/kvm_locore.S @@ -310,7 +310,7 @@ NESTED (MIPSX(GuestException), CALLFRAME_SIZ, ra) LONG_S

Re: linux-next: manual merge of the arm-soc tree with the net-next tree

2013-06-17 Thread Sergei Shtylyov
Hello. On 17-06-2013 10:39, Stephen Rothwell wrote: Today's linux-next merge of the arm-soc tree got a conflict in arch/arm/mach-shmobile/clock-r8a7740.c between commit e5c9b4cd6651 ("sh_eth: get R8A7740 support out of #ifdef") from the net-next tree and commit 9e0b428f079d ("ARM: shmobile: r8a

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

2013-06-05 Thread Sergei Shtylyov
Hello. On 05-06-2013 11:40, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs wrongly. Bug were introduced by commit cedb9bdce099206290a2bdd02ce47a7b253b6a84 (vhost-net:

Re: [PATCH] vhost_net: clear msg.control for non-zerocopy case during tx

2013-06-06 Thread Sergei Shtylyov
Hello. On 06/06/2013 07:27 AM, Jason Wang wrote: When we decide not use zero-copy, msg.control should be set to NULL otherwise macvtap/tap may set zerocopy callbacks which may decrease the kref of ubufs wrongly. Bug were introduced by commit cedb9bdce099206290a2bdd02ce47a7b253b6a84 (vhost-net:

Re: linux-next: manual merge of the arm-soc tree with the usb tree

2013-06-18 Thread Sergei Shtylyov
Hello. On 18-06-2013 10:12, Stephen Rothwell wrote: Today's linux-next merge of the arm-soc tree got a conflict in drivers/usb/phy/phy-rcar-usb.c between commit 56a9a6de2a87 ("usb: phy: rcar-usb: Fix comment w.r.t. devm_ioremap_resource") from the usb tree and commit 725bf9dcafe1 ("phy-rcar-usb

Re: linux-next: manual merge of the arm-soc tree with the net-next tree

2013-06-18 Thread Sergei Shtylyov
Hello. On 18-06-2013 12:33, Bastian Hecht wrote: Sergei is completely right I think. He was sceptic about the commit in a mail some days ago already. Unfortunately I recently haven't had access to my development environment to check what's up with this patch. I'm sorry that it ended up to you b

Re: [PATCH 1/1] drivers/net: param for lapbether for specific ethernet device

2013-06-19 Thread Sergei Shtylyov
Hello. On 19-06-2013 12:21, Stephen Moorby wrote: From 35607dd0607bca5322860703143c31cb04377764 Mon Sep 17 00:00:00 2001 From: Stephen Moorby Date: Wed, 19 Jun 2013 08:22:51 +0100 Subject: [PATCH 1/1] drivers/net: param for lapbether for specific ethernet device No need for this header

Re: [RFC PATCH 6/6] ARM: OMAP3: Enable Hardware Save and Restore for USB Host

2013-06-19 Thread Sergei Shtylyov
Hello. On 06/19/2013 06:05 PM, Roger Quadros wrote: To ensure hardware context is restored while resuming from OFF mode we need to enable the Hardware SAR bit for the USB Host power domain. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/powerdomains3xxx_data.c |8 +--- 1 fi

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-20 Thread Sergei Shtylyov
Hello. On 20-06-2013 6:26, Aaron Lu wrote: From: Liu Jiang Commit 30dcf76acc69 "libata: migrate ACPI code over to new bindings" removed ACPI dock notification related code, but there's some dead code left, so clean up it. [...] Subject: [PATCH] libata-acpi: add back ACPI based hotplug fun

Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush

2013-06-20 Thread Sergei Shtylyov
Hello. On 20-06-2013 15:48, Michael S. Tsirkin wrote: vhost_net_ubuf_put_and_wait has a confusing name: it will actually also free it's argument. Thus since commit 1280c27f8e29acf4af2da914e80ec27c3dbd5c01 Please also specify that commit's summary line in parens. vhost_net_flush tries to

Re: [PATCH 11/11] net: emaclite: Update driver header

2013-05-29 Thread Sergei Shtylyov
Hello. On 05/29/2013 07:33 PM, Michal Simek wrote: Corrent email address and years. s/Corrent/Correct/. Perhaps the committer can fix. Signed-off-by: Michal Simek WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH, v2 13/13] mm/m68k: fix build warning of unused variable

2013-05-29 Thread Sergei Shtylyov
Hello. On 05/29/2013 06:44 PM, Jiang Liu wrote: Fix build warning of unused variable: arch/m68k/mm/init.c: In function 'mem_init': arch/m68k/mm/init.c:151:6: warning: unused variable 'i' [-Wunused-variable] Signed-off-by: Jiang Liu Cc: Geert Uytterhoeven Cc: Greg Ungerer Cc: Thadeu Lima de

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-29 Thread Sergei Shtylyov
Hello. On 05/30/2013 01:09 AM, Davidlohr Bueso wrote: Use the already defined macro to pass the function return address. Signed-off-by: Davidlohr Bueso --- net/core/skbuff.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbu

Re: [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller

2013-05-30 Thread Sergei Shtylyov
Hello. On 30-05-2013 18:26, Timur Tabi wrote: - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context); + const unsigned long timing[] = { 5, 100, 500}; You'll save space and time if you also make this array "static", otherwise the compiler will build the array ever

Re: [PATCH v2 4/6] MIPS: jz4740: Register jz4740 DMA device

2013-05-30 Thread Sergei Shtylyov
Hello. On 05/30/2013 08:25 PM, Lars-Peter Clausen wrote: Register a device for the newly added jz4740 dmaengine driver. Signed-off-by: Lars-Peter Clausen Acked-by: Ralf Baechle [...] 3 files changed, 23 insertions(+) diff --git a/arch/mips/jz4740/platform.c b/arch/mips/jz4740/platform.c

Re: [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller

2013-05-31 Thread Sergei Shtylyov
Hello. On 31-05-2013 10:53, Clemens Ladisch wrote: +const unsigned long timing[] = { 5, 100, 500}; You'll save space and time if you also make this array "static", otherwise the compiler will build the array every time this function is called. No, *const* specifier is enough to not bu

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-31 Thread Sergei Shtylyov
Hello. On 31-05-2013 9:20, Joe Perches wrote: Why not "text:%#lx" as already used in this string? It's equivalent to "0x%lx". Well, I don't know the reasoning in this case, but I'd like to note that those are not strictly equivalent. Personally I find the formatting of 0 annoying enoug

Re: [net-next rfc V2 6/8] macvtap: allow TUNSETIFF to create multiqueue device

2013-05-31 Thread Sergei Shtylyov
Hello. On 31-05-2013 13:53, Jason Wang wrote: Though the queue were in fact created by open(), we still need to add this check to be compatible with tuntap which can let mgmt software use a single API to manage queues. This patch only validates the device name and moves the TUNSETIFF to a helpe

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-31 Thread Sergei Shtylyov
Hello. On 05/31/2013 08:54 PM, Joe Perches wrote: Don't use a standalone gcc compiled program to determine what the kernel outputs. [] The kernel output is; printk("0x%lx\n", 0x100ul)0x100 printk("%p\n", (void *)0x100ul) 0100 printk("%#p\n

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2013 12:22 AM, Emil Goode wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb->transfer_dma and urb->actual_length is also done a few lines belo

Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-06-01 Thread Sergei Shtylyov
Hello. On 24-05-2013 9:34, B, Ravi wrote: + phy1: usbphy-gs70@44e10620 { + compatible = "ti,dsps-usbphy"; + reg = <0x44e10620 0x8 + 0x44e10648 0x4>; + reg-names = "phy_ctrl","phy_wkup";

Re: [PATCH] libata: remove dead code from libata-acpi.c

2013-06-21 Thread Sergei Shtylyov
Hello. On 21-06-2013 4:55, Aaron Lu wrote: +void ata_acpi_hotplug_init(struct ata_host *host) +{ + int i; + + for (i = 0; i < host->n_ports; i++) { + struct ata_port *ap = host->ports[i]; + acpi_handle handle; + struct ata_device *dev; + +

Re: [PATCH 07/45] CPU hotplug: Expose the new debug config option

2013-06-23 Thread Sergei Shtylyov
Hello. On 23-06-2013 17:39, Srivatsa S. Bhat wrote: Now that we have all the pieces of the CPU hotplug debug infrastructure in place, expose the feature by growing a new Kconfig option, CONFIG_DEBUG_HOTPLUG_CPU. Cc: Andrew Morton Cc: "Paul E. McKenney" Cc: Akinobu Mita Cc: Catalin Marinas

Re: [PATCH net] tun: fix recovery from gup errors

2013-06-23 Thread Sergei Shtylyov
Hello. On 23-06-2013 18:19, Michael S. Tsirkin wrote: get user pages might fail partially in tun zero copy mode. To recover we need to put all pages that we got, but code used a wrong index resulting in double-free errors. Reported-by: Brad Hubbard Signed-off-by: Michael S. Tsirkin ---

Re: [PATCH v2] [NET]: Unmap fragment page once iterator is done

2013-06-24 Thread Sergei Shtylyov
Hello. On 24-06-2013 10:33, Wedson Almeida Filho wrote: Callers of skb_seq_read() are currently forced to call skb_abort_seq_read() even when consuming all the data because the last call to skb_seq_read (the one that returns 0 to indicate the end) fails to unmap the last fragment page. With

Re: [PATCH v2 2/2] regulators: max8973: initial DT support

2013-06-24 Thread Sergei Shtylyov
Hello. On 06/24/2013 02:50 PM, Guennadi Liakhovetski wrote: This patch adds primitive DT support to the max8973 regulator driver. None of the configuration parameters, supported in the platform data are yet available in DT, therefore no configuration is performed if booting with no platform dat

Re: [PATCH v2] [NET]: Unmap fragment page once iterator is done

2013-06-24 Thread Sergei Shtylyov
Hello. On 06/25/2013 02:47 AM, Wedson Almeida Filho wrote: The summary line of the original commit is "[NET]: Zerocopy sequential reading of skb data". That's interesting but please update your patch. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/07/2013 05:14 PM, Lotfi Manseur wrote: Handle null termios in ftdi_set_termios(), introduced in commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 This has been corrected in the mainline by commits c515598e0f5769916c31c00392cc2bfe6af74e55 and a816e3113b63753c330ca4751ea1d208e93e3015.

Re: [PATCH] USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/07/2013 10:32 PM, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman When writing data we were: lock do some work unlock call function lock do some work unlock return return I

Re: [PATCH 20/31] mips/kvm: Hook into TLB fault handlers.

2013-06-07 Thread Sergei Shtylyov
Hello. On 06/08/2013 03:03 AM, David Daney wrote: From: David Daney If the CPU is operating in guest mode when a TLB related excpetion occurs, give KVM a chance to do emulation. Signed-off-by: David Daney --- arch/mips/mm/fault.c | 8 arch/mips/mm/tlbex-fault.S | 6 ++

Re: [PATCH 14/15] usb: phy: rcar-usb: Fix comment w.r.t. devm_ioremap_resource

2013-06-10 Thread Sergei Shtylyov
Hello. On 10-06-2013 15:35, Tushar Behera wrote: Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") introduced devm_ioremap_resource() and deprecated the use of devm_request_and_ioremap(). Signed-off-by: Tushar Behera CC: linux-...@vger.kernel.org CC: Felipe Balbi ---

Re: [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure

2013-06-11 Thread Sergei Shtylyov
Hello. On 11-06-2013 14:36, Sekhar Nori wrote: From: KV Sujith Add struct davinci_gpio_platform_data davinci gpio module. Signed-off-by: KV Sujith Signed-off-by: Philip Avinash As Linus commented before, this should be merged with 03/11. --- include/linux/platform_data/gpio-dav

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Sergei Shtylyov
Hello. On 11-06-2013 18:57, Markos Chandras wrote: The Vortex driver depends on PCI with optional support for EISA. This fixes build problems when EISA is selected but not PCI. drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of function 'pci_iomap' [-Werror=implicit-

Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread Sergei Shtylyov
Hello. On 06/11/2013 01:45 PM, B, Ravi wrote: + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); + phy->phy_wkup = ioremap(res->start, resource_size(res)); devm_ioremap? The phy_wakeup register is common across two instances of phy, devm_ioremap_resourc

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Sergei Shtylyov
Hello. On 06/12/2013 12:16 AM, Paul Gortmaker wrote: The Vortex driver depends on PCI with optional support for EISA. This fixes build problems when EISA is selected but not PCI. drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of function 'pci_iomap' [-Werror=implici

Re: [PATCH] N900: fix operation on emulator

2013-07-01 Thread Sergei Shtylyov
Hello. On 07/01/2013 06:03 PM, Pavel Machek wrote: Errata workarounds for N900 hardware actually break operation on emulator. Fix it. This approach was suggested by Pali Rohár (thanks!). (Also explain what "sleep_ind" led actually does). Looks like unrelated change and probably wort

Re: [PATCH] N900: fix operation on emulator

2013-07-01 Thread Sergei Shtylyov
Hello. On 07/01/2013 11:51 PM, Pavel Machek wrote: Errata workarounds for N900 hardware actually break operation on emulator. Fix it. This approach was suggested by Pali Rohár (thanks!). (Also explain what "sleep_ind" led actually does). Looks like unrelated change and probably wo

Re: [PATCH next-20130703] net: sock: Add ifdef CONFIG_MEMCG_KMEM for mem_cgroup_sockets_{init,destroy}

2013-07-03 Thread Sergei Shtylyov
Hello. On 03-07-2013 16:14, Sedat Dilek wrote: When "CONFIG_MEMCG_KMEM=n" I see this in my build-log: ... LD init/built-in.o mm/built-in.o: In function `mem_cgroup_css_free': memcontrol.c:(.text+0x5caa6): undefined reference to `mem_cgroup_sockets_destroy' make[2]: *** [vmlinux] Error 1

Re: [PATCH] arm: Convert sa1111 platform and bus legacy pm_ops to dev_pm_ops

2013-07-05 Thread Sergei Shtylyov
Hello. On 07/06/2013 02:44 AM, Shuah Khan wrote: Convert arch/arm/common/sa platform and bus legacy pm_ops to dev_pm_ops. This change also updates the use of COMFIG_PM to CONFIG_PM_SLEEP as this platform and bus code implements PM_SLEEP ops and not the PM_RUNTIME ops. Compile tested. I

Re: [RFC 1/2] usb/musb dma: add cppi41 dma driver

2013-07-07 Thread Sergei Shtylyov
Hello. On 05-07-2013 20:12, Sebastian Andrzej Siewior wrote: This is a first shot of the cppi41 DMA driver. Where have you been when I submitted my drivers back in 2009? :-) It is currently used by a new musb dma-engine implementation. I have to test it somehow. The state of the cpp41

Re: [PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

2013-06-26 Thread Sergei Shtylyov
Hello. On 26-06-2013 13:41, navin patidar wrote: dev_warn() is preferred over pr_warning(). container_of() is used to get usb_driver pointer from usbip_device container (stub_device or vhci_device), to get device structure required for dev_warn(). Signed-off-by: navin patidar --- drive

Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton()

2013-06-27 Thread Sergei Shtylyov
Hello. On 27-06-2013 10:43, Cong Wang wrote: Signed-off-by: Cong Wang --- include/net/inet_addr.h | 20 net/core/netpoll.c | 24 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/include/net/inet_addr.h b/include/net/i

Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton()

2013-06-27 Thread Sergei Shtylyov
On 06/27/2013 06:18 PM, Sergei Shtylyov wrote: Signed-off-by: Cong Wang --- include/net/inet_addr.h | 20 net/core/netpoll.c | 24 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/include/net/inet_addr.h b/include/net

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Sergei Shtylyov
Hello. On 28-06-2013 3:10, William Gulland wrote: Control transfers have both IN and OUT (or SETUP) packets, so when clearing TT buffers for a control transfer it's necessary to send two HUB_CLEAR_TT_BUFFER requests to the hub. Signed-off-by: William Gulland --- drivers/usb

[PATCH] dma: add driver for R-Car HPB-DMAC

2013-06-29 Thread Sergei Shtylyov
e breaks in the dev_dbg() calls, rephrased and added IRQ # to the shdma_request_irq() failure message, added MODULE_AUTHOR(), fixed guard macro name in the header file, fixed #define ASYNCRSTR_ASRST20, added #define ASYNCRSTR_ASRST24, beautified some commets.] Signed-off-by: Sergei Shtylyov --- The p

Re: [PATCH] dma: add driver for R-Car HPB-DMAC

2013-06-29 Thread Sergei Shtylyov
Hello. On 06/30/2013 12:15 AM, Sergei Shtylyov wrote: Oops, forgot to add the From: line. The patch is not mine, I've only modified it slightly. Will repost now... Add support for HPB-DMAC found in Renesas R-Car SoCs, using 'shdma-base' DMA driver framework. Based on the

[PATCH v2] dma: add driver for R-Car HPB-DMAC

2013-06-29 Thread Sergei Shtylyov
macro name in the header file, fixed #define ASYNCRSTR_ASRST20, added #define ASYNCRSTR_ASRST24, beautified some commets.] Signed-off-by: Sergei Shtylyov --- The patch is against the 'next' branch of Vinod Koul's 'slave-dma.git' repo. Changes in version 2: - remov

Re: [RFC PATCH v2, part4 31/39] mm/SH: prepare for removing num_physpages and simplify mem_init()

2013-03-24 Thread Sergei Shtylyov
Hello. On 24-03-2013 11:25, Jiang Liu wrote: Prepare for removing num_physpages and simplify mem_init(). Signed-off-by: Jiang Liu Cc: Paul Mundt Cc: Wen Congyang Cc: Tang Chen Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- arch/sh/mm/init.c | 25 ---

Re: [RFC PATCH v2, part4 09/39] mm: use totalram_pages instead of num_physpages at runtime

2013-03-24 Thread Sergei Shtylyov
Hello. On 24-03-2013 11:24, Jiang Liu wrote: The global variable num_physpages is scheduled to be removed, so use totalram_pages instead of num_physpages at runtime. Signed-off-by: Jiang Liu Cc: Miklos Szeredi Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHI

Re: [RFC PATCH v2, part4 37/39] mm: use totalram_pages instead of num_physpages at runtime

2013-03-24 Thread Sergei Shtylyov
Hello. On 24-03-2013 11:25, Jiang Liu wrote: The global variable num_physpages is scheduled to be removed, so use totalram_pages instead of num_physpages at runtime. Signed-off-by: Jiang Liu Cc: Miklos Szeredi Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHI

Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

2013-08-14 Thread Sergei Shtylyov
Hello. On 08/14/2013 07:39 AM, Libo Chen wrote: We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL

Re: [PATCH RESEND 0/8] use platform_{get,set}_drvdata()

2013-08-14 Thread Sergei Shtylyov
On 08/14/2013 07:36 AM, Libo Chen wrote: We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after devi

<    1   2   3   4   5   6   7   8   9   10   >