On 04/02/13 01:41, Greg KH wrote:
On Fri, Feb 01, 2013 at 04:55:01PM +, Serban Constantinescu wrote:
Hi Greg,
On 01/02/13 16:18, Greg KH wrote:
On Fri, Feb 01, 2013 at 04:08:00PM +, Serban Constantinescu wrote:
The values exchanged between kernel and userspace through struct
This patch modifies the IOCTL macros to use user-exportable data types,
as they are the referred kernel types for the user/kernel interface.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h
set has been successfully tested on 32bit platforms(ARMv7 VExpress)
and 64bit platforms(ARMv8 RTSM) running a 32bit Android userspace and an in
kernel binder compat layer.
Best Regards,
Serban Constantinescu
Serban Constantinescu (8):
staging: android: binder: replace explicit size types
Since the binder driver uses both uint32_t and unsigned int any further
kernel changes will be difficult to read. This patch fixes the inconsistent
types usage.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging
: Serban Constantinescu
---
drivers/staging/android/binder.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index a2cdd9e..b5c2b59 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging
need for
a 64bit size_t on 64bit platforms).
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android
Fix format specifiers warnings introduced by the previous patch which
changes some structures in binder.h.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 22 +++---
1
he Android filesystem.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/android/
binder_thread_read/write
and make use of kernel types as well as user-exportable ones.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c |6 +++---
drivers/staging/android/binder.h | 16
2 files changed
will also ease our work in differentiating
BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/
32bit platforms(VExpress 4xA9) and
64bit platforms(RTSMv8) running 32bit Android userspace and 64bit Linux +
ashmem unit tests.
Best Regards,
Serban Constantinescu
PDSW Engineer ARM Ltd.
Serban Constantinescu (2):
staging: android: ashmem: fix ashmem pin/unpin interface
staging: android
The values exchanged between kernel and userspace through struct
ashmem_pin should be of type size_t. This change won't affect the
existing interface but will stand as the basis of 64bit compat layer.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/ashmem.c |2 +-
dr
ss A9(32bit platform).
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/ashmem.c | 65 ++
drivers/staging/android/ashmem.h | 15 +
2 files changed, 66 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/android/ashmem.c b/dr
Hi Greg,
On 01/02/13 16:18, Greg KH wrote:
On Fri, Feb 01, 2013 at 04:08:00PM +, Serban Constantinescu wrote:
The values exchanged between kernel and userspace through struct
ashmem_pin should be of type size_t. This change won't affect the
existing interface but will stand as the bas
ss A9(32bit platform).
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/ashmem.c | 21 -
drivers/staging/android/ashmem.h |6 ++
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ash
not pulled in for a default Linux
build.
Best Regards,
Serban Constantinescu
PDSW Engineer ARM Ltd.
Serban Constantinescu (2):
Staging: android: binder: Add support for 32bit binder calls in a
64bit kernel
Staging: android: ashmem: Add support for 32bit ashmem calls in a
64bit kernel
s a better
solution.
The patch has been successfully tested on ARMv8 AEM and Versatile
Express V2P-CA9.
Signed-off-by: Serban Constantinescu
Reviewed-by: Catalin Marinas
---
drivers/staging/android/ashmem.c | 60 +-
drivers/staging/android/ashmem.h |6 ++-
patch has been successfully tested on ARMv8 AEM and Versatile
Express V2P-CA9.
Signed-off-by: Serban Constantinescu
Reviewed-by: Catalin Marinas
---
drivers/staging/android/binder.c | 298 --
drivers/staging/android/binder.h | 56 +++
2 files ch
quot;);
Don't merge debug code into the kernel. It just means people can
spam /var/log/messages.
I see what you mean. I won't include those in the new patch set.
regards,
dan carpenter
Kind regards,
Serban Constantinescu
`
-- IMPORTANT NOTICE: The contents of this email and a
On 04/12/12 16:17, Greg KH wrote:
On Tue, Dec 04, 2012 at 10:44:13AM +, Serban Constantinescu wrote:
Android's IPC, Binder, does not support calls from a 32-bit userspace
in a 64 bit kernel. This patch adds support for syscalls coming from a
32-bit userspace in a 64-bit kernel.
Most o
On 05/12/12 00:26, Arve Hjønnevåg wrote:
On Tue, Dec 4, 2012 at 2:44 AM, Serban Constantinescu
wrote:
Android's IPC, Binder, does not support calls from a 32-bit userspace
in a 64 bit kernel. This patch adds support for syscalls coming from a
32-bit userspace in a 64-bit kernel.
It
Sorry for the disclaimer e-mail.
On 04/12/12 16:17, Greg KH wrote:
On Tue, Dec 04, 2012 at 10:44:13AM +, Serban Constantinescu wrote:
Android's IPC, Binder, does not support calls from a 32-bit userspace
in a 64 bit kernel. This patch adds support for syscalls coming from a
3
On 03/06/13 22:41, Arve Hjønnevåg wrote:
On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu
wrote:
The changes in this patch will fix the binder interface for use on 64bit
machines and stand as the base of the 64bit compat support. The changes
apply to the structures that are passed
On 05/06/13 00:58, Arve Hjønnevåg wrote:
On Tue, Jun 4, 2013 at 1:54 AM, Serban Constantinescu
wrote:
On 03/06/13 22:41, Arve Hjønnevåg wrote:
On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu
wrote:
The changes in this patch will fix the binder interface for use on 64bit
machines
Hi all,
Sorry for the late reply on this patch set - I had to re-prioritise some
of the other tasks I am currently working on. v5 of this patch set
should be out the door soon.
On 05/06/13 00:58, Arve Hjønnevåg wrote:
On Tue, Jun 4, 2013 at 1:54 AM, Serban Constantinescu
wrote:
On 03/06
Merged with the patch fixing the printk format specifiers.
Serban Constantinescu (6):
staging: android: binder: modify struct binder_write_read to use
size_t
staging: android: binder: fix BINDER_SET_MAX_THREADS declaration
staging: android: binder: fix BC_FREE_BUFFER ioctl declaration
he Android filesystem.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
: Serban Constantinescu
---
drivers/staging/android/binder.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index ce70909..7450d56 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android
well as user-exportable ones
and fix format specifier issues.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 20 ++--
drivers/staging/android/binder.h | 10 +-
2 files changed, 15 insertions
will also ease our work in differentiating
BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
64bit size_t
on 64bit platforms).
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.h b/drivers
.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.c | 10 +-
drivers/staging/android/binder.h |8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging
Hi all,
Any feedback or comments on this patch set?
Thanks,
Serban
On 19/06/13 18:12, Serban Constantinescu wrote:
Hi all,
This set of patches will clean-up and fix some of the issues that arise
with the current binder interface when moving to a 64bit kernel. All these
changes will not
On 03/07/13 23:30, Arve Hjønnevåg wrote:
On Wed, Jun 19, 2013 at 10:12 AM, Serban Constantinescu
wrote:
Since this driver is meant to be used on different types of processors
and a portable driver should specify the size a variable expects to be
this patch changes the types used throughout the
On 03/07/13 23:32, Arve Hjønnevåg wrote:
On Wed, Jul 3, 2013 at 9:35 AM, Serban Constantinescu
wrote:
Hi all,
Any feedback or comments on this patch set?
Thanks,
Serban
The new patches look OK, but I would like to also see the patches that
add support for 32 bit user-space on a 64 bit
.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.c | 10 +-
drivers/staging/android/binder.h |8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging
ommand IOCTL declarations according to Arve's review
Changes for v2:
1: 1/7: Modified the commit message according to Greg's feedback;
2: 3/7: Merged with the patch fixing the printk format specifiers.
Serban Constantinescu (6):
staging: android: binder: modify struct binder_write
will also ease our work in differentiating
BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index ce70909..7450d56 100644
--- a/drivers/staging/android/binder.c
well as user-exportable ones
and fix format specifier issues.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.c | 20 ++--
drivers/staging/android/binder.h | 12 ++--
2 files
64bit size_t
on 64bit platforms).
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.h b/drivers
he Android filesystem.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
ss A9(32bit platform).
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/ashmem.c | 22 +-
drivers/staging/android/ashmem.h |6 ++
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ash
On 05/03/13 08:37, Greg KH wrote:
On Mon, Feb 25, 2013 at 06:44:36PM +, Serban Constantinescu wrote:
Android's shared memory subsystem, Ashmem, does not support calls from a
32bit userspace in a 64 bit kernel. This patch adds support for syscalls
coming from a 32bit userspace in a
On 05/03/13 10:27, Greg KH wrote:
On Tue, Mar 05, 2013 at 10:18:27AM +, Serban Constantinescu wrote:
Android's shared memory subsystem, Ashmem, does not support calls from a
32bit userspace in a 64 bit kernel. This patch adds support for syscalls
coming from a 32bit userspace in a
ss A9(32bit platform).
v2: Fix missing compat.h include.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
Acked-by: John Stultz
---
drivers/staging/android/ashmem.c | 21 -
drivers/staging/android/ashmem.h |7 +++
2 files changed, 27 insertions(+), 1 del
On 06/04/13 07:00, Greg KH wrote:
On Fri, Apr 05, 2013 at 04:17:47PM -0700, Arve Hjønnevåg wrote:
On Thu, Apr 4, 2013 at 5:32 AM, Serban Constantinescu
wrote:
Since the binder driver uses both uint32_t and unsigned int any further
kernel changes will be difficult to read. This patch fixes
On 06/04/13 00:38, Arve Hjønnevåg wrote:
On Fri, Apr 5, 2013 at 3:00 PM, Greg KH wrote:
On Thu, Apr 04, 2013 at 01:32:30PM +0100, Serban Constantinescu wrote:
Hi all,
This set of patches will clean-up and fix some of the issues that arise
with the current binder interface when moving to a
for v2:
1: 1/7: Modified the commit message according to Greg's feedback;
2: 3/7: Merged with the patch fixing the printk format specifiers.
Serban Constantinescu (7):
staging: android: binder: clean-up uint32_t types
staging: android: binder: replace IOCTL types with user-exportable
uint32_t types are used inconsistently throughout the driver. This patch
replaces "uint32_t" types with "unsigned int" ones.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/and
need for
a 64bit size_t on 64bit platforms).
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android
: Serban Constantinescu
---
drivers/staging/android/binder.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index a2cdd9e..b5c2b59 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging
he Android filesystem.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/android/
This patch modifies the IOCTL macros to use user-exportable data types,
as they are the referred kernel types for the user/kernel interface.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h
will also ease our work in differentiating
BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/
binder_thread_read/write,
make use of kernel types as well as user-exportable ones and fix
format specifier issues.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 28 ++--
drivers/staging
On 10/04/13 01:11, Arve Hjønnevåg wrote:
On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu
wrote:
uint32_t types are used inconsistently throughout the driver. This patch
replaces "uint32_t" types with "unsigned int" ones.
I don't like this change. You fix the h
On 10/04/13 00:53, Arve Hjønnevåg wrote:
On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu
wrote:
This change will fix the BINDER_SET_MAX_THREADS ioctl to use __s32
instead of size_t for setting the max threads. Thus using the same
handler for 32 and 64bit kernels.
This value is stored
On 10/04/13 00:48, Arve Hjønnevåg wrote:
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 5794cf6..a2cdd9e 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
...
@@ -1700,7 +1700,7 @@ err_no_context_mgr_node:
}
int binder_
On 10/04/13 00:58, Arve Hjønnevåg wrote:
On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu
wrote:
The Android userspace aligns the data written to the binder buffers to
4bytes. Thus for 32bit platforms or 64bit platforms running an 32bit
Android userspace we can have a buffer looking like
Hi Arve,
On 30/04/13 00:13, Arve Hjønnevåg wrote:
On Mon, Apr 29, 2013 at 9:16 AM, Serban Constantinescu
wrote:
Hi all,
Any feedback or comments on this patch set?
You don't seem to have addressed my feedback on the previous patch set.
For v3 I have modified the following accordi
Hi Kirill,
On 30/04/13 08:31, Kirill A. Shutemov wrote:
On Fri, Apr 12, 2013 at 01:25:49PM +0100, Serban Constantinescu wrote:
The patch set has been successfully tested with a 64bit Linux userspace and
64bit binder unit-tests.
This patch set has been successfully tested on 32bit platforms
On 30/04/13 11:04, Kirill A. Shutemov wrote:
On Tue, Apr 30, 2013 at 09:52:34AM +0100, Serban Constantinescu wrote:
Hi Kirill,
On 30/04/13 08:31, Kirill A. Shutemov wrote:
On Fri, Apr 12, 2013 at 01:25:49PM +0100, Serban Constantinescu wrote:
The patch set has been successfully tested with a
On 01/05/13 00:52, Arve Hjønnevåg wrote:
On Tue, Apr 30, 2013 at 1:36 AM, Serban Constantinescu
wrote:
Hi Arve,
On 30/04/13 00:13, Arve Hjønnevåg wrote:
On Mon, Apr 29, 2013 at 9:16 AM, Serban Constantinescu
wrote:
Hi all,
Any feedback or comments on this patch set?
You don't
Hi all,
Any feedback or comments on this patch set?
Thanks,
Serban
On 12/04/13 13:25, Serban Constantinescu wrote:
Hi all,
This set of patches will clean-up and fix some of the issues that arise
with the current binder interface when moving to a 64bit kernel. All these
changes will not
On 10/04/13 23:12, Arve Hjønnevåg wrote:
struct flat_binder_object {
/* 8 bytes for large_flat_header. */
- unsigned long type;
- unsigned long flags;
+ __u32 type;
+ __u32 flags;
/* 8 bytes of data. */
union {
void __user *binder; /* local object */
- signed long handle; /* remote object */
+ _
On 10/04/13 23:30, Arve Hjønnevåg wrote:
On Wed, Apr 10, 2013 at 9:39 AM, Serban Constantinescu
wrote:
On 10/04/13 00:58, Arve Hjønnevåg wrote:
On Tue, Apr 9, 2013 at 3:00 AM, Serban Constantinescu
wrote:
The Android userspace aligns the data written to the binder buffers to
4bytes. Thus
ed BINDER_SET_MAX_THREADS ioctl definition accordint to Arve's review
5: Modified the binder command IOCTL declarations according to Arve's review
Changes for v2:
1: 1/7: Modified the commit message according to Greg's feedback;
2: 3/7: Merged with the patch fixing the printk form
64bit size_t
on 64bit platforms).
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
index
he Android filesystem.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/android/
well as user-exportable ones
and fix format specifier issues.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 20 ++--
drivers/staging/android/binder.h |8
2 files changed, 14 insertions(+), 14
: Serban Constantinescu
---
drivers/staging/android/binder.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 06004cf..6436f22 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging
.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 10 +-
drivers/staging/android/binder.h |8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers
will also ease our work in differentiating
BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
27;s review
Changes for v2:
1: 1/7: Modified the commit message according to Greg's feedback;
2: 3/7: Merged with the patch fixing the printk format specifiers.
Serban Constantinescu (6):
staging: android: binder: modify struct binder_write_read to use
size_t
staging: android: binder: fix
.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 10 +-
drivers/staging/android/binder.h |8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers
will also ease our work in differentiating
BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
Acked-by: Arve Hjønnevåg
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
, where
on 64bit systems, if the data_size is not aligned to 8bytes the offset's
start address will be incorrectly calculated.
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 18 +-
1 file chang
he Android filesystem.
The patch does not change in any way the functionality of the binder driver.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/android/
64bit size_t
on 64bit platforms).
The change does not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
index
well as user-exportable ones
and fix format specifier issues.
The changes do not affect existing 32bit ABI.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 20 ++--
drivers/staging/android/binder.h |8
2 files changed, 14 insertions(+), 14
This patch moves some of the logic for binder_thread_write() into
subfunctions. This way we can share more code with the binder compat
layer.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 403 +-
1 file changed, 220 insertions
This patch adds binder_copy_to_user() to be used for copying binder
commands to user address space. This way we can abstract away the
copy_to_user() calls and add separate handling for the compat layer.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 39
helper macros are extended
with compat handling by the last patch of the series.
The patches have been successfully tested on 32 and 64bit platforms.
Thanks for your help,
Best regards,
Serban Constantinescu
Serban Constantinescu (9):
staging: android: binder: Move some of the logic into
This patch adds copy_flat_binder_object macro() that will help
dereference struct flat_binder_object on 64bit systems where the
structure differs between 32bit and 64bit userspace.
This patch is a temporary patch that will be extended with 32bit compat
handling.
Signed-off-by: Serban
-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 95c2581..6d22717 100644
--- a/drivers/staging/android/binder.c
+++ b
This patch modifies the functions that need to be passed the explicit
command to use a boolean flag. This way we can reuse the code for 64bit
compat commands.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 35 ++-
1 file changed, 18
This patch adds support for 32bit userspace running on 64bit kernels.
All the changes done in this patch have been tested on 32bit and 64bit
systems.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 355 +-
1 file changed, 353
This patch adds all the needed compat structures to binder.h. All the
structures defined in this patch mirror the structure and size of 32bit
ones.
Signed-off-by: Serban Constantinescu
---
drivers/staging/android/binder.h | 109 ++
1 file changed, 109
This patch adds align_helper() macro that will be used for enforcing
the desired alignment on 64bit systems where the alignment will differ
depending on the userspace used (32bit /64bit).
This patch is a temporary patch that will be extended with 32bit compat
handling.
Signed-off-by: Serban
-off-by: Serban Constantinescu
---
drivers/staging/android/binder.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 6719a53..95c2581 100644
--- a/drivers/staging/android
_t != void *).
Author: Serban Constantinescu
Date: Thu Jul 4 10:54:48 2013 +0100
staging: android: binder: fix binder interface for 64bit compat layer
*64bit kernel/ 64bit coexisting with 32bit userspace
Please note that *none of the above solutions fix this yet*. To
understand why this is a sp
On 05/12/13 08:18, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
+static void bc_increfs_done(struct binder_proc *proc,
+ struct binder_thread *thread, uint32_t cmd,
+ void __user *node_ptr, void __user *cookie
On 05/12/13 08:00, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote:
+static void bc_dead_binder_done(struct binder_proc *proc,
+ struct binder_thread *thread, void __user *cookie)
+{
+ struct binder_work *w;
+ struct
On 04/12/13 23:17, Greg KH wrote:
On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote:
This patch adds binder_copy_to_user() to be used for copying binder
commands to user address space. This way we can abstract away the
copy_to_user() calls and add separate handling for the
On 05/12/13 08:40, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote:
This patch modifies the functions that need to be passed the explicit
command to use a boolean flag. This way we can reuse the code for 64bit
compat commands.
I don't under
96 matches
Mail list logo
