[PATCH] mtd: nand: davinci: don't acquire and enable clock

2018-03-30 Thread Sekhar Nori
DM644x EVM in legacy boot. Signed-off-by: Sekhar Nori --- Hi Boris, If/when this patch gets accepted, it will nice to put this on an immutable branch others can merge. There is potential cleanup in drivers/clock and in DaVinci machine code that will depend on this. Thanks, Sekhar drivers/mtd

Re: [PATCH v8 42/42] ARM: dts: da850: Add clocks

2018-04-02 Thread Sekhar Nori
On Friday 16 March 2018 10:50 PM, David Lechner wrote: > On 03/15/2018 09:52 PM, David Lechner wrote: >> This adds clock provider nodes for da850 and wires them up to all of the >> devices. >> >> Signed-off-by: David Lechner >> --- > > ... > > This is the mcasp0: mcasp@10 node... > >> @@ -5

Re: [PATCH v8 42/42] ARM: dts: da850: Add clocks

2018-04-02 Thread Sekhar Nori
On Monday 02 April 2018 09:45 PM, David Lechner wrote: > On 04/02/2018 06:12 AM, Sekhar Nori wrote: >> On Friday 16 March 2018 10:50 PM, David Lechner wrote: >>> On 03/15/2018 09:52 PM, David Lechner wrote: >>>> This adds clock provider nodes for da850 and wi

Re: [RFC work-in-progress 5/7] !WIP ARM: davinci: convert da850 to using the davinci clocksource driver

2018-04-24 Thread Sekhar Nori
On Tuesday 24 April 2018 12:08 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/mach-davinci/da850.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci

Re: [RFC work-in-progress 0/7] of: platform: use early platform routines instead of OF_DECLARE

2018-04-24 Thread Sekhar Nori
On Tuesday 24 April 2018 12:56 PM, Bartosz Golaszewski wrote: > 2018-04-23 23:38 GMT+02:00 David Lechner : >> FYI: It looks like the CC for Stephen and Arnd was messed up, so I >> fixed. >> > > Thanks! > >> On 04/23/2018 01:38 PM, Bartosz Golaszewski wrote: >>> >>> From: Bartosz Golaszewski >>>

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

2018-04-24 Thread Sekhar Nori
On Monday 23 April 2018 08:29 PM, David Lechner wrote: > On 04/06/2018 11:46 AM, Stephen Boyd wrote: >> Quoting Sekhar Nori (2018-04-06 02:37:03) >>> >>> Can you please check that and confirm there is no issue with genpd and >>> using CLK_OF_DECLARE() to i

Re: [PATCH v2 0/2] memory: aemif: add support for machine code

2018-04-24 Thread Sekhar Nori
On Friday 20 April 2018 10:54 PM, santosh.shilim...@oracle.com wrote: > On 4/19/18 8:12 AM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> This is a follow-up to the series that contained both changes to the >> aemif driver and platform code. It contains only the driver changes. >>

Re: [PATCH] davinci_all_defconfig: enable support for remoteproc drivers

2018-04-24 Thread Sekhar Nori
On Thursday 19 April 2018 05:33 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Enable the remoteproc framework and the da8xx remoteproc driver by > default in the davinci defconfig. > > Signed-off-by: Bartosz Golaszewski Applied to v4.18/defconfig. Please note that subject like

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

2018-05-03 Thread Sekhar Nori
Hi Boris, On Monday 30 April 2018 10:17 PM, Boris Brezillon wrote: > On Mon, 30 Apr 2018 18:45:06 +0200 > Bartosz Golaszewski wrote: > >> 2018-04-30 12:09 GMT+02:00 Boris Brezillon : >>> Hi Bartosz, >>> >>> On Mon, 30 Apr 2018 10:24:41 +0200 >>> Bartosz Golaszewski wrote: >>> From: Bartosz

Re: [PATCH v9 09/27] ARM: davinci: dm644x: add new clock init using common clock framework

2018-05-03 Thread Sekhar Nori
On Friday 27 April 2018 05:47 AM, David Lechner wrote: > void __init dm644x_init_time(void) > { > +#ifdef CONFIG_COMMON_CLK > + void __iomem *pll1, *psc; > + struct clk *clk; > + > + clk_register_fixed_rate(NULL, "ref_clk", NULL, 0, DM644X_REF_FREQ); > + > + pll1 = ioremap(DAVINCI

Re: [PATCH v9 07/27] ARM: davinci: dm355: add new clock init using common clock framework

2018-05-03 Thread Sekhar Nori
On Friday 27 April 2018 05:47 AM, David Lechner wrote: > This adds the new board-specific clock init in mach-davinci/dm355.c > using the new common clock framework drivers. > > The #ifdefs are needed to prevent compile errors until the entire > ARCH_DAVINCI is converted. > > Also clean up the #in

Re: [PATCH] ARM: dts: da850-lcdk: increase the size of the u-boot nand partition

2018-05-04 Thread Sekhar Nori
Hi Bartosz, On Friday 04 May 2018 01:38 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Current mainline u-boot builds images that are bigger than the 0x8 > bytes u-boot partition allocated from the NAND memory. Using the free > space partition results in an unbootable system.

Re: [PATCH v9 07/27] ARM: davinci: dm355: add new clock init using common clock framework

2018-05-04 Thread Sekhar Nori
On Thursday 03 May 2018 09:14 PM, David Lechner wrote: > On 05/03/2018 10:34 AM, Sekhar Nori wrote: >> On Friday 27 April 2018 05:47 AM, David Lechner wrote: >>> This adds the new board-specific clock init in mach-davinci/dm355.c >>> using the new common clock fra

Re: [PATCH] clk: davinci: pll-dm355: fix SYSCLKn parent names

2018-05-06 Thread Sekhar Nori
during the driver's development. > > Reported-by: Sekhar Nori > Signed-off-by: David Lechner > --- > > Sekhar, can you please test to make sure this works? > > > drivers/clk/davinci/pll-dm355.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions

Re: [PATCH] ARM: dts: da850: use gpio-ranges

2018-04-15 Thread Sekhar Nori
On Monday 16 April 2018 12:27 AM, David Lechner wrote: > On 02/23/2018 05:44 AM, Sekhar Nori wrote: >> On Thursday 22 February 2018 09:04 PM, Linus Walleij wrote: >>> On Mon, Feb 19, 2018 at 11:29 PM, David Lechner >>> wrote: >>> >>>> This makes u

Re: [RESEND PATCH v2 0/4] ARM: davinci: remove the mach-specific aemif driver - part 1

2018-04-17 Thread Sekhar Nori
Hi Bartosz, On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is the first part of changes required to remove duplicate aemif > support from mach-davinci. > > I actually noticed that one of my previous changes from 2017 broke nand > in legacy mod

Re: [RESEND PATCH v2 2/4] memory: aemif: add support for board files

2018-04-17 Thread Sekhar Nori
On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently aemif is supported in two places separately. By the platform > driver in drivers/memory and by a hand crafted driver in mach-davinci. > > We want to drop the latter but also keep the legacy mo

Re: [RESEND PATCH v2 3/4] ARM: davinci: add aemif & nand support to da850-lcdk in legacy mode

2018-04-17 Thread Sekhar Nori
On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We now have support for aemif & nand from board files. As an example > add support for nand to da850-lcdk in legacy mode. Hawkboard is a separate board of its own, although closely related to LCDK. Lets

Re: [RESEND PATCH v2 4/4] ARM: davinci: use aemif platform driver in legacy mode for da850-evm

2018-04-17 Thread Sekhar Nori
On Tuesday 17 April 2018 03:59 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We now support board files in aemif. Use the platform driver instead > of the handcrafted API in da850-evm. > > Note: the id of davinci_nand is changed to 0 in order to make it work > with the new commo

Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-10 Thread Sekhar Nori
r: Adam Ford AuthorDate: Mon May 7 07:37:21 2018 -0500 Commit: Sekhar Nori CommitDate: Thu May 10 14:01:15 2018 +0530 ARM: dts: da850-evm: use phandles to extend nodes Many node labels in the device tree (like serial0, serial1, etc) are being redefined, so let's m

Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-10 Thread Sekhar Nori
On Thursday 10 May 2018 08:38 PM, Adam Ford wrote: > On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori wrote: >> On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >>> Many node labels in the device tree (like serial0, serial1, etc) are being >>> redefined, so let's mo

Re: [PATCH v3 1/2] clk: davinci: pll-dm355: drop pll2_sysclk2

2018-05-10 Thread Sekhar Nori
echanism to keep it on. > > Reported-by: Sekhar Nori > Signed-off-by: David Lechner I would not have minded the SYSCLK_ALWAYS_ENABLED change to be a separate patch too, but: Acked-by: Sekhar Nori Thanks, Sekhar

Re: [PATCH v3 2/2] clk: davinci: pll-dm355: fix SYSCLKn parent names

2018-05-10 Thread Sekhar Nori
during the driver's development. > > Reported-by: Sekhar Nori > Signed-off-by: David Lechner Acked-by: Sekhar Nori Thanks, Sekhar

Re: [PATCH] ARM: davinci: DA8XX: fix oops in USB PHY driver due to stack allocated platform platform_data

2018-03-16 Thread Sekhar Nori
On Thursday 15 March 2018 11:32 PM, David Lechner wrote: > This fixes a possible kernel oops due to using stack allocated platform > data for the USB PHY driver on DA8XX devices. If the platform device > probe is deferred, then we get a corrupt pointer for the platform data. > > We now use a globa

Re: [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config

2018-03-16 Thread Sekhar Nori
On Thursday 15 March 2018 11:43 PM, David Lechner wrote: > Since commit 8253bb3f8255 ("regmap: potentially duplicate the name > string stored in regmap"), the name field of struct regmap_config > is copied in __regmap_init(), so we no longer need to worry about > keeping our own copy of the name. >

Re: [v2] ARM: davinci: fix the GPIO lookup for omapl138-hawk

2018-03-16 Thread Sekhar Nori
> >> Fixes: c69f43fb4f26 ("ARM: davinci: hawk: use gpio descriptor for mmc >> pins") >> Signed-off-by: Bartosz Golaszewski >> Signed-off-by: Bartosz Golaszewski >> Signed-off-by: Sekhar Nori >> --- >> v1 -> v2: >> - added the

Re: [PATCH v2 1/2] clk: davinci: pll-dm355: fix SYSCLKn parent names

2018-05-07 Thread Sekhar Nori
driver's development. > > Reported-by: Sekhar Nori > Signed-off-by: David Lechner > --- > > v2 changes: > - add second patch to fix additional problems with DM355 > > drivers/clk/davinci/pll-dm355.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 delet

Re: [PATCH v6 3/7] remoteproc/davinci: add the missing retval check for clk_enable()

2018-04-17 Thread Sekhar Nori
Acked-by: Suman Anna > Reviewed-by: David Lechner Reviewed-by: Sekhar Nori This should be safe to apply to v4.17-rc1 and should be queued by Ohad / Bjorn. Thanks, Sekhar

Re: [PATCH v6 4/7] remoteproc/davinci: prepare and unprepare the clock where needed

2018-04-17 Thread Sekhar Nori
szewski > Acked-by: Suman Anna > Reviewed-by: David Lechner Reviewed-by: Sekhar Nori This should be safe to apply to v4.17-rc1 as well (for inclusion in v4.18). Bartosz, I noticed that CONFIG_REMOTEPROC and the DA8XX driver is not enabled in davinci_all_defconfig. Can you please send a

Re: [PATCH v6 5/7] remoteproc/davinci: use octal permissions for module_param()

2018-04-17 Thread Sekhar Nori
On Tuesday 17 April 2018 11:00 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Checkpatch recommends to use octal perms instead of S_IRUGO. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Sekhar Nori Thanks, Sekhar

Re: [PATCH v6 6/7] remoteproc/davinci: use the reset framework

2018-04-17 Thread Sekhar Nori
On Tuesday 17 April 2018 11:00 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Switch to using the reset framework instead of handcoded reset routines > we used so far. > > Signed-off-by: Bartosz Golaszewski Looks good! Reviewed-by: Sekhar Nori This

Re: [RESEND PATCH v2 0/4] ARM: davinci: remove the mach-specific aemif driver - part 1

2018-04-18 Thread Sekhar Nori
On Tuesday 17 April 2018 10:59 PM, Santosh Shilimkar wrote: > On 4/17/2018 5:36 AM, Bartosz Golaszewski wrote: >> 2018-04-17 12:53 GMT+02:00 Sekhar Nori : >>> Hi Bartosz, > > [...] > >>>> This series applies on top of v8 of David Lechner's CCF series.

Re: [PATCH 2/2] memory: aemif: add support for board files

2018-04-19 Thread Sekhar Nori
On Wednesday 18 April 2018 09:05 PM, Bartosz Golaszewski wrote: > @@ -373,15 +372,23 @@ static int aemif_probe(struct platform_device *pdev) > goto error; > } > > - /* > - * For every controller device node, there is a cs device node that > - * describe the bus c

Re: [PATCH] ARM: dts: da850: enable high speed for mmc

2016-12-06 Thread Sekhar Nori
On Thursday 01 December 2016 07:40 PM, Axel Haslam wrote: > The mmc controller in da850 supports high speed modes > so add cap-sd-highspeed and cap-mmc-highspeed. > > Signed-off-by: Axel Haslam Forgot to reply earlier, but this was applied. Thanks, Sekhar

Re: [PATCH v3 1/3] ARM: da850: fix infinite loop in clk_set_rate()

2016-12-06 Thread Sekhar Nori
On Tuesday 06 December 2016 05:28 PM, Bartosz Golaszewski wrote: > 2016-12-05 11:15 GMT+01:00 Sekhar Nori : >> On Monday 05 December 2016 03:39 PM, Bartosz Golaszewski wrote: >>> The aemif clock is added twice to the lookup table in da850.c. This >>> breaks the child

Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node

2016-12-06 Thread Sekhar Nori
On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: > 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen : >> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>> Add the dumb-vga-dac node to the board DT together with corresponding >>> ports and vga connector. This allows to retrieve the edid inf

Re: [PATCH v3 1/3] ARM: da850: fix infinite loop in clk_set_rate()

2016-12-06 Thread Sekhar Nori
On Wednesday 07 December 2016 07:24 AM, David Lechner wrote: > On 12/05/2016 04:09 AM, Bartosz Golaszewski wrote: >> The aemif clock is added twice to the lookup table in da850.c. This >> breaks the children list of pll0_sysclk3 as we're using the same list >> links in struct clk. When calling clk_

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Sekhar Nori
Hi Frank, On Tuesday 22 November 2016 07:13 AM, Frank Rowand wrote: > On 11/21/16 08:33, Sekhar Nori wrote: >> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >>> +static int da8xx_ddrctl_probe(struct platform_device *pdev) >>> +{ >>> + const s

Re: [PATCH 0/2] ARM: davinvi: da850 add ohci DT nodes

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 10:29 PM, Axel Haslam wrote: > This adds the DT node for the ohci controller and > enables it for the omapl138-lckd platform. > > DEPENDENCIES: > > 1. [PATCH v6 0/5] USB: ohci-da8xx: Add device tree support > https://lkml.org/lkml/2016/11/21/558 Looks like atleast this

Re: [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: > The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 > > Signed-off-by: Axel Haslam The LCDK and HawkBoard are different boards. The HawkBoard schematic from eLinux.org page is broken, but looking for it on the net, I found

Re: [PATCH 2/3] ARM: davinci: hawk: remove mmc ro pin

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: > The hawk board does not have a write protect pin to read the card > write protect status. > > So remove un-needed platform data declaration for this gpio. > > Signed-off-by: Axel Haslam The schematic I found has the SD_WP pin connected t

Re: [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 03:40 PM, Axel Haslam wrote: > On Tue, Nov 22, 2016 at 10:53 AM, Sekhar Nori wrote: >> On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: >>> The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 >>> >>> Signed-off

Re: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: > Currently the mmc driver is polling the gpio to know if the > card was removed. > > By using a gpio descriptor instead of the platform callbacks, the > driver will be able to register the gpio with the mmc core with API's > designed for thi

Re: [RESEND PATCH 1/3] ARM: davinci: da830: Handle vbus with a regulator

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 10:23 PM, Axel Haslam wrote: > static __init void da830_evm_usb_init(void) > { > @@ -145,23 +123,13 @@ static __init void da830_evm_usb_init(void) > return; > } > > - ret = gpio_request(ON_BD_USB_DRV, "ON_BD_USB_DRV"); > - if (ret) { > -

Re: [RESEND PATCH 2/3] ARM: davinci: hawk: Remove vbus and over current gpios

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 10:23 PM, Axel Haslam wrote: > The hawk board VBUS is fixed to a 5v source, and the over > current pin is actually not connected to the SoC. > > Do not reseve these gpios for OHCI as they are not related > to usb. > > Signed-off-by: Axel Haslam As discussed over the M

Re: [RESEND PATCH 3/3] ARM: davinci: remove ohci platform usage

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 10:23 PM, Axel Haslam wrote: > As all users of ohci platform data have been converted > to use a regulator, we dont need to pass platform > data to register the ohci device anymore. > > Signed-off-by: Axel Haslam This looks good to me. Thanks, Sekhar

Re: [PATCH] ARM: dts: da850-lcdk: fix mmc card detect polarity

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 09:11 PM, Axel Haslam wrote: > The polarity of the card detect pin is inverted. > > Change it to reflect the right polarity for the board > which is ACTIVE_LOW. > > Signed-off-by: Axel Haslam Applied to v4.10/dt Thanks, Sekhar

Re: [PATCH 1/3] of: base: add support to get machine compatible string

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 04:36 PM, Sudeep Holla wrote: > > > On 22/11/16 10:57, Bartosz Golaszewski wrote: >> 2016-11-22 11:53 GMT+01:00 Sudeep Holla : >>> >>> >>> On 22/11/16 10:41, Bartosz Golaszewski wrote: Add a function allowing to retrieve the compatible string of the root

Re: [PATCH 1/3] of: base: add support to get machine compatible string

2016-11-22 Thread Sekhar Nori
Hi Sudeep, On Tuesday 22 November 2016 04:23 PM, Sudeep Holla wrote: > > > On 22/11/16 10:41, Bartosz Golaszewski wrote: >> Add a function allowing to retrieve the compatible string of the root >> node of the device tree. >> > > Rob has queued [1] and it's in -next today. You can reuse that if

Re: [PATCH] ARM: davinci_all_defconfig: Enable OHCI as module

2016-11-22 Thread Sekhar Nori
On Monday 21 November 2016 10:31 PM, Axel Haslam wrote: > Enable the davinci ohci driver as a module for usb > tested with the omap138-lcdk hawk board. > > Signed-off-by: Axel Haslam Applied to v4.10/defconfg after dropping "hawk" from commit description. Thanks, Sekhar

Re: [RESEND PATCH 2/3] ARM: davinci: hawk: Remove vbus and over current gpios

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 09:11 PM, Axel Haslam wrote: > Hi Sekhar > > On Tue, Nov 22, 2016 at 11:37 AM, Sekhar Nori wrote: >> On Monday 21 November 2016 10:23 PM, Axel Haslam wrote: >>> The hawk board VBUS is fixed to a 5v source, and the over >>> current pin

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: > Please note that the compatible property might contain several strings, not > just > a single string. So I guess the best thing to do is to use of_property_read_string_index() and print the sting at index 0. Thanks, Sekhar

Re: [PATCH 1/3] of: base: add support to get machine compatible string

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 09:16 PM, Sudeep Holla wrote: > Hi Sekhar, > > On 22/11/16 15:06, Sekhar Nori wrote: >> Hi Sudeep, >> >> On Tuesday 22 November 2016 04:23 PM, Sudeep Holla wrote: >>> >>> >>> On 22/11/16 10:41, Bartosz Golaszews

Re: [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: > Device-tree bindings for TI DA8XX/OMAP-L138/AM18XX pullup/pulldown s/DA8XX/DA850. It looks like this support is absent from DA830. > pinconf controller. > > Signed-off-by: David Lechner Thanks, Sekhar

Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: > This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These s/DA8XX/DA850/ > SoCs have a separate controller for controlling pullup/pulldown groups. > > Signed-off-by: David Lechner > +static const char *da850_pupd_get_g

Re: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: > This SoC has a separate pin controller for configuring pullup/pulldown > bias on groups of pins. > > Signed-off-by: David Lechner > --- > arch/arm/boot/dts/da850.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arc

Re: [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf

2016-11-23 Thread Sekhar Nori
nal pullup/down resistors disabled in order to work > correctly. This looks really neat to my non-pinconf trained eyes. I have sent some minor comments. But apart from that: Reviewed-by: Sekhar Nori 3/3 should go through my tree. If the driver patches are going to get queued for v4.10, I can que

Re: [PATCH 1/3] of: base: add support to get machine compatible string

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 03:35 PM, Sudeep Holla wrote: > > > On 23/11/16 07:49, Sekhar Nori wrote: >> On Tuesday 22 November 2016 09:16 PM, Sudeep Holla wrote: >>> Hi Sekhar, >>> >>> On 22/11/16 15:06, Sekhar Nori wrote: >>>> Hi Sudeep,

Re: [PATCH 1/3] of: base: add support to get machine compatible string

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 05:37 PM, Sudeep Holla wrote: >> So, the if(!of_node_get()) is just an expensive NULL pointer check. I >> think >> it is better to be explicit about it by not using of_node_get/put() at >> all. >> How about: >> > > Are we planning to use this in any time sensitive pat

Re: [PATCH v3 1/3] bus: da8xx-mstpri: drop the call to of_flat_dt_get_machine_name()

2016-11-23 Thread Sekhar Nori
Hi Bartosz, On Wednesday 23 November 2016 04:36 PM, Bartosz Golaszewski wrote: > In order to avoid a section mismatch use a locally implemented routine > instead of of_flat_dt_get_machine_name() when printing the error > message. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/bus/da8xx-

Re: [PATCH v2 1/3] ARM: davinci: da8xx: Fix ohci device name

2016-11-23 Thread Sekhar Nori
On Thursday 03 November 2016 09:33 PM, Axel Haslam wrote: > While the clk lookup table is making reference to "ohci" > other subsystems (such as phy) are trying to match "ohci.0" > > Since there is a single ohci instance, instead of changing > the clk name, change the dev id to -1, and add the "-d

Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-23 Thread Sekhar Nori
On Thursday 24 November 2016 04:18 AM, David Lechner wrote: > On 11/23/2016 04:32 PM, Kevin Hilman wrote: >> David Lechner writes: >> >>> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote: 2016-11-22 23:23 GMT+01:00 David Lechner : > On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:

Re: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 09:54 PM, David Lechner wrote: > On 11/23/2016 05:12 AM, Sekhar Nori wrote: >> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: >>> This SoC has a separate pin controller for configuring pullup/pulldown >>> bias on groups of

Re: [PATCH v4 0/2] da8xx: fix section mismatch in new drivers

2016-11-23 Thread Sekhar Nori
On Wednesday 23 November 2016 07:09 PM, Bartosz Golaszewski wrote: > Sekhar noticed there's a section mismatch in the da8xx-mstpri and > da8xx-ddrctl drivers. This is caused by calling > of_flat_dt_get_machine_name() which has an __init annotation. > > This series makes the drivers drop the call a

Re: [PATCH v2 2/4] serial: 8250: Add new port type for TI DA8xx/OMAPL13x/AM17xx/AM18xx/C66x

2017-01-05 Thread Sekhar Nori
on > device-tree boards as well and the mach code can eventually be removed. > > Signed-off-by: David Lechner Looks good to me, apart from the minor change above. Acked-by: Sekhar Nori Thanks, Sekhar

Re: [PATCH v2 4/4] ARM: dts: keystone: Add "ti,da830-uart" compatible string

2017-01-05 Thread Sekhar Nori
Hi Santosh, On Thursday 05 January 2017 03:30 AM, Santosh Shilimkar wrote: > On 1/4/2017 12:30 PM, David Lechner wrote: >> The TI Keystone SoCs have extra UART registers beyond the standard 8250 >> registers, so we need a new compatible string to indicate this. Also, at >> least one of these regis

Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850

2017-01-17 Thread Sekhar Nori
On Tuesday 17 January 2017 12:17 AM, David Lechner wrote: > On 01/16/2017 08:30 AM, Bartosz Golaszewski wrote: >> 2017-01-16 13:45 GMT+01:00 Sekhar Nori : >>> On Monday 16 January 2017 03:43 PM, Bartosz Golaszewski wrote: >>>> 2017-01-13 20:25 GMT+01:00 David

Re: [PATCH v2 01/14] devicetree: bindings: add bindings for ahci-da850

2017-01-18 Thread Sekhar Nori
On Wednesday 18 January 2017 12:05 AM, David Lechner wrote: > On 01/17/2017 06:26 AM, Bartosz Golaszewski wrote: >> Add DT bindings for the TI DA850 AHCI SATA controller. >> >> Signed-off-by: Bartosz Golaszewski >> --- >> Documentation/devicetree/bindings/ata/ahci-da850.txt | 18 >> ++

Re: [PATCH v2 06/14] ARM: davinci: da850: model the SATA refclk

2017-01-18 Thread Sekhar Nori
On Tuesday 17 January 2017 05:56 PM, Bartosz Golaszewski wrote: > Register a dummy clock modelling the external SATA oscillator for I would not call it a dummy clock. Its representing something physically present. Just call it "fixed rate clock" ? > da850 DT mode. For non-DT boot we don't registe

Re: [PATCH v2 12/14] ARM: dts: da850: add pinmux settings for the SATA controller

2017-01-18 Thread Sekhar Nori
Hi Bartosz, On Tuesday 17 January 2017 05:56 PM, Bartosz Golaszewski wrote: > Add pinmux sub-nodes for all muxed SATA pins. > > Signed-off-by: Bartosz Golaszewski Since these are all unused at this time, we should drop adding them until a time someone really needs these. Thanks, Sekhar

Re: [PATCH] ARM: davinci: da850-evm: fix read access to SPI flash

2017-01-18 Thread Sekhar Nori
On Wednesday 18 January 2017 05:55 AM, Kevin Hilman wrote: > Fabien Parent writes: > >> Read access to the SPI flash are broken on da850-evm, i.e. the data >> read is not what is actually programmed on the flash. >> According to the datasheet for the M25P64 part present on the da850-evm, >> if th

Re: [PATCH v2 1/2] ARM: davinci: Allocate extra interrupts

2017-01-18 Thread Sekhar Nori
On Saturday 14 January 2017 01:30 AM, David Lechner wrote: > This allocates extra interrupts for mach-davinci. These extra interrupts > are need for things like IIO triggers. I am not really familiar with IIO triggers. Can you give some more detail on what fails without this patch? Thanks, Sekhar

Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts

2017-01-13 Thread Sekhar Nori
On Friday 13 January 2017 02:02 AM, David Lechner wrote: > This adds a device tree definition file for LEGO MINDSTORMS EV3. > > What is working: > > * Pin muxing > * Pinconf > * GPIOs > * MicroSD card reader > * UART on input port 1 > * Buttons > * LEDs > * Poweroff/reset > * Flash memory > * EEP

Re: [PATCH v2 3/5] ARM: davinci_all_defconfig: enable iio and ADS7950

2017-01-13 Thread Sekhar Nori
On Wednesday 11 January 2017 01:53 PM, Sekhar Nori wrote: > On Tuesday 10 January 2017 09:13 PM, David Lechner wrote: >> On 01/09/2017 06:29 AM, Sekhar Nori wrote: >>> On Friday 06 January 2017 10:03 AM, David Lechner wrote: >>>> This enables the iio subsystem and

Re: [PATCH 00/10] ARM: da850-lcdk: add SATA support

2017-01-13 Thread Sekhar Nori
Thanks! For the non-platform patches which I wont be queuing: Tested-by: Sekhar Nori I will take a look at the series closely next week. Thanks, Sekhar

Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850

2017-01-16 Thread Sekhar Nori
On Monday 16 January 2017 03:43 PM, Bartosz Golaszewski wrote: > 2017-01-13 20:25 GMT+01:00 David Lechner : >> On 01/13/2017 06:37 AM, Bartosz Golaszewski wrote: >>> >>> Add DT bindings for the TI DA850 AHCI SATA controller. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> .../devicetree/bi

Re: [PATCH v7 03/14] ARM: davinci: add a clock lookup entry for the SATA clock

2017-01-31 Thread Sekhar Nori
On Monday 30 January 2017 03:32 PM, Bartosz Golaszewski wrote: > This entry is needed for the ahci driver to get a functional clock. > > Signed-off-by: Bartosz Golaszewski > --- This patch is not adding a clock lookup entry, but AUXDATA. I fixed the subject line to: ARM: davinci: da8xx-dt: add

Re: [PATCH v7 11/14] sata: ahci-da850: un-hardcode the MPY bits

2017-01-31 Thread Sekhar Nori
On Monday 30 January 2017 03:32 PM, Bartosz Golaszewski wrote: > + /* > + * The second clock used by ahci-da850 is the external REFCLK. If we > + * didn't get it from ahci_platform_get_resources(), let's try to > + * specify the con_id in clk_get(). > + */ > + if (!hpri

Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock

2017-01-26 Thread Sekhar Nori
On Thursday 26 January 2017 10:26 PM, Grygorii Strashko wrote: > > > On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote: >> The ahci-da850 SATA driver is now capable of retrieving clocks by >> con_id. Add the connection id for the sysclk2-derived SATA clock. >> >> Signed-off-by: Bartosz Golaszewsk

Re: [PATCH v2 0/2] ARM: davinvi: da850 add ohci DT nodes

2017-01-07 Thread Sekhar Nori
On Friday 06 January 2017 03:10 PM, Axel Haslam wrote: > This adds the DT node for the ohci controller and > enables it for the omapl138-lckd platform. Applied to v4.11/dt Thanks, Sekhar

Re: [PATCH v2 2/5] ARM: davinci_all_defconfig: Enable PWM modules

2017-01-09 Thread Sekhar Nori
On Friday 06 January 2017 10:03 AM, David Lechner wrote: > This enables PWM and the TI ECAP and EHRWPM modules. These are used on LEGO > MINDSTORMS EV3. Here too. Please resend with sign-off. Thanks, Sekhar

Re: [PATCH v2 1/5] ARM: davinci_all_defconfig: enable DA8xx pinconf

2017-01-09 Thread Sekhar Nori
On Friday 06 January 2017 10:03 AM, David Lechner wrote: > This enables the DA8xx pinconf driver by default. It is needed by LEGO > MINDSTORMS EV3. Missing your sign-off. I cannot apply that myself. Please resend. Thanks, Sekhar

Re: [PATCH v2 3/5] ARM: davinci_all_defconfig: enable iio and ADS7950

2017-01-09 Thread Sekhar Nori
On Friday 06 January 2017 10:03 AM, David Lechner wrote: > This enables the iio subsystem and the TI ADS7950 driver. This is used by > LEGO MINDSTORMS EV3, which has an ADS7957 chip. Can you add your sign-off? > --- > > The CONFIG_TI_ADS7950 driver is currently in iio/testing, so some coordinati

Re: [RESEND 3/3] ARM: davinci_all_defconfig: enable iio and ADS7950

2017-01-10 Thread Sekhar Nori
On Monday 09 January 2017 09:41 PM, David Lechner wrote: > This enables the iio subsystem and the TI ADS7950 driver. This is used by > LEGO MINDSTORMS EV3, which has an ADS7957 chip. > > Signed-off-by: David Lechner > --- > arch/arm/configs/davinci_all_defconfig | 7 +++ > 1 file changed, 7

Re: [RESEND 1/3] ARM: davinci_all_defconfig: enable DA8xx pinconf

2017-01-10 Thread Sekhar Nori
On Monday 09 January 2017 09:41 PM, David Lechner wrote: > This enables the DA8xx pinconf driver by default. It is needed by LEGO > MINDSTORMS EV3. > > Signed-off-by: David Lechner Applied to v4.11/defconfig Thanks, Sekhar

Re: [RESEND 2/3] ARM: davinci_all_defconfig: Enable PWM modules

2017-01-10 Thread Sekhar Nori
On Monday 09 January 2017 09:41 PM, David Lechner wrote: > This enables PWM and the TI ECAP and EHRWPM modules. These are used on LEGO > MINDSTORMS EV3. > > Signed-off-by: David Lechner Applied to v4.11/defconfig Thanks, Sekhar

Re: [PATCH 1/2] memory: aemif: allow passing device lookup table as platform data

2017-01-10 Thread Sekhar Nori
sz Golaszewski I did not really see any precedent to passing of_dev_auxdata as platform data, but the idea looks fine to me, so: Acked-by: Sekhar Nori Thanks, Sekhar

Re: [PATCH v4 01/14] devicetree: bindings: add bindings for ahci-da850

2017-01-20 Thread Sekhar Nori
On Thursday 19 January 2017 06:59 PM, Bartosz Golaszewski wrote: > Add DT bindings for the TI DA850 AHCI SATA controller. > > Signed-off-by: Bartosz Golaszewski > --- > Documentation/devicetree/bindings/ata/ahci-da850.txt | 15 +++ > 1 file changed, 15 insertions(+) > create mode 10

Re: [PATCH v4 06/14] ARM: davinci: da850: model the SATA refclk

2017-01-20 Thread Sekhar Nori
On Thursday 19 January 2017 06:59 PM, Bartosz Golaszewski wrote: > Register a dummy clock modelling the external SATA oscillator for I had asked about this earlier. I dont think calling it a dummy clock is right. Can you fix it or respond to my earlier mail with any objections? > da850 (both DT a

Re: [PATCH v2 1/2] ARM: davinci: Allocate extra interrupts

2017-01-20 Thread Sekhar Nori
On Wednesday 18 January 2017 10:27 PM, David Lechner wrote: > On 01/18/2017 03:50 AM, Sekhar Nori wrote: >> On Saturday 14 January 2017 01:30 AM, David Lechner wrote: >>> This allocates extra interrupts for mach-davinci. These extra interrupts >>> are need for things li

Re: [PATCH v2 2/2] ARM: davinci_all_defconfig: enable iio

2017-01-20 Thread Sekhar Nori
On Saturday 14 January 2017 01:30 AM, David Lechner wrote: > This enables the iio subsystem. This will be used by LEGO MINDSTORMS EV3, > which has an ADS7957 chip. > > Signed-off-by: David Lechner Applied. Thanks, Sekhar

Re: [PATCH v5 01/14] devicetree: bindings: add bindings for ahci-da850

2017-01-20 Thread Sekhar Nori
Hi Rob, On Friday 20 January 2017 04:51 PM, Bartosz Golaszewski wrote: > Add DT bindings for the TI DA850 AHCI SATA controller. > > Signed-off-by: Bartosz Golaszewski Could you ack this binding? Thanks, Sekhar > --- > Documentation/devicetree/bindings/ata/ahci-da850.txt | 15 +++

Re: [PATCH v4 0/4] Support for LEGO MINDSTORMS EV3

2017-01-20 Thread Sekhar Nori
On Saturday 14 January 2017 12:33 AM, David Lechner wrote: > This patch series adds support for LEGO MINDSTORMS EV3. This is a TI AM1808 > based board. Series applied with Rob's acks. Thanks, Sekhar

Re: [PATCH v5 00/14] ARM: da850-lcdk: add SATA support

2017-01-20 Thread Sekhar Nori
Hi Tejun, On Friday 20 January 2017 06:58 PM, Tejun Heo wrote: > On Fri, Jan 20, 2017 at 12:21:51PM +0100, Bartosz Golaszewski wrote: >> This series contains all the changes necessary to make SATA work on >> the da850-lcdk board. >> >> The first patch adds DT bindings for the ahci-da850 driver. >>

Re: [PATCH v5 00/14] ARM: da850-lcdk: add SATA support

2017-01-20 Thread Sekhar Nori
On Friday 20 January 2017 07:32 PM, Bartosz Golaszewski wrote: > 2017-01-20 14:56 GMT+01:00 Sekhar Nori : >> Hi Tejun, >> >> On Friday 20 January 2017 06:58 PM, Tejun Heo wrote: >>> On Fri, Jan 20, 2017 at 12:21:51PM +0100, Bartosz Golaszewski wrote: >>>

Re: [PATCH RESEND 2/2] ARM: da850: add the nand dev_id to the clock lookup table

2017-01-20 Thread Sekhar Nori
On Friday 13 January 2017 03:30 PM, Bartosz Golaszewski wrote: > The aemif driver can now access struct of_dev_auxdata (using platform > data). > > Add the device id to the clock lookup table for the nand clock and > create a separate lookup table for aemif subnodes. > > Signed-off-by: Bartosz Go

Re: [PATCH RESEND 2/2] ARM: da850: add the nand dev_id to the clock lookup table

2017-01-23 Thread Sekhar Nori
On Friday 20 January 2017 07:16 PM, Sekhar Nori wrote: > On Friday 13 January 2017 03:30 PM, Bartosz Golaszewski wrote: >> The aemif driver can now access struct of_dev_auxdata (using platform >> data). >> >> Add the device id to the clock lookup table for the nand clo

Re: [PATCH RESEND 2/2] ARM: da850: add the nand dev_id to the clock lookup table

2017-01-23 Thread Sekhar Nori
On Monday 23 January 2017 09:02 PM, Bartosz Golaszewski wrote: > 2017-01-23 16:17 GMT+01:00 Sekhar Nori : >> On Friday 20 January 2017 07:16 PM, Sekhar Nori wrote: >>> On Friday 13 January 2017 03:30 PM, Bartosz Golaszewski wrote: >>>> The aemif driver can now acces

Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock

2017-01-27 Thread Sekhar Nori
On Friday 27 January 2017 03:25 PM, Bartosz Golaszewski wrote: > Hi Sekhar, > > I'll wait with sending v7 until we get an ack from Rob for the > ahci-da850 bindings, so that we don't fall to the bottom of the review > queue again. Yes, makes sense. Regards, Sekhar

Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem

2016-07-18 Thread Sekhar Nori
On Friday 15 July 2016 08:45 PM, Kevin Hilman wrote: > Arnd Bergmann writes: > >> On Wednesday, July 13, 2016 12:59:23 PM CEST Bartlomiej Zolnierkiewicz wrote: >>> >>> On Friday, July 08, 2016 10:23:48 PM Arnd Bergmann wrote: On Friday, July 8, 2016 5:24:41 PM CEST Bartlomiej Zolnierkiewicz

<    4   5   6   7   8   9   10   11   12   13   >