Re: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion

2013-03-28 Thread Sebastien Royen
buf[3]; > > + z = buf[5]; > > + /* add 4 LSB */ > > + x = (x << 4) | (buf[0] & 0xf); > > + y = (y << 4) | (buf[2] & 0xf); > > + z = (z << 4) | (buf[4] & 0xf); > > Should we just say: > > x = ((int)(s8

[PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion

2013-03-28 Thread Sebastien Royen
From: seb Event value is wrong. Should be in range -2048 to 2047, but is in range 0 to 4095. Use s8 to int conversion and remove 0xfff mask. Signed-off-by: Sebastien Royen --- drivers/input/misc/mma8450.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers