Re: [ 061/128] 8250: blacklist Winbond CIR port

2013-02-03 Thread Sean Young
On Sun, Feb 03, 2013 at 03:47:45PM +0100, Ben Hutchings wrote: > 3.2-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Sean Young > > commit 65ecc9c02dbad033a73a32916d17c107c5b25031 upstream. > > The legacy se

Re: Stable kernel 3.8.4/3.9-rc3 breaks PNP serial port

2013-04-02 Thread Sean Young
On Tue, Apr 02, 2013 at 09:23:36AM -0700, Greg Kroah-Hartman wrote: > On Tue, Apr 02, 2013 at 11:53:44AM -0400, Josh Boyer wrote: > > Hi All, > > > > We've had a report [1] that the 3.8.4 stable kernel makes a PNP serial > > port stop working. After testing 3.8.3, the reporter narrowed it down >

Re: Stable kernel 3.8.4/3.9-rc3 breaks PNP serial port

2013-04-02 Thread Sean Young
On Tue, Apr 02, 2013 at 05:34:35PM +0100, Sean Young wrote: > On Tue, Apr 02, 2013 at 09:23:36AM -0700, Greg Kroah-Hartman wrote: > > On Tue, Apr 02, 2013 at 11:53:44AM -0400, Josh Boyer wrote: > > > Hi All, > > > > > > We've had a report [1] that t

[PATCH] tty/8250_pnp: serial port detection regression since v3.7

2013-02-22 Thread Sean Young
(8250_pnp: do pnp probe before legacy probe) we get a bogus ttyS0, which prevents the legacy probe from detecting it. Reported-by: Vincent Deffontaines Tested-by: Vincent Deffontaines Signed-off-by: Sean Young Cc: sta...@vger.kernel.org --- drivers/tty/serial/8250/8250_pnp.c | 12

Re: [RFC PATCH] [media] rc: filter out not allowed protocols when decoding

2012-09-03 Thread Sean Young
On Sat, Sep 01, 2012 at 09:57:09AM +0800, Du, Changbin wrote: > From: "Du, Changbin" > > Each rc-raw device has a property "allowed_protos" stored in structure > ir_raw_event_ctrl. But it didn't work because all decoders would be > called when decoding. This path makes only allowed protocol decod

Re: [RFC PATCH] [media] rc: filter out not allowed protocols when decoding

2012-09-04 Thread Sean Young
On Tue, Sep 04, 2012 at 11:06:07AM +0800, Changbin Du wrote: > > > mutex_lock(&ir_raw_handler_lock); > > > - list_for_each_entry(handler, &ir_raw_handler_list, list) > > > - handler->decode(raw->dev, ev); > > > + list_for_each_entry(handler,

Re: [PATCH RFC] media: lirc: Allow lirc dev to talk to rc device

2013-07-12 Thread Sean Young
On Fri, Jul 12, 2013 at 09:55:28AM +0100, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > > The use case is simple, if any rc device has allowed protocols = > RC_TYPE_LIRC and map_name = RC_MAP_LIRC set, the driver open will be never > called. The reason for this is, all of the key maps

Re: [PATCH v1 1/2] media: rc: Add user count to rc dev.

2013-07-19 Thread Sean Young
On Fri, Jul 19, 2013 at 09:39:27AM +0100, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > > This patch adds user count to rc_dev structure, the reason to add this > new member is to allow other code like lirc to open rc device directly. > In the existing code, rc device is only opened by

Re: [PATCH] tty/8250_pnp: serial port detection regression since v3.7

2013-03-04 Thread Sean Young
Greg, On Fri, Feb 22, 2013 at 04:27:19PM +, Sean Young wrote: > The InsydeH2O BIOS (version dated 09/12/2011) has the following in > its pnp resouces for its serial ports: > > $ cat /sys/bus/pnp/devices/00:0b/resources > state = active > io disabled > irq disabled >

[PATCH] Revert "tty/8250_pnp: serial port detection regression since v3.7"

2013-04-07 Thread Sean Young
ter fix. https://bugzilla.redhat.com/show_bug.cgi?id=928246 Signed-off-by: Sean Young Cc: stable --- drivers/tty/serial/8250/8250_pnp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c index b

Re: [PATCH 2/5] MEDIA: ttusbir, fix double free

2013-04-09 Thread Sean Young
ree. > > Instead, set rc to NULL resulting in rc_free_device being a noop. > > Signed-off-by: Jiri Slaby > Cc: Sean Young > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > --- > drivers/media/rc/ttusbir.c | 1 + > 1 file changed, 1 insertion(+) > &

Re: 8250.nr_uarts broken in 3.7

2013-03-10 Thread Sean Young
On Sat, Mar 09, 2013 at 03:14:18PM +0100, Jiri Slaby wrote: > This is so disgusting that I will do the following: > * ack your patch after you change the above (if that works) > * rename 8250.c to 8250_core.c > * change 8250_core.ko back to 8250.ko (ie. bring back the old module name) > * thus swit

[LOCKDEP] Possible recursive locking detected

2007-01-26 Thread Sean Young
.config: http://www.msxnet.org/config-2.6.20-rc5 = [ INFO: possible recursive locking detected ] 2.6.20-rc5 #1 - swapper/0 is trying to acquire lock: (&q->lock){++..}, at: [] __wake_up+0x18/0x43 but task is a

[PATCH][STABLE 2.6.19] Fix oops in PhidgetServo

2006-12-06 Thread Sean Young
From: Sean Young <[EMAIL PROTECTED]> The PhidgetServo causes an Oops when any of its sysfs attributes are read or written too, making the driver useless. Signed-off-by: Sean Young <[EMAIL PROTECTED]> --- Please consider this for inclusion in the next -stable, this issue is aff

Re: [BUG 2.6.21-rc2] divide error: 0000

2007-03-02 Thread Sean Young
On Fri, Mar 02, 2007 at 10:19:17AM +0100, Thomas Gleixner wrote: > On Fri, 2007-03-02 at 07:11 +0100, Willy Tarreau wrote: > > > Call Trace: > > > [] posix_cpu_clock_get+0x47/0xdc > > > [] sys_clock_gettime+0x80/0x82 > > > [] syscall_call+0x7/0xb > > > [] svc_ioctl+0xc2/0x261 > > > ===

Re: [RFC 1/7] [media] rc-main: assign driver type during allocation

2016-07-19 Thread Sean Young
at there lots of issues that checkpatch.pl would pick in these series. > > Suggested-by: Sean Young > Signed-off-by: Andi Shyti > --- > drivers/media/rc/rc-main.c | 4 +++- > include/media/rc-core.h| 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff -

Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters

2016-07-19 Thread Sean Young
ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young > Signed-off-by: Andi Shyti > --- > drivers/media/rc/rc-main.c | 35 +++ > include/

Re: [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer for raw transmitters

2016-07-19 Thread Sean Young
On Wed, Jul 20, 2016 at 12:56:56AM +0900, Andi Shyti wrote: > Raw transmitters receive the data which need to be sent to > receivers from userspace as stream of bits, they don't require > any handling from the lirc framework. No drivers of type RC_DRIVER_IR_RAW_TX should handle tx just like any ot

Re: [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-07-19 Thread Sean Young
On Wed, Jul 20, 2016 at 12:56:58AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > provided by userspace through a character

Re: [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-07-21 Thread Sean Young
Hi Andi, On Thu, Jul 21, 2016 at 10:09:26AM +0900, Andi Shyti wrote: > > > + ret = regulator_enable(idata->regulator); > > > + if (ret) > > > + return ret; > > > + > > > + mutex_lock(&idata->mutex); > > > + idata->xfer.len = n; > > > + idata->xfer.tx_buf = buffer; > > > + mutex_unlock(&ida

Re: [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer for raw transmitters

2016-07-21 Thread Sean Young
Hi Andi, On Thu, Jul 21, 2016 at 09:48:12AM +0900, Andi Shyti wrote: > > > Raw transmitters receive the data which need to be sent to > > > receivers from userspace as stream of bits, they don't require > > > any handling from the lirc framework. > > > > No drivers of type RC_DRIVER_IR_RAW_TX sho

Re: [PATCH v2 1/7] [media] rc-main: assign driver type during allocation

2016-09-01 Thread Sean Young
, it will be > set as RC_DRIVER_SCANCODE which was the default '0' value. > > Suggested-by: Sean Young > Signed-off-by: Andi Shyti > --- ... > diff --git a/drivers/media/pci/cx88/cx88-input.c > b/drivers/media/pci/cx88/cx88-input.c > index 3f1342c..e52bf69 10

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-01 Thread Sean Young
Thanks Andi, this is looking great! On Fri, Sep 02, 2016 at 02:16:29AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > prov

Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters

2016-09-01 Thread Sean Young
ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young > Signed-off-by: Andi Shyti > --- > drivers/media/rc/rc-main.c | 39 +++ > in

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-09-02 Thread Sean Young
On Fri, Sep 02, 2016 at 02:16:27AM +0900, Andi Shyti wrote: > Transmitters do not need to wait until the data has been sent > (and of course received). Return before waiting. > > Signed-off-by: Andi Shyti > --- > drivers/media/rc/ir-lirc-codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-02 Thread Sean Young
On Fri, Sep 02, 2016 at 02:27:08PM +0900, Andi Shyti wrote: > > Thanks Andi, this is looking great! > > Thanks Sean! With your reviews the whole thing looks much better > now :) > > I agree with all your points here, I will fix them. Can I add > your reviewd-by? Yes, please add it to this patch.

Re: [PATCH] media: av7110: switch to useing timer_setup()

2017-10-31 Thread Sean Young
On Tue, Oct 24, 2017 at 05:40:05PM -0700, Dmitry Torokhov wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Also stop poking into input core

[PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young --- drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 54 ++--- 2 files changed, 21 insertions

Re: [PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Hi Dmitry, On Tue, Oct 31, 2017 at 11:22:36AM -0700, Dmitry Torokhov wrote: > Hi Sean, > > On Tue, Oct 31, 2017 at 05:45:58PM +0000, Sean Young wrote: > > Leave the autorepeat handling up to the input layer, and move > > to the new timer API. > > > > Compile te

[PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young --- v2: - fixes and improvements from Dmitry Torokhov drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 56

Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

2017-10-18 Thread Sean Young
On Wed, Oct 18, 2017 at 06:54:56AM -0400, Jiancheng Xue wrote: > From: Younian Wang > > This is a NEC protocol type remote controller distributed with > hisilicon TV demo boards. > > Signed-off-by: Younian Wang > Signed-off-by: Jiancheng Xue > --- > drivers/media/rc/keymaps/Makefile

Re: [PATCH v3 0/6] arm: sunxi: IR support for A83T

2018-01-05 Thread Sean Young
On Tue, Dec 19, 2017 at 09:07:41AM +0100, Philipp Rossak wrote: > This patch series adds support for the sunxi A83T ir module and enhances > the sunxi-ir driver. Right now the base clock frequency for the ir driver > is a hard coded define and is set to 8 MHz. > This works for the most common ir r

Re: [PATCH v3 1/6] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

2018-01-05 Thread Sean Young
value could be > set if the attached ir receiver needs a different base clock frequency, > than the default 8 MHz. > > Signed-off-by: Philipp Rossak Acked-by: Sean Young Sean > --- > drivers/media/rc/sunxi-cir.c | 19 +++ > 1 file changed, 11 insertions(

Re: [PATCH] media: dvb: fix a missing-check bug

2018-11-27 Thread Sean Young
Hi Wenwen, On Mon, Oct 29, 2018 at 01:46:04PM -0500, Wenwen Wang wrote: > Hello, > > Can anyone confirm this bug? Thanks! > > Wenwen > > On Fri, Oct 19, 2018 at 9:12 AM Wenwen Wang wrote: > > > > In dvb_audio_write(), the first byte of the user-space buffer 'buf' is > > firstly copied and chec

[PATCH] MIPS: Remove superfluous check for __linux__

2018-11-16 Thread Sean Young
commit/?id=dd3ff81f58c4e1e6f33765dc61ad33c48ae6bb07 This check might otherwise be useful to stop users from using a non-linux compiler, but if you're doing that you are going to have a lot more trouble anyway. Signed-off-by: Sean Young --- arch/mips/include/uapi/asm/sgidefs.h | 8 1 file changed, 8 deletions(-) di

Re: [PATCH] [media] dib7000p: Remove dead code

2018-12-04 Thread Sean Young
On Tue, Dec 04, 2018 at 09:57:14AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 4 Dec 2018 10:26:40 + > Sean Young escreveu: > > > On Mon, Sep 17, 2018 at 07:39:36PM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 17 Sep 2018 10:58:32 -0700 > >

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-26 Thread Sean Young
On Fri, May 25, 2018 at 01:45:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 18, 2018 at 03:07:29PM +0100, Sean Young wrote: > > Add support for BPF_PROG_LIRC_MODE2. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report &g

[PATCH v5 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-27 Thread Sean Young
This makes is it possible for bpf prog detach to return -ENOENT. Acked-by: Yonghong Song Signed-off-by: Sean Young --- kernel/bpf/core.c| 11 +-- kernel/trace/bpf_trace.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/core.c b/kernel/bpf

[PATCH v5 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-27 Thread Sean Young
This is simple test over rc-loopback. Acked-by: Yonghong Song Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 53 - tools/include/uapi/linux/lirc.h | 217 ++ tools/lib/bpf

[PATCH v5 0/3] IR decoding using BPF

2018-05-27 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

[PATCH v5 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-27 Thread Sean Young
device. Acked-by: Yonghong Song Signed-off-by: Sean Young --- drivers/media/rc/Kconfig| 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-lirc.c | 313 drivers/media/rc/lirc_dev.c | 30 +++ drivers/media/rc/rc-core-priv.h | 21

[PATCH v1 2/4] media: bpf: allow raw IR decoder bpf programs to be used

2018-05-14 Thread Sean Young
This implements attaching, detaching, querying and execution. The target fd has to be the /dev/lircN device. Signed-off-by: Sean Young --- drivers/media/rc/ir-bpf-decoder.c | 191 ++ drivers/media/rc/lirc_dev.c | 30 + drivers/media/rc/rc-core-priv.h

[PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-14 Thread Sean Young
This implements the grundig-16 IR protocol. Signed-off-by: Sean Young --- samples/bpf/Makefile | 4 + samples/bpf/bpf_load.c| 9 +- samples/bpf/grundig_decoder_kern.c| 112 ++ samples/bpf/grundig_decoder_user.c

[PATCH v1 0/4] IR decoding using BPF

2018-05-14 Thread Sean Young
nderway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. Thanks, Sean

[PATCH v1 3/4] media: rc bpf: move ir_raw_event to uapi

2018-05-14 Thread Sean Young
The context provided to a BPF_PROG_RAWIR_DECODER is a struct ir_raw_event; ensure user space has a a definition. Signed-off-by: Sean Young --- include/media/rc-core.h| 19 +-- include/uapi/linux/bpf_rcdev.h | 24 2 files changed, 25 insertions

[PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Sean Young
Add support for BPF_PROG_IR_DECODER. This type of BPF program can call rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report that the last key should be repeated. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 8 +++ drivers/media/rc/Makefile | 1

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi Quentin, On Thu, May 17, 2018 at 01:10:56PM +0100, Quentin Monnet wrote: > 2018-05-16 22:04 UTC+0100 ~ Sean Young > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > &

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 Thread Sean Young
On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: > On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > > This is simple test over rc-loopback. > > > > Signed-off-by: Sean Young > > --- > > tools/bpf/bpftool/prog.c | 1 + &g

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi, Again thanks for a thoughtful review. This will definitely will improve the code. On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: > On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > >

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-18 Thread Sean Young
On Fri, May 18, 2018 at 11:13:07AM +0100, Quentin Monnet wrote: > 2018-05-17 22:01 UTC+0100 ~ Sean Young > > On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: > >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > >>> This is simple test over rc-loopback. &

[PATCH v4 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-18 Thread Sean Young
This makes is it possible for bpf prog detach to return -ENOENT. Signed-off-by: Sean Young --- kernel/bpf/core.c| 11 +-- kernel/trace/bpf_trace.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 2194c6a9df42

[PATCH v4 0/3] IR decoding using BPF

2018-05-18 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

[PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-18 Thread Sean Young
device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig| 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-lirc.c | 308 drivers/media/rc/lirc_dev.c | 30 drivers/media/rc/rc-core-priv.h | 22 +++ drivers/media/rc/rc

[PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 53 - tools/include/uapi/linux/lirc.h | 217 ++ tools/lib/bpf/libbpf.c

Re: [PATCH v4 0/3] IR decoding using BPF

2018-05-23 Thread Sean Young
On Wed, May 23, 2018 at 02:21:27PM +0200, Daniel Borkmann wrote: > On 05/18/2018 04:07 PM, Sean Young wrote: > > The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most > > widely used IR protocols, but there are many protocols which are not > > supported

Re: [PATCH v5 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-06-05 Thread Sean Young
On Mon, Jun 04, 2018 at 07:47:30PM +0200, Matthias Reichl wrote: > Hi Sean, > > I finally found the time to test your patch series and noticed > 2 issues - comments are inline > > On Sun, May 27, 2018 at 12:24:09PM +0100, Sean Young wrote: > > diff --git a/drivers/me

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 09:48:05PM -0700, Y Song wrote: > On Mon, May 14, 2018 at 2:10 PM, Sean Young wrote: > > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > > that t

Re: [PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 10:34:57PM -0700, Y Song wrote: > On Mon, May 14, 2018 at 2:11 PM, Sean Young wrote: > > This implements the grundig-16 IR protocol. > > > > Signed-off-by: Sean Young > > --- > > samples/bpf/Makefile |

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 04:27:19PM -0700, Randy Dunlap wrote: > On 05/14/2018 02:10 PM, Sean Young wrote: > > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call > > Kconfig file below uses IR_BPF_DECODER instead of the symbol name above. > > and then

[PATCH v2 0/2] IR decoding using BPF

2018-05-15 Thread Sean Young
nderway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. Thanks, Sean

[PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-15 Thread Sean Young
device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 10 + drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-rawir-event.c | 322 + drivers/media/rc/lirc_dev.c| 28 +++ drivers/media/rc/rc-core-priv.h| 19 ++ drivers

[PATCH v2 2/2] bpf: add selftest for rawir_event type program

2018-05-15 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 55 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Makefile | 7

Re: [PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 Thread Sean Young
On Tue, May 15, 2018 at 07:50:19PM +0100, Sean Young wrote: > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attach

[PATCH v3 0/2] IR decoding using BPF

2018-05-16 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

[PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-16 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 57 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Makefile | 8

[PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 Thread Sean Young
device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-rawir-event.c | 363 + drivers/media/rc/lirc_dev.c| 24 ++ drivers/media/rc/rc-core-priv.h| 24 ++ drivers

Re: [PATCH] selftests: ir: fix warning: ‘%s’ directive output may be truncated

2019-02-04 Thread Sean Young
n __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, > ^~~~ > __bos (__s), __fmt, __va_arg_pack ()); > ~ > > Signed-off-by: Shuah Khan Thank you for catching and fixing

Re: [PATCH 1/2] media: dvb-usb: Fix memory leak at error in dvb_usb_device_init()

2021-01-31 Thread Sean Young
On Wed, Jan 20, 2021 at 11:20:56AM +0100, Takashi Iwai wrote: > dvb_usb_device_init() allocates a dvb_usb_device object, but it > doesn't release it even when returning an error. The callers don't > seem caring it as well, hence those memories are leaked. > > This patch assures releasing the memo

Re: [PATCH 2/2] media: dvb-usb: Fix use-after-free access

2021-01-31 Thread Sean Young
Hi Takashi, On Fri, Jan 22, 2021 at 04:47:44PM +0100, Robert Foss wrote: > Hey Takashi, > > This patch is generating a checkpatch warning, but I think it is > spurious and can be ignored. The checkpatch warning isn't superious and should really be corrected. > > Other than that, this looks goo

Re: KASAN: use-after-free Read in rc_dev_uevent

2020-08-07 Thread Sean Young
On Fri, Aug 07, 2020 at 12:26:29AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:7b4ea945 Revert "x86/mm/64: Do not sync vmalloc/ioremap ma.. > git tree: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > console outp

Re: KASAN: use-after-free Read in rc_dev_uevent

2020-08-08 Thread Sean Young
On Fri, Aug 07, 2020 at 09:55:40PM +0800, Hillf Danton wrote: > > On Fri, 7 Aug 2020 10:15:04 +0100 Sean Young wrote: > > On Fri, Aug 07, 2020 at 12:26:29AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > >

Re: KASAN: use-after-free Read in rc_dev_uevent

2020-08-08 Thread Sean Young
Hi Eze, On Fri, Aug 07, 2020 at 08:45:12PM -0300, Ezequiel Garcia wrote: > On Fri, 7 Aug 2020 at 06:15, Sean Young wrote: > > > > On Fri, Aug 07, 2020 at 12:26:29AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > &

Re: KASAN: use-after-free Read in rc_dev_uevent

2020-08-10 Thread Sean Young
On Sun, Aug 09, 2020 at 11:03:28AM -0300, Ezequiel Garcia wrote: > On Sat, 8 Aug 2020 at 06:25, Sean Young wrote: > > On Fri, Aug 07, 2020 at 08:45:12PM -0300, Ezequiel Garcia wrote: > > > On Fri, 7 Aug 2020 at 06:15, Sean Young wrote: > > > > > > > >

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-07 Thread Sean Young
Hello Uwe, Thank you for taking the time to explain your thinking. On Mon, Dec 07, 2020 at 09:16:28AM +0100, Uwe Kleine-König wrote: > On Sun, Dec 06, 2020 at 02:19:41PM +0000, Sean Young wrote: > > On Sat, Dec 05, 2020 at 08:25:10PM +0100, Uwe Kleine-König wrote: > > > On Sa

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-07 Thread Sean Young
Hi Uwe, On Mon, Dec 07, 2020 at 02:52:09PM +0100, Uwe Kleine-König wrote: > On Mon, Dec 07, 2020 at 09:43:20AM +0000, Sean Young wrote: > > On Mon, Dec 07, 2020 at 09:16:28AM +0100, Uwe Kleine-König wrote: > > > On Sun, Dec 06, 2020 at 02:19:41PM +, Sean Young wrote: >

Re: [PATCH] Fix shift-out-of-bound in mceusb_process_ir_data

2021-01-13 Thread Sean Young
On Wed, Jan 13, 2021 at 07:11:22PM +0800, Dongliang Mu wrote: > The missing check of ir->buf_in[i+1] can lead to an shift-out-of-bound > in mceusb_handle_command or mceusb_dev_printdata. This patch adds a > check to limit its value lower than 16. The concrete report of UBSAN is > as follows. > > U

Re: [PATCH 1/4] media: sunxi-cir: Clean up dead register writes

2021-01-13 Thread Sean Young
On Tue, Jan 12, 2021 at 10:51:29PM -0600, Samuel Holland wrote: > The register writes during driver removal occur after the device is > already put back in reset, so they never had any effect. > > Signed-off-by: Samuel Holland > --- > drivers/media/rc/sunxi-cir.c | 10 -- > 1 file change

Re: [PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-13 Thread Sean Young
On Tue, Jan 12, 2021 at 10:51:31PM -0600, Samuel Holland wrote: > In preparation for adding suspend/resume hooks, factor out the hardware > initialization from the driver probe/remove functions. > > The timeout programmed during init is taken from the `struct rc_dev` so > it is maintained across a

Re: [PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-13 Thread Sean Young
Hi Samuel, On Wed, Jan 13, 2021 at 09:00:20AM -0600, Samuel Holland wrote: > On 1/13/21 8:36 AM, Sean Young wrote: > > On Tue, Jan 12, 2021 at 10:51:31PM -0600, Samuel Holland wrote: > >> In preparation for adding suspend/resume hooks, factor out the hardware > >> ini

Re: [PATCH v2 0/4] media: sunxi-cir: Cleanup and power management

2021-01-18 Thread Sean Young
On Mon, Jan 18, 2021 at 12:00:44AM -0600, Samuel Holland wrote: > This series cleans up some dead code in the sunxi-cir driver and adds > system power management hooks. > > --- > Changes from v1: > - Unregister the RC device first thing in sunxi_ir_remove() [3] > Thanks. I've tested it on my C

Re: [PATCH] media: rc: select CONFIG_BITREVERSE where needed

2021-01-19 Thread Sean Young
haup': > em28xx-input.c:(.text+0x1704): undefined reference to `byte_rev_table' > Acked-by: Sean Young Thanks Sean > Signed-off-by: Arnd Bergmann > --- > drivers/media/rc/Kconfig | 2 ++ > drivers/media/rc/img-ir/Kconfig | 1 + > drivers/media/usb/c

Re: [PATCH] media: rc: add keymap for KHAMSIN remote

2020-11-19 Thread Sean Young
On Thu, Nov 19, 2020 at 08:22:15AM +, Christian Hewitt wrote: > This remote ships with the Amlogic SML-5442TW IPTV/VOD Set-tob Box [0] > used by O2.cz. This keymap adds support for the default IR controls. s/Set-tob/Set-top/ Not sure what [0] refers to. > Signed-off-by: Christian Hewitt > -

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-04 Thread Sean Young
has been > introduced > to improve precision in case that the pwm controller is used by the pwm-ir-tx > driver. > I dont know how strong the requirement is to round down the period in > apply(), but I > can imagine that this may be a good reason to deviate from this rule.

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-04 Thread Sean Young
On Fri, Dec 04, 2020 at 08:44:17AM +, Sean Young wrote: > On Fri, Dec 04, 2020 at 12:42:15AM +0100, Lino Sanfilippo wrote: > > According to commit 11fc4edc4 rounding to the closest integer has been > > introduced > > to improve precision in case that the pwm controller is

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-04 Thread Sean Young
Hi, On Fri, Dec 04, 2020 at 12:13:26PM +0100, Uwe Kleine-König wrote: > On Fri, Dec 04, 2020 at 08:44:17AM +0000, Sean Young wrote: > > On Fri, Dec 04, 2020 at 12:42:15AM +0100, Lino Sanfilippo wrote: > > > > You're storing an unsigned long long (i.e. 64 bits) in an u3

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-04 Thread Sean Young
On Fri, Dec 04, 2020 at 12:21:15PM +0100, Uwe Kleine-König wrote: > Hello Lino, > > On Fri, Dec 04, 2020 at 12:42:15AM +0100, Lino Sanfilippo wrote: > > On 29.11.20 at 19:10, Uwe Kleine-König wrote: > > > You're storing an unsigned long long (i.e. 64 bits) in an u32. If > > > you are sure that thi

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-04 Thread Sean Young
Hi Uwe, On Fri, Dec 04, 2020 at 10:55:25PM +0100, Uwe Kleine-König wrote: > On Fri, Dec 04, 2020 at 11:40:36AM +0000, Sean Young wrote: > > On Fri, Dec 04, 2020 at 12:21:15PM +0100, Uwe Kleine-König wrote: > > > On Fri, Dec 04, 2020 at 12:42:15AM +0100, Lino Sanfilippo wrote: &

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-05 Thread Sean Young
Hello Uwe, On Sat, Dec 05, 2020 at 12:28:34AM +0100, Uwe Kleine-König wrote: > Hello Sean, > > On Fri, Dec 04, 2020 at 11:38:46AM +0000, Sean Young wrote: > > On Fri, Dec 04, 2020 at 12:13:26PM +0100, Uwe Kleine-König wrote: > > > On Fri, Dec 04, 2020 at 08:44:17AM

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-06 Thread Sean Young
Hello Uwe, On Sat, Dec 05, 2020 at 08:25:10PM +0100, Uwe Kleine-König wrote: > On Sat, Dec 05, 2020 at 05:34:44PM +0000, Sean Young wrote: > > What real life uses-cases are there for round down? If you want to round > > down, is there any need for round up? > > The scenario

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-25 Thread Sean Young
On Mon, Nov 23, 2020 at 07:58:06AM -0800, James Bottomley wrote: > On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > > wrote: > > > It's not about the risk of the changes it's about the cost of > > > implementing them. Even if you discou

Re: [PATCH 0/2] Improve LIRC documentation

2020-11-26 Thread Sean Young
ew. Thanks, For the series: Signed-off-by: Sean Young > > Mauro Carvalho Chehab (2): > media: docs: uAPI: rc: dual-license the docs with GPL v2 > media: rc: improve LIRC documentation > > Documentation/userspace-api/media/rc/keytable.c.rst | 2 +- > .../userspace-

[PATCH] btf: support ints larger than 128 bits

2020-12-17 Thread Sean Young
, which is under review. Link: https://clang.llvm.org/docs/LanguageExtensions.html#extended-integer-types Link: https://reviews.llvm.org/D93103 Signed-off-by: Sean Young --- Documentation/bpf/btf.rst | 4 ++-- include/uapi/linux/btf.h | 2 +- tools/bpf/bpftool/btf_dumper.c | 39

Re: [PATCH] btf: support ints larger than 128 bits

2020-12-18 Thread Sean Young
Hi Yonghong, Thank you for the detailed review. On Thu, Dec 17, 2020 at 06:12:11PM -0800, Yonghong Song wrote: > On 12/17/20 7:01 AM, Sean Young wrote: > > clang supports arbitrary length ints using the _ExtInt extension. This > > can be useful to hold very large values, e.g. 256

[PATCH v2] btf: support ints larger than 128 bits

2020-12-19 Thread Sean Young
review. Link: https://clang.llvm.org/docs/LanguageExtensions.html#extended-integer-types Link: https://reviews.llvm.org/D93103 Signed-off-by: Sean Young --- changes since v2: - added tests as suggested by Yonghong Song - added kernel pretty-printer Documentation/bpf/btf.rst

Re: [PATCH 1/2] media: rc: remove tango ir driver

2021-03-01 Thread Sean Young
Hi Arnd, On Thu, Jan 21, 2021 at 01:57:28PM +, Måns Rullgård wrote: > Arnd Bergmann writes: > > > From: Arnd Bergmann > > > > The tango platform is getting removed, so the driver is no > > longer needed. > > > > Cc: Marc Gonzalez > > Cc: Mans Rullgard > > Signed-off-by: Arnd Bergmann > >

Re: [PATCH 2/2] media: rc: remove zte zx ir driver

2021-03-01 Thread Sean Young
Hi Arnd, On Wed, Jan 20, 2021 at 03:25:42PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The zte zx platform is getting removed, so this driver is no > longer needed. I think the keymap should go too. drivers/media/rc/keymaps/rc-zx-irdec.c Any references to RC_MAP_ZX_IRDEC or rc-zx-i

Re: [PATCH 2/2] media: rc: remove zte zx ir driver

2021-03-02 Thread Sean Young
Hi Arnd, On Mon, Mar 01, 2021 at 10:25:22AM +, Sean Young wrote: > On Wed, Jan 20, 2021 at 03:25:42PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The zte zx platform is getting removed, so this driver is no > > longer needed. > >

Re: [PATCH v2] btf: support ints larger than 128 bits

2021-01-05 Thread Sean Young
On Wed, Dec 30, 2020 at 10:21:09AM -0800, Yonghong Song wrote: > On 12/19/20 8:36 AM, Sean Young wrote: > > clang supports arbitrary length ints using the _ExtInt extension. This > > can be useful to hold very large values, e.g. 256 bit or 512 bit types. > > > > Larger

[PATCH v3 3/4] bpftool: add support for ints larger than 128 bits

2021-01-05 Thread Sean Young
-types Link: https://reviews.llvm.org/D93103 Signed-off-by: Sean Young --- tools/bpf/bpftool/btf_dumper.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/tools/bpf/bpftool/btf_dumper.c b/tools/bpf/bpftool/btf_dumper.c index 0e9310727281..8b5318ec5c26 100644

[PATCH v3 4/4] bpf: add tests for ints larger than 128 bits

2021-01-05 Thread Sean Young
review. Link: https://clang.llvm.org/docs/LanguageExtensions.html#extended-integer-types Link: https://reviews.llvm.org/D93103 Signed-off-by: Sean Young --- tools/testing/selftests/bpf/Makefile | 3 +- tools/testing/selftests/bpf/prog_tests/btf.c | 3 +- .../selftests/bpf/progs

  1   2   3   >