s a memory leak).
i810_audio.c had a 'fixme' issue regarding ioremap fail that was
addressed as well.
Signed-off-by: Scott Thompson hushmail.com>
- ---
diff --git a/sound/oss/i810_audio.c b/sound/oss/i810_audio.c
index f5e31f1..407958c 100644
- --- a/sound/oss/i810_audio.c
+++ b
>please
>split this patch into at least one for sound/oss and one for
>sound/soc and
>sound/pci, thanks.
Will do, though wordwrapping issues will still be there. The part
of the function I was patching in i810_probe is nested so deep
birds have taken up residence.
----
ioremap / iounmap balancing in sound/pci tree
Signed-off-by: Scott Thompson hushmail.com>
---
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index ac007ce..871b09f 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -1319,6 +1319,13 @@ static
ioremap / iounmap balancing in sound/soc tree
Signed-off-by: Scott Thompson hushmail.com>
---
diff --git a/sound/soc/s3c24xx/s3c24xx-i2s.c
b/sound/soc/s3c24xx/s3c24xx-i2s.c
index 39f0246..cd89c41 100644
--- a/sound/soc/s3c24xx/s3c24xx-i2s.c
+++ b/sound/soc/s3c24xx/s3c24xx-i2s.c
@@ -385,6 +38
t. Thus, you don't need iounmap in each place.
>
>
>thanks,
>
>Takashi
Missed the callback on the audit, will repost this patch
(sound/pci) with just the unchecked returns...
---
Scott Thompson / [EMAIL PROTECTED]
--
f for
iounmap
this audit was only for files directly in drivers/net directory,
not the full tree.
I split patches up by file changed as each file had different
'owner' to ease accept/reject/revision process.
Signed-off-by: Scott Thompso
f for
iounmap
this audit was only for files directly in drivers/net directory,
not the full tree.
I split patches up by file changed as each file had different
'owner' to ease accept/reject/revision process.
Signed-off-by: Scott Thompso
f for
iounmap
this audit was only for files directly in drivers/net directory,
not the full tree.
I split patches up by file changed as each file had different
'owner' to ease accept/reject/revision process.
Signed-off-by: Scott Thompso
f for
iounmap
this audit was only for files directly in drivers/net directory,
not the full tree.
I split patches up by file changed as each file had different
'owner' to ease accept/reject/revision process.
Signed-off-by: Scott Thompso
patch against 2.6.23-rc2. this corrects two missing ioremap return
checks.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/ata/pata_ixp4xx_cf.c
b/drivers/ata/pata_ixp4xx_cf.c
index 4ca7fd6..eaebc4d 100644
--
patchset against 2.6.23-rc2.
corrects missing ioremap return checks and balancing on iounmap
calls in /drivers/atm...
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
in
patchset against 2.6.23-rc2 and this set is an audit of
/drivers/char/a*
through drivers/char .
this corrects missing ioremap return checks and balancing on
iounmap calls..
Signed-off-by: Scott Thompson hushmail.com>
--
diff --gi
patchset against 2.6.23-rc2 and this set is an audit of
/drivers/char/a*
through drivers/char .
this corrects missing ioremap return checks and balancing on
iounmap calls..
Signed-off-by: Scott Thompson hushmail.com>
--
diff --gi
patchset against 2.6.23-rc2 and this set is an audit of
/drivers/char/a*
through drivers/char .
this corrects missing ioremap return checks and balancing on
iounmap calls..
Signed-off-by: Scott Thompson hushmail.com>
--
diff --gi
patchset against 2.6.23-rc2 and this set is an audit of
/drivers/char/a*
through drivers/char .
this corrects missing ioremap return checks and balancing on
iounmap calls..
Signed-off-by: Scott Thompson hushmail.com>
--
diff --gi
patchset against 2.6.23-rc2 and this set is an audit of
/drivers/char/a*
through drivers/char .
this corrects missing ioremap return checks and balancing on
iounmap calls..
Signed-off-by: Scott Thompson hushmail.com>
--
diff --gi
up ioremap usage. And,
yes, I contributed *one more* wordwrap issue to the file, but when
in Rome...
---
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubscribe linux-kerne
he server side of
my mail client.
Will resubmit after resolving issue w/ mail provider...
-------
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
different mail client.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index 4ca7fd6..eaebc4d 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_c
hushmail users can be warned that
wordwrapping will be an issue on patch submission and another route
will be required.
-------
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubscribe lin
wordwrap issues, resending with different mail client.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 405ee5e..99e4ae4 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/
ries).
If there was a better list, or just to linux-kernel, please let me
know as tracking down the 'right' list for these kernel-janitor
kind of tasks can be tricky
---
Scott Thompson / [EMAIL PROTECTED]
---
AM");
Warning -- cleanup handler here may miss additional required cleanup as has
occurred on other
portions of ioremap audit. This patch had been submitted previously but
hushmail client caused
wordwrap issues, resending with different mail client.
lieve had incorrect/not ideal variable check on if for iounmap
this audit was only for files directly in drivers/net directory, not the full
tree.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/net/es3210.c b/dri
lieve had incorrect/not ideal variable check on if for iounmap
this audit was only for files directly in drivers/net directory, not the full
tree.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/net/myri_sbus.c b/dri
lieve had incorrect/not ideal variable check on if for iounmap
this audit was only for files directly in drivers/net directory, not the full
tree.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/net/ucc_geth.c b/dri
values
should be changed.
Let me know your preferences on these issues and I will include in
the next pass. Thanks for your comments and review...
---
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubsc
nitor faqs. Some groups seem more receptive
to these kind of fixes than others, though they may just be more
active maintainers.
I don't know if anyone does or doesn't roll these up collectively,
maybe the list can advise...
Patchset against 2.6.23-rc3. corrects missing ioremap return
checks, resending after making changes suggested
Signed-off-by: Scott Thompson hushmail.com>
diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_c
audit.
This patch had been submitted previously but hushmail client caused wordwrap
issues, resending
with different mail client.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/char/drm/drm_bufs.c b/drivers/char/
nup handler here may miss additional required cleanup as has
occurred on other
portions of ioremap audit.
This patch had been submitted previously but hushmail client caused wordwrap
issues, resending
with different mail client.
Signed-off-by: Scott Thompson hushmail.
audit.
This patch had been submitted previously but hushmail client caused wordwrap
issues, resending
with different mail client.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/
eas...
Warning -- cleanup handler here may miss additional required cleanup as has
occurred on other
portions of ioremap audit.
This patch had been submitted previously but hushmail client caused wordwrap
issues, resending
with different mail client.
Signed-off-by: Scott Thompson hushmail.
audit.
This patch had been submitted previously but hushmail client caused wordwrap
issues, resending
with different mail client.
Signed-off-by: Scott Thompson hushmail.com>
--
diff --git a/drivers/char/watchdog/iTCO_wdt.c b/drivers/c
ments for
the current state of the linux tree please advise.
---
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
t contain these
messages. When auditing (as I am for ioremap checking here) I am attempting
to keep changes "in the style of their surroundings". Otherwise it's massive
scope screep on these patches.
Signed-off-by
ic __devinit int ixp4xx_pata_probe(struct
platform_device *pdev)
Common advice appears to be to get smtp working on gmail, and I
thank the list for their suggestions. If I get one/two ways
working that are compliant for patch submittal w/o wordwrap (et al)
I'll start a 'howto' fr
patchset against 2.6.23-rc3.
moves the iomap/iounmap call to pci 'flavor'. this was a
recommendation from a previously submitted patch that handles
the unchecked iomap (or, now, pci_iomap) return code.
Signed-off-by: Scott Thompson hu
email clients + settings and will
post a link once a copy is up on the interweb.
---
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
r NAK is
fine
here and I won't resubmit w/ the hwbase var pulled out or the readl
-> ioread32 switchover.
---
Scott Thompson / [EMAIL PROTECTED]
---
-
To unsubscribe from this list: send the line "unsubscribe
40 matches
Mail list logo
