To avoid this, we add new BPF helpers that read the
correct values for some of the important task_struct
members such as pid, tgid, comm and flags which are
extensively used in BPF-based analysis tools such as
bcc. Since these helpers are built with GCC, they use
the correct offsets when referenci
Hi Alexei, Naveen,
On 11/04/2017 11:01 PM, Naveen N. Rao wrote:
>
> I think the offsets described in dwarf were incorrect with
> CONFIG_GCC_PLUGIN_RANDSTRUCT, but I'll let Sandipan confirm that.
>
I think that the offsets described in dwarf are probably incorrect when
CONFIG_GCC_PLUGIN_RANDSTR
This makes sure that the SyS symbols are ignored for any powerpc
system, not just the big endian ones.
Fixes: fb6d59423115 ("perf probe ppc: Use the right prefix when ignoring SyS
symbols on ppc")
Reported-by: Naveen N. Rao
Signed-off-by: Sandipan Das
Reviewed-by: Kamalesh Babulal
s: 99e608b5954c ("perf probe ppc64le: Fix probe location when using DWARF")
Reported-by: Aneesh Kumar K.V
Signed-off-by: Sandipan Das
---
tools/perf/arch/powerpc/util/sym-handling.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/arch/powerpc/util/sym-
test 0 'config=10,config1,config2=3,umask=1'
test child finished with 1
end
Parse event definition strings: FAILED!
Fixes: 055f839c5ef0 ("perf tests: Check that complex event name is parsed
correctly")
Suggested-by: Ravi Bangoria
Signed-off-by: Sandipan Das
---
s: 9ef0112442bd ("perf test: Fix subtest number when showing results")
Signed-off-by: Sandipan Das
---
tools/perf/tests/builtin-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 4f5de8245b32.
Hi Arnaldo,
I came across the same problem. Does the following patch fix it?
https://lkml.org/lkml/2018/7/26/669
- Sandipan
On Thursday 26 July 2018 06:45 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 25, 2018 at 02:59:34PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Hi Ingo,
>>
>> Ple
0
...
probe libc's inet_pton & backtrace it with ping: Ok
Fixes: e07d585e2454 ("perf tests: Switch trace+probe_libc_inet_pton to use
record")
Signed-off-by: Sandipan Das
---
tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 5 -
1 file changed, 4 insertions(+), 1
On 03/12/2018 06:35 PM, Jiri Olsa wrote:
> On Mon, Mar 12, 2018 at 06:14:50PM +0530, Sandipan Das wrote:
>> This fixes record+probe_libc_inet_pton.sh from always exiting
>> with code 0 and making the test pass even if the perf script
>> output does not match the expected pat
, breakpoints count 0, has_ioctl 1, share 0
test child finished with -2
end
Breakpoint accounting: Skip
After applying patch:
21: Breakpoint accounting : Disabled
Signed-off-by: Sandipan Das
---
tools/perf/tests/builtin-test.c | 1 +
1 file changed, 1 insertion
to fail on powerpc as
the back trace from perf output did not match the expected pattern.
Also, because of the issue described in the first patch, some entries
from the callchain were incorrectly skipped. So, this has also been
readjusted to work with the fix in the first patch.
Sandipan Das (2
_pton (/usr/lib64/libc-2.26.so)
10fa54 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)
1105b4 getaddrinfo (/usr/lib64/libc-2.26.so)
Fixes: a60335ba3298 ("perf tools powerpc: Adjust callchain based on DWARF debug
info")
Signed-off-by: Sandipan Das
ping: Ok
Fixes: e07d585e2454 ("perf tests: Switch trace+probe_libc_inet_pton to use
record")
Signed-off-by: Sandipan Das
---
tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 8
1 file changed, 8 insertions(+)
diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton
On 04/13/2018 12:13 AM, Arnaldo Carvalho de Melo wrote:
>
> So, the author for the fixed-by patch here is Sukadev Bhattiprolu
> , and the reporter for the problem that
> patch fixed is Maynard Johnson , who also tested
> that patch, I think it'd be better if they get CCed to have the
> opportuni
e=0x7fff9830, parent=0x7fff97b8,
> root_al=0x7fff9750, max_stack=127) at util/machine.c:2378
> #7 0x557ba4ee in sample__resolve_callchain (sample=,
> cursor=, parent=parent@entry=0x7fff97b8, evsel= out>, al=al@entry=0x7fffffff9750,
> max_stack=) at util/callchain.c:1085
>
Tested-by: Sandipan Das
Fixes: 67540759151a ("perf unwind: Use addr_location::addr instead of ip for
entries")
Signed-off-by: Sandipan Das
---
tools/perf/util/machine.c| 9 -
tools/perf/util/unwind-libdw.c | 2 +-
tools/perf/util/unwind-libunwind-local.c | 2 +-
3 files changed, 10 inse
/libc-2.26.so)
7fffa6df3898 __libc_start_main+0xb8 (/usr/lib64/libc-2.26.so)
0 [unknown] ([unknown])
Fixes: a60335ba3298 ("perf tools powerpc: Adjust callchain based on DWARF debug
info")
Signed-off-by: Sandipan Das
---
tools/perf/arch/powerpc/util/skip-callch
/lib64/power8/libc-2.26.so)
Cleanup of the event and the temporary files are now ensured by
allowing the cleanup code to be executed even if the lines from
the backtrace do not match their expected patterns instead of
simply exiting from the point of failure.
Signed-off-by: Sandipan Das
---
u had replied saying that you have applied
these patches to your tree but I still do not see the changes
in the 'perf/core' and 'perf/urgent' branches. Assuming that
you would be pushing these changes, I applied Kim's patches
to my local tree manually before I started working on
4 (/usr/lib64/libc-2.26.so)
7fffa24105b4 getaddrinfo+0x164 (/usr/lib64/libc-2.26.so)
138d52d70 main+0x3e0 (/usr/bin/ping)
test child finished with 0
end
probe libc's inet_pton & backtrace it with ping: Ok
Fixes: e07d585e2454 ("perf tests: Switch trace+probe_libc_ine
on __inet_pton@resolv/inet_pton.c in
/usr/lib64/power8/libc-2.26.so)
Signed-off-by: Sandipan Das
---
.../tests/shell/record+probe_libc_inet_pton.sh | 28 ++
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh
b/to
i Bangoria
Signed-off-by: Sandipan Das
---
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/arch/powerpc/util/skip-callchain-idx.c
b/tools/perf/arch/powerpc/util/skip-callchain-idx.c
index 264fc0158100..7c
ttps://github.com/0day-ci/linux/commits/Sandipan-Das/perf-tests-Fix-regex-for-record-probe_libc_inet_pton-sh/20180521-130408
>
>
> in testcase: perf-sanity-tests
> with following parameters:
>
> perf_compiler: gcc
>
>
>
> on test machine: qemu-system-x86_64
/test)
7fffb6fe36a0 generic_start_main.isra.0+0x140
(/usr/lib64/libc-2.26.so)
7fffb6fe3898 __libc_start_main+0xb8 (/usr/lib64/libc-2.26.so)
0 [unknown] ([unknown])
...
Signed-off-by: Sandipan Das
---
tools/perf/builtin-script.c | 26
perf record -e probe:sys_write ~/test
# perf script -F ip,sym,symoff
c04025b0 sys_write+0x10
...
Signed-off-by: Sandipan Das
---
tools/perf/util/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
t child forked, pid 30539
ping 30556 [003] 307254.313217: probe_libc:inet_pton: (7fe19ab10220)
7fe19ab10220 __GI___inet_pton+0x0 (/usr/lib64/libc-2.25.so)
7fe19aad5ebd getaddrinfo+0x11d (/usr/lib64/libc-2.25.so)
56351e3c1c71 main+0x891 (/usr/bin/ping)
test child finished with 0
---- end
pr
Hi Thomas,
On 05/18/2018 03:51 PM, Thomas-Mich Richter wrote:
[...]
>
> This patch fails on s390. I used 4.17.0rc5 + fedora 27 and I get this output:
>
>
> [root@p23lp27 perf]# ./perf test 59
> 59: probe libc's inet_pton & backtrace it with ping : Ok
> [root@p23lp27 linux]# cd ~/linux; pa
Hi Arnaldo,
On 05/19/2018 12:51 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, May 18, 2018 at 12:54:17PM +0530, Sandipan Das escreveu:
>> This test currently fails because the regular expressions for
>> matching the output of perf script do not consider the symbol
>> offs
f.data.tar.bz2 from the test program I sent earlier.
>
> cool, reproduced.. it seems to get introduced by:
> 2a9d5050dc84 perf script: Show correct offsets for DWARF-based unwinding
>
> reverting that patch fixes the issue for me, but looks like
> we could just make th attached che
From: Li Zhijian
since 6aa7de0, we failed to build perf with C++(clang)
to fix the following compile errors
--
lizhijian@haswell-OptiPlex-9020:~/lkp/linux/tools/perf$ make
LLVM_CONFIG=/usr/bin/llvm-config-3.9 LIBCLANGLLVM=1
...
CC util/probe-finder.o
In file included from /ho
Hi,
On 11/30/2017 07:06 AM, Li Zhijian wrote:
> since 6aa7de0, we failed to build perf with C++(clang)
> to fix the following compile errors
> --
> lizhijian@haswell-OptiPlex-9020:~/lkp/linux/tools/perf$ make
> LLVM_CONFIG=/usr/bin/llvm-config-3.9 LIBCLANGLLVM=1
> ...
> CC uti
Hi Mark,
On 04/04/2018 10:04 PM, Mark Rutland wrote:
>
> Zhijian, Sandipan, does this patch work for you?
>
Yes it does. Thanks for the fix.
- Sandipan
On 04/04/2018 10:48 PM, Mark Rutland wrote:
> On Wed, Apr 04, 2018 at 10:43:16PM +0530, Sandipan Das wrote:
>> Hi Mark,
>>
>> On 04/04/2018 10:04 PM, Mark Rutland wrote:
>>>
>>> Zhijian, Sandipan, does this patch work for you?
>>>
>>
>
_pton (/usr/lib64/libc-2.26.so)
10fa54 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)
1105b4 getaddrinfo (/usr/lib64/libc-2.26.so)
Fixes: a60335ba3298 ("perf tools powerpc: Adjust callchain based on DWARF debug
info")
Signed-off-by: Sandipan Das
nking
support")
Signed-off-by: Sandipan Das
---
tools/perf/Makefile.perf | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index f7517e1b73f8..83e453de36f8 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
1c77c ("perf clang: Add builtin clang support ant test case")
Signed-off-by: Sandipan Das
---
tools/perf/util/c++/clang.cpp | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/c++/clang.cpp b/tools/perf/util/c++/clang.cpp
index 1bfc946e37dc..bf3
source to ELF object: Ok
Fixes: e67d52d411c3 ("perf clang: Update test case to use real BPF script")
Signed-off-by: Sandipan Das
---
tools/perf/util/c++/clang-test.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/c++/clang-test.cpp
b/tool
ango...@linux.ibm.com
> v3->v4:
> - CONFIG_PPC64 check was not required, remove it.
> - Use SZ_ macros instead of hardcoded numbers.
>
Acked-by: Sandipan Das
Thanks for finding this! The patch set which moved protection-keys.txt
> out of x86 code probably just missed this when it got rebased. It
> originated well before June 2019, iirc.
>
That's right. Sorry about that. Must have missed it when rebasing the
older pkey selftest patches. Thanks for fixing this Mauro.
Acked-by: Sandipan Das
ind_locale libc-2.26.so
+8.87% dl-addr.c:52 [.] _dl_addr libc-2.26.so
+8.83% _init+236 [.] _initls
...
Reported-by: Ravi Bangoria
Signed-off-by: Sandipan Das
---
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 2 +-
1 file
On 04/17/2018 12:29 PM, Ravi Bangoria wrote:
>
> This change looks good to me but seems it fixed the issue
> partially.Ex,
>
> # readelf --debug-dump=frames-interp /lib64/libc-2.26.so | less
> ...
> 5778 0024 577c FDE cie=
> pc=00048b30..0
also been
readjusted to work with the fix in the first patch.
v2:
- Consider case when return address is in R0 as pointed out by Ravi.
- Add another patch to fix crash when callchain is empty.
Sandipan Das (3):
perf tools powerpc: Fix callchain ip filtering
perf tools powerpc: Fix crash if
trace it with ping: Ok
Fixes: e07d585e2454 ("perf tests: Switch trace+probe_libc_inet_pton to use
record")
Signed-off-by: Sandipan Das
---
tools/perf/tests/shell/record+probe_libc_inet_pton.sh | 8
1 file changed, 8 insertions(+)
diff --git a/tools/perf/tests/she
10fa54 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)
1105b4 getaddrinfo (/usr/lib64/libc-2.26.so)
Fixes: a60335ba3298 ("perf tools powerpc: Adjust callchain based on DWARF debug
info")
Signed-off-by: Sandipan Das
---
v2:
- Consider case when return address is in R0 as
+0x124)[0x1017ff5c]
perf(sample__resolve_callchain+0xf0)[0x10172788]
...
Reported-by: Ravi Bangoria
Signed-off-by: Sandipan Das
---
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/powerpc/util/skip-callchain
This replaces the incorrectly spelled word "localtion"
with "location" in some power8 PMU event descriptions.
Fixes: 2a81fa3bb5ed ("perf vendor events: Add power8 PMU events")
Signed-off-by: Sandipan Das
---
.../pmu-events/arch/powerpc/power8/cache.json| 10 +
.org/linux-mm/20200504070304.127361-1-sandi...@linux.ibm.com/T/#u
>
> [...]
>
Thanks again.
Acked-by: Sandipan Das
weak in common code. Fix it.
>
> Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
> Reported-by: Sandipan Das
> Signed-off-by: Ravi Bangoria
> ---
> tools/perf/arch/powerpc/util/Build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tool
. If GCC 4.6+ is used to build the kernel, this can be
solved by introducing appropriate defines for Clang so
that the anonymous structure is seen when determining the
offsets for the members.
Signed-off-by: Sandipan Das
---
include/linux/compiler-clang.h | 3 +++
1 file changed, 3 insertions
Commit-ID: a6f39cecf71537d105f4bf87b8d4760851960838
Gitweb: https://git.kernel.org/tip/a6f39cecf71537d105f4bf87b8d4760851960838
Author: Sandipan Das
AuthorDate: Thu, 26 Jul 2018 16:25:02 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 31 Jul 2018 10:52:23 -0300
perf tests
Commit-ID: aa90f9f9554616d5738f7bedb4a8f0e5e14d1bc6
Gitweb: https://git.kernel.org/tip/aa90f9f9554616d5738f7bedb4a8f0e5e14d1bc6
Author: Sandipan Das
AuthorDate: Thu, 26 Jul 2018 22:47:33 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 31 Jul 2018 10:52:51 -0300
perf tests
Commit-ID: c715fcfda5a08edabaa15508742be926b7ee51db
Gitweb: https://git.kernel.org/tip/c715fcfda5a08edabaa15508742be926b7ee51db
Author: Sandipan Das
AuthorDate: Tue, 10 Jul 2018 19:28:13 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 24 Jul 2018 14:50:10 -0300
perf powerpc
Commit-ID: 9068533e4f470daf2b0f29c71d865990acd8826e
Gitweb: https://git.kernel.org/tip/9068533e4f470daf2b0f29c71d865990acd8826e
Author: Sandipan Das
AuthorDate: Tue, 10 Jul 2018 19:28:14 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 24 Jul 2018 14:50:44 -0300
perf powerpc
Commit-ID: 3eae52f842329a95f8549124079518231c0daba8
Gitweb: https://git.kernel.org/tip/3eae52f842329a95f8549124079518231c0daba8
Author: Sandipan Das
AuthorDate: Tue, 10 Jul 2018 19:28:15 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 24 Jul 2018 14:51:37 -0300
perf tests
Commit-ID: 83e3b6d73e66a10088f362b08b99c36fec3a14e7
Gitweb: https://git.kernel.org/tip/83e3b6d73e66a10088f362b08b99c36fec3a14e7
Author: Sandipan Das
AuthorDate: Tue, 10 Jul 2018 19:28:16 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 24 Jul 2018 14:52:09 -0300
perf tests
Commit-ID: 60089e42d38438772e2f83334e3e5b7497009366
Gitweb: https://git.kernel.org/tip/60089e42d38438772e2f83334e3e5b7497009366
Author: Sandipan Das
AuthorDate: Tue, 10 Jul 2018 19:28:17 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 24 Jul 2018 14:52:19 -0300
perf tests
Commit-ID: 2a9d5050dc84fa2060f08a52f632976923e0fa7e
Gitweb: https://git.kernel.org/tip/2a9d5050dc84fa2060f08a52f632976923e0fa7e
Author: Sandipan Das
AuthorDate: Tue, 3 Jul 2018 17:35:55 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 24 Jul 2018 14:53:11 -0300
perf script
Commit-ID: 10f354a36f9a9aa1b8bffe0abc1cd43822a85bcd
Gitweb: https://git.kernel.org/tip/10f354a36f9a9aa1b8bffe0abc1cd43822a85bcd
Author: Sandipan Das
AuthorDate: Mon, 12 Mar 2018 18:14:50 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 16 Mar 2018 13:56:31 -0300
perf test
Commit-ID: c2fb54a183cfe77c6fdc9d71e2d5299c1c302a6e
Gitweb: https://git.kernel.org/tip/c2fb54a183cfe77c6fdc9d71e2d5299c1c302a6e
Author: Sandipan Das
AuthorDate: Wed, 4 Apr 2018 23:34:17 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 9 Apr 2018 11:13:07 -0300
perf tools
Commit-ID: 7854e499f33fd9c7e63288692ffb754d9b1d02fd
Gitweb: https://git.kernel.org/tip/7854e499f33fd9c7e63288692ffb754d9b1d02fd
Author: Sandipan Das
AuthorDate: Wed, 4 Apr 2018 23:34:18 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 9 Apr 2018 11:13:08 -0300
perf clang
Commit-ID: fcbd8fa44664e99a5d8c7ab97f1afdd82472f973
Gitweb: https://git.kernel.org/tip/fcbd8fa44664e99a5d8c7ab97f1afdd82472f973
Author: Sandipan Das
AuthorDate: Wed, 4 Apr 2018 23:34:19 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 9 Apr 2018 11:13:09 -0300
perf tests
Commit-ID: 143c99f6ac6812d23254e80844d6e34be897d3e1
Gitweb: https://git.kernel.org/tip/143c99f6ac6812d23254e80844d6e34be897d3e1
Author: Sandipan Das
AuthorDate: Mon, 11 Jun 2018 16:10:49 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 25 Jun 2018 11:59:35 -0300
perf report
Commit-ID: 354b064b8ebc1e1ede58550ca9e08bfa81e6af43
Gitweb: https://git.kernel.org/tip/354b064b8ebc1e1ede58550ca9e08bfa81e6af43
Author: Sandipan Das
AuthorDate: Thu, 9 Aug 2018 21:49:29 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 9 Aug 2018 14:40:11 -0300
perf probe
Commit-ID: fa694160cca6dbba17c57dc7efec5f93feaf8795
Gitweb: https://git.kernel.org/tip/fa694160cca6dbba17c57dc7efec5f93feaf8795
Author: Sandipan Das
AuthorDate: Tue, 28 Aug 2018 14:38:48 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 30 Aug 2018 15:15:11 -0300
perf probe
Commit-ID: 19610184693c547b4c12738df4156589892c4018
Gitweb: https://git.kernel.org/tip/19610184693c547b4c12738df4156589892c4018
Author: Sandipan Das
AuthorDate: Thu, 17 May 2018 12:03:25 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 17 May 2018 16:55:29 -0300
perf script
Commit-ID: 7903a70867230d9edbd5e886cd8b8a2b248f418f
Gitweb: https://git.kernel.org/tip/7903a70867230d9edbd5e886cd8b8a2b248f418f
Author: Sandipan Das
AuthorDate: Thu, 17 May 2018 12:03:26 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 18 May 2018 16:31:40 -0300
perf script
Commit-ID: 4b163ca343b45855b03114ef2ab47c454989d55c
Gitweb: https://git.kernel.org/tip/4b163ca343b45855b03114ef2ab47c454989d55c
Author: Sandipan Das
AuthorDate: Thu, 12 Apr 2018 21:51:40 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 12 Apr 2018 14:20:21 -0300
perf tests
67 matches
Mail list logo
