[PATCH] mailbox: Avoid NULL dereference in mbox_chan_received_data

2018-01-24 Thread Samuel Holland
CPI protocol driver frees its mailbox channel during probing if the SCP firmware does not respond within a specified timeout. In this case, if the SCP firmware takes slightly too long to respond, mbox_chan_received_data races with mbox_free_channel clearing chan->cl. Signed-off-by: Samuel H

[PATCH 0/5] coreboot table bus and framebuffer driver

2018-01-24 Thread Samuel Holland
il.coreboot.org/pipermail/coreboot/2014-September/078551.html Samuel Holland (5): firmware: coreboot: Expose the coreboot table as a bus firmware: memconsole: Probe via coreboot bus firmware: vpd: Probe via coreboot bus firmware: coreboot: Remove unused coreboot_table_find firmware: coreboo

[PATCH 3/5] firmware: vpd: Probe via coreboot bus

2018-01-24 Thread Samuel Holland
Remove the ad-hoc coreboot table search. Now the driver will only be probed when the necessary coreboot table entry has already been found. Furthermore, since the coreboot bus takes care of creating the device, a separate platform device is no longer needed. Signed-off-by: Samuel Holland

[PATCH 2/5] firmware: memconsole: Probe via coreboot bus

2018-01-24 Thread Samuel Holland
Remove the ad-hoc coreboot table search. Now the driver will only be probed when the necessary coreboot table entry has already been found. Signed-off-by: Samuel Holland --- drivers/firmware/google/memconsole-coreboot.c | 49 ++- 1 file changed, 17 insertions(+), 32

[PATCH 5/5] firmware: coreboot: Add coreboot framebuffer driver

2018-01-24 Thread Samuel Holland
Register a simplefb framebuffer when the coreboot table contains a framebuffer entry. Signed-off-by: Samuel Holland --- drivers/firmware/google/Kconfig| 8 ++ drivers/firmware/google/Makefile | 1 + drivers/firmware/google/coreboot_table.h | 22

[PATCH 4/5] firmware: coreboot: Remove unused coreboot_table_find

2018-01-24 Thread Samuel Holland
Now that all users of the coreboot_table_find function have been updated to hang off the coreboot table bus instead, remove it. Signed-off-by: Samuel Holland --- drivers/firmware/google/coreboot_table.c | 43 drivers/firmware/google/coreboot_table.h | 3 --- 2

[PATCH 1/5] firmware: coreboot: Expose the coreboot table as a bus

2018-01-24 Thread Samuel Holland
This simplifies creating device drivers for hardware or information described in the coreboot table. It also avoids needing to search through the table every time a driver is loaded. Signed-off-by: Samuel Holland --- drivers/firmware/google/coreboot_table-acpi.c | 2 +- drivers/firmware

Re: [linux-sunxi] [PATCH 16/16] arm: dts: sun8i: a83t: add thermal zone to A83T

2018-01-26 Thread Samuel Holland
On 01/26/18 09:19, Philipp Rossak wrote: > This patch adds the thermal zones to the A83T. Sensor 0 is located in the > cpu cluster 0. Sensor 1 is located in cluster 1 and Sensor 3 is located > in the gpu. You mention sensor 3 here, but have sensor 2 in the device tree. > Signed-off-by: Philipp Ro

Re: [linux-sunxi] [PATCH 13/16] arm: dts: sun8i: h3: add thermal zone to H3

2018-01-26 Thread Samuel Holland
On 01/26/18 09:19, Philipp Rossak wrote: > This patch adds the thermal zones to the H3. We have only one sensor and > that is placed in the cpu. > > Signed-off-by: Philipp Rossak > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/b

Re: [PATCH 1/2] arm64: arch_timer: Workaround for Allwinner A64 timer instability

2018-05-11 Thread Samuel Holland
On 05/11/18 03:48, Marc Zyngier wrote: > [+Mark, who co-maintains the arch timer code with me] > > Hi Samuel, > > On 11/05/18 03:27, Samuel Holland wrote: >> The Allwinner A64 SoC is known [1] to have an unstable architectural >> timer, which manifests itself most ob

Re: [linux-sunxi] Re: [PATCH 0/2] Allwinner A64 timer workaround

2018-07-04 Thread Samuel Holland
On 07/04/18 10:01, Marc Zyngier wrote: > On Wed, 04 Jul 2018 15:44:36, Andre Przywara wrote: >> On 04/07/18 15:31, Thomas Gleixner wrote: >>> On Wed, 4 Jul 2018, Andre Przywara wrote: On 04/07/18 11:00, Thomas Gleixner wrote: > On Wed, 4 Jul 2018, Marc Zyngier wrote: >> On 04/07/18 09

[PATCH] vt: Fix screen updates after CSI K sequences

2018-11-03 Thread Samuel Holland
of the cleared area. Cc: sta...@vger.kernel.org Fixes: d8ae72427187 ("vt: preserve unicode values corresponding to screen characters") Signed-off-by: Samuel Holland --- drivers/tty/vt/vt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/vt/vt.c b/d

Re: [PATCH] firmware: coreboot: Fix a missing-check bug

2018-10-18 Thread Samuel Holland
On 10/18/18 10:37, Wenwen Wang wrote: > In coreboot_table_init(), a for loop is used to copy the entries of the > coreboot table. For each entry, the header of the entry, which is a > structure coreboot_table_entry and includes the size of the entry, is > firstly copied from the IO region 'ptr_entr

Re: [PATCH 2/2] riscv: Fix text patching when IPI are used

2024-02-28 Thread Samuel Holland
Hi Alex, On 2024-02-28 11:51 AM, Alexandre Ghiti wrote: > For now, we use stop_machine() to patch the text and when we use IPIs for > remote icache flushes (which is emitted in patch_text_nosync()), the system > hangs. > > So instead, make sure every cpu executes the stop_machine() patching > fun

Re: [PATCH 13/17] mm: move numa_distance and related code from x86 to numa_memblks

2024-07-18 Thread Samuel Holland
On 2024-07-16 6:13 AM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move code dealing with numa_distance array from arch/x86 to > mm/numa_memblks.c > > This code will be later reused by arch_numa. > > No functional changes. > > Signed-off-by: Mike Rapoport (Microsoft) > --- >

Re: [PATCH v1 2/5] dt-bindings: mailbox: add binding for Microchip IPC mailbox driver

2024-09-12 Thread Samuel Holland
Hi Valentina, On 2024-09-12 12:00 PM, Valentina Fernandez wrote: > Add a dt-binding for the Microchip Inter-Processor Communication (IPC) > mailbox controller. > > Signed-off-by: Valentina Fernandez > --- > .../bindings/mailbox/microchip,sbi-ipc.yaml | 115 ++ > 1 file changed

Re: [PATCH v1 3/5] mailbox: add Microchip IPC support

2024-09-12 Thread Samuel Holland
Hi Valentina, On 2024-09-12 12:00 PM, Valentina Fernandez wrote: > +static int mchp_ipc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mchp_ipc_probe ipc_info; > + struct microchip_ipc *ipc; > + struct ipc_chan_info *priv; > + bool irq_

[PATCH net-next v2 2/5] net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check

2021-02-16 Thread Samuel Holland
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered, so there is no need to do it again here. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH net-next v2 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup

2021-02-16 Thread Samuel Holland
Adjust the spacing and use an explicit "return 0" in the success path to make the function easier to parse. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH net-next v2 0/5] dwmac-sun8i cleanup and shutdown hook

2021-02-16 Thread Samuel Holland
in patch 3 Samuel Holland (5): net: stmmac: dwmac-sun8i: Return void from PHY unpower net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check net: stmmac: dwmac-sun8i: Use reset_control_reset net: stmmac: dwmac-sun8i: Minor probe function cleanup net: stmmac: dwmac-sun8i: Add a

[PATCH net-next v2 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-02-16 Thread Samuel Holland
Use the appropriate function instead of reimplementing it, and update the error message to match the code. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH net-next v2 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower

2021-02-16 Thread Samuel Holland
This is a deinitialization function that always returned zero, and that return value was always ignored. Have it return void instead. Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH net-next v2 5/5] net: stmmac: dwmac-sun8i: Add a shutdown callback

2021-02-16 Thread Samuel Holland
The Ethernet MAC and PHY are usually major consumers of power on boards which may not be able to fully power off (those with no PMIC). Powering down the MAC and internal PHY saves power while these boards are "off". Reviewed-by: Chen-Yu Tsai Signed-off-by: Samuel Holland --- d

Re: [PATCH 0/3] Allwinner sunxi message box support

2018-02-28 Thread Samuel Holland
Hi, On 02/28/18 02:24, Maxime Ripard wrote: > On Tue, Feb 27, 2018 at 08:27:11PM -0600, Samuel Holland wrote: >> This series adds support for the "hardware message box" in recent >> Allwinner sunxi SoCs, used for communication with the ARISC management >> processo

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Samuel Holland
Hi, On 02/28/18 02:32, Maxime Ripard wrote: > On Tue, Feb 27, 2018 at 08:27:14PM -0600, Samuel Holland wrote: >> +/* >> + * The failure path should not disable the clock or assert the reset, >> + * because the PSCI implementation in firmware relies on this de

Re: [PATCH 1/3] dt-bindings: Add a binding for the sunxi message box

2018-02-28 Thread Samuel Holland
Hi, On 02/28/18 02:28, Maxime Ripard wrote: > On Tue, Feb 27, 2018 at 08:27:12PM -0600, Samuel Holland wrote: >> This mailbox hardware is present in several Allwinner sun8i and sun50i >> SoCs. Add a device tree binding for it. >> >> Signed-off-by: Samuel Holland

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Samuel Holland
Hi, On 02/28/18 03:16, Jassi Brar wrote: > On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: > > >> +/* >> + * The message box hardware provides 8 unidirectional channels. As the >> mailbox >> + * framework expects them to be bidirectional >>

Re: [PATCH 3/3] mailbox: sunxi-msgbox: Add a new mailbox driver

2018-02-28 Thread Samuel Holland
On 02/28/18 12:14, Jassi Brar wrote: > On Wed, Feb 28, 2018 at 11:21 PM, Samuel Holland wrote: >> Hi, >> >> On 02/28/18 03:16, Jassi Brar wrote: >>> On Wed, Feb 28, 2018 at 7:57 AM, Samuel Holland wrote: >>> >>> >>>> +/* >>

[PATCH] soc: sunxi: Fix missing dependency on REGMAP_MMIO

2019-02-28 Thread Samuel Holland
: Samuel Holland --- drivers/soc/sunxi/Kconfig | 1 + drivers/usb/musb/Kconfig | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/sunxi/Kconfig b/drivers/soc/sunxi/Kconfig index 353b07e40176..e84eb4e59f58 100644 --- a/drivers/soc/sunxi/Kconfig +++ b/drivers/soc/sunxi

[PATCH v2 07/10] ARM: dts: sunxi: a83t: Add msgbox node

2019-02-28 Thread Samuel Holland
The A83T SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 ++ 1 file changed, 10

[PATCH v2 00/10] Allwinner sunxi message box support

2019-02-28 Thread Samuel Holland
an A31 fallback compatible - Dropped the mailbox framework patch - Include DT patches for SoCs that document the message box Samuel Holland (10): clk: sunxi-ng: sun8i: Mark the msgbox clock as critical clk: sunxi-ng: sun9i: Mark the msgbox clock as critical clk: sunxi-ng: sun50i: Mark the

[PATCH v2 05/10] mailbox: sunxi-msgbox: Add a new mailbox driver

2019-02-28 Thread Samuel Holland
. Signed-off-by: Samuel Holland --- drivers/mailbox/Kconfig| 11 ++ drivers/mailbox/Makefile | 2 + drivers/mailbox/sunxi-msgbox.c | 315 + 3 files changed, 328 insertions(+) create mode 100644 drivers/mailbox/sunxi-msgbox.c diff --git a/drivers/mailbox

[PATCH v2 06/10] ARM: dts: sunxi: a80: Add msgbox node

2019-02-28 Thread Samuel Holland
The A80 SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun9i-a80.dtsi | 10 ++ 1 file changed, 10

[PATCH v2 08/10] ARM: dts: sunxi: h3/h5: Add msgbox node

2019-02-28 Thread Samuel Holland
The H3 and H5 SoCs contain a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 10 ++ 1 file

[PATCH v2 01/10] clk: sunxi-ng: sun8i: Mark the msgbox clock as critical

2019-02-28 Thread Samuel Holland
ff-by: Samuel Holland --- drivers/clk/sunxi-ng/ccu-sun8i-a23.c | 2 +- drivers/clk/sunxi-ng/ccu-sun8i-a33.c | 2 +- drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 2 +- drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8

[PATCH v2 02/10] clk: sunxi-ng: sun9i: Mark the msgbox clock as critical

2019-02-28 Thread Samuel Holland
ff-by: Samuel Holland --- drivers/clk/sunxi-ng/ccu-sun9i-a80.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80.c index 8936ef87652c..f9309782e7d8 100644 --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80.c +++ b/driver

[PATCH v2 10/10] arm64: dts: allwinner: h6: Add msgbox node

2019-02-28 Thread Samuel Holland
The H6 SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++ 1 file

[PATCH v2 03/10] clk: sunxi-ng: sun50i: Mark the msgbox clock as critical

2019-02-28 Thread Samuel Holland
ff-by: Samuel Holland --- drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 2 +- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c index 932836d26e2b..7780e855c56f 100644

[PATCH v2 09/10] arm64: dts: allwinner: a64: Add msgbox node

2019-02-28 Thread Samuel Holland
The A64 SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 10 ++ 1 file

[PATCH v2 04/10] dt-bindings: mailbox: Add a sunxi message box binding

2019-02-28 Thread Samuel Holland
This mailbox hardware is present in Allwinner sun8i, sun9i, and sun50i SoCs. Add a device tree binding for it. Signed-off-by: Samuel Holland --- .../bindings/mailbox/sunxi-msgbox.txt | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v3 15/15] [NOT FOR MERGE] arm64: dts: allwinner: a64: Remove unused r_intc

2019-03-01 Thread Samuel Holland
Now that r_intc is no longer used directly by Linux, it can be removed from the SoC device tree. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch

[PATCH v3 04/15] mailbox: sunxi-msgbox: Add a new mailbox driver

2019-03-01 Thread Samuel Holland
. Signed-off-by: Samuel Holland --- drivers/mailbox/Kconfig| 11 ++ drivers/mailbox/Makefile | 2 + drivers/mailbox/sunxi-msgbox.c | 315 + 3 files changed, 328 insertions(+) create mode 100644 drivers/mailbox/sunxi-msgbox.c diff --git a/drivers/mailbox

[PATCH v3 09/15] arm64: dts: allwinner: h6: Add msgbox node

2019-03-01 Thread Samuel Holland
The H6 SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 ++ 1 file

[PATCH v3 03/15] dt-bindings: mailbox: Add a sunxi message box binding

2019-03-01 Thread Samuel Holland
This mailbox hardware is present in Allwinner sun8i, sun9i, and sun50i SoCs. Add a device tree binding for it. Signed-off-by: Samuel Holland --- .../mailbox/allwinner,sunxi-msgbox.yaml | 79 +++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v3 06/15] ARM: dts: sunxi: a83t: Add msgbox node

2019-03-01 Thread Samuel Holland
The A83T SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun8i-a83t.dtsi | 10 ++ 1 file changed, 10

[PATCH v3 10/15] [NOT FOR MERGE] clk: sunxi-ng: sun8i: Avoid turning off unused PRCM gates

2019-03-01 Thread Samuel Holland
optimally configured these clocks before booting Linux. Signed-off-by: Samuel Holland --- drivers/clk/sunxi-ng/ccu-sun8i-r.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r.c b/drivers/clk/sunxi-ng/ccu-sun8i-r.c index

[PATCH v3 11/15] [NOT FOR MERGE] dt-bindings: Add a binding for a mailbox-backed interrupt controller

2019-03-01 Thread Samuel Holland
This is a somewhat generic binding for an interrupt controller/forwarder implemented in firmware and communicated with using a mailbox. Signed-off-by: Samuel Holland --- .../interrupt-controller/mbox-intc.txt| 33 +++ 1 file changed, 33 insertions(+) create mode 100644

[PATCH v3 12/15] [NOT FOR MERGE] irqchip/mbox: Introduce a mailbox-backed irqchip driver

2019-03-01 Thread Samuel Holland
This driver implements a simple interrupt controller using message passing over a mailbox channel. The intention is for the other end of the channel to be implemented in firmware. This allows filtering and forwarding interrupts from one processor to another. Signed-off-by: Samuel Holland

[PATCH v3 00/15] Allwinner sunxi message box support

2019-03-01 Thread Samuel Holland
-SoC compatible strings and an A31 fallback compatible - Dropped the mailbox framework patch - Include DT patches for SoCs that document the message box Samuel Holland (15): clk: sunxi-ng: Mark msgbox clocks as critical clk: sunxi-ng: Mark AR100 clocks as critical dt-bindings: mailbox: Add

[PATCH v3 14/15] [NOT FOR MERGE] arm64: dts: allwinner: a64: Convert DTS to use msgbox_intc

2019-03-01 Thread Samuel Holland
Now that there is an alternate way for Linux to receive NMIs from the PMIC, replace references to r_intc with references to the new interrupt controller. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts | 4 ++-- arch/arm64/boot/dts/allwinner/sun50i

[PATCH v3 08/15] arm64: dts: allwinner: a64: Add msgbox node

2019-03-01 Thread Samuel Holland
The A64 SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 10 ++ 1 file

[PATCH v3 02/15] clk: sunxi-ng: Mark AR100 clocks as critical

2019-03-01 Thread Samuel Holland
nux anyway, since it is the parent of all APB0 bus peripherals. This change only prevents Linux from turning off the AR100 clock in the rare case that no peripherals are in use. Signed-off-by: Samuel Holland --- drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 2 +- drivers/clk/sunxi-ng/ccu-sun8i-r.c | 2 +

[PATCH v3 07/15] ARM: dts: sunxi: h3/h5: Add msgbox node

2019-03-01 Thread Samuel Holland
The H3 and H5 SoCs contain a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 10 ++ 1 file

[PATCH v3 05/15] ARM: dts: sunxi: a80: Add msgbox node

2019-03-01 Thread Samuel Holland
The A80 SoC contains a message box that can be used to send messages and interrupts back and forth between the ARM application CPUs and the ARISC coprocessor. Add a device tree node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun9i-a80.dtsi | 10 ++ 1 file changed, 10

[PATCH v3 01/15] clk: sunxi-ng: Mark msgbox clocks as critical

2019-03-01 Thread Samuel Holland
other SoCs. Signed-off-by: Samuel Holland --- drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 3 ++- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 3 ++- drivers/clk/sunxi-ng/ccu-sun8i-a23.c | 3 ++- drivers/clk/sunxi-ng/ccu-sun8i-a33.c | 3 ++- drivers/clk/sunxi-ng/ccu-sun8i-a83t.c | 3 ++- drivers/clk/sun

[PATCH v3 13/15] [NOT FOR MERGE] arm64: dts: allwinner: a64: Add interrupt controller node

2019-03-01 Thread Samuel Holland
this virtual interrupt controller. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 29ee8f0f833a

Re: [PATCH 02/18] clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability

2019-02-26 Thread Samuel Holland
On 02/26/19 15:23, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v4.20.12, v4.19.25, v4.14.103,

Re: Fail to boot on bpim3 with next-20210128

2021-01-30 Thread Samuel Holland
On 1/30/21 11:00 AM, Corentin Labbe wrote: > Hello > > next-20210128 cannot be booted on my bpim3. > It start booting then freeze. > > [0.00] Linux version 5.11.0-rc5-03084-g7426957d237f (compile@Red) > (armv7a-unknown-linux-gnueabihf-gcc (Gentoo 9.3.0-r2 p4) 9.3.0, GNU ld > (Gentoo 2.3

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-08 Thread Samuel Holland
On 2/8/21 7:20 AM, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote: >> On 2/8/21 12:28 AM, Samuel Holland wrote: >>> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error >>> pointers to optional clocks

Re: [PATCH net-next RESEND 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-02-08 Thread Samuel Holland
On 2/8/21 10:29 AM, Alexander Duyck wrote: > On Sun, Feb 7, 2021 at 10:32 PM Samuel Holland wrote: >> >> Use the appropriate function instead of reimplementing it, >> and update the error message to match the code. >> >> Reviewed-by: Chen-Yu Tsai

[PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-07-30 Thread Samuel Holland
cur. This gets the controller working on big endian powerpc64. Signed-off-by: Samuel Holland --- Changes since v1: - Include changes to use __le?? types in command structures - Use an object literal for the intermediate "schedulertime" value - Use local "error" variable t

[PATCH 2/2] Bluetooth: hci_serdev: Fix crash with HCI_UART_INIT_PENDING

2020-08-01 Thread Samuel Holland
called concurrently, and then only calling hci_unregister_dev if the HCI was previously registered. Cc: sta...@vger.kernel.org Fixes: fdee6d8fc630 ("Bluetooth: hci_serdev: Fix HCI_UART_INIT_PENDING not working") Signed-off-by: Samuel Holland --- drivers/bluetooth/hci_serdev.c | 5 - 1

[PATCH 1/2] Bluetooth: hci_h5: Stop erroneously setting HCI_UART_REGISTERED

2020-08-01 Thread Samuel Holland
th: hci_serdev: Remove setting of HCI_QUIRK_RESET_ON_CLOSE."), this flag is ignored for hci_serdev users, so instead of fixing which flag is set, let's remove the flag entirely. Cc: sta...@vger.kernel.org Fixes: ce945552fde4 ("Bluetooth: hci_h5: Add support for serdev enumerated de

Re: [PATCH 1/2] Bluetooth: hci_h5: Stop erroneously setting HCI_UART_REGISTERED

2020-08-01 Thread Samuel Holland
On 8/1/20 10:43 AM, Samuel Holland wrote: > This code attempts to set the HCI_UART_RESET_ON_INIT flag. However, > it sets the bit in the wrong flag word: HCI_UART_RESET_ON_INIT goes in > hu->hdev_flags, not hu->flags. So it is actually setting > HCI_UART_REGISTERED, which is

[PATCH 2/2] Bluetooth: hci_ldisc/hci_serdev: Cancel init work before unregistering

2020-08-01 Thread Samuel Holland
fe6 ("Bluetooth: Add delayed init sequence support for UART controllers") Signed-off-by: Samuel Holland --- drivers/bluetooth/hci_ldisc.c | 1 + drivers/bluetooth/hci_serdev.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_

[PATCH 1/2] Bluetooth: hci_h5: Remove ignored flag HCI_UART_RESET_ON_INIT

2020-08-01 Thread Samuel Holland
Since commit cba736465e5c ("Bluetooth: hci_serdev: Remove setting of HCI_QUIRK_RESET_ON_CLOSE."), this flag is ignored for hci_serdev users, so let's remove setting it. Signed-off-by: Samuel Holland --- drivers/bluetooth/hci_h5.c | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-02 Thread Samuel Holland
On 7/31/20 2:29 AM, Arnd Bergmann wrote: > On Fri, Jul 31, 2020 at 12:07 AM Samuel Holland wrote: >> >> The main issue observed was at the call to scsi_set_resid, where the >> byteswapped parameter would eventually trigger the alignment check at >> drivers/scsi/sd

Re: [PATCH v2] scsi: 3w-9xxx: Fix endianness issues found by sparse

2020-08-08 Thread Samuel Holland
On 8/5/20 2:17 AM, Arnd Bergmann wrote: > On Wed, Aug 5, 2020 at 3:44 AM Samuel Holland wrote: >> On 8/3/20 9:02 AM, Arnd Bergmann wrote: >>> On Mon, Aug 3, 2020 at 5:42 AM Samuel Holland wrote: >>>> All of the command structures are packed, due to the "#pragma

[PATCH v3 1/3] scsi: 3w-9xxx: Use flexible array members to avoid struct padding

2020-08-08 Thread Samuel Holland
In preparation for removing the "#pragma pack(1)" from the driver, fix all instances where a trailing array member could be replaced by a flexible array member. Since a flexible array member has zero size, it introduces no padding, whether or not the struct is packed. Signed-off-

[PATCH v3 2/3] scsi: 3w-9xxx: Reduce scope of structure packing

2020-08-08 Thread Samuel Holland
adjusting the type of one misaligned "reserved" member. After this change, pahole reports that only one type had its layout change: the tw_compat_info member of TW_Device_Extension is now naturally aligned. Signed-off-by: Samuel Holland --- drivers/scsi/3w-9xxx.h | 18 ++--

[PATCH v3 3/3] scsi: 3w-9xxx: Fix endianness issues in command packets

2020-08-08 Thread Samuel Holland
big endian powerpc64. Signed-off-by: Samuel Holland --- drivers/scsi/3w-9xxx.c | 56 ++--- drivers/scsi/3w-9xxx.h | 111 + 2 files changed, 81 insertions(+), 86 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c index ec

[PATCH] arm64: dts: allwinner: Mark timer as stopped in suspend

2020-08-08 Thread Samuel Holland
platforms, or the time will be wrong after system resume. Adding the arm,no-tick-in-suspend property forces the kernel to ignore the ARM architectural timer when calculating sleeptime; it falls back to reading the RTC. Note that this only affects deep suspend, not s2idle. Signed-off-by: Samuel Holland

[PATCH] ASoC: sun8i-codec: Hook up component probe function

2020-08-18 Thread Samuel Holland
s expected. Fixes: 90cac932976e ("ASoC: sun8i-codec: Fix DAPM to match the hardware topology") Reported-by: Stephen Rothwell Signed-off-by: Samuel Holland --- sound/soc/sunxi/sun8i-codec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi

[PATCH v4 02/10] dt-bindings: irq: sun6i-r: Add a compatible for the H3

2021-01-11 Thread Samuel Holland
. Acked-by: Rob Herring Signed-off-by: Samuel Holland --- .../interrupt-controller/allwinner,sun6i-a31-r-intc.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun6i-a31-r-intc.yaml b/Documentation/devicetree

[PATCH v4 03/10] irqchip/sun6i-r: Use a stacked irqchip driver

2021-01-11 Thread Samuel Holland
provides a simple way to add wakeup support to any of its IRQs. That is the next patch; for now, just the NMI is moved over. This commit mostly reverts commit 173bda53b340 ("irqchip/sunxi-nmi: Support sun6i-a31-r-intc compatible"). Signed-off-by: Samuel Holland --- arch/a

[PATCH v4 06/10] ARM: dts: sunxi: Use the new r_intc binding

2021-01-11 Thread Samuel Holland
The binding of R_INTC was updated to allow specifying interrupts other than the external NMI, since routing those interrupts through the R_INTC driver allows using them for wakeup. Update the device trees to use the new binding. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun6i-a31

[PATCH v4 00/10] sunxi: Support IRQ wakeup from deep sleep

2021-01-11 Thread Samuel Holland
I_THREADED to avoid doubled level interrupts, since the latch will be set again as long as the trigger is met. - Replace sun6i_r_intc_domain_translate() with irq_domain_translate_twocell(). - Use an enum for the device tree binding. - Update commit messages for accuracy and typos. Samuel Holl

[PATCH v4 08/10] ARM: dts: sunxi: Move wakeup-capable IRQs to r_intc

2021-01-11 Thread Samuel Holland
-by: Samuel Holland --- arch/arm/boot/dts/sun6i-a31.dtsi | 4 arch/arm/boot/dts/sun8i-a23-a33.dtsi | 4 arch/arm/boot/dts/sun8i-a83t.dtsi| 3 +++ arch/arm/boot/dts/sunxi-h3-h5.dtsi | 3 +++ 4 files changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch

[PATCH v4 09/10] arm64: dts: allwinner: Use the new r_intc binding

2021-01-11 Thread Samuel Holland
The binding of R_INTC was updated to allow specifying interrupts other than the external NMI, since routing those interrupts through the R_INTC driver allows using them for wakeup. Update the device trees to use the new binding. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner

[PATCH v4 01/10] dt-bindings: irq: sun6i-r: Split the binding from sun7i-nmi

2021-01-11 Thread Samuel Holland
multiplexed IRQs to top-level register bits, it is no longer compatible with the A31 R_INTC. Signed-off-by: Samuel Holland --- .../allwinner,sun6i-a31-r-intc.yaml | 66 +++ .../allwinner,sun7i-a20-sc-nmi.yaml | 10 --- 2 files changed, 66 insertions(+), 10 deletions

[PATCH v4 05/10] ARM: dts: sunxi: Rename nmi_intc to r_intc

2021-01-11 Thread Samuel Holland
tion. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +- arch/arm/boot/dts/sun6i-a31-m9.dts | 2 +- arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 2 +- arch/arm/boot/dts/sun6i-a31.dtsi | 2 +

[PATCH v4 07/10] ARM: dts: sunxi: h3/h5: Add r_intc node

2021-01-11 Thread Samuel Holland
The H3 and H5 SoCs have an additional interrupt controller in the RTC power domain that can be used to enable wakeup for certain IRQs. Add a node for it. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm

[PATCH v4 10/10] arm64: dts: allwinner: Move wakeup-capable IRQs to r_intc

2021-01-11 Thread Samuel Holland
-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 3 +++ 2 files changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index fd4bf90163d5

[PATCH v4 04/10] irqchip/sun6i-r: Add wakeup support

2021-01-11 Thread Samuel Holland
ot;). Signed-off-by: Samuel Holland --- drivers/irqchip/irq-sun6i-r.c | 107 -- 1 file changed, 101 insertions(+), 6 deletions(-) diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c index d04d067423f4..a1b58c98d6ca 100644 --- a/drivers/irqchip

Re: [PATCH v4 2/2] hwspinlock: add sun8i hardware spinlock support

2020-12-11 Thread Samuel Holland
On 12/11/20 3:03 AM, Maxime Ripard wrote: > Hi, > > On Fri, Dec 11, 2020 at 09:24:15AM +0100, Wilken Gottwalt wrote: >> Adds the sun8i_hwspinlock driver for the hardware spinlock unit found in >> most of the sun8i compatible SoCs. >> >> This unit provides at least 32 spinlocks in hardware. The imp

Re: [PATCH v3 1/2] dt-bindings: hwlock: add sun8i_hwspinlock documentation

2020-12-07 Thread Samuel Holland
On 12/7/20 10:12 AM, Maxime Ripard wrote: > Hi, > > On Mon, Dec 07, 2020 at 05:05:03PM +0100, Wilken Gottwalt wrote: >> Adds documentation on how to use the sun8i_hwspinlock driver for sun8i >> compatible SoCs. >> >> Signed-off-by: Wilken Gottwalt >> --- >> .../bindings/hwlock/sun8i-hwspinlock.y

Re: [PATCH v3 1/6] cpufreq: sun50i: add efuse_xlate to get efuse version.

2020-12-07 Thread Samuel Holland
Hello, On 12/7/20 8:37 PM, Shuosheng Huang wrote: > It's better to use efuse_xlate to extract the differentiated part > regarding different SoC. > > Signed-off-by: Shuosheng Huang > --- > drivers/cpufreq/sun50i-cpufreq-nvmem.c | 72 +- > 1 file changed, 48 insertions(+),

[PATCH v2 0/3] PinePhone volume key (LRADC) wakeup support

2021-01-12 Thread Samuel Holland
ing change - Only add wakeup capability if "wakeup-source" is present - Warn but do not error out if setting the wake IRQ fails - Add "wakeup-source" property to PinePhone device tree Ondrej Jirman (1): input: sun4i-lradc-keys - Add wakup support Samuel Holland (2):

[PATCH v2 3/3] arm64: dts: allwinner: pinephone: Support volume key wakeup

2021-01-12 Thread Samuel Holland
PinePhone volume keys are connected to the LRADC in the A64. Users may want to use them to wake the device from sleep. Support this by declaring the LRADC as a wakeup source. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + 1 file changed, 1

[PATCH v2 2/3] input: sun4i-lradc-keys - Add wakup support

2021-01-12 Thread Samuel Holland
(sometimes doubling it), disable the LRADC wakeup source by default. Signed-off-by: Ondrej Jirman Signed-off-by: Samuel Holland --- drivers/input/keyboard/sun4i-lradc-keys.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/input/keyboard/sun4i-lradc

[PATCH v2 1/3] dt-bindings: sun4i-a10-lradc-keys: Accept wakeup-source property

2021-01-12 Thread Samuel Holland
The LRADC provides an interrupt that can be used to wake the system. Signify this by accepting a "wakeup-source" property in the binding. Signed-off-by: Samuel Holland --- .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml | 2 ++ 1 file changed, 2 insertions(+) dif

[PATCH 1/4] media: sunxi-cir: Clean up dead register writes

2021-01-12 Thread Samuel Holland
The register writes during driver removal occur after the device is already put back in reset, so they never had any effect. Signed-off-by: Samuel Holland --- drivers/media/rc/sunxi-cir.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media

[PATCH 0/4] media: sunxi-cir: Cleanup and power management

2021-01-12 Thread Samuel Holland
This series cleans up some dead code in the sunxi-cir driver and adds system power management hooks. Samuel Holland (4): media: sunxi-cir: Clean up dead register writes media: sunxi-cir: Remove unnecessary spinlock media: sunxi-cir: Factor out hardware initialization media: sunxi-cir

[PATCH 2/4] media: sunxi-cir: Remove unnecessary spinlock

2021-01-12 Thread Samuel Holland
Only one register, SUNXI_IR_CIR_REG, is accessed from outside the interrupt handler, and that register is not accessed from inside it. As there is no overlap between different contexts, no lock is needed. Signed-off-by: Samuel Holland --- drivers/media/rc/sunxi-cir.c | 10 -- 1 file

[PATCH 4/4] media: sunxi-cir: Implement suspend/resume/shutdown callbacks

2021-01-12 Thread Samuel Holland
To save power, gate/reset the hardware block while the system is asleep or powered off. Signed-off-by: Samuel Holland --- drivers/media/rc/sunxi-cir.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index

[PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-12 Thread Samuel Holland
function: throwing away the error from clk_prepare_enable and using the wrong type for the temporary register value. Signed-off-by: Samuel Holland --- drivers/media/rc/sunxi-cir.c | 128 --- 1 file changed, 74 insertions(+), 54 deletions(-) diff --git a/drivers/media

[PATCH] mmc: sunxi-mmc: Ensure host is suspended during system sleep

2021-01-12 Thread Samuel Holland
If the device suspend process begins before the mmc host's autosuspend timeout, the host will continue running during system sleep. Avoid this by forcing runtime suspend during a global suspend transition. Signed-off-by: Samuel Holland --- drivers/mmc/host/sunxi-mmc.c | 2 ++ 1 file chang

Re: [PATCH v4 3/3] scsi: 3w-9xxx: Fix endianness issues in command packets

2021-01-12 Thread Samuel Holland
On 9/2/20 10:44 PM, Samuel Holland wrote: > The controller expects all data it sends/receives to be little-endian. > Therefore, the packet struct definitions should use the __le16/32/64 > types. Once those are correct, sparse reports several issues with the > driver code, which are f

[PATCH v2 3/7] arm64: dts: allwinner: a64: Allow using multiple codec DAIs

2021-01-12 Thread Samuel Holland
Increase #sound-dai-cells on the digital codec to allow using the other DAIs provided by the codec for AIF2 and AIF3. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts

[PATCH v2 2/7] ARM: dts: sun8i-a33: Allow using multiple codec DAIs

2021-01-12 Thread Samuel Holland
Increase #sound-dai-cells on the digital codec to allow using the other DAIs provided by the codec for AIF2 and AIF3. Signed-off-by: Samuel Holland --- arch/arm/boot/dts/sun8i-a33.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b

  1   2   3   4   5   >