Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

2013-03-17 Thread Sam Ravnborg
On Sun, Mar 17, 2013 at 02:50:44PM -0700, Christopher Li wrote: > In the current tip of git tree. If I do a allmodconfig full build, then follow > by a "make" again without changing any code in the tree. > There are some object will always get rebuild. e.g. eboot.o. > I use "make V=2", it shows tha

Re: [PATCH] sparc: remove unused "config BITS"

2013-03-19 Thread Sam Ravnborg
S. That > doesn't count as usage of "config BITS". Just double checked - you are right. Maybe send a v2 with this info in changelog and add my: Acked-by: Sam Ravnborg Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn

2013-03-20 Thread Sam Ravnborg
On Tue, Mar 19, 2013 at 05:07:21PM +0900, Joonsoo Kim wrote: > On Tue, Mar 19, 2013 at 12:35:45AM -0700, Yinghai Lu wrote: > > Can you check why sparc do not need to change interface during converting > > to use memblock to replace bootmem? > > Sure. > According to my understanding to sparc32 code

Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

2013-03-20 Thread Sam Ravnborg
On Sun, Mar 17, 2013 at 03:08:11PM -0700, Christopher Li wrote: > On Sun, Mar 17, 2013 at 2:58 PM, Sam Ravnborg wrote: > > > > We got no patch - just some git help stuff. > > Seems you mistyped somthing.. > > > > Oops, sorry about that. I reattach the patch here

Re: linux-next: build failure after merge of the final tree (acpi tree related)

2013-02-12 Thread Sam Ravnborg
> > Signed-off-by: Stephen Rothwell > > --- > > arch/sparc/include/asm/processor.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/sparc/include/asm/processor.h > > b/arch/sparc/include/asm/processor.h > > index 34baa35..622cfa5 100644 > > --- a/arch/sparc/include/asm/proc

Re: Should SPARC use cpuidle?

2013-02-12 Thread Sam Ravnborg
rc uses an idle function pointer in its architecture > specific code. So we re-name sparc use of pm_idle to sparc_idle. > > Maybe some day, SPARC will cut over to cpuidle... > > Signed-off-by: Len Brown > Acked-by: David S. Miller Build tested - OK. Acked-by: Sam Ravnborg -

Re: Should SPARC use cpuidle? (was: linux-next: build failure after merge of the final tree (acpi tree related))

2013-02-12 Thread Sam Ravnborg
> > > Do you btw. have any hints how I can convert to the cpu_idle thing you > > hinted? > > If you have exactly 1 idle state, then cpuidle isn't that interesting, > except, perhaps the standard residency counters. If you have multiple > states to choose from, cpuidle becomes more valuable. >

Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-29 Thread Sam Ravnborg
On Tue, Jan 29, 2013 at 07:15:07PM +0530, Vineet Gupta wrote: > On Tuesday 29 January 2013 12:14 AM, Sam Ravnborg wrote: > > On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote: > >> Hi Sam, > >> > >> On Thursday 24 January 2013 04:20 PM, Vineet G

Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-28 Thread Sam Ravnborg
nt patches. > > Due to the nature of the 750 and 770, it is not possible to build for > > both together, w/o special runtime glue code which would hurt > > performance. > > > > Signed-off-by: Vineet Gupta > > Cc: Arnd Bergmann > > Cc: Sam Ravnbo

Re: [PATCH v6 1/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
On Tue, Feb 26, 2013 at 08:31:27AM -0800, Andrey Smirnov wrote: > From: Andrey Smirnov > > This patch adds all necessary header files and Kbuild plumbing for the > core driver for Silicon Laboratories Si476x series of AM/FM tuner > chips. > > The driver as a whole is implemented as an MFD device

Re: [PATCH v7 4/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
patch > adds a core portion of it that provides all the necessary > functionality to the two other drivers that represent radio and audio > codec subsystems of the chip. > > Acked-by: Hans Verkuil > Signed-off-by: Andrey Smirnov Acked-by: Sam Ravnborg -- To unsubscribe from this

Re: [PATCH 0/3] build linux-next without perl

2013-02-27 Thread Sam Ravnborg
On Wed, Feb 27, 2013 at 05:55:31PM +0100, John Spencer wrote: > Rob Landley wrote: >> Before 2.6.25 building Linux never required perl. This patch series > removes >> the requirement from basic kernel builds (tested on i686, x86_64, arm, >> > mips, >> powerpc, sparc, sh4, and m68k). Now updat

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-12 Thread Sam Ravnborg
> actually, y'know, proof-read it. Hmm.. > + $(KERNELRELEASE) "$(patsubst > y,_,$(CONFIG_HAVE_SYMBOL_PREFIX_UNDERSCORE))" > > +config HAVE_UNDERSCORE_SYMBOL_PREFIX HAVE_UNDERSCORE_... or HAVE_SYMBOL_... confusion. I prefer the HAVE_SYMBOL_... variant but no strong feelings..

Re: [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT"

2013-03-12 Thread Sam Ravnborg
l with > that name, this always evaluates to true. Delete this dependency. > > Signed-off-by: Paul Bolle Acked-by: Sam Ravnborg Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system

2013-03-12 Thread Sam Ravnborg
ct - from arch/sparc/Kconfig config HIGHMEM bool default y if SPARC32 > This patch and one other mistyped "free_highmem_page". I got lazy and > edited those patches in-place. Good spot! You can add my: Acked-by: Sam Ravnborg Sam -- To unsubscribe

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-13 Thread Sam Ravnborg
On Wed, Mar 13, 2013 at 09:21:01AM +, James Hogan wrote: > Hi Sam, > > On 13/03/13 06:31, Sam Ravnborg wrote: > >> /* Some toolchains use a `_' prefix for all user symbols. */ > >> -#ifdef CONFIG_SYMBOL_PREFIX > >> -#define MODULE_SYMBOL

Re: [2.6 patch] scsi/qlogicpti.c section fixes

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 03:00:16PM -0600, James Bottomley wrote: > > On Wed, 2008-01-30 at 22:03 +0200, Adrian Bunk wrote: > > This patch fixes the following section mismatches: > > > > <-- snip --> > > > > ... > > WARNING: drivers/scsi/qlogicpti.o(.devexit.text+0x8): Section mismatch in > >

Re: [2.6 patch] scsi/qlogicpti.c section fixes

2008-01-30 Thread Sam Ravnborg
> I'm just reflecting that all of the > problems would go away and we'd save thousands of person hours on the > infrastructure and bug fixing if we simply #defined most of the > sectional annotations to be nops. So far I have only seen three persons being really active in fixing the section mismat

Re: [git patches] net driver fixes

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 11:47:11PM +0100, Francois Romieu wrote: > Sam Ravnborg <[EMAIL PROTECTED]> : > [...] > > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > > +static struct pci_device_id sis190_pci_tbl[] = { > > > { PCI_DE

Re: oldconfig/menuconfig help text display for "choice" items

2008-01-30 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 02:02:19AM +0100, Jan Engelhardt wrote: > Hi, > > > when running oldconfig, I got to see some new IO delay questions, > and tried displaying its info using ?. > > IO delay type > 1. port 0x80 based port-IO delay [recommended] (IO_DELAY_0X80) (NEW) > >

Re: Value of __*{init,exit} anotations?

2008-01-30 Thread Sam Ravnborg
> > > > I don't deny we can invest large amounts of work to fix our current > > issues and build large scriptable checks to ensure we keep it fixed ... > > I'm just asking if, at the end of the day, it's really worth it. > > Some people consider it worth it for their memory restricted systems > a

Re: about relocs.c on x86

2008-01-31 Thread Sam Ravnborg
> > no strong opinion from me - but i think it should be obvious to the > developer when they are looking at a .c file that it's 32-bit only (or > 64-bit only). I.e. the default is that whatever .c file we look at is > unified - and in that sense relocs.c breaks that general expectation. I for

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 19:14:36 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > cpuhotplug is required for suspend/resume. > > > > Not on UP computers. > > > > great! someone who still has one of those and uses a kernel withou

Re: [Patch] mm: fix a section mismatch warning

2008-01-31 Thread Sam Ravnborg
gt; modpost: Found 1 section mismatch(es). > > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed-off-by: WANG Cong <[EMAIL PROTECTED]> > > --- > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b2838c2..8a9ae3c 100644 > --- a/mm/page_alloc.c > +++

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 10:48:11AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 19:34:25 +0100 > Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > > > On Thu, 31 Jan 2008 19:14:36 +0200 >

[PATCH] x86: fix section mismatch warning in acpi/boot.c

2008-01-31 Thread Sam Ravnborg
/processor_core.c in a __cpuinit path. So create a small wrapper and put back the annotation thus avoiding the warning. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/kernel/acpi/boot.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/x86/kerne

[PATCH] x86: silence section mismatch warning in smpboot_64.c

2008-01-31 Thread Sam Ravnborg
orrect and the right fix is to remove the __cpuinitdata annotation of cpu_initialized? Note: The analysis were disturbed by the fact that we had a variable with the same name in cpu/common.c - but this is 32 bit only] Note: Should smpboot_64 use cpu_clear()? Signed-off-by: Sam Ravnbo

[PATCH] cpu: do not annotate exported register_cpu_notifier()

2008-01-31 Thread Sam Ravnborg
completed. Drop the annotation so the function is kept after init. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Gautham R Shenoy <[EMAIL PROTECTED]> --- kernel/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index df94

[PATCH] pci: fix 4x section mismatch warnings

2008-01-31 Thread Sam Ravnborg
the init phase or during hotplug. So to avoid wasting too much memory in the non-hotplug case the simpler fix was to allow the fuctions to use code/data from the __devinit sections. This was done in all four case by adding the __ref annotation. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]&

[PATCH 0/11] fix 25 section mismatch warnings..

2008-01-31 Thread Sam Ravnborg
The following set of patches fixes 25 Section mismatch warnings in following directories: kernel/ mm/ drivers/pci arch/x86/ When build individually they are now clean. The shortlog: Sam Ravnborg (11): pci: fix section mismatch warnings referring to pci_do_scan_bus pci: fix 4x

[PATCH] pci: fix section mismatch warnings referring to pci_do_scan_bus

2008-01-31 Thread Sam Ravnborg
pci_do_scan_bus() so moving this function to the directory of PCI Hotplug was a logical way to fix so we only include this function in the kernel when the CONFIG_HOTPLUG_PCI is enabled. Then the abuse of __devinit could be dropped and we no longer trigger the above warnings. Signed-off-by: Sam

[PATCH] cpu: silence section mismatch warnings for hotcpu notifies

2008-01-31 Thread Sam Ravnborg
to the function .cpuinit.text:relay_hotcpu_callback() Additional warnings are silenced with this change but they are left put. This patch is just a workaround for the bad practice to use __cpuinit to annotate code solely used for HOTPLUG_CPU. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]&

[PATCH] cpu: fix section mismatch warnings for enable_nonboot_cpus

2008-01-31 Thread Sam Ravnborg
therefore the reference to _cpu_up() is valid. Annotate enable_nonboot_cpus() with __ref to silence modpost. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Gautham R Shenoy <[EMAIL PROTECTED]> --- kernel/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

[PATCH] x86: fix section mismatch warning in kernel/pci-calgary

2008-01-31 Thread Sam Ravnborg
handle_quirks ops). So annotate this function and the sister function __init. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/kernel/pci-calgary_64.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kern

[PATCH] mm: fix section mismatch warning in sparse.c

2008-01-31 Thread Sam Ravnborg
it is safe to annotate sparse_early_usemap_alloc with __init too. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Andy Whitcroft <[EMAIL PROTECTED]> Cc: Mel Gorman <[EMAIL PROTECTED]> Cc: Christoph Lameter <[EMAIL PROTECTED]> --- mm/sparse.c |2 +- 1 files cha

[PATCH] cpu: fix section mismatch related to cpu_chain

2008-01-31 Thread Sam Ravnborg
unregister_cpu_notifier() to the variable .cpuinit.data:cpu_chain cpu_chain is used by unregister_cpu_notifier() that is used by the kvm module. So we can call the unregister_cpu_notifier() long after init completed. Drop the __cpuinitdata annotation to avoid freeing cpu_chain. Signed-off-by: Sam

[PATCH] x86: fix section mismatch warnings when referencing notifiers

2008-01-31 Thread Sam Ravnborg
so there is no problem ignoring the reference. Note: This looks like another case where __cpuinit has been used as replacement for proper use of CONFIG_HOTPLUG_CPU to decide what code are used for HOTPLUG_CPU. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PROTE

Re: [PATCH] nozomi: constify driver

2008-01-31 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 07:25:05AM +0100, Frank Seidel wrote: > On Thursday 31 January 2008 22:39, Jan Engelhardt wrote: > > On Jan 31 2008 22:10, Frank Seidel wrote: > > >(Re: [PATCH 012/196 ver2] nozomi driver) and is a rework > > >of the nozomi constify patch from Jan Engelhardt. > > > > It's h

Re: [M68KNOMMU 06/06]: modify Makefiles to support common coldfire directory

2008-02-01 Thread Sam Ravnborg
Hi Greg. On Fri, Feb 01, 2008 at 05:37:56PM +1000, Greg Ungerer wrote: > Modify Makefiles to support separate coldfire platform directory. > > Currently the common ColdFire CPU family code sits in the > arch/m68knommu/platform/5307 directory. This is confusing, the files > containing this common

Re: [M68KNOMMU]: platform setup for 520x ColdFire parts

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 05:34:10PM +1000, Greg Ungerer wrote: > Switch to platform style configuration for 520x ColdFire parts. > Initial support is for the UARTs. DMA support moved to common code > for all ColdFire parts. > > +static struct mcf_platform_uart m520x_uart_platform[] = { > + { >

Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
James said in a related posting that the Section mismatch warnings were getting out of control. So I decided to take a closer look at current status. Latest mainline with Adrian + mine fixes applied. Target was x86 - an allyesconfig build. I looked at the reported Section mismatch warnings per di

Re: [M68KNOMMU]: platform setup for 520x ColdFire parts

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 09:44:04PM +1000, Greg Ungerer wrote: > > Hi Sam, > > Sam Ravnborg wrote: > >On Fri, Feb 01, 2008 at 05:34:10PM +1000, Greg Ungerer wrote: > >>Switch to platform style configuration for 520x ColdFire parts. > >>Initial support is for th

[PATCH] isdn: fix section mismatch warnings from hisax_cs_setup_card

2008-02-01 Thread Sam Ravnborg
checkcard is only used during init or when hot plugging ISDN devices. So annotate hisax_cs_setup_card() with __devinit. checkcard() is used by exported functions so it cannot be annotated __devinit. Annotate it with __ref so modpost ignore references to _devinit section. Signed-off-by: Sam Ravnborg

[PATCH] isdn: fix section mismatch warning in hfc_sx.c

2008-02-01 Thread Sam Ravnborg
CARD_INIT branch will only be taken under __devinit context but to be consistent remove the __devinit annotation of inithfcsx() so we do not mix non-__devinit and __devinit code. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Karsten Keil <[EMAIL PROTECTED]> Cc: Jeff Garzik <[

[PATCH] isdn: fix section mismatch warning in enpci_card_msg

2008-02-01 Thread Sam Ravnborg
enpci_card_msg() to the function .devinit.text:Amd7930_init() enpci_card_msg() can be called outside __devinit context referenced function should not be annotated __devinit. Remove annotation of Amd7930_init to fix this. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Karsten Keil &

[PATCH 0/5] isdn: fix section mismatch warnings in isdn

2008-02-01 Thread Sam Ravnborg
drivers/isdn resulted in 34 section mismatch warnings - so I decided to give them a try. This resulted in 5 simple patches. I know Jeff Garzik has some ISDN clean-up patches pending but rather than waiting forever to have them acked I deciced to fix the warnings in the current kernel. This for no

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:06:36PM +0100, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Change latencytop Kconfig entry so it doesn't list the archictectures > that support it. Instead introduce HAVE_LATENCY_SUPPORT which any > architecture can set. Should reduce patch confl

Re: [PATCH] latencytop s390 support.

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:08:11PM +0100, Heiko Carstens wrote: > Subject: [PATCH] latencytop s390 support. > > From: Heiko Carstens <[EMAIL PROTECTED]> > > Cc: Holger Wolf <[EMAIL PROTECTED]> > Cc: Martin Schwidefsky <[EMAIL PROTECTED]> > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> > --- >

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:32:28PM +0100, Ingo Molnar wrote: > > * Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > config STACKTRACE_SUPPORT > > > def_bool y > > > > > > +config HAVE_LATENCYTOP_SUPPORT > > > + def_bool y &

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:30:44PM +0100, Geert Uytterhoeven wrote: > On Fri, 1 Feb 2008, Harvey Harrison wrote: > > On Fri, 2008-02-01 at 03:03 -0800, Andrew Morton wrote: > > > On Fri, 1 Feb 2008 11:47:18 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > >

[PATCH] isdn: fix section mismatch warning for ISACVer

2008-02-01 Thread Sam Ravnborg
setup_avm_a1_pcmcia() to the function .devinit.text:setup_isac() ISACVer were only used from function annotated __devinit so add same annotation to ISACVer. One af the fererencing functions missed __devinit so add it and kill an additional warning. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: K

[PATCH] isdn: fix section mismatch warnings in isac.c and isar.c

2008-02-01 Thread Sam Ravnborg
clear_pending_isac_ints() were all used via a cardmsg fnction - which may be called ouside __devinit context. So remove the bogus __devinit annotation of the above three functions to fix the warnings. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Karsten Keil <[EMAIL PROTECTED]> Cc:

Re: [PATCH 0/5] isdn: fix section mismatch warnings in isdn

2008-02-01 Thread Sam Ravnborg
If anyone like to test it here is a cumulative patch. Sam diff --git a/drivers/isdn/hisax/amd7930_fn.c b/drivers/isdn/hisax/amd7930_fn.c index c0d7036..341faf5 100644 --- a/drivers/isdn/hisax/amd7930_fn.c +++ b/drivers/isdn/hisax/amd7930_fn.c @@ -744,8 +744,7 @@ dbusy_timer_handler(struct

Re: Avoid section mismatch involving arch_register_cpu

2008-02-01 Thread Sam Ravnborg
Hi Alexander. See below for my take on the same warning. It is already in x86.git pending merge. Comments welcome. Sam >From b7b4f3e109c742d32d255e04b7c2f90d08599ea8 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sat, 26 Jan 2008 21:25:08 +0100 Subjec

Re: Avoid section mismatch involving arch_register_cpu

2008-02-01 Thread Sam Ravnborg
annotation of register_cpu is wrong. > > The only external user of arch_register_cpu in the tree is > in drivers/acpi/processor_core.c where it is guarded by > ACPI_HOTPLUG_CPU (which depends on HOTPLUG_CPU). > > Signed-off-by: Alexander van Heukelum <[EMAIL PROTECTED]> &

Re: Avoid section mismatch involving arch_register_cpu

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 04:21:12PM +0100, Alexander van Heukelum wrote: > > On Fri, 1 Feb 2008 16:03:12 +0100, "Sam Ravnborg" <[EMAIL PROTECTED]> > said: > > Hi Alexander. > > > > See below for my take on the same warning. > > It is already in x

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 12:28:35PM -0500, Jeff Garzik wrote: > Tejun Heo wrote: > >This patch implements libata.force module parameter which can > >selectively override ATA port, link and device configurations > >including cable type, SATA PHY SPD limit, transfer mode and NCQ. > > > >For example, y

Re: PROBLEM: Section mismatches in kernel v2.6.24-6314-g24e1c13 build

2008-02-01 Thread Sam Ravnborg
Hi Dave. On Fri, Feb 01, 2008 at 06:06:58PM +, Dave Haywood wrote: > PROBLEM: Section mismatches in kernel v2.6.24-6314-g24e1c13 build > > Hi, > > I see the folllowing section mismatches in the latest Linus kernel git > tree build: ... Thanks for the report. These are being worked on but

Re: [BUILD FAILURE]2.6.24-git10 section type conflict

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 11:56:27PM +0530, Sudhir Kumar wrote: > Hi All, > I found the following kernel build failure for 2.6.24-git10 > on my machine: > > CC [M] drivers/scsi/lpfc/lpfc_attr.o > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type > conflict > make[2]: *** [driv

[PATCH] rtc: silence section mismatch warning in rtc-test

2008-02-01 Thread Sam Ravnborg
-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Alessandro Zummo <[EMAIL PROTECTED]> --- drivers/rtc/rtc-test.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c index 254c9fc..bc93002 100644 --- a/drivers/rtc/rtc-

[PATCH] pcmcia: silence section mismatch warnings from pci_driver variables

2008-02-01 Thread Sam Ravnborg
reference from the variable i82092aa_pci_drv to the function .devexit.text:i82092aa_pci_remove() Rename the variables from *_drv to *_driver so modpost ignore the OK references to __devinit/__devexit functions. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL

[PATCH] pcmcia: silence section mismatch warnings from class_interface variables

2008-02-01 Thread Sam Ravnborg
.devexit.text:pccard_sysfs_remove_rsrc() The variables of type class_interface contains references to __devinit and __devexit functions which is OK. Silence warnings by annotating the variables with __refdata. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL PROTECTED]> --- dr

[PATCH] serial: silence section mismatch warnings in 8250_pci

2008-02-01 Thread Sam Ravnborg
pci_serial_quirks with __refdata to ignore the __devexit references Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/serial/8250_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/serial/

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
> Another way to look at it... All of a sudden, different from 2.6.24, > kernel 2.6.25-git build spews so many warnings that I need to disable > section mismatch checking completely, because there is so much noise > that __normal build messages scroll off the screen__. One can ignore or one ca

Re: [PATCH] serial: silence section mismatch warnings in 8250_pci

2008-02-01 Thread Sam Ravnborg
Hi Andrew. Again I rely on you to pick up the patches. But let me know if you prefer another route toward mainline. And I obviously expect the Cc: people to review the changes albeit this serie is trivial. This is on top of my local tree and not -mm - so yell at me and drop anything that does no

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 10:22:13PM +0100, Geert Uytterhoeven wrote: > On Fri, 1 Feb 2008, Sam Ravnborg wrote: > > On Fri, Feb 01, 2008 at 02:30:44PM +0100, Geert Uytterhoeven wrote: > > > BTW, on m68k I get ca. 160 of them. Most seem to originate in > > > drivers/isdn/.

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 03:24:05PM -0500, Jeff Garzik wrote: > Sam Ravnborg wrote: > >One can ignore or one can fix... > >I decided to spend some of my friday on fixing section mismatch > >warnings as I've got a bit irritated over people spending time > >complainin

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 10:47:25PM +0100, Jan Engelhardt wrote: > > On Feb 1 2008 03:21, Harvey Harrison wrote: > >> > >> Question is: why do people keep adding new ones when they are so easy to > >> detect and fix? > >> > >> Asnwer: because neither they nor their patch integrators are doing ade

Re: [scsi bug] spurious build failures in aic7xxx

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 11:50:56PM +0100, Ingo Molnar wrote: > > i'm getting spurious build failures with latest -git: > > In file included from drivers/scsi/aic7xxx/aic7xxx_proc.c:44: > drivers/scsi/aic7xxx/aic7xxx_inline.h: In function 'ahc_pause_bug_fix': > drivers/scsi/aic7xxx/aic7xxx_inline.

Re: [PATCH] pci: fix section mismatch warnings referring to pci_do_scan_bus

2008-02-02 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 11:10:30PM +0100, Sam Ravnborg wrote: > Fix following warnings: > WARNING: o-x86_64/drivers/pci/built-in.o(.text+0xb054): Section mismatch in > reference from the function cpci_configure_slot() to the function > .devinit.text:pci_do_scan_bus() > WARNING: o

[RFC] Add EXPORT_INIT_SYMBOL()?

2008-02-02 Thread Sam Ravnborg
While analysing some of the section mismatches reported by modpost I came to the conclusion that there was no good way to say that a certain function could both be annotated say __cpuinit and exported. One example is register_cpu_notifier() in kernel/cpu.c The function is annotated __cpuinit which

Re: [scsi bug] spurious build failures in aic7xxx

2008-02-02 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 11:50:56PM +0100, Ingo Molnar wrote: > > i'm getting spurious build failures with latest -git: > > In file included from drivers/scsi/aic7xxx/aic7xxx_proc.c:44: > drivers/scsi/aic7xxx/aic7xxx_inline.h: In function 'ahc_pause_bug_fix': > drivers/scsi/aic7xxx/aic7xxx_inline.

Re: Section mismatch warning patch - microcode.c

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 04:39:02PM +0800, Peter Teoh wrote: > The following errors during compilation is corrected by the following > patch (against the latest linus tree): > > WARNING: arch/x86/kernel/microcode.o(.exit.text+0x6): Section mismatch > in reference from the function cleanup_module()

Re: [PATCH] sis190: fix compile error section type conflict

2008-02-02 Thread Sam Ravnborg
to Jeff once I have tested it with real > hardware (sunday evening entertainment). Sam, is it ok to add your > s-o-b to it ? No - a s-o-b document the path of the patch. And it will not hit Jeff via me. Although I know I said ths was to way to do it. But you can add my: Acked-by: Sam Ravnborg &

Re: [PATCH] kconfig: fix target update-po-config in Makefile

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 04:13:40PM +0100, Massimo Maiurana wrote: > Due to recent changes in arch/cris, "make update-po-config" fails > because it can't include arch/cris/arch as it is a symlink generated > at build time. > Patch below fixes this by creating, and then removing at the end, a > symli

Re: [scsi bug] spurious build failures in aic7xxx

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 03:18:57PM +0100, Ingo Molnar wrote: > > i should also specify the build environment: > > it's a distcc setup with 5-10 hosts active at a time, so highly parallel > with large, networking related delays. It's make -j130: > > nice -15 /usr/bin/time make -j130 bzImage ARCH

Re: CONFIG_SECTION_MISMATCH is replaced by CONFIG_DEBUG_SECTION_MISMATCH?

2008-02-02 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 12:20:41AM +0800, Peter Teoh wrote: > I supposed CONFIG_SECTION_MISMATCH has been deprecated by > CONFIG_DEBUG_SECTION_MISMATCH, as I found > CONFIG_DEBUG_SECTION_MISMATCH in Makefile, Makefile.build and > Makefile.modpost, but not the former symbol. Moreover, setting the

Re: Are Section mismatches out of control?

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 05:42:23PM +0100, Geert Uytterhoeven wrote: > On Fri, 1 Feb 2008, Sam Ravnborg wrote: > > On Fri, Feb 01, 2008 at 10:22:13PM +0100, Geert Uytterhoeven wrote: > > > On Fri, 1 Feb 2008, Sam Ravnborg wrote: > > > > On Fri, Feb 01, 2008 at 02:30:

Re: [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK

2008-02-02 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 02:14:08PM +, Ralf Baechle wrote: > Commit 312b1485fb509c9bc32eda28ad29537896658cb8 made __INIT_REFOK expand > into .section .section ".ref.text", "ax". Since the assembler doesn't > tolerate stuttering in the source that broke all MIPS builds. > > Since with this chan

Re: kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

2008-02-02 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 08:08:11AM -0800, Randy Dunlap wrote: > On Wed, 30 Jan 2008 11:13:23 +0100 (CET) Geert Uytterhoeven wrote: > > > kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH > > > > Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Applied a combined patch - thank

Re: 2.6.24-git7: section mismatches woes

2008-02-02 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 10:32:52PM +0100, Rafael J. Wysocki wrote: > On Wednesday, 30 of January 2008, Sam Ravnborg wrote: > > On Wed, Jan 30, 2008 at 07:50:43PM +0100, Rafael J. Wysocki wrote: > > > Hi, > > > > > > I get these messages, the majority

Re: [PATCH 1/1 try#2] [Scripts] add svn revision information to setlocalversion

2008-02-02 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 12:39:39AM +0800, Bryan Wu wrote: > >From f2adf444236eb3a4dcf5104dfbc1c5e1d5886c76 Mon Sep 17 00:00:00 2001 > From: Bryan Wu <[EMAIL PROTECTED]> > Date: Thu, 31 Jan 2008 00:38:16 +0800 > Subject: [PATCH] [Scripts] add svn revision information to setlocalversion > > [try #2]

Re: Incompatibility of "const" and __xxxinitdata?

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 11:20:44PM +0800, Peter Teoh wrote: > In include/linux/init.h, it is documented that all __xxxinitdata > declaration must not have constant, as show below: > > * > * static int init_variable __initdata = 0; > * static char linux_logo[] __initdata = { 0x32, 0x36, ... }; >

Re: make menuconfig broken

2008-02-02 Thread Sam Ravnborg
ks at top left corner you can see the current filename and is thus told what menuconfig use as default filename. Sam I fixed the bug like this: >From 7c280820a7a66abbb6b3b3f82c3753c7564600f2 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sat, 2 Feb

Re: [patch 0/5] Instrumentation Menu Removal

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 03:10:31PM -0500, Mathieu Desnoyers wrote: > Hi Andrew, > > Here are the updated instrumentation menu removal patches. They apply on top > of > 2.6.24-git12. I took tare of the underlying architecture changes that happened > recently (avr32 and arm especially). > > Patch

[REVIEW for merge] kbuild updates including silence of section mismatch check

2008-02-02 Thread Sam Ravnborg
H Mathieu Desnoyers (5): Fix ARM to play nicely with generic Instrumentation menu Create arch/Kconfig Add HAVE_OPROFILE Add HAVE_KPROBES Move Kconfig.instrumentation to arch/Kconfig and init/Kconfig Ralf Baechle (1): Remove __INIT_REFOK and __INITDATA_REFOK Sam R

Re: Some fixes for "Section mismatch" errors.

2008-02-02 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 12:00:29AM +0800, Peter Teoh wrote: > Today, I pulled from linus tree, and compile with MANY section > mismatches errors, eg, some of which are like the following: > > WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x1c9f): Section mismatch > in reference from the function hds

Re: SPI related Kconfig warning

2008-02-02 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 10:41:33PM -0600, Kumar Gala wrote: > Was wondering if anyone was looking at the cause of this warning in > top of linus's tree (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0) > > drivers/spi/Kconfig:156:warning: 'select' used by config symbol > 'SPI_PXA2XX' refers to undefi

Re: [REVIEW for merge] kbuild updates including silence of section mismatch check

2008-02-02 Thread Sam Ravnborg
Bryan this was from you - please comment/fix. Sam On Sat, Feb 02, 2008 at 10:25:51PM +0100, Frans Pop wrote: > Sam Ravnborg wrote: > > --- a/scripts/setlocalversion > > +++ b/scripts/setlocalversion > > @@ -45,3 +45,18 @@ if hgid=`hg id 2>/dev/null`; then >

Re: x86: fix arch/x86/kernel/test_nx.c modular build bug

2008-02-02 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 01:59:30AM +, Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=18fbef9e5242e146fe0264cf719a498785102841 > Commit: 18fbef9e5242e146fe0264cf719a498785102841 > Parent: f034347470e486835

[Additional PATCH] kbuild: do not warn about __*init/__*exit symbols being exported

2008-02-02 Thread Sam Ravnborg
>From e01639fd02bcf0126fcdedd09536a060e2593f07 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sat, 2 Feb 2008 23:30:22 +0100 Subject: [PATCH] kbuild: do not warn about __*init/__*exit symbols being exported We have several legitimate uses where we export symbols

Re: [RFC] Add EXPORT_INIT_SYMBOL()?

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 02:52:22PM +0100, Sam Ravnborg wrote: > While analysing some of the section mismatches reported > by modpost I came to the conclusion that there > was no good way to say that a certain function could > both be annotated say __cpuinit and exported. > &

Re: [patch] scsi: fix spurious build failures in aic7xxx

2008-02-02 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 05:54:41AM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > I could not reproduce the bug myself but I think I spotted it. We > > > had a missing dependency to the _reg.h file. Try following patch and > > > let me now if it continue to break

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Sam Ravnborg
> --- g26.orig/drivers/char/Kconfig > +++ g26/drivers/char/Kconfig > @@ -715,9 +715,12 @@ config NVRAM > To compile this driver as a module, choose M here: the > module will be called nvram. > > +comment "You are using the RTC framework, not the legacy CMOS RTC driver" > + dep

Re: 2.6.24-git7: section mismatches woes

2008-02-03 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 11:47:29PM +0100, Rafael J. Wysocki wrote: > On Saturday, 2 of February 2008, Sam Ravnborg wrote: > > On Wed, Jan 30, 2008 at 10:32:52PM +0100, Rafael J. Wysocki wrote: > > > On Wednesday, 30 of January 2008, Sam Ravnborg wrote: > > > > On W

Re: [PATCH try#2 ] kbuild: add svn revision information to setlocalversion

2008-02-03 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 02:13:26PM +0800, Bryan Wu wrote: > >From 0a7a2c6f19d32a85ca1a7887382325170ef19a66 Mon Sep 17 00:00:00 2001 > From: Bryan Wu <[EMAIL PROTECTED]> > Date: Sun, 3 Feb 2008 14:05:00 +0800 > Subject: [PATCH] [Scripts] add svn revision information to setlocalversion > > follow gi

[PATCH] x86: restore correct module name for apm

2008-02-03 Thread Sam Ravnborg
The apm module were renamed to apm_32 during the merge of 32 and 64 bit x86 which is unfortunate. As apm is 32 bit specific we like to keep the _32 in the filename but the module should be named apm. Fix this in the Makefile. Reported by "A.E.Lawrence" <[EMAIL PROTECTED]> Si

Re: [PATCH] x86: restore correct module name for apm

2008-02-03 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 11:52:16AM +, A.E.Lawrence wrote: > Sam Ravnborg wrote: > > The apm module were renamed to apm_32 during the merge of 32 and 64 bit x86 > > which > > is unfortunate. > > As apm is 32 bit specific we like to keep the _32 in the filename &

Re: [patch 0/4] cleanup - use _AC macro to define PAGE_SIZE

2008-02-03 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 02:22:17PM +0300, Cyrill Gorcunov wrote: > This patch series removes code duplication for PAGE_SIZE > definition on various architectures. > > Please review. Any comments are welcome. *UNTESTED* Looks good. Could you do a followup patch for each architecture introducing us

Re: 2.6.24-git7: section mismatches woes

2008-02-03 Thread Sam Ravnborg
> > > suspend to RAM working? > > I dunno - never used it I'm afraid. And do not know how to do it either. > > # echo mem > /sys/power/state > > (better do it after a fresh boot for the first time in case it fails). Will try later - thanks. > > The way to approach it is straightforward but bori

  1   2   3   4   5   6   7   8   9   10   >