[PATCH] Kawasaki USB-Ethernet Controller Driver

2001-03-24 Thread Sam
This driver adds support for Kawasaki USB-Ethernet 1-Chip Controler based devices. Sam kaweth.patch.gz

Adding support for IDE on nCS5 on an ARM7

2007-04-03 Thread Sam
ame thing happens if I try to read it as an 8-bit block... It also does the same thing if I don't do the mapping and try to access at the physical base address... but of course I shouldn't be doing that anyways right? Thanks, Sam Segfault:

your photos need edit

2018-08-02 Thread Sam
, body retouching) Glamour retouching Product retouching Color correction and others We provide testing for our services. Thanks, Sam

edit your photos

2018-08-02 Thread Sam
, body retouching) Glamour retouching Product retouching Color correction and others We provide testing for our services. Thanks, Sam

edit your photos

2018-08-02 Thread Sam
, body retouching) Glamour retouching Product retouching Color correction and others We provide testing for our services. Thanks, Sam

we look after your photos

2018-08-03 Thread Sam
. Thanks, Sam Parker

Enhancing your images

2018-08-03 Thread Sam
. Thanks, Sam Parker

Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

2013-03-17 Thread Sam Ravnborg
e unnecessary > rebuild of several objects. The second "make" has fewer output. > The clean rebuild seems works fine too. We got no patch - just some git help stuff. Seems you mistyped somthing.. Sam -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] sparc: remove unused "config BITS"

2013-03-19 Thread Sam Ravnborg
S. That > doesn't count as usage of "config BITS". Just double checked - you are right. Maybe send a v2 with this info in changelog and add my: Acked-by: Sam Ravnborg Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn

2013-03-20 Thread Sam Ravnborg
ther stuff. I recall from back then that these ackward named variables confused me, and some of my confusion was likely rooted in sparc32 using max_low_pfn for something elase than others do. I have no plans to look into adding memblock support for sparc32 right now. But may eventually do so when I get

Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

2013-03-20 Thread Sam Ravnborg
On Sun, Mar 17, 2013 at 03:08:11PM -0700, Christopher Li wrote: > On Sun, Mar 17, 2013 at 2:58 PM, Sam Ravnborg wrote: > > > > We got no patch - just some git help stuff. > > Seems you mistyped somthing.. > > > > Oops, sorry about that. I reattach the patch here

Re: linux-next: build failure after merge of the final tree (acpi tree related)

2013-02-12 Thread Sam Ravnborg
an you please move the definition of sparc_idle to processor_32.h It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards as the sparc32 variant are not used from assembler. Do you btw. have any hints how I can convert to the cpu_idle thing you hinted? Sam -- To unsubscr

Re: Should SPARC use cpuidle?

2013-02-12 Thread Sam Ravnborg
rc uses an idle function pointer in its architecture > specific code. So we re-name sparc use of pm_idle to sparc_idle. > > Maybe some day, SPARC will cut over to cpuidle... > > Signed-off-by: Len Brown > Acked-by: David S. Miller Build tested - OK. Acked-by: Sam Ravnborg -

Re: Should SPARC use cpuidle? (was: linux-next: build failure after merge of the final tree (acpi tree related))

2013-02-12 Thread Sam Ravnborg
m, cpuidle becomes more valuable. > > There are lots of cpuidle users now, including x86's intel_idle, > processor_idle, and the entire ARM tree. I think LEON has only a single power-down state. The APC stuff I know nothing about :-( So for now I think I will let it be as it is then.

Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-29 Thread Sam Ravnborg
On Tue, Jan 29, 2013 at 07:15:07PM +0530, Vineet Gupta wrote: > On Tuesday 29 January 2013 12:14 AM, Sam Ravnborg wrote: > > On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote: > >> Hi Sam, > >> > >> On Thursday 24 January 2013 04:20 PM, Vineet G

Re: [PATCH v3 02/71] ARC: Build system: Makefiles, Kconfig, Linker script

2013-01-28 Thread Sam Ravnborg
On Mon, Jan 28, 2013 at 11:59:36AM +0530, Vineet Gupta wrote: > Hi Sam, > > On Thursday 24 January 2013 04:20 PM, Vineet Gupta wrote: > > Arnd in his review pointed out that arch Kconfig organisation has several > > deficiencies: > > > > * Build time entrie

Re: [PATCH v6 1/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
On Tue, Feb 26, 2013 at 08:31:27AM -0800, Andrey Smirnov wrote: > From: Andrey Smirnov > > This patch adds all necessary header files and Kbuild plumbing for the > core driver for Silicon Laboratories Si476x series of AM/FM tuner > chips. > > The driver as a whole is implemented as an MFD device

Re: [PATCH v7 4/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
patch > adds a core portion of it that provides all the necessary > functionality to the two other drivers that represent radio and audio > codec subsystems of the chip. > > Acked-by: Hans Verkuil > Signed-off-by: Andrey Smirnov Acked-by: Sam Ravnborg -- To unsubscribe from this

Re: [PATCH 0/3] build linux-next without perl

2013-02-27 Thread Sam Ravnborg
werpc, sparc, sh4, and m68k). Now updated to 3.8-rc1. > > using this patch series since 2.6.32 in sabotage linux, it is highly > useful and it's about time to get it merged. > tested against linux 3.8, works perfectly. Why do you apply this patch serie to sabotage linux? S

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-12 Thread Sam Ravnborg
MBOL_PREFIX "" > +#define __VMLINUX_SYMBOL(x) x > +#define __VMLINUX_SYMBOL_STR(x) #x > +#define VMLINUX_SYMBOL_PREFIX_STR "" > #endif We know the prefix is an underscore. No benefits from defining VMLINUX_SYMBOL_PREFIX_STR. The config name even syas so. Skipping the above gi

Re: [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT"

2013-03-12 Thread Sam Ravnborg
l with > that name, this always evaluates to true. Delete this dependency. > > Signed-off-by: Paul Bolle Acked-by: Sam Ravnborg Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system

2013-03-12 Thread Sam Ravnborg
ct - from arch/sparc/Kconfig config HIGHMEM bool default y if SPARC32 > This patch and one other mistyped "free_highmem_page". I got lazy and > edited those patches in-place. Good spot! You can add my: Acked-by: Sam Ravnborg Sam -- To unsubscribe

Re: [RFC -next] linux/linkage.h: fix symbol prefix handling

2013-03-13 Thread Sam Ravnborg
On Wed, Mar 13, 2013 at 09:21:01AM +, James Hogan wrote: > Hi Sam, > > On 13/03/13 06:31, Sam Ravnborg wrote: > >> /* Some toolchains use a `_' prefix for all user symbols. */ > >> -#ifdef CONFIG_SYMBOL_PREFIX > >> -#define MODULE_SYMBOL

pointer dereference on remove gma500_gfx module 3.8.2

2013-03-15 Thread Sam Tygier
dmesg at end. I have no monitor attached. I can reproduce this. Thanks, Sam Please CC replies [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Linux version 3.8-trunk-amd64 (debian-ker...@lists.debian.org) (gcc version

Continuous warn slow path warning messages from top of the kernel tree

2012-08-30 Thread Sam Gandhi
ought those functions were slow path safe? I was wondering if this some new regression that anybody else has seen? -Sam --- [4.18] device=eth0, addr=192.168.137.1, mask=255.255.255.0, gw=192.168.137.254 [4.18] Dumping ftrace buffer: [4.18](ftrace buffer

Re: [2.6 patch] scsi/qlogicpti.c section fixes

2008-01-30 Thread Sam Ravnborg
ounds they provide > little benefit for all the pain they cause. For the embedded people a few kb here and there is worth it. > all __exit seems to do is set us up for unreferenced pointers in > discarded sections, so could we kill that too? Again - savings when we build-in the drivers. And with

Re: [2.6 patch] scsi/qlogicpti.c section fixes

2008-01-30 Thread Sam Ravnborg
ff I think it is worth it. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [git patches] net driver fixes

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 11:47:11PM +0100, Francois Romieu wrote: > Sam Ravnborg <[EMAIL PROTECTED]> : > [...] > > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > > +static struct pci_device_id sis190_pci_tbl[] = { > > > { PCI_DE

Re: oldconfig/menuconfig help text display for "choice" items

2008-01-30 Thread Sam Ravnborg
> > > The IO_DELAY_* "config" items have a help text, while the "choice" > item does not. > Are there any plans on 'fixing' oldconfig to somehow tell me something > about such new options? IT should be fixed but I have not looked into to it. Roman?

Re: Value of __*{init,exit} anotations?

2008-01-30 Thread Sam Ravnborg
ine applied but none of the recently posted fixes by Adrian. I am concentrating on: drivers/pci/ kernel/ mm/ Will post my patches during the weekend if things goes well. There are some low hanging fruits in drivers/ but I stay away from these from now expecting others to fix these. Sam --

Re: about relocs.c on x86

2008-01-31 Thread Sam Ravnborg
efit at that time to invest the time to unify them. Each of the remaining Makefile should be unifyable in less than 10 steps each. It is just work that are waitng to be done. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
it.data 0040 0025afc0 2**2 39 .meminit.data 000c 0025b000 2**2 __devinit alone gives a net win of 5464 bytes. That is only ~3% of total .text size but this is non-swapable memory where everything is worth it. And the configuration selected is by no means

Re: [Patch] mm: fix a section mismatch warning

2008-01-31 Thread Sam Ravnborg
gt; modpost: Found 1 section mismatch(es). > > Cc: Sam Ravnborg <[EMAIL PROTECTED]> > Signed-off-by: WANG Cong <[EMAIL PROTECTED]> > > --- > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b2838c2..8a9ae3c 100644 > --- a/mm/page_alloc.c > +++

Re: [PATCH] kill hotplug init/exit section annotations

2008-01-31 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 10:48:11AM -0800, Arjan van de Ven wrote: > On Thu, 31 Jan 2008 19:34:25 +0100 > Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 31, 2008 at 09:48:01AM -0800, Arjan van de Ven wrote: > > > On Thu, 31 Jan 2008 19:14:36 +0200 >

[PATCH] x86: fix section mismatch warning in acpi/boot.c

2008-01-31 Thread Sam Ravnborg
/processor_core.c in a __cpuinit path. So create a small wrapper and put back the annotation thus avoiding the warning. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/kernel/acpi/boot.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/x86/kerne

[PATCH] x86: silence section mismatch warning in smpboot_64.c

2008-01-31 Thread Sam Ravnborg
orrect and the right fix is to remove the __cpuinitdata annotation of cpu_initialized? Note: The analysis were disturbed by the fact that we had a variable with the same name in cpu/common.c - but this is 32 bit only] Note: Should smpboot_64 use cpu_clear()? Signed-off-by: Sam Ravnbo

[PATCH] cpu: do not annotate exported register_cpu_notifier()

2008-01-31 Thread Sam Ravnborg
completed. Drop the annotation so the function is kept after init. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Gautham R Shenoy <[EMAIL PROTECTED]> --- kernel/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/cpu.c b/kernel/cpu.c index df94

[PATCH] pci: fix 4x section mismatch warnings

2008-01-31 Thread Sam Ravnborg
the init phase or during hotplug. So to avoid wasting too much memory in the non-hotplug case the simpler fix was to allow the fuctions to use code/data from the __devinit sections. This was done in all four case by adding the __ref annotation. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]&

[PATCH 0/11] fix 25 section mismatch warnings..

2008-01-31 Thread Sam Ravnborg
The following set of patches fixes 25 Section mismatch warnings in following directories: kernel/ mm/ drivers/pci arch/x86/ When build individually they are now clean. The shortlog: Sam Ravnborg (11): pci: fix section mismatch warnings referring to pci_do_scan_bus pci: fix 4x

[PATCH] pci: fix section mismatch warnings referring to pci_do_scan_bus

2008-01-31 Thread Sam Ravnborg
pci_do_scan_bus() so moving this function to the directory of PCI Hotplug was a logical way to fix so we only include this function in the kernel when the CONFIG_HOTPLUG_PCI is enabled. Then the abuse of __devinit could be dropped and we no longer trigger the above warnings. Signed-off-by: Sam

[PATCH] cpu: silence section mismatch warnings for hotcpu notifies

2008-01-31 Thread Sam Ravnborg
to the function .cpuinit.text:relay_hotcpu_callback() Additional warnings are silenced with this change but they are left put. This patch is just a workaround for the bad practice to use __cpuinit to annotate code solely used for HOTPLUG_CPU. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]&

[PATCH] cpu: fix section mismatch warnings for enable_nonboot_cpus

2008-01-31 Thread Sam Ravnborg
therefore the reference to _cpu_up() is valid. Annotate enable_nonboot_cpus() with __ref to silence modpost. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Gautham R Shenoy <[EMAIL PROTECTED]> --- kernel/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

[PATCH] x86: fix section mismatch warning in kernel/pci-calgary

2008-01-31 Thread Sam Ravnborg
handle_quirks ops). So annotate this function and the sister function __init. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/kernel/pci-calgary_64.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kern

[PATCH] mm: fix section mismatch warning in sparse.c

2008-01-31 Thread Sam Ravnborg
it is safe to annotate sparse_early_usemap_alloc with __init too. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Andy Whitcroft <[EMAIL PROTECTED]> Cc: Mel Gorman <[EMAIL PROTECTED]> Cc: Christoph Lameter <[EMAIL PROTECTED]> --- mm/sparse.c |2 +- 1 files cha

[PATCH] cpu: fix section mismatch related to cpu_chain

2008-01-31 Thread Sam Ravnborg
unregister_cpu_notifier() to the variable .cpuinit.data:cpu_chain cpu_chain is used by unregister_cpu_notifier() that is used by the kvm module. So we can call the unregister_cpu_notifier() long after init completed. Drop the __cpuinitdata annotation to avoid freeing cpu_chain. Signed-off-by: Sam

[PATCH] x86: fix section mismatch warnings when referencing notifiers

2008-01-31 Thread Sam Ravnborg
so there is no problem ignoring the reference. Note: This looks like another case where __cpuinit has been used as replacement for proper use of CONFIG_HOTPLUG_CPU to decide what code are used for HOTPLUG_CPU. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PROTE

Re: [PATCH] nozomi: constify driver

2008-01-31 Thread Sam Ravnborg
atches and not to combine them. Where we combine two patches this is when the second patch fix a bug in the first patch. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [M68KNOMMU 06/06]: modify Makefiles to support common coldfire directory

2008-02-01 Thread Sam Ravnborg
ags-$(CONFIG_FULL_DEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1 > + > +obj-$(CONFIG_COLDFIRE) += dma.o entry.o vectors.o > +obj-$(CONFIG_M5206) += timers.o > +obj-$(CONFIG_M5206e) += timers.o > +obj-$(CONFIG_M520x) += pit.o > +obj-$(CONFIG_M523x) += pit.o > +obj-$(CONFIG_M524

Re: [M68KNOMMU]: platform setup for 520x ColdFire parts

2008-02-01 Thread Sam Ravnborg
nitdataconst for const data as replacement for __initdata. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
warnings. In my book things are not out of control. So stop complaining and lets see some fixes. I will look at drivers/isdn as next step. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [M68KNOMMU]: platform setup for 520x ColdFire parts

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 09:44:04PM +1000, Greg Ungerer wrote: > > Hi Sam, > > Sam Ravnborg wrote: > >On Fri, Feb 01, 2008 at 05:34:10PM +1000, Greg Ungerer wrote: > >>Switch to platform style configuration for 520x ColdFire parts. > >>Initial support is for th

[PATCH] isdn: fix section mismatch warnings from hisax_cs_setup_card

2008-02-01 Thread Sam Ravnborg
checkcard is only used during init or when hot plugging ISDN devices. So annotate hisax_cs_setup_card() with __devinit. checkcard() is used by exported functions so it cannot be annotated __devinit. Annotate it with __ref so modpost ignore references to _devinit section. Signed-off-by: Sam Ravnborg

[PATCH] isdn: fix section mismatch warning in hfc_sx.c

2008-02-01 Thread Sam Ravnborg
CARD_INIT branch will only be taken under __devinit context but to be consistent remove the __devinit annotation of inithfcsx() so we do not mix non-__devinit and __devinit code. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Karsten Keil <[EMAIL PROTECTED]> Cc: Jeff Garzik <[

[PATCH] isdn: fix section mismatch warning in enpci_card_msg

2008-02-01 Thread Sam Ravnborg
enpci_card_msg() to the function .devinit.text:Amd7930_init() enpci_card_msg() can be called outside __devinit context referenced function should not be annotated __devinit. Remove annotation of Amd7930_init to fix this. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Karsten Keil &

[PATCH 0/5] isdn: fix section mismatch warnings in isdn

2008-02-01 Thread Sam Ravnborg
no other reason than to get the noise level down. Andrew - I expect you to pick them up in -mm and forward to Linus. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Sam Ravnborg
> --- linux-2.6.orig/arch/x86/Kconfig > +++ linux-2.6/arch/x86/Kconfig > @@ -44,6 +44,9 @@ config LOCKDEP_SUPPORT > config STACKTRACE_SUPPORT > def_bool y > > +config HAVE_LATENCYTOP_SUPPORT > + def_bool y > + No. Please do: config X86 +

Re: [PATCH] latencytop s390 support.

2008-02-01 Thread Sam Ravnborg
> +config HAVE_LATENCYTOP_SUPPORT > + def_bool y > + Same comment as for the x86 version. Use: config S390 select HAVE_ Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] latencytop: Change Kconfig dependency.

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:32:28PM +0100, Ingo Molnar wrote: > > * Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > config STACKTRACE_SUPPORT > > > def_bool y > > > > > > +config HAVE_LATENCYTOP_SUPPORT > > > + def_bool y &

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 02:30:44PM +0100, Geert Uytterhoeven wrote: > On Fri, 1 Feb 2008, Harvey Harrison wrote: > > On Fri, 2008-02-01 at 03:03 -0800, Andrew Morton wrote: > > > On Fri, 1 Feb 2008 11:47:18 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > >

[PATCH] isdn: fix section mismatch warning for ISACVer

2008-02-01 Thread Sam Ravnborg
setup_avm_a1_pcmcia() to the function .devinit.text:setup_isac() ISACVer were only used from function annotated __devinit so add same annotation to ISACVer. One af the fererencing functions missed __devinit so add it and kill an additional warning. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: K

[PATCH] isdn: fix section mismatch warnings in isac.c and isar.c

2008-02-01 Thread Sam Ravnborg
clear_pending_isac_ints() were all used via a cardmsg fnction - which may be called ouside __devinit context. So remove the bogus __devinit annotation of the above three functions to fix the warnings. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Karsten Keil <[EMAIL PROTECTED]> Cc:

Re: [PATCH 0/5] isdn: fix section mismatch warnings in isdn

2008-02-01 Thread Sam Ravnborg
If anyone like to test it here is a cumulative patch. Sam diff --git a/drivers/isdn/hisax/amd7930_fn.c b/drivers/isdn/hisax/amd7930_fn.c index c0d7036..341faf5 100644 --- a/drivers/isdn/hisax/amd7930_fn.c +++ b/drivers/isdn/hisax/amd7930_fn.c @@ -744,8 +744,7 @@ dbusy_timer_handler

Re: Avoid section mismatch involving arch_register_cpu

2008-02-01 Thread Sam Ravnborg
Hi Alexander. See below for my take on the same warning. It is already in x86.git pending merge. Comments welcome. Sam >From b7b4f3e109c742d32d255e04b7c2f90d08599ea8 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sat, 26 Jan 2008 21:25:08 +0100 Subjec

Re: Avoid section mismatch involving arch_register_cpu

2008-02-01 Thread Sam Ravnborg
annotation of register_cpu is wrong. > > The only external user of arch_register_cpu in the tree is > in drivers/acpi/processor_core.c where it is guarded by > ACPI_HOTPLUG_CPU (which depends on HOTPLUG_CPU). > > Signed-off-by: Alexander van Heukelum <[EMAIL PROTECTED]> &

Re: Avoid section mismatch involving arch_register_cpu

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 04:21:12PM +0100, Alexander van Heukelum wrote: > > On Fri, 1 Feb 2008 16:03:12 +0100, "Sam Ravnborg" <[EMAIL PROTECTED]> > said: > > Hi Alexander. > > > > See below for my take on the same warning. > > It is already in x

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Sam Ravnborg
t; Given that the data is marked __initdata and the code is marked __init, > I cannot see the problem. I have lost the actual patch. But what you see is what happens when you mix const and non-const data in the same section. Look for use of __initdata for const data and replace it with __initcons

Re: PROBLEM: Section mismatches in kernel v2.6.24-6314-g24e1c13 build

2008-02-01 Thread Sam Ravnborg
eing worked on but it looks like we will have a few dozen left when we reach -rc1. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [BUILD FAILURE]2.6.24-git10 section type conflict

2008-02-01 Thread Sam Ravnborg
gt; conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > make[1]: *** [drivers/net] Error 2 > make[1]: *** Waiting for unfinished jobs > CC [M] drivers/scsi/lpfc/lpfc_vport.o Known issue with fix already pushed upstream. A workaround is to delete __devinitdata from the corresponding

[PATCH] rtc: silence section mismatch warning in rtc-test

2008-02-01 Thread Sam Ravnborg
-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Alessandro Zummo <[EMAIL PROTECTED]> --- drivers/rtc/rtc-test.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c index 254c9fc..bc93002 100644 --- a/drivers/rtc/rtc-

[PATCH] pcmcia: silence section mismatch warnings from pci_driver variables

2008-02-01 Thread Sam Ravnborg
reference from the variable i82092aa_pci_drv to the function .devexit.text:i82092aa_pci_remove() Rename the variables from *_drv to *_driver so modpost ignore the OK references to __devinit/__devexit functions. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL

[PATCH] pcmcia: silence section mismatch warnings from class_interface variables

2008-02-01 Thread Sam Ravnborg
.devexit.text:pccard_sysfs_remove_rsrc() The variables of type class_interface contains references to __devinit and __devexit functions which is OK. Silence warnings by annotating the variables with __refdata. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL PROTECTED]> --- dr

[PATCH] serial: silence section mismatch warnings in 8250_pci

2008-02-01 Thread Sam Ravnborg
pci_serial_quirks with __refdata to ignore the __devexit references Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/serial/8250_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/serial/

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
warnings are the least of his worries these days. I hope to get down to less than 20 warnings in my allyesconfig build before the merge window closes. And with just a bit of assistance from others this is doable. Sam - who expected more people to actually fix this stuff :-( -- To unsubscri

Re: [PATCH] serial: silence section mismatch warnings in 8250_pci

2008-02-01 Thread Sam Ravnborg
not apply. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 10:22:13PM +0100, Geert Uytterhoeven wrote: > On Fri, 1 Feb 2008, Sam Ravnborg wrote: > > On Fri, Feb 01, 2008 at 02:30:44PM +0100, Geert Uytterhoeven wrote: > > > BTW, on m68k I get ca. 160 of them. Most seem to originate in > > > drivers/isdn/.

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 03:24:05PM -0500, Jeff Garzik wrote: > Sam Ravnborg wrote: > >One can ignore or one can fix... > >I decided to spend some of my friday on fixing section mismatch > >warnings as I've got a bit irritated over people spending time > >complainin

Re: Are Section mismatches out of control?

2008-02-01 Thread Sam Ravnborg
rrect you. Section mismatch checks seldoms finds what I would call 'real' bugs that causes oops - but it happen. It is mostly fasle positives that needs workaround, but also a great deal of missing annotation resulting in additional memory saved. And then occasionally a bad reference

Re: [scsi bug] spurious build failures in aic7xxx

2008-02-01 Thread Sam Ravnborg
mware build I will take a look during the weekend. One day I get this Makefile fixed properly (I hope). Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] pci: fix section mismatch warnings referring to pci_do_scan_bus

2008-02-02 Thread Sam Ravnborg
On Thu, Jan 31, 2008 at 11:10:30PM +0100, Sam Ravnborg wrote: > Fix following warnings: > WARNING: o-x86_64/drivers/pci/built-in.o(.text+0xb054): Section mismatch in > reference from the function cpci_configure_slot() to the function > .devinit.text:pci_do_scan_bus() > WARNING: o

[RFC] Add EXPORT_INIT_SYMBOL()?

2008-02-02 Thread Sam Ravnborg
introduce EXPORT_INIT_SYMBOL and another that use the new EXPORT for register_cpu_notifier(). Sam diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index f784d2f..c64a675 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.

Re: [scsi bug] spurious build failures in aic7xxx

2008-02-02 Thread Sam Ravnborg
ut failed to finsih the job before it started building aic7xxx_proc.c so the build of aic7xxx_proc.c picked up a half written .h file. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Section mismatch warning patch - microcode.c

2008-02-02 Thread Sam Ravnborg
ter and post a fix for the warning. Sam > @@ -831,7 +831,7 @@ static int __init microcode_init (void) > return 0; > } > > -static void __exit microcode_exit (void) > +static void __init microcode_exit (void) > { -- To unsubscribe from this list: send the line

Re: [PATCH] sis190: fix compile error section type conflict

2008-02-02 Thread Sam Ravnborg
to Jeff once I have tested it with real > hardware (sunday evening entertainment). Sam, is it ok to add your > s-o-b to it ? No - a s-o-b document the path of the patch. And it will not hit Jeff via me. Although I know I said ths was to way to do it. But you can add my: Acked-by: Sam Ravnborg &

Re: [PATCH] kconfig: fix target update-po-config in Makefile

2008-02-02 Thread Sam Ravnborg
//www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/broken-out/cris-avoid-using-arch-links-in-kconfig.patch So until then we will live with a broken update-po-config. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [scsi bug] spurious build failures in aic7xxx

2008-02-02 Thread Sam Ravnborg
hat Intel has sponsored (thanks to Greg) :-) I could not reproduce the bug myself but I think I spotted it. We had a missing dependency to the _reg.h file. Try following patch and let me now if it continue to break. Sam diff --git a/drivers/scsi/aic7xxx/Makefile b/drivers/scsi/aic7xxx

Re: CONFIG_SECTION_MISMATCH is replaced by CONFIG_DEBUG_SECTION_MISMATCH?

2008-02-02 Thread Sam Ravnborg
setting the > symbol in .config, and followed by make oldconfig will result in the > non-debug symbol disappearing, but not the debug version. Am I > correct? Simple error on my side. Will fix while I touch this code for another reason. Thanks for the report and proposed patc

Re: Are Section mismatches out of control?

2008-02-02 Thread Sam Ravnborg
On Sat, Feb 02, 2008 at 05:42:23PM +0100, Geert Uytterhoeven wrote: > On Fri, 1 Feb 2008, Sam Ravnborg wrote: > > On Fri, Feb 01, 2008 at 10:22:13PM +0100, Geert Uytterhoeven wrote: > > > On Fri, 1 Feb 2008, Sam Ravnborg wrote: > > > > On Fri, Feb 01, 2008 at 02:30:

Re: [PATCH] Remove __INIT_REFOK and __INITDATA_REFOK

2008-02-02 Thread Sam Ravnborg
MIPS builds. > > Since with this change Sam downgraded __INIT_REFOK to just a backward > compat thing and there being only a single use in the MIPS arch code the > best solution is to delete both of __INIT_REFOK and __INITDATA_REFOK (which > was equally broken) being unused anyway these

Re: kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

2008-02-02 Thread Sam Ravnborg
> Applied a combined patch - thanks for fixing my bad grammar/spelling. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: 2.6.24-git7: section mismatches woes

2008-02-02 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 10:32:52PM +0100, Rafael J. Wysocki wrote: > On Wednesday, 30 of January 2008, Sam Ravnborg wrote: > > On Wed, Jan 30, 2008 at 07:50:43PM +0100, Rafael J. Wysocki wrote: > > > Hi, > > > > > > I get these messages, the majority

Re: [PATCH 1/1 try#2] [Scripts] add svn revision information to setlocalversion

2008-02-02 Thread Sam Ravnborg
lversion > > [try #2]: follow git and mercurial style, add uncommitted changes detect > > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Thanks - applied. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: Incompatibility of "const" and __xxxinitdata?

2008-02-02 Thread Sam Ravnborg
most certainly no other __initdata annotations or at least not to non-const data. If you go forward and fix up this stuff do so in adequate steps. So you for example do not mix net drivers with usb drivers in the same patch. And if fix it up then use the recommended style for the annotation. Impr

Re: make menuconfig broken

2008-02-02 Thread Sam Ravnborg
ks at top left corner you can see the current filename and is thus told what menuconfig use as default filename. Sam I fixed the bug like this: >From 7c280820a7a66abbb6b3b3f82c3753c7564600f2 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sat, 2 Feb

Re: [patch 0/5] Instrumentation Menu Removal

2008-02-02 Thread Sam Ravnborg
atch I picked this serie up in kbuild.git. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[REVIEW for merge] kbuild updates including silence of section mismatch check

2008-02-02 Thread Sam Ravnborg
.git. See below for more details and a combined patch. Individual patches will be sent to kbuild only (and no cc:) Sam Bryan Wu (1): kbuild: add svn revision information to setlocalversion Geert Uytterhoeven (1): kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATC

Re: Some fixes for "Section mismatch" errors.

2008-02-02 Thread Sam Ravnborg
our fix for this particular warning looks OK. But always do: -> One fix per patch -> Include the warning in the patch descript that you fix -> Explain why you fixed it the way you did it Without this info it is too time consuming to try to review your patch and I did nt look at the other chan

Re: SPI related Kconfig warning

2008-02-02 Thread Sam Ravnborg
> 'SPI_PXA2XX' refers to undefined symbol 'PXA_SSP' > > I was doing a build of a ppc kernel. I have now killed that warning. from kconfig. It has proved rather useless but annoying. Sam -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [REVIEW for merge] kbuild updates including silence of section mismatch check

2008-02-02 Thread Sam Ravnborg
Bryan this was from you - please comment/fix. Sam On Sat, Feb 02, 2008 at 10:25:51PM +0100, Frans Pop wrote: > Sam Ravnborg wrote: > > --- a/scripts/setlocalversion > > +++ b/scripts/setlocalversion > > @@ -45,3 +45,18 @@ if hgid=`hg id 2>/dev/null`; then >

Re: x86: fix arch/x86/kernel/test_nx.c modular build bug

2008-02-02 Thread Sam Ravnborg
ng 0b\n" > + " .long 2b\n" > +#else > " .quad 0b\n" > " .quad 2b\n" > +#endif This should have used _ASM_PTR from asm.h: #ifdef CONFIG_X86_32 /* 32 bits */ # define _ASM_PTR " .l

[Additional PATCH] kbuild: do not warn about __*init/__*exit symbols being exported

2008-02-02 Thread Sam Ravnborg
>From e01639fd02bcf0126fcdedd09536a060e2593f07 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sat, 2 Feb 2008 23:30:22 +0100 Subject: [PATCH] kbuild: do not warn about __*init/__*exit symbols being exported We have several legitimate uses where we export symbols

  1   2   3   4   5   6   7   8   9   10   >