Re: [PATCH v2 07/18] ceph: use ->invalidatepage() length argument

2013-02-05 Thread Sage Weil
On Tue, 5 Feb 2013, Lukas Czerner wrote: > ->invalidatepage() aop now accepts range to invalidate so we can make > use of it in ceph_invalidatepage(). > > Signed-off-by: Lukas Czerner > Cc: ceph-de...@vger.kernel.org Reviewed-by: Sage Weil > --- > fs/ceph/addr.c

Re: [PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type

2013-02-11 Thread Sage Weil
Acked-by: Sage Weil On Mon, 11 Feb 2013, Namjae Jeon wrote: > From: Namjae Jeon > > This patch is a follow up on below patch: > > [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type > commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63 > > Signed-off-b

[GIT PULL] Ceph updates for 3.9-rc1

2013-02-26 Thread Sage Weil
p for osd completions ceph: update "ceph_features.h" Cong Ding (1): libceph: fix undefined behavior when using snprintf() Jim Schutt (1): libceph: for chooseleaf rules, retry CRUSH map descent from root if leaf is failed Sage Weil (18): crush: avoid recursion if we hav

Re: [PATCH 143/193] fs/ceph: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Sage Weil
On Tue, 23 Oct 2012, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > CC: Sage Weil > Signed-off-by: Kees Cook Acked-by: Sage Weil -- To uns

Re: [PATCH 161/193] net/ceph: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Sage Weil
On Tue, 23 Oct 2012, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > CC: Sage Weil > CC: "David S. Miller" > Signed-off-by:

[GIT PULL] Ceph changes for 3.6

2012-07-31 Thread Sage Weil
of the device in sysfs rbd: set image size when header is updated rbd: use reference counting for the snap context rbd: send header version when notifying Sage Weil (40): libceph: use con get/put ops from osd_client libceph: drop connection refcounting for mon_cl

[GIT PULL] Ceph fixes for 3.6

2012-09-23 Thread Sage Weil
Hi Linus, Please pull the following fixes for Ceph from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus The first fixes a leak in the rbd setup error path, and the second fixes a more serious problem with mismatched kmap/kunmap that surfaced after the recent refa

[GIT PULL] Ceph fixes for -rc4

2012-10-29 Thread Sage Weil
the fs client code that is triggered by NFS reexport. Thanks! sage Alex Elder (1): rbd: reset BACKOFF if unable to re-queue David Zafman (1): ceph: fix dentry reference leak in encode_fh() Sage Weil (1

Re: [PATCH 3/5] ceph: use fscache as a local presisent cache

2013-08-26 Thread Sage Weil
On Wed, 21 Aug 2013, Milosz Tanski wrote: > Adding support for fscache to the Ceph filesystem. This would bring it to on > par with some of the other network filesystems in Linux (like NFS, AFS, > etc...) > > In order to mount the filesystem with fscache the 'fsc' mount option must be > passed. >

Re: linux-next: Tree for Aug 27 (ceph)

2013-08-27 Thread Sage Weil
On Tue, 27 Aug 2013, Randy Dunlap wrote: > On 08/27/13 03:30, Stephen Rothwell wrote: > > Hi all, > > > > I should know better than to take time off around -rc7 :-) > > > > Changes since 20130822: > > > > on i386: > > fs/built-in.o: In function `ceph_fallocate': > file.c:(.text+0x20b171): unde

Re: [PATCH v5] Ceph: Punch hole support for kernel client

2013-08-27 Thread Sage Weil
On Tue, 27 Aug 2013, Andrew Morton wrote: > On Thu, 15 Aug 2013 11:51:44 +0800 Li Wang wrote: > > > This patch implements fallocate and punch hole support for Ceph kernel > > client. > > i386 allmodconfig: > > ERROR: "__divdi3" [fs/ceph/ceph.ko] undefined! > make[1]: *** [__modpost] Error 1 >

[GIT PULL] Ceph updates for 3.11

2013-07-09 Thread Sage Weil
ix invalid unsigned->signed conversion for timespec encoding Sage Weil (1): rbd: fix a couple warnings Sasha Levin (1): ceph: avoid accessing invalid memory Tyler Hicks (1): libceph: Fix NULL pointer dereference in auth client code Yan, Zheng (12): libceph: fix sa

Re: linux-next: manual merge of the ceph tree with Linus' tree

2013-07-09 Thread Sage Weil
On Wed, 10 Jul 2013, Stephen Rothwell wrote: > Hi Sage, > > Today's linux-next merge of the ceph tree got conflicts in > drivers/block/rbd.c and net/ceph/osd_client.c because the ceph tree was > rebased before being sent to Linus and it looks like one patch > was dropped and several more added. >

[GIT PULL] Ceph fixes for 3.12-rc2

2013-09-19 Thread Sage Weil
Hi Linus, Please pull the following Ceph fixes for git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus These fix several bugs with RBD from 3.11 that didn't get tested in time for the merge window: some error handling, a use-after-free, and a sequencing issue when un

[GIT PULL] Ceph updates for 3.12 (part 1)

2013-09-04 Thread Sage Weil
ceph: remove useless variable revoked_rdcache Milosz Tanski (2): ceph: Remove bogus check in invalidatepage ceph: cleanup the logic in ceph_invalidatepage Nathaniel Yazdani (1): ceph: fix null pointer dereference Sage Weil (4): ceph: replace hold_mutex flag with goto

Re: [PATCHv4 0/5] ceph: persistent caching with fscache

2013-09-04 Thread Sage Weil
Hi David! On Wed, 4 Sep 2013, David Howells wrote: > Sage Weil wrote: > > > David, are the fscache patches here ready for the next merge window? Do > > you have a preference for whose tree they go through? > > There's only one problem - patch 1 needs to

Re: [PATCHv4 0/5] ceph: persistent caching with fscache

2013-09-04 Thread Sage Weil
On Wed, 4 Sep 2013, Sage Weil wrote: > Hi David! > > On Wed, 4 Sep 2013, David Howells wrote: > > Sage Weil wrote: > > > > > David, are the fscache patches here ready for the next merge window? Do > > > you have a preference for whose tree they go thr

Re: [PATCH 0/8] ceph: fscache support & upstream changes

2013-09-05 Thread Sage Weil
On Thu, 5 Sep 2013, Milosz Tanski wrote: > Hey gang I think this should be final revision of these changes. The changes > are: > > * David rewrote the cookie validity check (that originally was written by >Hongyi Jia). You might have seen some emails flying about doing it the >right way.

Re: [PATCH 0/8] ceph: fscache support & upstream changes

2013-09-06 Thread Sage Weil
On Fri, 6 Sep 2013, Milosz Tanski wrote: > Sage, > > I've taken David's latest changes and per his request merged his > 'fscache-fixes-for-ceph' tag then applied my changes on top of that. > In addition to the pervious changes I also added a fix for the > warnings the linux-next build bot found. >

[GIT PULL] Ceph updates for 3.12 (take 2)

2013-09-06 Thread Sage Weil
pointer dereference Sage Weil (4): ceph: replace hold_mutex flag with goto Merge remote-tracking branch 'linus/master' into testing ceph: fix fallocate division libceph: use pg_num_mask instead of pgp_num_mask for pg.seed calc Sha Zhengju (1): ceph: use

Re: [PATCH 0/8] ceph: fscache support & upstream changes

2013-09-09 Thread Sage Weil
On Mon, 9 Sep 2013, Milosz Tanski wrote: > David, > > I guess that's really a better question for Sage. He sent my branch > (which includes your changes) plus a whole slew of things over to > Linus. I'm going guess that a small follow on patch is simplest but > I'll let him comment. > > Here's th

Re: [PATCH] fscache: check consistency does not decrement refcount

2013-09-10 Thread Sage Weil
On Tue, 10 Sep 2013, Milosz Tanski wrote: > Sage, > > Can you submit to the upstream next in your next round of fixes (with > David's ack). Yep; it's in the queue. Thanks! sage > > Thanks, > - Milosz > > P.S: Thanks David. > > On Tue, Sep 10, 2013 at 8:34 AM, David Howells wrote: > > Milos

Re: linux-next: build failure after merge of the ceph tree

2013-09-25 Thread Sage Weil
On Thu, 26 Sep 2013, majianpeng wrote: > Sorry for that, i notice the commit 73a7075e3f6e.But i misread it. > I'll modify this as soon as possible. Thanks! For now I'll drop this patch and rebase the queue against 3.12-rc2. Thanks, Stephen! sage > > Thanks! > Jianpeng Ma > >Hi Sage, > > > >Af

Re: [PATCH] ceph: hung on ceph fscache invalidate in some cases

2013-09-25 Thread Sage Weil
Applied this to the ceph-client.git master branch. I'll send this upstream shortly after it gets some testing and/or any other fixes pile up. Thanks! sage On Wed, 25 Sep 2013, Milosz Tanski wrote: > In some cases I'm on my ceph client cluster I'm seeing hunk kernel tasks in > the invalidate

[GIT PULL] Ceph updates for -rc1

2012-10-06 Thread Sage Weil
rbd: get snapshot name for a v2 image rbd: update remaining header fields for v2 ceph: avoid 32-bit page index overflow Iulius Curt (1): libceph: Fix sparse warning Sage Weil (5): libceph: remove unused monc->have_fsid libceph: check for invalid mapping c

Re: vfs: oops on open_by_handle_at() in linux-next

2012-10-09 Thread Sage Weil
On Sun, 7 Oct 2012, Hugh Dickins wrote: > On Mon, 8 Oct 2012, Al Viro wrote: > > On Sun, Oct 07, 2012 at 08:32:51PM -0700, Hugh Dickins wrote: > > > Thank you, Sasha: this should fix it, and similar in other FSes. > > > > > > > > > [PATCH] tmpfs,ceph,gfs2,isofs,reiserfs,xfs: fix fh_len checking >

[GIT PULL] Ceph fixes for 3.8-rc2

2013-01-02 Thread Sage Weil
tocol feature bit failure path. Thanks! sage Alex Elder (3): libceph: move linger requests sooner in kick_requests() libceph: always reset osds when kicking libceph: WARN, don't BUG on unexpected connection states

[GIT PULL] Ceph updates for 3.8

2012-12-20 Thread Sage Weil
libceph: Unlock unprocessed pages in start_read() error path Joe Perches (1): bdi_register: add __printf verification, fix arg mismatch Sage Weil (4): libceph: avoid NULL kref_put from NULL alloc_msg return libceph: fix osdmap decode error paths ceph: Fix i_size update ra

Re: [GIT PULL] Ceph updates for 3.8

2012-12-21 Thread Sage Weil
On Fri, 21 Dec 2012, J. Bruce Fields wrote: > On Thu, Dec 20, 2012 at 01:29:49PM -0800, Sage Weil wrote: > > Hi Linus, > > > > Please pull the following Ceph updates for 3.8 from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git

Re: [PATCH RFC 03/12] userns: Convert ceph to use kuid/kgid where appropriate

2012-11-20 Thread Sage Weil
On Tue, 20 Nov 2012, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > Cc: Sage Weil > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman Acked-by: Sage Weil Do you want me to take this via the ceph tree? sage > --- > fs/ceph/caps.c |

[GIT PULL] Ceph fix for 3.9

2013-04-17 Thread Sage Weil
Hi Linus, Please pull this final ceph fix for 3.9 from: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus It's a simple fix for a hard to hit race, but low-risk and clearly correct. Thanks! sage Alex

Re: [PATCH 1/1] scripts/package/builddeb: build perftools package.

2013-04-17 Thread Sage Weil
On Tue, 26 Feb 2013, Michal Marek wrote: > Added Maximilian to CC. Hey- Did this get pulled in? We'd love to stop applying and maintaining this patch downstream. Thanks! sage > > Michal > > On 26.2.2013 02:30, Gary Lowell wrote: > > This will build a linux-tools-$version package for each b

Re: [PATCH -next] ceph: fix printk format warnings in file.c

2013-04-19 Thread Sage Weil
t argument 11 has type 'ssize_t' [-Wformat] > fs/ceph/file.c:762:2: warning: format '%ld' expects argument of type 'long > int', but argument 11 has type 'ssize_t' [-Wformat] > > Signed-off-by: Randy Dunlap > Cc: Sage Weil > Cc: ceph

Re: [PATCH v3 07/18] ceph: use ->invalidatepage() length argument

2013-04-23 Thread Sage Weil
On Tue, 9 Apr 2013, Lukas Czerner wrote: > ->invalidatepage() aop now accepts range to invalidate so we can make > use of it in ceph_invalidatepage(). > > Signed-off-by: Lukas Czerner > Cc: ceph-de...@vger.kernel.org Acked-by: Sage Weil > --- > fs/ceph/addr.c | 12

Re: [PATCH 0/2] Kernel file system client support for punch hole

2013-06-14 Thread Sage Weil
On Fri, 14 Jun 2013, Li Wang wrote: > This patch implements punch hole (fallocate) support for Ceph kernel > file system client. > We prepared two patches based on different kernel versions, one against > kernel 3.8-rc3, the other against the latest 3.10-rc5. It is because > unfortunately, we faile

Re: [PATCH 2/2] Punch hole support against 3.10-rc5

2013-06-14 Thread Sage Weil
On Fri, 14 Jun 2013, Li Wang wrote: > This patch implements punch hole (fallocate) support against > Linux kernel 3.10-rc5. > > Signed-off-by: Li Wang > Signed-off-by: Yunchuan Wen > --- > fs/ceph/file.c| 245 > + > net/ceph/osd_client.c

Re: linux-next: build warning after merge of the ceph tree

2013-06-17 Thread Sage Weil
, fixed. Thanks! sage On Mon, 17 Jun 2013, Stephen Rothwell wrote: > Hi Sage, > > After merging the ceph tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/block/rbd.c: In function 'rbd_release': > drivers/block/rbd.c:510:2: warning: 'return' with a valu

Re: [PATCH] ceph: fix sleeping function called from invalid context.

2013-06-18 Thread Sage Weil
On Tue, 18 Jun 2013, majianpeng wrote: > [ 1121.231883] BUG: sleeping function called from invalid context at > kernel/rwsem.c:20 > [ 1121.231935] in_atomic(): 1, irqs_disabled(): 0, pid: 9831, name: mv > [ 1121.231971] 1 lock held by mv/9831: > [ 1121.231973] #0: (&(&ci->i_ceph_lock)->rlock){+.

Re: [PATCH] rbd: remove RBD_DEBUG

2013-06-18 Thread Sage Weil
On Mon, 17 Jun 2013, Paul Bolle wrote: > The RBD_DEBUG macro is always defined, so it serves no purpose. > Removing it has the benefit that readers of the code won't be tricked > into thinking that rbd_assert() will compile away because they didn't > define RBD_DEBUG themselves. In the future we l

Re: [PATCH] rbd: silence GCC warnings

2013-06-18 Thread Sage Weil
This was already fixed up in teh testing branch; thanks! On Mon, 17 Jun 2013, Paul Bolle wrote: > Building rbd.o triggers two GCC warnings: > drivers/block/rbd.c: In function ?rbd_img_request_fill?: > drivers/block/rbd.c:1272:22: warning: ?bio_list? may be used > uninitialized in this fu

Re: Re: [PATCH] ceph: fix sleeping function called from invalid context.

2013-06-18 Thread Sage Weil
On Wed, 19 Jun 2013, majianpeng wrote: > >On Tue, 18 Jun 2013, majianpeng wrote: > >> [ 1121.231883] BUG: sleeping function called from invalid context at > >> kernel/rwsem.c:20 > >> [ 1121.231935] in_atomic(): 1, irqs_disabled(): 0, pid: 9831, name: mv > >> [ 1121.231971] 1 lock held by mv/9831:

[GIT PULL] Ceph fix for -rc7

2013-06-19 Thread Sage Weil
Hi Linus, Please pull the following patch for Ceph from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This fixes a problem preventing the kernel and userland librbd libraries from sharing data with the new format 2 images. Thanks! sage ---

Re: [PATCH V1] ceph: fix sleeping function called from invalid context.

2013-06-19 Thread Sage Weil
Applied, thanks! On Wed, 19 Jun 2013, majianpeng wrote: > [ 1121.231883] BUG: sleeping function called from invalid context at > kernel/rwsem.c:20 > [ 1121.231935] in_atomic(): 1, irqs_disabled(): 0, pid: 9831, name: mv > [ 1121.231971] 1 lock held by mv/9831: > [ 1121.231973] #0: > (&(&ci->

Re: [PATCH] ceph: avoid meaningless calling ceph_caps_revoking if sync_mode == WB_SYNC_ALL.

2013-06-19 Thread Sage Weil
Applied, thanks! sage On Wed, 19 Jun 2013, majianpeng wrote: > Signed-off-by: Jianpeng Ma > --- > fs/ceph/addr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 3e68ac1..25fa8b8 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/

Re: [PATCH v2] Ceph: Punch hole support

2013-06-19 Thread Sage Weil
Hi Li, There is a version of fsx.c floating around that tests hole punching... have you tried running that on top of this patch? Ideally, we should build a test (ceph.git/qa/workunits/rbd/hole_punch.sh or similar) that tests the hole punch both with a default file layout and with a more compl

Re: [PATCH] ceph: remove sb_start/end_write in ceph_aio_write.

2013-06-23 Thread Sage Weil
Thanks everyone, pushed this to the testing branch. sage On Sun, 23 Jun 2013, Yan, Zheng wrote: > On Mon, Jun 17, 2013 at 10:19 PM, majianpeng wrote: > > > > Either in vfs_write or io_submit,it call file_start/end_write. > > The different between file_start/end_write and sb_start/end_write is >

Re: [PATCH] libceph: Call con->ops->put(con) if cancel_delayed_work(&con->work) worked.

2013-06-23 Thread Sage Weil
On Mon, 24 Jun 2013, majianpeng wrote: > Because in func queue_con_delay, it will call con->ops->get(con). > So if we cancel the work successfully,we must call con->ops->put(con). > Otherwise some resource can't free like 'struct ceph_mds_session'. > > Signed-off-by: Jianpeng Ma Looks good, appl

[GIT PULL] Ceph fix for 3.10

2013-06-25 Thread Sage Weil
Hi Linus, Plesae pull the following patch from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This fixes another problem with using v2 images on 3.10 due to the order in which fields are read from the image header. Hopefully this is the last one. Thanks! sage

Re: [PATCH] ceph: Reconstruct the func ceph_reserve_caps.

2013-06-25 Thread Sage Weil
looks good, applied to the testing branch. thanks! sage On Wed, 26 Jun 2013, majianpeng wrote: > Signed-off-by: Jianpeng Ma > --- > fs/ceph/caps.c | 21 +++-- > fs/ceph/super.h | 2 +- > 2 files changed, 8 insertions(+), 15 deletions(-) > > diff --git a/fs/ceph/caps.c b/fs/

[GIT PULL] Ceph fixes for -rc6

2013-06-11 Thread Sage Weil
Hi Linus, Please pull the following fixes for Ceph from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus There is a pair of fixes for double-frees in the recent bundle for 3.10, a couple of fixes for long-standing bugs (sleep while atomic and an endianness fix), a

Re: [PATCH] ceph: avoid accessing invalid memory

2013-07-01 Thread Sage Weil
On Mon, 1 Jul 2013, Sasha Levin wrote: > when mounting ceph with a dev name that starts with a slash, ceph > would attempt to access the character before that slash. Since we > don't actually own that byte of memory, we would trigger an > invalid access: > > [ 43.499934] BUG: unable to handle ke

[PATCH] scripts/package/builddeb: build perftools package

2013-07-01 Thread Sage Weil
This will build a linux-tools-$version package for each build that includes perf. Signed-off-by: Gary Lowell --- scripts/package/builddeb | 95 +- 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/scripts/package/builddeb b/scripts/packag

Re: [PATCH 1/3] mds: update atime if client can read.

2013-07-02 Thread Sage Weil
On Tue, 2 Jul 2013, majianpeng wrote: > Now, update atime only for CEPH_CAP_FILE_EXCL.Change this if > CEPH_CAP_FILE_RD. Can we introduce a global config optoin (bool mds_atime in common/config_opts.h, maybe) so that users can turn this off? And/or add a 'relatime' option? More users won't wan

Re: [PATCH 2/3] ceph: update atime after read-operation.

2013-07-02 Thread Sage Weil
On Tue, 2 Jul 2013, majianpeng wrote: > Now ceph don't support updating atime after read-operation if the open > mode is CEPH_CAP_FILE_RD.There are two reasons: > 1:in client of fs,it don't set dirty cap of CEPH_CAP_FILE_RD. > 2:in mds,it only update the atime if the condition > "dirty & (CEPH_CAP_

[GIT PULL] Ceph fix for 3.10

2013-06-28 Thread Sage Weil
Hi Linus, Please pull the following patch from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This is a recently spotted regression in the snapshot behavior it turns out several tests weren't being run in the nightlies so this took a while to spot. Thanks!

Re: [PATCH v5] Ceph: Punch hole support for kernel client

2013-08-15 Thread Sage Weil
I've applied this to the testing branch and moved to the better fsx in the qa suite. The ceph-fuse patches are still in wip-fallocate until I can run the fs test suite against them. Thanks! sage On Thu, 15 Aug 2013, Li Wang wrote: > This patch implements fallocate and punch hole support for

Re: [PATCH] ceph: fix null pointer dereference

2013-08-04 Thread Sage Weil
Looks right, applied to the testing branch. Thanks! sage On Sun, 4 Aug 2013, Nathaniel Yazdani wrote: > When register_session() is given an out-of-range argument for mds, > ceph_mdsmap_get_addr() will return a null pointer, which would be given to > ceph_con_open() & be dereferenced, caus

Re: [PATCHv4 0/5] ceph: persistent caching with fscache

2013-08-21 Thread Sage Weil
Hi Milosz, I've pulled this into the ceph testing branch to make sure it holds up in qa. David, are the fscache patches here ready for the next merge window? Do you have a preference for whose tree they go through? Thanks! sage On Wed, 21 Aug 2013, Milosz Tanski wrote: > This an updated ve

[GIT PULL] Ceph fixes for -rc2

2013-05-14 Thread Sage Weil
Hi Linus, Please pull the following patches from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus Yes, this is a much larger pull than I would like after -rc1. There are a few things included: - a few fixes for leaks and incorrect assertions - a few patches fix

Re: [PATCH v2 2/3] ceph: add missing cpu_to_le32() calls when encoding a reconnect capability

2013-05-15 Thread Sage Weil
On Wed, 15 May 2013, Alex Elder wrote: > On 05/15/2013 11:38 AM, Jim Schutt wrote: > > In his review, Alex Elder mentioned that he hadn't checked that > > num_fcntl_locks > > and num_flock_locks were properly decoded on the server side, from a le32 > > over-the-wire type to a cpu type. I checked,

[GIT PULL] Ceph changes for 3.10

2013-05-06 Thread Sage Weil
uffer pointer advance in ceph_sync_write Laurent Barbe (1): rbd: revalidate_disk upon rbd resize Randy Dunlap (1): ceph: fix printk format warnings in file.c Sage Weil (7): ceph: revert commit 22cddde104 libceph: implement RECONNECT_SEQ feature libceph: clear messenger

Re: [PATCH] ceph: improve error handling in ceph_mdsmap_decode

2013-05-28 Thread Sage Weil
Applied to ceph tree; thanks! On Tue, 28 May 2013, Emil Goode wrote: > This patch makes the following improvements to the error handling > in the ceph_mdsmap_decode function: > > - Add a NULL check for return value from kcalloc > - Make use of the variable err > > Signed-off-by: Emil Goode > -

[GIT PULL] Ceph fix for -rc5

2013-03-29 Thread Sage Weil
Hi Linus, Please pull the following patch from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This fixes a regression introduced during the last merge window when mapping non-existent images. Thanks! sage ---

[GIT PULL] Ceph fix for -rc3

2013-03-11 Thread Sage Weil
Sage Weil (1): libceph: fix decoding of pgids net/ceph/osdmap.c | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[GIT PULL] Final ceph bits for 3.6

2012-08-02 Thread Sage Weil
crypto keys. Thanks! sage Sage Weil (1): ceph: simplify+fix atomic_open Sylvain Munaut (1): libceph: fix crypto key null deref, memory leak fs/ceph/dir.c | 38 fs/ceph/file.c

[GIT PULL] Ceph fixes for 3.6-rc3

2012-08-22 Thread Sage Weil
sage Jim Schutt (1): libceph: avoid truncation due to racing banners Sage Weil (3): libceph: delay debugfs initialization until we learn global_id ceph: tolerate (and warn on) extraneous dentry from mds ceph: avoid divide by ze

regression with poll(2)?

2012-08-15 Thread Sage Weil
I'm experiencing a stall with Ceph daemons communicating over TCP that occurs reliably with 3.6-rc1 (and linus/master) but not 3.5. The basic situation is: - the socket is two processes communicating over TCP on the same host, e.g. tcp0 2164849 10.214.132.38:6801 10.214.132.38:5

Re: regression with poll(2)?

2012-08-15 Thread Sage Weil
On Wed, 15 Aug 2012, Atchley, Scott wrote: > On Aug 15, 2012, at 3:46 PM, Sage Weil wrote: > > > I'm experiencing a stall with Ceph daemons communicating over TCP that > > occurs reliably with 3.6-rc1 (and linus/master) but not 3.5. The basic > > situation is:

Re: regression with poll(2)

2012-08-19 Thread Sage Weil
to help track this down? Thanks! sage On Wed, 15 Aug 2012, Sage Weil wrote: > I'm experiencing a stall with Ceph daemons communicating over TCP that > occurs reliably with 3.6-rc1 (and linus/master) but not 3.5. The basic > situation is: > > - the socket is two proce

Re: regression with poll(2)

2012-08-20 Thread Sage Weil
On Mon, 20 Aug 2012, Mel Gorman wrote: > On Sun, Aug 19, 2012 at 11:49:31AM -0700, Sage Weil wrote: > > I've bisected and identified this commit: > > > > netvm: propagate page->pfmemalloc to skb > > > > The skb->pfmemalloc flag get

[ANNOUNCE] Ceph distributed file system

2007-11-12 Thread Sage Weil
Hi everyone, Ceph is a distributed network file system designed to provide excellent performance, reliability, and scalability with POSIX semantics. I periodically see frustration on this list with the lack of a scalable GPL distributed file system with sufficiently robust replication and fail

Re: Linux Foundation Technical Advisory Board Elections and Nomination process

2015-10-13 Thread Sage Weil
On Tue, 13 Oct 2015, Grant Likely wrote: > On 11 Oct 2015 05:20, "Ric Wheeler" wrote: > > > > I would like to nominate Sage Weil with his consent. > > > > Sage has lead the ceph project since its inception, contributed to the > kernel as well as had

[GIT PULL] Ceph fixes for -rc6

2015-10-16 Thread Sage Weil
Hi Linus, The following changes since commit 25cb62b76430a91cc6195f902e61c2cb84ade622: Linux 4.3-rc5 (2015-10-11 11:09:45 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus for you to fetch changes up to e30b7577bf1d3

[GIT PULL] Ceph updates for -rc7

2015-10-23 Thread Sage Weil
Hi Linus, Please pull the following two patches from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus One is a stopgap to prevent a stack blowout when users have a deep chain of image clones. (We'll rewrite this code to be non-recursive for the next window, but i

[GIT PULL] Ceph fixes for -rc4

2015-01-08 Thread Sage Weil
Hi Linus, Please pull the following Ceph fixes from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client for-linus These are both pretty trivial: a sparse warning fix and size_t printk thing. Thanks! sage Ilya Dryomo

[GIT PULL] Ceph fixes for -rc7

2015-01-28 Thread Sage Weil
Hi Linus, Please pull the following two patches from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus These paches from Ilya finally squash a race condition with layered images that he's been chasing for a while. Thanks! sage -

Re: randconfig build error with next-20150421, in net/ceph

2015-04-21 Thread Sage Weil
On Tue, 21 Apr 2015, Guenter Roeck wrote: > On Tue, Apr 21, 2015 at 08:10:44AM -0700, Jim Davis wrote: > > Building with the attached random configuration file, > > > > ERROR: "__divdi3" [net/ceph/libceph.ko] undefined! > > Commit 7321f19d ("crush: straw2 bucket type with an efficient 64-bit > c

[GIT PULL] Ceph updates for 4.1-rc1

2015-04-22 Thread Sage Weil
Hi Linux, Please pull the following Ceph updates from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This time around we have a collection of CephFS fixes from Zheng around MDS failure handling and snapshots, support for a new CRUSH straw2 algorithm (to sync up

[GIT PULL] Ceph fix for -rc8

2015-04-07 Thread Sage Weil
Hi Linus, Please pull the following patch from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This corrects a recent misadventure with __GFP_MEMALLOC and PF_MEMALLOC; it turns out it's not a good fit for RBD and we're better off relying on dirty page throttling.

[GIT PULL] Ceph fixes for 3.5

2012-07-19 Thread Sage Weil
minor bug fixes. Thanks! sage Dan Carpenter (1): rbd: endian bug in rbd_req_cb() Sage Weil (1): libceph: fix messenger retry Yan, Zheng (1): rbd: Fix ceph_snap_context size calculation drivers/block/rbd.c

Re: [PATCH] ceph: Update the pages in fscache in writepages() path

2013-11-05 Thread Sage Weil
On Tue, 5 Nov 2013, Milosz Tanski wrote: > Li, > > First, sorry for the late reply on this. > > Currently fscache is only supported for files that are open in read > only mode. I originally was going to let fscache cache in the write > path as well as long as the file was open in with O_LAZY. I a

Re: [PATCH 0/3] Ceph fscache: Fix kernel panic due to a race

2014-03-06 Thread Sage Weil
Hi Milosz, Thanks, I've added this to the testing branch! sage On Mon, 3 Mar 2014, Milosz Tanski wrote: > Hey guys, I'm terribly sorry but apparently this got stuck in my draft > mailbox for 3 months. Since we've been running this on both our test / > prod clusters I would say this is sufficie

[GIT PULL] Ceph updates

2014-04-07 Thread Sage Weil
PRIMARY_AFFINITY feature bit libceph: output primary affinity values on osdmap updates libceph: dump pool {read,write}_tier to debugfs Sage Weil (4): ceph: avoid useless ceph_get_dentry_parent_inode() in ceph_rename() ceph: do not chain inode updates to parent fsync ceph

[GIT PULL] Ceph updates and fixes for 3.13

2013-11-23 Thread Sage Weil
Hi Linus, I just returned from two weeks off the grid to discover I'd miscalculated and just missed the merge window. If you're feeling inclined, there are a few non-fixes mixed into this this request (improved readv/writev, nicer behavior for unlinked files) that can be pulled from here: g

[GIT PULL] Ceph fixes for 3.13-rc5

2013-12-15 Thread Sage Weil
Hi Linus, Please pull the following pair of Ceph fixes from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus One of these is fixing a regression from the d_flags file type patch that went into -rc1 that broke instantiation of inodes and dentries (we were doing den

[GIT PULL] Ceph fixes for 3.17-rc5

2014-09-11 Thread Sage Weil
Sage Weil (1): libceph: gracefully handle large reply messages from the mon Wei Yongjun (1): rbd: fix error return code in rbd_dev_device_setup() drivers/block/rbd.c | 6 +- net/ceph/auth_x.c | 256 ++ net/ceph/mon_client.c

[GIT PULL] Ceph fixes for -rc6

2014-05-16 Thread Sage Weil
Hi Linus, Please pull the following Ceph fixes from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus The first patch fixes a problem when we have a page count of 0 for sendpage which is triggered by zfs. The second fixes a bug in CRUSH that was resolved in the us

[GIT PULL] Ceph fixes for -rc4

2014-02-17 Thread Sage Weil
by the Chinese holiday.) There is also a small fix for cached readdir handling when directories are fragmented. Thanks! sage Guangliang Zhao (1): ceph: make ceph_forget_all_cached_acls() static inline Sage Weil (1

Re: [PATCH] rbd: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2014-04-11 Thread Sage Weil
Applied, thanks! sage On Fri, 11 Apr 2014, Yan, Zheng wrote: > On Fri, Apr 11, 2014 at 4:38 PM, Duan Jiong wrote: > > This patch fixes coccinelle error regarding usage of IS_ERR and > > PTR_ERR instead of PTR_ERR_OR_ZERO. > > > > Signed-off-by: Duan Jiong > > --- > > drivers/block/rbd.c | 2 +

Re: [PATCH 1/1 RESEND] fs/ceph/inode.c: Remove get/set acl on symlinks

2014-03-21 Thread Sage Weil
We've pulled this into the Ceph tree. Thanks, Fabian! sage On Fri, 21 Mar 2014, Fabian Frederick wrote: > Remove unsupported symlink operations. > > Signed-off-by: Fabian Frederick > --- > fs/ceph/inode.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ceph/inode.c b/fs/ceph/in

[GIT PULL] Ceph changes for 3.16-rc1

2014-06-12 Thread Sage Weil
sd_request memory leak in __rbd_dev_header_watch_sync() rbd: fix ida/idr memory leak Josh Durgin (2): rbd: move calls that may sleep out of spin lock range rbd: only set disk to read-only once Sage Weil (1): ceph: include time stamp in every MDS request Yan, Zheng (8):

[GIT PULL] Ceph fix for 3.14

2014-03-29 Thread Sage Weil
Hi Linus, Please full a Ceph RBD fix from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This drops a bad assert that a few users have been hitting but we've only recently been able to track down. Thanks! sage -

[GIT PULL] Ceph fixes for -rc5

2014-05-05 Thread Sage Weil
Hi Linus, Please pull the following Ceph fixes from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus First, there is a critical fix for the new primary-affinity function that went into -rc1. The second batch of patches from Zheng fix a range of problems with dire

Re: [PATCH] ceph: fix corruption when using page_count 0 page in rbd

2014-05-06 Thread Sage Weil
neously free the > > page. > > > > This type of issue has been noted before, and handled in iscsi, drbd, > > etc. So, rbd should also handle this. This fix address this issue by fall > > back > > to slower sendmsg when page_count 0 detected. > > >

[GIT PULL] Ceph fix for -rc4

2014-06-25 Thread Sage Weil
Hi Linus, Please pull the following patch for Ceph from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This fixes a corner case for cloned RBD images. Thanks! sage Ilya Dryomov (1): rbd: hand

[GIT PULL] Ceph updates for -rc1

2014-01-28 Thread Sage Weil
Hi Linus, Please pull the following Ceph updates from git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus This is a big batch. From Ilya we have: - rbd support for more than ~250 mapped devices (now uses same scheme that SCSI does for device major/minor numberin

Re: [GIT PULL] Ceph updates for -rc1

2014-01-28 Thread Sage Weil
Hi Linus, On Tue, 28 Jan 2014, Linus Torvalds wrote: > On Tue, Jan 28, 2014 at 1:10 PM, Dave Jones wrote: > > > > This breaks the build for me. > > It is my merge (Christoph's ACL changes came in today through the VFS > tree from Al). > > I was doing the merges today on my laptop (I had jury du

Re: [GIT PULL] Ceph updates for -rc1

2014-01-29 Thread Sage Weil
On Tue, 28 Jan 2014, Sage Weil wrote: > Hi Linus, > > On Tue, 28 Jan 2014, Linus Torvalds wrote: > > On Tue, Jan 28, 2014 at 1:10 PM, Dave Jones wrote: > > > > > > This breaks the build for me. > > > > It is my merge (Christoph's ACL chan

Re: [PATCH v2] ceph: fix posix ACL hooks

2014-01-30 Thread Sage Weil
On Thu, 30 Jan 2014, Linus Torvalds wrote: > On Wed, Jan 29, 2014 at 11:54 PM, Christoph Hellwig > wrote: > > > > For ->set_acl that's fairly easily doable and I actually had a version > > doing that to be able to convert 9p. But for ->get_acl the path walking > > caller didn't seem easily feasi

Re: [PATCH] fs: ceph: new helper: file_inode(file)

2013-12-10 Thread Sage Weil
Applied, thanks! On Wed, 11 Dec 2013, Libo Chen wrote: > > Signed-off-by: Libo Chen > --- > fs/ceph/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index 3de8982..7549bd6 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @

  1   2   >