Re: [PATCH 152/193] fs/nilfs2: remove CONFIG_EXPERIMENTAL

>This config item has not carried much meaning for a while now and is >almost always enabled by default. As agreed during the Linux kernel >summit, remove it. > >CC: KONISHI Ryusuke >Signed-off-by: Kees Cook Point taken, thank you. Acked-by: Ryusuke Konishi Ryusuke Konishi

Re: [PATCH v5 11/12] nilfs2: replace direct access of d_count with the d_count() helper

thing should just work. > > Signed-off-by: Waiman Long Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi > --- > fs/nilfs2/super.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c > index c7d1f9f.

Re: [PATCH 0/9] [RFC v2] safely drop directory dentry on failed revalidate

lso pointless - in that case we have no children at all > and shrink_dcache_parent() will return immediately. This also looks true. I will confirm whether we can remove the pre-check for d_count == 1 case. Regards, Ryusuke Konishi -- From: Ryusuke Konishi Date: Thu, 22 Aug 2013 01:53:03 +09

Re: [PATCH 0/9] [RFC v2] safely drop directory dentry on failed revalidate

On Wed, 21 Aug 2013 22:00:38 +0100, Al Viro wrote: > On Thu, Aug 22, 2013 at 05:04:59AM +0900, Ryusuke Konishi wrote: >> On Wed, 21 Aug 2013 06:40:56 +0100, Al Viro wrote: >> >And I would like to understand what nilfs one is trying to do... >> > Unless I'm seri

Re: [PATCH 18/25] userns: Convert nillfs2 to use kuid/kgid where appropriate

1 - > 2 files changed, 4 insertions(+), 5 deletions(-) Looks good to me, thanks. Acked-by: Ryusuke Konishi Ryusuke Konishi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [PATCH] nilfs2: fix very long mount time issue

time. > > REPRODUCIBILITY: 100% > > FIX: > This patch adds checking that superblocks need to update and set > THE_NILFS_DISCONTINUED flag before nilfs_clean_segments() call. > > Reported-by: Sergey Alexandrov > Signed-off-by: Vyacheslav Dubeyko > Tested-by: Vyacheslav Dubeyko Acked-

Re: [PATCH] nilfs2: fix very long mount time issue

>On Sun, 13 Jan 2013 16:07:23 +0900 (JST) >Ryusuke Konishi wrote: > >> On Sat, 12 Jan 2013 19:34:48 +0400, Vyacheslav Dubeyko wrote: >> > From: Vyacheslav Dubeyko >> > Subject: [PATCH] nilfs2: fix very long mount time issue >> > >> > DESCRI

Re: [BUG] problem with nfs_invalidate_page

urns, the request (=nfs_page) associated with the page becomes a garbage in nfs_inode->nfs_page_tree. This causes the collision of nfs_page and yields the BUG. Cheers, Ryusuke Konishi > >On Fri, 2007-08-24 at 16:43 +0900, Ryusuke Konishi wrote: >> Hi, >> >> I got the fo

Re: [BUG] problem with nfs_invalidate_page

at was a fairly significant change in semantics... > >Anyhow, well done debugging it! Does the following patch fix the Oops? > >Trond Yes, the patch did fix the Oops crash. I've tested it in serveral ways, and it's working well enough so far. Thanks! Ryusuke Konishi >On

[PATCH] NFS: fix /proc/sys oops after module removal

similar at the first glance, but written properly. Signed-off-by: Ryusuke Konishi <[EMAIL PROTECTED]> --- fs/nfs/super.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index b2a851c..e784310 100644 --- a/fs/nfs/super.c +++ b/

Re: [PATCH] fs/nilfs2: Convert timers to use timer_setup()

x27;s target task, as the lifetime of sc_task doesn't appear to > match the timer's task. > > Cc: Ryusuke Konishi > Cc: linux-ni...@vger.kernel.org > Signed-off-by: Kees Cook Looks good. Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi > --- > fs/nilfs2/segmen

[PATCH 1/4] nilfs2: Fix race condition that causes file system corruption

overwrites millions of 4k files. Signed-off-by: Andreas Rohner Signed-off-by: Ryusuke Konishi Tested-by: Andreas Rohner Tested-by: Ryusuke Konishi Cc: sta...@vger.kernel.org --- fs/nilfs2/segment.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2/segment.c b

[PATCH 2/4] fs, nilfs: convert nilfs_root.count from atomic_t to refcount_t

ff-by: Ryusuke Konishi --- fs/nilfs2/the_nilfs.c | 8 fs/nilfs2/the_nilfs.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index 2dd75bf..afebb50 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c @@ -737,7 +

[PATCH 4/4] nilfs2: use octal for unreadable permission macro

Replace S_IRWXUGO with 0777 because symbolic permissions are considered harmful: https://lwn.net/Articles/696229/ Signed-off-by: Ryusuke Konishi --- fs/nilfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 515d13c

[PATCH 3/4] nilfs2: align block comments of nilfs_sufile_truncate_range() at *

Fix the following checkpatch warning: WARNING: Block comments should align the * on each line #633: FILE: sufile.c:633: +/** + * nilfs_sufile_truncate_range - truncate range of segment array Signed-off-by: Ryusuke Konishi --- fs/nilfs2/sufile.c | 32 1

[PATCH 0/4] nilfs2 updates

Hi Andrew, Please queue the following changes for the next merge window: Andreas Rohner (1): nilfs2: Fix race condition that causes file system corruption Elena Reshetova (1): fs, nilfs: convert nilfs_root.count from atomic_t to refcount_t Ryusuke Konishi (2): nilfs2: align

Re: [PATCH] nilfs2: remove inode->i_version initialization

On Mon, 30 Oct 2017 11:17:02 -0400, Jeff Layton wrote: > From: Jeff Layton > > It's never used in nilfs2. > > Signed-off-by: Jeff Layton > --- Applied, thank you. Ryusuke Konishi > fs/nilfs2/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --

[PATCH 0/5] nilfs2: introduce tracepoints

nilfs2: add tracepoints for analyzing reading and writing metadata files Ryusuke Konishi (1): MAINTAINERS: nilfs2: add header file for tracing These introduces some tracepoints to nilfs2 to help tracking its behavior for bottleneck detection, debugging, etc. Thanks, Ryusuke Konishi

[PATCH 5/5] MAINTAINERS: nilfs2: add header file for tracing

This adds header file "include/trace/events/nilfs2.h" to maintainer-ship of nilfs2 so that updates to the nilfs2 header file go to the mailing list of nilfs2. Signed-off-by: Ryusuke Konishi Cc: Hitoshi Mitake --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAI

[PATCH 1/5] nilfs2: add a tracepoint for tracking stage transition of segment construction

trace event in a correct manner. Signed-off-by: Hitoshi Mitake Signed-off-by: Ryusuke Konishi Cc: Steven Rostedt --- fs/nilfs2/segment.c | 71 +++ fs/nilfs2/segment.h | 3 +- include/trace/events/nilfs2.h | 50

[PATCH 4/5] nilfs2: add tracepoints for analyzing reading and writing metadata files

= 253 Cc: TK Kato Signed-off-by: Hitoshi Mitake Signed-off-by: Ryusuke Konishi Cc: Steven Rostedt --- fs/nilfs2/mdt.c | 6 + include/trace/events/nilfs2.h | 54 +++ 2 files changed, 60 insertions(+) diff --git a/fs/nilfs2/mdt.c b/fs

[PATCH 3/5] nilfs2: add tracepoints for analyzing sufile manipulation

-17800 [002] ...1 10675.073477: nilfs2_segment_usage_allocated: sufile = 880054f908a8 segnum = 3 Cc: Benixon Dhas Cc: TK Kato Signed-off-by: Hitoshi Mitake Signed-off-by: Ryusuke Konishi Cc: Steven Rostedt --- fs/nilfs2/sufile.c| 8 ++ include/trace/events/nilfs2.h | 67

[PATCH 2/5] nilfs2: add a tracepoint for transaction events

trivial cleaning of comma usage in collection stage transition event for consistent coding style. Signed-off-by: Hitoshi Mitake Signed-off-by: Ryusuke Konishi Cc: Steven Rostedt --- fs/nilfs2/segment.c | 33 ++- include/trace/events/nilfs2.h | 53

Re: [PATCH v2] vfs: remove unused wrapper block_page_mkwrite()

> block_page_mkwrite() and update the comment above block_page_mkwrite(). > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Jan Kara > Cc: Christoph Hellwig > Cc: Al Viro Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi > --- > fs/buffer.c

[PATCH] fs: nilfs2: Adding new return type vm_fault_t

From: Souptick Joarder Use new return type vm_fault_t for page_mkwrite handler. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Signed-off-by: Ryusuke Konishi --- fs/nilfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/file.c b/fs/nilfs2

Re: [PATCH] fs: Convert return type int to vm_fault_t

lfs_near_disk_full(inode->i_sb->s_fs_info))) > return VM_FAULT_SIGBUS; /* -ENOSPC */ > @@ -67,7 +68,7 @@ static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf) > if (page->mapping != inode->i_mapping || > page_offset(page) >= i_size_rea

[PATCH] nilfs2: convert to SPDX license tags

Remove the verbose license text from NILFS2 files and replace them with SPDX tags. This does not change the license of any of the code. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 11 +-- fs/nilfs2/alloc.h | 11 +-- fs/nilfs2/bmap.c | 11 +-- fs

Re: [PATCH] nilfs2: use time64_t internally

tent and correct on both 32-bit > and 64-bit machines. > > The on-disk format already uses 64-bit timestamps, so nothing changes > there. > > Signed-off-by: Arnd Bergmann Thank you for this patch. Acked-by: Ryusuke Konishi > --- > fs/nilfs2/segbuf.c| 2 +- >

[PATCH] MAINTAINERS, nilfs2: change project home URLs

ttps. Signed-off-by: Ryusuke Konishi --- Documentation/filesystems/nilfs2.txt | 4 ++-- MAINTAINERS | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/filesystems/nilfs2.txt b/Documentation/filesystems/nilfs2.txt index c0727dc..f2f3f85 100644

Re: [PATCH] nilfs2: fix potential use after free

Hi, Pan Bian Thank you for feeding back this patch. I reviewed this and am thinking this must be sent to upstream. Did you see any kernel oops on this bug ? Regards, Ryusuke Konishi On Mon, 26 Nov 2018 11:08:29 +0800, Pan Bian wrote: > brelse(bh) is called to drop the reference count of

[PATCH] fs/nilfs2: fix misspellings using codespell tool

From: Liu xuzhi Two typos are found out by codespell tool \ in 2217th and 2254th lines of segment.c: $ codespell ./fs/nilfs2/ ./segment.c:2217 :retured ==> returned ./segment.c:2254: retured ==> returned Fix two typos found by codespell. Signed-off-by: Liu xuzhi Signed-off-by: R

Re: [PATCH] fs/nilfs2: fix misspellings using codespell tool

Hi Andrew, Please queue this typo fix for the next merge window. Thank you, Ryusuke Konishi On Thu, Apr 8, 2021 at 3:41 PM Ryusuke Konishi wrote: > > From: Liu xuzhi > > Two typos are found out by codespell tool \ > in 2217th and 2254th lines of segment.c: > > $

Re: [PATCH -next] nilfs2: Fix typos in comments

Hi, This patch partially overlaps the following fix that I previously sent to Andrew: https://lkml.org/lkml/2021/4/8/114 Can you exclude two typo fixes of "retured -> returned" from yours ? Thanks, Ryusuke Konishi On Thu, Apr 8, 2021 at 11:08 PM Lu Jialin wrote: > > nu

Re: [PATCH v2 -next] nilfs2: Fix typos in comments

Thank you. Will apply this. Ryusuke Konishi On Fri, Apr 9, 2021 at 11:25 AM Lu Jialin wrote: > > numer -> number in fs/nilfs2/cpfile.c > Decription -> Description in fs/nilfs2/ioctl.c > isntance -> instance in fs/nilfs2/the_nilfs.c > > Signed-off-by: Lu Jialin >

[PATCH] nilfs2: Fix typos in comments

From: Lu Jialin numer -> number in fs/nilfs2/cpfile.c Decription -> Description in fs/nilfs2/ioctl.c isntance -> instance in fs/nilfs2/the_nilfs.c Signed-off-by: Lu Jialin Link: https://lore.kernel.org/r/20210409022519.176988-1-lujial...@huawei.com Signed-off-by: Ryusuke Konishi

Re: [PATCH] nilfs2: Fix typos in comments

Hi Andrew, Please also queue this typo fix patch that came separately. Thanks, Ryusuke Konishi On Fri, Apr 9, 2021 at 1:35 PM Ryusuke Konishi wrote: > > From: Lu Jialin > > numer -> number in fs/nilfs2/cpfile.c > Decription -> Description in fs/nilfs2/ioctl.c > is

[PATCH] eCryptfs: fix possible fault in ecryptfs_sync_page

They may fail when an eCryptfs page is waiting for lock. Signed-off-by: Ryusuke Konishi <[EMAIL PROTECTED]> --- fs/ecryptfs/mmap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/ecryptfs/mmap.c b/fs/ecryptfs/mmap.c index e4ab7bc..fd3f94d 100644 --- a/fs/ecry

Re: [Ecryptfs-devel] [PATCH] eCryptfs: fix possible fault in ecryptfs_sync_page

nk? Though I'm currenty focussing on eCryptfs in mainline, I'd like to shift my focus to the new one if it's preferable. Regards, Ryusuke Konishi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majo

[BUG] problem with nfs_invaildate_page

if=/dev/zero of=/secret/aaa bs=4096 count=1 These procedures do truncate an unwritten NFS page. Note that overwritting without use of eCryptfs doesn't reproduce the problem because it calls nfs_setattr() and forces the pages to be written back. Cheers, Ryusuke Konishi - To unsubscribe from th

[PATCH] nilfs2: fix gcc warning at nilfs_checkpoint_is_mounted()

ing indicates that the comparision "cno < 0" is useless because variable "cno" has an unsigned integer type "__u64". Reported-by: David Binderman Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 1/2] nilfs2: put out gfp mask manipulation from nilfs_set_inode_flags()

Signed-off-by: Ryusuke Konishi --- fs/nilfs2/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index cf9e489..0c28ccb 100644 --- a/fs/nilfs2/inode.c +++ b/fs/nilfs2/inode.c @@ -456,8 +456,6 @@ void nilfs_set_inode_flags(struct

[PATCH 2/2] nilfs2: use inode_set_flags() in nilfs_set_inode_flags()

to commit 5f16f3225b06 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()"). Signed-off-by: Ryusuke Konishi Cc: "Theodore Ts'o" --- fs/nilfs2/inode.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/nilfs2/inode

[PATCH 0/2] nilfs2: fix issues with nilfs_set_inode_flags()

Hi Andrew, Please queue the following changes for the next merge window: Ryusuke Konishi (2): nilfs2: put out gfp mask manipulation from nilfs_set_inode_flags() nilfs2: use inode_set_flags() in nilfs_set_inode_flags() These fix issues related to nilfs_set_inode_flags() function

[PATCH] nilfs2: fix sanity check of btree level in nilfs_btree_root_broken()

_LEVEL_MAX is exclusive. Signed-off-by: Ryusuke Konishi Cc: --- fs/nilfs2/btree.c | 2 +- include/linux/nilfs2_fs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c index 059f371..919fd5b 100644 --- a/fs/nilfs2/btree.c +++ b

[PATCH 0/4] some nilfs2 fixes

Hi Andrew, Please apply the following patches and send them upstream via the -mm tree at the next merge window. This patchset is composed of two comment fixes and two ioctl-related fixes in which one is for a deadlock issue and another for a potential timing issue. Thanks, Ryusuke Konishi

[PATCH 1/4] nilfs2: add omitted comment for ns_mount_state field of the_nilfs structure

From: Vyacheslav Dubeyko This patch adds omitted comment for ns_mount_state field of the_nilfs structure. Signed-off-by: Vyacheslav Dubeyko Signed-off-by: Ryusuke Konishi --- fs/nilfs2/the_nilfs.h |1 + 1 file changed, 1 insertion(+) diff --git a/fs/nilfs2/the_nilfs.h b/fs/nilfs2

[PATCH 2/4] NILFS2: remove references to long gone super operations

From: Fernando Luis Vazquez Cao ->delete_inode(), ->write_super_lockfs(), ->unlockfs() are gone so remove refereces to them in the NTFS code. Noticed while cleaning up the fsfreeze mess. Signed-off-by: Fernando Luis Vazquez Cao Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super

[PATCH 4/4] nilfs2: fix deadlock issue between chcp and thaw ioctls

s and the downgrade of snapshots to checkpoints exclusive. This fixes the deadlock issue by replacing the sb->s_umount usage in nilfs_ioctl_change_cpmode() with a dedicated mutex which protects snapshot mounts. Signed-off-by: Ryusuke Konishi Tested-by: Ryusuke Konishi Cc: --- fs/nilfs2/ioctl.

[PATCH 3/4] nilfs2: fix timing issue between rmcp and chcp ioctls

by an existing semaphore. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/cpfile.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/nilfs2/cpfile.c b/fs/nilfs2/cpfile.c index dab5c4c..deaa3d3 100644 --- a/fs/nilfs2/cpfile.c +++ b/fs/nilfs2/cpfile.c @@ -286,7 +286,7 @

[PATCH 1/2] NILFS2: add omitted comments for structures in nilfs2_fs.h

From: Vyacheslav Dubeyko This patch adds omitted comments for structures in nilfs2_fs.h. Signed-off-by: Vyacheslav Dubeyko Signed-off-by: Ryusuke Konishi --- include/linux/nilfs2_fs.h | 63 - 1 file changed, 39 insertions(+), 24 deletions

[PATCH 0/2] two more nilfs2 patches

Hi Andrew, Please apply the following two patches and send them upstream at the upcoming merge window, along with the previous patchset. These add missing comments on structures in nilfs2. Thanks, Ryusuke Konishi -- Vyacheslav Dubeyko (2): NILFS2: add omitted comments for structures in

[PATCH 2/2] NILFS2: add omitted comments for different structures in driver implementation

From: Vyacheslav Dubeyko This patch adds omitted comments for different structures in driver implementation. [modified so as to comply with kernel-doc data structure comment] Signed-off-by: Vyacheslav Dubeyko Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.h | 14 +++--- fs

[PATCH 0/1] NILFS2: support NFSv2 export

Hi Andrew, please queue the following patch for the next merge window. It fixes an NFSv2 related issue reported in: [1] http://marc.info/?l=linux-fsdevel&m=143104630128997 "[PATCH 0/3] make BTRFS, UDF, NILFS2 work with NFSv2." Thanks, Ryusuke Konishi -- NeilBrown (1): N

[PATCH 1/1] NILFS2: support NFSv2 export

me value, not exactly equal to it. Signed-off-by: NeilBrown Signed-off-by: Ryusuke Konishi --- fs/nilfs2/namei.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 2218083..37dd6b0 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/name

Re: NILFS2: double uuid

NT sda └─sda1 nilfs29dcd01c0-2bc8-41bf-a400-8ad8755aac6a $ lsblk --version lsblk from util-linux 2.23.2 $ lscp -V lscp (nilfs-utils 2.2.3) $ rpm -q libblkid util-linux libblkid-2.23.2-22.el7_1.x86_64 util-linux-2.23.2-22.el7_1.x86_64 $ uname -r 4.1.0-rc7 Regards, Ryusuke Konishi -- To uns

Re: NILFS2: double uuid

didn't reproduce the issue. On my CentOS 7 environment, lsblk and default mount are perfectly working. So, it may be a version dependent issue of util-linux. I will try to reproduce and nallow down the issue with newer util-linux packages. Thanks, Ryusuke Konishi -- To unsubscribe from

Re: NILFS2: double uuid

ckup super block should be dropped from candidates if its device size (sbp->s_dev_size) doesn't match the partition size. Regards, Ryusuke Konishi On Mon, 08 Jun 2015 19:31:51 +0900, Ryusuke Konishi wrote: > Hi, > > On 2015/06/08 19:08, Heinz Diehl wrote: >> On 08.06.20

Re: NILFS2: double uuid

Hi, On 2015/06/09 17:53, Karel Zak wrote: On Tue, Jun 09, 2015 at 12:31:27AM +0900, Ryusuke Konishi wrote: It looks like the backup super block should be dropped from candidates if its device size (sbp->s_dev_size) doesn't match the partition size. Yeah, fixed: http://git.kernel.

Re: NILFS2: double uuid

On Tue, 9 Jun 2015 16:07:42 +0200, Karel Zak wrote: > On Tue, Jun 09, 2015 at 10:04:15PM +0900, Ryusuke Konishi wrote: >> $ sudo nilfs-resize -y /dev/sdb1 1G >> Partition size = 2146435072 bytes. >> Shrink the filesystem size from 2146435072 bytes to 1073741824 bytes. &g

Re: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 in nilfs_segctor_do_co

advance. To ensure inode_attach_wb() is called, mark_buffer_dirty() should be called for those buffers. The following patch fixes this issue, but I got another oops at nilfs_segctor_complete_write() during a stress test. So, I'm still investigating. Regards, Ryusuke Konishi === diff --git

Re: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 in nilfs_segctor_do_co

> Wondering if it can be reproduced on mainline with c3aab9a0bd91 > ("mm/filemap.c: dont initiate writeback if mapping has no dirty pages") > reverted? For mainline kernels with that commit reverted, this oops actually doesn't occur. Regards, Ryusuke Konishi On Mon,

Re: [PATCH] fs/nilfs2: fix misspellings using codespell tool

Applied, thank you. Ryusuke Konishi On Thu, Mar 18, 2021 at 8:32 PM wrote: > > From: Liu xuzhi > > Two typos are found out by codespell tool \ > in 2217th and 2254th lines of segment.c: > > $ codespell ./fs/nilfs2/ > ./segment.c:2217 :retured ==> returned

Re: KASAN: use-after-free in nilfs_mdt_destroy

Hi, I haven't yet succeeded to reproduce the issue with the attached program. How reproducible is it in your environment? (Does it take a long time to reproduce ?) Regards, Ryusuke Konishi On Mon, Mar 22, 2021 at 6:05 PM butt3rflyh4ck wrote: > > Hi, guy, I reported a bug found b

[PATCH] fs/nilfs2: remove some unused macros to tame gcc

ent.c:143:0: warning: macro "nilfs_cnt32_lt" is not used [-Wunused-macros] Signed-off-by: Alex Shi Signed-off-by: Ryusuke Konishi --- fs/nilfs2/segment.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index e3726aca28ed..cd4da9535aed 10

Re: [PATCH] fs/nilfs2: remove some unused macros to tame gcc

Hi Andrew, Please queue this, a gcc warning fix, for the next merge window. Thanks, Ryusuke Konishi On Thu, Dec 10, 2020 at 7:25 AM Ryusuke Konishi wrote: > > From: Alex Shi > > There some macros are unused and cause gcc warning. Remove them. > > fs/nilfs2/segment.c:137

[PATCH] nilfs2: make splice write available again

to restore the functionality. Signed-off-by: Joachim Henke Signed-off-by: Ryusuke Konishi Tested-by: Ryusuke Konishi Cc: sta...@vger.kernel.org # 5.10+ --- fs/nilfs2/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nilfs2/file.c b/fs/nilfs2/file.c index 64bc81363c6c..e1bd592ce700 100644

Re: [PATCH] nilfs2: make splice write available again

Hi Andrew, Please send this to upstream. This fixes a regression of splice() on nilfs2. Thanks, Ryusuke Konishi On Mon, Feb 8, 2021 at 8:35 PM Ryusuke Konishi wrote: > > From: Joachim Henke > > Since 5.10, splice() or sendfile() to NILFS2 return EINVAL. This was > c

[PATCH 3/3] nilfs2: verify metadata sizes read from disk

ss to metadata or memory access overrun on metadata block buffers due to overflow in sundry calculations. Both lower limit and upper limit of metadata sizes are verified to prevent these issues. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/cpfile.c| 12 fs/nilfs2/

[PATCH 2/3] nilfs2: add FITRIM ioctl support for nilfs2

From: Andreas Rohner This patch adds support for the FITRIM ioctl, which enables user space tools to issue TRIM/DISCARD requests to the underlying device. Every clean segment within the specified range will be discarded. Signed-off-by: Andreas Rohner Signed-off-by: Ryusuke Konishi --- fs

[PATCH 1/3] nilfs2: add nilfs_sufile_trim_fs to trim clean segs

: Ryusuke Konishi --- fs/nilfs2/sufile.c | 152 fs/nilfs2/sufile.h |1 + 2 files changed, 153 insertions(+) diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c index 5628b99..84e384d 100644 --- a/fs/nilfs2/sufile.c +++ b/fs/nilfs2/sufile.c

[PATCH 0/3] nilfs2 additional updates

;Re: [PATCH 3/4] nilfs2: add nilfs_sufile_set_suinfo to update segment usage" Thanks in advance, Ryusuke Konishi -- Andreas Rohner (2): nilfs2: add nilfs_sufile_trim_fs to trim clean segs nilfs2: add FITRIM ioctl support for nilfs2 Ryusuke Konishi (1): nilfs2: verify metadata sizes re

[PATCH 2/2] nilfs2: update project's web site in nilfs2.txt

Project's web site was moved to nilfs.sourceforge.net from www.nilfs.org. This updates the site information in Documentation/filesystems/nilfs2.txt with the new location. Signed-off-by: Ryusuke Konishi --- Documentation/filesystems/nilfs2.txt |5 ++--- 1 file changed, 2 insertions(

[PATCH 1/2] nilfs2: update MAINTAINERS file entries fix

Also, web-page entry is updated according to relocation of project's web site. Signed-off-by: Ryusuke Konishi --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 971dcb7..c4ef32c 100644 --- a/MAINTAINERS +++ b/MAINTA

[PATCH 0/2] nilfs2: update web site information

pdate MAINTAINERS file entries" (to make folding it into the original patch easy). Thanks, Ryusuke Konishi -- Ryusuke Konishi (2): nilfs2: update MAINTAINERS file entries fix nilfs2: update project's web site in nilfs2.txt Documentation/filesystems/nilfs2.txt |5 ++-

[PATCH] nilfs2: fix data loss with mmap()

written to disk. This patch fixes the problem by also calling nilfs_set_file_dirty() if the page has no buffers attached to it. Signed-off-by: Andreas Rohner Tested-by: Andreas Rohner Signed-off-by: Ryusuke Konishi Cc: --- fs/nilfs2/inode.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) d

[PATCH 0/1] nilfs2: fix data loss with mmap()

not perfect and causing reproducible silent data loss issue. Thanks in advance, Ryusuke Konishi -- Andreas Rohner (1): nilfs2: fix data loss with mmap() fs/nilfs2/inode.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] nilfs2: fix data loss with mmap()

On Thu, 18 Sep 2014 12:17:08 -0700, Andrew Morton wrote: > On Thu, 18 Sep 2014 23:56:25 +0900 Ryusuke Konishi > wrote: > >> From: Andreas Rohner >> >> This bug leads to reproducible silent data loss, despite the use of >> msync(), sync() and a clean unmount

[PATCH 0/1] nilfs2: improve the performance of fdatasync()

change of the various timestamps. Andreas Rohner fixed this issue by discerning these situations properly. Thanks, Ryusuke Konishi -- Andreas Rohner (1): nilfs2: improve the performance of fdatasync() fs/nilfs2/inode.c | 13 +++-- fs/nilfs2/nilfs.h | 14 +++--- fs

[PATCH 1/1] nilfs2: improve the performance of fdatasync()

y: Andreas Rohner Signed-off-by: Ryusuke Konishi --- fs/nilfs2/inode.c | 13 +++-- fs/nilfs2/nilfs.h | 14 +++--- fs/nilfs2/segment.c |4 ++-- 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index 9e3c525..f276fe1 10064

[PATCH 0/1] nilfs2: fix device cache flush in nilfs_sync_fs()

written. The original cover letter can be seen at: [1] http://marc.info/?l=linux-nilfs&m=141061909728506 "[PATCH v6 0/1] nilfs2: add missing blkdev_issue_flush() to nilfs_sync_fs()" Thanks, Ryusuke Konishi -- Andreas Rohner (1): nilfs2: add missing blkdev_is

[PATCH] nilfs2: add missing blkdev_issue_flush() to nilfs_sync_fs()

are written and set whenever the block device is flushed. For convenience the function nilfs_flush_device() is added, which contains the above logic. Signed-off-by: Andreas Rohner Signed-off-by: Ryusuke Konishi --- fs/nilfs2/file.c |8 +++- fs/nilfs2/ioctl.c |8 +++- fs/nil

[PATCH 1/4] nilfs2: update MAINTAINERS file entries

Update git repository entry of nilfs2 file system and maintainer's email description. Signed-off-by: Ryusuke Konishi --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2cf5cf..342caaa 100644 --- a/MAINTAINERS

[PATCH 2/4] nilfs2: add struct nilfs_suinfo_update and flags

From: Andreas Rohner This patch adds the nilfs_suinfo_update structure, which contains the information needed to update one segment usage entry. The flags specify, which fields need to be updated. Signed-off-by: Andreas Rohner Signed-off-by: Ryusuke Konishi --- include/linux/nilfs2_fs.h

[PATCH 3/4] nilfs2: add nilfs_sufile_set_suinfo to update segment usage

-by: Andreas Rohner Signed-off-by: Ryusuke Konishi --- fs/nilfs2/sufile.c | 131 fs/nilfs2/sufile.h |1 + 2 files changed, 132 insertions(+) diff --git a/fs/nilfs2/sufile.c b/fs/nilfs2/sufile.c index 3127e9f..c37b5f0 100644 --- a/fs

[PATCH 4/4] nilfs2: implementation of NILFS_IOCTL_SET_SUINFO ioctl

d-off-by: Ryusuke Konishi --- fs/nilfs2/ioctl.c | 92 + include/linux/nilfs2_fs.h |2 + 2 files changed, 94 insertions(+) diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index 2b34021..c19a231 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/n

[PATCH 0/4] nilfs2 updates

userland counterpart is not yet finished, but this kernel patchset is ready for merge, I think. My additional patch updates entries of nilfs2 file system in MAINTAINERS file (independently). Thanks in advance, Ryusuke Konishi -- Andreas Rohner (3): nilfs2: add struct nilfs_suinfo_update

Re: [PATCH 4/4] nilfs2: implementation of NILFS_IOCTL_SET_SUINFO ioctl

On Mon, 3 Feb 2014 13:41:01 -0800, Andrew Morton wrote: > On Tue, 4 Feb 2014 01:50:44 +0900 Ryusuke Konishi > wrote: > >> With this ioctl the segment usage entries in the SUFILE can be >> updated from userspace. >> >> This is useful, because it allows the

[PATCH] nilfs2: add description of NILFS_IOCTL_SET_SUINFO ioctl

Add description of NILFS_IOCTL_SET_SUINFO ioctl in Documentation/filesystems/nilfs2.txt to make it up-to-date. Signed-off-by: Ryusuke Konishi Cc: Andreas Rohner --- Documentation/filesystems/nilfs2.txt |7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/filesystems

Re: [PATCH 3/4] nilfs2: add nilfs_sufile_set_suinfo to update segment usage

On Mon, 3 Feb 2014 13:38:18 -0800, Andrew Morton wrote: > On Tue, 4 Feb 2014 01:50:43 +0900 Ryusuke Konishi > wrote: > >> From: Andreas Rohner >> >> This patch introduces the nilfs_sufile_set_suinfo function, which >> expects an array of nilfs_suinfo_

Re: [PATCH 3/4] nilfs2: add nilfs_sufile_set_suinfo to update segment usage

On Wed, 05 Feb 2014 01:41:37 +0900 (JST), Ryusuke Konishi wrote: > On Mon, 3 Feb 2014 13:38:18 -0800, Andrew Morton wrote: >> On Tue, 4 Feb 2014 01:50:43 +0900 Ryusuke Konishi >> wrote: >> >>> From: Andreas Rohner >>> >>> This patch introd

[PATCH 03/11] nilfs2: remove FSF mailing address from GPL notices

This removes the extra paragraph which mentions FSF address in GPL notices from source code of nilfs2 and avoids the checkpatch.pl error related to it. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 4 fs/nilfs2/alloc.h | 4 fs/nilfs2/bmap.c | 4

[PATCH 11/11] nilfs2: clean trailing semicolons in macros

Remove trailing semicolons from macros, as suggested by checkpatch.pl. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/sysfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nilfs2/sysfs.h b/fs/nilfs2/sysfs.h index 677e3a1..648cedf 100644 --- a/fs/nilfs2/sysfs.h +++ b

[PATCH 10/11] nilfs2: add missing line spacing

Clean up checkpatch.pl warnings "WARNING: Missing a blank line after declarations" from nilfs2. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/cpfile.c| 2 ++ fs/nilfs2/dir.c | 2 ++ fs/nilfs2/ifile.h | 1 + fs/nilfs2/inode.c | 1 + fs/nilfs2/namei.c | 1 +

[PATCH 06/11] nilfs2: clarify permission to replicate the design

To respond to a certain developer's request, this explicitly state that developers can reimplement the nilfs2 design for other operating systems to share data stored in that format. Signed-off-by: Ryusuke Konishi --- Documentation/filesystems/nilfs2.txt | 5 + 1 file changed, 5 inser

[PATCH 09/11] nilfs2: replace __attribute__((packed)) with __packed

This fixes the following checkpatch.pl warning: WARNING: __packed is preferred over __attribute__((packed)) #23: FILE: export.h:23: +} __attribute__ ((packed)); Signed-off-by: Ryusuke Konishi --- fs/nilfs2/export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCH 07/11] nilfs2: get rid of nilfs_mdt_mark_block_dirty()

nilfs_mdt_mark_block_dirty() can be replaced with primary functions like nilfs_mdt_get_block() and mark_buffer_dirty(), and it's used only by nilfs_ioctl_mark_blocks_dirty(). This gets rid of the function to simplify the interface of metadata file. Signed-off-by: Ryusuke Konishi --- fs/n

[PATCH 00/11] nilfs2 updates

Hi Andrew, Please queue the following changes for the next merge window: Ryusuke Konishi (11): nilfs2: fix white space issue in nilfs_mount() nilfs2: remove space before comma nilfs2: remove FSF mailing address from GPL notices nilfs2: clean up old e-mail addresses

[PATCH 04/11] nilfs2: clean up old e-mail addresses

E-mail addresses of osrg.net domain are no longer available. This removes them from authorship notices and prevents reporters from being confused. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 5 ++--- fs/nilfs2/alloc.h | 5 ++--- fs/nilfs2/bmap.c | 2 +- fs

[PATCH 02/11] nilfs2: remove space before comma

Fix checkpatch.pl error "ERROR: space prohibited before that ',' (ctx:WxW)" at nilfs_sufile_set_suinfo(). This also fixes checkpatch.pl warning "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'" at nilfs_sufile_set_suinfo() and nilfs_su

[PATCH 08/11] nilfs2: move cleanup code of metadata file from inode routines

Refactor nilfs_clear_inode() and nilfs_i_callback() so that cleanup code or resource deallocation related to metadata file will be moved out to mdt.c. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/inode.c | 5 ++--- fs/nilfs2/mdt.c | 25 + fs/nilfs2/mdt.h | 8

  1   2   3   >