Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-06 Thread Roy Pledge
>> struct dpaa2_io { >> atomic_t refs; >> >> That's a kref, please use it instead of trying to roll your own. >> >> And even for this, your locking is not correct (i.e. you do not have >> any), that needs to be fixed so that teardown works correctly. > > I think we can drop this refcount

[PATCH v2 0/4] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-23 Thread Roy Pledge
staging directory. Horia Geantă (1): staging: fsl-dpaa2/eth: move generic FD defines to DPIO Roy Pledge (3): staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl drivers/staging: Remove fsl-mc driver from staging drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

[PATCH v2 1/4] staging: fsl-dpaa2/eth: move generic FD defines to DPIO

2018-07-23 Thread Roy Pledge
From: Horia Geantă Previous commits: commit 6e2387e8f19e ("staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver") commit 39163c0ce0f4 ("staging: fsl-dpaa2/eth: Errors checking update") have added bits that are not specific to the WRIOP accelerator. Move these where they belong (in DPIO)

[PATCH v2 2/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-23 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

[PATCH v2 3/4] drivers/staging: Remove fsl-mc driver from staging

2018-07-23 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH v2 4/4] drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

2018-07-23 Thread Roy Pledge
Convert the Datapath I/O documentation to .rst format and move to the Documation/networking/dpaa2 directory Signed-off-by: Roy Pledge --- .../networking/dpaa2/dpio-driver.rst | 30 +++--- Documentation/networking/dpaa2/index.rst | 1 + 2 files changed

[PATCH v3 3/4] drivers/staging: Remove fsl-mc driver from staging

2018-07-24 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH v3 0/4] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-24 Thread Roy Pledge
staging directory. Horia Geantă (1): staging: fsl-dpaa2/eth: move generic FD defines to DPIO Roy Pledge (3): staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl drivers/staging: Remove fsl-mc driver from staging drivers/soc/fsl/dpio: Convert DPIO documentation to .rst .../networking

[PATCH v3 1/4] staging: fsl-dpaa2/eth: move generic FD defines to DPIO

2018-07-24 Thread Roy Pledge
From: Horia Geantă Previous commits: commit 6e2387e8f19e ("staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver") commit 39163c0ce0f4 ("staging: fsl-dpaa2/eth: Errors checking update") have added bits that are not specific to the WRIOP accelerator. Move these where they belong (in DPIO)

[PATCH v3 4/4] drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

2018-07-24 Thread Roy Pledge
Convert the Datapath I/O documentation to .rst format and move to the Documation/networking/dpaa2 directory Signed-off-by: Roy Pledge --- .../networking/dpaa2/dpio-driver.rst | 29 +++--- Documentation/networking/dpaa2/index.rst | 1 + 2 files changed

[PATCH v3 2/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-24 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

Re: [PATCH v2 4/4] drivers/soc/fsl/dpio: Convert DPIO documentation to .rst

2018-07-24 Thread Roy Pledge
On 7/24/2018 9:52 AM, Horia Geanta wrote: > On 7/23/2018 8:00 PM, Roy Pledge wrote: >> Convert the Datapath I/O documentation to .rst format >> and move to the Documation/networking/dpaa2 directory > typo: ^^^ Documentation > >> Signed-off-by: Roy Pledge

Re: [PATCH 1/2] staging: fsl-mc/dpio: Add dpaa2_io_service_select() API

2018-01-05 Thread Roy Pledge
h > @@ -88,6 +88,8 @@ void dpaa2_io_down(struct dpaa2_io *d); > > irqreturn_t dpaa2_io_irq(struct dpaa2_io *obj); > > +struct dpaa2_io *dpaa2_io_service_select(int cpu); > + > /** >* struct dpaa2_io_notification_ctx - The DPIO notification context > structure >* @cb: The callback to be invoked when the notification arrives > Acked-by: Roy Pledge

[PATCH] soc/fsl/qbman: Check if CPU is offline when initializing portals

2018-01-29 Thread Roy Pledge
If the affine portal for a specific CPU is offline at boot time affine its interrupt to CPU 0. If the CPU is later brought online the hotplug handler will correctly adjust the affinity. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman.c | 17 + drivers/soc/fsl/qbman

[PATCH] arm64: dts: Add DPAA QBMan portal 9

2018-01-29 Thread Roy Pledge
ARM DPAA1 (LS1043 and LS1046) have 10 QBMan portals (indexed 0-9) Enable the one that is missing in the device trees. Signed-off-by: Roy Pledge --- arch/arm64/boot/dts/freescale/qoriq-bman-portals.dtsi | 6 ++ arch/arm64/boot/dts/freescale/qoriq-qman-portals.dtsi | 7 +++ 2 files

[PATCH] staging: fsl-mc/dpio: Add missing argument identifier

2018-03-07 Thread Roy Pledge
When running checkpatch over the DPIO code the following warning is reported: WARNING: function definition argument 'struct dpaa2_io_notification_ctx *' should also have an identifier name Add the missing identifier. Signed-off-by: Roy Pledge --- drivers/staging/fsl-mc/include/dpaa

[PATCH v3 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-26 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

[PATCH v3 0/4] drives/soc/fsl: Move DPIO driver out of staging

2018-03-26 Thread Roy Pledge
staging. Changes in v3: - Update caam files that use dpaa2 frame header files - Fix spare errors and memory leak - Remove empty staging/drivers/fsl-mc directory Changes in v2: - Fix minor conflict in latest linux-next branch - Generate patch using -M Roy

[PATCH v3 1/4] drivers/staging/fsl-mc: Use memremap for DPIO cache enabled area

2018-03-26 Thread Roy Pledge
Change the mapping of the QBMan cache enabled area from using ioremap_wc() to memremap(). This allows the __iomem attribute to be removed from the pointer (which makes sense as accesses try this as cacheable memory not IO memory). These changes allow sparse checks to pass. Signed-off-by: Roy

[PATCH v3 4/4] drivers/staging: Remove fsl-mc driver from staging

2018-03-26 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-26 Thread Roy Pledge
The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure. Signed-off-by: Roy Pledge --- drivers/staging

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Roy Pledge
On 3/27/2018 7:05 AM, Robin Murphy wrote: > Hi Roy, > > On 26/03/18 20:05, Roy Pledge wrote: >> The error path in the dpaa2_dpio_probe() function was not properly >> unmapping the QBMan device memory on the error path. This was also >> missing from the dpaa2_dpio_rel

[v2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-21 Thread Roy Pledge
-off-by: Roy Pledge --- Changes in v2: - Fix minor conflict in latest linux-next branch - Generate patch using -M so patch is smaller --- MAINTAINERS| 2 +- drivers/soc/fsl/Makefile

Re: [PATCH 0/2] soc: fsl: dpio: cleanup on the remove path

2018-11-12 Thread Roy Pledge
pumask to identify which cpus are unused > > drivers/soc/fsl/dpio/dpio-driver.c | 25 - > drivers/soc/fsl/dpio/dpio-service.c | 11 +++ > include/soc/fsl/dpaa2-io.h | 2 ++ > 3 files changed, 29 insertions(+), 9 deletions(-) > Reviewed-by: Roy Pledge

Re: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-09 Thread Roy Pledge
On 7/9/2018 6:37 AM, Laurentiu Tudor wrote: > Hi Roy, > > Couple of comments inline. > > On 05.07.2018 22:41, Roy Pledge wrote: >> Move the NXP DPIO (Datapath I/O Driver) out of the >> drivers/staging directory and into the drivers/soc/fsl directory. >> >>

[PATCH 1/2] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-07-05 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

[PATCH 0/2] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-05 Thread Roy Pledge
staging directory. Roy Pledge (2): staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl drivers/staging: Remove fsl-mc driver from staging MAINTAINERS | 2 +- drivers/crypto/caam/sg_sw_qm2.h | 2 +- drivers/crypto

[PATCH 2/2] drivers/staging: Remove fsl-mc driver from staging

2018-07-05 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

Re: [PATCH 0/2] staging/fsl-mc/bus: Move DPIO from staging to drivers/soc/fsl

2018-07-06 Thread Roy Pledge
On 7/6/2018 8:25 AM, Horia Geanta wrote: > On 7/5/2018 10:41 PM, Roy Pledge wrote: >> Move the NXP DPIO (Datapath I/O driver) from the staging/fsl-mc/bus/dpio >> directory to the drivers/soc/fsl directory. >> >> The DPIO driver enables access to the Queue and Buffer Ma

[PATCH v1 2/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2018-10-30 Thread Roy Pledge
when appropriate HW support is detected. Signed-off-by: Youri Querry Signed-off-by: Roy Pledge --- drivers/soc/fsl/dpio/dpio-driver.c | 23 -- drivers/soc/fsl/dpio/qbman-portal.c | 148 ++-- drivers/soc/fsl/dpio/qbman-portal.h | 5 ++ 3 files changed, 144

[PATCH v1 1/2] bus: mc-bus: Add support for mapping shareable portals

2018-10-30 Thread Roy Pledge
portal memory. The new portal region is identified as shareable through the addition of a new flag. Signed-off-by: Roy Pledge --- drivers/bus/fsl-mc/dprc.c | 3 ++- drivers/bus/fsl-mc/fsl-mc-bus.c | 14 -- drivers/bus/fsl-mc/fsl-mc-private.h | 17 ++--- 3

[PATCH v1 0/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2018-10-30 Thread Roy Pledge
thout needing manual cache manipulations by the CPU. The patches add support for the new portal attributes in the fsl-mc bus drivers as well as modifying the QBMan driver to use the new portal read trigger mechanism. Roy Pledge (2): bus: mc-bus: Add support for mapping shareable portals soc: fsl:

[PATCH v4 3/4] staging:fsl-mc: Move DPIO from staging to drivers/soc/fsl

2018-03-27 Thread Roy Pledge
-off-by: Roy Pledge --- MAINTAINERS| 2 +- drivers/crypto/caam/sg_sw_qm2.h| 2 +- drivers/crypto/caam/sg_sw_sec4.h | 2 +- drivers/soc/fsl/Kconfig

[PATCH v4 1/4] drivers/staging/fsl-mc: Use devm_memremap/devm_ioremap for DPIO

2018-03-27 Thread Roy Pledge
devm_ioremap() for the cache inhibited area so unmap occurs automatically when the device is released. Signed-off-by: Roy Pledge --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 19 +++ drivers/staging/fsl-mc/bus/dpio/qbman-portal.h | 4 ++-- drivers/staging/fsl-mc/include/dpaa2

[PATCH v4 0/4] drives/soc/fsl: Move DPIO driver out of staging

2018-03-27 Thread Roy Pledge
staging/drivers/fsl-mc directory Changes in v2: - Fix minor conflict in latest linux-next branch - Generate patch using -M Roy Pledge (4): drivers/staging/fsl-mc: Use devm_memremap/devm_ioremap for DPIO drivers/staging/fsl-mc: Fix DPIO error path issue staging:fsl-mc: Move

[PATCH v4 4/4] drivers/staging: Remove fsl-mc driver from staging

2018-03-27 Thread Roy Pledge
Remove the staging/drivers/fsl-mc directory from the staging area now that all the components have been moved to the main kernel areas. Signed-off-by: Roy Pledge --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile| 1 - drivers/staging/fsl-mc/Kconfig | 2

[PATCH v4 2/4] drivers/staging/fsl-mc: Fix DPIO error path issue

2018-03-27 Thread Roy Pledge
Remove unneeded call to dev_set_drvdata(dev, NULL) since the device will be deallocated in any case. Signed-off-by: Roy Pledge --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-driver.c

of_reserved_mem()/kexec interaction

2019-04-01 Thread Roy Pledge
Hi Rob, Not sure if you're the right person to address this to but if not hopefully someone on the list can assist me. I'm trying to understand if memory reserved in the device tree via the "reserved-memory" facility is preserved during a kexec system call, i.e., is the memory at the same locatio

[PATCH 01/11] powerpc: re-add devm_ioremap_prot()

2015-07-09 Thread Roy Pledge
From: Emil Medve devm_ioremap_prot() was removed in commit dedd24a12, and was introduced in commit b41e5fffe8. This reverts commit dedd24a12fe6735898feeb06184ee346907abb5d. Signed-off-by: Emil Medve --- arch/powerpc/include/asm/io.h |3 +++ arch/powerpc/lib/Makefile |1 + arch/pow

[PATCH 09/11] soc/bman: Add HOTPLUG_CPU support to the BMan driver

2015-07-09 Thread Roy Pledge
From: Hai-Ying Wang Add support for CPU hotplug for the DPAA 1.0 Buffer Manager driver Signed-off-by: Hai-Ying Wang Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman_portal.c | 40 +++ drivers/soc/fsl/qbman/dpaa_sys.h

[PATCH 08/11] soc/qman: Add debugfs support for the QMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add debugfs sypport for querying the state of hardware based queues managed by the DPAA 1.0 Queue Manager. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/Kconfig|7

[PATCH 11/11] soc/qman: add qman_delete_cgr_safe()

2015-07-09 Thread Roy Pledge
From: Madalin Bucur Add qman_delete_cgr_safe() that can be called from any CPU. This in turn schedules qman_delete_cgr() on the proper CPU. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman_api.c | 46 ++ 1 file

[PATCH 00/11] Freescale DPAA QBMan Drivers

2015-07-09 Thread Roy Pledge
The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and the accelerators. The

[PATCH 05/11] soc/bman: Add self-tester for BMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add a self test for the DPAA 1.0 Buffer Manager driver. This test ensures that the driver can properly acquire and release buffers using the BMan portal infrastructure. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl

[PATCH 10/11] soc/qman: Add HOTPLUG_CPU support to the QMan driver

2015-07-09 Thread Roy Pledge
From: Hai-Ying Wang Add support for CPU hotplug for the DPAA 1.0 Queue Manager driver. Signed-off-by: Hai-Ying Wang Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman_portal.c | 43 +++ 1 file changed, 43 insertions(+) diff

[PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-09 Thread Roy Pledge
-off-by: Roy Pledge --- drivers/soc/Kconfig |1 + drivers/soc/Makefile |1 + drivers/soc/fsl/Kconfig |5 + drivers/soc/fsl/Makefile |3 + drivers/soc/fsl/qbman/Kconfig | 33 +++ drivers/soc/fsl/qbman/Makefile|1 + drivers

[PATCH 00/11] Freescale DPAA QBMan Drivers

2015-07-09 Thread Roy Pledge
The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and the accelerators. The

[PATCH 03/11] soc/fsl: Introduce the DPAA BMan portal driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add support for Freescale DPAA 1.0 Buffer Manager portals. These portals allow software drivers for accelerators connected to the datapath to manage the hardware buffer pools. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc

[PATCH 07/11] soc/bman: Add debugfs support for the BMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add debugfs support for querying the state of hardware based Buffer Manager pools used in DPAA 1.0. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/Kconfig|7 ++ drivers/soc/fsl/qbman/Makefile

[PATCH 06/11] soc/qman: Add self-tester for QMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add a self test for the DPAA 1.0 Queue Manager driver. The tests ensure that the driver can properly enqueue and dequeue from frame queues using the QMan portal infrastructure. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc

[v2 00/11] Freescale DPAA QBMan Drivers

2015-08-12 Thread Roy Pledge
The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and the accelerators. The

[v2 11/11] soc/qman: add qman_delete_cgr_safe()

2015-08-12 Thread Roy Pledge
From: Madalin Bucur Add qman_delete_cgr_safe() that can be called from any CPU. This in turn schedules qman_delete_cgr() on the proper CPU. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman_api.c | 46 ++ 1 file

[v2 07/11] soc/bman: Add debugfs support for the BMan driver

2015-08-12 Thread Roy Pledge
From: Geoff Thorpe Add debugfs support for querying the state of hardware based Buffer Manager pools used in DPAA 1.0. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/Kconfig|7 ++ drivers/soc/fsl/qbman/Makefile

[v2 10/11] soc/qman: Add HOTPLUG_CPU support to the QMan driver

2015-08-12 Thread Roy Pledge
From: Hai-Ying Wang Add support for CPU hotplug for the DPAA 1.0 Queue Manager driver. Signed-off-by: Hai-Ying Wang Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman_portal.c | 43 +++ 1 file changed, 43 insertions(+) diff

[v2 01/11] powerpc: re-add devm_ioremap_prot()

2015-08-12 Thread Roy Pledge
From: Emil Medve devm_ioremap_prot() was removed in commit dedd24a12, and was introduced in commit b41e5fffe8. This reverts commit dedd24a12fe6735898feeb06184ee346907abb5d. Signed-off-by: Emil Medve --- arch/powerpc/include/asm/io.h |3 +++ arch/powerpc/lib/Makefile |1 + arch/pow

[v2 09/11] soc/bman: Add HOTPLUG_CPU support to the BMan driver

2015-08-12 Thread Roy Pledge
From: Hai-Ying Wang Add support for CPU hotplug for the DPAA 1.0 Buffer Manager driver Signed-off-by: Hai-Ying Wang Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman_portal.c | 40 +++ drivers/soc/fsl/qbman/dpaa_sys.h

[v2 05/11] soc/bman: Add self-tester for BMan driver

2015-08-12 Thread Roy Pledge
From: Geoff Thorpe Add a self test for the DPAA 1.0 Buffer Manager driver. This test ensures that the driver can properly acquire and release buffers using the BMan portal infrastructure. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl

[v2 06/11] soc/qman: Add self-tester for QMan driver

2015-08-12 Thread Roy Pledge
From: Geoff Thorpe Add a self test for the DPAA 1.0 Queue Manager driver. The tests ensure that the driver can properly enqueue and dequeue from frame queues using the QMan portal infrastructure. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc

[v2 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-08-12 Thread Roy Pledge
-off-by: Roy Pledge --- drivers/soc/Kconfig |1 + drivers/soc/Makefile |1 + drivers/soc/fsl/Kconfig |5 + drivers/soc/fsl/Makefile |3 + drivers/soc/fsl/qbman/Kconfig | 25 ++ drivers/soc/fsl/qbman/Makefile|1 + drivers

[v2 03/11] soc/fsl: Introduce the DPAA BMan portal driver

2015-08-12 Thread Roy Pledge
From: Geoff Thorpe Add support for Freescale DPAA 1.0 Buffer Manager portals. These portals allow software drivers for accelerators connected to the datapath to manage the hardware buffer pools. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc

[v2 08/11] soc/qman: Add debugfs support for the QMan driver

2015-08-12 Thread Roy Pledge
From: Geoff Thorpe Add debugfs sypport for querying the state of hardware based queues managed by the DPAA 1.0 Queue Manager. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/Makefile |1

RE: [v2 04/11] soc/fsl: Introduce drivers for the DPAA QMan

2015-09-15 Thread Roy Pledge
the DPAA QMan > > On Wed, Aug 12, 2015 at 04:14:50PM -0400, Roy Pledge wrote: > > +/* Lock/unlock frame queues, subject to the "LOCKED" flag. This is > > +about > > + * inter-processor locking only. Note, FQLOCK() is always called > > +either under a > >

Re: [PATCH v2] soc: fsl: dpio: Add support for QBMan ring bulk enqueue.

2019-09-06 Thread Roy Pledge
he bulk enqueue of one frame > > Signed-off-by: Youri Querry Acked-by: Roy Pledge > --- > drivers/soc/fsl/dpio/dpio-service.c | 69 +++- > drivers/soc/fsl/dpio/qbman-portal.c | 772 > > drivers/soc/fsl/dpio/qbman-portal.h | 175 +++

Re: [PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL_GUTS

2019-08-16 Thread Roy Pledge
On 8/15/2019 7:09 PM, Li Yang wrote: > On Wed, Jul 3, 2019 at 9:58 AM Ioana Ciornei wrote: >> Make FSL_MC_DPIO select directly FSL_GUTS. Without this change we could >> be in a situation where both FSL_MC_DPIO and SOC_BUS are enabled but >> FSL_GUTS is not. >> >> Signed-off-by: Ioana Ciornei >> -

[PATCH v1 0/8] soc/fsl/qbman: Enable Kexec for DPAA1 devices

2019-05-13 Thread Roy Pledge
QBMan private memories has not changed after the execution of the Kexec. Roy Pledge (8): soc/fsl/qbman: Rework QBMan private memory setup soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup soc/fsl/qbman: Cleanup QMan queues if device was already initialized soc/fsl

[PATCH v1 1/8] soc/fsl/qbman: Rework QBMan private memory setup

2019-05-13 Thread Roy Pledge
Rework QBMan private memory setup so that the areas are not zeroed if the device was previously initialized If the QMan private memory was already initialized skip the PFDR initialization. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman_ccsr.c | 26 -- drivers/soc

[PATCH v1 2/8] soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup

2019-05-13 Thread Roy Pledge
Clean the BMan buffer pools if the device had been initialized previously. This will ensure a consistent state if the kernel was soft restarted (kexec for example) Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman.c| 17 + drivers/soc/fsl/qbman/bman_ccsr.c | 10

[PATCH v1 3/8] soc/fsl/qbman: Cleanup QMan queues if device was already initialized

2019-05-13 Thread Roy Pledge
If the QMan device was previously initialized make sure all the frame queues are out of service once all the portals are probed. This handles the case where the kernel is restarted without the SoC being reset (kexec for example) Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c

[PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties

2019-05-13 Thread Roy Pledge
The index value should be passed to the of_parse_phandle() function to ensure the correct property is read. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/dpaa_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman

[PATCH v1 5/8] soc/fsl/qbman: Fix drain_mr_fqni()

2019-05-13 Thread Roy Pledge
The drain_mr_fqni() function may be called fron uninterruptable context so convert the msleep() to an mdelay(). Also ensure that the valid bit is updated while polling. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH v1 6/8] soc/fsl/qbman: Disable interrupts during portal recovery

2019-05-13 Thread Roy Pledge
Disable the QBMan interrupts during recovery. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 22 +++--- drivers/soc/fsl/qbman/qman_ccsr.c | 1 + drivers/soc/fsl/qbman/qman_priv.h | 1 + 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v1 7/8] soc/fsl/qbman: Fixup qman_shutdown_fq()

2019-05-13 Thread Roy Pledge
When shutting down a FQ on a dedicated channel only the SW portal associated with that channel can dequeue from it. Make sure the correct portal is use. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 53 +++- 1 file changed, 42 insertions

[PATCH v1 8/8] soc/fsl/qbman: Update device tree with reserved memory

2019-05-13 Thread Roy Pledge
reused after a kexec() Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/dpaa_sys.c | 58 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c index 0b901a8..9dd8bb5 100644 --- a

Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device tree properties

2019-05-13 Thread Roy Pledge
On 5/13/2019 12:40 PM, Joakim Tjernlund wrote: > On Mon, 2019-05-13 at 16:09 +0000, Roy Pledge wrote: >> The index value should be passed to the of_parse_phandle() >> function to ensure the correct property is read. > Is this a bug fix? Maybe for stable too? > > Jocke Yes

[PATCH v3 2/7] soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup

2019-08-01 Thread Roy Pledge
Clean the BMan buffer pools if the device had been initialized previously. This will ensure a consistent state if the kernel was soft restarted (kexec for example) Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman.c| 17 + drivers/soc/fsl/qbman/bman_ccsr.c | 10

[PATCH v3 0/7] soc/fsl/qbman: Enable Kexec for DPAA1 devices

2019-08-01 Thread Roy Pledge
QBMan private memories has not changed after the execution of the Kexec. Changes since v1: - Removed a bug fix and sent it separately to ease backporting Changes since v2: - Expliciitly flush FQD memory from cache on PPC before unmapping Roy Pledge (7): soc/fsl/qbman: Rework QBMan

[PATCH v3 4/7] soc/fsl/qbman: Fix drain_mr_fqni()

2019-08-01 Thread Roy Pledge
The drain_mr_fqni() function may be called fron uninterruptable context so convert the msleep() to an mdelay(). Also ensure that the valid bit is updated while polling. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH v3 3/7] soc/fsl/qbman: Cleanup QMan queues if device was already initialized

2019-08-01 Thread Roy Pledge
If the QMan device was previously initialized make sure all the frame queues are out of service once all the portals are probed. This handles the case where the kernel is restarted without the SoC being reset (kexec for example) Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c

[PATCH v3 7/7] soc/fsl/qbman: Update device tree with reserved memory

2019-08-01 Thread Roy Pledge
reused after a kexec() Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/dpaa_sys.c | 60 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c index 3e0a7f3..9dd8bb5 100644 --- a

[PATCH v3 5/7] soc/fsl/qbman: Disable interrupts during portal recovery

2019-08-01 Thread Roy Pledge
Disable the QBMan interrupts during recovery. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 22 +++--- drivers/soc/fsl/qbman/qman_ccsr.c | 1 + drivers/soc/fsl/qbman/qman_priv.h | 1 + 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v3 1/7] soc/fsl/qbman: Rework QBMan private memory setup

2019-08-01 Thread Roy Pledge
Rework QBMan private memory setup so that the areas are not zeroed if the device was previously initialized If the QMan private memory was already initialized skip the PFDR initialization. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman_ccsr.c | 26 +-- drivers/soc/fsl

[PATCH v3 6/7] soc/fsl/qbman: Fixup qman_shutdown_fq()

2019-08-01 Thread Roy Pledge
When shutting down a FQ on a dedicated channel only the SW portal associated with that channel can dequeue from it. Make sure the correct portal is use. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 53 +++- 1 file changed, 42 insertions

[PATCH] soc/fsl/qbman: Use index when accessing device tree properties

2019-06-27 Thread Roy Pledge
The index value should be passed to the of_parse_phandle() function to ensure the correct property is read. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/dpaa_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman

[PATCH v2 0/7] soc/fsl/qbman: Enable Kexec for DPAA1 devices

2019-07-03 Thread Roy Pledge
QBMan private memories has not changed after the execution of the Kexec. Changes since v1: - Removed a bug fix and sent it separately to ease backporting Roy Pledge (7): soc/fsl/qbman: Rework QBMan private memory setup soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to

[PATCH v2 1/7] soc/fsl/qbman: Rework QBMan private memory setup

2019-07-03 Thread Roy Pledge
Rework QBMan private memory setup so that the areas are not zeroed if the device was previously initialized If the QMan private memory was already initialized skip the PFDR initialization. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman_ccsr.c | 26 -- drivers/soc

[PATCH v2 7/7] soc/fsl/qbman: Update device tree with reserved memory

2019-07-03 Thread Roy Pledge
reused after a kexec() Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/dpaa_sys.c | 60 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dpaa_sys.c index 3e0a7f3..9dd8bb5 100644 --- a

[PATCH v2 5/7] soc/fsl/qbman: Disable interrupts during portal recovery

2019-07-03 Thread Roy Pledge
Disable the QBMan interrupts during recovery. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 22 +++--- drivers/soc/fsl/qbman/qman_ccsr.c | 1 + drivers/soc/fsl/qbman/qman_priv.h | 1 + 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v2 6/7] soc/fsl/qbman: Fixup qman_shutdown_fq()

2019-07-03 Thread Roy Pledge
When shutting down a FQ on a dedicated channel only the SW portal associated with that channel can dequeue from it. Make sure the correct portal is use. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 53 +++- 1 file changed, 42 insertions

[PATCH v2 4/7] soc/fsl/qbman: Fix drain_mr_fqni()

2019-07-03 Thread Roy Pledge
The drain_mr_fqni() function may be called fron uninterruptable context so convert the msleep() to an mdelay(). Also ensure that the valid bit is updated while polling. Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH v2 2/7] soc/fsl/qbman: Cleanup buffer pools if BMan was initialized prior to bootup

2019-07-03 Thread Roy Pledge
Clean the BMan buffer pools if the device had been initialized previously. This will ensure a consistent state if the kernel was soft restarted (kexec for example) Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman.c| 17 + drivers/soc/fsl/qbman/bman_ccsr.c | 10

[PATCH v2 3/7] soc/fsl/qbman: Cleanup QMan queues if device was already initialized

2019-07-03 Thread Roy Pledge
If the QMan device was previously initialized make sure all the frame queues are out of service once all the portals are probed. This handles the case where the kernel is restarted without the SoC being reset (kexec for example) Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c

[PATCH] soc: fsl: dpio: Increase timeout for QBMan Management Commands

2019-03-11 Thread Roy Pledge
From: Youri Querry The timeout for QBMan Management Commands can falsely trigger on a busy system. This patch doubles the timeout to avoid the false error reports Signed-off-by: Youri Querry Signed-off-by: Roy Pledge --- drivers/soc/fsl/dpio/qbman-portal.h | 4 ++-- 1 file changed, 2

[v6 4/8] bus: fsl-mc: dpio: add global dpaa2 definitions

2017-03-08 Thread Roy Pledge
From: Roy Pledge Create header for global dpaa2 definitions. Add definitions for dequeue results. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/include/dpaa2-global.h | 202 + 1 file changed, 202 insertions(+) create mode 100644

[v6 0/8] staging: fsl-mc: add dpio driver

2017-03-08 Thread Roy Pledge
location for both fsl-mc bus driver and dpio driver Ioana Radulescu (1): bus: fsl-mc: dpio: add APIs for DPIO objects Roy Pledge (6): bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs bus: fsl-mc: dpio: add global dpaa2 definitions bus: fsl-mc: dpio: add QBMan portal

[v6 5/8] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2017-03-08 Thread Roy Pledge
From: Roy Pledge Add QBman APIs for frame queue and buffer pool operations. Signed-off-by: Roy Pledge Signed-off-by: Haiying Wang Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/dpio/Makefile |2 +- drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 1033

[v6 3/8] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2017-03-08 Thread Roy Pledge
From: Roy Pledge Add global definitions for DPAA2 frame descriptors and scatter gather entries. Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/include/dpaa2-fd.h | 448 + 1 file changed, 448 insertions(+) create mode 100644

[v6 6/8] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

2017-03-08 Thread Roy Pledge
From: Roy Pledge The DPIO service interface handles initialization of DPIO objects and exports APIs to be used by other DPAA2 object drivers to perform queuing and buffer management related operations. The service allows registration of callbacks when frames or notifications are received

[v6 7/8] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver

2017-03-08 Thread Roy Pledge
The DPIO driver registers with the fsl-mc bus to handle bus-related events for DPIO objects. Key responsibility is mapping I/O regions, setting up interrupt handlers, and calling the DPIO service initialization during probe. Signed-off-by: Roy Pledge Signed-off-by: Haiying Wang Signed-off-by

[v6 2/8] bus: fsl-mc: dpio: add APIs for DPIO objects

2017-03-08 Thread Roy Pledge
From: Ioana Radulescu Add the command build/parse APIs for operating on DPIO objects through the DPAA2 Management Complex. Signed-off-by: Ioana Radulescu Signed-off-by: Roy Pledge Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/Kconfig | 10 ++ drivers/staging/fsl-mc

[v6 1/8] bus: fsl-mc: dpio: add DPIO driver overview document

2017-03-08 Thread Roy Pledge
From: Stuart Yoder add document describing the dpio driver and it's role, components and major interfaces Signed-off-by: Stuart Yoder --- drivers/staging/fsl-mc/bus/dpio/dpio-driver.txt | 135 +++ 1 file changed, 135 insertions(+) create mode 100644 drivers/staging/fsl-mc

  1   2   >