Hello Bjorn,
Can you please let us know the suggest the file name and review the patch.
On 7/9/2018 11:29 AM, Rohit Kumar wrote:
Thanks Rob for reviewing.
On 7/7/2018 2:02 AM, Rob Herring wrote:
On Fri, Jun 29, 2018 at 02:50:53PM +0530, Rohit kumar wrote:
This adds APSS based ADSP PIL
Add devicetree bindings documentation file for SDM845 sound card.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 82 ++
1 file changed, 82 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt
diff
This provides initial patchset to support audio on
Qualcomm Techonologies Inc. SDM845 SoC. Currently, it supports
audio playback/capture over Primary MI2S and Quaternary
TDM ports.
Changes since v1:
Addressed comments posted by Vinod and Srinivas.
Rohit kumar (2):
ASoC: qcom: dt-bindings: Add
This patch adds sdm845 audio machine driver support.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 9 +
sound/soc/qcom/Makefile | 2 +
sound/soc/qcom/sdm845.c | 514
3 files changed, 525 insertions(+)
create mode 100644 sound/soc
On 6/21/2018 8:39 PM, Srinivas Kandagatla wrote:
On 21/06/18 13:35, Vinod wrote:
And this one is generic DT parsing and seems quite similar to one in
apq8096.c
Can we move these into a lib and use them instead of duplicating.
I totally agree with Vinod, We should probably come up with a li
Thanks Bjorn for posting the patch.
On 8/28/2018 10:42 AM, Bjorn Andersson wrote:
The Hexagon v5 ADSP driver is used for more than only the ADSP and
there's an upcoming non-PAS ADSP PIL for SDM845, so rename the driver to
qcom_q6v5_pas in order to better suite this.
Cc: Rohit kumar
S
Thanks Bjorn for reviewing the patch.
On 8/28/2018 11:39 AM, Bjorn Andersson wrote:
On Fri 29 Jun 02:20 PDT 2018, Rohit kumar wrote:
This adds APSS based ADSP PIL driver for QCOM SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown operation handled from Application Processor
Add devicetree bindings documentation file for SDM845 sound card.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 80 ++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt
diff
This adds support to parse cpu, platform and codec
device nodes and add them in dai-links. Also, update
apq8096 machine driver to use the common API.
Acked-by: Srinivas Kandagatla
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Makefile | 2 +-
sound/soc/qcom/apq8096.c | 111
This patch adds sdm845 audio machine driver support.
Acked-by: Srinivas Kandagatla
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 8 ++
sound/soc/qcom/Makefile | 2 +
sound/soc/qcom/sdm845.c | 286
3 files changed, 296 insertions
Remove qcom prefix from machine driver dt bindings of
apq8096 SoC.
Acked-by: Srinivas Kandagatla
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree
- Addressed comments by Srinivas, Mark and Vinod.
Rohit kumar (4):
ASoC: qcom: dt-bindings: Add sdm845 machine bindings
ASoC: dt-bindings: Update dt binding name for apq8096
ASoC: qcom: Add support to parse common audio device nodes
ASoC: qcom: add sdm845 sound card support
.../devicetree
patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Rohit-kumar/Add-support-for-audio-on-SDM845-SoC/20180801-082203
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
for-next
reproduce
Add devicetree bindings documentation file for SDM845 sound card.
Reviewed-by: Rob Herring
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 80 ++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound
This provides initial patchset to support audio on
Qualcomm Techonologies Inc. SDM845 SoC. Currently, it supports
audio playback/capture over Primary MI2S and Quaternary
TDM ports.
Changes since v4:
- Used snd_mask_set_format() instead of snd_mask_set() to avoid sparse warning.
Rohit kumar (4
This adds support to parse cpu, platform and codec
device nodes and add them in dai-links. Also, update
apq8096 machine driver to use the common API.
Acked-by: Srinivas Kandagatla
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Makefile | 2 +-
sound/soc/qcom/apq8096.c | 111
Remove qcom prefix from machine driver dt bindings of
apq8096 SoC.
Acked-by: Srinivas Kandagatla
Reviewed-by: Rob Herring
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git
This patch adds sdm845 audio machine driver support.
Acked-by: Srinivas Kandagatla
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 8 ++
sound/soc/qcom/Makefile | 2 +
sound/soc/qcom/sdm845.c | 286
3 files changed, 296 insertions
Add DEPENDS_ON QCOM_APR for SND_SOC_SDM845 to fix the
warning: unmet direct dependencies detected for
SND_SOC_QDSP6.
Reported-by: Stephen Rothwell
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
This patch adds support to open, write and media format commands
in the q6asm module.
[..]
+static int32_t q6asm_callback(struct apr_device *adev,
+ struct apr_client_data *da
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
This patch adds support to q6asm dai driver which configures Q6ASM streams
to pass pcm data.
Currently the driver only exposes 2 playback streams for hdmi playback
support, it can be easily extended to add
On 2/13/2018 10:28 PM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla
---
include/dt-bindings/sound/qcom,q6afe.h | 10 +++
sound/soc/qcom/qdsp6/q6afe.c | 111 +
sound/soc/qcom/qdsp6/q6afe.h
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
This patch adds support to open, write and media format commands
in the q6asm module.
Signed-off-by: Srinivas Kandagatla
Reviewed-and-Tested-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6asm.c | 744
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
This patch adds support to Q6AFE (Audio Front End) module on Q6DSP.
[..]
+ if (res->status) {
+ dev_err(afe->dev, "cmd = 0x%x returned error = 0x%x\n",
+
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
[..]
+static int q6core_get_svc_versions(struct q6core *core)
+{
+ struct apr_device *adev = core->adev;
+ struct apr_hdr hdr = {0};
+ int rc;
+
+ core->get_version_supported = true;
On 3/10/2018 7:54 AM, srinivas.kandaga...@linaro.org wrote:
From: Srinivas Kandagatla
[..]
+struct bus_type aprbus_type = {
+ .name = "aprbus",
+ .match = apr_device_match,
+ .probe = apr_device_probe,
+ .remove = apr_device_remove
LPASS Audio Wrapper AON clock is on by default. Remove
voting for it.
Rohit kumar (2):
dt-binding: remoteproc: Remove lpass_aon clock from adsp pil clock
list
remoteproc: q6v5_adsp: Remove voting for lpass_aon clock
Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5
LPASS_Audio_Wrapper_AON clock is on by default. Remove
it from lpass clock list to avoid voting for it.
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree
Lpass_aon clock is on by default. Remove it from lpass
clock list to avoid voting for it.
Signed-off-by: Rohit kumar
---
drivers/remoteproc/qcom_q6v5_adsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
b/drivers/remoteproc
Update bit clock rate, slot width for TDM and MI2S
interfaces. Also add support for secondary MI2S TX
interface in SDM845 machine driver.
Rohit kumar (2):
ASoC: sdm845: Update slot_width for Quaternary TDM port
ASoC: sdm845: Add support for Secondary MI2S interface
sound/soc/qcom/sdm845.c
Change slot_width for quaternary TDM port to 16 and
update bclk rate for TDM and MI2S interfaces
accordingly.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/sdm845.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
Add support to configure bit clock for secondary MI2S
TX interface.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/sdm845.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
index 84e6ee7..58593db 100644
--- a/sound/soc/qcom
Thanks Rob for reviewing.
On 7/7/2018 2:02 AM, Rob Herring wrote:
On Fri, Jun 29, 2018 at 02:50:53PM +0530, Rohit kumar wrote:
This adds APSS based ADSP PIL driver for QCOM SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown operation handled from Application Processor
Thanks Vinod for reviewing.
On 7/9/2018 1:18 PM, Vinod wrote:
On 06-07-18, 15:13, Rohit kumar wrote:
+static void sdm845_init_supplies(struct device *dev)
+{
+ struct snd_soc_card *card = dev_get_drvdata(dev);
+ struct sdm845_snd_data *data = snd_soc_card_get_drvdata(card
Thanks Rob for reviewing.
On 6/26/2018 12:47 AM, Rob Herring wrote:
On Thu, Jun 21, 2018 at 04:23:18PM +0530, Rohit kumar wrote:
Add devicetree bindings documentation file for SDM845 sound card.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 82
This adds APSS based ADSP PIL driver for QCOM SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown operation handled from Application Processor
SubSystem(APSS).
Signed-off-by: Rohit kumar
---
Changes since v1:
- Used APIs from qcom_q6v5.c
- Use clock, reset and regmap driver APIs
This adds Qualcomm ADSP PIL driver support for SDM845 with ADSP bootup
and shutdown operation handled from Application Processor SubSystem(APSS).
Signed-off-by: Rohit kumar
Signed-off-by: RajendraBabu Medisetti
Signed-off-by: Krishnamurthy Renu
---
.../devicetree/bindings/remoteproc/qcom
This patch adds sdm845 audio machine driver support.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 87
sound/soc/qcom/Kconfig | 9 +
sound/soc/qcom/Makefile| 2 +
sound/soc/qcom/sdm845.c
Thanks Vinod for reviewing.
On 6/19/2018 10:35 AM, Vinod wrote:
On 18-06-18, 16:46, Rohit kumar wrote:
+struct sdm845_snd_data {
+ struct snd_soc_card *card;
+ struct regulator *vdd_supply;
+ struct snd_soc_dai_link dai_link[];
+};
+
+static struct mutex pri_mi2s_res_lock
Thanks Srinivas for reviewing.
On 6/19/2018 2:16 PM, Srinivas Kandagatla wrote:
Thanks Rohit for the patch!
On 18/06/18 12:16, Rohit kumar wrote:
This patch adds sdm845 audio machine driver support.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 87
Thanks Bjorn for the cleanup.
I validated PAS and Non- PAS ADSP PIL with the cleanup changes on SDM845.
Adding tag for ADSP PIL.
Reviewed-and-tested-by: Rohit kumar
On 5/23/2018 10:50 AM, Bjorn Andersson wrote:
With the introduction of support for the non-MSA Hexagon WCSS driver from
disabling of proxy resources. But apart from this there should be no
change in functionality.
Signed-off-by: Bjorn Andersson
Reviewed-and-tested-by: Rohit kumar
---
drivers/remoteproc/Kconfig | 1 +
drivers/remoteproc/qcom_adsp_pil.c | 156 +
2 files changed
driver.
- Removed qcom prefix from device tree properties as
suggested by Robb.
- Updated apq8096 machine driver to use common APIs.
Rohit kumar (5):
ASoC: qcom: dt-bindings: Add sdm845 machine bindings
ASoC: qcom: Add support to parse common audio device nodes
ASoC: qcom: add sdm845 sound
This adds support to parse cpu, platform and codec
device nodes and add them in dai-links. Also, add
API to add slave components associated with machine
driver.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 3 +
sound/soc/qcom/Makefile | 1 +
sound/soc/qcom/common.c | 150
This patch adds sdm845 audio machine driver support.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 10 ++
sound/soc/qcom/Makefile | 2 +
sound/soc/qcom/sdm845.c | 390
3 files changed, 402 insertions(+)
create mode 100644 sound/soc
Use generic APIs exposed by common.c for parsing
dai link device tree nodes and adding slave components.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/Kconfig | 1 +
sound/soc/qcom/apq8096.c | 151 ---
2 files changed, 11 insertions(+), 141
Add devicetree bindings documentation file for SDM845 sound card.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,sdm845.txt | 80 ++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,sdm845.txt
diff
Remove qcom prefix from machine driver dt bindings of
apq8096 SoC.
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/sound/qcom,apq8096.txt | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096
Headset codec is connected over PRIMARY_MI2S interface. Call
set_jack for codec associated with Primary Mi2s interface.
Also, set_jack to NULL when jack is freed.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/sdm845.c | 31 ++-
1 file changed, 22 insertions(+), 9
Add support for Audio over display port AFE port
Rohit kumar (4):
ASoC: qdsp6: dt-bindings: Add q6afe display_port dt binding
ASoC: qdsp6: qdafe: add support for display_port_rx
ASoC: qdsp6: q6afe-dai: add support to Display port RX dais
ASoC: qdsp6: q6routing: add display_port_rx port
This patch adds support for Display_Port_Rx
port in AFE.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6afe.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c
index 829b5e987..e0945f7a 100644
--- a/sound/soc/qcom/qdsp6
This patch adds bindings required for DISPLAY_PORT_RX
port on AFE.
Signed-off-by: Rohit kumar
---
include/dt-bindings/sound/qcom,q6afe.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/sound/qcom,q6afe.h
b/include/dt-bindings/sound/qcom,q6afe.h
index e2d3892..1df06f8
This patch adds support of AFE DAI for Display_port_rx port.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6afe-dai.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c
index bfc3bbf..dc645ba
This patch add support to Display_port_rx mixers required to
select path between ASM stream and AFE ports.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6routing.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6
Hello Mark,
On 12/7/2018 1:51 AM, Mark Brown wrote:
On Wed, Nov 28, 2018 at 05:00:34PM +0800, Cheng-Yi Chiang wrote:
Add a callback for init ops on dai_link to create and setup jack.
Signed-off-by: Rohit kumar
Signed-off-by: Cheng-Yi Chiang
This looks like you're forwarding a patch
clk list:
https://lore.kernel.org/patchwork/patch/1019609/
Rohit kumar (2):
arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
arm64: dts: qcom: sdm845: Add Q6V5 ADSP node
arch/arm64/boot/dts/qcom/sdm845.dtsi | 101 ++-
1 file changed, 100 insertions
Add memory nodes required for remoteproc q6v5_adsp pil.
Signed-off-by: Rohit kumar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 23a253b..c0a012f 100644
--- a
This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
Signed-off-by: Rohit kumar
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 96 +++-
1 file changed, 95 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts
Thanks Bjorn for review.
On 1/4/2019 5:12 AM, Bjorn Andersson wrote:
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
Add memory nodes required for remoteproc q6v5_adsp pil.
This range doesn't match the documented memory map. I would prefer to
see a "Specify all PIL regions as
Thanks Bjorn for review.
On 1/4/2019 5:20 AM, Bjorn Andersson wrote:
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
This patch adds Q6V5 ADSP remoteproc node for SDM845 SoCs.
Thanks Rohit, nice to see these things on the list!
Signed-off-by: Rohit kumar
---
arch/arm64/boot/dts/qcom
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Thanks,
Rohit
On 11/30/2018 12:59 PM, Rohit kumar wrote:
Lpass_aon clock is on by default. Remove it from lpass
clock list to avoid voting for it.
Signed-off-by
From: Ajit Pandey
Platform DAI component probe is not called if it is not
present in component list during sound card registration.
Check if component is registered for platform dai before
soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
sound/soc/qcom
Platform DAI component probe is not called if it is not
present in component list during sound card registration.
Add snd_soc_of_lookup_component() to get component info from
device_node. This can be used by machine driver to make sure that
card components are registered before calling snd_soc_regi
-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
include/sound/soc.h | 1 +
sound/soc/soc-core.c | 28
2 files changed, 29 insertions(+)
diff --git a/include/sound/soc.h b/include/sound/soc.h
index 8ec1de8..dc251fc 100644
--- a/include/sound/soc.h
+++ b/include/sound
stream.
Reported-by: Jimmy Cheng-Yi Chiang
Reported-by: Rohit kumar
Tested-by: Rohit kumar
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6afe-dai.c | 208 +++
1 file changed, 104 insertions(+), 104 deletions(-)
diff --git a/sound/soc/qcom/qdsp6
Frontend dai_link id is used for closing ADM sessions.
During concurrent usecase when one session is closed,
it closes other ADM session associated with other usecase
too. Dai_link->id should always point to Frontend dai id.
Set cpu_dai id as dai_link id to fix the issue.
Signed-off-by: Ro
SD line mask for MI2S starts from BIT 0 instead of BIT 1.
Fix all bit mask for MI2S SD lines.
Signed-off-by: Rohit kumar
---
sound/soc/qcom/qdsp6/q6afe.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6
+0xe4/0x164
Signed-off-by: Rohit kumar
---
sound/soc/soc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 6ddcf12..abdc460 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1467,7 +1467,7 @@ static int
On 11/2/2018 1:12 PM, Takashi Iwai wrote:
On Thu, 01 Nov 2018 13:38:49 +0100,
Rohit kumar wrote:
Remove no_pcm check to invoke pcm_new() for backend dai-links
too. This fixes crash in hdmi codec driver during hdmi_codec_startup()
while accessing chmap_info struct. chmap_info struct memory is
Hello Arnaud,
On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote:
Hello Rohit,
On 11/2/18 1:06 PM, Rohit Kumar wrote:
On 11/2/2018 1:12 PM, Takashi Iwai wrote:
On Thu, 01 Nov 2018 13:38:49 +0100,
Rohit kumar wrote:
Remove no_pcm check to invoke pcm_new() for backend dai-links
too. This fixes
Hello Rob,
Can you please review this patch and let me know if there is any concern
with this patch.
On 9/11/2018 9:24 AM, Rohit kumar wrote:
Add devicetree bindings documentation file for Qualcomm
Technolgies Inc ADSP Peripheral Image Loader.
Signed-off-by: Rohit kumar
---
Changes since
Thanks Bjorn for reviewing.
On 5/23/2018 11:56 AM, Bjorn Andersson wrote:
On Sun 13 May 00:01 PDT 2018, Rohit kumar wrote:
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
@@ -10,6 +10,7 @@ on the Qualcomm ADSP
snd_soc_card is retrieved as device drvdata during unbind().
Set it as drvdata during bind() to avoid memory corruption during
unbind().
Signed-off-by: Rohit kumar
---
sound/soc/qcom/apq8096.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096
This patch adds Q6V5 ADSP pil remoteproc node
for SDM845 SoC.
Signed-off-by: Rohit kumar
---
Changes since v2:
Updated reg property values from <0x1730 0x410> to <0 0x1730 0 0x410>
This depends on below upstream patches:
Add adsp_mem dt node: https://lkml.org/lkml/2019/1/29
Hello Mark,
Do you see any concern with patches (1-11).
As of now, there is comment only in patch 12 from Rob which I am
planning to update once other patches are merged. Can you
please review and let me know if anything is missing.
Thanks,
Rohit
On 8/4/2020 1:37 PM, Rohit kumar wrote:
From
Thanks Rob for reviewing
On 7/23/2020 10:46 PM, Rob Herring wrote:
On Wed, Jul 22, 2020 at 04:01:55PM +0530, Rohit kumar wrote:
Update lpass-cpu binding with yaml formats.
Signed-off-by: Rohit kumar
---
.../devicetree/bindings/sound/qcom,lpass-cpu.txt | 130
nce null return value")
Fixes: 1220f6a76e77 ("ASoC: qcom: Add common array to initialize soc based core
clocks")
Signed-off-by: Colin Ian King
---
Thanks for the fix.
Reviewed-by: Rohit kumar
sound/soc/qcom/lpass-apq8016.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Thanks Stephen for reviewing.
On 8/6/2020 6:01 AM, Stephen Boyd wrote:
Quoting Rohit kumar (2020-07-22 03:31:44)
From: Ajit Pandey
LPASS variants have their own soc specific clocks that needs to be
enabled for MI2S audio support. Added a common variable in drvdata to
initialize such clocks
.
Thanks,
Rohit
On 8/4/2020 1:37 PM, Rohit kumar wrote:
This patch chain add audio support for SC7180 soc by doing the required
modification in existing common lpass-cpu/lpass-platform driver.
This also fixes some concurrency issue.
This patch series is already tested by Srinivas on Dragon Board
From: Rohit
Use kmem_cache to allocate/free inode_smack since they are
alloced in high volumes making it a perfect case for kmem_cache.
Accounting of memory allocation is below :
total slacknet count-alloc/freecaller
Before (with kzalloc)
1919872 719
Currently we can only import dma buf fd's to get ion_handle.
Adding support to import dma buf handles to support kernel
specific use cases.
Signed-off-by: Rohit kumar
---
Currently, ION is the memory manager for graphics in android. However,
in other linux platforms such as Tizen, DRM-G
This patch fixes error handling case when buffer->pages allocation
fails. Also, it removes unreachable code of checking ret variable
although it is not updated.
Signed-off-by: Rohit kumar
---
drivers/staging/android/ion/ion.c | 14 +-
1 file changed, 5 insertions(+), 9 deleti
Hello Bjorn,
On 1/14/2019 4:14 PM, Rohit Kumar wrote:
On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the
This patch adds Q6V5 ADSP pil remoteproc node
for SDM845 SoC.
Signed-off-by: Rohit kumar
---
Changes since v1:
Addressed comments given by Bjorn.
This depends on below upstream patch which defines adsp_mem node:
https://lkml.org/lkml/2019/1/29/1392
arch/arm64/boot/dts/qcom/sdm845.dtsi | 89
On 1/12/2019 3:19 AM, Pierre-Louis Bossart wrote:
Thanks for the overnight fix. This update fixes the issue on my
Skylake XPS13 test device (blind testing since I don't understand
what the code does).
Tested-by: Pierre-Louis Bossart
I need to take this back, this set of changes (initial+f
On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support is already removed from lpass clock driver.
Applied the two patches.
Hello Bjorn,
Can you please point me to
called if it is not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Signed-off-by: Mark
Thanks Mark for review.
On 1/7/2019 11:57 PM, Mark Brown wrote:
On Mon, Dec 24, 2018 at 02:32:13PM +0530, Rohit kumar wrote:
From: Ajit Pandey
Platform DAI component probe is not called if it is not
present in component list during sound card registration.
Check if component is registered
From: Ajit Pandey
DAI component probe is not called if it is not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Signed-off-by: Mark Brown
---
I got below WARNING by this patch.
I guess we
)
Reported-by: Kuninori Morimoto
Signed-off-by: Rohit kumar
Signed-off-by: Ajit Pandey
---
sound/soc/soc-core.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index eec92f1..0934b36 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
Hello Bjorn,
On 1/30/2019 10:38 AM, Rohit Kumar wrote:
Hello Bjorn,
On 1/14/2019 4:14 PM, Rohit Kumar wrote:
On 1/7/2019 12:43 PM, Bjorn Andersson wrote:
On Thu 03 Jan 20:36 PST 2019, Rohit Kumar wrote:
Hello Bjorn,
Can you please review this patch series too.
LPASS_AON clock support
ist during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
Signed-off-by: Mark Brown
:04 04 98da59b0a73551030a0c9030
list")
Reported-by: Pierre-Louis Bossart
Signed-off-by: Ajit Pandey
Signed-off-by: Rohit kumar
---
sound/soc/soc-core.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 0934b36..df05fb8 100644
--- a/sound/soc/
On 9/12/2018 5:49 PM, Cheng-Yi Chiang wrote:
Toggle reset line in max98927_i2c_probe.
Use a list to store max98927 instances so we do not toggle reset line
again if more than one instances share the same reset line.
Signed-off-by: Cheng-Yi Chiang
Reviewed-and-tested-by: Rohit kumar
Thanks Sibi for reviewing.
On 9/22/2018 1:11 AM, Sibi Sankar wrote:
Hi Rohit,
On 2018-09-03 17:22, Rohit kumar wrote:
This adds Non PAS ADSP PIL driver for Qualcomm
Technologies Inc SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown operation handled from Application
On 9/24/2018 12:19 PM, Rohit Kumar wrote:
Thanks Sibi for reviewing.
On 9/22/2018 1:11 AM, Sibi Sankar wrote:
Hi Rohit,
On 2018-09-03 17:22, Rohit kumar wrote:
This adds Non PAS ADSP PIL driver for Qualcomm
Technologies Inc SoCs.
Added initial support for SDM845 with ADSP bootup and
This adds Non PAS ADSP PIL driver for Qualcomm
Technologies Inc SoCs.
Added initial support for SDM845 with ADSP bootup and
shutdown operation handled from Application Processor
SubSystem(APSS).
Signed-off-by: Rohit kumar
---
Changes since v3:
Addressed comments posted by Sibi
This
Hello Srinivas,
We will add support for vi feedback usecase in sdm845 machine driver
where we have to support 4 channel tx data for a particular backend. We
should probably keep be_hw_params_fixup in respective machine driver for
now to support such requirement.
Thanks,
Rohit
On 9/17/20
Input to qcom,sd-lines should be between 0 and 3 instead of
1 to 4 as 0 corresponds to BIT(0) which is MI2S_SD0 line.
Bit 1 to 3 corresponds to SD1 to SD3 lines respectively.
Updated documentation for the same.
Signed-off-by: Rohit kumar
---
Documentation/devicetree/bindings/sound/qcom
1 - 100 of 182 matches
Mail list logo
