[PATCH] IA64: Fix stack overflow in create_palinfo_proc_entries

2013-03-20 Thread Richard Weinberger
Having more than 99 CPUs causes an overflow of cpustr. If an attacker is able to control the number CPUs he might able to inject code ...kind of. ;-) Signed-off-by: Richard Weinberger --- arch/ia64/kernel/palinfo.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch

Re: DMAR faults from unrelated device when vfio is used

2013-02-05 Thread Richard Weinberger
Am Tue, 05 Feb 2013 13:36:53 -0700 schrieb Alex Williamson : > > Ugh, the infamous and useless error 10. It could be anything. > > I've got a system with onboard usb3, let me see what windows does > > with it here first. Thanks, > > Well, I've got an Etron USB3 HBA and (un)fortunately it works j

Re: DMAR faults from unrelated device when vfio is used

2013-02-06 Thread Richard Weinberger
Hi, Am Tue, 05 Feb 2013 13:36:53 -0700 schrieb Alex Williamson : > > Ugh, the infamous and useless error 10. It could be anything. > > I've got a system with onboard usb3, let me see what windows does > > with it here first. Thanks, > > Well, I've got an Etron USB3 HBA and (un)fortunately it wo

Re: DMAR faults from unrelated device when vfio is used

2013-02-06 Thread Richard Weinberger
Hi, Am Wed, 06 Feb 2013 11:47:20 -0700 schrieb Alex Williamson : > Does the card work with pci-assign or are both broken? It works with pci-assign. :-\ > Possible there's a bug in how we're managing the vector table and pba > here. Can you get to the monitor and run 'into mtree' and provide

Re: DMAR faults from unrelated device when vfio is used

2013-02-07 Thread Richard Weinberger
Hi, Am Wed, 06 Feb 2013 15:45:37 -0700 schrieb Alex Williamson : > On Wed, 2013-02-06 at 21:25 +0100, Richard Weinberger wrote: > > Hi, > > > > Am Wed, 06 Feb 2013 11:47:20 -0700 > > schrieb Alex Williamson : > > > Does the card work with pci-assign or are

Re: DMAR faults from unrelated device when vfio is used

2013-02-07 Thread Richard Weinberger
Am Thu, 07 Feb 2013 15:49:58 -0700 schrieb Alex Williamson : > > If I whitelist pcieport USB3 works within the guests. :-) > > Binding 1c.0 and 1c.6 is no longer needed. > > Next week I'll run some more tests with USB3 devices. > > Great! Thanks for the test. I assume you didn't need to do anyth

[PATCH] cs5535-mfgpt: Fix quotation marks

2013-04-02 Thread Richard Weinberger
Commit "cs5535-mfgpt: Add another reset method" introduced an unterminated string and broke the build. Reported-by: Stephen Rothwell Signed-off-by: Richard Weinberger --- drivers/misc/cs5535-mfgpt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/m

[PATCH 1/2] efivars: Check max_size only if it is non-zero.

2013-04-04 Thread Richard Weinberger
Some (broken?) EFI implementations return always a MaximumVariableSize of 0, check against max_size only if it is non-zero. Signed-off-by: Richard Weinberger --- drivers/firmware/efivars.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efivars.c b/drivers

[PATCH 2/2] efivars: Implement no_storage_paranoia parameter

2013-04-04 Thread Richard Weinberger
Using this parameter one can disable the storage_size/2 check if he is really sure that the UEFI does sane gc. Signed-off-by: Richard Weinberger --- drivers/firmware/efivars.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware

Re: [PATCH 1/2] efivars: Check max_size only if it is non-zero.

2013-04-04 Thread Richard Weinberger
Am 04.04.2013 18:00, schrieb Luck, Tony: Some (broken?) EFI implementations return always a MaximumVariableSize of 0, check against max_size only if it is non-zero. The spec doesn't say that zero has any special meaning - so if an implementation returns max_size == 0 but lets you set a variable

OCFS2 mainline state?

2013-02-25 Thread Richard Weinberger
Hi! Today I encountered the following problem on v3.8: [ 28.940032] general protection fault: [#1] PREEMPT SMP ... [ 28.984953] Call Trace: [ 28.986628 [] ocfs2_fast_symlink_readpage+0x70/0x1b0 [ocfs2] [ 28.988302] [] ? add_to_page_cache_lru+0x29/0x40 [ 28.989942] [] do_read_c

Re: linux-next: build failure after merge of the ubi tree

2012-10-03 Thread Richard Weinberger
Artem, Stephen, Am Wed, 03 Oct 2012 10:20:43 +0300 schrieb Artem Bityutskiy : > On Wed, 2012-10-03 at 12:27 +1000, Stephen Rothwell wrote: > > Hi Artem, > > > > After merging the ubi tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > ERROR: "ubi_update_fastmap" [

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Richard Weinberger
Am Wed, 03 Oct 2012 11:25:45 +0300 schrieb Artem Bityutskiy : > On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote: > > UBI Fastmap is an optional feature which stores the physical to > > logical eraseblock relations in a checkpoint (called fastmap) to > > reduce th

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Richard Weinberger
On 03.10.2012 10:44, Artem Bityutskiy wrote: On Wed, 2012-10-03 at 10:36 +0200, Richard Weinberger wrote: Am Wed, 03 Oct 2012 11:25:45 +0300 schrieb Artem Bityutskiy : On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote: UBI Fastmap is an optional feature which stores the physical to

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Richard Weinberger
On 03.10.2012 11:30, Artem Bityutskiy wrote: On Wed, 2012-10-03 at 11:03 +0200, Richard Weinberger wrote: Yeah, it looks like all issues reported by aiaiai are caused by the missing goto. Can you deal with the patch below or do you want me to send it using git send-email? I'll apply it

Re: [PATCH] [RFC] coredump: Ensure that the coredump helper has stdout and stderr

2012-10-04 Thread Richard Weinberger
On 28.09.2012 18:32, Richard Weinberger wrote: Currently only stdin is available in the coredump helper process. If the process opens a file and then issues a printf(), printf() will write to that opened file instead to a console. Therefore open /dev/console and create fd 1 and 0 as init/main.c

Re: [PATCH 029/193] arch/um: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Richard Weinberger
Am Tue, 23 Oct 2012 13:01:42 -0700 schrieb Kees Cook : > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > CC: Jeff Dike > CC: Richard Weinberger > Sig

Re: [PATCH 032/193] arch/x86/um: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Richard Weinberger
Am Tue, 23 Oct 2012 13:01:45 -0700 schrieb Kees Cook : > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > CC: Jeff Dike > CC: Richard Weinberger > CC: Thomas

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
On 24.10.2012 01:18, Matthew Leach wrote: Hi, When building UML against 3.7-rc2 I encounter the following build error: # make ARCH=uml scripts/kconfig/conf --silentoldconfig arch/x86/um/Kconfig CHK include/generated/uapi/linux/version.h UPD include/generated/uapi/linux/version.h

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
On 24.10.2012 10:08, Richard Weinberger wrote: On 24.10.2012 01:18, Matthew Leach wrote: Hi, When building UML against 3.7-rc2 I encounter the following build error: # make ARCH=uml scripts/kconfig/conf --silentoldconfig arch/x86/um/Kconfig CHK include/generated/uapi/linux/version.h

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
On 24.10.2012 11:09, Matthew Leach wrote: Hi Richard, Richard Weinberger writes: Does this patch fix the issue? Your patch fixed the initial error, but I now get: Okay, we have to get rid of all struct sig_infos. A patch is on the way. Thanks, //richard -- To unsubscribe from this list

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
Am Wed, 24 Oct 2012 00:18:34 +0100 > I have tracked this down to [1] where, indeed, the type of sig_info is > different; the second parameter in signal.c is 'siginfo_t' where as in > as-layout.h the second parameter's type is declared as 'struct > siginfo'. > > [1]: d3c1cfcdb43e023ab1b1c7a555cd9e9

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
Am Wed, 24 Oct 2012 20:48:52 +0100 schrieb Matthew Leach : > > Richard Weinberger writes: > > Am Wed, 24 Oct 2012 00:18:34 +0100 > >> I have tracked this down to [1] where, indeed, the type of > >> sig_info is different; the second parameter in signal.c is &

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
Am Wed, 24 Oct 2012 21:06:25 +0100 schrieb Matthew Leach : > Richard Weinberger writes: > > Am Wed, 24 Oct 2012 20:48:52 +0100 > > schrieb Matthew Leach : > > > >> > >> Richard Weinberger writes: > >> > Am Wed, 24 Oct 2012 00:18:34 +0100 &g

Re: [REGRESSION] uml: signal.c build errors

2012-10-24 Thread Richard Weinberger
Am Wed, 24 Oct 2012 21:13:55 +0100 schrieb Matthew Leach : > Richard Weinberger writes: > > > Am Wed, 24 Oct 2012 21:06:25 +0100 > > schrieb Matthew Leach : > > > >> Richard Weinberger writes: > >> > Am Wed, 24 Oct 201

Re: [PATCH 05/14] userns: Convert hostfs to use kuid and kgid where appropriate

2012-09-23 Thread Richard Weinberger
Am 21.09.2012 02:28, schrieb Eric W. Biederman: > From: "Eric W. Biederman" > > Cc: Jeff Dike > Cc: Richard Weinberger > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman > --- Looks sane to me. Acked-by: Richard Weinberger BTW: How you do test

[PATCH 06/10] UBI: Wire-up ->fm_sem

2012-09-24 Thread Richard Weinberger
Fastmap uses ->fm_sem to stop EBA changes while writing a new fastmap. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/eba.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 8af2ebf..50b3045 100

[PATCH 05/10] UBI: Add fastmap bits to build.c

2012-09-24 Thread Richard Weinberger
Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/build.c | 71 -- 1 files changed, 67 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 3497703..cc7c03c 100644 --- a/drivers/mtd/ubi/build.c +++ b

[PATCH 01/10] UBI: Add fastmap on-flash data structures

2012-09-24 Thread Richard Weinberger
Add the on-flash data structures neeed by fastmap to ubi-media.h Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/ubi-media.h | 137 +++ 1 files changed, 137 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi

[PATCH 09/10] UBI: Add fastmap core

2012-09-24 Thread Richard Weinberger
Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/fastmap.c | 1560 + 1 files changed, 1560 insertions(+), 0 deletions(-) create mode 100644 drivers/mtd/ubi/fastmap.c diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c new file

[PATCH 10/10] UBI: Wire-up fastmap

2012-09-24 Thread Richard Weinberger
Make fastmap known to Kconfig, UBI Makefile and MAINTAINERS. Signed-off-by: Richard Weinberger --- MAINTAINERS |6 ++ drivers/mtd/ubi/Kconfig | 20 drivers/mtd/ubi/Makefile |1 + 3 files changed, 27 insertions(+), 0 deletions(-) diff --git a

[PATCH 08/10] UBI: Add fastmap support to the WL sub-system

2012-09-24 Thread Richard Weinberger
To make fastmap possible the WL sub-system needs some changes. Mostly to support fastmaps pools. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/wl.c | 576 ++ 1 files changed, 531 insertions(+), 45 deletions(-) diff --git a/drivers/mtd

[PATCH 07/10] UBI: Add fastmap stuff to attach.c

2012-09-24 Thread Richard Weinberger
- Export compare_lebs() as fastmap needs this function. - Implement fastmap scan logic. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/attach.c | 387 +++--- 1 files changed, 259 insertions(+), 128 deletions(-) diff --git a/drivers/mtd/ubi

UBI: Fastmap request for inclusion (v18)

2012-09-24 Thread Richard Weinberger
UBI Fastmap is an optional feature which stores the physical to logical eraseblock relations in a checkpoint (called fastmap) to reduce the initialization time of UBI. The current init time of UBI is proportional to the number of physical erase blocks on the FLASH device. With fastmap enabled the s

[PATCH 04/10] UBI: Add self_check_eba()

2012-09-24 Thread Richard Weinberger
self_check_eba() compares two ubi_attach_info objects. Fastmap uses this function for self checks. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/eba.c | 96 + 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/drivers/mtd

[PATCH 02/10] UBI: Add fastmap stuff to ubi.h

2012-09-24 Thread Richard Weinberger
This patch adds fastmap specific data structures to ubi.h. It moves also struct ubi_work to ubi.h as it is now needed for more than one c file. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/ubi.h | 119 +++- drivers/mtd/ubi/wl.c | 24

[PATCH 03/10] UBI: Export next_sqnum()

2012-09-24 Thread Richard Weinberger
Fastmap needs next_sqnum(), rename it to ubi_next_sqnum() and make it non-static. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/eba.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index a26d7d2

Re: [PATCH/resend/bypass] um: Preinclude include/linux/kern_levels.h

2012-09-25 Thread Richard Weinberger
Am Tue, 25 Sep 2012 22:37:13 +0200 schrieb Geert Uytterhoeven : > On Tue, Sep 25, 2012 at 9:43 PM, Al Viro > wrote: > > On Tue, Sep 25, 2012 at 12:20:55PM -0700, Linus Torvalds wrote: > >> IOW, this part of the patch: > >> > >> - c_flags = -Wp,-MD,$(depfile) $(USER_CFLAGS) -include user.h >

[PATCH 01/10] UBI: Add fastmap on-flash data structures

2012-09-26 Thread Richard Weinberger
Add the on-flash data structures neeed by fastmap to ubi-media.h Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/ubi-media.h | 137 +++ 1 files changed, 137 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/ubi/ubi-media.h b/drivers/mtd/ubi

[PATCH 07/10] UBI: Add fastmap stuff to attach.c

2012-09-26 Thread Richard Weinberger
- Export compare_lebs() as fastmap needs this function. - Implement fastmap scan logic. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/attach.c | 386 +++--- drivers/mtd/ubi/build.c |2 +- drivers/mtd/ubi/ubi.h|2 +- 3 files changed

UBI: Fastmap request for inclusion (v19)

2012-09-26 Thread Richard Weinberger
UBI Fastmap is an optional feature which stores the physical to logical eraseblock relations in a checkpoint (called fastmap) to reduce the initialization time of UBI. The current init time of UBI is proportional to the number of physical erase blocks on the FLASH device. With fastmap enabled the s

[PATCH 10/10] UBI: Wire-up fastmap

2012-09-26 Thread Richard Weinberger
Make fastmap known to Kconfig, UBI Makefile and MAINTAINERS. Signed-off-by: Richard Weinberger --- MAINTAINERS |6 ++ drivers/mtd/ubi/Kconfig | 20 drivers/mtd/ubi/Makefile |1 + 3 files changed, 27 insertions(+), 0 deletions(-) diff --git a

[PATCH 08/10] UBI: Add fastmap support to the WL sub-system

2012-09-26 Thread Richard Weinberger
To make fastmap possible the WL sub-system needs some changes. Mostly to support fastmaps pools. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/wl.c | 575 ++ 1 files changed, 531 insertions(+), 44 deletions(-) diff --git a/drivers/mtd

[PATCH 09/10] UBI: Add fastmap core

2012-09-26 Thread Richard Weinberger
Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/fastmap.c | 1560 + 1 files changed, 1560 insertions(+), 0 deletions(-) create mode 100644 drivers/mtd/ubi/fastmap.c diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c new file

[PATCH 06/10] UBI: Wire-up ->fm_sem

2012-09-26 Thread Richard Weinberger
Fastmap uses ->fm_sem to stop EBA changes while writing a new fastmap. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/eba.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index d56ae1c..0e11671 100

[PATCH 05/10] UBI: Add fastmap bits to build.c

2012-09-26 Thread Richard Weinberger
Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/build.c | 68 -- 1 files changed, 65 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 3497703..c9b99be 100644 --- a/drivers/mtd/ubi/build.c +++ b

[PATCH 04/10] UBI: Add self_check_eba()

2012-09-26 Thread Richard Weinberger
self_check_eba() compares two ubi_attach_info objects. Fastmap uses this function for self checks. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/eba.c | 96 + 1 files changed, 96 insertions(+), 0 deletions(-) diff --git a/drivers/mtd

[PATCH 03/10] UBI: Export next_sqnum()

2012-09-26 Thread Richard Weinberger
Fastmap needs next_sqnum(), rename it to ubi_next_sqnum() and make it non-static. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/eba.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index a26d7d2

Re: [PATCH 01/10] UBI: Add fastmap on-flash data structures

2012-09-26 Thread Richard Weinberger
Artem, Am Wed, 26 Sep 2012 13:33:11 +0300 schrieb Artem Bityutskiy : > Richard, thanks, here is the deal I suggest > > 1. I do not really have time to review this in details. > 2. I do not want to block this either > 3. I want to merge this to 3.7 with come pre-conditions (see below) >as "Exp

[PATCH 02/10] UBI: Add fastmap stuff to ubi.h

2012-09-26 Thread Richard Weinberger
This patch adds fastmap specific data structures to ubi.h. It moves also struct ubi_work to ubi.h as it is now needed for more than one c file. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/ubi.h | 116 - drivers/mtd/ubi/wl.c | 24

Re: [PATCH v4 1/4] lib: Introduce atomic MMIO modify

2013-08-24 Thread Richard Weinberger
Am 24.08.2013 21:58, schrieb Ezequiel Garcia: > On Sat, Aug 24, 2013 at 08:27:10PM +0200, richard -rw- weinberger wrote: >> On Sat, Aug 24, 2013 at 5:35 PM, Ezequiel Garcia >> wrote: >>> Some platforms have MMIO regions that are shared across orthogonal >>> subsystems. This commit implements a pos

Re: [PATCH v4 1/4] lib: Introduce atomic MMIO modify

2013-08-24 Thread Richard Weinberger
Am 24.08.2013 22:49, schrieb Ezequiel Garcia: > On Sat, Aug 24, 2013 at 10:35:34PM +0200, Richard Weinberger wrote: >> Am 24.08.2013 21:58, schrieb Ezequiel Garcia: >>> On Sat, Aug 24, 2013 at 08:27:10PM +0200, richard -rw- weinberger wrote: >>>> On Sat, Aug 24, 20

[PATCH] UBI: fix refill_wl_user_pool()

2013-08-26 Thread Richard Weinberger
If no free PEBs are available refill_wl_user_pool() must not return with -ENOSPC immediately. It has to block till produce_free_peb() produced a free PEB. Reported-and-Tested-by: Richard Genoud Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/wl.c | 4 1 file changed, 4 deletions

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Richard Weinberger
Am 03.10.2013 17:00, schrieb Artem Bityutskiy: > On Sat, 2013-09-28 at 15:55 +0200, Richard Weinberger wrote: >> If no free PEBs are available refill_wl_user_pool() must not >> return with -ENOSPC immediately. >> It has to block till produce_free_peb() produced a free PE

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Richard Weinberger
Am 03.10.2013 17:27, schrieb Artem Bityutskiy: > On Thu, 2013-10-03 at 17:08 +0200, Richard Weinberger wrote: >> Am 03.10.2013 17:00, schrieb Artem Bityutskiy: >>> On Sat, 2013-09-28 at 15:55 +0200, Richard Weinberger wrote: >>>> If no free PEBs are available

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Richard Weinberger
Am 03.10.2013 18:00, schrieb Artem Bityutskiy: > On Thu, 2013-10-03 at 17:53 +0200, Richard Weinberger wrote: >> Am 03.10.2013 17:27, schrieb Artem Bityutskiy: >>> On Thu, 2013-10-03 at 17:08 +0200, Richard Weinberger wrote: >>>> Am 03.10.2013 17:00, schrieb Artem Bit

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Richard Weinberger
Am 03.10.2013 18:41, schrieb Artem Bityutskiy: > On Thu, 2013-10-03 at 18:35 +0200, Richard Weinberger wrote: >> Am 03.10.2013 18:00, schrieb Artem Bityutskiy: >>> On Thu, 2013-10-03 at 17:53 +0200, Richard Weinberger wrote: >>>> Am 03.10.2013 17:27, schrieb Artem Bit

Re: [PATCH] fs: make sure we do not read beyond allocation

2013-10-04 Thread Richard Weinberger
On Fri, Oct 4, 2013 at 8:05 AM, Dmitry Vyukov wrote: > On Fri, Oct 4, 2013 at 12:57 AM, Al Viro wrote: >> On Thu, Oct 03, 2013 at 12:36:08PM -0700, Kees Cook wrote: >>> > Kees, try to think for a minute[1]. Really. We have general-purpose >>> > ... >>> > [1] yes, yes, I know - the mere mention

Re: [PATCH] fs: make sure we do not read beyond allocation

2013-10-04 Thread Richard Weinberger
Am 04.10.2013 12:53, schrieb Dmitry Vyukov: > On Fri, Oct 4, 2013 at 2:38 PM, Richard Weinberger > wrote: >>>>>> ... >>>>>> [1] yes, yes, I know - the mere mention of security should've prevented >>>>>> such >>>>>&g

Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u".

2013-10-05 Thread Richard Weinberger
On Sat, Oct 5, 2013 at 5:46 PM, Chen Gang wrote: > On 10/05/2013 11:41 PM, Joe Perches wrote: >> On Sat, 2013-10-05 at 23:19 +0800, Chen Gang wrote: >>> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so >>> need set MAX_NAMELEN 11 instead of 10. >> >> %d can be negative. >> >>

Re: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u".

2013-10-05 Thread Richard Weinberger
Am 05.10.2013 19:06, schrieb Chen Gang: > On 10/06/2013 12:50 AM, Chen Gang wrote: >> On 10/06/2013 12:08 AM, Richard Weinberger wrote: >>> On Sat, Oct 5, 2013 at 5:46 PM, Chen Gang wrote: >>>> On 10/05/2013 11:41 PM, Joe Perches wrote: >>>>> On Sa

Re: [PATCHv3] uml: Fix which_tmpdir failure when /dev/shm is a symlink, and in other edge cases

2013-07-08 Thread Richard Weinberger
Am 08.07.2013 22:19, schrieb Tristan Schmelcher: > From: Tristan Schmelcher > > which_tmpdir did the wrong thing if /dev/shm was a symlink (e.g., to > /run/shm), > if there were multiple mounts on top of each other, if the mount(s) were > obscured by a later mount, or if /dev/shm was a prefix of

Re: [PATCH] UBI: fix refill_wl_user_pool()

2013-09-04 Thread Richard Weinberger
Am 26.08.2013 12:08, schrieb Richard Weinberger: > If no free PEBs are available refill_wl_user_pool() must not > return with -ENOSPC immediately. > It has to block till produce_free_peb() produced a free PEB. > > Reported-and-Tested-by: Richard Genoud > Signed-off-by:

[PULL] UML updates for 3.12

2013-09-07 Thread Richard Weinberger
, //richard Richard Weinberger (8): um: hostfs: Fix writeback um: Implement probe_kernel_read() um: ubd: Add REQ_FLUSH suppport um: ubd: Introduce submit_request() um: Cleanup SIGTERM handling um: Run UML

Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only

2013-10-07 Thread Richard Weinberger
ne wanting to use checkpatch to check for this can easily enough > enable --strict or turn on LONG_LINE explicitly, but it shouldn't be > part of the default warnings. > > Signed-off-by: Josh Triplett As I'm not a huge fan of the 80-character limit, Acked-by: Richard Weinber

Global do_signal() cleanup

2013-10-08 Thread Richard Weinberger
This patch series moves all remaining archs to the get_signal() and signal_setup_done() functions. Currently these archs use open coded variants of the said functions. Further, unused parameters get removed from get_signal_to_deliver(), tracehook_signal_handler() and signal_delivered(). After all

[PATCH 04/29] blackfin: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/blackfin/kernel/signal.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/arch/blackfin/kernel/signal.c b

[PATCH 01/29] arc: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/arc/kernel/signal.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/arch/arc/kernel/signal.c b/arch/arc

[PATCH 05/29] c6x: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/c6x/kernel/signal.c | 43 ++- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/arch/c6x/kernel/signal.c b/arch

[PATCH 03/29] avr32: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/avr32/kernel/signal.c | 43 ++- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/arch/avr32/kernel/signal.c b

[PATCH 02/29] arm64: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/arm64/include/asm/signal32.h | 7 +++--- arch/arm64/kernel/signal.c| 48 --- arch/arm64/kernel/signal32.c | 8

[PATCH 08/29] h8300: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/h8300/kernel/signal.c | 81 +++--- 1 file changed, 34 insertions(+), 47 deletions(-) diff --git a/arch/h8300/kernel/signal.c b

[PATCH 06/29] cris: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/cris/arch-v10/kernel/signal.c | 79 -- arch/cris/arch-v32/kernel/signal.c | 77 +++-- 2 files

[PATCH 14/29] microblaze: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/microblaze/kernel/signal.c | 48 +++-- 1 file changed, 17 insertions(+), 31 deletions(-) diff --git a/arch/microblaze/kernel

[PATCH 07/29] frv: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/frv/kernel/signal.c | 99 +++- 1 file changed, 40 insertions(+), 59 deletions(-) diff --git a/arch/frv/kernel/signal.c b

[PATCH 09/29] hexagon: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/hexagon/kernel/signal.c | 45 ++-- 1 file changed, 18 insertions(+), 27 deletions(-) diff --git a/arch/hexagon/kernel/signal.c

[PATCH 12/29] m68k: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/m68k/kernel/signal.c | 63 ++- 1 file changed, 24 insertions(+), 39 deletions(-) diff --git a/arch/m68k/kernel/signal.c b

[PATCH 10/29] ia64: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. This inverts also the return codes of force_sigsegv_info() and setup_frame() to follow the kernel convention. Signed-off-by: Richard Weinberger --- arch/ia64/kernel/signal.c | 42

[PATCH 19/29] powerpc: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. This inverts also the return codes of setup_*frame() to follow the kernel convention. Signed-off-by: Richard Weinberger --- arch/powerpc/kernel/signal.c| 31 +++ arch/powerpc

[PATCH 20/29] s390: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/s390/kernel/compat_signal.c | 77 +-- arch/s390/kernel/entry.h | 4 +- arch/s390/kernel/signal.c| 79

[PATCH 17/29] openrisc: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/openrisc/kernel/signal.c | 53 --- 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/arch/openrisc/kernel

[PATCH 24/29] um: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/um/include/shared/frame_kern.h | 12 -- arch/um/kernel/signal.c | 27 +- arch/x86/um/signal.c| 45

[PATCH 22/29] sh: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/sh/kernel/signal_32.c | 79 ++-- arch/sh/kernel/signal_64.c | 82 ++ 2 files

[PATCH 27/29] get_signal_to_deliver: remove regs and cookie args

2013-10-08 Thread Richard Weinberger
Both arguments are unused, remove them. Signed-off-by: Richard Weinberger --- include/linux/signal.h | 5 ++--- kernel/signal.c| 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/linux/signal.h b/include/linux/signal.h index 2ac423b..735e0a3 100644 --- a

[PATCH 26/29] xtensa: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/xtensa/kernel/signal.c | 43 --- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/arch/xtensa/kernel/signal.c b

[PATCH 25/29] unicore32: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/unicore32/kernel/signal.c | 48 ++ 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/arch/unicore32/kernel

[PATCH 29/29] Clean up signal_delivered()

2013-10-08 Thread Richard Weinberger
- Pass a ksignal struct to it - Remove unused regs parameter - Make it private as it's nowhere outside of kernel/signal.c is used Signed-off-by: Richard Weinberger --- include/linux/signal.h | 1 - kernel/signal.c| 21 - 2 files changed, 8 insertions(+

[PATCH 21/29] score: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/score/kernel/signal.c | 43 ++- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/arch/score/kernel/signal.c b

[PATCH 28/29] tracehook_signal_handler: Remove sig, info, ka and regs

2013-10-08 Thread Richard Weinberger
These parameters are nowhere used, so we can remove them. Signed-off-by: Richard Weinberger --- include/linux/tracehook.h | 8 +--- kernel/signal.c | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/include/linux/tracehook.h b/include/linux/tracehook.h index

[PATCH 26/29] xtensa: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/xtensa/kernel/signal.c | 43 --- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/arch/xtensa/kernel/signal.c b

[PATCH 23/29] tile: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/tile/include/asm/compat.h | 3 +-- arch/tile/kernel/compat_signal.c | 29 ++--- arch/tile/kernel/signal.c| 54

[PATCH 15/29] mips: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/mips/include/asm/abi.h | 10 +++ arch/mips/kernel/signal.c | 66 --- arch/mips/kernel/signal32.c | 39

[PATCH 16/29] mn10300: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/mn10300/kernel/signal.c | 89 ++-- 1 file changed, 36 insertions(+), 53 deletions(-) diff --git a/arch/mn10300/kernel/signal.c

[PATCH 13/29] metag: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/metag/kernel/signal.c | 55 -- 1 file changed, 24 insertions(+), 31 deletions(-) diff --git a/arch/metag/kernel/signal.c b

[PATCH 18/29] parisc: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/parisc/kernel/signal.c | 58 +++-- 1 file changed, 24 insertions(+), 34 deletions(-) diff --git a/arch/parisc/kernel/signal.c

[PATCH 11/29] m32r: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
Use the more generic functions get_signal() signal_setup_done() for signal delivery. Signed-off-by: Richard Weinberger --- arch/m32r/kernel/signal.c | 47 --- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/arch/m32r/kernel/signal.c b

Re: Global do_signal() cleanup

2013-10-08 Thread Richard Weinberger
Am 08.10.2013 15:38, schrieb Michal Simek: > On 10/08/2013 01:27 PM, Richard Weinberger wrote: >> This patch series moves all remaining archs to the get_signal() and >> signal_setup_done() functions. Currently these archs use open coded >> variants of the said functi

Re: [PATCH 01/29] arc: Use get_signal() signal_setup_done()

2013-10-08 Thread Richard Weinberger
email server quirk. /me got your first mail. > Anyways, > > On 10/08/2013 04:57 PM, Richard Weinberger wrote: >> Use the more generic functions get_signal() signal_setup_done() >> for signal delivery. > > I never realized Al has added the infrastructure already (ba

Re: [PATCH 28/29] tracehook_signal_handler: Remove sig, info, ka and regs

2013-10-08 Thread Richard Weinberger
Am 08.10.2013 17:45, schrieb Al Viro: > On Tue, Oct 08, 2013 at 01:36:18PM +0200, Richard Weinberger wrote: >> These parameters are nowhere used, so we can remove them. > > I'm not sure it's a good idea... OTOH, it probably has no business in > tracehook.h any

Re: [PATCH 27/29] get_signal_to_deliver: remove regs and cookie args

2013-10-08 Thread Richard Weinberger
Am 08.10.2013 17:52, schrieb Christoph Hellwig: > On Tue, Oct 08, 2013 at 01:36:17PM +0200, Richard Weinberger wrote: >> Both arguments are unused, remove them. > > And with the get_signal macro left as the only caller, that one should > become the implementation function. W

  1   2   3   4   5   6   7   8   9   10   >