Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

S.Çağlar Onur wrote: Hi; Following patch silents net/bluetooth/hci_sysfs.c: In function `del_conn': net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: M

Tabs, spaces, indent and 80 character lines

and changing the CodeStyle to be something like "maximum 80 characters-wide lines, with a tab-setting of 8 spaces", that is possible + easier to write code-checkers [2]. Or are we really that concerned about the disk-space? ;) 2 cents away... /Richard Knutsson [1] As has been pointe

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet.

Re: Tabs, spaces, indent and 80 character lines

Benny Halevy wrote: On Feb. 24, 2008, 7:40 -0800, Richard Knutsson <[EMAIL PROTECTED]> wrote: Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: Why hinder a developer who prefer 2, 4, 6 or any other != 8 width? I guess we co

Re: Tabs, spaces, indent and 80 character lines

Krzysztof Halasa wrote: Richard Knutsson <[EMAIL PROTECTED]> writes: I guess we could use tabs only at the line start, for indentation only. Rather hard to implement, most text editors can't do that yet. You mean for split lines? Syntactic indentation v

Re: Tabs, spaces, indent and 80 character lines

Miles Bader wrote: Why do people even respond to these trolls...? -Miles Obviously, this must to have been discussed before, with a clear conclusion. Unfortunately, I have not, during my ~2 years on the list, seen anything of the sort and would like to, in that case, request a small direct

Re: [PATCH 1/3] ipc: Convert handmade 'max' to max().

Sorry for the late response, have been away during the holidays. Andrew Morton wrote: On Mon, 17 Dec 2007 03:35:55 +0100 (MET) Richard Knutsson <[EMAIL PROTECTED]> wrote: Convert handmade 'max' to max(). ... --- a/ipc/msg.c +++ b/ipc/msg.c @@ -473,7 +473,7 @@ asmlinkage

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

f (err) - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); return err; } Hi Mathieu What about changing the __FUNCTION__ to __func__, while you are at it? Richard Knutsson -- To unsubscribe from this list: se

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[E

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 12:44:56 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when t

Re: [patch 1/5] Introduce __WARN()

Arjan van de Ven wrote: On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example...

[PATCH][SCSI] megaraid: Convert from "scsi.h" to (and friends)

Convert glue-include "scsi.h" to (and friends). (binary sizes) allyesconfig: before: 260132 after: 260048 allmodconfig: before: 261740 after: 261656 Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Do not have the hardware, but since it co

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

Andre Noll wrote: On 17:40, Andi Kleen wrote: Here's a proposal for some useful code transformations the kernel janitors could do as opposed to running checkpatch.pl. Here's my take on drivers/scsi/sg.c. It's only compile-tested on x86-64. ... and x86 with all(yes|mod)config. :)

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

David Miller wrote: From: Richard Knutsson <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 15:37:46 +0100 David Miller wrote: But this time I'll just let you know up front that I don't see much value in this patch. It is not a clear improvement to replace int's with

[PATCH] mm/mmap: Remove sparse-warning (NULL as 0).

Fixing: CHECK mm/mmap.c mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1623:29: warning: Using plain integer as NULL pointer mm/mmap.c:1944:29: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Ad

[PATCH] kernel/params.c: Remove sparse-warning (different signedness).

Fixing: CHECK kernel/params.c kernel/params.c:329:41: warning: incorrect type in argument 8 (different signedness) kernel/params.c:329:41:expected int *num kernel/params.c:329:41:got unsigned int * Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on x86 wi

[PATCH] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and &q

[PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Remove local definition of TRUE/FALSE. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h index d5d092c..4484778 100644 --- a/drivers/net/ipg.h +++ b/drivers/net/ipg.h @@ -490,38 +490,34 @@ enum ipg_regs { *

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

Pekka Enberg wrote: Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson <[EMAIL PROTECTED]> wrote: Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree: http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=c

[PATCH 2/6] pcmcia/3c574_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:695:7: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/3c574_cs.c:636:6: originally declared here Signed-off-by: Richard Knutson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/3c574_cs.c b/driver

[PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3c574_cs.c:196:14: warning: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Rich

[PATCH 3/6] pcmcia/axnet_cs: Make functions static

Fixing: CHECK drivers/net/pcmcia/axnet_cs.c drivers/net/pcmcia/axnet_cs.c:994:5: warning: symbol 'ax_close' was not declared. Should it be static? drivers/net/pcmcia/axnet_cs.c:1017:6: warning: symbol 'ei_tx_timeout' was not declared. Should it be static? Signed-off-

[PATCH 4/6] pcmcia/axnet_cs: Make use of 'max()' instead of handcrafted one

Use 'max(x,y)' instead of 'x < y ? y : x'. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c index 8d910a3..96931cc 100644 --- a/drivers/net/pcmcia/axnet_cs.c +++ b/drivers/net/pcmcia/

[PATCH 5/6] pcmcia/fmvj18x_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/fmvj18x_cs.c drivers/net/pcmcia/fmvj18x_cs.c:1205:6: warning: symbol 'i' shadows an earlier one drivers/net/pcmcia/fmvj18x_cs.c:1179:9: originally declared here Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/dr

[PATCH 6/6] pcmcia/pcnet_cs: Fix 'shadow variable' warning

Fixing: CHECK drivers/net/pcmcia/pcnet_cs.c drivers/net/pcmcia/pcnet_cs.c:523:15: warning: symbol 'hw_info' shadows an earlier one drivers/net/pcmcia/pcnet_cs.c:148:18: originally declared here Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/dr

Re: [PATCH 1/6] pcmcia/3c574_cs: Fix dubious bitfield warning

Alan Cox wrote: On Tue, 11 Dec 2007 05:32:38 +0100 (MET) Richard Knutsson <[EMAIL PROTECTED]> wrote: Fixing: CHECK drivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c574_cs.c:194:13: warning: dubious bitfield without explicit `signed' or `unsigned' drivers/net/pcmcia/3

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

Vegard Nossum wrote: Hi, On Nov 28, 2007 7:51 AM, Richard Knutsson <[EMAIL PROTECTED]> wrote: Vegard Nossum wrote: +static int Not 'static bool'? +page_is_tracked(struct page *page) Why not returning 'false' and 'true'?

[PATCH 1/2] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Remove a gcc-2.95 requirement. Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmodconfig".

[PATCH 2/2] ivtv: Remove a invalid shadow-variable

Remove the shadowing 'struct v4l2_chip_ident *chip', since it already exists and makes the if-statement useless. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and "allmodconfig". diff --git a/drivers/medi

Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes

Hans Verkuil wrote: On Sunday 02 December 2007 18:46, Richard Knutsson wrote: Fix "warning: Using plain integer as NULL pointer". Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> Remove a gcc-2.95 requirement. NACK! The main v4l-dvb repository that contains

[PATCH] ivtv: Some general fixes

Fix "warning: Using plain integer as NULL pointer". Convert 'x < y ? x : y' to use min() instead. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Signed-off-by: Hans Verkuil <[EMAIL PROTECTED]> --- Compile-tested on i386 with "allyesconfig" and &q

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

es? Do you use integers for ASCII characters too? It can also avoid some potential bugs like the 'if (i == TRUE)'... What is wrong with 'size_t' (since it is unsigned, compared to (some) 'int')? /Richard Knutsson -- To unsubscribe from this list: send the line "

Re: [patch 02/13] dio: ARRAY_SIZE() cleanup

Geert Uytterhoeven wrote: -#define NUMNAMES (sizeof(names) / sizeof(struct dioname)) +#define NUMNAMES ARRAY_SIZE(names) Why not replace NUMNAMES? /Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

[PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig & allmodconfig. utdebug.c |2 ++ utmisc.c |4 2 files changed, 6 insertions(+) diff --git a/drivers/acpi/utilities/utdebug.c b/dr

[PATCH] net/irda/parameters.c: Trivial fixes

nel/src/net/irda/parameters.c:573:2: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/net/irda/parameters.c b/net/irda/parameters.c index 2627dad..bf19071 100644 --- a

[PATCH] [MIPS]: Compliment va_start() with va_end().

Compliment va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- ieee754.c |2 ++ ieee754dp.c |2 ++ ieee754sp.c |2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/mips/math-emu/ieee754.c b/arch/mips/math-emu/ieee754.c index 946aee3..c

[PATCH] kernel: Compliment va_copy with va_end()

Compliment va_copy() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig & allmodconfig. diff --git a/kernel/audit.c b/kernel/audit.c index f93c271..836626c 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -1245,6 +1245,7

[PATCH] include/asm-m68k: Remove atari_joystick.h

Remove include/asm-m68k/atari_joystick.h and clean up. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Not compiled, but should be trivial. (if FIXED_ATARI_JOYSTICK is defined somehow, please tell how) b/arch/m68k/atari/atakeyb.c|8 b/arch/m68k/atari/atari_k

Re: [PATCH] net/irda/parameters.c: Trivial fixes

Samuel Ortiz wrote: Hi Richard, On Sat, Nov 24, 2007 at 09:44:05PM +0100, Richard Knutsson wrote: Make a single va_start() -> va_end() path + fixing: Ok, this should be 2 separate patches then. Thought about it, but they were so simple, I believed they would better be mer

[PATCH] [REISERFS]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. BTW, the nested if()'s (lines above) may look better if unnested. diff --git a/fs/reiserfs/prints.c b/fs/reiserfs/prints.c in

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

we do)) and to automated searches (that is how I found this one). I suppose some implementation could allocate memory at va_start, but in practice, does this happen? Not sure what you mean. Bob cu Richard Knutsson [1] http://www.cs.utah.edu/dept/old/texinfo/glibc-manual-0.02/library

Re: [PATCH] [ACPI] utilities/: Compliment va_start() with va_end().

med quite messy. When it comes to va_end() and maintainers, they often seem positive to this. I guess the occasional lack off va_end() is usually an oversight. -Original Message- From: Richard Knutsson [mailto:[EMAIL PROTECTED] Sent: Monday, November 26, 2007 4:16 PM To: Moore, Robert Cc:

Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

hy use '0' instead of 'false'? } static void tcrypt_complete(struct crypto_async_request *req, int err) cu Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] [VIDEO]: Complement va_start() with va_end().

Complement va_start() with va_end(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c index ad02329..996b494 100644 --- a/drivers/media/video/saa5

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. s

[PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Complement va_start() with va_end() + minor style fixes in the same function. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested on i386 with allyesconfig and allmodconfig. Thanks to WANG Cong for pointing out the missing 'style fix'-description. (Sorry about

Re: [PATCH] [VIDEO]: Complement va_start() with va_end() + style fixes

Please ignore the previous patch. Have resent it, but since my mail-client (Thunderbird) seem to be having a bad day, I had to use 'sendpatchset' and it can't continue on a thread. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

gs & (1 << PG_slab)) +return address_get_shadow_slab(address, head); + +return NULL; +} + +static int 'static bool'? +test(void *shadow, unsigned int size) +{ +switch (size) { +case 8: +return *(uint8_t *) shadow == 0xff; +case 16: +return

[PATCH 1/3] ipc: Convert handmade 'max' to max().

Convert handmade 'max' to max(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- msg.c |2 +- sem.c |2 +- shm.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c

[PATCH 2/3] msg.h: Convert m_ts from int to size_t.

Convert m_ts ("message text size") from int to size_t. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Remove some trailing spaces, since we are in the neighborhood. diff --git a/include/linux/msg.h b/include/linux/msg.h index 10a3d5a..7a61952 100644 --- a/include/l

[PATCH 3/3] ipc: Convert handmade 'min' to min().

Convert handmade 'min' to min(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Dependent on 'msg->m_ts' being changed from int to size_t. diff --git a/ipc/msg.c b/ipc/msg.c index fdf3db5..74d0709 100644 --- a/ipc/msg.c +++ b/ipc/msg.c @@ -920,7 +920,7 @@ o

[PATCH] kernel: Convert to generic boolean-functions

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- diff --git a/include/linux/relay.h b/include/linux/relay.h index 6cd8c44..70f4dc9 100644 --- a/include/linux/relay.h +++ b/include/linux/relay.h @@ -175,7 +175,7 @@ extern void relay_subbufs_consumed(struct rchan

[PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.

'acpi_gbl_system_awake_and_running' is no longer used, only assigned. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl drivers/acpi/hardware/hwsleep.c |5 - drivers/acpi/utilities/utglobal.c |1

[PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Convert to use the generic boolean. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl (warned about long lines, but it is not introduced by this patch) dpt_i2o.c | 22 +++--- dpti.h|9 ++--- 2

[PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6f56528 100644 --- a/drivers/scsi/lpfc/lpfc_hw.h +++ b/drivers/scsi/lpfc/lpfc_hw.h @@ -3

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool initialized:8; + bool in_use:8; /* is the

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote: Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is

Re: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

Denys Vlasenko wrote: On Tuesday 30 October 2007 10:54, Richard Knutsson wrote: Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote: I just don't see the reason why expressing a boolean as an integer. Some advantage? This is C, not Java, or some other highly-typed language. if (int) and if (ptr) are perfectly acceptable

Re: [PATCH] mtrr use type bool

{ return -ENODEV; } - The rest looks good :) Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] mtrr use type bool

Lennart Sorensen wrote: On Wed, Oct 31, 2007 at 04:27:31PM +0100, Richard Knutsson wrote: Paul Jimenez wrote: - usage_table[i] = usage_table[replace] + !!increment; + usage_table[i] = usage_table[replace] + increment; This

Re: [PATCH] mtrr use type bool

Paul Jimenez wrote: On Wednesday, Oct 31, 2007, Richard Knutsson writes: if (likely(replace < 0)) usage_table[i] = 1; else { - usage_table[i] = usage_table[replace] + !!increm

[PATCH] sonypi: Fix initialization warning

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)): drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c index 73037a4..2

Re: [PATCH] sonypi: Fix initialization warning

Thomas Renninger wrote: On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote: Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)): drivers/char/sonypi.c:1153: warning: initialization from incompatible p

Re: [PATCH 02/68] 0 -> NULL, for arch/arm

buse the '!' on "regular" variables. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 06/68] 0 -> NULL, for arch/frv

o know if the thing being tested is a pointer ... dont know if the sparse utility would be able to pick it out as i'm not familiar with what level that thing runs at Didn't he mean "x == NULL" > "!x"? Richard Knutsson (wrote this offline so if someone has alr

Re: [PATCH 06/68] 0 -> NULL, for arch/frv

Mike Frysinger wrote: On 7/31/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Mike Frysinger wrote: On 7/27/07, Robin Getz <[EMAIL PROTECTED]> wrote: If there is a definite style or semantic preference that everyone should live with - does it make sense to p

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

even earlier. The expression; nothing is new under the sun comes to mind ;) Anyway, glad to see someone actually implementing it. Thanks! Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

be even ".maintainer" now). It has also been suggested that the file should be at the lowest common pathway to avoid duplication. Downside is the added need to search for the file... Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH] [2/2many] - FInd the maintainer(s) for a patch - MAINTAINERS

Joe Perches wrote: It helps when you do the diff the right way. Describe the new F: pattern Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d3a0684..0d7f856 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -83,6 +83,13 @@ S: Status, one of the following

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

Kok, Auke wrote: Richard Knutsson wrote: Kok, Auke wrote: Joe Perches wrote: I grew weary of looking up the appropriate maintainer email address(es) to CC: for a patch. I added flags to the MAINTAINERS file F:file pattern for each maintained block and a script to parse the modified

[PATCH] arch/i386: Convert to generic boolean

Convert to generic boolean (+ some minor cleanup). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on i386 Diffed against Linus' git-tree Sent on 2007-05-12, no replys amd.c |2 -- cyrix.c |2 +- gener

[PATCH] drivers/net/3c505: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/3c505.c b/drivers/net/3c505.c index e985a85.

[PATCH] drivers/net/tlan: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/tlan.c b/drivers/net/tlan.c index 106dc1e.

[PATCH] drivers/net/tokenring: Convert to generic boolean

Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenrin

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

simple "diffstat -p1 -l | xargs " makes the day. Too bad, as Joe pointed out, it does not include relevant ML. cheers Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [libata] fix 'if(' and similar areas that lack whitespace

eadw(mmio + NV_ADMA_CTL ); /* flush posted write */ and here udelay(1); writew(tmp & ~NV_ADMA_CTL_CHANNEL_RESET, mmio + NV_ADMA_CTL); - readw( mmio + NV_ADMA_CTL );/* flush posted write */ + readw(mmio + NV_ADMA_CTL ); /* flush posted write */ and here

Re: [RFC] How to (automatically) find the correct maintainer(s)

Stefan Richter wrote: On 14 Jan, Richard Knutsson wrote: Stefan Richter wrote: [getting a wrong contact from looking at the MAINTAINERS file] Hopefully, but I think it is asking much of the maintainer and then there will certanly be confused/frustrated submitter who don't kno

Re: [RFC] How to (automatically) find the correct maintainer(s)

Matthias Schniedermeyer wrote: Richard Knutsson wrote: Matthias Schniedermeyer wrote: Richard Knutsson wrote: Any thoughts on this is very much appreciated (is there any flaws with this?). The thought that crossed my mind was: Why not do the same thing that

Re: [RFC] How to (automatically) find the correct maintainer(s)

Stefan Richter wrote: On 15 Jan, Matthias Schniedermeyer wrote: Stefan Richter wrote: On 14 Jan, Richard Knutsson wrote: (Really liked the idea to have a "Maintainer"-button next to "Help" in *config) Rhetorical question: What will thi

Re: [RFC] How to (automatically) find the correct maintainer(s)

Stefan Richter wrote: On 14 Jan, Richard Knutsson wrote: Stefan Richter wrote: May I remind that whoever uses scripts to figure out contacts should better double-check what the script found out for him. [...] During development, that's a given. But I would hope that whe

Re: [RFC] How to (automatically) find the correct maintainer(s)

Matthias Schniedermeyer wrote: Richard Knutsson wrote: Stefan Richter wrote: On 15 Jan, Matthias Schniedermeyer wrote: Stefan Richter wrote: On 14 Jan, Richard Knutsson wrote: (Really liked the idea to have a "Maintainer"-butt

[PATCH] sysctl.h: Comment out unused constants

Comment out unused constants in include/linux/sysctl.h. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with allyes and allmod under i386. diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index 81480e6..c8d2cb7 100644 --- a/include/linux/sysctl.h

Re: [PATCH] sysctl.h: Comment out unused constants

H. Peter Anvin wrote: Richard Knutsson wrote: Comment out unused constants in include/linux/sysctl.h. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> NAK as all hell. This file exports an interface to userspace, and thus should be maintained indefinitely. Oh, then I misunderstoo

[PATCH] drivers/scsi/BusLogic: Replace 'boolean' by 'bool'

Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- "sed s/boolean/bool/" and remove "typedef bool boolean". Minor comment-alignment fixes. BusLogic.c includes FlashPoint.c. Compile-tested with "allyes" and "allmod" on i386. Bu

Re: [PATCH] Introduce simple TRUE and FALSE boolean macros.

Nicholas Miell wrote: On Sun, 2007-01-21 at 05:03 -0500, Robert P. J. Day wrote: Introduce the TRUE and FALSE boolean macros so that everyone can stop re-inventing them, and remove the one occurrence in the source tree that clashes with that change. If you're going to introduce true

Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7

ot;$TMP" sed -e '/^+/s/[ ]*$//' <"$TMP" >"$1" rm "$TMP" } for i in "$@" do strip1 "$i" done " http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt I believe: for i in "

Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7

Satoru Takeuchi wrote: At Tue, 23 Jan 2007 00:42:31 +0100, Richard Knutsson wrote: Michal Piotrowski wrote: How about this script? "d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such white

Re: [PATCH 4/8] UML - audio driver formatting

Isn't labels _suppose_ to be spaced? (due to "grep", if I'm not mistaken)... kfree(kbuf); return(err); } @@ -99,12 +99,12 @@ static ssize_t hostaudio_read(struct fil Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH 4/8] UML - audio driver formatting

Randy Dunlap wrote: On Tue, 02 Jan 2007 02:52:33 +0100 Richard Knutsson wrote: Jeff Dike wrote: Whitespace and style fixes. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/hostaudio_kern.c | 160 +-- 1 file changed, 73 inse

Re: [KJ][RFC][PATCH] BIT macro cleanup

b.h @@ -68,7 +68,6 @@ # define print_var(X,Y...) #endif -#define BIT(x) (1ul<<(x)) #define POW2(x)(1ul<<(x)) Maybe you can clean up POW2 as well (or define it as "#define POW2(x) BIT(x)") Also, it seems your mail-client swapped the tabs to spaces (aka not

Re: [KJ][RFC][PATCH] BIT macro cleanup

Milind Choudhary wrote: On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: > +#define BITWRAP(nr)(1UL << ((nr) % BITS_PER_LONG)) > > & make the whole input subsystem use it > The change is huge, more than 125 files using input.h > & almost all u

Re: [KJ][RFC][PATCH] BIT macro cleanup

Dmitry Torokhov wrote: On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Milind Choudhary wrote: > On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: >> > +#define BITWRAP(nr)(1UL << ((nr) % BITS_PER_LONG)) >> > >> > & make the

Re: [KJ][RFC][PATCH] BIT macro cleanup

IT since it works as well with 'char' as 'long'. Also, I think it would be best if the name indicated it is a 'long'. Am a little bit curious why you would like it in bitops.h, but won't complain if you do (think you have noticed my view of it ;)) Richard K

Re: [KJ][RFC][PATCH] BIT macro cleanup

Dmitry Torokhov wrote: On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Dmitry Torokhov wrote: > I was not talking about name (I hate BITWRAP) but behavior. Oh, my bad :) > >> but mainly since it only enables wrapping of the long-type. > > I'd provde BIT an

Re: [KJ][RFC][PATCH] BIT macro cleanup

Dmitry Torokhov wrote: On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Dmitry Torokhov wrote: > > Hm, I thought as was clear, but apparently I messed up explaining my > position: > > 1. I don't like BITWRAP name at all and I don't want anything like >

[PATCH] drivers/mfd/sm501.c: Replace pci_module_init with pci_register_driver

Replace pci_module_init with pci_register_driver Signed-off-by: Richard Knutson <[EMAIL PROTECTED]> --- Compile-tested with "allyes", "allmod" & "allno" on i386 diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 5c5a1e2..c707c8e 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c

[PATCH -mm] drivers/net/vioc/vioc_driver.c: Replace pci_module_init with pci_register_driver

Replace pci_module_init with pci_register_driver Signed-off-by: Richard Knutson <[EMAIL PROTECTED]> --- Not compile-tested (but should be correct!) --- a/drivers/net/vioc/vioc_driver.c2007-02-24 10:04:03.0 +0100 +++ b/drivers/net/vioc/vioc_driver.c2007-02-24 10:05:01.0 +01

Re: [KJ][RFC][PATCH] BIT macro cleanup

Vojtech Pavlik wrote: On Fri, Feb 23, 2007 at 11:43:44PM +0100, Richard Knutsson wrote: Is the reason for the modulo to put a bitmask larger then the variable into an array? The complementary LONG() macro will tell you the index of an array of longs where the bit should be set

Re: [KJ][RFC][PATCH] BIT macro cleanup

t;< ((nr) % BITS_PER_LONG)) #define LLBIT(nr) (1ULL << (nr)) thoughts Since you guys seems in agreement about the silenced compiler-warnings, then I will rest my case. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

  1   2   >