2015-09-02 21:19 GMT-04:00 Greg Kroah-Hartman :
> Turns out this file is never even built, you should just remove it :)
You're right, although it seems that is one of the "To-dos" of that
module, as the references I find about the config variable to allow
the compiling of that file is the followin
Oh well. Actually you did it. I answered while pulling the git...
Sorry for that unuseful mail! :)
2015-09-05 12:25 GMT-04:00 Raphaël Beamonte :
> 2015-09-02 21:19 GMT-04:00 Greg Kroah-Hartman :
>> Turns out this file is never even built, you should just remove it :)
>
> You'r
2015-09-03 13:00 GMT-04:00 Greg Kroah-Hartman :
> You need to prove that they are aligned before I can take this patch :(
Right!
I looked at those structs using pahole. The structs used are
net_device from include/linux/netdevice.h and sockaddr from
include/linux/socket.h, in which we use the ele
drivers/net/ethernet/intel/i40e/i40e_main.c
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/usb/lan78xx.c
net/8021q/vlan_dev.c
net/batman-adv/soft-interface.c
net/dsa/slave.c
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1
2015-09-07 4:38 GMT-04:00 Jiri Olsa :
> Adding part of the kernel's interface:
> inline void * __must_check ERR_PTR(long error);
> inline long __must_check PTR_ERR(__force const void *ptr);
> inline bool __must_check IS_ERR(__force const void *ptr);
>
> it will be used to propagate error
2015-09-08 16:22 GMT-04:00 Raphaël Beamonte :
> Perhaps a dumb question, but it seems the code is exactly the same as
> in linux/err.h besides the part of the comment you added. Why not
> using that file directly in the other patches then?
I meant include/linux/err.h, from git r
2015-09-08 17:06 GMT-04:00 Arnaldo Carvalho de Melo :
> Em Tue, Sep 08, 2015 at 04:22:39PM -0400, Raphaël Beamonte escreveu:
>> 2015-09-07 4:38 GMT-04:00 Jiri Olsa :
>> > Adding part of the kernel's interface:
>> > inline void * __must_check ERR_PTR
changed, 49 insertions(+)
> create mode 100644 tools/include/linux/err.h
Reviewed-by: Raphaël Beamonte
>
> diff --git a/tools/include/linux/err.h b/tools/include/linux/err.h
> new file mode 100644
> index ..c9ada48f5156
> --- /dev/null
> +++ b/tools/include/linu
ME ':' PE_NAME
> snprintf(&sys_name, 128, "%s-%s", $1, $3);
>
> ALLOC_LIST(list);
> - ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &sys_name,
> $5));
> + ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &a
---
>> tools/perf/util/util.h | 6 ---
>> 9 files changed, 101 insertions(+), 79 deletions(-)
>> create mode 100644 tools/lib/api/fs/tracing_path.c
>> create mode 100644 tools/lib/api/fs/tracing_path.h
>
> Reviewed-by: Mat
2015-09-02 9:12 GMT-04:00 Arnaldo Carvalho de Melo :
> Em Wed, Sep 02, 2015 at 09:56:35AM +0200, Jiri Olsa escreveu:
> Humm, here I think that "_path" may look excessive... But tracing_path__
> better
> than debugfs__, so its progress, applying, if we get a better name, we
> can change this later.
cing_path.h | 3 +++
> tools/perf/builtin-trace.c | 5 ++--
> 4 files changed, 60 insertions(+), 54 deletions(-)
Reviewed-by: Raphaël Beamonte
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
2015-09-02 3:56 GMT-04:00 Jiri Olsa :
> Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs)
> interface that tries to mount the filesystem in case no mount is found.
>
> Link: http://lkml.kernel.org/n/tip-ja49vwfiq2qqkmoxx9yk2...@git.kernel.org
> Signed-off-by: Jiri Olsa
> ---
> to
s/fs.h | 15 +++
> 2 files changed, 50 insertions(+), 9 deletions(-)
The patch is fine by me! My Reviewed-by can be added if wanted :o)
Reviewed-by: Raphaël Beamonte
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
2015-09-04 12:44 GMT-04:00 Arnaldo Carvalho de Melo :
> From: Jiri Olsa
>
> Moving debugfs__strerror_open out of api/fs/debugfs.c, because it's not
> debugfs specific. It'll be changed to consider tracefs mount as well in
> following patches.
>
> Renaming it into tracing_path__strerror_open_tp to
2015-09-04 12:44 GMT-04:00 Arnaldo Carvalho de Melo :
> From: Jiri Olsa
>
> Adding FSTYPE__mount (where FSTYPE is, as of now, one of sysfs, procfs,
> debugfs, tracefs) method that tries to mount the filesystem in case no
> mount of FSTYPE is found.
>
> Signed-off-by: Jiri Olsa
> Cc: Raphael Beamo
Reuse some local temporary variables to reduce line length under the maximum
of 80 characters, as per the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
Add some temporary variables to reduce line length under the maximum
of 80 characters, as per the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 130 ++---
1 file changed, 88 insertions(+), 42 deletions(-)
diff --git
2015-08-17 5:08 GMT-04:00 Dan Carpenter :
> Pull it in one indent level... But actually this macro has a return in
> the middle of it, so it just introduces bugs all over the place like
> eating cookies in bed. We should just delete it instead.
You're right!
I'll clean those macro up and send a
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 2 --
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wlan_cfg.c
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8 +++
drivers/staging/wilc1000/linux_wlan_common.h | 32 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wil
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging
driver.
Raphaël
Raphaël Beamonte (5):
staging: wilc1000: remove DECLARE_WILC_BUFFER()
staging: wilc1000: remove FREE_WILC_BUFFER()
staging: wilc1000: replace MALLOC_WILC_BUFFER() macro to avoid
possible memory leak
staging: wilc1000: use pr_* instead of printk
staging: wilc1000: remove
2015-08-17 13:47 GMT-04:00 Dan Carpenter :
>> - printk("[Sendconfigpkt]Get Timed out\n");
>> + pr_debug("[Sendconfigpkt]Get Timed out\n");
>
>
> Possibly pr_err()?
Yep. My mistake. I'll do the same for Set Timed Out also!
>> -
Hi,
Following comments from Dan Carpenter, please find the following
revised patches.
Raphaël
Raphaël Beamonte (5):
staging: wilc1000: remove void function return statements that are not
useful
staging: wilc1000: use pr_* instead of printk
staging: wilc1000: remove
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging/wilc1000
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers
The MACRO_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wil
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c| 4
drivers/staging/wilc1000/linux_wlan.c| 1 -
drivers/staging/wilc1000/wilc_exported_buf.c | 4 +---
drivers/staging/wilc1000/wilc_wlan.c | 3 ---
drivers/staging/wilc1000/wilc_wlan_cfg.c
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/coreconfigurator.c | 4 ++--
drivers/staging/wilc1000/linux_wlan.c| 8
drivers/staging/wilc1000/linux_wlan_common.h | 28 ++--
drivers/staging/wilc1000/linux_wlan_sdio.c | 2 +-
drivers
The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wil
2015-08-17 15:41 GMT-04:00 Arend van Spriel :
> Probable MACRO_WILC_BUFFER should be MALLOC_WILC_BUFFER here.
Good catch!
> There is really no need to print an error message here. kmalloc will blurb
> enough info when it fails.
Ok!
> So these buffers are globals? So does this driver support mul
2015-08-18 0:24 GMT-04:00 Sudip Mukherjee :
>> + netdev_err("[Sendconfigpkt]Get Timed out\n");
> This will not compile. you can not just replace printk with
> netdev_*, you need to mention a net_device.
You're right! I'm making a lot of mistakes. It seems I called the m
2015-08-18 1:02 GMT-04:00 Sudip Mukherjee :
> since you are modifying these lines for consistent spacing, it will be
> better to have:
> (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit
> This should be:
> priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >>
2015-08-18 1:30 GMT-04:00 Sudip Mukherjee :
> These are not externs. These are forward declarations.
I copied the message from checkpatch. Will edit that to make it more accurate!
Thanks,
Raphaël
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message t
2015-08-18 1:44 GMT-04:00 Sudip Mukherjee :
> I think that will be better, since you are sending the patch for
> consistent spacing.
Actually, going through the bunch of patches, it seems that the
whitespace neatening one is taking care of that. That one patch was
mostly about taking care of the c
Some switch and case were not be at the same indent level.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 190 -
1 file changed, 95 insertions(+), 95 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
Fix "code indent should use tabs where possible" checkpatch error
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_co
Quoted strings should not be split to help text grep in the source.
All quoted strings that were split have thus been merged to one unique
quoted string each to follow the code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 8
1 file changed, 4
Use #include instead of
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 9a658b4..2ab0a98 100644
--- a/drivers
Adds whitespaces to separate the variables declarations and the
function content.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 44 +++---
1 file changed, 41 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u
Light code refactoring to keep the lines under 80 characters to follow
the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 1248 ++--
1 file changed, 850 insertions(+), 398 deletions(-)
diff --git a/drivers/staging
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
Two sets of parentheses were used to contain the same statement.
In those cases, one of them has been removed, as unnecessary.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Clean-up the file by using a cleaner spacing around symbols and
words. Mostly use the automatic checkpatch whitespacing fixes.
This takes care of the consistent spacing errors reported by
checkpatch.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 288
braces {} are not necessary for any arm of a statement containing
one statement on each side.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b
An else statement is not useful after a return.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
Checkpatch was giving a "externs should be avoided in .c files" because
of these forward declarations. As these were not useful in this case,
they have been removed.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 6 --
1 file changed, 6 deletions(-)
Whitespaces are not necessary before a quoted newline. Remove those.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
kfree(NULL) is safe and the checks were not required.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
Fix "else should follow close brace" checkpatch error.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
ind
Replace C99 // comments by /* comments */ to follow the
kernel code style. Remove some unuseful comments.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 636 -
1 file changed, 316 insertions(+), 320 deletions(-)
diff --git a/drivers
A missing struct keyword in variable declaration triggered a
need consistent spacing around '*' code style error. The struct
keyword thus has been added everywhere for the rtl8192_rx_info
struct, and therefore its typedef removed as not needed anymore.
Signed-off-by: Raphaë
void function return statement was not useful in this case.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 2ab0a98..90c5907
nings, 4909 lines checked
And after patches:
total: 0 errors, 0 warnings, 5379 lines checked
Please let me know if there is anything else I can do to improve these
patches!
Thanks,
Raphaël
Raphaël Beamonte (19):
staging: rtl8192u: r8192U_core: fix switch and case indent code style
A space existed before the close parenthesis of an if statement. This patch
removes it to follow the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
2015-08-18 5:15 GMT-04:00 Dan Carpenter :
> To be honest, I have lost track of this patchset. If you are planning
> to redo the other patches can you send it in a new thread?
Actually, Greg already included the "return statement" and
"DECLARE_WILC_BUFFER" ones.
The replacement of printk by netdev
2015-08-18 7:43 GMT-04:00 Matt Fleming :
>> - perror("Can't open event dir");
>> + debugfs__strerror_open(
>> + errno, errbuf, sizeof(errbuf),
>> + evt_path + strlen(debugfs_mountpoint) + 1);
>
> The way the filename is passed seems a
It was just a wrapper around kfree(), so call that instead.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers/staging/wilc1000
Hi,
As requested, here are the two remaining ready patches of this
patchset. I pulled and rebased against staging-testing just now.
They should thus be usable without problem!
Thanks,
Raphaël
Raphaël Beamonte (2):
staging: wilc1000: remove FREE_WILC_BUFFER()
staging: wilc1000: replace
The MALLOC_WILC_BUFFER() macro was using a return statement, and didn't
take care of possible memory leaks and subsequent bugs when it was failing
after succeeding some allocations. This patch corrects this behavior.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wil
Fix a macro with complex value coding style error.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/gdm72xx/usb_ids.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/usb_ids.h
b/drivers/staging/gdm72xx/usb_ids.h
index 8ce544d..7afb9ba 100644
Replace C99 // comments by /* comments */ to follow the kernel
coding style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/vt6655/rf.c | 535 ++--
1 file changed, 269 insertions(+), 266 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b
> This doesn't apply to my staging-next branch of staging-git :(
>
> Please rebase and resend.
Seems it already has been fixed in your staging-git!
I switched to this git for future changes. (was using the linux.git)
Thanks!
Raphaël
--
To unsubscribe from this list: send the line "unsubscribe lin
Some switch and case were not be at the same indent level.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 190 -
1 file changed, 95 insertions(+), 95 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
:
total: 0 errors, 0 warnings, 5379 lines checked
Thanks,
Raphaël
Raphaël Beamonte (20):
staging: rtl8192u: r8192U_core: fix switch and case indent code style
error
staging: rtl8192u: r8192U_core: fix consistent spacing code style
error
staging: rtl8192u: t8192U_core: fix space before
Externs should be avoided in .c files. These one were not useful and
are thus removed.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
void function return statement was not useful in this case
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 5bbfa91..ff8c197 100644
braces {} are not necessary for any arm of a statement containing
one statement on each side.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b
Use #include instead of
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 9477a0f..5bbfa91 100644
--- a/drivers
A missing struct keyword in variable declaration triggered a
need consistent spacing around '*' code style error.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r81
Replace C99 // comments by /* comments */ to follow the
kernel code style. Remove some unuseful comments.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 636 -
1 file changed, 316 insertions(+), 320 deletions(-)
diff --git a/drivers
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 270 -
1 file changed, 135 insertions(+), 135 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index b204782..7d3a626 100644
Light code refactoring to keep the lines under 80 characters to follow
the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 1248 ++--
lib/Kconfig.debug |2 +-
2 files changed, 851 insertions
Fix else should follow close brace code style error.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index fe92021
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 511e979..0048cff 100644
--- a/drivers/staging/rtl8192u
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 44 +++---
1 file changed, 41 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 5aae096..511e979 100644
--- a
A space existed before the close parenthesis of an if statement. This patch
removes it to follow the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
Whitespaces are not necessary before a quoted newline.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
An else statement is not useful after a return.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u
Fix multiple occurences of the need consistent spacing code style error
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index 99d7f7c..25d31fe 100644
--- a/drivers/staging/rtl8192u
Fix code indent should use tabs where possible code style error
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index
kfree(NULL) is safe and the checks were not required.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
Globals should not be initialized to 0 or NULL.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b
Open braces should be on the same line as if and for statements.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/linux_wlan.c | 3 +--
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
Hello,
Please find in following emails code style patches for the driver
wilc1000 in staging.
Raphaël
Raphaël Beamonte (3):
staging: wilc1000: code style: fix macro with multiple statements
staging: wilc1000: code style: fix globals initialized to false
staging: wilc1000: code style: fix
Macros with multiple statements should be enclosed in a do - while loop
Signed-off-by: Raphaël Beamonte
---
drivers/staging/wilc1000/wilc_exported_buf.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_exported_buf.c
b/drivers
make that patch better in hope that it
could be used upstream and thus close that bug report!
Thanks,
Raphaël
Raphaël Beamonte (1):
perf: fix confusing messages when not able to read trace events files
tools/perf/util/parse-events.c | 14 +++---
tools/perf/util/parse-options.c | 6
g the debugfs__strerror_open
function to report the access error in a more elegant way, as well as
provide a hint like the one provided by the perf trace tool.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=100781
Signed-off-by: Raphaël Beamonte
---
tools/perf/util/parse-events.c
original content.
The last patch gets rid of the last WARNING of checkpatch about
the 80 lines, as well as the TO_DO_LIST macro that was used in
that module to comment out unused or unusable code.
Thanks,
- R.
[1]: https://lkml.org/lkml/2015/8/19/173
Raphaël Beamonte (16):
staging: rtl8192u
Add some temporary variables to reduce line length under the maximum
of 80 characters, as per the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 139 ++---
1 file changed, 94 insertions(+), 45 deletions(-)
diff --git
Rename variable to a shorter name to allow easier code
refactoring in following patch.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
Refactor code to avoid multiple check of same boolean value, and to
make the code clearer. This patches also implements the necessary
changes for the code lines in this function to be under 80 chars.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 259
Rename variable to a shorter name to allow easier code refactoring
in following patch.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 84 +-
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8192u
Reverse some conditions to clean the code and allow to have lines
under 80 characters, as to follow the kernel code style.
Signed-off-by: Raphaël Beamonte
---
drivers/staging/rtl8192u/r8192U_core.c | 48 ++
1 file changed, 25 insertions(+), 23 deletions(-)
diff
1 - 100 of 141 matches
Mail list logo
