[PATCH 0/2] Add devfreq runtime pm support

2013-03-21 Thread Rajagopal Venkat
Patch to bind devfreq to runtime pm framework. The device devfreq is automatically suspended with pm_runtime_suspend() and resumed with pm_runtime_resume(). Discussed at http://comments.gmane.org/gmane.linux.linaro.devel/13787 Rajagopal Venkat (2): PM / devfreq: Fix compiler warnings PM

[PATCH 1/2] PM / devfreq: Fix compiler warnings

2013-03-21 Thread Rajagopal Venkat
Fix compiler warnings generated when devfreq is not enabled (CONFIG_PM_DEVFREQ is not set). Signed-off-by: Rajagopal Venkat --- include/linux/devfreq.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index

[PATCH 2/2] PM / devfreq: tie suspend/resume to runtime-pm

2013-03-21 Thread Rajagopal Venkat
. pm_runtime_resume(dev) will resume device devfreq(if available) after device is resumed from runtime pm core. Signed-off-by: Rajagopal Venkat --- drivers/base/power/runtime.c | 18 ++- drivers/devfreq/devfreq.c| 51 ++ include/linux/devfreq.h

Re: [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

2013-02-04 Thread Rajagopal Venkat
MyungJoo, Ping. On 15 January 2013 16:51, Rajagopal Venkat wrote: > On 14 January 2013 20:06, MyungJoo Ham wrote: >> On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat >> wrote: >>> Set devfreq device min and max frequency limits when device >>> is added to dev

Re: [PATCH 3/3] PM / devfreq: account suspend/resume for stats

2013-02-04 Thread Rajagopal Venkat
MyungJoo, Ping. On 15 January 2013 17:16, Rajagopal Venkat wrote: > On 14 January 2013 20:18, MyungJoo Ham wrote: >> On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat >> wrote: >>> devfreq stats is not taking device suspend and resume into >>> account. Fix it.

Re: [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

2013-02-05 Thread Rajagopal Venkat
On 5 February 2013 12:21, MyungJoo Ham wrote: > On Tue, Jan 15, 2013 at 8:21 PM, Rajagopal Venkat > wrote: >> On 14 January 2013 20:06, MyungJoo Ham wrote: >>> On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat >>> wrote: >>>> Set devfreq device min an

Re: [PATCH] PM / devfreq: add comments and Documentation

2013-02-05 Thread Rajagopal Venkat
On 5 February 2013 15:15, MyungJoo Ham wrote: > - Added missing ABI documents > - Added comments to clarify the objectives of functions > > Signed-off-by: MyungJoo Ham Acked-by: Rajagopal Venkat > --- > Documentation/ABI/testing/sysfs-class-devfreq | 20 +

Re: [PATCH v2 2/2] PM / devfreq: tie suspend/resume to runtime-pm

2013-04-04 Thread Rajagopal Venkat
On 3 April 2013 23:46, Kevin Hilman wrote: > Rajagopal Venkat writes: > >> Devfreq core suspend/resume of a device is explicitly handled >> by devfreq driver through devfreq_suspend_device() and >> devfreq_resume_device() apis typically called from runtime >> suspen

Re: [PATCH v2 2/2] PM / devfreq: tie suspend/resume to runtime-pm

2013-04-04 Thread Rajagopal Venkat
On 3 April 2013 23:46, Kevin Hilman wrote: > Rajagopal Venkat writes: > >> Devfreq core suspend/resume of a device is explicitly handled >> by devfreq driver through devfreq_suspend_device() and >> devfreq_resume_device() apis typically called from runtime >> suspen

[PATCH 0/3] devfreq: Add support for devices which can idle

2012-09-03 Thread Rajagopal Venkat
devfreq_resume_device() are added to support suspend/resume of device devfreq. -- Rajagopal Venkat (3): devfreq: core updates to support devices which can idle devfreq: Add suspend and resume apis devfreq: Add current freq callback in device profile Documentation/ABI/testing/sysfs-class-devfreq

[PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-03 Thread Rajagopal Venkat
sets ground for adding suspend/resume events. The devfreq apis are not modified and are kept intact. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 376 ++ drivers/devfreq/governor.h| 9 + drivers/devfreq

[PATCH 3/3] devfreq: Add current freq callback in device profile

2012-09-03 Thread Rajagopal Venkat
new sysfs node to expose governor predicted next target frequency. Signed-off-by: Rajagopal Venkat --- Documentation/ABI/testing/sysfs-class-devfreq | 7 +++ drivers/devfreq/devfreq.c | 14 ++ include/linux/devfreq.h | 3 +++ 3 files

[PATCH 2/3] devfreq: Add suspend and resume apis

2012-09-03 Thread Rajagopal Venkat
Add devfreq suspend/resume apis for devfreq users. This patch supports suspend and resume of devfreq load monitoring, required for devices which can idle. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 26 ++ drivers/devfreq/governor.h

Re: [PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-13 Thread Rajagopal Venkat
d locking for these functions? > Event_handler callback won't want the properties in devfreq to be changed > externally during its execution. Agree. > > Plus, please edit Documentation/ABI entry (central_polling is being removed) Done. > > Other than that, it looks

[PATCH v2 0/3] devfreq: Add support for devices which can idle

2012-09-13 Thread Rajagopal Venkat
From: Rajagopal Venkat This patchset updates devfreq core to add support for devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume when device is back online. patch 1 introduce core design changes

[PATCH v2 2/3] devfreq: Add suspend and resume apis

2012-09-13 Thread Rajagopal Venkat
From: Rajagopal Venkat Add devfreq suspend/resume apis for devfreq users. This patch supports suspend and resume of devfreq load monitoring, required for devices which can idle. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 26

[PATCH v2 1/3] devfreq: Core updates to support devices which can idle

2012-09-13 Thread Rajagopal Venkat
From: Rajagopal Venkat Prepare devfreq core framework to support devices which can idle. When device idleness is detected perhaps through runtime-pm, need some mechanism to suspend devfreq load monitoring and resume back when device is online. Present code continues monitoring unless device is

[PATCH v2 3/3] devfreq: Add current freq callback in device profile

2012-09-13 Thread Rajagopal Venkat
From: Rajagopal Venkat Devfreq returns governor predicted frequency as current frequency via sysfs interface. But device may not support all frequencies that governor predicts. So add a callback in device profile to get current freq from driver. Also add a new sysfs node to expose governor

Re: Re: [PATCH v3 1/3] devfreq: Core updates to support devices which can idle

2012-10-02 Thread Rajagopal Venkat
s with governors via events to perform >> >> specific actions. These events include start/stop devfreq. >> >> This sets ground for adding suspend/resume events. >> >> >> >> The devfreq apis are not modified and are kept intact. >> >> &g

[PATCH v4 0/3] devfreq: Add support for devices which can idle

2012-10-04 Thread Rajagopal Venkat
- handled work suspend/resume contention between devfreq driver and sysfs Changes since v3: - added additonal checks in suspend/resume to avoid invalid usage of apis - added check in devfreq_monitor_start, not to start monitoring when polling_ms is set to zero. -- Rajagopal Venkat (3): devfreq

[PATCH v4 1/3] devfreq: Core updates to support devices which can idle

2012-10-04 Thread Rajagopal Venkat
sets ground for adding suspend/resume events. The devfreq apis are not modified and are kept intact. Signed-off-by: Rajagopal Venkat --- Documentation/ABI/testing/sysfs-class-devfreq | 8 - drivers/devfreq/devfreq.c | 443 +++--- drivers/devfreq/governor.h

[PATCH v4 2/3] devfreq: Add suspend and resume apis

2012-10-04 Thread Rajagopal Venkat
Add devfreq suspend/resume apis for devfreq users. This patch supports suspend and resume of devfreq load monitoring, required for devices which can idle. Signed-off-by: Rajagopal Venkat Acked-by: MyungJoo Ham --- drivers/devfreq/devfreq.c | 28

[PATCH v4 3/3] devfreq: Add current freq callback in device profile

2012-10-04 Thread Rajagopal Venkat
frequency. Signed-off-by: Rajagopal Venkat Acked-by: MyungJoo Ham --- Documentation/ABI/testing/sysfs-class-devfreq | 11 ++- drivers/devfreq/devfreq.c | 14 ++ include/linux/devfreq.h | 3 +++ 3 files changed, 27 insertions(+), 1 deletion

Re: [PATCH v4 0/3] devfreq: Add support for devices which can idle

2012-10-05 Thread Rajagopal Venkat
ince v2: >> - added new helper function for polling interval update >> - handled work suspend/resume contention between devfreq driver >> and sysfs >> >> Changes since v3: >> - added additonal checks in suspend/resume to avoid invalid usage of apis >> - ad

[PATCH v3 0/3] devfreq: Add support for devices which can idle

2012-09-21 Thread Rajagopal Venkat
- Handled work suspend/resume contention between devfreq driver and sysfs -- Rajagopal Venkat (3): devfreq: Core updates to support devices which can idle devfreq: Add suspend and resume apis devfreq: Add current freq callback in device profile Documentation/ABI/testing/sysfs-class-devfreq

[PATCH v3 1/3] devfreq: Core updates to support devices which can idle

2012-09-21 Thread Rajagopal Venkat
sets ground for adding suspend/resume events. The devfreq apis are not modified and are kept intact. Signed-off-by: Rajagopal Venkat --- Documentation/ABI/testing/sysfs-class-devfreq | 8 - drivers/devfreq/devfreq.c | 431 +++--- drivers/devfreq/governor.h

[PATCH v3 3/3] devfreq: Add current freq callback in device profile

2012-09-21 Thread Rajagopal Venkat
frequency. Signed-off-by: Rajagopal Venkat Signed-off-by: MyungJoo Ham --- Documentation/ABI/testing/sysfs-class-devfreq | 11 ++- drivers/devfreq/devfreq.c | 14 ++ include/linux/devfreq.h | 3 +++ 3 files changed, 27 insertions(+), 1

[PATCH v3 2/3] devfreq: Add suspend and resume apis

2012-09-21 Thread Rajagopal Venkat
Add devfreq suspend/resume apis for devfreq users. This patch supports suspend and resume of devfreq load monitoring, required for devices which can idle. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 28 drivers/devfreq/governor.h

Re: [PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-09 Thread Rajagopal Venkat
On 10 September 2012 03:16, Rafael J. Wysocki wrote: > On Monday, September 03, 2012, Rajagopal Venkat wrote: >> Prepare devfreq core framework to support devices which >> can idle. When device idleness is detected perhaps through >> runtime-pm, need some mechanism to

Re: [PATCH 2/3] devfreq: Add suspend and resume apis

2012-09-09 Thread Rajagopal Venkat
On 10 September 2012 03:21, Rafael J. Wysocki wrote: > On Monday, September 03, 2012, Rajagopal Venkat wrote: >> Add devfreq suspend/resume apis for devfreq users. This patch >> supports suspend and resume of devfreq load monitoring, required >> for devices which can idle

Re: [PATCH 3/3] devfreq: Add current freq callback in device profile

2012-09-10 Thread Rajagopal Venkat
On 10 September 2012 03:30, Rafael J. Wysocki wrote: > On Monday, September 03, 2012, Rajagopal Venkat wrote: >> Devfreq returns governor predicted frequency as current >> frequency via sysfs interface. But device may not support >> all frequencies that governor predicts

Re: [PATCH v4 1/3] devfreq: Core updates to support devices which can idle

2012-10-08 Thread Rajagopal Venkat
based monitoring functions or to implement their own mechanism. >> - devfreq core interacts with governors via events to perform >> specific actions. These events include start/stop devfreq. >> This sets ground for adding suspend/resume events. >> >> The devfreq apis are no

Re: [PATCH v4 2/3] devfreq: Add suspend and resume apis

2012-10-08 Thread Rajagopal Venkat
On 8 October 2012 03:31, Rafael J. Wysocki wrote: > On Thursday 04 of October 2012 14:58:33 Rajagopal Venkat wrote: >> Add devfreq suspend/resume apis for devfreq users. This patch >> supports suspend and resume of devfreq load monitoring, required >> for devices which can i

Re: [PATCH v4 1/3] devfreq: Core updates to support devices which can idle

2012-10-10 Thread Rajagopal Venkat
based monitoring functions or to implement their own mechanism. >> - devfreq core interacts with governors via events to perform >> specific actions. These events include start/stop devfreq. >> This sets ground for adding suspend/resume events. >> >> The devfreq apis are no

[PATCH V3] PM / devfreq: tie suspend/resume to runtime-pm

2013-04-17 Thread Rajagopal Venkat
me is done automatically from runtime core, this patch removes the existing devfreq_suspend_device() and devfreq_resume_device() apis. Signed-off-by: Rajagopal Venkat Changes from V2: Updated change log to clarify patch deals with runtime suspend/resume Changes from v1: Improved change lo

Re: [PATCH 2/2] PM / devfreq: tie suspend/resume to runtime-pm

2013-03-22 Thread Rajagopal Venkat
On 21 March 2013 20:32, Alan Stern wrote: > On Thu, 21 Mar 2013, Rajagopal Venkat wrote: > >> Allow device devfreq to be suspend/resume automatically with >> runtime pm suspend/resume. The devfreq drivers should be least >> cared when to suspend/resume the devfreq. >

Re: [PATCH 2/2] PM / devfreq: tie suspend/resume to runtime-pm

2013-03-24 Thread Rajagopal Venkat
On 22 March 2013 23:04, Kevin Hilman wrote: > Hi Rajagopal, > > Rajagopal Venkat writes: > >> Allow device devfreq to be suspend/resume automatically with >> runtime pm suspend/resume. The devfreq drivers should be least >> cared when to suspend/resume the devfre

[PATCH v2 1/2] PM / devfreq: Fix compiler warnings

2013-03-27 Thread Rajagopal Venkat
Fix compiler warnings generated when devfreq is not enabled (CONFIG_PM_DEVFREQ is not set). Signed-off-by: Rajagopal Venkat --- include/linux/devfreq.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index

[PATCH v2 2/2] PM / devfreq: tie suspend/resume to runtime-pm

2013-03-27 Thread Rajagopal Venkat
me-pm, this patch removes the existing devfreq_suspend_device() and devfreq_resume_device() apis. Signed-off-by: Rajagopal Venkat --- drivers/base/power/runtime.c | 21 - drivers/devfreq/devfreq.c| 69 +++--- include/linux/devfreq.h |

[PATCH v2 0/2] Add devfreq runtime pm support

2013-03-27 Thread Rajagopal Venkat
on pm_runtime_resume(). Discussed at http://comments.gmane.org/gmane.linux.linaro.devel/13787 Changes from v1: - improved change log and code comments - added NULL check for devfreq runtime-pm callbacks - Rajagopal Venkat (2): PM / devfreq: Fix compiler warnings PM / devfreq: tie suspend

Re: [PATCH v2] davinci: vpif: add pm_runtime support

2013-04-01 Thread Rajagopal Venkat
On 1 April 2013 12:06, Prabhakar lad wrote: > From: Lad, Prabhakar > > Add pm_runtime support to the TI Davinci VPIF driver. > > Signed-off-by: Lad, Prabhakar > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Sakari Ailus > Cc: Sekhar Nori > --- > Changes for v2:

Re: [PATCH v2] davinci: vpif: add pm_runtime support

2013-04-01 Thread Rajagopal Venkat
On 1 April 2013 13:53, Prabhakar Lad wrote: > On Mon, Apr 1, 2013 at 12:47 PM, Rajagopal Venkat > wrote: >> On 1 April 2013 12:06, Prabhakar lad wrote: >>> From: Lad, Prabhakar >>> >>> Add pm_runtime support to the TI Davinci VPIF driver. >>>

Re: Re: [PATCH 1/3] devfreq: core updates to support devices which can idle

2012-09-17 Thread Rajagopal Venkat
el and it won't happen > often. However, it may behave incorrectly. > > Why don't we simply let the all the struct devfreq protected > when the external code (governors) is probably reading/writing the > protected values? > > This also guarantees that th

[PATCH] clk: allow reparenting of a clock to the orphan list

2013-01-21 Thread Rajagopal Venkat
Allow reparenting of a clock(multiple and single parent) to the orphan list when new parent clock is NULL. Signed-off-by: Rajagopal Venkat --- drivers/clk/clk.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index

[RFC PATCH] PM / devfreq: Add runtime-pm support

2012-11-21 Thread Rajagopal Venkat
suspend the devfreq and pm_runtime_resume() will resume the devfreq. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 145 -- include/linux/devfreq.h | 12 2 files changed, 102 insertions(+), 55 deletions(-) diff --git a/drivers

Re: [PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

2013-01-15 Thread Rajagopal Venkat
On 14 January 2013 20:06, MyungJoo Ham wrote: > On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat > wrote: >> Set devfreq device min and max frequency limits when device >> is added to devfreq, provided frequency table is supplied. >> This helps governors to suggest

Re: [PATCH 2/3] PM / devfreq: fix stats start time stamp

2013-01-15 Thread Rajagopal Venkat
On 14 January 2013 20:12, MyungJoo Ham wrote: > On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat > wrote: >> Mark the stats start time stamp when actual load monitoring is >> started for accuracy. >> > > It appears that you are changing the semantics of the infor

Re: [PATCH 3/3] PM / devfreq: account suspend/resume for stats

2013-01-15 Thread Rajagopal Venkat
On 14 January 2013 20:18, MyungJoo Ham wrote: > On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat > wrote: >> devfreq stats is not taking device suspend and resume into >> account. Fix it. >> >> Signed-off-by: Rajagopal Venkat > > With monitor_suspend(), we ar

Re: [PATCH v3 1/3] devfreq: Core updates to support devices which can idle

2012-09-27 Thread Rajagopal Venkat
based monitoring functions or to implement their own mechanism. >> - devfreq core interacts with governors via events to perform >> specific actions. These events include start/stop devfreq. >> This sets ground for adding suspend/resume events. >> >> The devfreq apis are

Re: [PATCH] clk: remove unreachable code

2013-01-16 Thread Rajagopal Venkat
On 16 January 2013 04:15, Mike Turquette wrote: > Quoting Rajagopal Venkat (2013-01-08 22:29:48) >> while reparenting a clock, NULL check is done for clock in >> consideration and its new parent. So re-check is not required. >> If done, else part becomes unreachable

[PATCH 1/3] PM / devfreq: set min/max freq limit from freq table

2013-01-07 Thread Rajagopal Venkat
Set devfreq device min and max frequency limits when device is added to devfreq, provided frequency table is supplied. This helps governors to suggest target frequency with in limits. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 24 1 file changed

[PATCH 2/3] PM / devfreq: fix stats start time stamp

2013-01-07 Thread Rajagopal Venkat
Mark the stats start time stamp when actual load monitoring is started for accuracy. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 5782c9b

[PATCH 3/3] PM / devfreq: account suspend/resume for stats

2013-01-07 Thread Rajagopal Venkat
devfreq stats is not taking device suspend and resume into account. Fix it. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 2843a22

[RFC PATCH] PM / devfreq: Add runtime-pm support

2013-01-07 Thread Rajagopal Venkat
suspend the devfreq and pm_runtime_resume() will resume the devfreq. Signed-off-by: Rajagopal Venkat --- drivers/devfreq/devfreq.c | 89 ++--- include/linux/devfreq.h | 12 -- 2 files changed, 76 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH] clk: remove unreachable code

2013-01-08 Thread Rajagopal Venkat
while reparenting a clock, NULL check is done for clock in consideration and its new parent. So re-check is not required. If done, else part becomes unreachable. Signed-off-by: Rajagopal Venkat --- drivers/clk/clk.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

Re: [PATCH] clk: remove unreachable code

2013-01-08 Thread Rajagopal Venkat
On 9 January 2013 11:20, Tushar Behera wrote: > On 01/08/2013 06:33 PM, Rajagopal Venkat wrote: >> while reparenting a clock, NULL check is done for clock in >> consideration and its new parent. So re-check is not required. >> If done, else part becomes unreachable. >>

[PATCH] clk: remove unreachable code

2013-01-08 Thread Rajagopal Venkat
while reparenting a clock, NULL check is done for clock in consideration and its new parent. So re-check is not required. If done, else part becomes unreachable. Signed-off-by: Rajagopal Venkat --- drivers/clk/clk.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff

Re: [PATCH 4/4] PM/Devfreq: Add Exynos5-bus devfreq driver for Exynos5250

2013-01-09 Thread Rajagopal Venkat
On 9 January 2013 17:36, Abhilash Kesavan wrote: > Exynos5-bus device devfreq driver monitors PPMU counters and > adjusts operating frequencies and voltages with OPP. ASV should > be used to provide appropriate voltages as per the speed group > of the SoC rather than using a constant 1.025V. > > S