Re: [PATCH net-next v23 03/23] ovpn: add basic interface creation/destruction/management routines

2025-03-16 Thread Qingfang Deng
Hi Antonio, On Wed, 12 Mar 2025 21:54:32 +0100, Antonio Quartulli Wrote: > diff --git a/drivers/net/ovpn/main.c b/drivers/net/ovpn/main.c > index > 28133e7e15e74b8a4a937ed03f70d9f83d7a14c8..e71183e6f42cd801861caaec9eb0f6828b64cda9 > 100644 > --- a/drivers/net/ovpn/main.c > +++ b/drivers/net/ovpn

Re: [PATCH net-next v23 03/23] ovpn: add basic interface creation/destruction/management routines

2025-03-17 Thread Qingfang Deng
On Mon, Mar 17, 2025 at 6:00 PM Antonio Quartulli wrote: > > On 17/03/2025 10:41, Qingfang Deng wrote: > > Hi Antonio, > > > > On Mon, Mar 17, 2025 at 5:23 PM Antonio Quartulli > > wrote: > >>>> +static void ovpn_setup(struct net_device *dev)

Re: [PATCH net-next v23 03/23] ovpn: add basic interface creation/destruction/management routines

2025-03-17 Thread Qingfang Deng
Hi Antonio, On Mon, Mar 17, 2025 at 5:23 PM Antonio Quartulli wrote: > >> +static void ovpn_setup(struct net_device *dev) > >> +{ > >> +netdev_features_t feat = NETIF_F_SG | NETIF_F_HW_CSUM | > >> NETIF_F_RXCSUM | > > > > Do not advertise NETIF_F_HW_CSUM or NETIF_F_RXCSUM, as TX/RX checksum

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-24 Thread Qingfang Deng
Hi Antonio, On Tue, 18 Mar 2025 02:40:44 +0100, Antonio Quartulli wrote: > > This change implements encryption/decryption and > encapsulation/decapsulation of OpenVPN packets. > > Support for generic crypto state is added along with > a wrapper for the AEAD crypto kernel API. > > Signed-off-by:

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Qingfang Deng
Hi Antonio, On Wed, Mar 26, 2025 at 5:41 PM Antonio Quartulli wrote: > >> +/* Get the next packet ID for xmit */ > >> +static inline int ovpn_pktid_xmit_next(struct ovpn_pktid_xmit *pid, u32 > >> *pktid) > >> +{ > >> +const s64 seq_num = atomic64_fetch_add_unless(&pid->seq_num, 1, > >> +

Re: [PATCH net-next v24 09/23] ovpn: implement packet processing

2025-03-26 Thread Qingfang Deng
On Wed, Mar 26, 2025 at 6:22 PM Antonio Quartulli wrote: > >> This is not what we want. > > > > Got it. You could replace it with > > atomic_fetch_add_unless(&pid->seq_num, 1, 0) and check if it wraps > > around to zero. > > What about the first time when seq_num is 0? It will already stop, no? T