mountinfo contents changed when rootfs is ramfs

2020-08-19 Thread Pranay Srivastava
if (opt == -ENOPARAM) + if (opt == -ENOPARAM && strcmp(param->key, "source")) opt = 0; return opt; } so that mountinfo gives the same information as for earlier kernels. Thanks! -- Regards, Pranay Srivastava

Re: [RESEND PATCH]nbd: fix might_sleep warning on socket shutdown

2016-05-01 Thread Pranay Srivastava
Hi, Can the following patch be reviewed? I'm working on some more changes on top of this change, so it'll be really helpful if someone can review this patch and let me know of shortcomings/issues with this. On Sat, Apr 30, 2016 at 11:49 AM, Pranay Kr. Srivastava wrote: > This patch fixes the wa

Re: [RESEND PATCH]nbd: fix might_sleep warning on socket shutdown

2016-05-02 Thread Pranay Srivastava
On Tue, May 3, 2016 at 5:45 AM, Greg KH wrote: > On Mon, May 02, 2016 at 08:58:34AM +0530, Pranay Srivastava wrote: >> Hi, >> >> Can the following patch be reviewed? I'm working on some more changes >> on top of this change, >> so it'll be really helpf

Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning.

2016-05-11 Thread Pranay Srivastava
Greg, Resending as I missed the cc list earlier. On Wed, May 11, 2016 at 2:03 PM, Greg KH wrote: > On Wed, May 11, 2016 at 11:18:30AM +0300, Pranay Kr. Srivastava wrote: >> Signed-off-by: Pranay Kr. Srivastava >> --- >> drivers/block/nbd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] nbd: Move socket shutdown out of spinlock

2016-05-12 Thread Pranay Srivastava
Hi Markus, On Thu, May 12, 2016 at 3:13 PM, Markus Pargmann wrote: > spinlocked ranges should be small and not contain calls into huge > subfunctions. Fix my mistake and just get the pointer to the socket > instead of doing everything with spinlock held. > > Reported-by: Mikulas Patocka > Signe

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

2016-05-23 Thread Pranay Srivastava
Hi Markus On Fri, May 20, 2016 at 1:52 PM, Markus Pargmann wrote: > On Friday 20 May 2016 02:05:36 Pranay Srivastava wrote: >> On Thu, May 19, 2016 at 11:52 AM, Markus Pargmann >> wrote: >> > Hi, >> > >> > On Wed, May 11, 2016 at 11:18:29AM +0300, Pra

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

2016-05-19 Thread Pranay Srivastava
On Thu, May 19, 2016 at 11:52 AM, Markus Pargmann wrote: > Hi, > > On Wed, May 11, 2016 at 11:18:29AM +0300, Pranay Kr. Srivastava wrote: >> This patch fixes the warning generated when a timeout occurs >> on the request and socket is closed from a non-sleep context >> by >> >> 1. Moving the socket

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

2016-05-25 Thread Pranay Srivastava
On Mon, May 23, 2016 at 4:02 PM, Pranay Srivastava wrote: > Hi Markus > > On Fri, May 20, 2016 at 1:52 PM, Markus Pargmann wrote: >> On Friday 20 May 2016 02:05:36 Pranay Srivastava wrote: >>> On Thu, May 19, 2016 at 11:52 AM, Markus Pargmann >>> wrote: >

Re: [PATCH] nbd: Move socket shutdown out of spinlock

2016-05-12 Thread Pranay Srivastava
On Thu, May 12, 2016 at 6:13 PM, Markus Pargmann wrote: > Hi, > > On Thursday 12 May 2016 16:42:31 Pranay Srivastava wrote: >> Hi Markus, >> >> >> On Thu, May 12, 2016 at 3:13 PM, Markus Pargmann wrote: >> > spinlocked ranges should be small and not cont

Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout

2016-05-12 Thread Pranay Srivastava
On Thu, May 12, 2016 at 2:49 PM, Markus Pargmann wrote: > Hi, > > On Wednesday 11 May 2016 11:18:46 Pranay Kr. Srivastava wrote: >> When a timeout occurs or a recv fails, then >> instead of abruplty killing nbd block device >> wait for it's users to finish. >> >> This is more required when filesys

Re: [PATCH 2/2] nbd: Disallow ioctls on disconnected block device

2016-07-16 Thread Pranay Srivastava
Hi, On Fri, Jun 24, 2016 at 2:59 PM, Markus Pargmann wrote: > After NBD_DO_IT exited the block device may still be used. Make sure > that we handle intended disconnects differently and do not allow any > changed of the nbd device. > > This patch should avoid that the nbd-client connects to a diff

Re: [Nbd] [PATCH 2/2] nbd: Disallow ioctls on disconnected block device

2016-07-16 Thread Pranay Srivastava
On Sat, Jul 16, 2016 at 3:02 PM, Alex Bligh wrote: > > On 16 Jul 2016, at 08:42, Pranay Srivastava wrote: > >> So instead can't we put a mechanism in place for network address + mac >> to be same >> for allowing clients to reconnect? Do let me know if this is

Re: [PATCH v5 2/4] nbd: fix might_sleep warning on socket shutdown.

2016-07-16 Thread Pranay Srivastava
Hi Markus, On Sat, Jul 16, 2016 at 2:52 PM, Pranay Kr Srivastava wrote: > From: "Pranay Kr. Srivastava" > > spinlocked ranges should be small and not contain calls into huge > subfunctions. Fix my mistake and just get the pointer to the socket > instead of doing everything with spinlock held. >

Re: [PATCH v5 3/4] make nbd device wait for its users

2016-07-16 Thread Pranay Srivastava
Hi Markus On Sat, Jul 16, 2016 at 4:06 PM, Pranay Kr Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruptly killing nbd block device > wait for its users to finish. > > This is more required when filesystem(s) like > ext2 or

Re: [Nbd] [PATCH 2/2] nbd: Disallow ioctls on disconnected block device

2016-07-16 Thread Pranay Srivastava
On Sat, Jul 16, 2016 at 4:56 PM, Wouter Verhelst wrote: > On Sat, Jul 16, 2016 at 03:38:40PM +0530, Pranay Srivastava wrote: >> Okay. So how about we include some negotiated key which goes in with every >> request which the server could maintain for clients that can be checked whi

Re: [PATCH 1/2] nbd: make nbd device wait for its users

2016-06-24 Thread Pranay Srivastava
Hey Markus, On Fri, Jun 24, 2016 at 2:59 PM, Markus Pargmann wrote: > From: "Pranay Kr. Srivastava" > > When a timeout occurs or a recv fails, then instead of abruplty killing > nbd block device wait for it's users to finish. > > This is more required when filesystem(s) like ext2 or ext3 don't e

Re: [PATCH v2 1/5] nbd: fix might_sleep warning on socket shutdown.

2016-06-09 Thread Pranay Srivastava
Hello On Thu, Jun 2, 2016 at 3:54 PM, Pranay Kr. Srivastava wrote: > spinlocked ranges should be small and not contain calls into huge > subfunctions. Fix my mistake and just get the pointer to the socket > instead of doing everything with spinlock held. > > Reported-by: Mikulas Patocka > Signe

Re: [PATCH v4 1/5]nbd: cleanup nbd_set_socket

2016-07-07 Thread Pranay Srivastava
On Thu, Jun 30, 2016 at 4:32 PM, Pranay Kr. Srivastava wrote: > From: "Pranay Kr. Srivastava" > > This patch > 1) uses spin_lock instead of irq version. > > 2) removes the goto statement in case a socket >is already assigned with simple if-else statement. > > Signed-off-by: Pranay Kr. Srivast

Re: [PATCH v2 4/5]nbd: make nbd device wait for its users.

2016-06-14 Thread Pranay Srivastava
Hi Markus, On Tue, Jun 14, 2016 at 2:29 PM, Markus Pargmann wrote: > > On Thursday 02 June 2016 13:25:00 Pranay Kr. Srivastava wrote: > > When a timeout occurs or a recv fails, then > > instead of abruplty killing nbd block device > > wait for it's users to finish. > > > > This is more required w

Re: [PATCH v2 1/5] nbd: fix might_sleep warning on socket shutdown.

2016-06-14 Thread Pranay Srivastava
Hi On Tue, Jun 14, 2016 at 2:22 PM, Markus Pargmann wrote: > Hi, > > On Thursday 02 June 2016 13:24:57 Pranay Kr. Srivastava wrote: >> spinlocked ranges should be small and not contain calls into huge >> subfunctions. Fix my mistake and just get the pointer to the socket >> instead of doing every

Re: [PATCH v2 4/5]nbd: make nbd device wait for its users.

2016-06-15 Thread Pranay Srivastava
Hey Markus, On Wed, Jun 15, 2016 at 12:00 PM, Markus Pargmann wrote: > Hi Pranay, > > On Tuesday 14 June 2016 15:03:40 Pranay Srivastava wrote: >> Hi Markus, >> >> On Tue, Jun 14, 2016 at 2:29 PM, Markus Pargmann wrote: >> > >> > On Thursday 02 J

Re: [Nbd] [PATCH v2 4/5]nbd: make nbd device wait for its users.

2016-06-15 Thread Pranay Srivastava
On Wed, Jun 15, 2016 at 12:30 PM, Wouter Verhelst wrote: > On Wed, Jun 15, 2016 at 08:30:45AM +0200, Markus Pargmann wrote: >> Thanks for the explanations. I think my understanding was off by one ;).. >> I didn't realize that the DO_IT thread from the userspace has the block >> device open as well

Re: [PATCH v4 3/5]nbd: make nbd device wait for its users

2016-07-13 Thread Pranay Srivastava
On Wed, Jul 13, 2016 at 1:24 PM, Markus Pargmann wrote: > On Sunday 10 July 2016 21:32:07 Pranay Srivastava wrote: >> On Sun, Jul 10, 2016 at 6:32 PM, Markus Pargmann wrote: >> > On 2016 M06 30, Thu 14:02:03 CEST Pranay Kr. Srivastava wrote: >> >> When a timeou

Re: [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

2016-07-13 Thread Pranay Srivastava
On Wed, Jul 13, 2016 at 12:43 PM, Markus Pargmann wrote: > On Sunday 10 July 2016 21:03:05 Pranay Srivastava wrote: >> On Sunday, July 10, 2016, Markus Pargmann wrote: >> > Hi, >> > >> > On 2016 M06 30, Thu 14:02:02 CEST Pranay Kr. Srivastava wrote: >>

Re: [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

2016-07-04 Thread Pranay Srivastava
On Thu, Jun 30, 2016 at 4:32 PM, Pranay Kr. Srivastava wrote: > spinlocked ranges should be small and not contain calls into huge > subfunctions. Fix my mistake and just get the pointer to the socket > instead of doing everything with spinlock held. > > Reported-by: Mikulas Patocka > Signed-off-b

Re: [PATCH 1/1]ext4: Fix WARN_ON_ONCE when marking buffer dirty

2016-07-04 Thread Pranay Srivastava
On Thu, Jun 30, 2016 at 4:42 PM, Pranay Kr. Srivastava wrote: > Signed-off-by: Pranay Kr. Srivastava > --- > fs/ext4/super.c | 30 -- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 3822a5a..8f10715 100644

Re: [PATCH 1/1]ext4: Fix WARN_ON_ONCE when marking buffer dirty

2016-07-04 Thread Pranay Srivastava
On Mon, Jul 4, 2016 at 7:59 PM, Theodore Ts'o wrote: > On Thu, Jun 30, 2016 at 02:12:30PM +0300, Pranay Kr. Srivastava wrote: >> Signed-off-by: Pranay Kr. Srivastava > > The description for why the change is being made should go in the > commit. (No need to put the description in a separate cove

Re: [PATCH 0/4]nbd: fixes for nbd

2016-05-29 Thread Pranay Srivastava
Hi On Tue, May 24, 2016 at 4:56 PM, Pranay Kr. Srivastava wrote: > This patch series fixes the following > > 1) fix might_sleep warning on socket shutdown: >Fix sock_shutdown to avoid calling kernel_sock_shutdown >while holding spin_lock. > > 2)fix various coding standard warnings >Ma

Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

2017-03-24 Thread Pranay Srivastava
On Fri, Mar 24, 2017 at 2:13 PM, Greg KH wrote: > On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote: >> speakup_allocate used GFP_ATOMIC for allocations >> even while during initialization due to it's use >> in notifier call. > > Is that a problem? No that's the way it should

Re: [PATCH v4 1/5]nbd: cleanup nbd_set_socket

2016-07-09 Thread Pranay Srivastava
On Thu, Jul 7, 2016 at 8:26 PM, Pranay Srivastava wrote: > On Thu, Jun 30, 2016 at 4:32 PM, Pranay Kr. Srivastava > wrote: >> From: "Pranay Kr. Srivastava" >> >> This patch >> 1) uses spin_lock instead of irq version. >> >> 2) removes

Re: [PATCH v4 3/5]nbd: make nbd device wait for its users

2016-07-10 Thread Pranay Srivastava
On Sun, Jul 10, 2016 at 6:32 PM, Markus Pargmann wrote: > On 2016 M06 30, Thu 14:02:03 CEST Pranay Kr. Srivastava wrote: >> When a timeout occurs or a recv fails, then >> instead of abruplty killing nbd block device >> wait for its users to finish. >> >> This is more required when filesystem(s) li

Re: [PATCH v2 1/5] nbd: fix might_sleep warning on socket shutdown.

2016-06-13 Thread Pranay Srivastava
Hello, On Thu, Jun 9, 2016 at 3:33 PM, Pranay Srivastava wrote: > > Hello > > > On Thu, Jun 2, 2016 at 3:54 PM, Pranay Kr. Srivastava > wrote: > > spinlocked ranges should be small and not contain calls into huge > > subfunctions. Fix my mistake and just

Re: [PATCH 0/4]nbd: fixes for nbd

2016-06-06 Thread Pranay Srivastava
This got rejected by mailing-list[due to HTML content] so resending it again. On Sat, Jun 4, 2016 at 10:25 AM, Pranay Srivastava wrote: > > > On Thursday, June 2, 2016, Pranay Kr. Srivastava wrote: >> This patch series fixes the following >> >> 1) fix might_sleep

Re: [PATCH 1/2] nbd: make nbd device wait for its users

2016-06-25 Thread Pranay Srivastava
On Fri, Jun 24, 2016 at 2:59 PM, Markus Pargmann wrote: > From: "Pranay Kr. Srivastava" > > When a timeout occurs or a recv fails, then instead of abruplty killing > nbd block device wait for it's users to finish. > > This is more required when filesystem(s) like ext2 or ext3 don't expect > their

Re: [Nbd] [PATCH 3/3]nbd: make nbd device wait for its users

2016-06-25 Thread Pranay Srivastava
Hi Eric, On Fri, Jun 24, 2016 at 7:12 PM, Eric Blake wrote: > On 06/24/2016 04:09 AM, Pranay Kr. Srivastava wrote: >> When a timeout occurs or a recv fails, then >> instead of abruplty killing nbd block device > > s/abruplty/abruptly/ > >> wait for it's users to finish. > > s/it's/its/ > >> >> Th

Re: [PATCH 3/3]nbd: make nbd device wait for its users

2016-06-25 Thread Pranay Srivastava
Hi On Fri, Jun 24, 2016 at 3:39 PM, Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to > disa

Re: [PATCH v3 1/3]nbd: fix might_sleep warning on socket shutdown

2016-06-27 Thread Pranay Srivastava
Hi Markus, On Fri, Jun 24, 2016 at 3:39 PM, Pranay Kr. Srivastava wrote: > spinlocked ranges should be small and not contain calls into huge > subfunctions. Fix my mistake and just get the pointer to the socket > instead of doing everything with spinlock held. > > Reported-by: Mikulas Patocka >

Re: [PATCH 3/3]nbd: make nbd device wait for its users

2016-06-29 Thread Pranay Srivastava
Hi On Wed, Jun 29, 2016 at 12:36 PM, Markus Pargmann wrote: > Hi, > > On Friday 24 June 2016 13:09:36 Pranay Kr. Srivastava wrote: >> When a timeout occurs or a recv fails, then >> instead of abruplty killing nbd block device >> wait for it's users to finish. >> >> This is more required when file

Re: mountinfo contents changed when rootfs is ramfs

2020-08-21 Thread Pranay Srivastava
On Wed, Aug 19, 2020 at 5:20 PM Pranay Srivastava wrote: > > Hello, > > I'm running a system where rootfs is ramfs. For kernel version 5.2.11 > > # cat /proc/self/mountinfo > 0 0 0:1 / / rw - rootfs rootfs rw > %<---snip>% > > while for kernel 5.4.58 >