Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-22 Thread Pramod Gurav
Hi Ritesh, Thanks for the inputs. On 22 September 2016 at 20:02, Ritesh Harjani wrote: > Hi Pramod, >> Thanks Ulf for the comments. Will check this and see if there is >> something of this sort we have to do to achieve auto tuning. >> Adding Ritesh who has been posting some SDHCI MSM patches

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 9 September 2016 at 15:48, Georgi Djakov wrote: > On 09/08/2016 11:02 AM, Adrian Hunter wrote: >> >> On 01/09/16 17:23, Pramod Gurav wrote: >>> >>> Provides runtime PM callbacks to enable and disable clock resources >>> when idle. Also support syst

Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-15 Thread Pramod Gurav
On 15 September 2016 at 15:49, Ulf Hansson wrote: > On 15 September 2016 at 09:59, Pramod Gurav wrote: >> On 9 September 2016 at 15:48, Georgi Djakov wrote: >>> On 09/08/2016 11:02 AM, Adrian Hunter wrote: >>>> >>>> On 01/09/16 17:23, Pramod Gu

Re: [PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-08-30 Thread Pramod Gurav
Thanks Ulf for the review. On 29 August 2016 at 19:50, Ulf Hansson wrote: > On 16 June 2016 at 14:35, Pramod Gurav wrote: >> + platform_set_drvdata(pdev, msm_host); >> + >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pd

[PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v2: - Moved pm_rutime enabling before adding host - Handled pm_rutime in remove - Changed

Re: [PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
On 1 September 2016 at 19:38, Ulf Hansson wrote: > [...] > >>> + >>> +static const struct dev_pm_ops sdhci_msm_pm_ops = { >>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume) > > One more thing. Why do you need the late versions of the system PM callbacks? > > I think it's

[PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v3: - Added CONFIG_PM around runtime pm function. - Replaced msm suspend/resume with generic

[PATCH] mmc: sdhci-msm: Add pm_runtime and system PM support

2016-09-01 Thread Pramod Gurav
Provides runtime PM callbacks to enable and disable clock resources when idle. Also support system PM callbacks to be called during system suspend and resume. Signed-off-by: Pramod Gurav --- Changes in v1: - Added CONFIG_PM around runtime pm function. - Replaced msm suspend/resume with generic

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
On 25 August 2016 at 10:05, Andy Gross wrote: > On 17 June 2016 at 05:16, Pramod Gurav wrote: > >> + if (msm_port->is_uartdm) { >> + ret = clk_enable(msm_port->pclk); > > Ditto here. Thanks Andy, will include these two changes in v2. > >> + if (ret)

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
Hi, On 17 June 2016 at 15:46, Pramod Gurav wrote: > Add runtime pm and suspend/resume callback support to serial msm > driver so that clock resources are managed runtime to save power. > Any comments on this patch? > Signed-off-by: Pramod Gurav > --- > drivers/tty/serial/

[PATCH] drivers: Kconfig: Remove duplicate sourcing of soc folder

2014-12-08 Thread Pramod Gurav
Folder soc/ was sourced twice somehow. Remove duplicate entry. Signed-off-by: Pramod Gurav --- drivers/Kconfig |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/Kconfig b/drivers/Kconfig index 1a693d3..5add358 100644 --- a/drivers/Kconfig +++ b/drivers/Kconfig @@ -132,8 +132,6

Re: [PATCH] drivers: Kconfig: Remove duplicate sourcing of soc folder

2014-12-08 Thread Pramod Gurav
Thanks. :-) On Mon, Dec 8, 2014 at 7:08 PM, Tobias Klauser wrote: > On 2014-12-08 at 14:36:24 +0100, Pramod Gurav > wrote: >> Folder soc/ was sourced twice somehow. Remove duplicate entry. > > I already sent a patch for this a while ago [1], though it wasn't >

Re: [PATCH] mmc: mmci: Get rid of unused variable and operations on it

2015-01-08 Thread Pramod Gurav
Hi Ulf, Any comment on this change? Thanks Pramod On Tuesday 16 December 2014 07:21 PM, Pramod Gurav wrote: > DMA configuration has been removed from function mmci_dma_setup but the > local mask variable was not removed. This remains unused hence remove > it from the function and oper

[PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Pramod Gurav
baud rate. Hence doing away with both of these calls. - CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate. So do away with this here. Signed-off-by: Pramod Gurav --- Changes since v1: - v1 was just removing call to msm_set_baud_rate(). Other code is removed on

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-08 Thread Pramod Gurav
Hi Stephen, On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote: > On 01/08/2015 01:15 AM, Pramod Gurav wrote: >> drivers/tty/serial/msm_serial.c | 15 --- >> 1 file changed, 15 deletions(-) >> >> diff --git a/drivers/tty/serial/msm_serial.c >>

Re: [PATCH v2] tty: serial: msm_serial: Remove duplicate code in msm_console_setup

2015-01-12 Thread Pramod Gurav
Hi Stephen, On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote: > On 01/08/2015 01:15 AM, Pramod Gurav wrote: >> drivers/tty/serial/msm_serial.c | 15 --- >> 1 file changed, 15 deletions(-) >> >> diff --git a/drivers/tty/serial/msm_serial.c >>

[PATCH v3] tty: serial: msm_serial: code cleanup in msm_console_setup

2015-01-12 Thread Pramod Gurav
msm_set_termios(). msm_reset() is called when we change the baud rate. Hence doing away with both of these calls. - CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate. So do away with this here. Signed-off-by: Pramod Gurav --- Changes since v2: - initialize

[PATCH] tty: serial: msm_serial: Remove console unregistration from driver exit.

2015-01-12 Thread Pramod Gurav
unregister_console() will be called from uart_remove_one_port() while removing the platform driver. So not necessary to call it in driver exit path. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial

[PATCH RESEND] ssb: Fix Sparse error in main

2015-01-27 Thread Pramod Gurav
This change fixes below sparse error: drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus' was not declared. Should it be static? Acked-by: Michael Buesch Signed-off-by: Pramod Gurav --- drivers/ssb/main.c | 19 --- 1 file changed, 19 deletions(-) di

[PATCH RESEND] ssb: Fix Sparse error in main

2015-01-27 Thread Pramod Gurav
This change fixes below sparse error: drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus' was not declared. Should it be static? Acked-by: Michael Buesch Signed-off-by: Pramod Gurav --- drivers/ssb/main.c | 19 --- 1 file changed, 19 deletions(-) di

[PATCH] tty: serial: msm: Fix mask value of RFR level

2015-04-07 Thread Pramod Gurav
According to documents The RFR_LEVEL1 in UART_DM_MR1 can be programmed in bits 31:8 but the masks only bits 17:8. Correct the same. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/msm_serial.h

[PATCH 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 4c1e9ea..f38565c 100644 --- a/drivers/tty/serial

[PATCH 1/2] tty: serial: msm: Add mask value for UART_DM registers

2015-04-08 Thread Pramod Gurav
so do it only for UART core. Signed-off-by: Pramod Gurav -- Changes since last version: - Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing. - Added a new macro for IPR register as it is also different in UART_DM - Changed subject line --- drivers/tty/serial

[PATCH v2 1/2] tty: serial: msm: Add mask value for UART_DM registers

2015-04-08 Thread Pramod Gurav
so do it only for UART core. Signed-off-by: Pramod Gurav --- Changes since last version: - Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing. - Added a new macro for IPR register as it is also different in UART_DM - Changed subject line - Removed change log from

[PATCH v2 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
Disable the pclk when tty port is closed by user space. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 4c1e9ea..f38565c 100644 --- a/drivers/tty/serial

Re: [PATCH v2 2/2] tty: serial: msm: Disable pclk when port is closed

2015-04-08 Thread Pramod Gurav
On Thu, April 9, 2015 5:21 am, Stephen Boyd wrote: > On 04/08/15 06:28, Pramod Gurav wrote: >> Disable the pclk when tty port is closed by user space. >> >> Signed-off-by: Pramod Gurav >> --- >> drivers/tty/serial/msm_serial.c | 1 + >> 1 file changed, 1

Re: [PATCH v3 2/3] tty: serial: msm: Remove duplicate operations on clocks in startup/shutdown

2015-04-29 Thread Pramod Gurav
Thanks Stephen for review. On Fri, April 10, 2015 11:33 pm, Stephen Boyd wrote: > On 04/10/15 05:19, Pramod Gurav wrote: >> @@ -683,8 +679,7 @@ static void msm_power(struct uart_port *port, >> unsigned int state, >> >> switch (state) { >> case 0: &

Re: [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding

2014-07-17 Thread pramod gurav
On Thu, Jul 17, 2014 at 3:50 AM, Bjorn Andersson wrote: >> On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson >> wrote: > [...] >>> + rpm@108000 { >>> + compatible = "qcom,rpm-msm8960"; >>> + reg = <0x108000 0x1000>; >>> + qcom,ipc = <&apcs 0x8 2>; >>

Re: [PATCH v4 2/3] soc: qcom-rpm: Driver for the Qualcomm RPM

2014-07-17 Thread pramod gurav
Hi Bjorn, On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson wrote: > Driver for the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 > and 8064 based devices. The driver exposes resources that child drivers > can operate on; to implementing regulator, clock and bus frequency > drivers. >

Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver

2014-07-21 Thread pramod gurav
On Mon, Jul 21, 2014 at 9:32 PM, divya ojha wrote: > Hi, > > On Thu, Jul 17, 2014 at 8:55 PM, Ivan T. Ivanov wrote: >> From: "Ivan T. Ivanov" >> >> This is the pinctrl, pinmux, pinconf and gpiolib driver for the >> Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. >> >> Signed-o

[PATCH] input: ads7846: Release resources on failure for clean exit

2014-07-29 Thread Pramod Gurav
From: Pramod Gurav Input device must be released(input_free_device) when ads7846_probe_dt fails. This fixes the same by releasing resources on failure. CC: Dmitry Torokhov CC: Lejun Zhu CC: Sachin Kamat Signed-off-by: Pramod Gurav --- drivers/input/touchscreen/ads7846.c |6 -- 1

[PATCH] Input: jornada720_ts: Switch to using Managed resources

2014-07-30 Thread Pramod Gurav
This switches the driver to using managed resources to simplify error handling and to do away with remove function. Also fixes some indentations by replacing spaces with tabs. CC: Dmitry Torokhov CC: Paul Gortmaker Signed-off-by: Pramod Gurav --- drivers/input/touchscreen/jornada720_ts.c

Re: [PATCH] Input: jornada720_ts: Switch to using Managed resources

2014-07-30 Thread Pramod Gurav
On Wed, Jul 30, 2014 at 6:48 PM, Paul Gortmaker wrote: > On 14-07-30 08:09 AM, Pramod Gurav wrote: >> This switches the driver to using managed resources to simplify >> error handling and to do away with remove function. >> >> Also fixes some indentations by replacing

[PATCH 1/2] Input: jornada720_ts: Switch to using Managed resources

2014-07-30 Thread Pramod Gurav
This switches the driver to using managed resources to simplify error handling and to do away with remove function. CC: Dmitry Torokhov CC: Paul Gortmaker Signed-off-by: Pramod Gurav --- drivers/input/touchscreen/jornada720_ts.c | 38 ++--- 1 file changed, 8

[PATCH 2/2] Input: jornada720_ts: Get rid of space indentation and use tab

2014-07-30 Thread Pramod Gurav
CC: Dmitry Torokhov CC: Paul Gortmaker Signed-off-by: Pramod Gurav --- drivers/input/touchscreen/jornada720_ts.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/input/touchscreen/jornada720_ts.c b/drivers/input/touchscreen

[PATCH] power: reset: use restart_notifier mechanism for msm poweroff

2014-09-19 Thread Pramod Gurav
-off-by: Pramod Gurav --- This patch is tested on DB8074 Target and are based on patchset [1] by Guenter Roeck. [1]: https://patchwork.kernel.org/patch/4746721/ drivers/power/reset/msm-poweroff.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH] pinctrl: qcom: use restart_notifier mechanism for ps_hold

2014-09-19 Thread Pramod Gurav
ase where PS_HOLD has failed to reset the chip. > > Choose priority 128, as according to documentation, this mechanism "is > sufficient to restart the entire system". > > Cc: Pramod Gurav > Cc: Guenter Roeck > Signed-off-by: Josh Cartwright > --- -- To unsubscribe

Re: [PATCH 3/3] watchdog: qcom: register a restart notifier

2014-09-19 Thread Pramod Gurav
Hi Josh, Tested this patch on IFC6410 by disabling pinctrl ps_hold reset implementation and on top of Guenter's patchset for restart_notifier. Tested-by: pramod.gu...@smartplayin.com I picked up DT changes from bindings as they are from this patchset. Thanks Pramod On Friday 19 September 2014 0

Re: [PATCH v7 00/11] kernel: Add support for restart handler call chain

2014-09-19 Thread Pramod Gurav
Hello Guenter, Thanks for the patches. Tested patches 1,2 & 4 from this series on qcom apq8064 based IFC6410 with Josh's patches which replace arm restart with restart notifier for this target. Tested-by: pramod.gu...@smartplayin.com On Wednesday 20 August 2014 06:15 AM, Guenter Roeck wrote: > V

Re: [PATCH] power: reset: use restart_notifier mechanism for msm poweroff

2014-09-19 Thread Pramod Gurav
Hi Guenter, Thanks for you. On 19-09-2014 07:23 PM, Guenter Roeck wrote: > On 09/19/2014 05:06 AM, Pramod Gurav wrote: >> This change uses replaces use of arm_pm_restart with recently introduced >> reset mechanism in Linux kernel called restart_notifier. >> >> Cc:

[PATCH] thermal: ti-soc-thermal: Switch to using managed resources

2014-09-19 Thread Pramod Gurav
This change switches to managed resource APIs to allocated resources such as irq, clock. Hence does away with release statements of the same resorces in error lables and remove function. Cc: Eduardo Valentin Cc: Zhang Rui Cc: linux...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers

[PATCH 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-19 Thread Pramod Gurav
Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/atmel-mci.c | 57 1 file changed, 20 insertions(+), 37 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index bb585d9..21a222c 100644

[PATCH 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

2014-09-19 Thread Pramod Gurav
This change takes care of releasing mmc resources on error cases in probe function which was missing. Also release timer in remove function. Cc: Ludovic Desroches Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/atmel-mci.c | 13

[PATCH] mmc: android-goldfish: Remove unnecessary NULL check on host

2014-09-20 Thread Pramod Gurav
This change removes unwanted NULL check around mmc private data structure in remove function as the probe would not have succeeded with this structure variable as NULL. Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/android

[PATCH] mmc: usdhi6rol0: Remove unnecessary header files

2014-09-20 Thread Pramod Gurav
These headers are not required hence this change removes them from the driver. Cc: Guennadi Liakhovetski Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/usdhi6rol0.c | 7 --- 1 file changed, 7 deletions(-) diff --git a

[PATCH v2] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-22 Thread Pramod Gurav
-by: Pramod Gurav --- Tested on Dragonboard APQ8074 Changes since v1: - Initialized restart_nb with its declaration - Removed return check for register_restart_handler as it always returns 0 as per Guenter's suggestion to Josh's similar patch. This takes care of Guenter's comment

[PATCH] mmc: omap_hsmmc: Switch to using managed version to gpio request

2014-09-22 Thread Pramod Gurav
This change switches to managed version of gpio_request to simplify module unloading and failure cases and does away with code to release gpio resources. Cc: Balaji T K Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/omap_hsmmc.c

Re: [PATCH 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-22 Thread Pramod Gurav
uest_irq and free_irq the time it takes to solve this issue > is probably better. Oh, Thanks for letting me know this. I will resend this patch keeping request_irq and free_irq in driver. > > Regards > > Ludovic > > On Sat, Sep 20, 2014 at 12:22:30PM +0530, Pramod Gurav wrote:

[PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-22 Thread Pramod Gurav
...@vger.kernel.org Signed-off-by: Pramod Gurav --- Tested on Dragonboard APQ8074 Changes since v2: - Removed unwanted header file and added linux/pm.h Changes since v1: - Initialized restart_nb with its declaration - Removed return check for register_restart_handler as it always returns 0 as per

Re: [PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-22 Thread Pramod Gurav
+linux-arm-msm On Tuesday 23 September 2014 11:38 AM, Pramod Gurav wrote: > This change replaces use of arm_pm_restart with recently introduced > reset mechanism in Linux kernel called restart_notifier. > > Reviewed-by: Guenter Roeck > Cc: Guenter Roeck > Cc: Josh Cartwrigh

[PATCH v2 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

2014-09-23 Thread Pramod Gurav
This change takes care of releasing mmc resources on error cases in probe function which was missing. Also release timer in remove function. Cc: Ludovic Desroches Cc: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- Changes since v1: None drivers/mmc

[PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-23 Thread Pramod Gurav
: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- Changes since v1: - Dropped using devm_request_irq as suggested by Ludovic Desroches as it seems there are race conditions seen with them. - Added another patch to fix failure path in probe to call atmci_cleanup_slot after

[PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-23 Thread Pramod Gurav
: Chris Ball Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- Changes since v1: - Dropped using devm_request_irq as suggested by Ludovic Desroches as it seems there are race conditions seen with them. - Added another patch to fix failure path in probe to call

Re: [PATCH v3] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-23 Thread Pramod Gurav
Hi Kumar, On 23-09-2014 11:18 PM, Kumar Gala wrote: > > On Sep 23, 2014, at 1:28 AM, Pramod Gurav > wrote: > >> +linux-arm-msm >> On Tuesday 23 September 2014 11:38 AM, Pramod Gurav wrote: >>> This change replaces use of arm_pm_restart with recently introd

Re: [PATCH] thermal: ti-soc-thermal: Switch to using managed resources

2014-09-25 Thread Pramod Gurav
+Valentin On Friday 19 September 2014 11:35 PM, Pramod Gurav wrote: > This change switches to managed resource APIs to allocated resources > such as irq, clock. Hence does away with release statements of the > same resorces in error lables and remove function. > > Cc: Eduardo

[PATCH v4] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-25 Thread Pramod Gurav
Cartwright Cc: Sebastian Reichel Cc: Dmitry Eremin-Solenikov Cc: David Woodhouse Cc: Stephen Boyd Cc: linux...@vger.kernel.org Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Signed-off-by: Pramod Gurav --- Why reset handler in pinctrl-msm wont collide with reset in poweroff-msm.c in

[PATCH] ARM: multi_v7_defconfig: Add Support for QCOM APQ8074 reset

2014-09-25 Thread Pramod Gurav
This change adds support for reset driver for apq8074 based platform. With this we should be able to reboot the board from command prompt. Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- arch/arm/configs

Re: linux-next: build failure after merge of the watchdog tree

2014-09-25 Thread Pramod Gurav
On Friday 26 September 2014 11:10 AM, Stephen Rothwell wrote: > Hi Wim, > > After merging the watchdog tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > > drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe': > drivers/watchdog/meson_wdt.c:178:2: error: impli

[PATCH] mmc: davinci: Fix and simplify probe failure path

2014-09-26 Thread Pramod Gurav
-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/davinci_mmc.c | 91 +++- 1 file changed, 33 insertions(+), 58 deletions(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 5d4c5e0..160b7e8 100644 --- a

[PATCH] ARM: multi_v7_defconfig: Add Support for QCOM SDHCI Controller

2014-09-26 Thread Pramod Gurav
: Georgi Djakov Signed-off-by: Pramod Gurav --- arch/arm/configs/multi_v7_defconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index bad9d92..cc55117 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Pramod Gurav
Hi Felipe, On 13-09-2014 01:50 AM, Felipe Balbi wrote: > On Sat, Sep 13, 2014 at 01:44:25AM +0530, Pramod Gurav wrote: >> Andy, >> Couple of minor comments. >> >> On Sat, Sep 13, 2014 at 12:58 AM, Andy Gross wrote: >> >>> From: "Ivan T. Ivanov&quo

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Pramod Gurav
On 13-09-2014 01:59 AM, Felipe Balbi wrote: > Hi, > > On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote: >>>>> + qdwc = devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP_KERNEL); >>>>> + if (!qdwc) >>>>> +

Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

2014-09-26 Thread Pramod Gurav
Hi Arnd, On Sat, Sep 27, 2014 at 1:04 AM, Arnd Bergmann wrote: > As of 528bc7808f4e ("mmc: atmel-mci: Release mmc resources on failure in > probe"), > the atmci_probe() function calls atmci_cleanup_slot in the failure path. > > This causes a new warning whenever the driver is built: > > WARNING:

Re: [PATCH v4] power: reset: use restart_notifier mechanism for msm-poweroff

2014-09-26 Thread Pramod Gurav
On 27-09-2014 01:55 AM, Sebastian Reichel wrote: > Hi, > > On Thu, Sep 25, 2014 at 05:03:51PM +0530, Pramod Gurav wrote: >> This change replaces use of arm_pm_restart with recently introduced >> reset mechanism in Linux kernel called restart_notifier. >> >> Choosi

[PATCH] usb: phy: msm: Fix Sparse warning

2014-09-29 Thread Pramod Gurav
This change fixes below sparse warning: drivers/usb/phy/phy-msm-usb.c:1397:30: warning: symbol 'msm_otg_mode_fops' was not declared.Should it be static? Cc: Srinivas Kandagatla Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- d

[PATCH] mmc: sdhci-pxav3: Fix Sparse warning of duplicate set_uhs_signaling entry

2014-09-29 Thread Pramod Gurav
: Russell King Cc: Ulf Hansson Cc: Chris Ball Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/sdhci-pxav3.c | 37 - 1 file changed, 37 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c

[PATCH] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
by removing a check on info->irqmux_base as info->irqmux_base has already been checked for error when allocating it. Hence there is no need to redo the check. Cc: Maxime Coquelin Cc: Patrice Chotard CC: Linus Walleij Cc: Srinivas Kandagatla Signed-off-by: Pramod Gurav --- drivers/pinctr

Re: [PATCH] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
Hi Srini, Thanks for review. On Mon, Sep 29, 2014 at 8:16 PM, Srinivas Kandagatla wrote: > On 29/09/14 14:48, Pramod Gurav wrote: >> >> This change fixes below sparse error, >> drivers/pinctrl/pinctrl-st.c:1515:31: error: incompatible types for >> operation (>) &

Re: [PATCH] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
On Mon, Sep 29, 2014 at 9:08 PM, Srinivas Kandagatla wrote: > > > On 29/09/14 16:05, Pramod Gurav wrote: >>> >>> >I think the correct fix is: >>> > >>> >diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c >>> &g

[PATCH v2] pinctrl: st: Fix Sparse error

2014-09-29 Thread Pramod Gurav
lin Cc: Patrice Chotard CC: Linus Walleij Cc: Srinivas Kandagatla Signed-off-by: Pramod Gurav --- drivers/pinctrl/pinctrl-st.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 5475374..2ff0da8 100644 --

[PATCH 1/2] gpio: remove remaining users of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Some driver in gpio still check for return value from gpiochip_remove Get rid of the check for return value. Cc: Linus Walleij Cc: Alexandre Courbot Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/gpio/gpio-crystalcove.c | 12 drivers/gpio/gpio-omap.c

[PATCH 2/2] mfd: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Samuel Ortiz CC: Lee Jones Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mfd/asic3.c|3 ++- drivers/mfd/htc-i2cpld.c |6

[PATCH] HID: cp2112: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Jiri Kosina Cc: linux-in...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/hid/hid-cp2112.c |6 ++ 1 file changed, 2

[PATCH 1/2] input: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/input/keyboard/adp5588-keys.c |4 +--- drivers

[PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-09-30 Thread Pramod Gurav
Get rid of using return value from gpiochip_remove() as it returns void. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Bryan Wu Cc: Richard Purdie Cc: linux-l...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/leds/leds-pca9532.c | 10

[PATCH 1/5] mmc: msm_sdcc: Switch to using managed resources

2014-09-16 Thread Pramod Gurav
-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c index 9405ecd..2b8ac9c 100644 --- a/drivers/mmc

[PATCH 0/5] mmc: msm_sdcc: Cleanups

2014-09-16 Thread Pramod Gurav
This patchset does some cleanups in msm sdcc driver. Pramod Gurav (5): mmc: msm_sdcc: Switch to using managed resources mmc: msm_sdcc: Add support for platform_driver remove function mmc: msm_sdcc: Replace pr_ with dev_ mmc: msm_sdcc: Remove duplicate check around dmares mmc: msm_sdcc

[PATCH 3/5] mmc: msm_sdcc: Replace pr_ with dev_

2014-09-16 Thread Pramod Gurav
This replaces pr_* with dev_ for message logging and also does away with printing function names in logs. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-...@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host

[PATCH 4/5] mmc: msm_sdcc: Remove duplicate check around dmares

2014-09-16 Thread Pramod Gurav
ux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c index 2111c03..5025364 100644 --- a/drivers/mmc/host/msm_sdcc.c +++ b/drivers/mmc/host/msm_

[PATCH 5/5] mmc: msm_sdcc: Remove unwanted initializations in probe

2014-09-16 Thread Pramod Gurav
This removes unnecessary initialisations of resource pointers and does away with a lable and just returns error on fail instead. Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-...@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav

[PATCH 2/5] mmc: msm_sdcc: Add support for platform_driver remove function

2014-09-16 Thread Pramod Gurav
This change adds remove function in platform_driver to clean unloading Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman CC: Ulf Hansson CC: linux-...@vger.kernel.org CC: linux-arm-...@vger.kernel.org Signed-off-by: Pramod Gurav --- drivers/mmc/host/msm_sdcc.c | 18

[PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-06-20 Thread Pramod Gurav
Fixed: ERROR: do not use assignment in if condition Fixed: WARNING: EXPORT_SYMBOL should immediately follow its function Fixed: WARNING: line over 80 characters in a comment CC: Rafael J. Wysocki CC: Daniel Lezcano Signed-off-by: Pramod Gurav --- drivers/cpuidle/cpuidle.c | 18

Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-06-20 Thread pramod gurav
+linux-pm On Fri, Jun 20, 2014 at 4:27 PM, Pramod Gurav wrote: > Fixed: ERROR: do not use assignment in if condition > Fixed: WARNING: EXPORT_SYMBOL should immediately follow its function > Fixed: WARNING: line over 80 characters in a comment > > CC: Rafael J. Wysocki >

Re: [PATCH] cpufreq: Fix latency for cpufreq_info

2014-07-24 Thread pramod gurav
Viresh, Be careful when you ACK Nick's patches. He has confessed he has no idea how to build test a kernel. His patches are NOT AT ALL build tested. And some of his patches are being reverted for causing problems in build and all. He looks for FIXME and removes/edits the code as per the comments. J

Re: [PATCH] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod gurav
Thanks Sachin for the review. Will resend the patch addressing your review comments. On Fri, Jul 25, 2014 at 1:59 PM, Sachin Kamat wrote: > On Fri, Jul 25, 2014 at 12:39 PM, wrote: >> From: Pramod Gurav >> >> This patch does below: >> - Removes kfree done on data al

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-25 Thread pramod gurav
On Fri, Jul 25, 2014 at 3:59 PM, Sachin Kamat wrote: > Hi Pramod, > > > On Fri, Jul 25, 2014 at 2:42 PM, wrote: >> From: Pramod Gurav >> >> This patch does below: >> - Removes kfree done on data allocated with devm_zalloc in probe >> path of the driv

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-27 Thread pramod gurav
Hi Dmitry, Thanks for the review. On Fri, Jul 25, 2014 at 9:52 PM, Dmitry Torokhov wrote: > Hi Pramod, > > On Fri, Jul 25, 2014 at 05:04:34PM +0530, pramod.gurav@gmail.com wrote: >> From: Pramod Gurav >> >> This patch does below: >> - Removes kfree done o

Re: [PATCH v2] Input: soc_button_array: Remove kfree on data allocated with devm_zalloc

2014-07-28 Thread pramod gurav
On Mon, Jul 28, 2014 at 12:40 PM, Dmitry Torokhov wrote: > On July 27, 2014 11:50:41 PM PDT, pramod gurav > wrote: >>Hi Dmitry, >> > > No need to resend, I picked out the good bits and applied. Thanks. :) -- Thanks and Regards Pramod -- To unsubscribe from

Re: [PATCH] input: ads7846: Switch to managed version of kzalloc and cleanups

2014-07-28 Thread Pramod Gurav
Thanks Dmitry for reviewing. On Mon, Jul 28, 2014 at 10:19 PM, Dmitry Torokhov wrote: > Hi Pramod, > > On Mon, Jul 28, 2014 at 02:16:55PM +0530, pramod.gurav@gmail.com wrote: >> From: Pramod Gurav >> >> This switches memory allocations from kzalloc to devm_kzallo

Re: [PATCH] fs/direct-io.c: Fix compilation warning for uninitialized variables

2014-07-14 Thread pramod gurav
Thanks Christoph for the review. :) On Sun, Jul 13, 2014 at 5:20 PM, Christoph Hellwig wrote: > Looks good to me, > > Reviewed-by: Christoph Hellwig > > Al, can you pick this up? It's the only warnings in many of my usual > kernel builds at the moment. > -- Thanks and Regards Pramod -- To u

Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-07-14 Thread pramod gurav
Hi Rafael, Can we consider these changes if there are no issues with this? On Fri, Jun 20, 2014 at 4:28 PM, pramod gurav wrote: > +linux-pm > > On Fri, Jun 20, 2014 at 4:27 PM, Pramod Gurav > wrote: >> Fixed: ERROR: do not use assignment in if condition >> Fixed: WARNI

Re: [PATCH 1/3] mfd: qpnp-spmi: add support for Qualcomm QPNP PMICs

2014-07-14 Thread pramod gurav
On Tue, Jul 8, 2014 at 9:24 PM, Stanimir Varbanov wrote: > From: Josh Cartwright > > The Qualcomm QPNP PMIC chips are components used with the > Snapdragon 800 series SoC family. This driver exists > largely as a glue mfd component, it exists to be an owner > of an SPMI regmap for children devic

Re: [RFC/PATCH 03/12] clk: qcom: Add support for muxes, dividers, and mux dividers

2014-07-14 Thread pramod gurav
Hi Stephen, On Wed, Jun 25, 2014 at 5:36 AM, Stephen Boyd wrote: > The Krait CPU clocks are made up of muxes and dividers with a > handful of sources. Add a set of clk_ops that allow us to > configure these clocks so we can support CPU frequency scaling on > Krait CPUs. > > Based on code original

Re: [RFC/PATCH 06/12] clk: qcom: Add MSM8960's HFPLLs

2014-07-14 Thread pramod gurav
Hi Stephen, On Wed, Jun 25, 2014 at 5:36 AM, Stephen Boyd wrote: > Describe the HFPLLs present on MSM8960 devices. > > Signed-off-by: Stephen Boyd > --- > drivers/clk/qcom/gcc-msm8960.c | 82 > ++ > 1 file changed, 82 insertions(+) > > diff --git a/dri

Re: [RFC/PATCH 09/12] clk: qcom: Add Krait clock controller driver

2014-07-14 Thread pramod gurav
On Wed, Jun 25, 2014 at 5:36 AM, Stephen Boyd wrote: > The Krait CPU clocks are made up of a primary mux and secondary > mux for each CPU and the L2, controlled via cp15 accessors. For > Kraits within KPSSv1 each secondary mux accepts a different aux > source, but on KPSSv2 each secondary mux acce

Re: [PATCH 1/2] drm/msm: update iommu support

2014-07-14 Thread pramod gurav
On Tue, Jun 17, 2014 at 8:02 PM, Stephane Viau wrote: > Iommu support is slightly modified in order to make sure > that MDP iommu is properly cleaned up if a probe deferral is > requested. Before this change, IOMMU faults would occur if the > probe failed (-EPROBE_DEFER). > > Signed-off-by: Stepha

Re: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl

2014-07-14 Thread pramod gurav
On Mon, Jul 14, 2014 at 11:38 PM, Rafael J. Wysocki wrote: > On Monday, July 14, 2014 12:40:24 PM pramod gurav wrote: >> Hi Rafael, >> >> Can we consider these changes if there are no issues with this? > > Well, are you "fixing" checkpatch.pl warnings just

Re: [RFC/PATCH 00/12] Krait clocks + Krait CPUfreq

2014-07-15 Thread pramod gurav
Hi Stephen, On Wed, Jun 25, 2014 at 5:36 AM, Stephen Boyd wrote: > > Stephen Boyd (12): > ARM: Add Krait L2 register accessor functions > clk: Add safe switch hook > clk: qcom: Add support for muxes, dividers, and mux dividers > clk: qcom: Add support for High-Frequency PLLs (HFPLLs) >

Re: [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-07-16 Thread pramod gurav
Hi Bjorn, On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson wrote: > Driver for regulators exposed by the Resource Power Manager (RPM) found > in Qualcomm 8660, 8960 and 8064 based devices. > > Signed-off-by: Bjorn Andersson > --- > drivers/regulator/Kconfig | 12 + > drivers/regul

Re: [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding

2014-07-16 Thread pramod gurav
Hi Bjorn, RPM breaks on IFC6410 without entry for 'qcom.ipc' node. Please find my observations below. On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson wrote: > Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660, > 8960 and 8064 based devices. The binding currently describes

  1   2   3   >