Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_esai.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound
Fix W=1 warnings. The kernel-doc support is partial, add more
descriptions and follow proper syntax
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi.c | 70 ++---
1 file changed, 44 insertions(+), 26 deletions(-)
diff
Fix W=1 warnings. Kernel-doc syntax was not properly used.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl-asoc-card.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl
Fix W=1 warnings. kernel-doc syntax was not followed and missing parameter
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_spdif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
diff --git a/sound/soc/intel/boards/Kconfig
b/sound/soc/intel/boards/Kconfig index 3d820e1..b3b863e 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -291,9 +291,17 @@ config
SND_SOC_INTEL_DA7219_MAX98357A_GENERIC
select SND_SOC_DMIC
select SND_
has been attached to a bus, the slave->dev_num_sticky
should be non-zero, so we can check this value to skip the
ghost devices defined in ACPI table but not populated in hardware.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundw
Thanks Vinod for the review.
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -13,6 +13,9 @@
#include
#include
#include
+#include
Do we really need core header?
No we don't, the only thing needed in sound/soc.h it seems.
+#include
+#include
#include "bus.h
+irqreturn_t sdw_intel_thread(int irq, void *dev_id)
+{
+ struct sdw_intel_ctx *ctx = dev_id;
+ struct sdw_intel_link_res *link;
+
+ list_for_each_entry(link, &ctx->link_list, list)
+ sdw_cdns_irq(irq, link->cdns);
+
+ sdw_intel_enable_irq(ctx->mmio_base,
On 7/7/20 5:40 AM, Mark Brown wrote:
On Tue, Jul 07, 2020 at 11:37:35AM +0100, Lee Jones wrote:
Some of these issues have been present for years. It's quite the
coincidence that we both submitted these this week!
I'm guessing you've both been inspired by the 0day bot turning W=1
warnings
by: Lukasz Majczak
Signed-off-by: Harsha Priya
Acked-by: Pierre-Louis Bossart
---
v1 -> v2:
- Extract dmic from SSP0 as every BE should have own fixup function.
v2 -> v3:
- Restore naming in the dapm route table to not confuse with other
drivers
- Fixed indentations
v3 -> v4:
- Upda
Wunused-but-set-variable]
Peter suggested that the whole read can be removed, so that's
been done too.
Cc: Peter Ujfalusi
Cc: Jarkko Nikula
Cc: Samuel Ortiz
Cc: linux-o...@vger.kernel.org
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/ti/omap-mcbsp-st.c | 3
ned-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7219.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index f2520a6c7875..153ea30b5a8f 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -1708,11 +1708,13
DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
| ^~~~
Cc: ter Huurne
Reviewed-by: Paul Cercueil
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/jz4770.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs
by: Pierre-Louis Bossart
---
sound/soc/codecs/max98390.c | 8
1 file changed, 8 deletions(-)
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index b345e626956d..3e8094241645 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -944,14 +944,6
Fix W=1 warning - wrong parameter description and bad format
Reviewed-by: Masahiro Yamada
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/uniphier/aio-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio
Fix W=1 warning:
sound/soc//tegra/tegra20_das.c:101:11: warning:
comparison of unsigned expression >= 0 is always true [-Wtype-limits]
101 | if ((reg >= TEGRA20_DAS_DAP_CTRL_SEL) &&
| ^~
Reviewed-by: Jon Hunter
Signed-off-by: Pierre-Louis Bossart
---
s
Fix W=1 warnings - typos with structure fields
Reviewed-by: Sylwester Nawrocki
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/spdif.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c
index 759fc6644329
Fix W=1 warning
Kernel-doc is not used in one file and missing argument in the second.
Acked-by: Alexandre Belloni
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/atmel/atmel-pcm-dma.c | 2 +-
sound/soc/atmel/atmel_ssc_dai.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
by: Pierre-Louis Bossart
---
sound/soc/codecs/cros_ec_codec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 8d45c628e988..f23956cf4ed8 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_
Fix W=1 warnings - missing fields in structure
Credits to Sylwester Nawrocki for the pclk and cclk descriptions.
Reviewed-by: Sylwester Nawrocki
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/pcm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/samsung/pcm.c b
Fix W=1 warning
sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined
but not used [-Wunused-const-variable=]
842 | static const struct acpi_device_id es8316_acpi_match[] = {
|^
Signed-off-by: Pierre-Lou
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
Acked-by: Adam Thomson
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7210.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
Fix W=1 warning when ACPI is not defined
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt274.c | 2 ++
sound/soc/codecs/rt286.c | 2 ++
sound/soc/codecs/rt298.c | 2 ++
sound/soc/codecs/rt5660.c | 2 ++
sound/soc/codecs/rt5677-spi.c | 2 ++
5 files changed, 10
Fix W=1 warning - missing parameter description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/qcom/qdsp6/q6asm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
index ae4b2cabdf2d..d67b23a5f397 100644
--- a
_DECL’
1207 | static SOC_VALUE_ENUM_SINGLE_DECL(
| ^~
Cc: Oder Chiou
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5659.c | 37 -
1 file changed, 37 deletions(-)
diff --git a/sound/soc/codecs/rt5
Cc: Daniel Mack
Cc: Haojian Zhuang
Cc: Robert Jarzmik
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/pxa/pxa-ssp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 6a72cc1665b7..d1e09ade0190 100644
-set-variable]
Cc: Kuninori Morimoto
Cc: Junichi Wakasugi
Cc: Mihai Serban
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/ak4458.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
Fix W=1 warnings - missing fields in description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-i2s.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index d0a8d5810c0a..f23ff29e7c1d 100644
: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/ux500/ux500_msp_i2s.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a16..fd0b88bb7921 100644
--- a/sound/soc/
d but
not used [-Wunused-const-variable=]
1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
| ^~
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sti/uniperif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/so
Fix W=1 warning - typo in field description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 86779a99df75..326dd45e39da 100644
--- a/sound
Fix W=1 warning, spurious kernel-doc start and missing arguments
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5631.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355
Fix W=1 warning. Remove spurious /** since there isn't any kernel-doc
comment in this file.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/tlv320aic26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320ai
off-by: Pierre-Louis Bossart
---
sound/soc/meson/axg-pdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/meson/axg-pdm.c b/sound/soc/meson/axg-pdm.c
index bfd37d49a73e..8fe5b2563619 100644
--- a/sound/soc/meson/axg-pdm.c
+++ b/sound/soc/meson/axg-pdm.c
@@ -206,7 +20
-by: Pierre-Louis Bossart
---
sound/soc/meson/axg-spdifin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/meson/axg-spdifin.c b/sound/soc/meson/axg-spdifin.c
index d0d09f945b48..5fa411d4e985 100644
--- a/sound/soc/meson/axg-spdifin.c
+++ b/sound/soc/meson/axg-spdifi
rre-Louis Bossart
---
sound/soc/intel/skylake/skl-sst-dsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-sst-dsp.c
b/sound/soc/intel/skylake/skl-sst-dsp.c
index 225706d148d8..cb83b395f210 100644
--- a/sound/soc/intel/skylake/skl-sst-dsp.c
+++ b/so
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index c3558288242a..8c214436a2c2 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -258,7 +258,7 @@ static int q6asm_dai_prepare(struct snd_soc_component
*component,
i
@@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, uint32_t token,
switch (opcode) {
case ASM_CLIENT_EVENT_CMD_RUN_DONE:
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
- q6asm_write_async(prtd->audio_client,
-
+int q6asm_stream_remove_initial_silence(struct audio_client *ac,
+ uint32_t stream_id,
+ uint32_t initial_samples)
+{
+ return q6asm_stream_remove_silence(ac, stream_id,
+
On 7/7/20 11:36 AM, Srinivas Kandagatla wrote:
Add support to gapless playback by implementing metadata,
next_track, drain and partial drain support.
Gapless on Q6ASM is implemented by opening 2 streams in a single asm stream
What does 'in a single asm stream' means?
and toggling them on
CONFIG_REGMAP is not selected when no other serial bus is supported.
It's largely academic since CONFIG_I2C is usually selected e.g. by
DRM, but still this can break randconfig so let's be explicit.
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 2 +-
1 file
On 7/8/20 4:11 AM, Arnaud POULIQUEN wrote:
Hi Pierre-Louis,
On 7/7/20 9:16 PM, Pierre-Louis Bossart wrote:
Fix W=1 warning. The table uni_tdm_hw is declared in a header included
by multiple C file. This isn't really a good practice but for now
using __maybe_unused makes the foll
On 7/8/20 2:14 AM, Greg Kroah-Hartman wrote:
On Tue, Jul 07, 2020 at 03:26:28PM -0500, Pierre-Louis Bossart wrote:
CONFIG_REGMAP is not selected when no other serial bus is supported.
It's largely academic since CONFIG_I2C is usually selected e.g. by
DRM, but still this can break randc
Add support to gapless playback by implementing metadata,
next_track, drain and partial drain support.
Gapless on Q6ASM is implemented by opening 2 streams in a single asm
stream
What does 'in a single asm stream' means?
So in QDSP6 ASM (Audio Stream Manager) terminology we have somethin
right, but the key point is 'switch between streams'. That means a
more complex/capable implementation that should be advertised as such
to applications. This is not the default behavior assumed initially:
to allow for minimal implementations in memory-constrained devices, we
assumed gapless
On 6/18/20 6:44 AM, Daniel Baluta wrote:
On 6/18/20 2:01 PM, Mark Brown wrote:
On Wed, Jun 17, 2020 at 09:02:32PM -0400, Sasha Levin wrote:
From: Daniel Baluta
[ Upstream commit c26fde3b15ed41f5f452f1da727795f787833287 ]
This provides a better separation between runtime and PM sleep
callb
On 6/16/20 9:18 PM, JaeHun Jung wrote:
In mobile, a co-processor is used when using USB audio
to improve power consumption.
hooking is required for sync-up when operating
the co-processor. So register call-back function.
The main operation of the call-back function is as follows:
- Initialize
On 6/22/20 1:58 AM, Vinod Koul wrote:
So we had some discussions of the stream states, so I thought it is a
good idea to document the state transitions, so add it documentation
Signed-off-by: Vinod Koul
---
.../sound/designs/compress-offload.rst| 52 +++
1 file cha
On 6/22/20 12:34 AM, Vinod Koul wrote:
On 19-06-20, 09:27, Pierre-Louis Bossart wrote:
+For Gapless, we move from running state to partial drain and back, along
+with setting of meta_data and signalling for next track
On 6/12/20 7:19 AM, Mark Brown wrote:
On Thu, Jun 11, 2020 at 05:49:29PM -0700, John Stultz wrote:
On Thu, Jun 11, 2020 at 5:13 PM John Stultz wrote:
I've bisected it down to the following commit from this pull req:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
On 6/12/20 9:46 AM, Mark Brown wrote:
On Fri, Jun 12, 2020 at 08:54:11AM -0500, Pierre-Louis Bossart wrote:
I think that those configuration errors are the problem and should be fixed
as a prerequisite to the removal of the duplication between
dpcm_playback/dpcm_capture/playback_only
ted by Kai don't show any regression and change looks
good so:
Reviewed-by: Pierre-Louis Bossart
Thanks Brent!
On 7/14/20 8:33 AM, Hans de Goede wrote:
Hi,
On 7/14/20 10:09 AM, Jing Xiangfeng wrote:
snd_byt_cht_es8316_mc_probe() misses to call put_device() in an error
path. Add the missed function call to fix it.
Fixes: ba49cf6f8e4a ("ASoC: Intel: bytcht_es8316: Add quirk for
inverted jack detect")
application is going to be for volume/gain
controls.
The 3rd patch was initially suggested for inclusion in the SoundWire
tree, and was modified to add more background information in the
commit message as requested by Vinod Koul.
Pierre-Louis Bossart (4):
regmap: sdw: move to -EOPNOTSUPP
regmap: sdw
Explicitly add header files used by regmap SoundWire support.
Suggested-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/regmap-sdw.c | 2 ++
1 file changed, 2
ing is required, but
the most often used parameter values are placed in the lower 16 bits
of the address. This helps to keep the paging registers constant while
updating Controls for a specific Device/Function.
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
-ENOTSUPP is not a valid error code, use recommended value instead.
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/regmap-sdw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
ng
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 6 +-
drivers/base/regmap/Makefile | 1 +
drivers/base/regmap/regmap-sdw-mbq.c | 102 +++
include/linux/regmap.h
-ENOTSUPP is not a valid error code, use recommended value instead.
What makes you say this - it's what regmap uses internally for
unsupported operations?
This was flagged by scripts/checkpatch.pl (must be a new addition).
# ENOTSUPP is not a standard error code and should be avoided in ne
+ * @hw_sync_min_links: Number of links used by a stream above which
+ * hardware-based synchronization is required. This value is only
+ * meaningful if multi_link is set. If set to 1, hardware-based
+ * synchronization will be used even if a stream only uses a single
+ * SoundWire segment.
- ret = sdw_prepare_stream(dma->stream);
+ /*
+* All cpu dais belong to a stream. To ensure sdw_prepare_stream
+* is called once per stream, we should call it only when
+* dai = first_cpu_dai.
+*/
+ if (first_cpu_dai == dai)
+ ret
On 8/26/20 4:48 AM, Vinod Koul wrote:
On 18-08-20, 10:41, Bard Liao wrote:
From: Pierre-Louis Bossart
Detect cases where the clock is assumed to be stopped but the IP is
not in the relevant state, and add a dynamic debug trace.
you meant a debug print..and it looks like error print below
One possible objection is that this code could have been handled with
regmap-sdw.c. However this is a new spec addition not handled by every
SoundWire 1.1 and non-SDCA device, so there's no reason to load code
that will never be used.
Also in practice it's extremely unlikely that CONFIG_REG
checkpatch is broken.
Heh, I'm not objecting it :)
OTOH, it's also true that ENOTSUPP is no good error code if returned
to user-space. Unfortunately many codes (including what I wrote) use
this code mistakenly, and they can't be changed any longer...
It's also used internally in vari
+/* v1.2 device - SDCA address mapping */
Can you please add description of bits used by each field here,
something like we have done for DevId
were you referring to something like this?
* Spec definition
* Register Bit Contents
* DevId_0 [7:4] 47:44 sdw_versio
On 8/26/20 7:28 AM, Vinod Koul wrote:
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on
failure which should be checked with IS_ERR. Also use PTR_ERR for
returning error codes.
Do you mind changing these two additional codecs that were missed in
this series? Thanks!
+#include
+#include
+#include
Curious why do you need this header?
I'll return the question back to you, since you added this header for
regmap-sdw.c:
7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6)
#include
so I assumed it was needed here as well.
+MODULE_DESC
check for devm_regmap_init_sdw()
ASoC: rt711: Fix return check for devm_regmap_init_sdw()
ASoC: rt715: Fix return check for devm_regmap_init_sdw()
ASoC: rt700: Fix return check for devm_regmap_init_sdw()
Thanks for the fix.
Reviewed-by: Pierre-Louis Bossart
If you want to change this you'd need to change it over the whole
subsystem (if not other subsystems), including the places where the
value is used.
ok, I'll drop this patch for now, keep -ENOTSUPP and deal with this
later. The only thing I really care about for now is SoundWire MBQ
suppor
On 9/25/20 4:28 AM, Srinivas Kandagatla wrote:
Usage of regmap_field_alloc becomes much overhead when number of fields
exceed more than 3.
QCOM LPASS driver has extensively converted to use regmap_fileds.
Multiple typos scattered in this patch: fileds -> fields?
Using new bluk api to allo
n they are merged and available in Mark
Brown's tree (and I need to address the clock-related feedback).
Thanks for your work Michael, really nice and useful, feel free to add
the following tag:
Tested-by: Pierre-Louis Bossart
On 5/29/20 8:30 AM, Mark Brown wrote:
On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not us
On 5/29/20 8:55 AM, Pierre-Louis Bossart wrote:
On 5/29/20 8:30 AM, Mark Brown wrote:
On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
sound/soc/sof/
On 5/25/20 2:06 AM, Dinghao Liu wrote:
When sst_load_fw() returns an error code, a pairing runtime
PM usage counter decrement is needed to keep the counter
balanced.
Signed-off-by: Dinghao Liu
---
sound/soc/intel/atom/sst/sst_drv_interface.c | 1 +
1 file changed, 1 insertion(+)
diff --g
This single fix address two issues on machines with nau88125:
1) Audio distortion, due to lack of required clock rate on MCLK line
2) Loud audible "pops" on headphones if there is no sysclk during nau8825
playback power up sequence
Explanation for:
1) Due to Skylake HW limitation, MCLK pi
, flags);
This change is quite hard to review, this error handling can be called
from multiple places.
I *think* it's correct because in all cases where the
disconnect/close/hw_free labels are reached, the non-shared BEs either
remain or are put in the DPCM_STATE_CLOSE state before doing t
On 5/13/20 2:20 PM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
snd_soc_dai_hw
On 6/8/20 3:43 PM, Jonathan Marek wrote:
Adds support for qcom soundwire devices with memory mapped IO registers.
'device' is an ambiguous term for SoundWire.
Seems to me this is a SoundWire Master device directly accessed with
mmio registers instead of over a SLIMbus link?
Signed-off-
On 6/8/20 3:43 PM, Jonathan Marek wrote:
The driver may be used without slimbus, so don't depend on slimbus.
Signed-off-by: Jonathan Marek
---
drivers/soundwire/Kconfig | 1 -
drivers/soundwire/qcom.c | 5 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/sound
On 8/28/20 2:45 AM, Vinod Koul wrote:
On 28-08-20, 01:47, Liao, Bard wrote:
snd_pcm_substream *substream,
goto err;
}
- ret = sdw_prepare_stream(dma->stream);
+ /*
+* All cpu dais belong to a stream. To ensure sdw_prepare_stream
+*
Is this timeout for suspend or resume? Somehow I was under the
assumption that it is former? Or is the result seen on resume?
Rereading the race describe above in steps, I think this should be
handled in step c above. Btw is that suspend or runtime suspend which
causes this? Former would be
Detect cases where the clock is assumed to be stopped but the IP is
not in the relevant state, and add a dynamic debug trace.
you meant a debug print..and it looks like error print below (also in title).
I don't understand the comment. Is the 'trace' confusing and are you asking
to e.g. cha
+#include
Curious why do you need this header?
I'll return the question back to you, since you added this header for
regmap-sdw.c:
7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6) #include
Looks like it should be removed :)
I could compile it without any issues on few
+config SND_SOC_SC7180
+ tristate "SoC Machine driver for SC7180 boards"
+ depends on SND_SOC_QCOM
this depends is probably not necessary, the code is already in an if case.
+ select SND_SOC_QCOM_COMMON
+ select SND_SOC_LPASS_SC7180
+ select SND_SOC_MAX98357A
+
s.
Alternatively we can also split this in two, with ASoC-only and
SoundWire-only patches in separate series if it's easier for
maintainers. We would lose the rationale for the changes but that's not
essential.
Pierre-Louis Bossart (7):
ASoC: soc-dai: clarify return value for ge
On 9/1/20 6:07 AM, Vinod Koul wrote:
On 31-08-20, 10:15, Pierre-Louis Bossart wrote:
Detect cases where the clock is assumed to be stopped but the IP is
not in the relevant state, and add a dynamic debug trace.
you meant a debug print..and it looks like error print below (also in title
On 9/1/20 6:13 AM, Vinod Koul wrote:
mod_devicetable.h does not seem to be required for this file, so
remove it.
Signed-off-by: Vinod Koul
Reviewed-by: Pierre-Louis Bossart
---
changes in v2:
- fix typo in patch subject
drivers/base/regmap/regmap-sdw.c | 1 -
1 file changed, 1
Explicitly add header files used by regmap SoundWire support.
Suggested-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/regmap-sdw.c | 2 ++
1 file changed, 2
most often used parameter values are placed in the lower 16 bits
of the address. This helps to keep the paging registers constant while
updating Controls for a specific Device/Function.
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Acked-by: Bard Liao
Signe
ng
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Acked-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 6 +-
drivers/base/regmap/Makefile | 1 +
drivers/base/regmap/regmap-sdw-mbq.c | 101 +++
include/linux/reg
+ } else if (clock_stop_quirks & SDW_INTEL_CLK_STOP_BUS_RESET) {
+ ret = sdw_cdns_clock_stop(cdns, true);
+ if (ret < 0) {
+ dev_err(dev, "cannot enable clock stop on suspend\n");
+ return ret;
+ }
+
+
On 8/17/20 7:08 AM, Vinod Koul wrote:
On 22-07-20, 04:37, Bard Liao wrote:
This series adds power management support for Intel soundwire links.
I had applied except 3 & 9 (few skipped in middle due to conflict while
applying), BUT I get a build failure on patch 2 onwards :(
drivers/soundwi
The upcoming SDCA (SoundWire Device Class Audio) specification defines
a hiearchical encoding to interface with Class-defined capabilities,
typo hiearchical
ok
based on which audio function, entity, control and channel being used.
Can you please elaborate on what do these terms refer to
I had applied except 3 & 9 (few skipped in middle due to conflict while
applying), BUT I get a build failure on patch 2 onwards :(
drivers/soundwire/intel_init.c: In function ‘sdw_intel_cleanup’:
drivers/soundwire/intel_init.c:72:4: error: implicit declaration of
function ‘pm_runtime_disable
typo in commit message?
On 8/29/20 5:39 AM, Vinod Koul wrote:
mod_devicetable.h does not seem to be required for this file, so
remove it.
Signed-off-by: Vinod Koul
---
drivers/base/regmap/regmap-sdw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/base/regmap/regmap-sdw.c b/driv
for better
understanding.
Changes in v2:
- Split patches into sdw and asoc patches. Please note that "soundwire:
fix port_ready[] dynamic allocation in mipi_disco" and "ASoC: codecs:
fix port_ready[] dynamic allocation in ASoC codecs" should be merged
at the same
Detect cases where the clock is assumed to be stopped but the IP is
not in the relevant state, and add a dynamic debug trace.
you meant a debug print..and it looks like error print below (also in title).
I don't understand the comment. Is the 'trace' confusing and are you asking
to e.g. cha
kfree(bus->defer_msg.msg->buf);
+ kfree(bus->defer_msg.msg);
+ }
I'd prefer a conditional check for each, but sdw_ml_sync_bank_switch()
has this same pattern, so it looks like the lifetime of these two
match.
Reviewed-by: Nick Desaulniers
Also looks good to me.
Reviewed-by: Pierre-Louis Bossart
On 8/3/20 11:33 PM, Lu, Brent wrote:
For avoid further misunderstanding: it's fine that CRAS *uses* such a short
period. It's often required for achieving a short latency.
However, the question is whether the driver can set *only* this value for
making it working. IOW, if we don't have thi
@@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device *pdev)
if (!ctrl->regmap)
return -EINVAL;
} else {
- /* Only WCD based SoundWire controller is supported */
- return -ENOTSUPP;
+ ct
901 - 1000 of 1237 matches
Mail list logo
