On 7/19/19 4:04 AM, Rafael J. Wysocki wrote:
On Fri, Jul 19, 2019 at 1:02 AM Pierre-Louis Bossart
wrote:
The existing code has a mixed select/depend usage which makes no sense.
config SOUNDWIRE_BUS
tristate
select REGMAP_SOUNDWIRE
config REGMAP_SOUNDWIRE
tristate
+static int sof_dt_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ const struct sof_dev_desc *desc;
+ /*TODO: create a generic snd_soc_xxx_mach */
+ struct snd_soc_acpi_mach *mach;
I wonder if you really need to use the same structures. For Intel we
On 8/7/19 10:29 AM, Daniel Baluta wrote:
On Tue, Jul 23, 2019 at 6:19 PM Pierre-Louis Bossart
wrote:
diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
index 61b97fc55bb2..2aa3a1cdf60c 100644
--- a/sound/soc/sof/Kconfig
+++ b/sound/soc/sof/Kconfig
@@ -36,6 +36,15 @@ config
Hi Mark,
Vinod, Mark, any feedback?
There will be a set of SoundWire codec drivers provided upstream soonish and
we'll get a number of kbuild errors without this patch.
I think I'm missing context here, I've basically been zoning out all the
soundwire stuff - the patch series are huge and
@@ -35,6 +36,7 @@ static int sdw_slave_add(struct sdw_bus *bus,
slave->dev.release = sdw_slave_release;
slave->dev.bus = &sdw_bus_type;
+ slave->dev.of_node = of_node_get(to_of_node(fwnode));
shouldn't this protected by
#if IS_ENABLED(CONFIG_OF) ?
slave->bus = b
+/* 4 ports */
+static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = {
+ {
+ /* DAC */
+ .num = 1,
+ .type = SDW_DPN_SIMPLE,
IIRC we added the REDUCED type in SoundWire 1.1 to cover the PDM case
with channel packing (or was it
+++ b/Documentation/devicetree/bindings/soundwire/slave.txt
@@ -0,0 +1,46 @@
+SoundWire slave device bindings.
+
+SoundWire is a 2-pin multi-drop interface with data and clock line.
+It facilitates development of low cost, efficient, high performance systems.
+
+SoundWire slave devices:
+Every
+/* 4 ports */
+static struct sdw_dpn_prop wsa_sink_dpn_prop[WSA881X_MAX_SWR_PORTS] = {
+ {
+ /* DAC */
+ .num = 1,
+ .type = SDW_DPN_SIMPLE,
IIRC we added the REDUCED type in SoundWire 1.1 to cover the PDM case
with channel packing (or was it grouping) used by Qualco
diff --git a/sound/soc/sof/imx/Makefile b/sound/soc/sof/imx/Makefile
new file mode 100644
index ..c69237971da5
--- /dev/null
+++ b/sound/soc/sof/imx/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+
+ccflags-y += -DDEBUG
this should be removed or in
diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
index 61b97fc55bb2..2aa3a1cdf60c 100644
--- a/sound/soc/sof/Kconfig
+++ b/sound/soc/sof/Kconfig
@@ -36,6 +36,15 @@ config SND_SOC_SOF_ACPI
Say Y if you need this option
If unsure select "N".
+config SND_SOC_SOF_DT
On 6/17/19 2:45 PM, Arnd Bergmann wrote:
Compile-testing without PCI just causes warnings:
sound/soc/sof/sof-pci-dev.c:330:13: error: 'sof_pci_remove' defined but not
used [-Werror=unused-function]
static void sof_pci_remove(struct pci_dev *pci)
^~
sound/soc/sof/sof-
do an airport lounge review and didn't see any blatant issues, so feel
free to take the following tag for the series.
Reviewed-by: Pierre-Louis Bossart
On 6/26/19 3:36 PM, Jerome Brunet wrote:
Like cpus and platforms, defer sound card initialization if the codec
component is missing when initializing the dai_link
Signed-off-by: Jerome Brunet
---
sound/soc/soc-core.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/soc-c
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,swr.txt
b/Documentation/devicetree/bindings/soundwire/qcom,swr.txt
new file mode 100644
index ..eb84d0f4f36f
--- /dev/null
+++ b/Documentation/devicetree/bindings/soundwire/qcom,swr.txt
@@ -0,0 +1,62 @@
+Qualcomm SoundWi
+#define SWRM_COMP_HW_VERSION 0x00
Can we please use SDW_ or QCOM_SDW_ as prefix?
SWRM prefix is as per the data sheet register names, If it help am happy
to add QCOM_ prefix it.
That'd be fine. As long as there is no duplication and two
terms/prefixes used for the s
On 6/11/19 5:29 AM, Srinivas Kandagatla wrote:
On 10/06/2019 15:12, Pierre-Louis Bossart wrote:
+
+ if (dev_addr == SDW_BROADCAST_DEV_NUM) {
+ ctrl->fifo_status = 0;
+ ret = wait_for_completion_timeout(&ctrl->sp_cmd_comp,
+ msecs_
On 6/6/19 6:22 AM, Srinivas Kandagatla wrote:
multi bank switching code takes lock on condition but releases without
any check resulting in below warning.
This patch fixes this.
Question to make sure we are talking about the same thing: multi-link
bank switching is a capability beyond the sco
On 6/6/19 9:58 AM, Srinivas Kandagatla wrote:
On 06/06/2019 15:28, Pierre-Louis Bossart wrote:
On 6/6/19 6:22 AM, Srinivas Kandagatla wrote:
multi bank switching code takes lock on condition but releases without
any check resulting in below warning.
This patch fixes this.
Question to make
On 6/7/19 3:56 AM, Srinivas Kandagatla wrote:
This patch adds SDW_MAX_PORT so that other driver can use it.
Signed-off-by: Srinivas Kandagatla
---
include/linux/soundwire/sdw.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
i
On 6/7/19 3:56 AM, Srinivas Kandagatla wrote:
This patch adds bindings for Qualcomm soundwire controller.
Qualcomm SoundWire Master controller is present in most Qualcomm SoCs
either integrated as part of WCD audio codecs via slimbus or
as part of SOC I/O.
Signed-off-by: Srinivas Kandagatla
--
+config SOUNDWIRE_QCOM
+ tristate "Qualcomm SoundWire Master driver"
+ select SOUNDWIRE_BUS
+ depends on SND_SOC
depends on SLIMBUS if you need the SlimBus link to talk to your
SoundWire Master?
Also depends on device tree since you use of_ functions?
+#define SWRM_COMP
On 6/7/19 2:00 PM, Mark Brown wrote:
On Fri, Jun 07, 2019 at 05:31:12PM +0100, Guillaume Tucker wrote:
On 30/05/2019 16:53, Takashi Iwai wrote:
+ mutex_lock(&client_mutex);
for_each_rtdcom(rtd, rtdcom) {
component = rtdcom->component;
if (component->driv
On 6/7/19 5:19 PM, Alex Levin wrote:
When calling kmalloc with GFP_KERNEL in case CONFIG_SLOB is unset,
kmem_cache_alloc_trace is called.
In case CONFIG_TRACING is set, kmem_cache_alloc_trace will ball
slab_alloc, which will call slab_pre_alloc_hook which might_sleep_if.
The context in which
used by all other serial links.
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 2 +-
drivers/soundwire/Kconfig | 7 +--
drivers/soundwire/Makefile | 2 +-
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/r
On 7/21/19 9:23 AM, Masahiro Yamada wrote:
When CONFIG_UAPI_HEADER_TEST=y, exported headers are compile-tested to
make sure they can be included from user-space.
Currently, header.h and fw.h are excluded from the test coverage.
To make them join the compile-test, we need to fix the build erro
On 7/22/19 7:56 AM, Takashi Iwai wrote:
On Mon, 22 Jul 2019 14:49:34 +0200,
Pierre-Louis Bossart wrote:
On 7/21/19 9:23 AM, Masahiro Yamada wrote:
When CONFIG_UAPI_HEADER_TEST=y, exported headers are compile-tested to
make sure they can be included from user-space.
Currently, header.h
On 7/22/19 8:34 AM, Arnd Bergmann wrote:
On Mon, Jul 22, 2019 at 3:16 PM Pierre-Louis Bossart
wrote:
On 7/22/19 7:56 AM, Takashi Iwai wrote:
On Mon, 22 Jul 2019 14:49:34 +0200,
Pierre-Louis Bossart wrote:
On 7/21/19 9:23 AM, Masahiro Yamada wrote:
When CONFIG_UAPI_HEADER_TEST=y
On 7/22/19 8:39 AM, Arnd Bergmann wrote:
On Sun, Jul 21, 2019 at 4:25 PM Masahiro Yamada
wrote:
struct snd_sof_blk_hdr {
enum snd_sof_fw_blk_type type;
- uint32_t size; /* bytes minus this header */
- uint32_t offset;/* offset from base */
+ __u
cht_es8316_mc_remove().
Fixes: 0d3e91da0750 ("ASoC: Intel: bytcht_es8316: Add external speaker mux
support")
Signed-off-by: Wei Yongjun
Acked-by: Pierre-Louis Bossart
---
v1 -> v2: fix snd_byt_cht_es8316_mc_remove() instead, suggested by Dan.
---
sound/soc/intel/boards/bytcht_es8
if (!w_param_text)
+ return;
Acked-by: Pierre-Louis Bossart
next time, try using git format-patch -v2 to signal it's an updated
version, it helps reviewers. Thanks!
+
for (count = 0 ; count < num_params; count++)
devm_kfree(card->dev, (void *)w_pa
y set, but it is not
cleared if the device is subsequently removed. Adding a remove function
to clear the pointer fixes the problem.
Makes sense
Acked-by: Pierre-Louis Bossart
I'd like to highlight that there is a fundamental flaw in the way the
machine drivers are handled. Since we don&
On 3/25/19 8:12 AM, Mark Brown wrote:
On Sat, Mar 23, 2019 at 09:55:46AM -0400, Pierre-Louis Bossart wrote:
I'd like to highlight that there is a fundamental flaw in the way the
machine drivers are handled. Since we don't have a hook for the machine
driver in the BIOS, the DSP driver
While debugging Skylake audio stuff, I came across a kernel oops
introduced by this commit.
It's quite late here and my brain is fried, submitting as is but my
money is on the use of link->platform->of_node which is quite unlikely
to work on ACPI platforms.
and btw you may want to fix the ty
issue on my Skylake
XPS13 test device (blind testing since I don't understand what the code
does).
Tested-by: Pierre-Louis Bossart
Fixes: 8780cf1142a5 ("ASoC: soc-core: defer card probe until all component is added
to list")
Reported-by: Pierre-Louis Bossart
Signed-off-by: Ajit
Thanks for the overnight fix. This update fixes the issue on my
Skylake XPS13 test device (blind testing since I don't understand what
the code does).
Tested-by: Pierre-Louis Bossart
I need to take this back, this set of changes (initial+fix) causes an
error with our HDMI su
n
Fixes: 4772c16ede52 ("ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI
dependencies")
Signed-off-by: Pierre-Louis Bossart
---
already sent on January 23 but apparently missed
sound/soc/intel/Kconfig | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
On 04/02/2018 04:17 PM, Kirill Marinushkin wrote:
Hello Pierre-Louis,
I explicitly clarified with Takashi: to have this patch series merged, we need a
tag "Reviewed-by" from you.
I am fine with the changes, but maybe while we are at it, we should
clarify what mclk_direction means?
__u8
this convention is suggested:
PLT_CLK[2:0] - Camera
PLT_CLK[3] - Audio Codec
PLT_CLK[4] -
PLT_CLK[5] - COMMs
By the way, would I suggest to use same prefix as provider, i.e.
pmc_atom_plt_clk_%d ?
I tried this suggestion and it doesn't work unfortunately. It looks like
the struct cl
Fix Makefile for x86 support, dependency on CONFIG_COMMON_CLK
was not explicit
Fixes: 701190fd7419 ('clk: x86: add support for Lynxpoint LPSS clocks')
Signed-off-by: Pierre-Louis Bossart
---
drivers/clk/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/
ate
Irina Tirdea (3):
clk: x86: Add Atom PMC platform clocks
arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86
platform/x86: Enable Atom PMC platform clocks
Pierre-Louis Bossart (2):
clk: Make x86/ conditional on CONFIG_COMMON_CLK
platform/x86: fix typo in comment
arch/x
CherryTrail. These clocks
are available for general system use, where appropriate, and each
have Control & Frequency register fields associated with them.
Port from legacy by Pierre Bossart, integration in clock framework
by Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: I
s/Acumulate/Accumulate/
Signed-off-by: Pierre-Louis Bossart
---
include/linux/platform_data/x86/pmc_atom.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/platform_data/x86/pmc_atom.h
b/include/linux/platform_data/x86/pmc_atom.h
index aa8744c..e4905fe 100644
include files by
alphabetical order in pmc_atom.h
Signed-off-by: Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
---
arch/x86/Kconfig | 4
arch/x86/platform/atom/Makefile | 1 -
drivers/acpi/acpi_lpss.c
CherryTrail. These clocks
are available for general system use, where appropriate. For example,
the usage for platform clocks suggested in the datasheet is the
following:
PLT_CLK[0..2] - Camera
PLT_CLK[3] - Audio Codec
PLT_CLK[4] -
PLT_CLK[5] - COMMs
Signed-off-by: Pierre-Louis Bossart
On 1/16/17 1:45 AM, Shrirang Bagul wrote:
On Thu, 2017-01-12 at 08:40 -0600, Pierre-Louis Bossart wrote:
On 1/12/17 6:01 AM, Shrirang Bagul wrote:
rt5660 and rt5640 are similar codecs so reuse the bytcr_rt5640 driver.
RT5660 codec is used on Dell Edge IoT Gateways with ACPI ID 10EC3277.
These
Thanks for the review Stephen.
On 1/20/17 5:58 PM, Stephen Boyd wrote:
On 01/17, Pierre-Louis Bossart wrote:
diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
new file mode 100644
index 000..312d4e9
--- /dev/null
+++ b/drivers/clk/x86/clk-pmc-atom.c
atform/x86
platform/x86: Enable Atom PMC platform clocks
Pierre-Louis Bossart (2):
clk: Make x86/ conditional on CONFIG_COMMON_CLK
platform/x86: fix typo in comment
arch/x86/Kconfig | 4 -
arch/x86/platform/atom/Makefile| 1 -
dr
CherryTrail. These clocks
are available for general system use, where appropriate. For example,
the usage for platform clocks suggested in the datasheet is the
following:
PLT_CLK[0..2] - Camera
PLT_CLK[3] - Audio Codec
PLT_CLK[4] -
PLT_CLK[5] - COMMs
Signed-off-by: Pierre-Louis Bossart
s/Acumulate/Accumulate/
Signed-off-by: Pierre-Louis Bossart
---
include/linux/platform_data/x86/pmc_atom.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/platform_data/x86/pmc_atom.h
b/include/linux/platform_data/x86/pmc_atom.h
index aa8744c..e4905fe 100644
include files by
alphabetical order in pmc_atom.h
Signed-off-by: Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
---
arch/x86/Kconfig | 4
arch/x86/platform/atom/Makefile | 1 -
drivers/acpi/acpi_lpss.c
CherryTrail. These clocks
are available for general system use, where appropriate, and each
have Control & Frequency register fields associated with them.
Port from legacy by Pierre Bossart, integration in clock framework
by Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: I
Fix Makefile for x86 support, dependency on CONFIG_COMMON_CLK
was not explicit
Fixes: 701190fd7419 ('clk: x86: add support for Lynxpoint LPSS clocks')
Signed-off-by: Pierre-Louis Bossart
---
drivers/clk/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/
On 6/21/16 12:40 PM, Richard Cochran wrote:
On Tue, Jun 21, 2016 at 10:45:18AM -0700, Pierre-Louis Bossart wrote:
You can experiment with the 'dma' and 'link' timestamps today on any
HDaudio-based device. Like I said the synchronized part has not been
upstreamed yet (delays
+SoundWire stream states
+===
+Below figure shows the SoundWire stream states and possible state
+transition diagram.
+
+|--| |-| |--| |--|
+| ALLOC|>|CONFIG |>| PREPARE|>|ENABLE
Thanks for the reviews Mark, comment below:
On 11/14/16 7:17 AM, Mark Brown wrote:
On Fri, Oct 21, 2016 at 06:11:03PM +0530, Hardik Shah wrote:
This patch adds the SoundWire bus driver interfaces for following.
1. APIs to register/unregister SoundWire Master device and driver.
2. APIs to regis
On 11/14/16 10:08 AM, Charles Keepax wrote:
There are some issues with this, as the slave driver only probes
when the device actually shows up on the bus. However often
(especially in embedded contexts) some things may need to be
done to enable the slave. For example it may be held in reset or
it
On 12/17/16 7:57 AM, Andy Shevchenko wrote:
On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote:
On 12/15, Pierre-Louis Bossart wrote:
Clients use devm_clk_get() with a "pmc_plt_clk_"
argument.
This is the problem. Clients should be calling clk_get() like:
clk_get(de
On 12/19/16 9:55 AM, Mark Brown wrote:
On Mon, Dec 19, 2016 at 09:51:47PM +0800, Shrirang Bagul wrote:
+
+#define DEBUG
This should be production code...
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
The ordering o
On 12/21/16 5:05 PM, Stephen Boyd wrote:
On 12/19, Pierre-Louis Bossart wrote:
On 12/17/16 7:57 AM, Andy Shevchenko wrote:
On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd wrote:
On 12/15, Pierre-Louis Bossart wrote:
Clients use devm_clk_get() with a "pmc_plt_clk_"
argument.
T
them.
Signed-off-by: Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
Who is the actual author? SoB I guess should be either the author, or
1st, 2nd, ..., last one who is submitter.
I ported the initial code from Android legacy stuff and Irina ported the
functionality to the clk framework
Hi Stephen,
can you elaborate on the last comment?
thanks,
-Pierre
On 12/13/2016 05:25 PM, Stephen Boyd wrote:
+ void __iomem *base,
+ const char **parent_names,
+ int num_pare
On 12/16/16 2:46 AM, Andy Shevchenko wrote:
On Fri, Dec 16, 2016 at 7:15 AM, Pierre-Louis Bossart
wrote:
Hi Stephen,
can you elaborate on the last comment?
Please don't do top posting.
devm_kasprintf()
Please no.
That's why I used modal verb "might" instead of
On 1/12/17 6:01 AM, Shrirang Bagul wrote:
rt5660 and rt5640 are similar codecs so reuse the bytcr_rt5640 driver.
RT5660 codec is used on Dell Edge IoT Gateways with ACPI ID 10EC3277.
These devices sport only Line-In and Line-Out jacks.
While it would be nice to avoid copy/pasting everytime we a
On 8/10/16 12:06 PM, Mark Brown wrote:
On Wed, Aug 10, 2016 at 08:57:28AM -0500, Pierre-Louis Bossart wrote:
Without going into a debate on x86 v. the clock API or the merits of a patch
that has already been applied, I am pretty confused on who's supposed to
manage the mclk between the ma
On 7/29/16 11:39 AM, Mark Brown wrote:
On Fri, Jul 29, 2016 at 09:45:21PM +0530, Vinod Koul wrote:
Yeah I am not aware of any plan to have clks on x86. For audio we are not
going to use much. ACPI and controller w/ firmware does the job.
I have added Darren, he oversee platform things so mig
On 8/10/16 12:52 PM, Mark Brown wrote:
On Wed, Aug 10, 2016 at 12:31:28PM -0500, Pierre-Louis Bossart wrote:
If we want to be consistent then we need to have a framework that handles
both the SOC clock sources and the codec internal clock tree (including
dividers and switches)
I wonder if what
On 6/10/20 5:07 AM, Srinivas Kandagatla wrote:
For gapless playback call to snd_compr_drain_notify() after
partial drain should put the state to SNDRV_PCM_STATE_RUNNING
rather than SNDRV_PCM_STATE_SETUP as the driver is ready to
process the buffers for new track.
With existing code, if we are
On 6/11/20 12:09 PM, Lu, Brent wrote:
Hi Brent,
Thanks for the patch. Is this fix for a specific issue you're seeing?
If so, could you please give us some details about it?
Thanks,
Ranjani
Hi Ranjani,
It's reported to happen on GLK Chromebook 'Fleex' that sometimes it
cannot output the au
I added debug messages to print the RIRBWP register and realize
that
response could come between the read of RIRBWP in the
snd_hdac_bus_update_rirb() function and the interrupt clear in the
hda_dsp_stream_interrupt() function. The response is not handled
but
the interrupt is already cleared. It
nges.
Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
Fixes: fd443a20c2f0 ("ASoC: rt5682: fix I2C/Soundwire dependencies")
Signed-off-by: Arnd Bergmann
Reviewed-by: Pierre-Louis Bossart
Thanks for this cleanup.
Hi Michael,
+struct gpio_regmap_config {
+ struct device *parent;
+ struct regmap *regmap;
+
+ const char *label;
+ int ngpio;
could we add a .names field for the gpio_chip, I found this useful for
PCM512x GPIO support, e.g.
Sure, I have the names in the device tree.
But I'd pre
zed speaker amplifier types.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: e1435a1feb18 ("ASoC: Intel: bxt-da7219-max98357a: support MAX98390 speaker
amp")
Signed-off-by: Colin Ian King
Sounds good, thanks Colin.
Acked-by: Pierre-Louis Bossart
---
On 7/1/20 9:04 PM, Vincent Chen wrote:
On Thu, Jul 2, 2020 at 2:48 AM Pierre-Louis Bossart
wrote:
0day/kbuild reports warnings with the ASoC codecs compiled with W=1.
In file included from arch/riscv/include/asm/kgdb.h:109,
from include/linux/kgdb.h:20
On 7/2/20 2:35 AM, Liao, Bard wrote:
-Original Message-
From: Vinod Koul
Sent: Wednesday, July 1, 2020 1:42 PM
To: Pierre-Louis Bossart
Cc: Bard Liao ; alsa-de...@alsa-project.org;
ti...@suse.de; gre...@linuxfoundation.org; linux-kernel@vger.kernel.org;
ranjani.sridha
On 7/2/20 6:11 AM, Srinivas Kandagatla wrote:
For gapless playback its possible that each track can have different
codec profile with same decoder, for example we have WMA album,
we may have different tracks as WMA v9, WMA v10 and so on
Existing code does not allow to change this profile whil
On 7/2/20 6:18 AM, Mark Brown wrote:
On Wed, Jul 01, 2020 at 09:21:24PM -0400, Sasha Levin wrote:
From: Pierre-Louis Bossart
[ Upstream commit c8d2e2bfaeffa0f914330e8b4e45b986c8d30b58 ]
Usually the DSP is not traditionally enabled on H skews but this might
be used moving forward.
"
Fix W=1 warning
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/acp-da7219-max98357a.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/amd/acp-da7219-max98357a.c
b/sound/soc/amd/acp-da7219-max98357a.c
index 9414d7269c4f..7d8986379d80 100644
--- a/sound/soc/amd/acp-da7219
Fix W=1 warning
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/acp-rt5645.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c
index 73b31f88a6b5..87f0060e771f 100644
--- a/sound/soc/amd/acp-rt5645.c
+++ b/sound/soc/amd/acp
Fix W=1 warning. the card variable is useless here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 5bd458e0fe31..1f0fe5aaab1d 100644
Fix W=1 warning. The variable prtd is set but not used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-i2s.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index a0e14cc91d95..c3eb9b347eaa 100644
--- a
Fix W=1 warning. The variable prtd is not used, remove.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 1f0fe5aaab1d..17290c829c4b
Fix W=1 warning. the card variable is useless here
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-i2s.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index 14607563abd2..a0e14cc91d95 100644
--- a/sound
Fix W=1 warning
Kernel-doc is not used in one file and missing argument in the second.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/atmel/atmel-pcm-dma.c | 2 +-
sound/soc/atmel/atmel_ssc_dai.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/atmel/atmel-pcm
Fix W=1 warnings - typos with structure fields
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/spdif.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c
index 759fc6644329..4ae7ff623b82 100644
--- a/sound
Fix W=1 warnings - missing fields in structure
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/pcm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
index a5b1a12b3496..86eefbc89e9e 100644
--- a/sound/soc/samsung/pcm.c
+++ b
Fix W=1 warning - wrong parameter description and bad format
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/uniphier/aio-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c
index 9bcba06ba52e
Fix W=1 warnings - missing fields in description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-i2s.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index d0a8d5810c0a..f23ff29e7c1d 100644
Fix W=1 warning - missing parameter description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/qcom/qdsp6/q6asm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
index ae4b2cabdf2d..d67b23a5f397 100644
--- a
Fix W=1 warning:
sound/soc//tegra/tegra20_das.c:101:11: warning:
comparison of unsigned expression >= 0 is always true [-Wtype-limits]
101 | if ((reg >= TEGRA20_DAS_DAP_CTRL_SEL) &&
| ^~
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/tegra/tegra20_das.c |
Fix W=1 warning - typo in field description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 86779a99df75..326dd45e39da 100644
--- a/sound
Fix W=1 warnings. There is no kernel-doc here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi_dbg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi_dbg.c b/sound/soc/fsl/fsl_ssi_dbg.c
index 2a20ee23dc52..2c46c55f0a88 100644
--- a
Fix W=1 warnings. fix kernel doc and describe arguments.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_asrc.c | 57 +++-
1 file changed, 39 insertions(+), 18 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index
Fix W=1 warnings. Kernel-doc syntax was not properly used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl-asoc-card.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index
Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_esai.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index
Fix W=1 warnings. kernel-doc syntax was not followed and missing parameter
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_spdif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 5b2689ae63d4
Fix W=1 warnings. The kernel-doc support is partial, add more
descriptions and follow proper syntax
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi.c | 70 ++---
1 file changed, 44 insertions(+), 26 deletions(-)
diff --git a/sound/soc/fsl
On 7/2/20 1:47 PM, Nicolin Chen wrote:
On Thu, Jul 02, 2020 at 12:22:24PM -0500, Pierre-Louis Bossart wrote:
Fix W=1 warnings. Kernel-doc syntax was not properly used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl-asoc-card.c | 21 +
1 file changed, 9
On 7/2/20 1:55 PM, Nicolin Chen wrote:
On Thu, Jul 02, 2020 at 12:22:27PM -0500, Pierre-Louis Bossart wrote:
Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters.
Signed-off-by: Pierre-Louis Bossart
+ * fsl_esai_set_dai_sysclk - This function mainly configures the clock
Fix W=1 warnings. There is no kernel-doc here.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi_dbg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi_dbg.c b/sound/soc/fsl/fsl_ssi_dbg.c
index 2a20ee23dc52
Fix W=1 warnings. fix kernel doc and describe arguments.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_asrc.c | 57 +++-
1 file changed, 39 insertions(+), 18 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc
801 - 900 of 1237 matches
Mail list logo
