On 5/6/19 10:40 AM, Hans de Goede wrote:
Hi,
On 05-05-19 09:51, Takashi Iwai wrote:
On Sat, 04 May 2019 17:16:52 +0200,
Nariman wrote:
From: Jordy Ubink
The snprintf calls filling byt_rt5651_cpu_dai_name /
byt_rt5651_cpu_dai_name always fill them with the same string
(ssp0-port" resp "rt5
On 5/6/19 11:22 AM, Vinod Koul wrote:
On 06-05-19, 17:19, Greg KH wrote:
On Mon, May 06, 2019 at 09:42:35AM -0500, Pierre-Louis Bossart wrote:
+
+int sdw_sysfs_slave_init(struct sdw_slave *slave)
+{
+ struct sdw_slave_sysfs *sysfs;
+ unsigned int src_dpns, sink_dpns, i, j
Thanks for the quick feedback Greg!
+static const struct attribute_group sdw_master_node_group = {
+ .attrs = master_node_attrs,
+};
+
+static const struct attribute_group *sdw_master_node_groups[] = {
+ &sdw_master_node_group,
+ NULL
+};
Minor nit, you can use the ATTRIBUTE_
On 5/6/19 11:38 AM, Vinod Koul wrote:
On 06-05-19, 09:48, Pierre-Louis Bossart wrote:
+struct dentry *sdw_bus_debugfs_get_root(struct sdw_bus_debugfs *d)
+{
+ if (d)
+ return d->fs;
+ return NULL;
+}
+EXPORT_SYMBOL(sdw_bus_debugfs_get_root);
_GPL()?
Oops, that&
[=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
SND_SOC_SOF_TOPLEVEL [=y] && (ACPI [=y] || COMPILE_TEST [=n]) && X86 [=y]
Signed-off-by: Randy Dunlap
Cc: Liam Girdwood
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Acked-by:
On 5/6/19 5:53 PM, Evan Green wrote:
Add support for Intel Comet Lake platforms by adding a new Kconfig
for CometLake and the appropriate PCI ID.
This is odd. I checked internally a few weeks back and the CML PCI ID
was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To
t
On 5/3/19 7:29 PM, Pierre-Louis Bossart wrote:
The MIPI DisCo specification for SoundWire defines the
"mipi-sdw-link-N-subproperties", not the master-N properties. Fix to
parse firmware information.
Please ignore this patch for now, there is a confusion in the spec
itself that n
+int sdw_sysfs_bus_init(struct sdw_bus *bus)
+{
+ struct sdw_master_sysfs *master;
+ int err;
+
+ if (bus->sysfs) {
+ dev_err(bus->dev, "SDW sysfs is already initialized\n");
+ return -EIO;
+ }
+
+ master = kzalloc(sizeof(*master), GFP_K
On 5/6/19 10:34 PM, M R, Sathya Prakash wrote:
-Original Message-
From: Pierre-Louis Bossart [mailto:pierre-louis.boss...@linux.intel.com]
Sent: Tuesday, May 7, 2019 7:11 AM
To: Evan Green ; Liam Girdwood
; Mark Brown
Cc: M, Naveen ; M R, Sathya Prakash ; Ben Zhang
; Rajat Jain
On 5/7/19 12:19 AM, Vinod Koul wrote:
On 06-05-19, 11:46, Pierre-Louis Bossart wrote:
On 5/6/19 11:22 AM, Vinod Koul wrote:
On 06-05-19, 17:19, Greg KH wrote:
On Mon, May 06, 2019 at 09:42:35AM -0500, Pierre-Louis Bossart wrote:
+
+int sdw_sysfs_slave_init(struct sdw_slave *slave
On 5/7/19 7:26 AM, Vinod Koul wrote:
On 03-05-19, 19:29, Pierre-Louis Bossart wrote:
The convention is that the SoundWire controller device is a child of
the HDAudio controller. However there can be more than one child
exposed in the DSDT table, and the current namespace walk returns the
On 5/6/19 5:53 PM, Evan Green wrote:
Add support for Intel Comet Lake platforms by adding a new Kconfig for
CometLake and the appropriate PCI ID.
This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8,
same as WHL and CNL, so we did not add a PCI ID on purpose. To
What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML
PCH-H (0x06C8).
Can we respin this patchset to add support for those last two instead of
just the -LP case?
Sure. So just to clarify, you want the entry for 0x02c8, and you want
an additional entry for 0x06c8 under the same
Minor nit-picks below. The Kconfig would work but select CANNONLAKE even
if you don't want it.
+config SND_SOC_SOF_COMETLAKE_LP
+ tristate
+ select SND_SOC_SOF_CANNONLAKE
This should be
select SND_SOF_SOF_HDA_COMMON
+ help
+ This option is not user-selectable bu
On 5/7/19 4:53 PM, Evan Green wrote:
Add PCI IDs for Intel CometLake platforms, which from a software
point of view are extremely similar to Cannonlake platforms.
Humm, I have mixed feelings here.
Yes the hardware is nearly identical, with the exception of one detail
that's not visible to the
The model here is that Master device is PCI or Platform device and then
creates a bus instance which has soundwire slave devices.
So for any attribute on Master device (which has properties as well and
representation in sysfs), device specfic struct (PCI/platfrom doesn't
help). For slave that
On 4/26/19 11:47 AM, Ross Zwisler wrote:
Currently in sst_dsp_new() if we get an error return from sst_dma_new()
we just print an error message and then still complete the function
successfully. This means that we are trying to run without sst->dma
properly set up, which will result in NULL poin
a sst->pdata->resindex_dma_base
being set to -1.
Signed-off-by: Ross Zwisler
Cc: sta...@vger.kernel.org
Acked-by: Pierre-Louis Bossart
Thanks Ross!
FWIW we should start deprecating this driver now and transition to SOF.
I'll double-check how the upcoming 1.3 release works on my Pixel
2015/
On 4/30/19 3:51 AM, Vinod Koul wrote:
On 15-04-19, 08:09, Pierre-Louis Bossart wrote:
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c| 87
drivers/soundwire/bus.h| 16
My patch-bot would reject a patch that tried to do multiple types of
different cleanups on the same file(s). Has done so for _years_, this
is not a new thing.
If there are tools let's use them (all the fixes in this series were
reported by tools). Can you share pointers and location of this
_next_child_node()")', so
this should probably go to linux-stable all the way to 4.12
Signed-off-by: Pierre-Louis Bossart
---
drivers/acpi/property.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 5815356ea6ad
On 4/30/19 9:54 AM, Vfiinod Koul wrote:
On 30-04-19, 08:38, Pierre-Louis Bossart wrote:
On 4/30/19 3:51 AM, Vinod Koul wrote:
On 15-04-19, 08:09, Pierre-Louis Bossart wrote:
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire
On 4/30/19 11:30 AM, Andy Shevchenko wrote:
On Tue, Apr 30, 2019 at 10:52:29AM -0500, Pierre-Louis Bossart wrote:
When the DSDT tables expose devices with subdevices and a set of
hierarchical _DSD properties, the data returned by
acpi_get_next_subnode() is incorrect, with the results suggesting
On 4/16/19 3:09 AM, Rafael J. Wysocki wrote:
On Tue, Apr 16, 2019 at 5:29 AM Vinod Koul wrote:
On 15-04-19, 10:18, Pierre-Louis Bossart wrote:
Standards such as the MIPI DisCo for SoundWire 1.0 specification
assume the _ADR field is 64 bits.
_ADR is defined as an "Integer" repr
On 5/1/19 5:23 AM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a hda_dsp_rom_msg message, fix it.
Signed-off-by: Colin Ian King
Acked-by: Pierre-Louis Bossart
Thanks for the fix!
---
sound/soc/sof/intel/hda.c | 2 +-
1 file changed, 1 insertion(+), 1
e:
Before:
$ more /sys/bus/acpi/devices/device\:38/adr
0x5d07
After:
$ more /sys/bus/acpi/devices/device\:38/adr
0x10025d07
Signed-off-by: Pierre-Louis Bossart
---
v2: only use 64 bits when required to avoid compatibility issues
(feedback from Vinod and Rafael)
drivers/acpi/device_s
code is
exactly the same as in v3.
Changes since v2:
fixed inversion of devm_kcalloc parameters, detected while rebasing
additional patches.
Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (22):
soundwire: Kconfig: fix help format
soun
No C++ comments in .h files
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.h| 4 ++--
drivers/soundwire/cadence_master.h | 4 ++--
drivers/soundwire/intel.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a
Move to the regular help format, --help-- is no longer recommended.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index
and make the code more readable
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index efdcefc62e1a..423dc6d17999 100644
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 66 -
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 688848637099
tools complain here and the location of the newline does not improve
readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 863bf418e342
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/mipi_disco.c b/drivers/soundwire/mipi_disco.c
index 95efa82dc73b
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 8c653a563534..2852ce293fd4 100644
Extra newline does not improve readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 50181752c2a4
While not strictly necessary, balanced parentheses help with code
readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 74 +--
drivers/soundwire/cadence_master.c | 12 ++--
drivers/soundwire
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 59 +++
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 70ca27ccad85
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 79 +++---
1 file changed, 40 insertions(+), 39 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/slave.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index ac103bd0c176..f39a5815e25d 100644
--- a/drivers
Extra parentheses required here
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 56d6c1dda0ff
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 161 +++--
1 file changed, 84 insertions(+), 77 deletions(-)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 63b162feecfc
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel_init.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index e0f2903101c7..9ad6045720c4
no need for an explicit test against false
reported by Coccinelle
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 423dc6d17999
spelling mistakes
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 74e04caa811b..efdcefc62e1a 100644
--- a/drivers/soundwire
use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.h| 12 ++--
drivers/soundwire/cadence_master.h | 18 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/soundwire/bus.h b/drivers
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus_type.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
index 283b2832728e..2655602f0cfb 100644
--- a
Use Linux style. In some cases parenthesis alignment is modified to
keep the code readable.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 112 ++---
1 file changed, 62 insertions(+), 50 deletions(-)
diff --git a
On 5/2/19 1:32 AM, Greg KH wrote:
On Thu, May 02, 2019 at 11:07:46AM +0530, Vinod Koul wrote:
On 01-05-19, 10:57, Pierre-Louis Bossart wrote:
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre
On 5/2/19 11:39 PM, Mark Brown wrote:
On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote:
config REGMAP_SOUNDWIRE
tristate
- depends on SOUNDWIRE_BUS
+ select SOUNDWIRE_BUS
This now makes _SOUNDWIRE different to all the other bus types; if this
is a
1. The existing code uses a
bitmask between enums, one of which being zero. Or'ing with zero is
not very useful in general...Fix by or-ing with a BIT dependent on the
enum value.
Fix additional comments to align with MIPI spec
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c
sdw_slave_read_dp0 was so far a static function, which prevented codec
drivers from using it. Expose as non-static function and add symbol
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 7 ---
include/linux/soundwire/sdw.h | 3 +++
2 files changed, 7 insertions
Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index bd05a85d345c..80584e9d5970 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux
sdw_slave_read_dpn was so far a static function, which prevented
codec drivers from using it. Expose as non-static function and add symbol
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 7 ---
include/linux/soundwire/sdw.h | 3 +++
2 files changed, 7 insertions
The MIPI DisCo specification for SoundWire defines the
"mipi-sdw-link-N-subproperties", not the master-N properties. Fix to
parse firmware information.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
nd DPn levels. Rename
to follow the MIPI definitions, no need to be creative here.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 2 +-
drivers/soundwire/mipi_disco.c | 6 +++---
drivers/soundwire/stream.c | 6 +++---
include/linux/soundwire/sdw.h | 13 +++-
avoid email bounces and avoid spamming them forever with SoundWire
patches.
Pierre-Louis Bossart (8):
soundwire: intel: filter SoundWire controller device search
soundwire: mipi_disco: fix master/link error
soundwire: mipi_disco: expose sdw_slave_read_dpn as symbol
soundwire: mipi_disco: e
Somehow previous header files did not include definition for
sink/source, flow and grouping.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 53 +++
1 file changed, 53 insertions(+)
diff --git a/include/linux/soundwire/sdw.h b/include
iterating to find the next child.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel_init.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index d3d6b54c5791..f85db67d05f0 100644
Add debugfs file to dump the Intel SoundWire registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change
is the use of scnprintf to avoid known issues with snprintf.
Signed-off-by: Pierre-Louis Bossart
For each master N, add a device sdw-master:N and add the
master properties as attributes.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile| 3
The description is directly derived from the MIPI DisCo specification.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
.../ABI/testing/sysfs-bus-soundwire-master| 21
The description is directly derived from the MIPI DisCo specification.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah
Signed-off-by: Pierre-Louis Bossart
---
.../ABI/testing/sysfs-bus-soundwire-slave | 85
Add debugfs file to dump the Cadence master registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change
is the use of scnprintf to avoid known issues with snprintf.
Signed-off-by: Pierre-Louis Bossart
Kale, Shreyas Nc and Hardik Shah
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile | 2 +-
drivers/soundwire/bus.c | 2 +
drivers/soundwire/bus.h | 2 +
drivers/soundwire/bus_type.c| 5 +
drivers/soundwire/slave.c | 1
ump the Master and Slave registers, as
well as the Intel-specific parts. One of the main changes from the
previous code was to harden the code with scnprintf
Feedback welcome.
~Pierre
Pierre-Louis Bossart (7):
soundwire: Add sysfs support for master(s)
soundwire: add Slave sysfs support
ABI:
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change
is the use of scnprintf to avoid known issues with snprintf.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile| 3 +-
drivers/soundwire/bus.c | 5 +
drivers/soundwire/bus.h | 28 +
drivers
#Cadence Objs
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 49f64b2115b9..89d5f1537d9b 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -49,6 +49,8 @@ int sdw_add_bus_master(struct sdw_bus *bus)
}
}
+ bus->debugfs = sdw_bu
On 8/10/19 2:03 AM, Greg KH wrote:
On Fri, Aug 09, 2019 at 05:43:40PM -0500, Pierre-Louis Bossart wrote:
+/**
+ * sdw_cdns_debugfs_init() - Cadence debugfs init
+ * @cdns: Cadence instance
+ * @root: debugfs root
+ */
+void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root
r fallback compilation
removed intermediate variables
removed hard-coded constants in loops (used registers offsets and
hardware capabilities)
squashed patch 3
Pierre-Louis Bossart (3):
soundwire: add debugfs support
soundwire: cadence_master: add debugfs register dump
soundwire: intel: a
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile| 4 +
drivers/soundwire/bus.c | 6 ++
drivers/soundwire/bus.h | 16
drivers/soundwire/bus_type.c | 3 +
drivers/soundwire/debugfs
Add debugfs file to dump the Cadence master registers.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 107
Add debugfs file to dump the Intel SoundWire registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 121 ++
1 file
Looks like the merge resolution is not quite right.
I have used the sound-asoc tree from next-20190808 for today.
I am still getting this failure ...
Intel people, any thoughts?
I provided a solution on alsa-devel yesterday, see 'ASoC: SOF: fix HDA
direct MMIO access'
On 8/13/19 6:29 AM, Mark Brown wrote:
On Tue, Aug 13, 2019 at 03:24:51AM -0700, Tony Lindgren wrote:
* Takashi Iwai [190809 08:24]:
... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".
Mark, looks like this comm
On 8/13/19 1:10 AM, Nathan Chancellor wrote:
clang warns when CONFIG_ACPI is unset:
../drivers/soundwire/slave.c:16:12: warning: unused function
'sdw_slave_add' [-Wunused-function]
static int sdw_slave_add(struct sdw_bus *bus,
^
1 warning generated.
Before commit 8676b3ca4673 ("soun
On 8/13/19 3:35 AM, Srinivas Kandagatla wrote:
On platforms which have smart speaker amplifiers connected via
soundwire and modeled as aux devices in ASoC, in such usecases machine
driver should be able to get sdw master stream from dai so that it can
use the runtime stream to setup slave streams
On 8/13/19 3:35 AM, Srinivas Kandagatla wrote:
From: Vinod Koul
This callback allows masters to compute the bus parameters required.
This looks like a partial use of the patch ('soundwire: Add Intel
resource management algorithm')? see comments below
Signed-off-by: Vinod Koul
Signed-off
On 8/13/19 11:50 AM, Srinivas Kandagatla wrote:
Thanks for the review,
On 13/08/2019 15:44, Pierre-Louis Bossart wrote:
On 8/13/19 3:35 AM, Srinivas Kandagatla wrote:
On platforms which have smart speaker amplifiers connected via
soundwire and modeled as aux devices in ASoC, in such usecases
On 8/13/19 1:17 PM, Srinivas Kandagatla wrote:
On 13/08/2019 15:34, Pierre-Louis Bossart wrote:
On 8/13/19 3:35 AM, Srinivas Kandagatla wrote:
From: Vinod Koul
This callback allows masters to compute the bus parameters required.
This looks like a partial use of the patch ('soundwire
On 8/13/19 1:06 PM, Srinivas Kandagatla wrote:
On 13/08/2019 18:51, Pierre-Louis Bossart wrote:
On 8/13/19 11:50 AM, Srinivas Kandagatla wrote:
Thanks for the review,
On 13/08/2019 15:44, Pierre-Louis Bossart wrote:
On 8/13/19 3:35 AM, Srinivas Kandagatla wrote:
On platforms which have
On 8/13/19 2:18 PM, Mark Brown wrote:
On Tue, Aug 13, 2019 at 02:15:18PM -0500, Pierre-Louis Bossart wrote:
On 8/13/19 1:06 PM, Srinivas Kandagatla wrote:
sorry for the confusion. It was too quick reply. :-)
I was suppose to say sdw_stream_add_slave() instead of set_sdw_stream().
ok, so
ap dependencies and align with other serial
links")
Link: https://github.com/ClangBuiltLinux/linux/issues/637
Signed-off-by: Nathan Chancellor
Sounds good, thanks for the fix.
Acked-by: Pierre-Louis Bossart
---
v1 -> v2:
* Rename slave.o to acpi_slave.o
* Reword commit message to
Implement suspend/resume capabilities (not runtime_pm for now)
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 18 ++--
drivers/soundwire
-Louis Bossart
---
drivers/soundwire/cadence_master.c | 15 ---
drivers/soundwire/cadence_master.h | 2 +-
drivers/soundwire/intel.c | 2 +-
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 84 +-
drivers/soundwire/cadence_master.h | 1 +
drivers/soundwire/intel.c | 14 -
3 files changed, 73 insertions(+), 26 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers
Add basic hooks in DAI .startup and .shutdown callbacks. The SoundWire
IP should be powered between those two calls.
By default the platform_device is in SUSPENDED mode, it is required to
call pm_runtime_set_active() before _enable()
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire
Move code to helper for reuse in power management routines
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 5f14c6acce80
Provide debugfs capability to kick link and devices into hard-reset
(as defined by MIPI). This capability is really useful when some
devices are no longer responsive and/or to check the software handling
of resynchronization.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire
S in pm_runtime code
Clarified commit messages
Pierre-Louis Bossart (6):
soundwire: fix startup sequence for Intel/Cadence
soundwire: cadence_master: add hw_reset capability in debugfs
soundwire: intel: add helper for initialization
soundwire: intel: Add basic power management support
soundwire:
+static u32 cdns_set_initial_frame_shape(int n_rows, int n_cols)
+{
+ u32 val;
+ int c;
+ int r;
+
+ r = sdw_find_row_index(n_rows);
+ c = sdw_find_col_index(n_cols) & CDNS_MCP_FRAME_SHAPE_COL_MASK;
+
+ val = (r << CDNS_MCP_FRAME_SHAPE_ROW_OFFSET) | c;
+
+ return val;
+}
+
On 8/13/19 11:11 PM, Vinod Koul wrote:
On 13-08-19, 20:58, Mark Brown wrote:
On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote:
Indeed. I don't have a full understanding of that part to be honest, nor why
we need something SoundWire-specific. We already abuse
fs only if CONFIG_DEBUG_FS is selected
used static inlines for fallback compilation
removed intermediate variables
removed hard-coded constants in loops (used registers offsets and
hardware capabilities)
squashed patch 3
Pierre-Louis Bossart (3):
soundwire: add debugfs support
soundwire: cadence_m
Add debugfs file to dump the Intel SoundWire registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 114 ++
1 file
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile| 5 ++
drivers/soundwire/bus.c | 6 ++
drivers/soundwire/bus.h | 24 ++
drivers/soundwire/bus_type.c | 3 +
drivers/soundwire/debugfs
Add debugfs file to dump the Cadence master registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 104 +
drivers
On 7/31/19 9:50 PM, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the sound-asoc tree got conflicts in:
sound/soc/intel/skylake/skl-nhlt.c
sound/soc/intel/skylake/skl.h
between commit:
1169cbf6b98e ("ASoC: Intel: Skylake: use common NHLT module")
from the sound tree
On 7/25/19 12:35 AM, Christophe JAILLET wrote:
Fix some typo to have the filaname given in a comment match the real name
of the file.
Some 'acpi' have erroneously been written 'apci'
Signed-off-by: Christophe JAILLET
yes, thanks for the corrections.
Acked-by:
uciak and Tomasz Lauda on the SOF side,
currently being reviewed, see
https://github.com/thesofproject/sof/pull/1638
Comments and feedback welcome!
Bard liao (1):
soundwire: include mod_devicetable.h to avoid compiling warnings
Pierre-Louis Bossart (38):
soundwire: add debugfs support
soun
601 - 700 of 1237 matches
Mail list logo
