Presentation time is either set by
a) Local sound card performing capture (in which case it will be 'capture
time')
b) Local media application sending a stream accross the network
(time when the sample should be played out remotely)
c) Remote media application streaming data *to* host, in
On 6/20/16 5:31 AM, Richard Cochran wrote:
On Mon, Jun 20, 2016 at 02:18:38PM +0200, Richard Cochran wrote:
Documentation/sound/alsa/timestamping.txt says:
Examples of typestamping with HDaudio:
1. DMA timestamp, no compensation for DMA+analog delay
$ ./audio_time -p --ts_type=1
Wh
On 6/20/16 5:18 AM, Richard Cochran wrote:
On Mon, Jun 20, 2016 at 01:08:27PM +0200, Pierre-Louis Bossart wrote:
The ALSA API provides support for 'audio' timestamps (playback/capture rate
defined by audio subsystem) and 'system' timestamps (typically linked to
TSC/ART) wit
+ if (found == false) {
+ /* TODO: Park this device in Group 13 */
+ dev_err(bus->dev, "Slave Entry not found");
No break here? Otherwise...
Thats intentional. We want to still read next device that show up
+ }
+
On 11/1/17 4:08 AM, Vinod Koul wrote:
On Wed, Nov 01, 2017 at 02:49:15AM +0530, Pierre-Louis Bossart wrote:
+ if (found == false) {
+ /* TODO: Park this device in Group 13 */
+ dev_err(bus->dev, "Slave Entry not found"
On 11/2/17 6:07 AM, Arnd Bergmann wrote:
I ran into multiple problems during randconfig builds of the
recently changed Kconfig logic for Intel ASoC drivers:
we did quite a bit of testing on this change, looks like we missed a
number of cases. Gah.
- Building without DMADEVICES doesn't work
On 11/10/17 8:48 PM, Ruslan Bilovol wrote:
On Wed, Nov 8, 2017 at 9:38 PM, Pierre-Louis Bossart
wrote:
Nice work, thanks! I double-checked all the descriptors and values and
didn't find anything problematic, the main comment I have is that the clock
source/selection could probab
On 11/10/2017 12:36 PM, Jeremy Cline wrote:
Replace snd_soc_acpi_check_hid() with the generic acpi_dev_present()
and remove the now unused snd_soc_acpi_check_hid function. This should
have no functional change.
The code looks ok, but I'd like to first add the fix for the quirk
handling regre
On 11/14/2017 01:12 PM, Jeremy Cline wrote:
On Mon, Nov 13, 2017 at 01:43:57PM -0600, Pierre-Louis Bossart wrote:
On 11/10/2017 12:36 PM, Jeremy Cline wrote:
Replace snd_soc_acpi_check_hid() with the generic acpi_dev_present()
and remove the now unused snd_soc_acpi_check_hid function. This
datasheet on hand CherryTrail has them, though they both
provide 19.2MHz frequency.
Fixes: 282a4e4ce5f9 ("platform/x86: Enable Atom PMC platform clocks")
Cc: Pierre-Louis Bossart
Signed-off-by: Andy Shevchenko
---
drivers/platform/x86/pmc_atom.c | 7 ++-
1 file changed, 6 insert
On 10/18/17 11:07 AM, Carlo Caione wrote:
From: Carlo Caione
While working on enabling a cherry-trail laptop shipping the rt5651
codec I realized that the machine driver needed some fixup.
In particular the laptop I'm working on (KIANO SlimNote 14.2) has the
internal mic connected to the IN2 p
line or with
modprobe (as done in other machine drivers).
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c
b
On 10/19/17 6:03 AM, Carlo Caione wrote:
From: Carlo Caione
Enable jack detection or the RT5651 codec on the JD1_1 pin.
Nice, but the codec supports a second jack detection on JD1 and has a
second JD2 pin. I will bet that some devices will have a different
routing and I wonder if we could j
On 10/19/17 6:03 AM, Carlo Caione wrote:
From: Carlo Caione
Introduce an headset jack in the machine driver and register it to the
codec driver.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 24
1 file changed, 24 insertions(+)
diff --git
never read
Signed-off-by: Colin Ian King
Indeed this has been unused since at least 2015...
FWIW
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/common/sst-firmware.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/intel/common/sst-firmware.c
b/sound/soc/intel/common/sst-
This val_bit is only there for debug/test, it should be set to one by
default and has nothing to do with the lpcm_id. This variable was set
even in patches before upstream submission and was never needed, I guess
it must be a 9-yr old issue. Good catch!
Acked-by: Pierre-Louis Bossart
BTW
Good to hear, applied the patch now.
BTW looking at the structures in intel_hdmi_lpe_audio.h, the field
format:3 in audio_ch_status_0 is misleading at best, it should be the
emphasis if I look at the SPDIF/AES docs. It's not used but I'll have
to relook at all this when I find some time... We
On 7/27/18 5:13 AM, Akshu Agrawal wrote:
There are cases where a pointer function populates
runtime->delay, such as:
./sound/pci/hda/hda_controller.c
./sound/soc/intel/atom/sst-mfld-platform-pcm.c
Also, in some cases cpu dai used is generic and the pcm
driver needs to set delay.
This delay was
On 7/27/18 11:28 PM, Agrawal, Akshu wrote:
On 7/27/2018 8:39 PM, Pierre-Louis Bossart wrote:
On 7/27/18 5:13 AM, Akshu Agrawal wrote:
There are cases where a pointer function populates
runtime->delay, such as:
./sound/pci/hda/hda_controller.c
./sound/soc/intel/atom/sst-mfld-platform-pc
On 8/1/18 4:00 AM, Takashi Iwai wrote:
On Wed, 01 Aug 2018 12:47:42 +0200,
Colin King wrote:
From: Colin Ian King
Variable cfg_val is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'cfg_val' set but not used [-Wunused-but
On 7/12/18 10:42 AM, Takashi Iwai wrote:
On Thu, 12 Jul 2018 17:26:00 +0200,
Pierre-Louis Bossart wrote:
On 7/11/18 3:43 AM, Srinivas Kandagatla wrote:
This patch aims at add achieving dynamic behaviour of audio card when
the dependent components disappear and reappear.
With this patch the
n
Fixes: 4772c16ede52 ("ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI
dependencies")
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/inte
On 1/21/18 4:14 PM, Arnd Bergmann wrote:
In a configuration with SND_SST_ATOM_HIFI2_PLATFORM_PCI=y and
SND_SST_ATOM_HIFI2_PLATFORM=m, we get this module link failure:
ERROR: "sst_context_init" [sound/soc/intel/atom/sst/snd-intel-sst-acpi.ko]
undefined!
ERROR: "sst_context_cleanup" [sound/soc/in
On 1/22/18 5:39 AM, Andy Shevchenko wrote:
On Mon, 2018-01-22 at 11:58 +0100, Arnd Bergmann wrote:
On Mon, Jan 22, 2018 at 10:51 AM, Andy Shevchenko
wrote:
On Sun, 2018-01-21 at 23:14 +0100, Arnd Bergmann wrote:
Slightly later, commit 05f4434bc130 ("ASoC: Intel: remove
mfld_machine")
was ad
+ devices
Fixed a couple of indentation issues
Pierre-Louis Bossart (8):
ASoC: acpi: add missing includes for non-ACPI platforms
ASoC: Intel: Fix Kconfig with top-level selector
ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies
ASoC: Intel: document what Kconfig options do
ASo
Make sure all the configs are aligned
Also add the missing dependencies on SOC_ACPI stuff used to fix
DAI names based on HID and fix a couple of indentation issues
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
---
sound/soc/intel/boards/Kconfig | 33
Make sure that the same I2C/I2C_DESIGNWARE_PLATFORM are selected.
The latter might actually need to be moved to the SOC side of things,
it really has no place in a machine driver dependency
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
---
sound/soc/intel/boards/Kconfig | 2
From: Vinod Koul
Drop "Intel ASoC SST driver for " platforms and "SOC Machine Audio driver
for Intel" for machines..
Signed-off-by: Vinod Koul
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
---
sound/soc/intel/Kconfig| 10 +-
sound/soc/
ested with each of Haswell, Baytrail legacy, HiFi2, SKL cases
selected independently. 0-day and explicit randconfig tests did not report
additional issues and no functionality loss was observed in Intel tests on
HIFI2 and SKYLAKE platforms
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevc
the near future to
allow for this option to be selected by both SST and SOF drivers
(simplification with submenu for machine drivers by Vinod Koul)
Fixes: f6a118a800e3 ("ASoC: Intel: clarify Kconfig dependencies")
Reported-by: Linus Torvalds
Signed-off-by: Pierre-Louis Bossart
Sig
From: Vinod Koul
Help in finding matching "if" endings by commenting the "endif".
Signed-off-by: Vinod Koul
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
---
sound/soc/intel/boards/Kconfig | 10 +-
1 file changed, 5 insertions(+), 5 deleti
No reason why SND_SOC_INTEL_SST should be set here.
Also make sure same dependencies are used everywhere (only last one has SPI
in addition). Replace X86_INTEL_LPSS by MFD_INTEL_LPSS since the former
makes no sense for Skylake+ devices
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy
hid[ACPI_ID_LEN])
sound/soc/soc-acpi.c: At top level:
>> sound/soc/soc-acpi.c:174:16: error: expected declaration specifiers or
'...' before string constant
MODULE_LICENSE("GPL v2");
Add missing include files.
Fixes: 7feb2f786a46 ("ASoC: move ACPI common
Document in comments what the options are supposed to mean, before
clean-up in next patch.
No functionality change here.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
---
sound/soc/intel/Kconfig | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff
by anyone, and with Edison now defunct support for
Merrifield/Edison is to be determined.
The dependency on SND_DMA_SGBUF for Haswell is not clear at this
point and may have to be further updated.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Andy Shevchenko
---
sound/soc/intel/Kconfig
On 1/5/18 4:06 AM, Sagar Arun Kamble wrote:
On 1/3/2018 1:23 AM, Pierre-Louis Bossart wrote:
On 1/2/18 12:21 PM, Richard Cochran wrote:
On Tue, Jan 02, 2018 at 11:15:45AM -0600, Pierre-Louis Bossart wrote:
I wrote the code for HDaudio and I remember wasting time trying to
figure
out the
On 1/5/18 11:04 AM, Mark Brown wrote:
On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote:
+ /* SoundWire register address are contiguous */
+ if (config->reg_stride != 0)
+ return -ENOTSUPP;
That doesn't mean the chip hasn't decided not to use half the addres
the only place this remains. Thanks for the patch.
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index b0bd1938b71e..f2c9e8c5970a 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/so
On 04/05/2018 08:14 PM, Mark Brown wrote:
On Thu, Apr 05, 2018 at 10:56:57PM +0200, Dominik Brodowski wrote:
Christoph,
unfortunately, commit 6e4bf5867783 breaks sound on my Dell XPS13, see the
dmesg diff between fec777c385b6 and 6e4bf5867783:
Adding Vinod and Pierre from Intel in case they
On 4/9/18 5:46 AM, Jia-Ju Bai wrote:
broxton_audio_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".
Despite never getting called from atomic context,
broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for al
On 11/22/18 3:56 AM, Andy Shevchenko wrote:
On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote:
On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote:
Compare:
/* CFL */
{ PCI_DEVICE(0x8086, 0xa348),
.driver_data = (unsigned long)&snd_soc_acpi_in
ed choices in supported
platforms.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 73 ++
sound/soc/intel/boards/Kconfig | 16 +++-
sound/soc/intel/skylake/skl.c | 12 ++
3 files changed, 92 insertions(+), 9 deletions(-)
diff --g
bus->ppcap is now tested upfront, there is no need to re-check if the
DSP is present. Remove tests and remove indentation.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/skylake/skl.c | 40 ---
1 file changed, 18 insertions(+), 22 deletions(-)
d
Enable fallback for select PCI IDs
Signed-off-by: Pierre-Louis Bossart
---
sound/pci/hda/Kconfig | 40 +++
sound/pci/hda/hda_intel.c | 19 +--
sound/soc/intel/Kconfig | 6 ++
3 files changed, 59 insertions(+), 6 deletions(-)
diff
Check immediately if the DSP can be found, bail and avoid doing inits
to enable legacy fallback without delay.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/skylake/skl.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/sound/soc/intel
es.
Credits to Takashi for the initial code shared on the alsa-devel
mailing list. Testing with base-defconfig, sst-defconfig and
hdaudio-defconfigs provided at
https://github.com/thesofproject/kconfig
Signed-off-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
include/sound/hdaudio.h
individually and last provide a dynamic
fallback mechanism when two drivers are registered for the same PCI
ID.
When the SOF driver is released, the same mechanism will be used to
enable the SOF-legacy fallback. There will be no plans to enable an
SOF->SST falback.
Pierre-Louis Bossart (4):
A
From: Takashi Iwai
It's with CNP, supposed to be equivalent with CNL entry.
Signed-off-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/skylake/skl-messages.c | 8
sound/soc/intel/skylake/skl.c | 3 +++
2 files changed, 11 insertions(+)
diff --
On 11/21/18 8:29 AM, Andy Shevchenko wrote:
On Tue, Nov 20, 2018 at 03:36:40PM -0600, Pierre-Louis Bossart wrote:
Check immediately if the DSP can be found, bail and avoid doing inits
to enable legacy fallback without delay.
It does slightly more than described. Please do either remove
On 11/21/18 8:27 AM, Andy Shevchenko wrote:
On Tue, Nov 20, 2018 at 03:36:39PM -0600, Pierre-Louis Bossart wrote:
From: Takashi Iwai
It's with CNP, supposed to be equivalent with CNL entry.
May you consider to switch to PCI_DEVICE_DATA() first?
Is this really the recommended path?
On 11/21/18 4:32 AM, Takashi Iwai wrote:
On Tue, 20 Nov 2018 22:36:38 +0100,
Pierre-Louis Bossart wrote:
This patchset is provided as an RFC and should not be merged as is
(Turkey break in the USA and more validation needed). This is however
a good time to gather comments. This work is the
Th
On 11/19/18 7:26 AM, kbuild test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6
commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492 ASoC: hdac_hda: add asoc
extension for legacy HDA codec drivers
d
On 12/5/18 3:48 AM, Mark Brown wrote:
On Wed, Dec 05, 2018 at 04:34:23AM -0500, Sasha Levin wrote:
From: Pierre-Louis Bossart
[ Upstream commit 4c10473d6ddf12ec124c9ff71a5d23bb5388478b ]
On certain platforms, Display HDMI HDA codec was not going to sleep state
after the use when links are
On 12/7/18 3:05 AM, Zhuohao Lee wrote:
From the da7219 spec, the button A, B, C and D are remapped to
0, 1, 2 and 3 respectively where button A is KEY_PLAYPAUSE,
B is KEY_VOLUMEUP, C is KEY_VOLUMEDOWN and D is KEY_VOICECOMMAND
Ok, but could fix all da7219-based machine drivers then, the mapp
On 6/1/18 8:17 AM, Guenter Roeck wrote:
On 06/01/2018 03:25 AM, Mark Brown wrote:
On Thu, May 24, 2018 at 12:49:21PM -0700, Guenter Roeck wrote:
From: Guenter Roeck
Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE
DAI") introduced sound topology files version 5. Initially, thi
guess this is the v2
Acked-by: Pierre-Louis Bossart
As discussed in the v1 thread, we'll need to align other DA7219-based
devices to use the same mapping.
---
sound/soc/intel/boards/kbl_da7219_max98927.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/
On 12/21/18 12:02 PM, Randy Dunlap wrote:
On 12/21/18 12:32 AM, Stephen Rothwell wrote:
Hi all,
News: there will be no linux-next release until Jan 2. Have a good break.
Changes since 20181220:
on x86_64:
A new group of Kconfig "select"s is causing kconfig warnings:
WARNING: unmet direc
Remove warnings by selecting SND_HDA_INTEL_DSP_DETECTION_XYZ only when
SND_HDA_INTEL is part of the config.
Fixes: c337104b1a16 ('ALSA: HD-Audio: SKL+: abort probe if DSP is present and
Skylake driver selected')
Reported-by: Randy Dunlap
Signed-off-by: Pierre-Louis Bossart
---
sound
No reason why this is global, fix warnings with W=1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/dmic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c
index da921da50ef0..de041369e5a7 100644
--- a/sound/soc
Fix warnings with W=1
If these variables are useful this driver should be modified to expose
them.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/es8316.c | 4
1 file changed, 4 deletions(-)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index e97d12d578b0
Reported by Coccinelle:
sound/soc/codecs/max98373.c:411:2-20: WARNING: Assignment of bool to 0/1
sound/soc/codecs/max98373.c:922:2-27: WARNING: Assignment of bool to 0/1
sound/soc/codecs/max98373.c:924:2-27: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc
From: Bard liao
rt5645_if3_adc_in_mux, rt5645_inr_mux, and rt5645_inl_mux are not used.
Remove them from the driver.
Signed-off-by: Bard liao
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5645.c | 36
1 file changed, 36 deletions(-)
diff
Fix warnings with W=1
If these variables are useful then this driver should be modified to
expose them.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/max98090.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs
Reported by Coccinelle:
sound/soc/codecs/rt5651.c:750:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5651.c:754:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5651.c:2192:1-16: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs
Reported by Coccinelle:
sound/soc/codecs/cs4271.c:226:2-16: WARNING: Assignment of bool to 0/1
sound/soc/codecs/cs4271.c:229:2-16: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/cs4271.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
-Louis Bossart
---
sound/soc/codecs/rt286.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 0b0f748bffbe..c9457c247a03 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -296,10 +296,10 @@ static
Missing or spurious parameter descriptions. Fix warnings with W=1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/nau8825.c | 1 +
sound/soc/codecs/rt5514.c | 1 +
sound/soc/codecs/rt5677.c | 8
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs
:348:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:351:5-8: WARNING: Comparison to bool
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt298.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c
Reported by Coccinelle:
sound/soc/codecs/rt5640.c:980:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5640.c:984:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5640.c:2825:1-16: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs
From: Bard liao
Some mux/mixer are not used. Remove them from the driver.
Signed-off-by: Bard liao
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5670.c | 54 ---
1 file changed, 54 deletions(-)
diff --git a/sound/soc/codecs/rt5670.c b/sound
ned-off-by: Bard liao
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5645.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 52ce380c8f3a..9a0751978090 100644
--- a/sound/
Reported by Coccinelle:
mt6351.c:1418:5-8: Unneeded variable: "ret". Return "0" on line 1437
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/mt6351.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/codecs/mt6351.c b/sound/soc/c
From: Bard liao
The buf in rl6347a_hw_read is __be32.
Cc: Oder Chiou
Signed-off-by: Bard liao
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rl6347a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rl6347a.c b/sound/soc/codecs/rl6347a.c
-aad.c:157:37:got restricted __le16 [usertype]
Cc: Adam Thomson
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7219-aad.c | 2 +-
sound/soc/codecs/da7219.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc
Reported by Coccinelle:
sound/soc/codecs/tscs42xx.c:392:5-31: WARNING: Comparison to bool
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/tscs42xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c
index
-Louis Bossart
---
sound/soc/codecs/rt274.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index e2855ab9a2c6..9e88f7b25d38 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -381,10 +381,10
: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/max98927.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c
index 065303a46535..e53d2007f3be 100644
--- a/sound/soc/codecs/max98927.c
Reported by Sparse:
da7219.c:841:57: warning: dubious: x & !y
Cc: Adam Thomson
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7219.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index ce165047
Reported by Coccinelle:
nau8824.c:810:6-12: ERROR: Assignment of bool to non-0/1 constant
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/nau8824.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c
index
On 1/4/19 6:34 PM, Azat Khuzhin wrote:
This is unfortunately a known issue with this driver, Takashi and I had
a couple of email threads on this. Even without errors removing the
module doesn't seem to release all resources. I don't like this at all,
and for the Sound Open Firmware (SOF) driver
On 12/31/18 2:11 AM, Takashi Iwai wrote:
On Mon, 31 Dec 2018 00:17:58 +0100,
Pierre-Louis Bossart wrote:
BTW, one thing I'd really like to avoid is to rearrange the probe
procedure of the legacy HDA driver (so that we can get codec_mask
during pci probe() call). The async probe is the r
On 12/31/18 7:43 AM, Azat Khuzhin wrote:
+/* CFL and later models, preferring ASoC when DSP is available */
+#define IS_CFL_PLUS(pci)\
+ ((pci)->vendor == 0x8086 && \
+((pci)->device == 0xa348 || \
+ (pci)->device == 0x9dc8 || \
+ (pci)->device == 0x34
On 12/31/18 12:15 PM, Takashi Iwai wrote:
On Mon, 31 Dec 2018 11:24:41 +0100,
Pierre-Louis Bossart wrote:
On 12/31/18 2:11 AM, Takashi Iwai wrote:
On Mon, 31 Dec 2018 00:17:58 +0100,
Pierre-Louis Bossart wrote:
BTW, one thing I'd really like to avoid is to rearrange the probe
procedu
On 12/31/18 1:35 PM, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote:
On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 8:47 PM Mark Brown wrote:
I don't have the cover letter or anything for this series, what's going
on with dependenci
On 12/31/18 2:35 PM, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart
wrote:
On 12/31/18 1:35 PM, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote:
On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
On Mon, Dec 31, 2018 at 8:47 PM Mark
Please check out this tag next-20181224 and apply the patches afterwards.
Thanks, will do. I think this patchset will uncover additional
inconsistencies, e.g. for legacy Haswell/Broadwell/Baytrail the machine
drivers depend on X86_INTEL_LPSS, which depends in turn on PCI, but the
platform dr
I have three opens with this ACPI/PCI change
1. the baseline change fails on my cross-compilation checks, see below
the result of the attached script (simplification of the one I use to
avoid 0day reports).
2. there are different patterns to express the dependency on PCI e.g.
config MMC_SDH
otherwise.
it doesn't but that's not a good enough reason to lay on the tracks.
I'll follow-up with a cleanup for the Intel audio parts when this series
is merged. The PCI dependency could be moved to the top-level since it's
pretty much required for all platforms except for compilation tests, and
there are multiple dependencies that repeated for no good reason, so FWIW
Acked-by: Pierre-Louis Bossart
On 1/2/19 4:58 PM, Sinan Kaya wrote:
On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
wrote:
This is pointing to a kconfig issue on ia64 arch.
arch/ia64/Kconfig:128:error: recursive dependency detected!
arch/ia64/Kconfig:128:choice contains symbol IA64_HP_SIM
arch/ia64/Kconfig
arch/ia64/Kconfig:126:error: recursive dependency detected!
arch/ia64/Kconfig:126:choice contains symbol IA64_HP_SIM
arch/ia64/Kconfig:200:symbol IA64_HP_SIM is part of choice PM
kernel/power/Kconfig:144:symbol PM is selected by PM_SLEEP
kernel/power/Kconfig:104:symbol PM_SLEEP
[ Adding linux-usb ML to Cc, as it's a core USB issue ]
So the device seems incorrectly advertising as if it were supporting
UAC3 -- assuming the device is still not UAC3-capable.
IOW, it's a buggy firmware. We need some blacklisting, or revert the
commit for now, unless any real UAC3 device
On 1/4/19 10:52 AM, Gopal, Saranya wrote:
[ Adding linux-usb ML to Cc, as it's a core USB issue ]
So the device seems incorrectly advertising as if it were supporting
UAC3 -- assuming the device is still not UAC3-capable.
IOW, it's a buggy firmware. We need some blacklisting, or revert the
c
On 12/23/18 5:25 PM, Sinan Kaya wrote:
Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.
Can you please share the .config that exposes this problem? This hasn't
changed in a long time and I wonder why this pops up now.
On 12/25/18 8:29 PM, Kangjie Lu wrote:
snd_pcm_lib_malloc_pages() may fail, so let's check its status and
return its error code upstream.
Acked-by: Pierre-Louis Bossart
Signed-off-by: Kangjie Lu
---
sound/soc/intel/atom/sst-mfld-platform-pcm.c | 8 +++-
1 file chang
On 12/30/18 6:19 PM, Linus Torvalds wrote:
On Sun, Dec 30, 2018 at 3:18 PM Pierre-Louis Bossart
wrote:
The KabyLake Dell XPS13 was initially used for the ASoC driver for
HDaudio, so there is no known hardware-related reason why this problem
happens.
Mine isn't the Kabylake one, it&
On 10/29/18 2:08 PM, Dean Wallace wrote:
On 29-10-18, Andy Shevchenko wrote:
On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko
wrote:
Cc: Pierre as well.
On Mon, Oct 29, 2018 at 7:48 PM Stephen Boyd wrote:
Quoting Dean Wallace (2018-10-25 16:25:17)
I have found a regression in 4.18.15 that
e
problem of trying to manage from the kernel what the firmware already
manages.
Regards,
Hans
On 29-10-18 23:03, Pierre-Louis Bossart wrote:
On 10/29/18 2:08 PM, Dean Wallace wrote:
On 29-10-18, Andy Shevchenko wrote:
On Mon, Oct 29, 2018 at 7:52 PM Andy Shevchenko
wrote:
Cc: Pierre as
On 10/30/18 10:03 AM, Andy Shevchenko wrote:
On Tue, Oct 30, 2018 at 4:48 PM Hans de Goede wrote:
On 30-10-18 15:38, Dean Wallace wrote:
Excellent work Hans. Compiled 4.19 with
0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch, sound
works as before.
for i in /sys/kernel/debu
On 10/30/18 10:46 AM, Hans de Goede wrote:
Hi,
On 30-10-18 16:04, Pierre-Louis Bossart wrote:
On 10/30/18 9:38 AM, Dean Wallace wrote:
On 30-10-18, Hans de Goede wrote:
Hi Dean,
Attached are 2 different attempts at fixing this.
When trying these patches do not forget to remove the
On 10/30/18 11:02 AM, Hans de Goede wrote:
Hi,
On 30-10-18 16:46, Hans de Goede wrote:
Hi,
On 30-10-18 16:04, Pierre-Louis Bossart wrote:
On 10/30/18 9:38 AM, Dean Wallace wrote:
On 30-10-18, Hans de Goede wrote:
Hi Dean,
Attached are 2 different attempts at fixing this.
When trying
1 - 100 of 1237 matches
Mail list logo
