On 19/06/2017 22:13, Florian Fainelli wrote:
> On 06/14/2017 09:29 AM, Phil Elwell wrote:
>> Devices in the BCM2835 AUX block share a common interrupt line, with a
>> register indicating which devices have active IRQs. Expose this as a
>> nested interrupt controller to avoid
Hi,
I've run into a problem using the fixed-factor clock on Raspberry Pi and I'd
like some advice before I submit a patch.
Some context: the aim is to use a standard UART and some external circuitry
as a MIDI interface. This would be straightforward except that Linux doesn't
recognise the require
cy. In practice,
the combined effect of the two patches is to choose OSC as a source if
an integer divisor can be used, otherwise PLLD_PER is chosen.
Phil Elwell (2):
clk: bcm2835: Limit PCM clock to OSC and PLLD_PER
clk: bcm2835: Minimise clock jitter for PCM clock
drivers/clk/bcm/clk
-off-by: Phil Elwell
---
drivers/clk/bcm/clk-bcm2835.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 0258538..facc346 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -1511,6
jitter. The metric is the ideal rate minus the
worse deviation from that ideal using the nearest integer divisors.
Use this metric for parent selection for clocks requiring low jitter
(currently just PCM).
Signed-off-by: Phil Elwell
---
drivers/clk/bcm/clk-bcm2835.c | 39
Hi Eric,
On 06/03/2018 19:02, Eric Anholt wrote:
Stefan Wahren writes:
Hi Eric,
Am 05.03.2018 um 21:28 schrieb Eric Anholt:
This was just a way for the DT-passed value to get out of sync with
what Linux has configured the ARM for.
Signed-off-by: Eric Anholt
---
.../interface/vchiq_arm
On 07/03/2018 12:10, Stefan Wahren wrote:
> Hi Phil,
>> It is the L2 cache line size that matters, but as long as you end up with
>> the numbers Stefan mentioned - 32 on BCM2835, 64 on BCM2836 and BCM2837 -
>> I'm not too bothered how you get there.
>
> i think a kernel with bcm2835_defconfig
lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
content, but the value gets overwritten before it is returned and the
read goes ahead anyway. Make the read conditional as it should be
and preserve the error code.
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan78xx.c | 3
events directly, relying on
the subsequent deferral of the EVENT_LINK_RESET call to schedule the
work. Take the same precaution with EVENT_STAT_UPDATE to avoid a
totally unnecessary error message.
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan78xx.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi Andrew.
On 11/04/2018 13:57, Andrew Lunn wrote:
> On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote:
>> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
>> content, but the value gets overwritten before it is returned and the
>> read goes a
a bindings file, adding it to
MAINTAINERS at the same time.
Signed-off-by: Phil Elwell
---
.../devicetree/bindings/net/microchip,lan78xx.txt | 44 ++
MAINTAINERS| 1 +
2 files changed, 45 insertions(+)
create mode 100644
nk100/1000/activity 5=link10/1000/activity
6=link10/100/activity14=off15=on
Also use the presence of the DT property to indicate that the
LEDs should be enabled - necessary in the event that no valid OTP
or EEPROM is available.
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan7
Add two new Device Tree properties:
* microchip,eee-enabled - a boolean to enable EEE
* microchip,tx-lpi-timer - time in microseconds to wait after TX goes
idle before entering the low power state
(default 600)
Signed-off-by: Phil Elwell
reading the MAC address, EEE setting
and LED modes from Device Tree.
Phil Elwell (4):
lan78xx: Read MAC address from DT if present
lan78xx: Read initial EEE setting from Device Tree
lan78xx: Read LED modes from Device Tree
dt-bindings: Document the DT bindings for lan78xx
.../devicetree
There is a standard mechanism for locating and using a MAC address from
the Device Tree. Use this facility in the lan78xx driver to support
applications without programmed EEPROM or OTP. At the same time,
regularise the handling of the different address sources.
Signed-off-by: Phil Elwell
Hi Andrew,
On 12/04/2018 15:04, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote:
>> The Microchip LAN78XX family of devices are Ethernet controllers with
>> a USB interface. Despite being discoverable devices it can be useful to
>> be able t
Hi Andrew,
On 12/04/2018 15:06, Andrew Lunn wrote:
> Hi Phil
>
>> -ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
>> -ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
>> +mac_addr = of_get_mac_address(dev->udev->dev.of_node);
>
> It might be
Hi Andrew,
On 12/04/2018 15:26, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:35PM +0100, Phil Elwell wrote:
>> Add support for DT property "microchip,led-modes", a vector of two
>> cells (u32s) in the range 0-15, each of which sets the mode for one
>> of the
Hi Andrew,
On 12/04/2018 15:30, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote:
>> The Microchip LAN78XX family of devices are Ethernet controllers with
>> a USB interface. Despite being discoverable devices it can be useful to
>> be able t
Andrew,
On 12/04/2018 15:16, Andrew Lunn wrote:
> On Thu, Apr 12, 2018 at 02:55:34PM +0100, Phil Elwell wrote:
>> Add two new Device Tree properties:
>> * microchip,eee-enabled - a boolean to enable EEE
>> * microchip,tx-lpi-timer - time in microseconds
On 08/04/2018 12:28, Stefan Wahren wrote:
> Hi Geert,
>
> [add Phil]
>
>> Geert Uytterhoeven hat am 8. April 2018 um 11:05
>> geschrieben:
>>
>>
>> If CONFIG_RASPBERRYPI_FIRMWARE=n:
>>
>> drivers/gpio/gpio-raspberrypi-exp.c: In function
>> ‘rpi_exp_gpio_get_polarity’:
>> drivers/gpio/g
h the link is up), rendering the interface unusable.
Fix this issue by removing the lan78xx_reset call from lan78xx_open.
Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan78xx.c | 4
1 file changed, 4 deletions(-)
diff --g
Hi Nisar,
On 10/04/2018 15:16, nisar.sa...@microchip.com wrote:
> Thanks Phil, for identifying the issues.
>
>> -ret = lan78xx_reset(dev);
>> -if (ret < 0)
>> -goto done;
>> -
>> phy_start(net->phydev);
>>
>> netif_dbg(dev, ifup, dev->net, "phy initialised successful
The SPI configuration state includes an SPI_NO_CS flag that disables
all CS line manipulation, for applications that want to manage their
own chip selects. However, this flag is ignored by the GPIO CS code
in the SPI framework.
Correct this omission with a trivial patch.
Signed-off-by: Phil
Hi Greg,
On 18/09/2018 14:02, Greg Kroah-Hartman wrote:
> On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote:
>> The SC16IS752 is a dual-channel device. The two channels are largely
>> independent, but the IRQ signals are wired together as an open-drain,
>> active
Hi Nicolas,
On Tue, 9 Feb 2021 at 13:00, Nicolas Saenz Julienne
wrote:
>
> In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present
> with the ISP and H264 bits, and V3D is in the same place in the new ASB
> as the old one.
>
> Use the fact that 'pm->argon_asb' is populated as a h
Nicolas,
On Tue, 9 Feb 2021 at 14:00, Nicolas Saenz Julienne
wrote:
>
> On Tue, 2021-02-09 at 13:19 +, Phil Elwell wrote:
> > Hi Nicolas,
> >
> > On Tue, 9 Feb 2021 at 13:00, Nicolas Saenz Julienne
> > wrote:
> > >
> > > In BCM2711 the n
-clock";
clocks = <&clk_core>;
#clock-cells = <0>;
clock-div = <1>;
clock-mult = <2>;
};
};
Phil
On 10/09/2015 16:57, Martin Sperl wrote:
>> On 10.09.2015, at 17:48, Noralf Trønnes wrote:
>>
&g
ing to the crash. Instead, store its private data as the
drvdata and retrieve the thermal_zone_device pointer from it.
Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
Signed-off-by: Phil Elwell
---
drivers/thermal/broadcom/bcm2835_thermal.c | 9
ing to the crash. Instead, store its private data as the
drvdata and retrieve the thermal_zone_device pointer from it.
Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
Signed-off-by: Phil Elwell
---
drivers/thermal/broadcom/bcm2835_thermal.c | 9
Hi Daniel,
On 29/01/2019 09:52, Daniel Lezcano wrote:
> On 29/01/2019 10:10, Phil Elwell wrote:
>> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
>> dereference in bcm2835_thermal_debugfs. The driver makes use of the
>> implementation deta
Hi Stefan,
On 29/01/2019 09:44, Stefan Wahren wrote:
> Hi Phil,
>
> Am 29.01.2019 um 10:10 schrieb Phil Elwell:
>> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
>> dereference in bcm2835_thermal_debugfs. The driver makes use of the
>>
Hi Dave,
Thanks for the reply.
On 12/07/2019 12:21, Dave Martin wrote:
> On Thu, Jul 11, 2019 at 02:45:32PM +0100, Phil Elwell wrote:
>> pl011_tx_chars takes a "from_irq" parameter to reduce the number of
>> register accesses. When from_irq is true the function assumes
Hi Rogier,
On 12/07/2019 13:10, Rogier Wolff wrote:
> On Fri, Jul 12, 2019 at 12:21:05PM +0100, Dave Martin wrote:
>> diff --git a/drivers/tty/serial/amba-pl011.c
>> b/drivers/tty/serial/amba-pl011.c
>> index 89ade21..1902071 100644
>> --- a/drivers/tty/serial/amba-pl011.c
>> +++ b/drivers/tty/se
pl011_tx_chars, causing polling to be used in the unsafe case.
Fixes: 1e84d22322ce ("serial/amba-pl011: Refactor and simplify TX FIFO
handling")
Signed-off-by: Phil Elwell
---
drivers/tty/serial/amba-pl011.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/driver
and since the armed flag was being
cleared this lead to a deadlock.
Fixes: 852b2876a8a8 ("staging: vchiq: rework remove_event handling")
Signed-off-by: Phil Elwell
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 +
1 file changed, 1 insertion(+)
diff --g
between the interrupt handler and access to the
Enhanced Features Register.
Phil Elwell (2):
sc16is7xx: Fix for multi-channel stall
sc16is7xx: Fix for "Unexpected interrupt: 8"
drivers/tty/serial/sc16is7xx.c | 50 +-
1 file changed, 44 insert
em (or at least make it much less likely to happen)
by reducing the granularity of per-channel interrupt processing
to one condition per iteration, only exiting the overall loop when
both channels are no longer interrupting.
Signed-off-by: Phil Elwell
---
drivers/tty/serial/s
eaded interrupt handler).
See: https://github.com/raspberrypi/linux/issues/2529
Signed-off-by: Phil Elwell
---
drivers/tty/serial/sc16is7xx.c | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 47b4115.
reading the MAC address and LED modes from
Device Tree.
v3:
- Move LED setting into PHY driver.
v2:
- Use eth_platform_get_mac_address.
- Support up to 4 LEDs, and move LED mode constants into dt-bindings header.
- Improve bindings document.
- Remove EEE support.
Phil Elwell (3):
lan78xx: Read MAC
a bindings file.
Signed-off-by: Phil Elwell
---
.../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++
MAINTAINERS| 1 +
2 files changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/microchip
available.
Signed-off-by: Phil Elwell
---
MAINTAINERS | 1 +
drivers/net/phy/microchip.c | 25 ++
drivers/net/usb/lan78xx.c | 32 -
include/dt-bindings/net/microchip-lan7
reading the MAC address and LED modes from
Device Tree.
v3:
- Move LED setting into PHY driver.
v2:
- Use eth_platform_get_mac_address.
- Support up to 4 LEDs, and move LED mode constants into dt-bindings header.
- Improve bindings document.
- Remove EEE support.
Phil Elwell (3):
lan78xx: Read MAC
There is a standard mechanism for locating and using a MAC address from
the Device Tree. Use this facility in the lan78xx driver to support
applications without programmed EEPROM or OTP. At the same time,
regularise the handling of the different address sources.
Signed-off-by: Phil Elwell
There is a standard mechanism for locating and using a MAC address from
the Device Tree. Use this facility in the lan78xx driver to support
applications without programmed EEPROM or OTP. At the same time,
regularise the handling of the different address sources.
Signed-off-by: Phil Elwell
a bindings file.
Signed-off-by: Phil Elwell
---
.../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++
MAINTAINERS| 1 +
2 files changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/microchip
EEE support.
Phil Elwell (3):
lan78xx: Read MAC address from DT if present
lan78xx: Read LED states from Device Tree
dt-bindings: Document the DT bindings for lan78xx
.../devicetree/bindings/net/microchip,lan78xx.txt | 54
MAINTAINERS
available.
Signed-off-by: Phil Elwell
---
MAINTAINERS | 1 +
drivers/net/phy/microchip.c | 25 ++
drivers/net/usb/lan78xx.c | 32 -
include/dt-bindings/net/microchip-lan7
There is a standard mechanism for locating and using a MAC address from
the Device Tree. Use this facility in the lan78xx driver to support
applications without programmed EEPROM or OTP. At the same time,
regularise the handling of the different address sources.
Signed-off-by: Phil Elwell
a bindings file.
Signed-off-by: Phil Elwell
Reviewed-by: Andrew Lunn
---
.../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++
MAINTAINERS| 1 +
2 files changed, 55 insertions(+)
create mode 100644 Documentation/devicetree
.
Phil Elwell (3):
lan78xx: Read MAC address from DT if present
lan78xx: Read LED states from Device Tree
dt-bindings: Document the DT bindings for lan78xx
.../devicetree/bindings/net/microchip,lan78xx.txt | 54
MAINTAINERS| 2
available.
Signed-off-by: Phil Elwell
Reviewed-by: Andrew Lunn
---
MAINTAINERS | 1 +
drivers/net/phy/microchip.c | 25 ++
drivers/net/usb/lan78xx.c | 32 -
include/dt-bindings/net
On 16/04/2018 20:22, Rob Herring wrote:
> On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote:
>> The Microchip LAN78XX family of devices are Ethernet controllers with
>> a USB interface. Despite being discoverable devices it can be useful to
>> be able to configure
reading the MAC address and LED modes from
Device Tree.
v2:
- Use eth_platform_get_mac_address.
- Support up to 4 LEDs, and move LED mode constants into dt-bindings header.
- Improve bindings document.
- Remove EEE support.
Phil Elwell (3):
lan78xx: Read MAC address from DT if present
lan78xx
a bindings file.
Signed-off-by: Phil Elwell
---
.../devicetree/bindings/net/microchip,lan78xx.txt | 44 ++
MAINTAINERS| 1 +
2 files changed, 45 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/microchip
There is a standard mechanism for locating and using a MAC address from
the Device Tree. Use this facility in the lan78xx driver to support
applications without programmed EEPROM or OTP. At the same time,
regularise the handling of the different address sources.
Signed-off-by: Phil Elwell
available.
Signed-off-by: Phil Elwell
---
MAINTAINERS | 1 +
drivers/net/usb/lan78xx.c| 35
include/dt-bindings/net/microchip-78xx.h | 21 +++
3 files changed, 57 insertions(+)
create mode 100644
On 01/03/2016 01:30, Eric Anholt wrote:
> From: Phil Elwell
>
> The DT bindings for pinctrl-bcm2835 allow both the function and pull
> to contain either one entry or one per pin. However, an error in the
> DT parsing can cause failures if the number of pulls differs from the
> n
Hi,
In the downstream Raspberry Pi kernel we are using configfs to apply overlays at
runtime, using a patchset from Pantelis that hasn't been accepted upstream yet.
Apart from the occasional need to adapt to upstream changes, this has been
working
well for us.
A Raspberry Pi user recently notice
Hi Frank,
On 04/06/2019 19:20, Frank Rowand wrote:
Hi Phil,
On 6/4/19 5:15 AM, Phil Elwell wrote:
Hi,
In the downstream Raspberry Pi kernel we are using configfs to apply overlays at
runtime, using a patchset from Pantelis that hasn't been accepted upstream yet.
Apart from the occas
On 05/12/2017 13:23, Matthias Reichl wrote:
> On Tue, Dec 05, 2017 at 01:14:17PM +, Russell King - ARM Linux wrote:
>> On Tue, Dec 05, 2017 at 12:47:09PM +0100, Matthias Reichl wrote:
>>> On Wed, Aug 23, 2017 at 03:03:51PM -0400, Steven Rostedt wrote:
On Wed, 23 Aug 2017 11:48:13 -0700
>>>
On 10/08/2017 11:21, Dan Carpenter wrote:
> The original patch did not go through the normal review process...
>
> On Tue, Aug 08, 2017 at 01:05:02PM +0100, Phil Elwell wrote:
>> I'm all for fixing memory leaks, but freeing a block while it is still
>> being used is
On 10/08/2017 12:24, Dan Carpenter wrote:
> On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote:
>> On 10/08/2017 11:21, Dan Carpenter wrote:
>>> The original patch did not go through the normal review process...
>>>
>>> On Tue, Aug 08, 2017 at
connections.
Simplifying the code by removing a bunch of gotos and returning errors
directly.
Signed-off-by: Phil Elwell
Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in
bcm2835_audio_open_connection()")
---
v2: Simplified following feedback from Dan Carpenter.
---
.../vc0
connections.
Simplifying the code by removing a bunch of gotos and returning errors
directly.
Signed-off-by: Phil Elwell
Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in
bcm2835_audio_open_connection()")
---
[Resend with v2 in subject]
v2: Simplified following feedback from Dan
, causing the waiting cores to execute random code.
Use the /memreserve/ Device Tree directive to mark the first page as
off-limits to the kernel.
See: https://github.com/raspberrypi/linux/issues/1989
Signed-off-by: Phil Elwell
---
arch/arm/boot/dts/bcm2710-rpi-3-b.dts | 4
arch/arm/boot/dts
applied then the other cores will sleep forever.
See: https://github.com/raspberrypi/linux/issues/1989
Signed-off-by: Phil Elwell
---
drivers/irqchip/irq-bcm2836.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c
index e10597c
, causing the waiting cores to execute random code.
Use the /memreserve/ Device Tree directive to mark the first page as
off-limits to the kernel.
See: https://github.com/raspberrypi/linux/issues/1989
Signed-off-by: Phil Elwell
---
Changes in V2:
- Rebase against linux-next
- Drop downstream-only
On 09/05/2017 19:14, Marc Zyngier wrote:
On 09/05/17 19:08, Eric Anholt wrote:
Marc Zyngier writes:
On 09/05/17 17:59, Eric Anholt wrote:
Phil Elwell writes:
In order to reduce power consumption and bus traffic, it is sensible
for secondary cores to enter a low-power idle state when
On 09/05/2017 19:53, Marc Zyngier wrote:
On 09/05/17 19:52, Phil Elwell wrote:
On 09/05/2017 19:14, Marc Zyngier wrote:
On 09/05/17 19:08, Eric Anholt wrote:
Marc Zyngier writes:
On 09/05/17 17:59, Eric Anholt wrote:
Phil Elwell writes:
In order to reduce power consumption and bus
On 10/05/2017 08:42, Marc Zyngier wrote:
> On 09/05/17 20:02, Phil Elwell wrote:
>> On 09/05/2017 19:53, Marc Zyngier wrote:
>>> On 09/05/17 19:52, Phil Elwell wrote:
>>>> On 09/05/2017 19:14, Marc Zyngier wrote:
>>>>> On 09/05/17 19:08, E
On 04/05/2017 18:51, Stefan Wahren wrote:
>
>> Phil Elwell hat am 4. Mai 2017 um 11:58 geschrieben:
>>
>>
>> vchiq_arm supports transfers less than one page and at arbitrary
>> alignment, using the dma-mapping API to perform its cache maintenance
>> (even
On 10/05/2017 09:55, Marc Zyngier wrote:
> On Wed, May 10 2017 at 9:27:10 am BST, Phil Elwell
> wrote:
>> On 10/05/2017 08:42, Marc Zyngier wrote:
>>> On 09/05/17 20:02, Phil Elwell wrote:
>>>> On 09/05/2017 19:53, Marc Zyngier wrote:
>>>>> On 09
On 10/05/2017 10:06, Greg Kroah-Hartman wrote:
> On Wed, May 10, 2017 at 09:42:43AM +0100, Phil Elwell wrote:
>> On 04/05/2017 18:51, Stefan Wahren wrote:
>>>
>>>> Phil Elwell hat am 4. Mai 2017 um 11:58 geschrieben:
>>>>
>>>>
>>>>
On 10/05/2017 11:09, Marc Zyngier wrote:
> On 10/05/17 10:05, Phil Elwell wrote:
>> On 10/05/2017 09:55, Marc Zyngier wrote:
>>> On Wed, May 10 2017 at 9:27:10 am BST, Phil Elwell
>>> wrote:
>>>> On 10/05/2017 08:42, Marc Zyngier wrote:
>>>>&
or the 2836")
>
> M.
>
The patch has some checkpatch warnings, but otherwise:
Reviewed-by: Phil Elwell
Tested-by: Phil Elwell
Thanks,
Phil
On 10/05/2017 16:31, Marc Zyngier wrote:
> On 10/05/17 16:07, Phil Elwell wrote:
>> On 10/05/2017 14:32, Marc Zyngier wrote:
>>> On 10/05/17 14:26, Marc Zyngier wrote:
>>>> One of the RPi-2/3 irqchip's key features is that it contains some
>>>>
Hi Stefan,
On 30/05/2017 19:41, Stefan Wahren wrote:
> Hi Phil,
>
>> Phil Elwell hat am 30. Mai 2017 um 18:28 geschrieben:
>>
>>
>> Restrict clock sources for the PCM peripheral to the oscillator and
>> PLLD_PER because other source may have varying rates or
Hi Stefan,
On 30/05/2017 20:04, Stefan Wahren wrote:
> Hi Phil,
>
>> Phil Elwell hat am 30. Mai 2017 um 18:28 geschrieben:
>>
>>
>> Fractional clock dividers generate accurate average frequencies but
>> with jitter, particularly when the integer divisor is sm
jitter. The metric is the ideal rate minus the
worse deviation from that ideal using the nearest integer divisors.
Use this metric for parent selection for clocks requiring low jitter
(currently just PCM).
Signed-off-by: Phil Elwell
---
drivers/clk/bcm/clk-bcm2835.c | 40
-off-by: Phil Elwell
---
drivers/clk/bcm/clk-bcm2835.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 0258538..81ecd4c 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk
LK analagous to REGISTER_PER_CLK in patch 1.
* Renamed temporary variable idiv to int_div in patch 2.
Phil Elwell (2):
clk: bcm2835: Limit PCM clock to OSC and PLLD_PER
clk: bcm2835: Minimise clock jitter for PCM clock
drivers/clk/bcm/clk-bcm2835.c | 50 ++-
1 f
On 31/05/2017 16:58, Stefan Wahren wrote:
> Am 31.05.2017 um 17:27 schrieb Stephen Warren:
>> On 05/30/2017 06:23 AM, Phil Elwell wrote:
>>> Hi,
>>>
>>> I've run into a problem using the fixed-factor clock on Raspberry Pi
>>> and I'd
>
On 01/06/2017 07:39, Stephen Boyd wrote:
> On 05/31, Phil Elwell wrote:
>> On 31/05/2017 16:58, Stefan Wahren wrote:
>>> Am 31.05.2017 um 17:27 schrieb Stephen Warren:
>>>> On 05/30/2017 06:23 AM, Phil Elwell wrote:
>>>>> Hi,
>>>>>
&
On 31/05/2017 22:36, Eric Anholt wrote:
> Phil Elwell writes:
>
>> Fractional clock dividers generate accurate average frequencies but
>> with jitter, particularly when the integer divisor is small.
>>
>> Introduce a new metric of clock accuracy to penalise clo
On 31/05/2017 22:24, Eric Anholt wrote:
> Phil Elwell writes:
>
>> Restrict clock sources for the PCM peripheral to the oscillator and
>> PLLD_PER because other source may have varying rates or be switched off.
>> Prevent other sources from being selected by replacing th
and gave
it a comment in patch 1.
* Added a REGISTER_PCM_CLK analagous to REGISTER_PER_CLK in patch 1.
* Renamed temporary variable idiv to int_div in patch 2.
Phil Elwell (2):
clk: bcm2835: Limit PCM clock to OSC and PLLD_PER
clk: bcm2835: Minimise clock jitter for PCM clock
drivers/clk/bcm/clk
-off-by: Phil Elwell
Reviewed-by: Eric Anholt
---
drivers/clk/bcm/clk-bcm2835.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 0258538..81ecd4c 100644
--- a/drivers/clk/bcm/clk
jitter. The metric is the ideal rate minus the
worse deviation from that ideal using the nearest integer divisors.
Use this metric for parent selection for clocks requiring low jitter
(currently just PCM).
Signed-off-by: Phil Elwell
Reviewed-by: Eric Anholt
---
drivers/clk/bcm/clk-bcm2835.c | 34
jitter. The metric is the ideal rate minus the
worse deviation from that ideal using the nearest integer divisors.
Use this metric for parent selection for clocks requiring low jitter
(currently just PCM).
Signed-off-by: Phil Elwell
Reviewed-by: Eric Anholt
Acked-by: Stefan Wahren
---
drivers
Changes in v2:
* Extended bcm2835_pcm_per_parents to cover the pllh_aux slot, and gave
it a comment in patch 1.
* Added a REGISTER_PCM_CLK analagous to REGISTER_PER_CLK in patch 1.
* Renamed temporary variable idiv to int_div in patch 2.
* Fix comment formatting in patch 2.
Phil Elwell (2):
clk: bcm
-off-by: Phil Elwell
Reviewed-by: Eric Anholt
Acked-by: Stefan Wahren
---
drivers/clk/bcm/clk-bcm2835.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 0258538..49867d2 100644
--- a
re is no real negative impact as the spi-framework
does no longer rely on driver-provided DMA mappings but
maps the transfers transparently.
Signed-off-by: Martin Sperl
Submitted-by: Phil Elwell
---
drivers/mmc/host/mmc_spi.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/driver
On 23/05/2017 08:58, Ulf Hansson wrote:
> On 22 May 2017 at 11:09, Phil Elwell wrote:
>> since:
>> commit 0589342c27944e50ebd7a54f5215002b6598b748
>> Author: Rob Herring
>> Date: Tue Oct 29 23:36:46 2013 -0500
>>
>>
On 05/06/2017 21:13, Stephen Boyd wrote:
> On 06/05, Phil Elwell wrote:
>> That sounds great, but it doesn't match my experience. Let me restate my
>> observations with a bit more detail.
>>
>> In this scenario there three devices in a dependency chain:
>>
>
arguably be forked off as a separate
irqchip driver, but the clock driver has already claimed the AUX_IRQ
register so some driver and DT surgery would still be required.
Eric Anholt thought that including it here is reasonable, but I'm
prepared to split it out if this is considered too hacky.
Phil E
Devices in the AUX block share a common interrupt line, with a register
indicating which devices have active IRQs. Expose this as a nested
interrupt controller to avoid IRQ sharing problems (easily observed if
UART1 and SPI1/2 are enabled simultaneously).
Signed-off-by: Phil Elwell
---
drivers
Now that the AUX block has a dedicated interrupt controller, declare it
in the Device Tree and update the bcm283x uart1 and spi1/spi2 nodes to
use it.
Signed-off-by: Phil Elwell
---
arch/arm/boot/dts/bcm283x.dtsi | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a
On 07/06/2017 13:07, Alexander Stein wrote:
> On Wednesday 07 June 2017 12:11:45, Phil Elwell wrote:
>> Devices in the AUX block share a common interrupt line, with a register
>> indicating which devices have active IRQs. Expose this as a nested
>> interrupt controller
AUX clock driver for a time when its DT node may only be
a single word register, but until then ioremap its region without
reserving it to permit sharing.
Phil Elwell (4):
clk: bcm2835: More flexible IO register remapping
dt: bindings: Add bindings for bcm2835-aux-intc
irqchip: Add
1 - 100 of 119 matches
Mail list logo
