Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-15 Thread Peter Rosin
On 2018-05-15 12:22, Daniel Vetter wrote: > On Mon, May 14, 2018 at 10:40 PM, Peter Rosin wrote: >> On 2018-05-14 18:28, Daniel Vetter wrote: >>> On Fri, May 11, 2018 at 09:37:47AM +0200, Peter Rosin wrote: >>>> On 2018-05-10 10:10, Andrzej Hajda wrote: >>

[PATCH v2 1/2] i2c: algos: make use of i2c_8bit_addr_from_msg

2018-05-16 Thread Peter Rosin
Because it looks neater. Signed-off-by: Peter Rosin --- drivers/i2c/algos/i2c-algo-bit.c | 4 +--- drivers/i2c/algos/i2c-algo-pca.c | 5 + drivers/i2c/algos/i2c-algo-pcf.c | 8 ++-- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-bit.c b

[PATCH v2 0/2] i2c: make use of i2c_8bit_addr_from_msg

2018-05-16 Thread Peter Rosin
patches 1-3 (algos) and patches 4-21 (busses) making the series consist of just two patches instead of 21. - Added ack-bys and reviewed-bys from Guenter, Uwe and LinusW. - Eliminated the flags variable in algos/i2c-algo-pcf.c Cheers, Peter Peter Rosin (2): i2c: algos: make use of

[PATCH v2 2/2] i2c: busses: make use of i2c_8bit_addr_from_msg

2018-05-16 Thread Peter Rosin
an] Acked-by: Uwe Kleine-König [emf32 and imx] Acked-by: Linus Walleij [stu300] Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-aspeed.c | 3 +-- drivers/i2c/busses/i2c-axxia.c | 5 +++-- drivers/i2c/busses/i2c-diolan-u2c.c | 11 --- drivers/i2c/busses/i2c-efm32

[PATCH v3 05/26] drm/bridge: cdns-dsi: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..e9be5c3f0284 100644 --- a/drivers

[PATCH v3 03/26] drm/bridge/analogix: core: specify the owner .odev of the bridge

2018-05-16 Thread Peter Rosin
This will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 2bcbfadb6ac5

[PATCH v3 00/26] device link, bridge supplier <-> drm device

2018-05-16 Thread Peter Rosin
/lists/dri-devel/msg174275.html Peter Rosin (26): drm/bridge: allow optionally specifying an owner .odev device drm/bridge: adv7511: provide an owner .odev device drm/bridge/analogix: core: specify the owner .odev of the bridge drm/bridge: analogix-anx78xx: provide an owner .odev device

[PATCH v3 09/26] drm/bridge: nxp-ptn3460: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index d64a3283822a..fa832f32b518 100644 --- a

[PATCH v3 14/26] drm/bridge: sii8620: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index 7ab36042a822..8e35578b0488 100644 --- a

[PATCH v3 07/26] drm/bridge: lvds-encoder: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/lvds-encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index 75b0d3f6e4de..a80eec17b13b 100644

[PATCH v3 12/26] drm/bridge: sii902x: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sii902x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 60373d7eb220..894525b05985 100644 --- a/drivers/gpu

[PATCH v3 18/26] drm/bridge: ti-tfp410: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index acb857030951..4745838fdf0e 100644 --- a/drivers

[PATCH v3 20/26] drm/mediatek: hdmi: provide an owner .odev device for the bridge

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 59a11026dceb..d8c7d93d0a87 100644 --- a

[PATCH v3 23/26] drm/sti: provide an owner .odev device for the bridges

2018-05-16 Thread Peter Rosin
The .of_node member is going away and providing an .odev will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/sti/sti_dvo.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 1 + drivers/gpu/drm/sti/sti_hdmi.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 24/26] drm/bridge: remove the .of_node member

2018-05-16 Thread Peter Rosin
It is unused. Acked-by: Daniel Vetter Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 3 +-- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 -- include/drm/drm_bridge.h | 4 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu

[PATCH v3 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-16 Thread Peter Rosin
-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 18 ++ include/drm/drm_bridge.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 78d186b6831b..0259f0a3ff27 100644 --- a/drivers/gpu/drm/drm_bridge.c

[PATCH v3 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach

2018-05-16 Thread Peter Rosin
The .odev owner device will be handy to have around. Reviewed-by: Andrzej Hajda Acked-by: Daniel Vetter Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index

[PATCH v3 19/26] drm/exynos: mic: provide an owner .odev device for the bridge

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 2174814273e2..f9ff8d3ec937

[PATCH v3 22/26] drm/rcar-du: lvds: provide an owner .odev device for the bridge

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 3d2d3bbd1342..efda02f55c95 100644 --- a

[PATCH v3 16/26] drm/bridge: tc358767: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 0fd9cf27542c..75f93e1d0bf5 100644 --- a/drivers

[PATCH v3 21/26] drm/msm: specify the owner .odev of the bridges

2018-05-16 Thread Peter Rosin
This will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 1 + drivers/gpu/drm/msm/edp/edp_bridge.c | 1 + drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers

[PATCH v3 15/26] drm/bridge: synopsys: provide an owner .odev device for the bridges

2018-05-16 Thread Peter Rosin
It gets rid of two #ifdefs and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v3 17/26] drm/bridge: thc63lvd1024: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c index c8b9edd5a7f4..4765c9c45aef 100644

[PATCH v3 13/26] drm/bridge: sii9234: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sii9234.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index c77000626c22..54326357b2ee 100644 --- a/drivers/gpu

[PATCH v3 10/26] drm/bridge: panel: provide an owner .odev device

2018-05-16 Thread Peter Rosin
It gets rid of an #ifdef and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/panel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 6d99d4a3beb3..f43d77b5ed20

[PATCH v3 11/26] drm/bridge: ps8622: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/parade-ps8622.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c index 81198f5e9afa..957420a1c924 100644

[PATCH v3 08/26] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdp-ge

[PATCH v3 06/26] drm/bridge: vga-dac: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 9837c8d69e69..95cce18e8943 100644

[PATCH v3 04/26] drm/bridge: analogix-anx78xx: provide an owner .odev device

2018-05-16 Thread Peter Rosin
It gets rid of an #if and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c

[PATCH v3 01/26] drm/bridge: allow optionally specifying an owner .odev device

2018-05-16 Thread Peter Rosin
-by: Daniel Vetter Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 3 ++- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 +++- include/drm/drm_bridge.h | 2 ++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b

[PATCH v3 02/26] drm/bridge: adv7511: provide an owner .odev device

2018-05-16 Thread Peter Rosin
The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 2614cea538e2

Re: [PATCH v4 7/8] drm/i2c: tda998x: register as a drm bridge

2018-04-25 Thread Peter Rosin
On 2018-04-24 19:06, Russell King - ARM Linux wrote: > On Tue, Apr 24, 2018 at 07:04:16PM +0300, Jyri Sarha wrote: >> On 24/04/18 13:14, Peter Rosin wrote: >>> On 2018-04-24 10:08, Russell King - ARM Linux wrote: >>>> On Tue, Apr 24, 2018 at 08:58:42AM +0200, Peter Ro

Re: [PATCH v6 2/2] drivers: mux: Add Generic regmap bitfield-based multiplexer in mmio-mux

2019-04-17 Thread Peter Rosin
On 2019-04-17 10:21, Pankaj Bansal wrote: > HI Peter, > > Have these changes been applied in any linux branch? I did not see these > changes in > https://elixir.bootlin.com/linux/v5.1-rc5/source/drivers/mux/mmio.c#L46 > Hi, No they have not, I've been busy with other stuff... However, I don't

Re: [PATCH] i2c: iproc: Change driver to use 'BIT' macro

2019-04-17 Thread Peter Rosin
On 2019-04-18 01:48, Ray Jui wrote: > > > On 4/14/2019 11:56 PM, Peter Rosin wrote: >> On 2019-04-13 00:59, Peter Rosin wrote: >>> On 2019-04-03 23:05, Ray Jui wrote: >>>> Change the iProc I2C driver to use the 'BIT' macro from all '1 <<

Re: [PATCH 0/5] i2c-mux-gpio: Split plat- and dt-specific code up

2019-04-24 Thread Peter Rosin
On 2019-04-24 14:34, Serge Semin wrote: > The main idea of this patchset was to add the dt-based GPIOs support > in i2c-mux-gpio driver. In particular we needed to have the full GPIOs > specifier being handled including the dt-flags like GPIO_ACTIVE_HIGH, > GPIO_ACTIVE_LOW, etc. Due to using a lega

Re: [PATCH 2/5] i2c-mux-gpio: Return an error if no config data found

2019-04-24 Thread Peter Rosin
On 2019-04-24 14:34, Serge Semin wrote: > It's pointless and might be even errors prone to proceed with further > initialization if neither of- no platform-based settings were discovered. > Just return an error in this case. > > Signed-off-by: Serge Semin > --- > drivers/i2c/muxes/i2c-mux-gpio.c

Re: [PATCH 5/5] i2c-mux-gpio: Create of-based GPIOs request method

2019-04-24 Thread Peter Rosin
On 2019-04-24 14:34, Serge Semin wrote: > Most modern platforms provide a dts with description of the devices > available in the system. It may also include i2c-gpio-mux'es. > Up until now the i2c-mux-gpio driver supported it' dts nodes, but > performed the GPIOs request by means of legacy GPIO API

Re: [PATCH 3/5] i2c-mux-gpio: Save initial channel number to the idle data field

2019-04-24 Thread Peter Rosin
On 2019-04-24 14:34, Serge Semin wrote: > In case if the idle state has been specified in the data structure, > the idle variable is left untouched as before, so to keep a default > channel number enabled in the mux idle state. But if a platform doesn't > specify which channel is going to be enable

Re: [PATCH 0/5] i2c-mux-gpio: Split plat- and dt-specific code up

2019-04-25 Thread Peter Rosin
On 2019-04-25 16:37, Serge Semin wrote: > On Wed, Apr 24, 2019 at 09:25:24PM +0000, Peter Rosin wrote: > > Hello Peter, > >> On 2019-04-24 14:34, Serge Semin wrote: >>> The main idea of this patchset was to add the dt-based GPIOs support >>> in i2c-mux-gpi

Re: [PATCH 2/5] i2c-mux-gpio: Return an error if no config data found

2019-04-25 Thread Peter Rosin
On 2019-04-25 17:47, Serge Semin wrote: > On Wed, Apr 24, 2019 at 09:25:50PM +0000, Peter Rosin wrote: >> On 2019-04-24 14:34, Serge Semin wrote: >>> It's pointless and might be even errors prone to proceed with further >>> initialization if neither of- no platfor

Re: [PATCH 3/5] i2c-mux-gpio: Save initial channel number to the idle data field

2019-04-25 Thread Peter Rosin
On 2019-04-25 17:53, Serge Semin wrote: > On Wed, Apr 24, 2019 at 09:26:22PM +0000, Peter Rosin wrote: >> On 2019-04-24 14:34, Serge Semin wrote: >>> In case if the idle state has been specified in the data structure, >>> the idle variable is left untouched as b

Re: [PATCH v4 3/3] i2c: mux: pca954x: allow management of device idle state via sysfs

2019-03-13 Thread Peter Rosin
Hi Greg, I was wondering if you think the below ABI addition looks sane to you? Or, should I ask someone else for a tag? Cheers, Peter On 2019-02-28 12:43, Robert Shearman wrote: > From: Robert Shearman > > The behaviour, by default, to not deselect after each transfer is > unsafe when there i

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-26 Thread Peter Rosin
On 2019-03-25 18:12, Steven Price wrote: > On 25/03/2019 15:30, laurentiu.tu...@nxp.com wrote: >> From: Laurentiu Tudor >> >> If the dma controller is not yet probed, defer i2c probe. >> The error path in probe was slightly modified (no functional change) *snip* >> @@ -1161,19 +1162,25 @@ static

Re: [PATCH v3 2/2] drivers: mux: Add Generic regmap bitfield-based multiplexer in mmio-mux

2019-02-25 Thread Peter Rosin
On 2019-02-24 09:27, Pankaj Bansal wrote: > Generic register bitfield-based multiplexer that controls the multiplexer > producer defined under a parent node. > The driver corresponding to parent node provides register read/write > capabilities. > > Signed-off-by: Pankaj Bansal > --- > > Notes: >

Re: [PATCH v3 2/2] drivers: mux: Add Generic regmap bitfield-based multiplexer in mmio-mux

2019-02-26 Thread Peter Rosin
On 2019-02-26 07:08, Pankaj Bansal wrote: >>> + if (IS_ERR_OR_NULL(regmap)) { >>> + ret = PTR_ERR_OR_ZERO(regmap) ? PTR_ERR(regmap) : - >> ENODEV; >> >> The above is not correct, this should be better (untested): >> >> ret = PTR_ERR(regmap) ?: -ENODEV; > > Omitting the sec

Re: include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant

2020-08-12 Thread Peter Rosin
On 2020-08-11 06:27, Andrew Morton wrote: > On Sat, 8 Aug 2020 08:03:38 +0800 kernel test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 30185b69a2d533c4ba6ca926b8390ce7de495e29 >> commit: 295bcca84916cb5079140a89fccb472bb8d1f6e2

Re: [PATCH 4/7] dt-bindings: ti-serdes-mux: Add defines for AM64 SoC

2021-01-08 Thread Peter Rosin
J7200 sections have a blank line here, between the header comment and the actual defines. But mehh... Acked-by: Peter Rosin Cheers, Peter > +#define AM64_SERDES0_LANE0_PCIE0 0x0 > +#define AM64_SERDES0_LANE0_USB 0x1 > + > #endif /* _DT_BINDINGS_MUX_TI_SERDES */ >

Re: [RESEND PATCH v3 2/2] i2c: i2c-mux-gpio: Enable this driver in ACPI land

2021-01-15 Thread Peter Rosin
that area. I would greatly appreciate Andy following through with his line of thinking... So, if we ignore Andys review comments, then: Acked-by: Peter Rosin Cheers, Peter

Re: [RESEND PATCH v3 1/2] i2c: i2c-mux-gpio: Factor out pdev->dev in _probe_dt()

2021-01-15 Thread Peter Rosin
&pdev->dev to dev refactor (Peter) > > drivers/i2c/muxes/i2c-mux-gpio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Acked-by: Peter Rosin (this patch doesn't make much sense without 2/2) Cheers, Peter

Re: [PATCH v1 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-30 Thread Peter Rosin
; > diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c > index 02c1f2c014e8..891ee0274733 100644 > --- a/drivers/mux/gpio.c > +++ b/drivers/mux/gpio.c > @@ -6,7 +6,7 @@ > * > * Author: Peter Rosin > */ > - Nit, please keep the empty line here. With that, Acked

Re: [PATCH v1 2/3] mux: gpio: Make it OF independent

2021-03-30 Thread Peter Rosin
le.h sorts before module.h. With that changed, Acked-by: Peter Rosin Cheers, Peter > #include > -#include > #include > #include > > @@ -97,7 +97,7 @@ static int mux_gpio_probe(struct platform_device *pdev) > static struct platform_driver mux_gpio_driver = { >

Re: [PATCH v1 3/3] mux: gpio: Simplify code by using dev_err_probe()

2021-03-30 Thread Peter Rosin
lines and a long one here and there. Sorry to be a pest, but coding-style.rst agrees with me: "The preferred limit on the length of a single line is 80 columns." So, with that changed, Acked-by: Peter Rosin Cheers, Peter > WARN_ON(pins != mux_gpio->gpios->ndescs); > mux_chip->mux->states = BIT(pins); > >

Re: [PATCH v2 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-31 Thread Peter Rosin
aps like it's done in the driver might be error prone. > Fix this by using bitmap API. > > Signed-off-by: Andy Shevchenko > Acked-by: Peter Rosin > --- > v2: left blank line untouched (Peter) > drivers/mux/gpio.c | 6 -- > 1 file changed, 4 insertions(+), 2 delet

Re: [PATCH] drm/fb-helper: Add missed unlocks in setcmap_legacy()

2020-12-03 Thread Peter Rosin
> Signed-off-by: Chuhong Yuan Yup, my patch fumbled the locking. Sorry, and thanks for cleaning up my mess! Acked-by: Peter Rosin (Spelled that as Ached-by at first, what does that mean??) Cheers, Peter > --- > drivers/gpu/drm/drm_fb_helper.c | 15 ++- > 1 file c

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi! (and thank you for the pointer to the example with the ssc-dai in master mode) > Hi Peter, > > On 10/20/2014 09:45 PM, Peter Rosin wrote: > > From 1e5621d7b9887c648d1a66238dc82d715c1e2cad Mon Sep 17 00:00:00 > > 2001 > > From: Peter Rosin > > Date

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi again! > Hi Peter, > > On 10/21/2014 03:55 PM, Peter Rosin wrote: > > Hi! > > > > (and thank you for the pointer to the example with the ssc-dai in > > master mode) > > > >> Hi Peter, > >> > >> On 10/20/2014 09:45 PM, Peter

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi again, > -Original Message- > From: Peter Rosin > Sent: Tuesday, October 21, 2014 13:05 > To: 'Bo Shen' > Cc: Liam Girdwood; Mark Brown; Jaroslav Kysela; Takashi Iwai; 'alsa- > de...@alsa-project.org'; linux-kernel@vger.kernel.org > Subject: RE:

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi! > Hi Peter, > > On 10/21/2014 09:05 PM, Peter Rosin wrote: > > I did some further tests, and the following program fails without the patch: > > With the patch, it is OK? Yes. > > #include > > #include > > #include > > #include &g

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-22 Thread Peter Rosin
Hi! > >> With the patch, it is OK? > > > > Yes. > > > >>> #include > >>> #include > >>> #include > >>> #include > >>> > >>> int > >>> main(void) > >>> { > >>> int fd; > >>> int format; > >>> int channels; > >>> > >>> if ((fd = open("/dev/dsp", O_WRONLY, 0)) == -1) { > >>> per

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-22 Thread Peter Rosin
Bo Chen wrote: > with this piece of code, I reproduce your issue. > > Now, I know the reason of this issue, work in oss mode, it will set the > default > clock to 8KHz, and then if change to other sample rate, for example 48KHz, > the div is different, then it reports -EBUSY. Indeed. > So, I th

[PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-22 Thread Peter Rosin
>From 86be84c4de4e7b21cfda9656a02a902c543210af Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Wed, 22 Oct 2014 16:45:29 +0200 Subject: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex. The CMR divider register is shared by playback and capture. The SSC dri

[PATCH] ARM: at91/dt: Fix sama5d3x typos.

2014-10-23 Thread Peter Rosin
>From c23d712fe924b929c2eb39eba644fe74bcccfd37 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Thu, 23 Oct 2014 13:52:03 +0200 Subject: [PATCH] ARM: at91/dt: Fix sama5d3x typos. The DT compatible strings also need binding documentation, but that is for someone else to write. Signed-off

NXP Semiconductors TFA9879 Amplifier Driver

2014-11-06 Thread Peter Rosin
Hi! Sorry for not sending this from my axentia.se account, but I tend to get high spam-scores from there when I use git send-email. This is a new driver, and it's pretty minimalistic with support for only a few basic controls. However, it is usable and I'd be happy to see it included. I don't kn

[PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
From: Peter Rosin Signed-off-by: Peter Rosin --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 334 sound/soc/codecs/tfa9879.h | 202

[PATCH 2/2] ASoC: tfa9879: Add bass and treble gain/freq controls.

2014-11-06 Thread Peter Rosin
From: Peter Rosin Signed-off-by: Peter Rosin --- sound/soc/codecs/tfa9879.c | 16 1 file changed, 16 insertions(+) diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index 90cc28f7e6ed..0d62962542e2 100644 --- a/sound/soc/codecs/tfa9879.c +++ b/sound/soc

RE: [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
Thanks for the review! I'm answering here, but would like to thank Lars-Peter for the review as well. Mark Brown wrote: > On Thu, Nov 06, 2014 at 01:54:00PM +0100, Peter Rosin wrote: > > > +#define TFA9879_REG(codec, reg, field, value) \ > > + snd_soc_update_bits

[PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
From: Peter Rosin Signed-off-by: Peter Rosin --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 323 sound/soc/codecs/tfa9879.h | 202

[v2] NXP Semiconductors TFA9879 Amplifier Driver

2014-11-06 Thread Peter Rosin
On 2014-11-06 17:02, Mark Brown wrote:> On Thu, Nov 06, 2014 at 02:37:31PM +0000, Peter Rosin wrote: >> > Mark Brown wrote: >>>> > > > +if (tfa9879->lsb_justified) >>>> > > > +TFA9879_REG(codec, SERIAL_INTERFACE_1, I2S_SE

RE: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-24 Thread Peter Rosin
> Hi Peter, >Thanks for your patch. And thanks for the Ack! >Btw, do you use "git send-email" command to send the patch? No, I didn't, "git format-patch" and paste into the mail body. Was there some whitespace issues with the patch? Cheers, Peter -- To unsubscribe from this list: send

Re: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-24 Thread Peter Rosin
Ok, I'm trying with git send-email, sorry for the inconvenience. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-24 Thread Peter Rosin
P_SPEED, &speed) == -1) { perror("SNDCTL_DSP_SPEED"); return 1; } return 0; } Signed-off-by: Peter Rosin --- sound/soc/atmel/atmel_ssc_dai.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel_ssc_

NXP Semiconductors TFA9879 Amplifier Driver

2014-11-08 Thread Peter Rosin
Mark Brown wrote: > On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote: > > > + { TFA9879_MISC_STATUS, 0x }, /* 0x15, read-only > */ > > The fix here is the wrong way round - if the device is reporting status > here there should be no defau

[PATCH v3] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-08 Thread Peter Rosin
From: Peter Rosin Signed-off-by: Peter Rosin --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 328 sound/soc/codecs/tfa9879.h | 202

Re: [PATCH v6 01/24] i2c-mux: add common data for every i2c-mux instance

2016-04-15 Thread Peter Rosin
Wolfram Sang wrote: > > > wonder even more if we couldn't supply num_adapters to i2c_mux_alloc() > > > and reserve the memory statically. i2c busses are not > > > dynamic/hot-pluggable so that should be good enough? > > > > Yes, that would work, but it would take some restructuring in some of > >

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-04-28 Thread Peter Rosin
On 2016-04-28 22:50, Wolfram Sang wrote: > On Wed, Apr 20, 2016 at 05:17:56PM +0200, Peter Rosin wrote: >> Add i2c_lock_bus() and i2c_unlock_bus(), which call the new lock_bus and >> unlock_bus ops in the adapter. These funcs/ops take an additional flags >> argument th

Re: [PATCH v7 22/24] [media] rtl2832: change the i2c gate to be mux-locked

2016-04-28 Thread Peter Rosin
On 2016-04-28 23:47, Wolfram Sang wrote: > On Wed, Apr 20, 2016 at 05:18:02PM +0200, Peter Rosin wrote: >> The root i2c adapter lock is then no longer held by the i2c mux during >> accesses behind the i2c gate, and such accesses need to take that lock >> just like any other

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-04-29 Thread Peter Rosin
On 2016-04-29 09:16, Wolfram Sang wrote: >> Yes, obviously... I'll make that change locally and wait for the rest. > Another nit: You could use '--strict' with checkpatch and see if you > want to fix the issues reported. I am not keen on those (except for > 'space around operators'), it's a matter

Re: [PATCH] iio: inv_mpu6050: Add support for auxiliary I2C master

2016-04-29 Thread Peter Rosin
On 2016-04-28 12:39, Crestez Dan Leonard wrote: > On 04/27/2016 11:39 AM, Peter Rosin wrote: >> On 2016-04-23 23:32, Jonathan Cameron wrote: >>> On 20/04/16 18:17, Crestez Dan Leonard wrote: >>>> The MPU has an auxiliary I2C bus for connecting external >>&g

Re: [PATCH] iio: inv_mpu6050: Add support for auxiliary I2C master

2016-04-29 Thread Peter Rosin
On 2016-04-29 11:29, Peter Rosin wrote: > On 2016-04-28 12:39, Crestez Dan Leonard wrote: >> On 04/27/2016 11:39 AM, Peter Rosin wrote: >>> On 2016-04-23 23:32, Jonathan Cameron wrote: >>>> On 20/04/16 18:17, Crestez Dan Leonard wrote: >>>>> Th

Re: [PATCH] ASoC: pcm: allow changing the playback/capture rates for symmetric links

2016-05-02 Thread Peter Rosin
On 2016-04-28 12:38, Mark Brown wrote: > On Wed, Apr 27, 2016 at 10:45:48PM +0200, Peter Rosin wrote: >> I haven't looked really closely at the userspace side of this, but the >> big picture is that we're using a (closed source) library that in its >> documentation

Re: [RFC 5/7] iio: inv_mpu6050: Add support for auxiliary I2C master

2016-05-02 Thread Peter Rosin
On 2016-04-29 21:02, Crestez Dan Leonard wrote: > The MPU has an auxiliary I2C bus for connecting external > sensors. This bus has two operating modes: > * pass-through, which connects the primary and auxiliary busses > together. This is already supported via an i2c mux. > * I2C master mode, where

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-05-04 Thread Peter Rosin
Hi! On 2016-05-03 23:38, Wolfram Sang wrote: > On Wed, Apr 20, 2016 at 05:17:56PM +0200, Peter Rosin wrote: >> Add i2c_lock_bus() and i2c_unlock_bus(), which call the new lock_bus and >> unlock_bus ops in the adapter. These funcs/ops take an additional flags >> argument th

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-05-04 Thread Peter Rosin
On 2016-05-03 23:39, Wolfram Sang wrote: >> Yes, they look like reasonable complaints. > > Thanks for fixing them. I just sent out my latest comments and when you > fix those and send V8, I'll apply that right away. I think we are safe > to fix the rest incrementally if needed. Note that I didn'

[PATCH v9 2/9] i2c: muxes always lock the parent adapter

2016-05-04 Thread Peter Rosin
Instead of checking for i2c parent adapters for every lock/unlock, simply override the locking for muxes to always lock/unlock the parent adapter directly. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 21 +++-- drivers/i2c/i2c-mux.c | 30

[PATCH v9 4/9] i2c-mux: document i2c muxes and elaborate on parent-/mux-locked muxes

2016-05-04 Thread Peter Rosin
Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology | 370 + MAINTAINERS| 1 + 2 files changed, 371 insertions(+) create mode 100644 Documentation/i2c/i2c-topology diff --git a/Documentation/i2c/i2c-topology b

[PATCH v9 9/9] [media] rtl2832: regmap is aware of lockdep, drop local locking hack

2016-05-04 Thread Peter Rosin
Tested-by: Antti Palosaari Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832.c | 30 -- drivers/media/dvb-frontends/rtl2832_priv.h | 1 - 2 files changed, 31 deletions(-) diff --git a/drivers/media/dvb-frontends

[PATCH v9 8/9] [media] rtl2832_sdr: get rid of empty regmap wrappers

2016-05-04 Thread Peter Rosin
Tested-by: Antti Palosaari Reviewed-by: Antti Palosaari Signed-off-by: Peter Rosin --- drivers/media/dvb-frontends/rtl2832_sdr.c | 302 +- 1 file changed, 132 insertions(+), 170 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media

[PATCH v9 7/9] [media] rtl2832: change the i2c gate to be mux-locked

2016-05-04 Thread Peter Rosin
use plain old regmap accesses. This also removes the need for the regmap wrappers used by rtl2832_sdr, so deconvolute the code further and provide the regmap handle directly instead of the wrapper functions. Tested-by: Antti Palosaari Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology

[PATCH v9 6/9] [media] si2168: change the i2c gate to be mux-locked

2016-05-04 Thread Peter Rosin
unlocked. But add a mutex so that firmware commands are still serialized. Signed-off-by: Antti Palosaari Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology| 2 +- drivers/media/dvb-frontends/si2168.c | 83 --- drivers/media/dvb-frontends

[PATCH v9 5/9] iio: imu: inv_mpu6050: change the i2c gate to be mux-locked

2016-05-04 Thread Peter Rosin
e very end (and grabs the newfangled i2c mux lock where it previously grabbed the i2c adapter lock). Acked-by: Jonathan Cameron Acked-by: Daniel Baluta Tested-by: Crestez Dan Leonard Signed-off-by: Peter Rosin --- Documentation/i2c/i2c-topology| 2 +- drivers/iio/imu/inv_m

[PATCH v9 3/9] i2c-mux: relax locking of the top i2c adapter during mux-locked muxing

2016-05-04 Thread Peter Rosin
apter in the same adapter tree that is muxed, and request a "mux-locked mux" if that is the case. Modify the select-transfer-deselect code for "mux-locked" muxes so that each of the select-transfer-deselect ops locks the mux parent adapter individually. Signed-off-by: Peter Ros

[PATCH v9 1/9] i2c: allow adapter drivers to override the adapter locking

2016-05-04 Thread Peter Rosin
. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 41 +++-- include/linux/i2c.h| 44 ++-- 2 files changed, 69 insertions(+), 16 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index

[PATCH v9 0/9] i2c mux cleanup and locking update

2016-05-04 Thread Peter Rosin
fic i2c muxes that I had overlooked. - Rebase on top of v4.4-rc8 (was based on v4.4-rc6 previously). - Drop the last two patches in the series. Cheers, Peter Antti Palosaari (1): [media] si2168: change the i2c gate to be mux-locked Peter Rosin (8): i2c: allow adapter drivers to override the a

[PATCH] ASoC: MAX9860: new driver

2016-05-10 Thread Peter Rosin
This is a driver for the MAX9860 Mono Audio Voice Codec. https://datasheets.maximintegrated.com/en/ds/MAX9860.pdf This driver does not support sidetone since the DVST register field is backwards with the mute near the maximum level instead of the minimum. Signed-off-by: Peter Rosin

Re: [PATCH] ASoC: MAX9860: new driver

2016-05-11 Thread Peter Rosin
On 2016-05-11 17:29, Mark Brown wrote: > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote: > >> +if (master) { >> +switch (max9860->pclk_rate) { >> +case 1200: >> +

Re: [PATCH] ASoC: MAX9860: new driver

2016-05-11 Thread Peter Rosin
On 2016-05-11 17:09, Mark Brown wrote: > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote: > >> This driver does not support sidetone since the DVST register field is >> backwards with the mute near the maximum level instead of the minimum. > > Why would that

Re: [PATCH] ASoC: MAX9860: new driver

2016-05-12 Thread Peter Rosin
[Dropping the DT crowd] On 2016-05-11 22:50, Mark Brown wrote: > On Wed, May 11, 2016 at 10:12:56PM +0200, Peter Rosin wrote: >> On 2016-05-11 17:09, Mark Brown wrote: >>> On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote: > >>>> This driver does no

Re: [PATCH] ASoC: MAX9860: new driver

2016-05-12 Thread Peter Rosin
On 2016-05-11 22:53, Mark Brown wrote: > On Wed, May 11, 2016 at 10:28:12PM +0200, Peter Rosin wrote: >> On 2016-05-11 17:29, Mark Brown wrote: >>> On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote: > >>>> + if (master) { >>>>

Re: [PATCH v2 2/5] of: changesets: Introduce changeset helper methods

2016-05-17 Thread Peter Rosin
Hi! I found a resource management bug in this patch. Cheers, Peter On 2016-05-16 18:41, Pantelis Antoniou wrote: > Changesets are very powerful, but the lack of a helper API > makes using them cumbersome. Introduce a simple copy based > API that makes things considerably easier. > > To wit, add

Re: [PATCH v2 2/7] iio: inv_mpu6050: Initial regcache support

2016-05-19 Thread Peter Rosin
Hi! On 2016-05-20 04:34, Matt Ranostay wrote: > On Wed, May 18, 2016 at 8:00 AM, Crestez Dan Leonard > wrote: >> Signed-off-by: Crestez Dan Leonard >> --- >> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 47 >> ++ >> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 5 --

<    1   2   3   4   5   6   7   8   9   10   >