On 2018-03-27 15:22, Jonathan Cameron wrote:
> On Tue, 27 Mar 2018 09:42:40 +0200
> Peter Rosin wrote:
>> On 2018-03-24 15:03, Jonathan Cameron wrote:
>>> On Mon, 19 Mar 2018 18:02:46 +0100
>>> Peter Rosin wrote:
>>>> + if (iio_channel_has_info(pchan
;> Use that function to verify the device ID of a given device.
>
> I am very open to these patches, just...
>
>>
>> Cc: Peter Rosin
>> Signed-off-by: Guenter Roeck
>> ---
>> RFC:
>> - Compile tested only
>
> ... I would really like to have
Sorry for replying to self...
On 2018-04-08 11:08, Peter Rosin wrote:
> On 2018-04-08 09:34, Wolfram Sang wrote:
>> Hi,
>>
>> On Mon, Mar 19, 2018 at 09:10:58AM -0700, Guenter Roeck wrote:
>>> Commit dde67eb1beeb ("i2c: add i2c_get_device_id() to get the s
Hi Ken,
It's been a couple of weeks and I wondered if you are making any
progress? Simple lack of time perhaps, or are you stuck and need
help?
Cheers,
Peter
On 2018-03-20 10:31, Peter Rosin wrote:
> On 2018-03-20 07:19, Ken Chen wrote:
>> Signed-off-by: Ken Chen
>
> Ok,
On 2018-04-10 15:12, Bartosz Golaszewski wrote:
> We switched to using probe_new(), so this is no longer used
> by i2c core.
It seems to be used in i2c_device_match() ???
This could easily be me not understanding something...
Cheers,
Peter
> Signed-off-by: Bartosz Golaszewski
> ---
> drivers/
On 2018-04-11 12:09, Bartosz Golaszewski wrote:
> 2018-04-11 11:56 GMT+02:00 Peter Rosin :
>> On 2018-04-10 15:12, Bartosz Golaszewski wrote:
>>> We switched to using probe_new(), so this is no longer used
>>> by i2c core.
>>
>> It seems to be used in i2c_dev
On 2018-04-10 15:12, Bartosz Golaszewski wrote:
> Move the code responsible for creating the dummy i2c clients used by
> chips taking multiple slave addresses to a separate function.
>
> Signed-off-by: Bartosz Golaszewski
> ---
> drivers/misc/eeprom/at24.c | 47 ++
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/tfa9879.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
index e7ca764b5729..15c769528d6d 100644
--- a/sound/soc/codecs
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/max9860.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/max9860.c b/sound/soc/codecs/max9860.c
index a2dc6a47f466..376bd48e4790 100644
--- a/sound/soc/codecs
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
---
drivers/mux/adg792a.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mux/adg792a.c b/drivers/mux/adg792a.c
index 6a8725cf3d71..e8fc2fc1ab09 100644
--- a/drivers/mux/adg792a.c
+++ b/drivers
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
---
drivers/iio/potentiometer/mcp4018.c | 41 ++---
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/drivers/iio/potentiometer/mcp4018.c
b/drivers/iio/potentiometer/mcp4018.c
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
---
drivers/iio/potentiometer/mcp4531.c | 145 ++--
1 file changed, 72 insertions(+), 73 deletions(-)
diff --git a/drivers/iio/potentiometer/mcp4531.c
b/drivers/iio/potentiometer/mcp4531.c
This is a current sense amplifier from Analog Devices.
Signed-off-by: Peter Rosin
---
drivers/iio/afe/Kconfig | 3 +-
drivers/iio/afe/iio-unit-converter.c | 54
2 files changed, 56 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/afe
in". In the end I went with the resistors since
while the normal case is an integer gain, that may not always be
the case. And when it's not, that could get tricky. But I'm open
for arguments on that.
Cheers,
Peter
Peter Rosin (2):
dt-bindings: iio: afe: add binding for adi,lt6
This is a current sense amplifier from Analog Devices.
Signed-off-by: Peter Rosin
---
.../devicetree/bindings/iio/afe/adi,lt6106.txt | 50 ++
MAINTAINERS| 1 +
2 files changed, 51 insertions(+)
create mode 100644 Documentation
ers,
Peter
On 2018-04-03 09:18, Boris Brezillon wrote:
> On Tue, 3 Apr 2018 08:11:30 +0200
> Peter Rosin wrote:
>
>> On 2018-04-02 22:20, Boris Brezillon wrote:
>>> On Mon, 2 Apr 2018 21:28:43 +0200
>>> Boris Brezillon wrote:
>>>
>>&g
On 2018-04-11 16:59, Boris Brezillon wrote:
> On Wed, 11 Apr 2018 16:44:10 +0200
> Peter Rosin wrote:
>
>> Hi Nicolas,
>>
>> Boris asked for your input on this (the datasheet difference appears to
>> have no bearing on the issue) elsewhere in the tree of messag
On 2018-04-11 17:34, Nicolas Ferre wrote:
> On 11/04/2018 at 16:44, Peter Rosin wrote:
>> Hi Nicolas,
>>
>> Boris asked for your input on this (the datasheet difference appears to
>> have no bearing on the issue) elsewhere in the tree of messages. It's
>> now
On 2018-04-11 17:43, Andrew F. Davis wrote:
> On 04/11/2018 09:15 AM, Peter Rosin wrote:
>> This is a current sense amplifier from Analog Devices.
>>
>> Signed-off-by: Peter Rosin
>> ---
>> drivers/iio/afe/Kconfig | 3 +-
>> dr
On 2018-04-11 18:13, Andrew F. Davis wrote:
> On 04/11/2018 10:51 AM, Lars-Peter Clausen wrote:
>> On 04/11/2018 05:43 PM, Andrew F. Davis wrote:
>>> On 04/11/2018 09:15 AM, Peter Rosin wrote:
>>>> This is a current sense amplifier from Analog Devices.
>&g
ped patch 1/4 because id_table is still needed as pointed out by
> Peter Rosin
> - fixed patch 3/3: we need to free the dummy client if regmap_init fails
>
> Bartosz Golaszewski (3):
> eeprom: at24: use devm_nvmem_register()
> eeprom: at24: provide and use a helper for relea
It's less overhead, clearer and generally neater.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/max9860.c | 10 +-
sound/soc/codecs/max9860.h | 10 +-
2 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/sound/soc/codecs/max9860.c b/sound/soc/codecs/max9860.c
On 2018-04-12 18:16, Mark Brown wrote:
> On Wed, Apr 11, 2018 at 02:42:38PM +0200, Peter Rosin wrote:
>
>> Use the new probe style for i2c drivers.
> This doesn't apply against current code, please check and resend.
That's not my fault. Somebody forgot to drop a note wit
Long lines and bad alignment disturbs the reading pleasure.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/max9860.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/max9860.c b/sound/soc/codecs/max9860.c
index 5bbf889ad98e..53448b7b7b28 100644
--- a
It's less overhead, clearer and generally neater.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/tfa9879.c | 7 +--
sound/soc/codecs/tfa9879.h | 7 +--
2 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
Use the new probe style for i2c drivers.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/tfa9879.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
index 4d9b3f393808..d686e04bc5c7 100644
--- a/sound/soc/codecs
Long lines and bad alignment disturbs the reading pleasure.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/tfa9879.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
index 6d213c6d3920
On 2018-04-12 17:35, Andrew F. Davis wrote:
> On 04/12/2018 09:29 AM, Peter Rosin wrote:
>> On 2018-04-11 18:13, Andrew F. Davis wrote:
>>> On 04/11/2018 10:51 AM, Lars-Peter Clausen wrote:
>>>> On 04/11/2018 05:43 PM, Andrew F. Davis wrote:
>>>>&
On 2018-04-13 08:59, ChenKenYY 陳永營 TAO wrote:
> Hi Peter,
>
> Sorry for late. Here has some event at my company which needs to pause
> this work.
>
> If the status changed, I will update my patch.
No worries, I just want to know how to handle my preparatory patches. If
nothing changes, I think I
On 2018-04-13 13:19, Mark Brown wrote:
> On Thu, Apr 12, 2018 at 11:14:35PM +0200, Peter Rosin wrote:
>
>> @@ -1,3 +1,4 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /*
>> * Driver for the MAX9860 Mono Audio Voice Codec
>> *
>
> Please don
It's less overhead, clearer and generally neater.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/tfa9879.c | 18 ++
sound/soc/codecs/tfa9879.h | 7 +--
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9
It's less overhead, clearer and generally neater.
Signed-off-by: Peter Rosin
---
sound/soc/codecs/max9860.c | 31 +++
sound/soc/codecs/max9860.h | 10 +-
2 files changed, 12 insertions(+), 29 deletions(-)
diff --git a/sound/soc/codecs/max9860.c b/soun
On 2018-03-19 19:48, Guenter Roeck wrote:
> On Mon, Mar 19, 2018 at 05:47:05PM +0100, Peter Rosin wrote:
>> I also wonder if NXP will ever release a chip with part-id 0 and
>> die-revision 0? If not, an all zero struct i2c_device_identity
>> could be used instead of manufactur
On 2018-03-19 21:50, Guenter Roeck wrote:
> On Mon, Mar 19, 2018 at 08:55:55PM +0100, Peter Rosin wrote:
>> On 2018-03-19 19:48, Guenter Roeck wrote:
>>> On Mon, Mar 19, 2018 at 05:47:05PM +0100, Peter Rosin wrote:
>>>> I also wonder if NXP will ever release a ch
Make the arbitrate and release_bus implementation chip specific.
Signed-off-by: Peter Rosin
---
drivers/i2c/muxes/i2c-mux-pca9541.c | 62 +++--
1 file changed, 45 insertions(+), 17 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c
b/drivers/i2c
In preparation for PCA9641 support, convert the mybus and busoff macros
to functions, and in the process prefix them with pca9541_. Also prefix
remaining chip specific macros with PCA9541_.
Signed-off-by: Peter Rosin
---
drivers/i2c/muxes/i2c-mux-pca9541.c | 26 +++---
1
On 2018-03-20 07:19, Ken Chen wrote:
> Signed-off-by: Ken Chen
Ok, now that you are not adding a new driver, but instead
modify an existing driver, the subject I requested in no
longer relevant. Now I would like to see:
i2c: mux: pca9541: add support for PCA9641 chips
Or something like that.
>
Because it looks nice!
Signed-off-by: Peter Rosin
---
drivers/i2c/muxes/i2c-mux-pca9541.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c
b/drivers/i2c/muxes/i2c-mux-pca9541.c
index 6a39adaf433f
On 2018-03-20 14:20, Guenter Roeck wrote:
> On 03/20/2018 02:31 AM, Peter Rosin wrote:
>> +static int pca9541_mybus(int ctl)
>
> bool ?
>
>> +{
>> +if (!(ctl & PCA9541_MYBUS))
>> +return 1;
>
> true ?
>
>
On 2018-03-21 00:24, Vladimir Zapolskiy wrote:
> Hi Peter,
>
> On 03/20/2018 11:31 AM, Peter Rosin wrote:
>> In preparation for PCA9641 support, convert the mybus and busoff macros
>> to functions, and in the process prefix them with pca9541_. Also prefix
>> remainin
On 2018-03-21 07:54, Vladimir Zapolskiy wrote:
> Hi Peter,
>
> On 03/21/2018 07:53 AM, Peter Rosin wrote:
>> On 2018-03-21 00:24, Vladimir Zapolskiy wrote:
>>> Hi Peter,
>>>
>>> On 03/20/2018 11:31 AM, Peter Rosin wrote:
>>>> In preparation fo
On 2018-03-21 08:01, Vladimir Zapolskiy wrote:
> On 03/21/2018 03:19 AM, Guenter Roeck wrote:
>> On 03/20/2018 04:17 PM, Vladimir Zapolskiy wrote:
>>> Hi Peter, Ken,
>>>
>>> On 03/20/2018 11:32 AM, Peter Rosin wrote:
>>>> Make the arbitr
Remove pullup on uart TX signals, they are push-pull outputs thus
pullups are pointless.
Add pullup on uart RX signals, they prevent the RX signals to be left
floating and so consuming a useless extra amount of power in crowbarred
state if nothing is connected to RX.
Signed-off-by: Peter Rosin
For consistency with all other serial pins, add this pullup. It also
prevents the signal from floating and so consuming a useless extra amount
of power in crowbarred state if nothing is connected to RX.
Signed-off-by: Peter Rosin
---
arch/arm/boot/dts/at91sam9260.dtsi | 4 ++--
1 file changed
For consistency with all other serial pins, add this pullup. It also
prevents the signal from floating and so consuming a useless extra amount
of power in crowbarred state if nothing is connected to RX.
Signed-off-by: Peter Rosin
---
arch/arm/boot/dts/at91rm9200.dtsi | 4 ++--
1 file changed, 2
sign of confusion, so I lumped all
those fixes in one big patch.
One or two of the removed comments with duplicate info where wrong
as well, i.e. the info was supposed to be duplicate but wasn't.
Cheers,
Peter
Peter Rosin (3):
ARM: dts: at91: fixes uart pinctrl, set pullup on rx, clear p
On 2018-03-23 12:00, Boris Brezillon wrote:
> From: Boris Brezillon
>
> A new I3C subsystem has been added and a generic description has been
> created to represent the I3C bus and the devices connected on it.
>
> Document this generic representation.
>
> Signed-off-by: Boris Brezillon
> ---
>
On 2018-03-23 14:14, Jonathan Cameron wrote:
> On Mon, 19 Mar 2018 18:02:43 +0100
> Peter Rosin wrote:
>
>> Hi!
>>
>> This moves the iio-mux driver to a new category, since I think
>> it will be the single driver in that category forever, and now
>> I
On 2018-04-04 14:35, Peter Rosin wrote:
> On 2018-04-04 11:07, Laurent Pinchart wrote:
>> Hi Daniel,
>>
>> On Wednesday, 4 April 2018 09:34:41 EEST Daniel Vetter wrote:
>>> On Wed, Apr 4, 2018 at 12:28 AM, Laurent Pinchart wrote:
>>>> On Wednesday, 28 Ma
that).
Anyway, this series solves some real issues for my HW.
Cheers,
Peter
Peter Rosin (5):
dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185
dt-bindings: display: atmel: add optional output-mode property
drm/atmel-hlcdc: allow overriding the output mode
drm/atmel-hlcdc: ad
Useful for beating cases where an output mode selection heuristic
fails.
Signed-off-by: Peter Rosin
---
Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt
b
connector does not advertize and format at
all.
Signed-off-by: Peter Rosin
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 12 ++--
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 19 +++
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 8
3 files changed, 33
Start list of actual chips compatible with "lvds-encoder".
Reviewed-by: Laurent Pinchart
Signed-off-by: Peter Rosin
---
.../devicetree/bindings/display/bridge/lvds-transmitter.txt | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
a/Documentation/
When the of-graph points to a tda998x-compatible HDMI encoder, register
as a component master and bind to the encoder/connector provided by
the tda998x driver.
Signed-off-by: Peter Rosin
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 81 --
drivers/gpu/drm/atmel-hlcdc
Bump the minor version while at it.
Signed-off-by: Peter Rosin
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index b411038890a9
On 2018-04-08 18:50, Jonathan Cameron wrote:
> On Tue, 3 Apr 2018 17:36:34 +0200
> Peter Rosin wrote:
>
> circuit in the patch title is spelled wrong.
>
>> An ADC is often used to measure other quantities indirectly. These
>> bindings describe two cases, a current th
On 2018-04-09 13:17, Russell King - ARM Linux wrote:
> On Mon, Apr 09, 2018 at 12:59:13PM +0200, Peter Rosin wrote:
>> During this, I found that the tda998x driver never sets the format in
>> the connector display_info. Thus, the atmel-hlcdc driver fails to select
>> outpu
On 2018-04-09 14:02, Russell King - ARM Linux wrote:
> On Mon, Apr 09, 2018 at 01:44:22PM +0200, Peter Rosin wrote:
>> On 2018-04-09 13:17, Russell King - ARM Linux wrote:
>>> On Mon, Apr 09, 2018 at 12:59:13PM +0200, Peter Rosin wrote:
>>>> During this, I found that
On 2018-04-09 14:51, Laurent Pinchart wrote:
> Hi Peter,
>
> On Monday, 9 April 2018 10:04:05 EEST Peter Rosin wrote:
>> On 2018-04-04 14:35, Peter Rosin wrote:
>>> On 2018-04-04 11:07, Laurent Pinchart wrote:
>>>> On Wednesday, 4 April 2018 09:34:41 EEST Dani
writes to _RAW (sorry Phil) as I don't need it and have
not tested it. It's easy to add back if needed.
- Fail if the source channel does not support _RAW or _SCALE.
- Fix various spelling issues.
- Fix various code style issues.
Peter Rosin (2):
dt-bindings: iio: afe: add current-
An ADC is often used to measure other quantities indirectly. These
bindings describe two cases, a current through a shunt resistor, and
a "big" voltage measured with the help of a voltage divider.
Signed-off-by: Peter Rosin
---
.../bindings/iio/afe/current-sense-shunt.txt
the current through the
resistor.
This driver solves both problems by allowing to linearly scale a channel
and by allowing changes to the type of the channel. Or both.
Signed-off-by: Peter Rosin
---
MAINTAINERS | 1 +
drivers/iio/Kconfig | 1
On 2018-04-10 16:11, Wolfram Sang wrote:
> The number of I2C host controller drivers keeps increasing, and although
> I had some success acquiring specific driver maintainers, my bandwidth
> is by far not enough to act as a fallback for the rest of the drivers.
> To reflect this status-quo in MAINT
On 2018-04-10 17:52, Wolfram Sang wrote:
> Hi Peter,
>
>> Hmm, I think you are ducking out from the i2c-mux-pinctrl driver as well.
>> Was that the intent?
>
> Oops, nope! Sorry, I just forgot about the demux (I think you mean that
> one) driver and will create a seperate entry for it.
Right, I
Hi!
Here's an iio driver for Microchip MCP4018 potentiometers, that
also covers a few variants (MCP4017 and MCP4019).
I found no existing potentiometer driver with a compatible
interface to piggyback on, so I did a new driver.
Cheers,
Peter
Peter Rosin (2):
dt-bindings: trivial: add va
They come in 5 kOhm, 10 kOhm, 50 kOhm and 100 kOhm variations.
Signed-off-by: Peter Rosin
---
Documentation/devicetree/bindings/trivial-devices.txt | 12
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/trivial-devices.txt
b/Documentation/devicetree
Add support for Microchip digital potentiometers and rheostats
MCP4017, MCP4018, MCP4019
They all have one wiper with 128 steps and come in 5, 10, 50 and 100 kOhm
variations.
Datasheet: http://www.microchip.com/downloads/en/DeviceDoc/22147a.pdf
Signed-off-by: Peter Rosin
On 2018-09-26 13:57, Vignesh R wrote:
> AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
> handle AM654 SoCs.
>
> Signed-off-by: Vignesh R
> ---
> Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Docu
On 2018-11-23 13:10, Thierry Reding wrote:
> From: Thierry Reding
>
> The "at," prefix was never correct for Atmel, so fix the few occurrences
> that got it wrong. Use "atmel," instead.
Fully agreed. However, given that atmel,24c08 is documented in
.../eeprom/at24.txt
I think it would be better
instead.
>>
>> While at it, remove the at,24c08 compatible string from the list of
>> trivial devices because it is already documented in eeprom/at24.txt.
>>
>> Signed-off-by: Thierry Reding
>
> Peter, I'd assume you are okay with me applying the patch directly?
Absolutely, go ahead.
Acked-by: Peter Rosin
Cheers,
Peter
On 2018-11-18 12:13, Luca Ceresoli wrote:
> Hi Peter,
>
> On 10/10/18 17:48, Luca Ceresoli wrote:
>> Hi Peter,
>>
>> On 08/10/2018 23:43, Peter Rosin wrote:
>>> On 2018-10-03 17:19, Luca Ceresoli wrote:
>>>> From: Luca Ceresoli
>>>>
>
.
Signed-off-by: Peter Rosin
---
arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index 911d2c7c1500..0f6d335125e2 100644
--- a/arch/arm/boot/dts/at91-nattis
On 2018-12-06 10:45, Bartosz Golaszewski wrote:
> This is a follow-up to Thierry's patch which missed a few occurences.
>
> Cc: Thierry Reding
> Signed-off-by: Bartosz Golaszewski
Acked-by: Peter Rosin
Wolfram, you can take this one as well, of course.
Cheers,
Peter
>
On 2018-12-07 12:29, tudor.amba...@microchip.com wrote:
> From: "tudor.amba...@microchip.com"
>
> The clock-frequency property is not mandatory for the i2c buses. If it's
> not present in the device tree, the buses __usually__ assume it's 100kHZ
> (see altera, at91, axxia, etc.). Broadcom uses a
Hi!
This patch looks like a good idea. However, a nitpick below.
On 2018-12-01 11:01, Nicholas Mc Guire wrote:
> devm_kstrdup() may return NULL if internal allocation failed.
> Thus using name, value is unsafe without being checked. As
> i2c_demux_pinctrl_probe() can return -ENOMEM in other cas
On 2018-12-04 13:13, Nicholas Mc Guire wrote:
> On Tue, Dec 04, 2018 at 11:16:59AM +0000, Peter Rosin wrote:
>> Hi!
>>
>> This patch looks like a good idea. However, a nitpick below.
>>
>> On 2018-12-01 11:01, Nicholas Mc Guire wrote:
>>> devm_kstrdu
Ho hmm. Had another look at this patch, or rather, the context of the
patch so not really related, but...
On 2018-12-01 11:01, Nicholas Mc Guire wrote:
> devm_kstrdup() may return NULL if internal allocation failed.
> Thus using name, value is unsafe without being checked. As
> i2c_demux_pinctrl
On 2018-12-04 15:25, Nicholas Mc Guire wrote:
> On Tue, Dec 04, 2018 at 01:49:11PM +0000, Peter Rosin wrote:
>> On 2018-12-04 13:13, Nicholas Mc Guire wrote:
>>> On Tue, Dec 04, 2018 at 11:16:59AM +, Peter Rosin wrote:
>>>> Hi!
>>>>
>>>>
On 2018-12-04 15:36, Nicholas Mc Guire wrote:
> On Tue, Dec 04, 2018 at 02:11:33PM +0000, Peter Rosin wrote:
>> Ho hmm. Had another look at this patch, or rather, the context of the
>> patch so not really related, but...
>>
>> On 2018-12-01 11:01, Nicholas Mc Guire wr
On June 30, 2018 3:33:26 PM GMT+02:00, Manivannan Sadhasivam
wrote:
>Add I2C controller nodes for Actions Semiconductor S900 SoC.
>
>Signed-off-by: Manivannan Sadhasivam
>---
> arch/arm64/boot/dts/actions/s900.dtsi | 60 +++
> 1 file changed, 60 insertions(+)
>
>diff --git
On June 30, 2018 3:33:29 PM GMT+02:00, Manivannan Sadhasivam
wrote:
>Add Actions Semiconductor Owl family S900 I2C driver.
>
>Signed-off-by: Manivannan Sadhasivam
>---
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-owl.c | 477 +
On July 1, 2018 2:13:20 PM GMT+02:00, Wolfram Sang wrote:
>On Wed, Jun 27, 2018 at 09:08:18AM +0200, Wolfram Sang wrote:
>>
>> > Because, thinking more about it, the problem with those allocs are
>not
>> > related to the locking details; adding another trylock to the mix
>just
>> > makes it so mu
On 2018-07-07 11:29, Jun Gao wrote:
> From: Jun Gao
>
> This function is needed by i2c_get_dma_safe_msg_buf() potentially.
> It is used to free DMA safe buffer when DMA operation fails.
>
> Signed-off-by: Jun Gao
> ---
> drivers/i2c/i2c-core-base.c | 14 ++
> include/linux/i2c.h
On 2018-07-08 13:58, Peter Rosin wrote:
> On 2018-07-07 11:29, Jun Gao wrote:
>> From: Jun Gao
>>
>> This function is needed by i2c_get_dma_safe_msg_buf() potentially.
>> It is used to free DMA safe buffer when DMA operation fails.
>>
>> Signed-off-by: J
On June 26, 2018 4:37:58 AM GMT+02:00, Wolfram Sang wrote:
>
>> This is not perfectly equivalent, since i2c_smbus_xfer was callable
>from
>> atomic/irq context if you happened to end up emulating SMBus with an
>I2C
>> transfer, and that is no longer the case with this patch. It is
>unknown
>> (to
On June 26, 2018 3:46:07 PM GMT+02:00, Wolfram Sang wrote:
>> I don't think it's that easy as I just thought about another problem
>> with lifting the locking from the emulation function. It calls
>> kzalloc(..., GFP_KERNEL), at least in some cases, and that's not a
>> very good idea from atomic/i
On June 28, 2018 8:10:36 PM GMT+02:00, Manivannan Sadhasivam
wrote:
>This patchset adds I2C controller support for Actions Semi S900 SoC.
>This driver has been structured in a way such that there will be only
>one controller driver for the whole OWL family series (S500, S700 and
>S900 SoCs).
>
>T
On June 28, 2018 8:10:41 PM GMT+02:00, Manivannan Sadhasivam
wrote:
>Add Actions Semi OWL family S900 I2C driver.
>
>Signed-off-by: Manivannan Sadhasivam
>---
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-owl.c | 471 ++
On June 29, 2018 6:44:39 AM GMT+02:00, Manivannan Sadhasivam
wrote:
>Hi Peter,
>
>On Fri, Jun 29, 2018 at 06:13:31AM +0200, Peter Rosin wrote:
>> Hi!
>>
>> I don't know for sure, but over here the arch/arm64/boot/dts/actions
>folder has no pinctrl nodes a
On 2018-05-21 11:49, Julia Lawall wrote:
> Drop call to of_match_device, which is subsumed by the subsequent
> call to of_device_get_match_data. The code becomes simpler, and a
> temporary variable can be dropped.
Thanks for your patch!
Applied to i2c-mux/for-next
Cheers,
Peter
On 2018-02-01 17:24, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 1 Feb 2018 17:17:19 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Applied to i2
Cheers,
Peter
Peter Rosin (2):
rtmutex: allow specifying a subclass for nested locking
i2c: mux: annotate the nested rt_mutex usage
drivers/i2c/i2c-core-base.c | 2 +-
drivers/i2c/i2c-mux.c | 4 ++--
include/linux/rtmutex.h | 7 +++
kernel/locking/rtm
/0x70
my2c_init+0xa2/0x1000 [my2c]
do_one_initcall+0x51/0x192
do_init_module+0x62/0x216
load_module+0x20f9/0x2b50
SYSC_init_module+0x19a/0x1c0
SyS_init_module+0xe/0x10
do_syscall_64+0x6c/0x1a0
entry_SYSCALL_64_after_hwframe+0x42/0xb7
Reported-by: John Sperbeck
Signed-off-by: Peter
Needed for annotating rt_mutex locks.
Signed-off-by: Peter Rosin
---
include/linux/rtmutex.h | 7 +++
kernel/locking/rtmutex.c | 29 +
2 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/include/linux/rtmutex.h b/include/linux/rtmutex.h
index
On 2018-05-20 08:50, Wolfram Sang wrote:
> Since commit 1eace8344c02 ("i2c: add param sanity check to
> i2c_transfer()"), the I2C core does this check now. We can remove it
> from drivers.
Reviewed-by: Peter Rosin
>
> Signed-off-by: Wolfram Sang
> ---
>
> On
On 2018-05-20 08:50, Wolfram Sang wrote:
> Since commit 1eace8344c02 ("i2c: add param sanity check to
> i2c_transfer()") and b7f625840267 ("i2c: add quirk checks to core"), the
> I2C core does this check now. We can remove it here.
>
> Signed-off-by: Wolf
On 2018-05-25 16:51, Tudor Ambarus wrote:
> Hi, Peter,
>
> On 04/11/2018 06:34 PM, Nicolas Ferre wrote:
>> I'll try to move forward with your detailed explanation and with my
>> contacts within the "product" team internally.
>
> We have talked with the hardware team, looks like there is an error
On 2018-05-25 16:51, Tudor Ambarus wrote:
> We think the best way is to keep LCD on DDR Ports 2 and 3 (8th and 9th
> slaves), to have maximum bandwidth and to use DMA on DDR port 1 for NAND
> (7th slave).
Exactly how do I accomplish that?
I can see how I can move the LCD between slave DDR port 2
On 2018-05-27 11:18, Peter Rosin wrote:
> On 2018-05-25 16:51, Tudor Ambarus wrote:
>> We think the best way is to keep LCD on DDR Ports 2 and 3 (8th and 9th
>> slaves), to have maximum bandwidth and to use DMA on DDR port 1 for NAND
>> (7th slave).
>
> Exactly how d
On 2018-04-18 07:48, yos...@codeaurora.org wrote:
> On 2018-04-17 17:11, Peter Rosin wrote:
>> On 2018-04-17 15:52, Yossi Mansharoff wrote:
>>> On the db410c 96boards platform we have a TC7USB40MU on the board
>>> to mux the D+/D- lines coming from the controller betw
201 - 300 of 1862 matches
Mail list logo
