I have business proposition involving transfer that will be of great benefit
for both of us. I will give you more details as regards this transaction as
soon as you notify me of your interest.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
is running a number of tap devices. (It is a UML host server
running the skas patches http://www.user-mode-linux.org/~blaisorblade/).
Regards, Peter
# uname -r
2.6.11.7-skas3-v8
unregister_netdevice: waiting for tap24 to become free. Usage count = 1
unregister_netdevice: waiting for tap24 to
orted with older 2.6 kernels and a patch was
floating around. I'm not sure if that is integrated into the current
2.6.11 kernel.
http://www.google.com/search?q=unregister_netdevice%3A+waiting
Regards, Peter
Jul 10 16:52:03 host39 sshd(pam_unix)[19779]: authentication failure;
logname= u
I just tried 2.6.12.2 with skas-V8.2. The server (otherwise reliable),
had a kernel crash (which I was unable to capture) within a couple of
hours of boot up.
Regards, Peter
Blaisorblade wrote:
On Tuesday 12 July 2005 00:26, Peter wrote:
Nothing in the logs prior to the first error
ed.
You need either a block translation layer, or a (swap) filesystem that
understands flash peculiarities in order to make such a thing work.
The standard Linux swap format will not work.
--
Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au
weitere Details.
Mit freundlichen Grüßen,
Peter Wong
E-Mail: wwpon...@aol.jp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
e. As was discussed recently, there's several reasons
why the pinctrl call might fail, and not all are fatal (E.G. pinmux
already setup by bootloader):
http://article.gmane.org/gmane.linux.kernel/1399756
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe l
Use WARN() as intended.
Signed-off-by: Peter Hurley
---
drivers/staging/fwserial/dma_fifo.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/fwserial/dma_fifo.c
b/drivers/staging/fwserial/dma_fifo.c
index 72aa053..5e84634 100644
--- a/drivers/staging
On Mon, 2012-11-26 at 12:56 -0800, Randy Dunlap wrote:
> On 11/26/2012 06:17 AM, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20121115:
> >
>
>
> on i386:
>
> drivers/staging/fwserial/dma_fifo.c: In function 'dma_fifo_in':
> drivers/staging/fwserial/dma_fifo.c:174:2: error: imp
On Mon, 2012-11-26 at 15:20 -0800, Andrew Morton wrote:
> On Mon, 26 Nov 2012 12:56:07 -0800
> Randy Dunlap wrote:
>
> > On 11/26/2012 06:17 AM, Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Changes since 20121115:
> > >
> >
> >
> > on i386:
> >
> > drivers/staging/fwserial/dma_fifo
This driver only supported the Charging indicator LED.
New set of drivers going to provide support for both PWMs and LEDs for twl4030
and twl6030 series of PMICs.
Signed-off-by: Peter Ujfalusi
---
drivers/pwm/Kconfig | 9 ---
drivers/pwm/Makefile | 1 -
drivers/pwm/pwm-twl6030.c
twl6030 (PWM 1/2) instances
pwm-twl-led driver supports twl4030 (PWM driven LED A/B ports) and twl6030's
Charging indication LED (PWM driven).
Regards,
Peter
---
Peter Ujfalusi (3):
pwm: New driver to support PWMs on TWL4030/6030 series of PMICs
pwm: New driver to support PWM driven
.
When the PWM has been freed, the LED driver is put back to HW control.
Signed-off-by: Peter Ujfalusi
---
.../devicetree/bindings/pwm/ti,twl-pwmled.txt | 17 +
drivers/pwm/Kconfig| 9 +
drivers/pwm/Makefile | 1 +
drivers/pwm
.
Signed-off-by: Peter Ujfalusi
---
.../devicetree/bindings/pwm/ti,twl-pwm.txt | 17 +
drivers/pwm/Kconfig| 9 +
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-twl.c | 357 +
4
then we can reasonably assume that
Thierry> your second case can't happen, can't we?
Well, peripherals only need pinmuxing if the bootloader didn't already
set it up in advance. We could naturally enforce people to add
"redundant" pinmux info to their .dts files, but
t is freed.
> This patch does exactly that -- put tty_port_destroy at those places.
>
> Signed-off-by: Jiri Slaby
Hi Jiri & Greg & Alan,
I'd be more than willing to fixup staging/fwserial against this series
but I'm unclear on the mechanics since this series isn't in
On Tue, 2012-11-27 at 09:04 -0800, Greg Kroah-Hartman wrote:
> On Tue, Nov 27, 2012 at 11:52:09AM -0500, Peter Hurley wrote:
> > On Thu, 2012-11-15 at 09:49 +0100, Jiri Slaby wrote:
> > > After commit "TTY: move tty buffers to tty_port", the tty buffers are
> > &g
On Wed, 2012-11-14 at 02:25 +0100, Stefan Richter wrote:
> On Nov 13 Peter Hurley wrote:
> > On Tue, 2012-11-13 at 00:33 +0100, Stefan Richter wrote:
> > > On Nov 02 Peter Hurley wrote:
> > > > +2. MAX_ASYNC_PAYLOAD needs to be publicly exposed by core/ohci
> &g
r a while I'm also seeing these:
>
> [ 603.533932] tty is bad=-2 ops= (null)Pid: 37, comm: kworker/4:0
> Tainted: G W 3.7.0-rc3-next-20121102-sasha-000
> 02-gbb570e0-dirty #112
Hi Sasha,
Assuming this access-after-free is still reproducible for you, would
On Tue, 2012-11-27 at 10:42 -0800, Randy Dunlap wrote:
> On 11/26/2012 11:11 PM, Peter Hurley wrote:
>
> > Use WARN() as intended.
> >
> > Signed-off-by: Peter Hurley
>
>
> Reported-by: Randy Dunlap
> Acked-by: Randy Dunlap
>
> Thanks.
Hi Randy,
On Wed, 2012-11-28 at 00:58 +0100, Stefan Richter wrote:
> On Nov 27 Peter Hurley wrote:
> > > > Currently, firewire-net sets an arbitrary address handler length of
> > > > 4096. This works because the largest AR packet size the current
> > > > firewir
Hi Greg,
This patch series fixes up staging/fwserial to meet the new requirements
in Jiri Slaby's series "TTY: memory leaks patchset" (in tty-next).
Strictly speaking, only PATCH 1/3 implements the necessary cleanup.
PATCHES 2/3 & 3/3 are additional cleanups in the same are
For TTY drivers that manage the port lifetime, the tty_port should
to be specifically destructed when the port lifetime ends. Now that
a method has been added to do this, use it.
Signed-off-by: Peter Hurley
Cc: Jiri Slaby
Cc: Alan Cox
---
drivers/staging/fwserial/fwserial.c | 5 -
1 file
Signed-off-by: Peter Hurley
---
drivers/staging/fwserial/fwserial.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index 99a2d2d..0681967 100644
--- a/drivers/staging/fwserial/fwserial.c
Now that the dma fifo is allocated on activate and freed on
shutdown, this extra free is harmless but unnecessary.
Signed-off-by: Peter Hurley
---
drivers/staging/fwserial/fwserial.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging
Hi Grant, Lars, Thierry,
On 11/26/2012 04:46 PM, Grant Likely wrote:
> You're effectively asking the pwm layer to behave like a gpio (which
> is completely reasonable). Having a completely separate translation node
> really doesn't make sense because it is entirely a software construct.
> In fact,
and later
> > does a tasklet_schedule(), we do need clear the TASKLET_STATE_HI.
>
> That as well ;)
>
> > Also
> > we need to remove the tasklet_hi_enable() as it is the same as
> > tasklet_enable() and there's
> > only one user..
> >
> > I&#
[cc'ing linux-next]
On Wed, 2012-11-28 at 13:00 -0500, Peter Hurley wrote:
> Hi all,
>
> I couldn't find the v2 patch of this on linux-kernel but this commit
>
> 4660e32 "tasklet: ignore disabled tasklet in tasklet_action()"
>
> BUGS in
lease run .../scripts/checkpatch.pl -strict before submission - not
everything that is reported might be applicable, but quite often it is.
Looking forward to your v2 so I can give a more detailed code review of your
code.
Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubs
antic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 6bdf267..70d4ea5 100644
--- a/drivers/cha
antic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Peter Huewe
---
v2:
Removed/changed that silly itpm = (probe == 0) ? 0 : 1;
since probe is here either 0 or 1 -- thanks Al for noticing.
This section and the probing of the itpm can probably be improved anyway,
but I'll wrap
Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro:
> On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote:
> > - itpm = (probe == 0) ? 0 : 1;
> > + itpm = (probe == 0) ? false : true;
>
> Charming. Not that original had been better, bu
On 11/28/2012 08:30 PM, Thierry Reding wrote:
> I must say I'm not terribly thrilled to integrate something like this
> into the PWM subsystem.
I agree. I would not really want to add my name to something like this either...
> I wish hardware engineers wouldn't come up with such designs.
I have
antic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Peter Huewe
---
v3 for this tiny patch... shame on me.
drivers/char/tpm/tpm_tis.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 6b
; This !! isn't necessary as ints assigned to bool are converted
> > by the compiler to 0 or 1.
>
> Good to know, thanks Joe!
So v2 is fine.
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.ker
--
fundamentally, this technique is what flush_to_ldisc() does.
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, 2013-03-18 at 13:48 +0100, Stephane Eranian wrote:
> if (!rb->writable)
> - return true;
> + return false;
writable means user writable (VM_WRITE); the difference is that a
!VM_WRITE buffer will simply over-write its own tail whereas a VM_WRITE
buffer w
On Mon, 2013-03-18 at 14:03 +0100, Stephane Eranian wrote:
> On Mon, Mar 18, 2013 at 1:59 PM, Peter Zijlstra wrote:
> > On Mon, 2013-03-18 at 13:48 +0100, Stephane Eranian wrote:
> >> if (!rb->writable)
> >> - return true;
>
On Mon, 2013-03-18 at 16:59 -0700, Greg Kroah-Hartman wrote:
> On Mon, Mar 11, 2013 at 04:44:48PM -0400, Peter Hurley wrote:
> > Read lock recursion is no longer required for ldisc references;
> > remove mechanism.
> >
> > Signed-off-by: Peter Hurley
> > ---
&g
On Mon, 2013-03-18 at 17:05 -0700, Greg Kroah-Hartman wrote:
> On Mon, Mar 18, 2013 at 08:01:01PM -0400, Peter Hurley wrote:
> > On Mon, 2013-03-18 at 16:59 -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Mar 11, 2013 at 04:44:48PM -0400, Peter Hurley wrote:
> > > > Re
On Mon, 2013-03-18 at 16:58 -0700, Greg Kroah-Hartman wrote:
> On Mon, Mar 11, 2013 at 04:44:46PM -0400, Peter Hurley wrote:
> > The semantics of a rw semaphore are almost ideally suited
> > for tty line discipline lifetime management; multiple active
> > threads obtain &qu
On Mon, 2013-03-18 at 12:22 -0700, Tejun Heo wrote:
> try_to_wake_up_local() should only be invoked to wake up another task
> in the same runqueue and BUG_ON()s are used to enforce the rule.
> Missing try_to_wake_up_local() can stall workqueue execution but such
> stalls are likely to be finite eit
> are you going to include that, or should I repost it?
Ah, please repost (and prettify) it, I'm still very limited in the
amount of work that I can do :/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordo
On Mon, 2013-03-18 at 20:53 +0530, Viresh Kumar wrote:
> +/*
> + * This routine returns the nearest non-idle cpu. It accepts a
> bitwise OR of
> + * SD_* flags present in linux/sched.h. If the local CPU isn't idle,
> it is
> + * returned back. If it is idle, then we must look for another CPU
> whic
ecord can be saved and it will be gracefully
> handled
> by upper code layers.
>
> In v2, we also make the logic for the writable more explicit by
> renaming it to rb->overwrite because it tells whether or not the
> buffer can overwrite its tail (suggested by PeterZ).
>
> S
On Mon, 2013-03-18 at 14:46 +0100, Stephane Eranian wrote:
>
> This patch fixes an uninitialized pt_regs struct in drain BTS
> function. The pt_regs struct is propagated all the way to the
> code_get_segment() function from perf_instruction_pointer()
> and may get garbage.
>
> We cannot simply in
On Tue, 2013-03-19 at 13:50 +0100, Stephane Eranian wrote:
> > Should we not replace:
> >
> > regs.ip = 0;
> >
> > with that memset? It avoids the memset work in a few cases and
> removes
> > the then superfluous clearing of the IP field.
> >
> We could drop it because it's covered by t
oonsoo Kim
Acked-by: Peter Zijlstra
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, 2013-03-18 at 16:15 -0700, Greg Kroah-Hartman wrote:
> On Wed, Mar 06, 2013 at 08:38:22AM -0500, Peter Hurley wrote:
> > minimum_to_wake is unique to N_TTY processing, and belongs in
> > per-ldisc data.
> >
> > Add the ldisc method, ldisc_ops::fasync(), to notif
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> After commit 88b8dac0, dst-cpu can be changed in load_balance(),
> then we can't know cpu_idle_type of dst-cpu when load_balance()
> return positive. So, add explicit cpu_idle_type checking.
No real objection I suppose, but did you actually s
#x27;t
> consider other cpus. Assigning to 'this_rq->idle_stamp' is now valid.
>
> Cc: Srivatsa Vaddagiri
> Signed-off-by: Joonsoo Kim
Fair enough, good catch.
Acked-by: Peter Zijlstra
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 0c6aaf
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 3fd657b..b2f621f 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -1814,20 +1814,16 @@ do_it_again
of the
available buffer space, and the subsequent work loop will likely
overwrite unread data in the input buffer.
Update receive_room atomically with the calculation of the
available buffer space.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 18 +++---
1 file changed, 11 inse
Although the driver-side input path must update the available
buffer space, it should not reschedule itself. If space is still
available and the flip buffers are not empty, flush_to_ldisc()
will loop again.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 13 +
1 file changed
readable input. When disabled, blocking reader/polls are not
woken until the read buffer is full.
Canonical mode (L_ICANON(tty), n_tty_data::icanon) is not affected by
the minimum_to_wake setting.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 39
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> Some validation for task moving is performed in move_tasks() and
> move_one_task(). We can move these code to can_migrate_task()
> which is already exist for this purpose.
> @@ -4011,18 +4027,7 @@ static int move_tasks(struct lb_env *env)
>
On Tue, 2013-03-19 at 10:35 -0400, Steven Rostedt wrote:
> What about:
> int err = 0;
>
> err += tracing_data_header();
> err += read_header_files();
> [...]
>
> if (err < 0) {
> free(tdata);
> tdata = NULL;
> }
>
>
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> This name doesn't represent specific meaning.
> So rename it to imply it's purpose.
>
> Signed-off-by: Joonsoo Kim
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 26058d0..e6f8783 100644
> --- a/kernel/sched/core.c
> +++
On Tue, 2013-03-19 at 10:59 -0400, Steven Rostedt wrote:
> On Tue, 2013-03-19 at 15:49 +0100, Peter Zijlstra wrote:
> > On Tue, 2013-03-19 at 10:35 -0400, Steven Rostedt wrote:
> > > What about:
> > > int err = 0;
> > >
> > > er
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> Commit 88b8dac0 makes load_balance() consider other cpus in its group.
> But, in that, there is no code for preventing to re-select dst-cpu.
> So, same dst-cpu can be selected over and over.
>
> This patch add functionality to load_balance()
l panic - not syncing: Fatal exception in interrupt
[ 44.064933] drm_kms_helper: panic occurred, switching back to text console
[ 44.064933] [ cut here ]
[ 44.064933] WARNING: at /home/peter/src/kernels/mainline/drivers/gpu/drm/drm_crtc.c:82 drm_warn_on_modeset_not_all_lo
On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> Commit 88b8dac0 makes load_balance() consider other cpus in its group.
> So, now, When we redo in load_balance(), we should reset some fields of
> lb_env to ensure that load_balance() works for initial cpu, not for other
> cpus in its group. S
On Mon, 2013-03-18 at 18:59 -0700, Greg Kroah-Hartman wrote:
> On Mon, Mar 18, 2013 at 09:01:19PM -0400, Peter Hurley wrote:
> > On Mon, 2013-03-18 at 16:58 -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Mar 11, 2013 at 04:44:46PM -0400, Peter Hurley wrote:
> > > >
Rename o_ldisc to avoid confusion with the ldisc of the
'other' tty.
Signed-off-by: Peter Hurley
---
drivers/tty/tty_ldisc.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index a150f95..9ace119 10
Signed-off-by: Peter Hurley
---
drivers/tty/tty_ldisc.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index 9725c94..ba49c0e 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c
Just as the tty pair must be locked in a stable sequence
(ie, independent of which is consider the 'other' tty), so must
the ldisc pair be locked in a stable sequence as well.
Signed-off-by: Peter Hurley
---
drivers/tty/tty_ldisc.c | 87 +++
chanism
3) lock order wrt. tty_lock()
4) dropping locks while changing ldisc
5) previously unidentified deadlock while locking ldisc from
both linked ttys concurrently
6) previously unidentified recursive deadlocks
Adds much-needed lockdep diagnostics.
Signed-off-by: Peter Hurley
---
d
e existing read
waits and prevent further read locks.
Wait timeouts are trivially added, but obviously change the lock
semantics as lock attempts can fail (but only due to timeout).
This implementation incorporates the write-lock stealing work of
Michel Lespinasse .
Cc: Michel Lespinasse
Signed-off
The hangup may already have happened; check for that state also.
Signed-off-by: Peter Hurley
---
drivers/tty/tty_ldisc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index 9ace119..84ba790 100644
--- a/drivers/tty
he semaphore-related patches of that set have been squashed into the
first patch.
Sasha and Dave,
Please don't run the 44-patch ldisc patchset anymore. That patchset
was only partially applied so trinity testing for linux-next may
give false assurance that those bugs are fixed.
Peter Hur
Signed-off-by: Peter Hurley
---
drivers/tty/tty_ldisc.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index 84ba790..9725c94 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c
@@ -567,13 +567,15
Ldisc interface functions must be called with interrupts enabled.
Separating the ldisc calls into a helper function simplies the
spin lock management.
Update the buffer's read index _after_ the data has been received
by the ldisc.
Signed-off-by: Peter Hurley
---
drivers/tty/tty_buffer.c
if receive_room() is 0).
Add n_tty_receive_room() as the receive_room() method for N_TTY
and remove tty->receive_room references in N_TTY.
Line disciplines not using input flow control can continue to set
tty->receive_room to a fixed value.
Signed-off-by: Peter Hurley
---
drivers/tt
tty_set_ldisc() is guaranteed exclusive use of the line discipline
by tty_ldisc_lock_pair_timeout(); shutting off input by resetting
receive_room is unnecessary.
Signed-off-by: Peter Hurley
---
drivers/tty/tty_ldisc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c
N_TTY .chars_in_buffer() method requires serialized access if
the current thread is not the single-consumer, n_tty_read().
Separate the internal interface; prepare for lockless read-side.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 11 ---
1 file changed, 8 insertions(+), 3
[ adding Ben Skeggs and Dave Airlie ]
On Tue, 2013-03-19 at 21:24 +0100, Borislav Petkov wrote:
> On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote:
> > Dropping Tegra ML, it's not the place where Nouveau mails should go.
> > Adding Nouveau ML and Maarten, who probably knows Lockdep+Nouv
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 9d7badc..68445c7 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -1471,26
).
However, the actual count was irrelevent; only whether it was
non-zero (meaning 'is there any input to transfer?'). This
shared count is unnecessary and unsafe with a lockless algorithm.
The same check is made by comparing canon_head with read_tail instead.
Signed-off-by: Pe
character as a special character.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index b1b934c..9d7badc 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -1577,6 +1577,7 @@ static void
If the read buffer indices are in the same cache-line, cpus will
contended over the cache-line (so called 'false sharing').
Separate the producer-published fields from the consumer-published
fields; document the locks relevant to each field.
Signed-off-by: Peter Hurley
---
drivers/t
Storing the read_cnt creates an unnecessary shared variable
between the single-producer (n_tty_receive_buf()) and the
single-consumer (n_tty_read()).
Compute read_cnt from head & tail instead of storing.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 15 ++-
1 file cha
User-space read() can run concurrently with receiving from device;
waiting for receive_buf() to complete is not required.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 68445c7..adccff8
termios is commonly accessed unsafely (especially by N_TTY)
because the existing mutex forces exclusive access.
Convert existing usage.
Signed-off-by: Peter Hurley
---
drivers/net/irda/irtty-sir.c | 8 ++--
drivers/tty/n_tty.c | 2 +-
drivers/tty/pty.c| 4 +-
drivers/tty
guarantee
safe access to the termios and for mutual exclusion).
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 35 ++-
1 file changed, 30 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index fa463a9..985e0a3 100644
--- a
other than consumer or producer
(eg., TIOCINQ ioctl).
Note the read_tail is published _after_ clearing the newline
indicator in read_flags to avoid racing the producer.
Drop read_lock spinlock.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 178
).
Greg,
Unfortunately, this series is dependent on the 'ldsem patchset'.
The reason is that this series abandons tty->receive_room as
a flow control mechanism (because that requires locking),
and the TIOCSETD ioctl _without ldsem_ uses tty->receive_room
to shutoff i/o.
Peter Hurley
Instead of pushing one char per loop, pre-compute the data length
to copy and copy all at once.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 110
1 file changed, 77 insertions(+), 33 deletions(-)
diff --git a/drivers/tty/n_tty.c b
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 51b08d9..446674e 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -319,6 +319,7 @@ static ssize_t chars_in_buffer(struct
Simplify n_tty_read(); extract complex copy algorithm
into separate function, canon_copy_to_user().
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 95 -
1 file changed, 57 insertions(+), 38 deletions(-)
diff --git a/drivers/tty/n_tty.c
Prepare for replacing read_cnt field with computed value.
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 41 +++--
1 file changed, 23 insertions(+), 18 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 446674e..26a4514 100644
Wrap read_buf indices (read_head, read_tail, canon_head) at
max representable value, instead of at the N_TTY_BUF_SIZE. This step
is necessary to allow lockless reads of these shared variables
(by updating the variables atomically).
Signed-off-by: Peter Hurley
---
drivers/tty/n_tty.c | 111
On Wed, 2013-03-20 at 02:42 +0400, Ilya Zykov wrote:
> On 20.03.2013 0:21, Peter Hurley wrote:
> > Ldisc interface functions must be called with interrupts enabled.
> > Separating the ldisc calls into a helper function simplies the
> > spin lock management.
> >
> &g
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
> > Right, so I'm not so taken with this one. The whole load stuff really
> > is a balance heuristic that's part of move_tasks(), move_one_task()
> > really doesn't care about that.
> >
> > So why did you include it? Purely so you didn't have
On Wed, 2013-03-20 at 16:33 +0900, Joonsoo Kim wrote:
> > Right, so I'm not so taken with this one. The whole load stuff really
> > is a balance heuristic that's part of move_tasks(), move_one_task()
> > really doesn't care about that.
> >
> > So why did you include it? Purely so you didn't have
On Wed, 2013-03-20 at 12:16 +0100, Peter Zijlstra wrote:
> > If your recommandation is to move up can_mirate_task() above
> > load evaluation code, yes, I can, and will do that. :)
>
> I would actually propose
... to move the throttled test into can_migrate_task().
(damn
On Wed, 2013-03-20 at 16:43 +0900, Joonsoo Kim wrote:
> On Tue, Mar 19, 2013 at 04:05:46PM +0100, Peter Zijlstra wrote:
> > On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> > > Commit 88b8dac0 makes load_balance() consider other cpus in its group.
> > > But, in
>> Signed-off-by: Philip Avinash
>> ---
>> Changes since v1:
>> - Reusing ti,am33xx as compatible field as both IP's are
>> same with am33xx platform and da850 has no platform specific
>> dependency.
Sekhar> Which is fine, but I think the binding documentat
by testing for
a pending flush _after_ each receive_buf(), since TTYP_FLUSHPENDING
can only be set while the lock is dropped around receive_buf().
Reported-by: Ilya Zykov
Signed-off-by: Peter Hurley
---
drivers/tty/tty_buffer.c | 22 ++
1 file changed, 10 insertions(+
is of potential
dependencies to avoid creating problems. The drivers that use work items
might need examination as well.
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
e/api/devm_request_and_ioremap.cocci.
Signed-off-by: Peter Huewe
---
drivers/i2c/busses/i2c-mxs.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index d6abaf2..4ca92b6 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/b
1 - 100 of 39329 matches
Mail list logo
