usbnet/rndis (was: Is this bug too obvious?)

2007-02-16 Thread Pete Zaitcev
On Tue, 13 Feb 2007 20:13:06 -0500, Chuck Ebbert <[EMAIL PROTECTED]> wrote: > OK I'll keep looking for the cause of the oops then: > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228231 > Feb 12 01:11:29 MyComputer kernel: ohci_hcd :00:02.1: auto-wakeup > Feb 12 01:11:30 MyComputer

Re: [PATCH] Fix USB Mon breakage

2007-02-20 Thread Pete Zaitcev
On Tue, 20 Feb 2007 16:15:41 +, Russell King <[EMAIL PROTECTED]> wrote: > Never call __exit code from __init code - it causes errors such as: Oh heh, just saw this now. > Signed-off-by: Russell King <[EMAIL PROTECTED]> I ack this. Greg, please either apply Dobriyan's patch, or this one, the

Re: Juju

2007-01-25 Thread Pete Zaitcev
On Fri, 26 Jan 2007 03:35:19 +0100, Stefan Richter <[EMAIL PROTECTED]> wrote: > The fundamental thing about SBP-2 is that ORBs ( = SCSI command blocks > plus SBP-2 header) and data buffers all reside in the memory of the > initiator (or of a 3rd party on the FireWire bus). I recognize the concept

Re: Juju

2007-01-28 Thread Pete Zaitcev
On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: > Indeed, I've just moved to an in-tree development model now. I still think > the out-off-tree model is a good way to prototype, get started and reach > "critical mass" with your driver. But as I'm starting to in

Re: Juju

2007-01-29 Thread Pete Zaitcev
On Mon, 29 Jan 2007 14:53:28 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: > >>git://people.freedesktop.org/~krh/linux-2.6 > > > > This seems to have disappeared. Was it moved or dropped? > > No, it's still there, and I just did a git clone on it. How does it fail for > you? Oh neve

Re: [OHCI] BIOS handoff failed (BIOS bug?)

2006-12-01 Thread Pete Zaitcev
On Fri, 1 Dec 2006 19:28:55 +0100, Sebastian Kemper <[EMAIL PROTECTED]> wrote: > I also increased the wait time from 5 seconds to 20 in > drivers/usb/host/pci-quirks.c but that didn't change anything. That was a good try, but I thought maybe it needs doing something twice, or having some extra bi

Re: [OHCI] BIOS handoff failed (BIOS bug?)

2006-12-01 Thread Pete Zaitcev
On Fri, 1 Dec 2006 15:23:39 -0800, [EMAIL PROTECTED] wrote: > BIOS handoff assumes an SMI, right? Could SMI be masked? That might be a bad idea, because things like fans may be controlled by SMM BIOS. The best thing we can do is to follow the published procedure, and maybe insert a workaround if

Re: [PATCH 2/3] Import fw-ohci driver.

2006-12-04 Thread Pete Zaitcev
On Tue, 05 Dec 2006 00:22:45 -0500, "Kristian Høgsberg" <[EMAIL PROTECTED]> wrote: Your wonderful crossed-o might be ok here (or it would've been if only your mailer worked -- notice that the name is right in the "On" tag line above): > Signed-off-by: Kristian Høgsberg <[EMAIL PROTECTED]> > ---

Re: single bit errors on files stored on USB-HDDs via USB2/usb_storage

2006-12-07 Thread Pete Zaitcev
On Thu, 07 Dec 2006 20:41:12 +0100, Matthias Schniedermeyer <[EMAIL PROTECTED]> wrote: > >>I'm using a Bunch auf HDDs in USB-Enclosures for storing files. > >>(currently 38 HDD, with a total capacity of 9,5 TB of which 8,5 TB is used) > >>[] > >>This time i kept the defective files and used "

Re: [PATCH] connector: Some fixes for ia64 unaligned access errors

2006-12-08 Thread Pete Zaitcev
On Thu, 7 Dec 2006 17:22:13 -0600, Erik Jacobson <[EMAIL PROTECTED]> wrote: > Here, we just adjust how the variables are declared and use memcopy to > avoid the error messages. > - ev->timestamp_ns = timespec_to_ns(&ts); > + ev.timestamp_ns = timespec_to_ns(&ts); Please try to declare u64

Re: 2.6.19-git libusual: modprobe for usb-storage succeeded, but module is not present

2006-12-08 Thread Pete Zaitcev
On Fri, 08 Dec 2006 19:08:29 -0600, [EMAIL PROTECTED] wrote: > usb 2-2: new high speed USB device using ehci_hcd and address 3 > usb 2-2: configuration #1 chosen from 1 choice > libusual: modprobe for usb-storage succeeded, but module is not present > usb 2-4: new high speed USB device using ehci_

Re: [PATCH] connector: Some fixes for ia64 unaligned access errors

2006-12-09 Thread Pete Zaitcev
On Sat, 9 Dec 2006 15:09:13 -0600, Erik Jacobson <[EMAIL PROTECTED]> wrote: > > Please try to declare u64 timestamp_ns, then copy it into the *ev > > instead of copying whole *ev. This ought to fix the problem if > > buffer[] ends aligned to 32 bits or better. > > So I took this suggestion for a

Re: [PATCH] connector: Some fixes for ia64 unaligned access errors

2006-12-11 Thread Pete Zaitcev
On Mon, 11 Dec 2006 15:52:47 -0800, Matt Helsley <[EMAIL PROTECTED]> wrote: > I'm shocked memcpy() introduces 8-byte stores that violate architecture > alignment rules. Is there any chance this a bug in ia64's memcpy() > implementation? I've tried to read it but since I'm not familiar with >

Weird code in scripts/kconfig/Makefile

2006-12-12 Thread Pete Zaitcev
Hi, Roman & All: In 2.6.19 (and Linus' curent tree), I found the following: libpath=$$dir/lib; lib=qt; osdir=""; \ $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \ osdir=x$$($(HOSTCXX) -print-multi-os-directory); \ test -d $$libpath/$$osdir && l

Re: 2.6.18.5 usb/sysfs bug.

2006-12-15 Thread Pete Zaitcev
On Fri, 15 Dec 2006 16:37:15 -0500, Dave Jones <[EMAIL PROTECTED]> wrote: > Linux version 2.6.18-1.2864.fc6 ([EMAIL PROTECTED]) (gcc version 4.1.1 > 20061011 (Red Hat 4.1.1-30)) #1 SMP Fri Dec 15 13:14:58 EST 2006 > Kernel command line: ro root=/dev/VolGroup00/LogVol00 profile=1 vga=791 > audit(

Re: Looking for recent lkml email

2006-11-16 Thread Pete Zaitcev
On Fri, 17 Nov 2006 01:18:10 + (UTC), Oleg Verych <[EMAIL PROTECTED]> wrote: > To do not produce megabytes of additional traffic in case of any > kind of backlog and have anything you lkml like, i would suggest to have > good news reader and point it to news.gmane.org service (well, i'm > sure

Re: newsreaders (Re: Looking for recent lkml email)

2006-11-16 Thread Pete Zaitcev
On Fri, 17 Nov 2006 07:28:48 +, Oleg Verych <[EMAIL PROTECTED]> wrote: > BTW. On you web site i've read historical lkml messages, like Linus' > moving from Transmeta, and i saw, that you had news<->lkml bridge. I'm fed up with it and moving to gmane because our sysadmin refuses to stop mangli

Re: mass-storage problems with Archos AV500

2006-12-01 Thread Pete Zaitcev
On Wed, 29 Nov 2006 22:47:36 +0100, David Weinehall <[EMAIL PROTECTED]> wrote: > I've got an Archos AV500 here (running the very latest firmware), pretty > much acting as a doorstop, since I cannot get it to be recognized > properly by Linux. >[...] > [ 118.144000] SCSI device sdb: 58074975 512-b

USB: Take over usblp

2007-06-21 Thread Pete Zaitcev
Vojtech agreed to pass usblp over to me, so if you find bugs don't bug him. Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> Signed-off-by: Vojtech Pavlik <[EMAIL PROTECTED]> --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3702,12 +3702,12 @@ L: [EMAIL PROTECTED] W:

Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

2007-05-30 Thread Pete Zaitcev
On Wed, 30 May 2007 10:47:52 +0200, Matthias Kaehlcke <[EMAIL PROTECTED]> wrote: > @@ -1608,8 +1605,7 @@ static void ub_reset_task(struct work_struct *work) > spin_lock_irqsave(sc->lock, flags); > sc->reset = 0; > tasklet_schedule(&sc->tasklet); > - list_for_each(p, &sc->luns

Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

2007-05-30 Thread Pete Zaitcev
On Thu, 31 May 2007 02:44:17 +0530, "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > > > - list_for_each(p, &sc->luns) { > > > - lun = list_entry(p, struct ub_lun, link); > > > + list_for_each_entry(lun, &sc->luns, link) { > > This patch straddles the border of acceptable. The poi

Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

2007-05-30 Thread Pete Zaitcev
On Wed, 30 May 2007 16:14:01 -0700, Roland Dreier <[EMAIL PROTECTED]> wrote: > > The negative is the sheer number of helper functions in list.h. Personally, > > I find it difficult to retain a working knowledge of them. Iterators are > > particularly nasty that way. I'm thinking about dropping

Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

2007-05-30 Thread Pete Zaitcev
On Wed, 30 May 2007 16:42:41 -0700, Roland Dreier <[EMAIL PROTECTED]> wrote: > If I just see > > for (pos = list_entry((head)->next, typeof(*pos), member), > n = list_entry(pos->member.next, typeof(*pos), member); >&pos->member != (head); >pos = n, n =

Re: Andi, you broke my laptop :-)

2007-05-10 Thread Pete Zaitcev
On Thu, 10 May 2007 15:35:56 +0200, "Joerg Roedel" <[EMAIL PROTECTED]> wrote: > I debugged this problem a bit and my compiler[1]interprets the =A > constraint as %rax instead of %edx:%eax on x86_64 which causes the > problem. The appended patch provides a workaround for this and fixed the > hang o

Re: [PATCH 8/8] One Laptop Per Child power/battery driver

2007-05-12 Thread Pete Zaitcev
On Tue, 08 May 2007 18:52:31 +0100, David Woodhouse <[EMAIL PROTECTED]> wrote: > On Tue, 2007-05-08 at 18:45 +0100, Maciej W. Rozycki wrote: > > Well, my name has an acute above "o" and a dot above "z", but I do not > > have such a high expectation as to have it correctly spelled in comments >

Re: [PATCH 8/8] One Laptop Per Child power/battery driver

2007-05-12 Thread Pete Zaitcev
On Mon, 7 May 2007 22:23:11 +0100, Alan Cox <[EMAIL PROTECTED]> wrote: > We had this discussion before. Kernel sources should use utf-8 for > comments where neccessary. Many names cannot be correctly represented in > US ascii, and mangling them is just plain rude. I have to disagree here. It is u

Re: [PATCH 8/8] One Laptop Per Child power/battery driver

2007-05-12 Thread Pete Zaitcev
On Sun, 13 May 2007 13:39:48 +0800, David Woodhouse <[EMAIL PROTECTED]> wrote: > Please don't use my work email address unless I _really_ need to be > wearing my tinfoil hat when I read it. I'll keep it in mind, sorry. > But we'd be wrong -- just as you are. SPF is utterly moronic because it > s

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Pete Zaitcev
On Sun, 13 May 2007 18:20:53 +0100, Matthew Garrett <[EMAIL PROTECTED]> wrote: > +static void atp_reinit(struct work_struct *work) > +{ > + char data[8]; > + size = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > +ATP_GEYSER3_MODE_READ_REQUEST_ID, > +

Re: [PATCH] Make appletouch shut up when it has nothing to say

2007-05-13 Thread Pete Zaitcev
On Sun, 13 May 2007 20:57:25 +0100, Matthew Garrett <[EMAIL PROTECTED]> wrote: > Ok, I've tidied this up a little. [...] Looks fine here... well, almost. Did you try rmmod (I don't even know if it's applicable, sorry)? Usually, when schedule_work is involved, you want to make sure that a schedule

Re: [PATCH] usb-storage: Add support for unusual device by Sierra Wireless

2007-05-14 Thread Pete Zaitcev
On Mon, 14 May 2007 14:44:49 -0700, Kevin Lloyd <[EMAIL PROTECTED]> wrote: > + schedule_timeout_uninterruptible(delay_t*HZ); > + retval = sierra_ms_change_mode(us, SWIMS_SET_MODE_Modem); > + if (retval == -ETIMEDOUT || retval == -ETIME) { > +

Re: blank filenames in /sys/modules, kernel 2.6.21

2007-06-08 Thread Pete Zaitcev
On Fri, 8 Jun 2007 11:32:32 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > > and from drivers/usb/core/usb.c: > > > > /* format to disable USB on kernel command line is: nousb */ > > __module_param_call("", nousb, param_set_bool, param_get_bool, &nousb, > > 0444); > Pete added that back in Decem

Re: usb_fill_bulk_urb() broken for USB1.1?

2007-06-26 Thread Pete Zaitcev
On Tue, 26 Jun 2007 13:52:41 -0400, Chuck Ebbert <[EMAIL PROTECTED]> wrote: > On 06/26/2007 10:20 AM, Keith Chew wrote: > [cc: linux-usb-devel] > > > We have been using a Zydas based WIFI drivers under kernel 2.6.16.18 > > with great success. Recently, when we upgraded to 2.6.20.1 (also > > teste

Re: [Patch] Off by one in floppy.c

2007-05-21 Thread Pete Zaitcev
On Tue, 22 May 2007 00:57:56 +0200, Eric Sesterhenn / Snakebyte <[EMAIL PROTECTED]> wrote: > http://marc.info/?l=linux-kernel&m=115144559823592&w=2 Shows how much we care about floppy... It's going to be a year old soon. > +++ linux-2.6/drivers/block/floppy.c 2007-05-22 00:54:18.0 +020

Re: Fix locking in mousedev

2007-03-09 Thread Pete Zaitcev
On Fri, 9 Mar 2007 09:28:49 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > On 2/28/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > Dmitry, please consider getting rid of the list of handles entirely. > > The other major user is drivers/char/keyboard.c.

Re: [PATCH] usb bulk transfer: 1024 byte packets

2007-04-13 Thread Pete Zaitcev
On Fri, 13 Apr 2007 12:56:47 -0400, "Jeremy C. Andrus" <[EMAIL PROTECTED]> wrote: > I recently ran into a couple of USB devices which insisted on using 1024 > byte packets in bulk transfer mode (despite the hard limit of 512 > established in the spec). I really wanted to use these devices, so I

Re: [PATCH] usb bulk transfer: 1024 byte packets

2007-04-14 Thread Pete Zaitcev
On Sat, 14 Apr 2007 09:14:25 -0400 (EDT), "Jeremy C. Andrus" <[EMAIL PROTECTED]> wrote: > On Fri, April 13, 2007 22:16, Pete Zaitcev wrote: > > The transfer size in the URB is not limited by the maximum packet > > size. The HC driver splits up the transfer a

Andi, you broke my laptop :-)

2007-05-09 Thread Pete Zaitcev
Hi, Andi: The attached patch (actually, git show output) makes my Dell 1501 to hang on boot. Sorry, I have no clue why... The culprit is found with git bisect. But yes, it's an AMD MK-36. I use an x86_64 kernel. It is 100% reproducible. Cheers, -- Pete commit c5bcb5635a03da3158f121ae20ccbbf72b4f

BSOD (was: [2/6] 2.6.21-rc2: known regressions)

2007-03-19 Thread Pete Zaitcev
On Sun, 18 Mar 2007 12:40:45 -0400, Jim Gettys <[EMAIL PROTECTED]> wrote: > Also more seriously, a somewhat hybrid approach is in order for mode > setting: simple mode setting isn't much code and is required for sane > behavior on crash (it is nice to get oopses onto a screen); but the full > blow

Re: chrdev_open lifetime question

2007-03-19 Thread Pete Zaitcev
On Wed, 7 Mar 2007 17:23:05 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > It seems that if a process keeps a character device open then other > processes will also be able to get into filp->f_op->open(inode,filp) > in chrdev_open() even after a driver called cdev_del() as part of its > unw

Re: possible USB regression with 2.6.21-rc4: iPod doesn't work

2007-03-22 Thread Pete Zaitcev
On Thu, 22 Mar 2007 17:56:13 -0400, Chuck Ebbert <[EMAIL PROTECTED]> wrote: > >>> _Something_ is generating those overcurrent > >>> warnings, and it sure looks like a hardware malfunction. > >> But it works with 2.6.20. > Generation 1 iPod Shuffle is notorious for high current draw. > You s

Fix sudden warps in mousedev

2007-03-23 Thread Pete Zaitcev
243.356237, type 3 (Absolute), code 1 (Y), value 1987 <- warp here, by the difference of 3687 and 1987, plus some small frac_dy value. Easily jumps half the screen. Event: time 1174703243.356246, -- Report Sync Signed-off-by: Pete Zaitcev

Re: Fix sudden warps in mousedev

2007-03-25 Thread Pete Zaitcev
On Sun, 25 Mar 2007 01:34:02 -0400, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > +    * Without this, a touchpad may report an unchanged > > position, > > +    * then a sync. The input_event() eats the position report, > > but > > +    * lets the sync throug

Re: usb hid: reset NumLock

2007-04-05 Thread Pete Zaitcev
On a certain keyboard, when BIOS sets NumLock LED on, it survives the takeover by Linux and thus confuses users. Eating of an increasibly scarce quirk bit is unfortunate. We do it for safety, given the history of nervous input devices which crash if anything unusual happens. Signed-off-by: Pete

Re: usb hid: reset NumLock

2007-04-05 Thread Pete Zaitcev
On Thu, 5 Apr 2007 16:54:17 -0400, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > > On a certain keyboard, when BIOS sets NumLock LED on, it survives the > > takeover > > by Linux and thus confuses users. > > > > Eating of an increasibly scarce quirk bit is unfortunate. We do it for > > safety,

One odd thing about Synaptics

2007-04-11 Thread Pete Zaitcev
Hi, Peter: There's one thing I wanted to report, just in case... It does not affect anything, but it's odd. Every time I lift a finger from the pad, the driver sends an event with odd values (X is 1 and Y is 5855): Event: time 1174695694.561806, type 1 (Key), code 330 (Touch), value 0 Event: tim

Re: [linux-usb-devel] khubd and ent:sda1 sucking CPU with reiser4 + USB HD

2007-03-07 Thread Pete Zaitcev
On Wed, 7 Mar 2007 17:18:29 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > I've never heard of a process failing to show up in a SysRq-t listing. It > suggests something is wrong with the process management in the kernel you > were using. That leads me to think a non -mm kernel might giv

Re: Fix sudden warps in mousedev

2007-03-26 Thread Pete Zaitcev
On Sun, 25 Mar 2007 23:19:38 -0400, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > I tried to reproduce warping on console but could not for some reason. Could > you > please try the patch below and tell me if it fixes the problem for you? > +++ work/drivers/input/mousedev.c > @@ -124,32 +124,33 @

Re: [PATCH] USB Elan FTDI: check for driver registration status

2007-03-26 Thread Pete Zaitcev
On Sun, 25 Mar 2007 11:27:33 +0400, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > This patch adds checking of driver registration status > and if it fails release allocated resources. > + if (status_queue) { > + destroy_workqueue(status_queue); > + status_queue = NULL;

Re: Fix sudden warps in mousedev

2007-03-26 Thread Pete Zaitcev
On Mon, 26 Mar 2007 15:30:42 -0400, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > Regarding the synaptics driver and scroll problem. Yesterday I > scrolled twice through entire Remarque's "Spark of Life" off lib.ru > (once with 0.14.2 and once with latest git pull) and did not see any > scrollbar

Re: [PATCH] USB Elan FTDI: check for driver registration status

2007-03-27 Thread Pete Zaitcev
On Tue, 27 Mar 2007 19:14:05 +0400, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > --- a/drivers/usb/misc/ftdi-elan.c > @@ -2903,7 +2903,7 @@ static struct usb_driver ftdi_elan_driver = { > }; > static int __init ftdi_elan_init(void) > { > -int result; > +int result = 0; Why do y

Re: USB: on suspend to ram/disk all usb devices are replugged

2007-03-27 Thread Pete Zaitcev
it's going to send an "add" right > after. Instead it should enumerate the bus on resume and only send the events > that represents how to get from the previous device tree to the current one. > From Pete Zaitcev > What does happen if a user suspends, unplugs a USB key,

Re: [PATCH] USB Elan FTDI: check for driver registration status

2007-03-28 Thread Pete Zaitcev
On Wed, 28 Mar 2007 20:00:32 +0400, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > result = usb_register(&ftdi_elan_driver); > -if (result) > +if (result) { > + destroy_workqueue(status_queue); > + destroy_workqueue(command_queue); > + des

usb hid: reset NumLock

2007-03-30 Thread Pete Zaitcev
This is a patch for comments only, please do not apply (at least not as-is). I haven't got the test results yet. Dell people (Stuart and Charles) complained that on some USB keyboards, if BIOS enables NumLock, it stays on even after Linux has started. Since we always start with NumLock off, this c

Re: usb hid: reset NumLock

2007-03-30 Thread Pete Zaitcev
On Fri, 30 Mar 2007 14:14:20 -0400, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > > I didn't like a) layering violation, and b) that they defeat filtering > > unconditionally. Why have any filtering then? > > > > Instead, I propose for USB HID driver to reset NumLock on probe. Like this: > > > >

Re: usb hid: reset NumLock

2007-03-31 Thread Pete Zaitcev
On Sat, 31 Mar 2007 21:35:19 +0200 (CEST), Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Fri, 30 Mar 2007, Pete Zaitcev wrote: > I think I see an issue here. Imagine that you boot a system initially with > one keyboard connected (usb, ps/2, doesn't matter), and after some

Re: usb hid: reset NumLock

2007-04-01 Thread Pete Zaitcev
On Sun, 1 Apr 2007 14:49:59 +0300, "Pekka Enberg" <[EMAIL PROTECTED]> wrote: > On 3/30/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > Dell people (Stuart and Charles) complained that on some USB keyboards, > > if BIOS enables NumLock, it stays on even after L

Re: usb hid: reset NumLock

2007-04-01 Thread Pete Zaitcev
On Sat, 31 Mar 2007 21:35:19 +0200 (CEST), Jiri Kosina <[EMAIL PROTECTED]> wrote: > I think I see an issue here. Imagine that you boot a system initially with > one keyboard connected (usb, ps/2, doesn't matter), and after some time > you connect second USB keyboard (the NumLock is 'on' on the

Re: usb hid: reset NumLock

2007-04-02 Thread Pete Zaitcev
On Mon, 2 Apr 2007 16:48:24 +0200 (CEST), Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Sun, 1 Apr 2007, Pete Zaitcev wrote: > could you please change the order of the two functions, so that you > don't have to put the forward declaration here? >[...] > I'd say thi

Re: usb hid: reset NumLock

2007-04-02 Thread Pete Zaitcev
On Tue, 3 Apr 2007 01:04:05 -0400, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > What do you think? The patch looks sane, although I haven't yet tested it. I'll live with it until next quarterly update, then consider if I should take it or use my patch for RHEL 5 and RHEL 4. -- Pete - To unsubscr

Re: OHCI: USB webcam works, but not on USB Hub

2007-04-03 Thread Pete Zaitcev
On Tue, 03 Apr 2007 08:22:28 -0700, "Kok, Auke" <[EMAIL PROTECTED]> wrote: > Having the gspca driver move into the main tree would help a lot though. I think we need to articulate better why this is an issue and not just an excuse. We know that scheduling issues with ISO transfers exist, but with

Oops in make_class_name in 2.6.22.1 on Fedora

2007-09-10 Thread Pete Zaitcev
Hi, Greg (and others): I do not seem to be able to find an answer, sorry. Do you happen to remember if this was fixed after 2.6.22.1: localhost kernel: EIP is at make_class_name+0x27/0x7a localhost kernel: [] class_device_del+0x97/0x119 localhost kernel: [] class_device_unregister+0x8/0x10 loca

Re: [GIT PATCH] USB autosuspend fixes for 2.6.23-rc6

2007-09-13 Thread Pete Zaitcev
On Thu, 13 Sep 2007 09:43:13 -0700 (PDT), Linus Torvalds <[EMAIL PROTECTED]> wrote: > So why not make the 64 sector limit be the default? Get rid of the quirk: > we already allow people to override it in /sys if they really want to, but > realistically, it's probably not going to make any diffe

Re: 2.6.23-rc6: usb 1-1: device not accepting address 2, error -62

2007-09-15 Thread Pete Zaitcev
On Sat, 15 Sep 2007 03:48:19 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > I have an error message with 2.6.23-rc6. > > This did not happen with 2.6.22. > > Another one for Michal's dirt file. No, I think it's the module ordering again. > > 2.6.23-rc6 boot.msg extract ( hub/usb ) I wish

Re: [PATCH] USB: usblp: don't call usb_set_interface if there's a single alt

2021-01-24 Thread Pete Zaitcev
On Sat, 23 Jan 2021 18:21:36 -0600 Jeremy Figgins wrote: > Signed-off-by: Jeremy Figgins > +++ b/drivers/usb/class/usblp.c > + if (usblp->intf->num_altsetting > 1) { Acked-by: Pete Zaitcev I am having some misgivings about it, but let's see if it works. At worst

Re: [PATCH] connector: improved unaligned access error fix

2013-11-14 Thread Pete Zaitcev
On Thu, 14 Nov 2013 12:09:21 -0500 Chris Metcalf wrote: > - __u8 buffer[CN_PROC_MSG_SIZE]; > + __u8 buffer[CN_PROC_MSG_SIZE] __aligned(8); > - msg = (struct cn_msg *)buffer; > + msg = buffer_to_cn_msg(buffer); > ev = (struct proc_event *)msg->data; > memset(&ev->event

Re: [PATCH 1/1] usblp: do not set TASK_INTERRUPTIBLE before lock

2015-11-11 Thread Pete Zaitcev
hat mutex_lock_interruptible() can set the state, or it didn't do it back then (it was in 2007), and the 7f477358e introduced the existing code. Acked-By: Pete Zaitcev -- Pete -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [PATCH] USB: usbmon: Remove timeval usage for timestamp

2015-05-05 Thread Pete Zaitcev
On Tue, 05 May 2015 11:24:16 +0200 Arnd Bergmann wrote: > On Tuesday 05 May 2015 11:44:33 Tina Ruchandani wrote: > > static inline unsigned int mon_get_timestamp(void) > > { > > - struct timeval tval; > > + struct timespec64 now; > > unsigned int stamp; > > > > - do_gettimeofday(&t

Re: KASAN: use-after-free Read in usblp_bulk_read

2020-05-06 Thread Pete Zaitcev
On Wed, 06 May 2020 11:14:42 +0200 Oliver Neukum wrote: > Very well. We are not going to find it without exceptional luck. Yet > there may be a real issue, too. We simply do not know. How about the > attached patch? > usblp_unlink_urbs(usblp); > mutex_unlock(&usblp->mut); > + usb

<    1   2   3