On Fri, 04 Feb 2005 23:16:22 +1100, Rusty Russell <[EMAIL PROTECTED]> wrote:
> [...] I have since then had multiple
> ext3 and ext2 errors: 2.6.8, 2.6.9, 2.6.10 and 2.6.11-rc3 all exhibit
> the problem within an hour of stress (untarring a fresh kernel tree, cp
> -al'ing to apply patches repeatedl
On Tue, 8 Feb 2005 18:40:12 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> Here is the promised patch. It turns out protocol validation code was
> a bit (or rather a byte ;) ) off.
> +++ b/drivers/input/mouse/alps.c 2005-02-08 18:16:27 -05:00
> @@ -198,8 +198,8 @@
> return
Now that 2.6 has my changes, we can apply them to 2.4. This includes the
removal of dead code under #ifdef FIX_WRITE_RETURN_CODE_PROBLEM.
This patch fixes the endless loops on disconnect when resubmitting failed
URBs monopolizes CPU and prevents the disconnect thread from cleaning up.
Note though
Granted, this is a cleanup, and we don't like cleanups in 2.4. But I really
dislike how the comment managed to detach from the function it described.
The idiotic error message is quite annoying, too.
diff -urpN -X dontdiff linux-2.4.30-pre1/drivers/usb/serial/ftdi_sio.c
linux-2.4.30-pre1-usb/driv
Apparently, the HP rx5670 fails to reboot if a USB keyboard if attached
without this patch (and the OHCI fix we accepted for 2.4.29).
This bug is better known for its effect on Altix, but SGI ships a magic
kernel anyhow, so I don't want to use that as justification.
The original patch comes from
I entered a patch which adds "exclusive_access" lock into 2.4.29, to fix
devices which cannot handle simultaneous accesses. This caused a regression
with European ADSL modems. An ioctl USBDEVFS_REAPURB allows a process to enter
the kernel and wait for USB I/O to finish. Naturally, this should not t
On Wed, 16 Feb 2005 04:05:47 +0900, Chris White <[EMAIL PROTECTED]> wrote:
> Ironically, if the network card driver is not working, there's no way to
> google around for information on what modules to compile in for various
> drivers. [...]
I always google for the PCI IDs which lspci -n shows.
>
Hi, Jens:
I think this question belongs to your domain, but please let me know
if I'm mistaken, so I can pursue this elsewhere.
I encountered a strange performance anomaly. I do the following:
<- Plug USB key
[EMAIL PROTECTED] ~]# time dd if=/dev/uba of=/dev/null bs=10k count=10240
10240+0 r
On Tue, 25 Jan 2005 16:30:15 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> > The more serious one is that sometimes it seems to spontaneously emit click
> > events while I'm moving finger across pad. Which means I've had to learn to
> > plan my "mouse" motions to avoid areas where clicking
Hello, Peter:
The keyboard seems to work now, but I stepped on a very strange condition.
Suddenly, touchpad motions started to cause wild movements in it became
impossible to do anything due to a focus loss (of course, I had plenty of
modified files open :-)
The dmesg looked like this:
psmouse.c
On Mon, 31 Jan 2005 22:40:35 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> > Suddenly, touchpad motions started to cause wild movements in it became
> > impossible to do anything due to a focus loss (of course, I had plenty of
> > modified files open :-)
> > psmouse.c: TouchPad at isa0060/s
turn exports of usb_bus_list and usb_bus_list_lock for those who
wish to build usbmon as a module.
Signed-off-by: Pete Zaitcev
diff -urpN -X dontdiff linux-2.6.11-rc2/drivers/usb/core/hcd.c
linux-2.6.11-rc2-lem/drivers/usb/core/hcd.c
--- linux-2.6.11-rc2/drivers/usb/core/hcd.c 2005-01-22 14:54:24.0
On Mon, 31 Jan 2005 23:10:01 -0800, Greg KH <[EMAIL PROTECTED]> wrote:
> First off, why make usbmon a module? You aren't allowing it to happen,
> so just take out the parts of the patch that allow it.
No, I do allow it. This way I can load and unload it when debugging it.
Perhaps in the future w
On Tue, 01 Feb 2005 12:13:03 +0100, Marcel Holtmann <[EMAIL PROTECTED]> wrote:
> By accident I removed the debugfs option from my kernel config and this
> makes usbmon totally useless. So I think the module approach is wrong
> from my point of view. Why not compile it always and if debugfs is
> av
Hi, guys,
I was looking at this:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138892
I have added usb-handoff as a kernel option in grub.conf for
2.4.21-20.EL (smp) and re-enabled USB Emulation and Controller in the
BIOS, and the machine now seems to boot normally. I only had tim
On Tue, 01 Feb 2005 22:37:50 +0100, Marcel Holtmann <[EMAIL PROTECTED]> wrote:
> I think if cat is the prefered tool for viewing this file then it should
> be more human readable. If not, then a binary format should be choosen.
> Maybe we can implement both. Is this possible?
Yes. Now you know wh
turn exports of usb_bus_list and usb_bus_list_lock for those who
wish to build usbmon as a module.
This version of the patch changes #define to inlines for hooks and
drops extra mod_ops.
Signed-off-by: Pete Zaitcev
diff -urpN -X dontdiff linux-2.6.11-rc2/drivers/usb/core/hcd.c
linux-2.6.11-rc2-lem/d
On 30 Jan 2005 12:10:34 +0100, Peter Osterlund <[EMAIL PROTECTED]> wrote:
> > - Slow motion of finger produces no motion, then a jump. So, it's very hard
> > to
> > target smaller UI elements and some web links.
>
> I see this too when I don't use the X touchpad driver. With the X
> driver the
On Wed, 2 Feb 2005 11:20:33 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote:
> Well, you removed the scaling to the touchpad resolution, which will
> cause ALPS touchpad to be significantly slower than Synaptics touchpads.
> Similarly, the screen size used to be taken into account, but probably
>
On Wed, 2 Feb 2005 18:07:27 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote:
> On Wed, Feb 02, 2005 at 08:56:28AM -0800, Pete Zaitcev wrote:
> > On Wed, 2 Feb 2005 11:20:33 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote:
> >
> > > Well, you removed the scali
On Wed, 02 Feb 2005 17:40:17 +0100, Marcel Holtmann <[EMAIL PROTECTED]> wrote:
> While I am really thinking about starting usbdump, I may ask why you
> have choosen to use debugfs as interface. This will not be available in
> normal distribution kernels and I think a general USB monitoring ability
On Wed, 2 Feb 2005 20:11:35 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote:
> It's different hardware. While the ALPS pad delivers X axis in the range
> of 0 to 1000, the Synaptics pad will give X axis values from approx 1500
> to approx 5500. This is four times the resolution - the size of the p
On 02 Feb 2005 21:57:39 +0100, Peter Osterlund <[EMAIL PROTECTED]> wrote:
> Please try this patch instead. It works well with my alps touchpad. (I
> don't have a synaptics touchpad.) It does the following:
>
> * Compensates for the lack of floating point arithmetic by keeping
> track of remaind
On Wed, 2 Feb 2005 23:58:05 +0100 (CET), Peter Osterlund <[EMAIL PROTECTED]>
wrote:
> It didn't make any difference for the generated assembly code though,
> using gcc 3.4.2 from Fedora Core 3.
OK, unary minus is fine then.
What about using 'value' in place of 'fx(0)'?
-- Pete
-
To unsubscribe
On Thu, 3 Feb 2005 13:58:29 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> I haven't reached the test for corruption because the stock SATA oopses at
> probe time. Running Marcelo's 2.4.29 and 2.4.29-rc1-libata1.patch
> (also ksymoops from RHEL 3). Please see the att
On Mon, 21 Feb 2005 08:51:32 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote:
> > [EMAIL PROTECTED] ~]# time dd if=/dev/uba of=/dev/null bs=10k count=10240
> > real0m22.731s
> > [EMAIL PROTECTED] ~]# time dd if=/dev/uba1 of=/dev/null bs=10k count=10240
> > real1m42.622s
> > So, reading from
On Mon, 21 Feb 2005 12:00:48 -0800 (PST), Linus Torvalds <[EMAIL PROTECTED]>
wrote:
> That said, I'm surprised that the difference in performance is _that_
> large. Regardless of whether the disk blocksize is 512 bytes or 4096
> bytes, you should be getting IO merging - it might use more CPU ti
On Mon, 28 Feb 2005 14:02:30 -0500, Steve Dickson <[EMAIL PROTECTED]> wrote:
> Discovered using AKPM's ext3-tools: odwrite -ko 0 16385 foo
> Signed-off-by: Bill Rugolsky <[EMAIL PROTECTED]>
> Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
The root cause of the bug is that the code violates th
On Wed, 2 Mar 2005 12:12:53 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> > Booting X in new kernel makes my touchpad very unresponsive. I can't
> > click any longer in the touchpad area, and the touchpad doesn't response
> > when moving in small increments, so the whole experience is quite
On Fri, 11 Feb 2005 11:16:20 +0100 Duncan Sands <[EMAIL PROTECTED]>
wrote:
> On Thu, 2005-02-10 at 16:11 -0800, Pete Zaitcev wrote:
> > I entered a patch which adds "exclusive_access" lock into 2.4.29,
> > to fix devices which cannot handle simultaneous accesses. Th
> This [code morphing and binary tranlation]
> was set off to provide compensation for the biggest hurdle
> of VLIW design - insane code size and partially huge memmory
> bus bandwidth designs due to this. (Why do you think the itanim
> sucks on integer performance?)
First, Merced does not suck
> Then again JavaOS was an abortion on top of Slowaris. [...]
This is a false statemenet, Rob. It was an abortion, all right,
but not related to Solaris in any way at all.
JavaOS existed in two flavours minimum, which had very little
in common. The historically first of them (Luna), was a home-m
> There is no such thing as a "user mode" interrupt service routine.
> There never was one, and there will never be one on any machine
> that fetches instructions from memory for execution. [...]
If memory does not deceive me, SunLab Spring processed interrupts
in user space. I do not remember fo
> I'd like to find out if anyone has thought about how Linux will handle
> some of the new network technologies people are starting to push.
> Specifically I'm talking about "System Area Networks," that is, things
> like Infiniband, as well as TCP/IP offload.
Infiniband is doing relatively well,
> Well you have device drivers like the symbios scsi driver for instance that
> tries to determine if it's seen a card before. It does this by looking at the
> bus,dev etc numbers...
Can it be done by comparing struct pci_dev pointers for equal?
-- Pete
-
To unsubscribe from this list: send the
> Lately, I have been having problems reading from from my HP Colorado IDE
> tape drive. I can use mt to get the status of the drive and to forward the
> drive to a different file. I can even use tar to write to the tape.
> But whenever I try to read the tar files that I have written to tape, I
> When I do anything (print to it, query its ink levels with escputil,
> etc.) with my Epson 870 while it's hooked to my computer via USB, the
> whole machine locks hard. [...]
> Has anyone else has seen this problem? I posted to the gimp-print and
> linux-usb lists, but there was nary a response
> This patch adds a missing semicolon that is noticed only if you define
> IDETAPE_DEBUG_LOG_VERBOSE:
>
> John Guthrie
> [EMAIL PROTECTED]
It makes me curious, why do you need to define
IDETAPE_DEBUG_LOG_VERBOSE?
I fixed some stuff with files not restoring properly
with last block corrupt. Talk
In linux-kernel, you wrote:
> Peter Zaitsev wrote:
> >
> > That's why I thought this problem is related to raid1 swapping I'm
> > using.
>
> Well there is the potential problem that RAID1 has that it can't avoid allocating
> memory in some occasions, for the 2nd bufferhead. ATARAID raid0 has the
> This message is in MIME format. The first part should be readable text,
> while the remaining parts are likely unreadable without MIME-aware tools.
Quite so. Linus told you many times not to send patches
in MIME and I happen to agree.
> Content-Type: TEXT/PLAIN; charset=US-ASCII; name="pa
On Wed, 2 Feb 2005 10:18:47 +0300 Andrey Panin <[EMAIL PROTECTED]> wrote:
> > +++ linux-2.6.11-rc2-lem/arch/i386/kernel/dmi_scan.c2005-01-31
> > 20:42:16.163592792 -0800
> > +static __init int enable_usb_handoff(struct dmi_blacklist *d)
> > +{
> Please don't add new quirks into dmi_scan
Hello:
My box here slows down dramatically after a while, and starts
behaving as if it has very little memory, e.g. programs page
each other out. It turns out that out of 40MB total, about
35MB is used for dcache and icache, and system basically
runs in 5MB of RAM.
When I tried to discuss it wit
> While trying to compile the 2.4.4 kernel on a SPARC-20, I encounter the
> following error.
> make[1]: Entering directory `/usr/src/linux-2.4.4/mm'
> make all_targets
> make[2]: Entering directory `/usr/src/linux-2.4.4/mm'
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.4/include -Wall -Wstrict-prototyp
One of our customers has a Fujitsu laptop, poor thing...
It shares IRQ10 between Eepro, additional IDE for CD-ROM (CMD646),
and USB controllers. I talked this over with DaveM briefly,
and if I understood him right, something like the attached
patch may be in order. Anyone cares to comment?
Thank
Hello:
Here are updates from ALSA. The interrupt acknowledge has a
potential bug report for it in RH bugzilla. Power-up fix I include
"just because", Alan bounced it to me from sound-hackers;
Also Jeff Garzik asked for it. I wanted to include it with
full PM support, but perhaps not.
-- Pete
--
Due to a pilot error, my ymfpci update would not compile
(forgot to submit .h change). Here is the missing part:
--- linux-2.4.4/drivers/sound/ymfpci.h Fri Jan 26 23:31:16 2001
+++ linux-2.4.4-niph/drivers/sound/ymfpci.h Fri May 4 11:07:17 2001
@@ -135,6 +135,8 @@
#define PCIR_LEGCTRL
David,
Russel King complained that you might be calling pci_consistent_free
from an interrupt, which is unsafe on ARM. Why don't you remove this
part from pci_pool_free():
+ else if (!is_page_busy (pool->blocks_per_page, page->bitmap))
+ pool_free_page (pool, page);
In that
Hi:
I found that every time I run a 2.4 on my laptop, APM locks up
the machine. Apparently, legacy YMF code enabled decoding of
10 bits of I/O address. A call to APM BIOS touched that and
somehow the system locked up.
If Pavel Roskin, Daisuke Nagano or someone else do not mind,
I want this in st
> switching it back on, a problem occurs with reenabling the ports on
> that USB hub. The kernel output follows.
> Comments anyone?
Next time, post your /proc/version.
There were similar things recently (missing urb->dev
reinitialization in usb_hub_reset).
-- Pete
-
To unsubscribe from this li
> May 9 10:05:11 localhost kernel: EIP:0010:[call_policy+427/608]
I saw it before, but was unable to track it down.
What is your kernel version?
-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
> From: "David S. Miller" <[EMAIL PROTECTED]>
> Date: Tue, 8 May 2001 17:52:45 -0700 (PDT)
> Ummm... What Alan's saying is:
>
> 1) Whatever driver is trying to shut down from IRQ context
>is broken must be fixed. pci_pool is fine.
>
> 2) The Documentation/ files which suggest that such dev
How about this (with documentation fixes by David-B):
diff -ur -X dontdiff linux-2.4.4/Documentation/DMA-mapping.txt
linux-2.4.4-niph/Documentation/DMA-mapping.txt
--- linux-2.4.4/Documentation/DMA-mapping.txt Thu Apr 19 08:38:48 2001
+++ linux-2.4.4-niph/Documentation/DMA-mapping.txt Thu
A Jan Kasprzak asked a few days ago to have a MAINTAINERS entry for ub.
This patch updates my entries in MAINTAINERS (ub & ymfpci).
Signed-Off-By: Pete Zaitcev <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1/MAINTAINERS2005-03-18 17:11:29.0 -0800
+++ linux-2.6.12-rc1-lem/M
Dear Russell:
I have a favour to ask of you. I need the following patch to be applied
to the USB core:
diff -urpN -X dontdiff linux-2.6.11-rc1-bk4/drivers/usb/core/hcd.c
linux-2.6.11-rc1-bk4-lem/drivers/usb/core/hcd.c
--- linux-2.6.11-rc1-bk4/drivers/usb/core/hcd.c 2005-01-12 16:35:53.0
On Tue, 18 Jan 2005 22:14:24 -0800, David Brownell <[EMAIL PROTECTED]> wrote:
> > > Also, I don't like the idea of scattering knowledge all over the place
> > > that the root hub is always given address 1 ...
>
> which you didn't address yet.
Yes, I have to look why you do not like using the pi
On Wed, 19 Jan 2005 09:08:34 -0800, David Brownell <[EMAIL PROTECTED]> wrote:
> On Wednesday 19 January 2005 7:42 am, Pete Zaitcev wrote:
> > Relying on pipe makes
> > tests dependant on URB only. No references to bus or HCD, therefore no
> > extra refcou
On Thu, 20 Jan 2005 22:28:31 -0800, David Brownell <[EMAIL PROTECTED]> wrote:
> By the way ... on the topic of usbmon rather than changing
> usbcore, is there a brief writeup of what you want this
> new version to be doing -- and how? Like, why put the
> spy hooks in that location, rather than an
On Sun, 23 Jan 2005 15:34:23 -0800, David Brownell <[EMAIL PROTECTED]> wrote:
> > so let me restate it. Simply put, neither dev nor hcd are available
> > at the time urb->complete is called,
>
> Completely untrue. They are at a minimum provided through the URB itself,
> and giveback (which is t
Hi, guys:
I thought the David's argument over and decided that it makes usbmon simpler
if hooks are made explicit. Most importantly, URBs are not tracked anymore
at all. This magically fixes ISO and interrupt URBs. The struct urb does
not have anything added anymore, there's no need to jiggle with
Hi, Vojtech:
Since the 2.6.11-rc2, I encounter problems with touchpad and keyboard
on my laptop, Dell Lattitude D600. The following patch appears to be
the culprit:
diff -urp -X dontdiff linux-2.6.11-rc1/drivers/input/mouse/psmouse-base.c
linux-2.6.11-rc2/drivers/input/mouse/psmouse-base.c
---
On Mon, 24 Jan 2005 11:48:51 +, David Woodhouse <[EMAIL PROTECTED]> wrote:
> On Wed, 2005-01-19 at 14:07 -0800, Greg KH wrote:
> > I have been running with just the code portion of this patch for a while
> > now, with good results (no Kconfig changes.)
> >
> > Pete and Matt, do you mind me ap
On Mon, 29 Oct 2007 20:04:57 +0200, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
> Finally had a time on my weekend to perform tests and fix Pete's patch a
> little. Now it seems to be correct.
Great!
> 1. One device per user space application. Old driver allowed many users
> application to work
On Tue, 30 Oct 2007 15:09:54 +0200, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
> As about read_urb_finished probably it's OK. But we shouldn't decrease
> open_count in the case of error as then we return normal exit value.
Oh, thanks. I fixed that.
One other small thing. I see you dropped the dev
On Tue, 30 Oct 2007 20:09:45 +0100, Norbert Preining <[EMAIL PROTECTED]> wrote:
> Is this a regression from 2.6.20, or is it supposed to work?
Please post your /proc/bus/usb/devices. Maybe it just fails to match.
-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
On Tue, 30 Oct 2007 22:22:13 +0100, Norbert Preining <[EMAIL PROTECTED]> wrote:
> I tried the attached patch which I found on the usb list, but it didn't
> work, the cdrom was still always found, and it was
> connected/disconnected permanently.
The difference with huaweiAktBbo.c seems that kernel
On Wed, 31 Oct 2007 07:23:56 +0100, Norbert Preining <[EMAIL PROTECTED]> wrote:
> Hmm, in addition I added a
> printk(KERN_ERR "ENTERING usb_stor_huawei_e220_init!\n");
> at the beginning of the function but it never showed up in my log files.
> So it seems that the UNUSUAL_DEV entry does no
On Wed, 31 Oct 2007 13:54:54 +0200, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-10-30 at 23:54, Pete Zaitcev wrote:
>
> > One other small thing. I see you dropped the dev->mtx bracket that
> > I added around the initialization and submission. Notice that
se of
usb_kill_urb was outright racy (it unlinked and immediately freed).
- Fix indentation in adu_write. Looks like it was damaged by a script.
- Vitaly wants -EBUSY on multiply opens.
- bInterval was taken from a wrong endpoint.
Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]>
Signed-off-
On Thu, 01 Nov 2007 11:06:24 +0200, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
> > Do you still want to go ahead with a 2.4 backport?
>
> Yep. Will do it asap. In latest 2.4 patch we had just a locks issue.
> So do you think I should modify 2.4 patch with all modifications we done in
> 2.6 versio
On Fri, 3 Aug 2007 10:24:16 -0400, Dave Jones <[EMAIL PROTECTED]> wrote:
> On Fri, Aug 03, 2007 at 09:57:45AM +0200, Oliver Neukum wrote:
>
> > Kernel developers are a diverser lot than you think ;-)
> > We don't enable autosuspend in drivers we can't test, except where
> > the lack of a kerne
On Fri, 03 Aug 2007 15:29:21 -0400, Chuck Ebbert <[EMAIL PROTECTED]> wrote:
> > Well, we did - with hindsight it may not have been such a great plan :)
> > I believe that Fedora did as well, but have disabled it in an update
> > kernel.
>
> Yeah, autosuspend broke too many devices. Way too many
On Fri, 3 Aug 2007 15:45:32 -0400, Dave Jones <[EMAIL PROTECTED]> wrote:
> > > My experience suggests the opposite. Of the several I've tried so far,
> > > none have worked with usb suspend.
> >
> > All of mine work. I'm wondering if this has something to do with
> > a hub or motherboard...
Create arch/x86_64/vdso/.gitignore and put vdso.lds into it.
Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]>
---
Utterly trivial but for some reason missing. V.odd. I must be
misunderstanding how this works, but just in case here's patch.
--- linux-2.6.23-rc1/arch/x86_64/vdso
I received two updates, and something jumped out:
On Sun, 12 Aug 2007 23:38:00 -0700, [EMAIL PROTECTED] wrote:
> +F: drivers/block/ub.c
On Sun, 12 Aug 2007 23:38:30 -0700, [EMAIL PROTECTED] wrote:
> +F: /drivers/usb/class/usblp.c
Why do some patterns start with a leading slash and others do
On Fri, 19 Oct 2007 18:26:35 +0300, "Vitaliy Ivanov" <[EMAIL PROTECTED]> wrote:
> Didn't here anything on this? What is our final decision here?
It's gotten worse, not better. Apparently, you aren't getting the
concept of protecting the open count with a static lock and my
explanations are just n
se of
usb_kill_urb was outright racy (it unlinked and immediately freed).
- Fix indentation in adu_write. Looks like it was damaged by a script.
Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]>
---
If someone with a real device tested this, it would be great. Please
make sure to pull the
On Fri, 19 Oct 2007 20:40:35 +0300, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
Hi, Vitaly, I added you on cc: for the 2.6 cleanup. Please double-check
what I'm doing there and use it for your 2.4 version. I hope my intentions
get clearer with an example. Now, about the specific question:
> Static
On Tue, 23 Oct 2007 11:38:37 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> > + /* XXX Anchor these instead */
> > + spin_lock_irqsave(&dev->buflock, flags);
> > + if (!dev->read_urb_finished) {
> > + spin_unlock_irqrestore(&dev->buflock, flags);
> > + usb_kill_urb(dev
se of
usb_kill_urb was outright racy (it unlinked and immediately freed).
- Fix indentation in adu_write. Looks like it was damaged by a script.
- Remove sleep_on.
Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]>
---
Oliver, thanks for the inftdata catch. I also fixed the sleep_on.
But I lef
On Wed, 24 Oct 2007 17:09:47 +0300, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
> > static void adu_abort_transfers(struct adu_device *dev)
> > {
> ...
> > + mutex_lock(&dev->mtx);
> ...
> > + mutex_unlock(&dev->mtx);
>
> > }
>
> Don't you think it's needed? You call adu_abort_transfers fr
BTW, the patch in my previous message had one buglet - an extra
remove_wait_queue. It was in an error case though, so it should be
ok to test. But just in case, here's a fixed one.
-- Pete
diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c
index c567aa7..6914c0b 100644
--- a/drive
On Thu, 25 Oct 2007 14:03:48 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> Am Donnerstag 25 Oktober 2007 schrieb Pete Zaitcev:
> > + if (signal_pending(current)) {
> > dbg(1," %s :
On Fri, 12 Oct 2007 14:57:28 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> > Should I be submitting my driver as a patch to linux.kernel or are Alan
> > or Greg going to push their changes?
>
> Please submit your patches to Greg and the USB development list.
> Greg has a directory on kernel.
On Sun, 14 Oct 2007 23:45:36 +0300, "Vitaliy Ivanov" <[EMAIL PROTECTED]> wrote:
> Also IMHO the more drivers are in the tree the more users will use it.
> Once it will be merged in the mainline then it will be backported to
> enterprise kernels and would gain wide usage.
At least in case of RHEL,
On Tue, 16 Oct 2007 16:54:49 +0300, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote:
> Again, comments are welcomed.
It looks like you misunderstood why a static lock protects open counts.
This is done so you do not need to worry about in-structure lock which
can be freed together with the structure. Lo
On Tue, 16 Oct 2007 17:41:38 +0200, Willy Tarreau <[EMAIL PROTECTED]> wrote:
> OK, I have no objection, but please apply the fixes the le16 problem as
> suggested by Pete and Greg first. Also, you will probably receive more
> comments, and/or criticisms from further reviews. This is normal and
> e
Hi, Kristian:
I only looked briefly at SBP-2, and at submit/callback paths it pulled,
because I do not understand most of the other issues.
Executive summary: please implement proper ORB cancellation. This is
how you verify that your locking model is worth anything: by interaction
of normal trans
On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote:
> > I see that ORBs are always allocated with a call (like SKB) and not
> > embedded into drivers (like URBs). It's great, keep it up. Also,
> > never allow drivers to pass DMA-mapped buffers into fw_send_request
> >
On Fri, 29 Dec 2006 20:45:57 -0500, Eric Buddington <[EMAIL PROTECTED]> wrote:
> Kernel 2.6.19-rc6-mm2 on an Athlon XP gave me the following Oops when
> unplugging a USB device. I an usually plug and unplug devices without
> trouble, so this is probably not easily repeatable.
> [1742510.173840] PR
On Tue, 20 Feb 2007 09:02:53 +0100 (CET), Jiri Kosina <[EMAIL PROTECTED]> wrote:
> On Mon, 19 Feb 2007, Veronique & Vincent wrote:
> > Hi again Marcel and Jiri,
> > I've set up the hid-core.c to DEBUG mode... and it literally got pretty
> > verbose...
> thanks for the output. Is this really the
On Mon, 19 Feb 2007 21:15:49 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> +++ b/drivers/usb/misc/ftdi-elan.c
> @@ -57,9 +57,9 @@ module_param(distrust_firmware, bool, 0);
> MODULE_PARM_DESC(distrust_firmware, "true to distrust firmware
> power/overcurren"
> "t setup");
> extern
Here's a curious code I found in drivers/input/input.c (2.6.21-rc1):
void input_release_device(struct input_handle *handle)
{
if (handle->handler->start)
handle->handler->start(handle);
}
Is the above supposed to be this way, or you meant ->stop here?
The commit comm
On Thu, 22 Feb 2007 11:43:38 +0100, Duncan Sands <[EMAIL PROTECTED]> wrote:
> > + /* the module/device has probably been removed */
> > + if (urb->status == -ESHUTDOWN)
> > + return;
> > +
> > if (printk_ratelimit())
> > atm_war
On Fri, 23 Feb 2007 10:06:14 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote:
> On 2/23/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote:
> > void input_release_device(struct input_handle *handle)
> > {
> >
> >if (handle->handler->
On Fri, 23 Feb 2007 11:10:05 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> I may be wrong, but a lot of the kernel code have static pointers
> initialized to NULL with explicit manner... More over I always thought
> that _static_ is not mean _initialized to zero_. I think _static_ is
> just
On Sat, 24 Feb 2007 11:57:07 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote:
> > To tell you the truth, all I really want is to hold a static mutex
> > across a call to input_close_device(). Can I do that?
>
> Are you trying to fix locking in mousedev?
Yes.
-- Pete
-
To unsubscribe from this
On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> Thanks a lot for comments and Ack the patch please.
Cyrill, I forgot to mention a couple of points, sorry.
> printk(KERN_INFO "driver %s built at %s on %s\n",
> ftdi_elan_driver.name,
> - _
On Tue, 27 Feb 2007 09:06:21 -0500, Eric Buddington <[EMAIL PROTECTED]> wrote:
> sd 1:0:0:0: rejecting I/O to offline device
> ...
> SoftDog: Initiating system reboot.
> Now, the USB problem may well be a device or cabling issue, but I
> don't think that this drive failure should trigger a reboot
; done
This way, it oopses on 2nd or 3rd disconnect reliably. With the patch,
I can disconnect the mouse 20 times.
Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]>
---
Discussion
One of the race scenarios is related to the list of handles. The cat
calls mousedev_close -> mixdev_rele
On Thu, 8 Feb 2007 22:27:43 -0500, "D. Hazelton" <[EMAIL PROTECTED]> wrote:
> So almost all the rules around the signs of types are because of a single,
> historical machine. Hence the rules about "char" being unsigned by default
> and "int" being signed by default are because of the nature of t
101 - 200 of 268 matches
Mail list logo
