Re: [PATCH] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Paul Kocialkowski
Hi, On Thu, 2019-01-24 at 11:32 +0100, Greg KH wrote: > On Thu, Jan 24, 2019 at 10:55:42AM +0100, Paul Kocialkowski wrote: > > This reverts commit cf20ae1535eb690a87c29b9cc7af51881384e967. > > > > The vb2_find_timestamp helper was modified to allow finding buffers > >

[PATCH v2] Revert "media: cedrus: Allow using the current dst buffer as reference"

2019-01-24 Thread Paul Kocialkowski
: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 13 - drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 2 -- drivers/staging/media/sunxi/cedrus/cedrus_mpeg2.c | 10 -- 3 files changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/staging

Re: [PATCH v2 2/2] media: cedrus: Add HEVC/H.265 decoding support

2019-01-24 Thread Paul Kocialkowski
Hi, On Tue, 2018-11-27 at 09:21 +0100, Maxime Ripard wrote: > Hi! > > On Fri, Nov 23, 2018 at 02:02:09PM +0100, Paul Kocialkowski wrote: > > This introduces support for HEVC/H.265 to the Cedrus VPU driver, with > > both uni-directional and bi-directional predi

Re: [PATCH v8 4/4] drm/vc4: Allocate binner bo when starting to use the V3D

2019-05-10 Thread Paul Kocialkowski
Hi, On Thu, 2019-05-09 at 11:39 -0700, Eric Anholt wrote: > Paul Kocialkowski writes: > > > The binner BO is not required until the V3D is in use, so avoid > > allocating it at probe and do it on the first non-dumb BO allocation. > > > > Keep track of which

Re: [PATCH v3 4/7] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp

2019-05-20 Thread Paul Kocialkowski
ut we really should have an unsigned plane index wherever it's used. We're only checking for plane >= info->num_planes but seldom for plane < 0. Either way, this is: Reviewed-by: Paul Kocialkowski Cheers, Paul > Reviewed-by: Emil Velikov > Signed-off-by: Maxime Ripar

Re: [PATCH v3 7/7] drm: Remove users of drm_format_num_planes

2019-05-20 Thread Paul Kocialkowski
zx_writel(paddr_reg, paddr); > paddr_reg += 4; > } > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h > index 4ef8ccb5d236..405466692bd2 100644 > --- a/include/drm/drm_fourcc.h > +++ b/include/drm/drm_fourcc.h > @@ -261,23 +261,6 @@ drm_format_info_is_yuv_sampling_444(const struct > drm_format_info *info) > } > > /** > - * drm_format_info_plane_cpp - determine the bytes per pixel value > - * @format: pixel format info > - * @plane: plane index > - * > - * Returns: > - * The bytes per pixel value for the specified plane. > - */ > -static inline > -int drm_format_info_plane_cpp(const struct drm_format_info *info, int plane) > -{ > - if (!info || plane >= info->num_planes) > - return 0; > - > - return info->cpp[plane]; > -} > - > -/** > * drm_format_info_plane_width - width of the plane given the first plane > * @format: pixel format info > * @width: width of the first plane > -- > git-series 0.9.1 > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com

Re: [PATCH v3 5/7] drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height

2019-05-20 Thread Paul Kocialkowski
also be changed to match the > other functions prototype. Same comment about plane being int instead of unsigned int, but I think we can fix that later. Another thing that I find odd is that the division by vsub/hsub is not rounded up, but again, it's something independent from your patch. Revi

[PATCH v11 0/4] media: cedrus: Add H264 decoding support

2019-05-24 Thread Paul Kocialkowski
Hi, Here is a new version of the H264 decoding support in the cedrus driver. As you might already know, the cedrus driver relies on the Request API, and is a reverse engineered driver for the video decoding engine found on the Allwinner SoCs. This work has been possible thanks to the work done b

[PATCH v11 1/4] media: uapi: Add H264 low-level decoder API compound controls.

2019-05-24 Thread Paul Kocialkowski
From: Pawel Osciak Stateless video codecs will require both the H264 metadata and slices in order to be able to decode frames. This introduces the definitions for the structures used to pass the metadata from the userspace to the kernel. Reviewed-by: Paul Kocialkowski Reviewed-by: Tomasz Figa

[PATCH v11 3/4] media: pixfmt: Add H264_SLICE_RAW format documentation

2019-05-24 Thread Paul Kocialkowski
From: Maxime Ripard The H264_SLICE_RAW format introduced before is meant for stateless decoders that will need the H264 parsed slice data without the start code. Let's document it. Signed-off-by: Maxime Ripard Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/pixfmt-compressed.rst | 25

[PATCH v11 2/4] media: pixfmt: Add H264 Slice format

2019-05-24 Thread Paul Kocialkowski
From: Maxime Ripard The H264_SLICE_RAW format is meant to hold the parsed slice data without the start code. This will be needed by stateless decoders. Signed-off-by: Maxime Ripard Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/media/h264-ctrls.h

[PATCH v11 4/4] media: cedrus: Add H264 decoding support

2019-05-24 Thread Paul Kocialkowski
From: Maxime Ripard Introduce some basic H264 decoding support in cedrus. So far, only the baseline profile videos have been tested, and some more advanced features used in higher profiles are not even implemented. Reviewed-by: Jernej Skrabec Reviewed-by: Paul Kocialkowski Signed-off-by

[PATCH v5 0/4] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-05-24 Thread Paul Kocialkowski
relevant platforms; * Switched over to tags instead of buffer indices in the DPB * Declared variable in their reduced scope as suggested; * Added the H.265/HEVC spec to the biblio; * Used in-doc references to the spec and the required APIs; * Removed debugging leftovers. Cheers! Paul Kocialkowski (4

[PATCH v5 2/4] media: pixfmt: Add HEVC slice pixel format

2019-05-24 Thread Paul Kocialkowski
format (with raw slice header), with slice controls attached. Signed-off-by: Paul Kocialkowski --- include/media/hevc-ctrls.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h index 9ea013c88afc..2de83d9f6d47 100644 --- a/include/media

[PATCH v5 3/4] media: pixfmt: Document the HEVC slice pixel format

2019-05-24 Thread Paul Kocialkowski
Document the current state of the HEVC slice pixel format. The format will need to evolve in the future, which is why it is not part of the public API. Signed-off-by: Paul Kocialkowski --- .../media/uapi/v4l/pixfmt-compressed.rst | 21 +++ 1 file changed, 21 insertions

[PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-24 Thread Paul Kocialkowski
This introduces the required definitions for HEVC decoding support with stateless VPUs. The controls associated to the HEVC slice format provide the required meta-data for decoding slices extracted from the bitstream. They are not exported to the public V4L2 API since reworking this API will be ne

[PATCH v5 4/4] media: cedrus: Add HEVC/H.265 decoding support

2019-05-24 Thread Paul Kocialkowski
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with both uni-directional and bi-directional prediction modes supported. Field-coded (interlaced) pictures, custom quantization matrices and 10-bit output are not supported at this point. Signed-off-by: Paul Kocialkowski

Re: [PATCH v5 1/4] media: v4l: Add definitions for the HEVC slice controls

2019-05-25 Thread Paul Kocialkowski
Hi Hans, On Sat, 2019-05-25 at 13:08 +0200, Hans Verkuil wrote: > Hi Paul, > > This patch is missing your Signed-of-by line! Can you reply with your SoB? Ouch, sorry about that. This is definitely: Signed-off-by: Paul Kocialkowski Cheers, Paul > Regards, > > Hans

Hardware-accelerated video decoders used through a firmware instead of hardware registers

2019-05-12 Thread Paul Kocialkowski
. What do you think? Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com

Re: Hardware-accelerated video decoders used through a firmware instead of hardware registers

2019-05-12 Thread Paul Kocialkowski
Hi Nicolas, Le dimanche 12 mai 2019 à 10:17 -0400, Nicolas Dufresne a écrit : > Le dimanche 12 mai 2019 à 13:35 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > With the work done on the media request API and the cedrus driver for > > Allwinner ARM SoCs, we now

Re: [linux-sunxi] [PATCH] drm/sun4i: Unbind components before releasing DRM and mem at master unbind

2019-04-19 Thread Paul Kocialkowski
Hi, On Fri, 2019-04-19 at 09:02 -0700, Chen-Yu Tsai wrote: > On Fri, Apr 19, 2019 at 1:03 AM Paul Kocialkowski > wrote: > > Our components may still be using the DRM device driver (if only to > > access our driver's private data), so make sure to unbind them before &g

Re: [PATCH v5 3/4] drm/vc4: Check for the binner bo before handling OOM interrupt

2019-04-23 Thread Paul Kocialkowski
Hi, On Mon, 2019-04-15 at 13:48 -0700, Eric Anholt wrote: > Paul Kocialkowski writes: > > > Since the OOM interrupt directly deals with the binner bo, it doesn't > > make sense to try and handle it without a binner buffer registered. > > > &g

Re: [PATCH v5 04/11] media: uapi: h264: Add the concept of start code

2019-08-14 Thread Paul Kocialkowski
eadable put like this, with START_CODE as a prefix since it's common to both options and the name of the enum: - V4L2_MPEG_VIDEO_H264_START_CODE_NONE - V4L2_MPEG_VIDEO_H264_START_CODE_ANNEX_B What do you think? Cheers, Paul > > +}; > > + > > #define V4L2_H264_SPS_CONSTRAINT_SET0_FLAG 0x01 > > #define V4L2_H264_SPS_CONSTRAINT_SET1_FLAG 0x02 > > #define V4L2_H264_SPS_CONSTRAINT_SET2_FLAG 0x04 > > > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v5 03/11] media: uapi: h264: Add the concept of decoding mode

2019-08-14 Thread Paul Kocialkowski
decoding modes. Drivers are > allowed to support only one decoding but they can support both too. > > Signed-off-by: Boris Brezillon > Reviewed-by: Paul Kocialkowski > Tested-by: Philipp Zabel > --- > Changes in v5: > * Improve specification as suggested by Hans. > Change

Re: [PATCH v7 0/4] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-07-31 Thread Paul Kocialkowski
Hi, On Tue 30 Jul 19, 09:27, Hans Verkuil wrote: > On 7/27/19 11:57 AM, Paul Kocialkowski wrote: > > Hi Hans, > > > > On Fri 26 Jul 19, 10:33, Hans Verkuil wrote: > >> On 7/25/19 8:55 PM, Paul Kocialkowski wrote: > >>> HEVC/H.265 stateless support for

Re: [PATCH 7/9] media: hantro: Add core bits to support H264 decoding

2019-08-01 Thread Paul Kocialkowski
for a similar side-buffer but give it a dedicated CMA allocation, which should allow dma-buf-imported buffers. Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v6 3/5] media: v4l: Add definitions for the HEVC slice controls

2019-07-25 Thread Paul Kocialkowski
Hi Hans and thanks for the review! On Mon 22 Jul 19, 16:40, Hans Verkuil wrote: > On 6/14/19 4:38 PM, Paul Kocialkowski wrote: > > This introduces the required definitions for HEVC decoding support with > > stateless VPUs. The controls associated to the HEVC slice format provide &

[PATCH v7 1/4] media: v4l2-ctrl: Add a comment on why we zero out compound controls fields

2019-07-25 Thread Paul Kocialkowski
Since it's not necessarily very explicit why we need to zero some fields in std_validate_compound, add a comment before the function to explain why, which should help as a reminder. Signed-off-by: Paul Kocialkowski --- drivers/media/v4l2-core/v4l2-ctrls.c | 4 1 file changed, 4 inser

[PATCH v7 3/4] media: pixfmt: Document the HEVC slice pixel format

2019-07-25 Thread Paul Kocialkowski
Document the current state of the HEVC slice pixel format. The format will need to evolve in the future, which is why it is not part of the public API. Signed-off-by: Paul Kocialkowski --- .../media/uapi/v4l/pixfmt-compressed.rst | 21 +++ 1 file changed, 21 insertions

[PATCH v7 4/4] media: cedrus: Add HEVC/H.265 decoding support

2019-07-25 Thread Paul Kocialkowski
This introduces support for HEVC/H.265 to the Cedrus VPU driver, with both uni-directional and bi-directional prediction modes supported. Field-coded (interlaced) pictures, custom quantization matrices and 10-bit output are not supported at this point. Signed-off-by: Paul Kocialkowski

[PATCH v7 2/4] media: v4l: Add definitions for the HEVC slice controls

2019-07-25 Thread Paul Kocialkowski
support; * No support for SPS extensions: range, multilayer, 3d, scc, 4 bits; * No support for PPS extensions: range, multilayer, 3d, scc, 4 bits. Signed-off-by: Paul Kocialkowski --- Documentation/media/uapi/v4l/biblio.rst | 9 + .../media/uapi/v4l/ext-ctrls-codec.rst| 486

[PATCH v7 0/4] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-07-25 Thread Paul Kocialkowski
instead of buffer indices in the DPB * Declared variable in their reduced scope as suggested; * Added the H.265/HEVC spec to the biblio; * Used in-doc references to the spec and the required APIs; * Removed debugging leftovers. Cheers! Paul Kocialkowski (4): media: v4l2-ctrl: Add a comment on why

Re: [PATCH] media: Clarify the meaning of file descriptors in VIDIOC_DQBUF

2019-06-18 Thread Paul Kocialkowski
hether those are new file descriptors referring to the same DMA-bufs or > just the same integers as passed to VIDIOC_QBUF back in time. Clarify > the documentation that it's the latter. LGTM, Reviewed-by: Paul Kocialkowski Cheers, Paul > Signed-off-by: Tomasz Figa > --- &g

Re: [PATCH] media: v4l-ctrl: add control for variable frame rate

2019-06-29 Thread Paul Kocialkowski
8_TRANSFORM: > > > case V4L2_CID_MPEG_VIDEO_H264_VUI_SAR_ENABLE: > > > case V4L2_CID_MPEG_VIDEO_MPEG4_QPEL: > > > diff --git a/include/uapi/linux/v4l2-controls.h > > > b/include/uapi/linux/v4l2-controls.h > > > index 06479f2fb3ae..f1bf52eb0152 100644 > > > --- a/include/uapi/linux/v4l2-controls.h > > > +++ b/include/uapi/linux/v4l2-controls.h > > > @@ -404,6 +404,9 @@ enum v4l2_mpeg_video_multi_slice_mode { > > > #define V4L2_CID_MPEG_VIDEO_MV_V_SEARCH_RANGE > > > (V4L2_CID_MPEG_BASE+228) > > > #define V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME > > > (V4L2_CID_MPEG_BASE+229) > > > > > > +#define V4L2_CID_MPEG_VIDEO_VFR_ENABLE (V4L2_CID_MPEG_BASE + 250) > > > +#define V4L2_CID_MPEG_VIDEO_VFR_MIN_FRAMERATE (V4L2_CID_MPEG_BASE + 251) > > > + > > > #define V4L2_CID_MPEG_VIDEO_H263_I_FRAME_QP > > > (V4L2_CID_MPEG_BASE+300) > > > #define V4L2_CID_MPEG_VIDEO_H263_P_FRAME_QP > > > (V4L2_CID_MPEG_BASE+301) > > > #define V4L2_CID_MPEG_VIDEO_H263_B_FRAME_QP > > > (V4L2_CID_MPEG_BASE+302) > > > > > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com

Re: [PATCH v5] media: docs-rst: Document m2m stateless video decoder interface

2019-07-22 Thread Paul Kocialkowski
tted request resulted in a ``CAPTURE`` buffer being held > > by the > > +use of the ``V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF`` flag, the last frame may > > not > > +be available on the ``CAPTURE`` queue. In this case, an extra request with > > an > > +empty ``OUTPUT`` buffer (e.g. which ``bytesused`` is set to 0) and a > > different > > which -> where > > > +timestamp can be queued. This will make the driver release the held > > ``CAPTURE`` > > +buffer without doing any extra processing. > > > > I don't like this. It's a special request which would require special > handling in > drivers. It just makes things more complicated. > > How about this: add a new command to VIDIOC_DECODER_CMD: > V4L2_DEC_CMD_END_OF_FRAME. > > A stateless decoder that supports HOLD_CAPTURE_BUF would implement support > for this > command to flush the last frame, if any. > > What do you think? > > Regards, > > Hans -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com

Re: [PATCH v6 0/5] HEVC/H.265 stateless support for V4L2 and Cedrus

2019-07-22 Thread Paul Kocialkowski
Hi, Any feedback on this series? I think it was pretty much ready for merge regarding the comments received so far. I could craft a rebased v7, with or without additional changes, if needed. What do you think? Cheers, Paul On Fri 14 Jun 19, 16:38, Paul Kocialkowski wrote: > This is ea

Re: [PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

2019-07-10 Thread Paul Kocialkowski
Hi, On Tue 09 Jul 19, 22:04, Joe Perches wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches Good catch, thanks! Acked-by: Paul Kocialkowski Cheers, Paul > --- > drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- > 1 file ch

Re: [PATCH] media: v4l: Add packed YUV444 24bpp pixel format

2019-07-11 Thread Paul Kocialkowski
> #define V4L2_PIX_FMT_YUV555 v4l2_fourcc('Y', 'U', 'V', 'O') /* 16 > YUV-5-5-5 */ > #define V4L2_PIX_FMT_YUV565 v4l2_fourcc('Y', 'U', 'V', 'P') /* 16 > YUV-5-6-5 */ > +#define V4L2_PIX_FMT_YUV24 v4l2_fourcc('Y', 'U', 'V', '3') /* 24 > YUV-8-8-8 */ > #define V4L2_PIX_FMT_YUV32 v4l2_fourcc('Y', 'U', 'V', '4') /* 32 > YUV-8-8-8-8 */ > #define V4L2_PIX_FMT_AYUV32 v4l2_fourcc('A', 'Y', 'U', 'V') /* 32 > AYUV-8-8-8-8 */ > #define V4L2_PIX_FMT_XYUV32 v4l2_fourcc('X', 'Y', 'U', 'V') /* 32 > XYUV-8-8-8-8 */ > -- > 2.7.4 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com

[PATCH v3 4/4] drm/vc4: Add a debugfs entry to disable/enable the load tracker

2019-01-08 Thread Paul Kocialkowski
tracker enabled. Signed-off-by: Paul Kocialkowski Signed-off-by: Boris Brezillon --- Changes since v3 (of the standalone patch): * Added a comment for the load_tracker_enabled field; * Moved the ->load_tracker_enabled initialization in vc4_kms_load(); * Moved the if (vc4->load_tracker_e

[PATCH v3 2/4] drm/vc4: Report underrun errors

2019-01-08 Thread Paul Kocialkowski
From: Boris Brezillon The DRM framework provides a generic way to report underrun errors. Let's implement the necessary hooks to support it in the VC4 driver. Signed-off-by: Boris Brezillon --- Changes in v3: - Generic underrun report function has been dropped, adjust the code accordingly Ch

[PATCH v3 0/4] drm/vc4: Add a load tracker

2019-01-08 Thread Paul Kocialkowski
introduced, which fixes underrun reports when reconfiguring the display pipeline. A detailed changelog is available on each patch when applicable. Cheers, Paul Boris Brezillon (2): drm/vc4: Report underrun errors drm/vc4: Add a load tracker to prevent HVS underflow errors Paul Kocialkowski (2

[PATCH v3 3/4] drm/vc4: Add a load tracker to prevent HVS underflow errors

2019-01-08 Thread Paul Kocialkowski
From: Boris Brezillon The HVS block is supposed to fill the pixelvalve FIFOs fast enough to meet the requested framerate. The problem is, the HVS and memory bus bandwidths are limited, and if we don't take these limitations into account we might end up with HVS underflow errors. This patch is tr

[PATCH v3 1/4] drm/vc4: Wait for display list synchronization when completing commit

2019-01-08 Thread Paul Kocialkowski
each enabled channel of the HVS to synchronize its current display list address. This fixes the issue of random underrun reporting on commits. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/vc4/vc4_hvs.c | 17 + drivers/gpu/drm/vc4/vc4_

[PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Paul Kocialkowski
the current destination buffer before resorting to vb2_find_timestamp and use it in MPEG-2. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus_dec.c | 13 + drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 2 ++ drivers/staging/media/sunxi/cedrus

[PATCH 1/2] media: cedrus: Cleanup duplicate declarations from cedrus_dec header

2019-01-09 Thread Paul Kocialkowski
Some leftover declarations are still in the cedrus_dec header although they were moved to cedrus_video already. Clean them up. Signed-off-by: Paul Kocialkowski --- drivers/staging/media/sunxi/cedrus/cedrus_dec.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/media

Re: [PATCH 2/2] media: cedrus: Allow using the current dst buffer as reference

2019-01-09 Thread Paul Kocialkowski
Hi, On Wed, 2019-01-09 at 15:29 +0100, Hans Verkuil wrote: > On 01/09/19 15:19, Paul Kocialkowski wrote: > > It was reported that some cases of interleaved video decoding require > > using the current destination buffer as a reference. However, this is > > no longer possi

Re: [PATCH v3 1/4] drm/vc4: Wait for display list synchronization when completing commit

2019-01-09 Thread Paul Kocialkowski
Hi Daniel, On Tue, 2019-01-08 at 19:21 +0100, Daniel Vetter wrote: > On Tue, Jan 8, 2019 at 3:51 PM Paul Kocialkowski > wrote: > > During an atomic commit, the HVS is configured with a display list > > for the channel matching the associated CRTC. The Pixel Valve (CRTC) > &

Re: [PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-13 Thread Paul Kocialkowski
when all frames depending on it have been decoded. So I am leaning > towards not complicating matters and keeping your first sentence > as-is. Yes, I believe it would be much simpler to require userspace to only queue capture buffers once they are no longer needed as references. This also means that the dmabuf fd can't be changed so we are guaranteed that memory will still be there. Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com

Re: [PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-13 Thread Paul Kocialkowski
Hi, On Wed, 2019-02-13 at 10:57 +0100, Hans Verkuil wrote: > On 2/13/19 10:20 AM, Paul Kocialkowski wrote: > > Hi, > > > > On Wed, 2019-02-13 at 09:59 +0100, Hans Verkuil wrote: > > > On 2/13/19 6:58 AM, Alexandre Courbot wrote: > > > > On Wed,

Re: [PATCH 2/7] drm/vc4: Use drm_print_regset32() for our debug register dumping.

2019-03-22 Thread Paul Kocialkowski
Hi, Le mercredi 20 février 2019 à 13:03 -0800, Eric Anholt a écrit : > This removes a bunch of duplicated boilerplate for the debugfs vs > runtime printk debug dumping. This is: Reviewed-by: Paul Kocialkowski Cheers, Paul > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2019-03-22 Thread Paul Kocialkowski
bit, because I encountered this bug today. > > > > > > On Thu, Mar 21, 2019 at 11:02:10AM +0100, Bin Liu wrote: > > > > On Sat, Apr 21, 2018 at 12:59:23PM +0200, Paul Kocialkowski wrote: > > > > > Hi, > > > > > > > > > > L

Re: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-18 Thread Paul Kocialkowski
elper for similar lookup on legacy PHYs and > > it's > > probably not worth the effort to add it. > > > > When no legacy USB PHY is found by phandle, fallback to grabbing any > > registered > > USB2 PHY. This ensures backward compatibility if some users we

Re: [PATCH 5/7] drm/vc4: Disable V3D interactions if the v3d component didn't probe.

2019-03-25 Thread Paul Kocialkowski
= of_find_compatible_node(NULL, NULL, "brcm,bcm2835-v3d"); It looks like we support more compatibles than this one, so it could be worth having a separate helper to check if we can find a v3d-compatible node. It could certainly reuse the platform driver's of_match_table; With tha

Re: [PATCH] ARM: dts: imx6qdl-cubox-i: Move card-detect GPIO to 1.5 SOM devices only

2018-04-22 Thread Paul Kocialkowski
Hi, Le dimanche 22 avril 2018 à 15:39 +0100, Russell King - ARM Linux a écrit : > On Sun, Apr 22, 2018 at 04:21:51PM +0200, Paul Kocialkowski wrote: > > The Solid-Run CuBox-i lower board used in the first generation of > > CuBox-i devices feature a hinged micro SD card slot

Re: [PATCH] ARM: dts: imx6qdl-cubox-i: Move card-detect GPIO to 1.5 SOM devices only

2018-04-22 Thread Paul Kocialkowski
Hi, Le dimanche 22 avril 2018 à 15:02 +, Jon Nettleton a écrit : > On Sun, Apr 22, 2018 at 4:39 PM Russell King - ARM Linux ux.org.uk> wrote: > > On Sun, Apr 22, 2018 at 04:21:51PM +0200, Paul Kocialkowski wrote: > > > The Solid-Run CuBox-i lower board used in th

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-04-20 at 09:39 +0200, Maxime Ripard wrote: > On Thu, Apr 19, 2018 at 05:45:35PM +0200, Paul Kocialkowski wrote: > > This adds nodes for the Video Engine and the associated reserved > > memory > > for the Allwinner A20. Up to 96 MiB of memory are ded

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-05-04 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-26 at 22:04 -0500, Rob Herring wrote: > On Fri, Apr 20, 2018 at 09:22:20AM +0200, Paul Kocialkowski wrote: > > Hi and thanks for the review, > > > > On Fri, 2018-04-20 at 01:31 +, Tomasz Figa wrote: > > > Hi Paul, Philipp, > > >

Re: [PATCH v2 07/10] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-04 Thread Paul Kocialkowski
Hi, On Tue, 2018-04-24 at 12:13 +0300, Sakari Ailus wrote: > Hi Paul > > On Thu, Apr 19, 2018 at 05:45:33PM +0200, Paul Kocialkowski wrote: > > This introduces the Sunxi-Cedrus VPU driver that supports the VPU > > found > > in Allwinner SoCs, also known as Vide

Re: [PATCH v2 06/10] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-04-20 at 15:59 +0200, Hans Verkuil wrote: > On 04/19/18 17:45, Paul Kocialkowski wrote: > > This introduces support for Allwinner's MB32-tiled NV12 format, > > where > > each plane is divided into macroblocks of 32x32 pixels. Hence, the > >

Re: [PATCH v2 02/10] media-request: Add a request complete operation to allow m2m scheduling

2018-05-04 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-19 at 17:41 +0200, Paul Kocialkowski wrote: > When using the request API in the context of a m2m driver, the > operations that come with a m2m run scheduling call in their > (m2m-specific) ioctl handler are delayed until the request is queued > (for instance, t

Re: [PATCH v2 03/10] videobuf2-core: Add helper to get buffer private data from media request

2018-05-04 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-19 at 17:41 +0200, Paul Kocialkowski wrote: > When calling media operation driver callbacks related to media > requests, > only a pointer to the request itself is provided, which is > insufficient > to retrieve the driver's context. Since the driver context

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
Hi, On Tue, 2018-04-24 at 12:01 +0300, Sakari Ailus wrote: > Hi Paul, > > On Thu, Apr 19, 2018 at 05:45:31PM +0200, Paul Kocialkowski wrote: > > Stateless video decoding engines require both the MPEG slices and > > associated metadata from the video stream in o

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-04-20 at 15:57 +0200, Hans Verkuil wrote: > On 04/19/18 17:45, Paul Kocialkowski wrote: > > Stateless video decoding engines require both the MPEG slices and > > associated metadata from the video stream in order to decode frames. > > > > This intro

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-04-20 at 09:51 +, Tomasz Figa wrote: > Hi Paul, > > On Fri, Apr 20, 2018 at 12:46 AM Paul Kocialkowski < > paul.kocialkow...@bootlin.com> wrote: > [snip] > > +struct v4l2_ctrl_mpeg2_frame_hdr { > > + __u32 slice_len; > > +

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-05-04 at 10:40 +0200, Maxime Ripard wrote: > On Fri, May 04, 2018 at 09:49:16AM +0200, Paul Kocialkowski wrote: > > > > + reserved-memory { > > > > + #address-cells = <1>; > > > > + #siz

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
On Thu, 2018-04-19 at 17:45 +0200, Paul Kocialkowski wrote: > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > with M

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
On Fri, 2018-05-04 at 10:47 +0200, Paul Kocialkowski wrote: > > > > Don't you also need to map the SRAM on the A20? > > > > > > That's a good point, there is currently no syscon handle for A20 > > > (and > > > also A13). Maybe SRAM is mux

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-05-04 at 11:15 +0200, Maxime Ripard wrote: > On Fri, May 04, 2018 at 10:47:44AM +0200, Paul Kocialkowski wrote: > > > > > > + reg = <0x01c0e000 0x1000>; > > > > > > + memory-region = <&ve_

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
On Fri, 2018-05-04 at 15:40 +0200, Maxime Ripard wrote: > On Fri, May 04, 2018 at 02:04:38PM +0200, Paul Kocialkowski wrote: > > On Fri, 2018-05-04 at 11:15 +0200, Maxime Ripard wrote: > > > On Fri, May 04, 2018 at 10:47:44AM +0200, Paul

[PATCH 1/3] drm/panel: Add RGB666 variant of Innolux AT070TN90

2018-05-06 Thread Paul Kocialkowski
device-tree property to specify the bus format and maybe specify it in the mode description instead of panel description so that the appropriate mode can be selected for each bus format. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/panel/panel-simple.c | 26 ++ 1

[PATCH 2/3] ARM: dts: sun7i: Add RGB666 pins definition

2018-05-06 Thread Paul Kocialkowski
This adds the pins definition for RGB666 LCD panels on the A20. It was inspired by the A33 definition, that concernes the same set of pins. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun7i

[PATCH 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-06 Thread Paul Kocialkowski
dio output * Audio speakers * USB via SPCI connector The following are not supported: * Wi-Fi * Bluetooth * NAND * Audio via SPCI connector * Audio via Bluetooth I2S Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/sun7i-a20-ainol-aw1

Re: [PATCH 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-06 Thread Paul Kocialkowski
Le dimanche 06 mai 2018 à 22:56 +0200, Paul Kocialkowski a écrit : > This adds support for the Ainol AW1, an A20-based 7" tablet from > Ainol. > > The following board-specific features are supported: > * LCD panel > * Backlight > * USB OTG > * Buttons > * Touch

[PATCH v3 1/3] drm/panel: Add RGB666 variant of Innolux AT070TN90

2018-05-06 Thread Paul Kocialkowski
device-tree property to specify the bus format and maybe specify it in the mode description instead of panel description so that the appropriate mode can be selected for each bus format. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/panel/panel-simple.c | 26 ++ 1

[PATCH v3 2/3] ARM: dts: sun7i: Add RGB666 pins definition

2018-05-06 Thread Paul Kocialkowski
This adds the pins definition for RGB666 LCD panels on the A20. It was inspired by the A33 definition, that concernes the same set of pins. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun7i

[PATCH v3 3/3] ARM: dts: sun7i: Add support for the Ainol AW1 tablet

2018-05-06 Thread Paul Kocialkowski
dio output * Audio speakers * USB via SPCI connector The following are not supported: * Wi-Fi * Bluetooth * NAND * Audio via SPCI connector * Audio via Bluetooth I2S Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/sun7i-a20-ainol-aw1

[PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31

2018-04-19 Thread Paul Kocialkowski
: Paul Kocialkowski --- drivers/gpu/drm/sun4i/sun4i_frontend.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c b/drivers/gpu/drm/sun4i/sun4i_frontend.c index 85f75046712c..c5a3de11817d 100644 --- a/drivers/gpu/drm/sun4i/sun4i_frontend.c +++ b/drivers/gpu

Re: [PATCH 6/9] sunxi-cedrus: Add device tree binding document

2018-04-19 Thread Paul Kocialkowski
Hi, On Sun, 2018-03-18 at 07:48 -0500, Rob Herring wrote: > On Fri, Mar 09, 2018 at 11:14:42AM +0100, Paul Kocialkowski wrote: > > From: Florent Revest > > "device tree binding document" can all be summarized with the subject > prefix "dt-bindings: media: &

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-04-19 Thread Paul Kocialkowski
Hi, On Mon, 2018-03-12 at 17:15 +, Joonas Kylmälä wrote: > Paul Kocialkowski: > > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus_regs.h > > new file mode 100644 > > index ..738

Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-04-19 Thread Paul Kocialkowski
Hi, On Mon, 2018-03-12 at 20:29 +, Joonas Kylmälä wrote: > Paul Kocialkowski: > > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > > new file mode 100644 > > index ..88624035e0e3

Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver

2018-04-19 Thread Paul Kocialkowski
Hi and thanks for the review, On Fri, 2018-03-09 at 14:57 +0100, Maxime Ripard wrote: > On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote: > > +/* > > + * mem2mem callbacks > > + */ > > + > > +void job_abort(void *priv) > > +{} > >

[PATCH v2 03/10] videobuf2-core: Add helper to get buffer private data from media request

2018-04-19 Thread Paul Kocialkowski
his allows scheduling m2m device runs from the newly-introduced request complete operation. Signed-off-by: Paul Kocialkowski --- drivers/media/common/videobuf2/videobuf2-core.c | 15 +++ include/media/videobuf2-core.h | 1 + 2 files changed, 16 insertions(+) diff --git

[PATCH v2 00/10] Sunxi-Cedrus driver for the Allwinner Video Engine, using media requests

2018-04-19 Thread Paul Kocialkowski
aders text rework. Remaining tasks: * using the dedicated SRAM controller driver; * cleaning up registers description and documenting the fields used; * removing the assigned-clocks property and setting the clock rate in the driver directly; * testing on more platforms. Cheers! Paul Kocialkowsk

[PATCH v2 01/10] media: v4l2-ctrls: Add missing v4l2 ctrl unlock

2018-04-19 Thread Paul Kocialkowski
This adds a missing v4l2_ctrl_unlock call that is required to avoid deadlocks. Signed-off-by: Paul Kocialkowski --- drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2

[PATCH v2 04/10] media: vim2m: Implement media request complete op to schedule m2m run

2018-04-19 Thread Paul Kocialkowski
This adds an implementation of the media request complete operation for the vim2m driver, that ensures that the driver will try to schedule a m2m run whenever a request was completed. Without this operation, no m2m device run will be scheduled in many scenarios. Signed-off-by: Paul Kocialkowski

[PATCH v2 02/10] media-request: Add a request complete operation to allow m2m scheduling

2018-04-19 Thread Paul Kocialkowski
held, that is eventually needed in the device_run call to apply relevant controls. Signed-off-by: Paul Kocialkowski --- drivers/media/media-request.c | 3 +++ include/media/media-device.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/media/media-request.c b/drivers/media/media-requ

[PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-04-19 Thread Paul Kocialkowski
This adds a device-tree binding document that specifies the properties used by the Sunxi-Cedurs VPU driver, as well as examples. Signed-off-by: Paul Kocialkowski --- .../devicetree/bindings/media/sunxi-cedrus.txt | 50 ++ 1 file changed, 50 insertions(+) create mode

[PATCH v2 07/10] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-04-19 Thread Paul Kocialkowski
community in the interest of reverse engineering, documenting and implementing support for Allwinner VPU. Signed-off-by: Florent Revest Signed-off-by: Paul Kocialkowski --- drivers/media/platform/Kconfig | 15 + drivers/media/platform/Makefile| 1 + drivers

[PATCH v2 10/10] ARM: dts: sun8i-a33: Add Video Engine and reserved memory nodes

2018-04-19 Thread Paul Kocialkowski
tream software, the last 96 MiB of the first 256 MiB of RAM are reserved for this purpose. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a33.dtsi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm

[PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-04-19 Thread Paul Kocialkowski
tream software, the last 96 MiB of the first 256 MiB of RAM are reserved for this purpose. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun7i-a20.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boo

[PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-04-19 Thread Paul Kocialkowski
(metadata) to drivers. Signed-off-by: Paul Kocialkowski Signed-off-by: Florent Revest --- drivers/media/v4l2-core/v4l2-ctrls.c | 10 ++ drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/v4l2-controls.h | 26 ++ include/uapi/linux/videodev2.h | 3

[PATCH v2 06/10] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-04-19 Thread Paul Kocialkowski
after line. The MB32-tiled NV12 format is used by the video engine on Allwinner platforms: it is the default format for decoded frames (and the only one available in the oldest supported platforms). Signed-off-by: Paul Kocialkowski --- include/uapi/linux/videodev2.h | 1 + 1 file changed, 1 inse

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-04-20 Thread Paul Kocialkowski
Hi and thanks for the review, On Fri, 2018-04-20 at 01:31 +, Tomasz Figa wrote: > Hi Paul, Philipp, > > On Fri, Apr 20, 2018 at 1:04 AM Philipp Zabel > wrote: > > > Hi Paul, > > On Thu, 2018-04-19 at 17:45 +0200, Paul Kocialkowski wrote: > > > This adds

Re: [PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31

2018-04-20 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-19 at 17:07 +0200, Maxime Ripard wrote: > On Thu, Apr 19, 2018 at 02:56:38PM +0200, Paul Kocialkowski wrote: > > Although frontend nodes are defined in the device-trees of the > > aforementioned platforms, there are no matching compatibles defined > > in

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-21 Thread Paul Kocialkowski
Hi, Le mardi 03 avril 2018 à 11:29 +0200, Maxime Ripard a écrit : > Hi, > > On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wr

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

2018-04-21 Thread Paul Kocialkowski
Hi, Le vendredi 20 avril 2018 à 09:25 -0500, Bin Liu a écrit : > On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > > Hi, > > > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkow

[PATCH] ARM: dts: imx6qdl-cubox-i: Move card-detect GPIO to 1.5 SOM devices only

2018-04-22 Thread Paul Kocialkowski
-i devices, the pin control properties are kept untouched regardless of the slot capability. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/imx6dl-cubox-i-emmc-som-v15.dts | 4 arch/arm/boot/dts/imx6dl-cubox-i-som-v15.dts | 4 arch/arm/boot/dts/imx6q-cubox-i-emmc-som-v15

Re: [PATCH v4 1/3] drm/panel: Add RGB666 variant of Innolux AT070TN90

2018-05-09 Thread Paul Kocialkowski
Hi, On Wed, 2018-05-09 at 09:12 +0200, Maxime Ripard wrote: > On Tue, May 08, 2018 at 12:04:11AM +0200, Paul Kocialkowski wrote: > > This adds timings for the RGB666 variant of the Innolux AT070TN90 panel, > > as found on the Ainol AW1 tablet. > > > > The panel also s

[PATCH v3 08/14] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-07 Thread Paul Kocialkowski
the frame header (metadata) to drivers. Signed-off-by: Florent Revest Signed-off-by: Paul Kocialkowski --- drivers/media/v4l2-core/v4l2-ctrls.c | 10 ++ drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/v4l2-controls.h | 26 ++ include/uapi/linux

[PATCH v3 09/14] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-05-07 Thread Paul Kocialkowski
after line. The MB32-tiled NV12 format is used by the video engine on Allwinner platforms: it is the default format for decoded frames (and the only one available in the oldest supported platforms). Signed-off-by: Paul Kocialkowski --- include/uapi/linux/videodev2.h | 1 + 1 file changed, 1 inse

<    1   2   3   4   5   6   7   8   9   >