Fixed parenthesis alignment checkpatch checks as per kernel coding style
guidelines in hal_init.c
---
drivers/staging/rtl8712/hal_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 0c7
Added missing signed off by line and fixed alignment to match
open parenthesis.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/hal_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
Signed-off-by: Parth Sane
---
Changes in v3:
-Added missing signed off by line and fixed alignment to match
open parenthesis.
-Fixed location of message
drivers/staging/rtl8712/hal_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 0c76fbc..0dd458d 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
Fixed alignment to match open parenthesis.
Signed-off-by: Parth Sane
---
Changes in v5:
-Fixed missing commit messages.
drivers/staging/rtl8712/hal_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging
Fixed alignment to match open parenthesis.
Signed-off-by: Parth Sane
---
Changes in v6:
-Added line before Signed-off message
drivers/staging/rtl8712/hal_init.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers
Hi,
Thanks for the feedback. I did find this issue with the assistance
checkpatch.pl script.
Regards,
Parth Sane
> On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt
> wrote:
>
> On 25/04/16 16:43, Parth Sane wrote:
>> Fixed alignment to match open parenthesis.
>>
>
Hi,
Yes you are right on that regard. I did do that in my previous patches.
It’s just something that I will have to remember now onwards. Thanks.
Regards,
Parth Sane
> On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt
> wrote:
>
> On 26/04/16 15:33, Parth Sane wrote:
>> Hi,
No mate, that aint just cutting it.
I tried putting it, maybe i’m doing something wrong?
Regards,
Parth
> On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt
> wrote:
>
> On 08/06/16 12:58, Parth Sane wrote:
>> I’m trying to fix line 224 but its simply not happening. Can you hel
Multiple parenthesis alignment warnings were thrown by checkpatch in ieee80211.c
This patch effectively fixes that.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/ieee80211.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging
> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt
> wrote:
>
> On 08/06/16 12:27, Parth Sane wrote:
>> Multiple parenthesis alignment warnings were thrown by checkpatch in
>> ieee80211.c
>> This patch effectively fixes that.
>>
>> Signed-off-by:
I’m trying to fix line 224 but its simply not happening. Can you help me with
this?
Regards,
Parth
> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt
> wrote:
>
> On 08/06/16 12:37, Parth Sane wrote:
>>
>>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt
>>&g
Hi,
Please ignore the previous patch. I’ll be sending in one soon again since the
earlier one sent more warning. Apologies for any inconvenience.
Regards,
Parth Sane
> On 11-Mar-2016, at 2:13 PM, laerdevstud...@gmail.com wrote:
>
> From: Parth Sane
>
> diff --git a/drivers/s
Hi,
I forgot to add the signed off part in the patch please ignore the previous
patches I have sent. Please bear with a kernel newbie.
Regards,
Parth Sane
> On 11-Mar-2016, at 2:45 PM, laerdevstud...@gmail.com wrote:
>
> From: Parth Sane
>
> diff --git a/drivers/staging/netlogic
Using comparison to false and true is error prone. Fixed multiple warnings as
per checkpatch guidelines.
Signed-off-by: Parth Sane
---
drivers/staging/vt6656/wcmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging
Using comparison to false and true is error prone. Fixed multiple warnings as
per checkpatch guidelines.
Signed-off-by: Parth Sane
---
drivers/staging/vt6656/main_usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging
From: Ubuntu
Fixed alignment of paranthesis as per checkpatch.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index
Fixed alignment of paranthesis as per checkpatch.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index daee1b2
Fixed alignment of paranthesis as per checkpatch. Please ignore earlier sent
patch for paranthesis check and use this one.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic
Fixed alignment of parenthesis checkpatch warning to fit coding standards.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic
Fixed checkpatch warnings about parenthesis alignment at line #186.
Signed-off-by: Parth Sane
---
drivers/staging/netlogic/platform_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
repeating work. I apologise for
any inconvenience.
Regards,
Parth Sane
signature.asc
Description: Message signed with OpenPGP using GPGMail
Removed copyright notice as per checkpatch check warning.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 29e47e1..ae79047 100644
--- a
Removed FSF address notice which causes checkpatch warning.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 29e47e1..ae79047 100644
--- a
Removed checkpatch warning caused by FSF address paragraph.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/ethernet.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ethernet.h
b/drivers/staging/rtl8712/ethernet.h
index fad173f..039da36 100644
--- a
Removed checkpatch warning caused by FSF address block
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/hal_init.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 8008efe..225ef37 100644
--- a/drivers
Removed checkpatch warning caused due to FSF address paragraph
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/ieee80211.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging/rtl8712/ieee80211.c
index d13b4d5..8918654 100644
--- a
Removed checkpatch warning caused due to FSF address paragraph
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/mlme_linux.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c
b/drivers/staging/rtl8712/mlme_linux.c
index e4e4bde..f124d72 100644
Fixed multiple parenthesis alignment warnings.
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/hal_init.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 225ef37..afa7fe78 100644
--- a
> On 20-Mar-2016, at 7:56 PM, Larry Finger wrote:
>
> On 03/20/2016 08:59 AM, Parth Sane wrote:
>> Removed checkpatch warning caused by FSF address block
>> Signed-off-by: Parth Sane
>> ---
>> drivers/staging/rtl8712/hal_init.c | 4
>> 1 file chang
> On 20-Mar-2016, at 9:18 PM, Joe Perches wrote:
>
> On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote:
>> Fixed multiple parenthesis alignment warnings.
>> Signed-off-by: Parth Sane
>
> Please always add a blank line after your changelog and
> before your &q
*** BLURB HERE ***
Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
index 29e47e1..ae79047 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/basic_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/basic_types.h
b/drivers/staging/rtl8712/basic_types.h
index 7561bed..f5c0231 100644
--- a/drivers/staging/rtl8712/basic_types.h
+++ b/drivers
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/ethernet.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ethernet.h
b/drivers/staging/rtl8712/ethernet.h
index fad173f..039da36 100644
--- a/drivers/staging/rtl8712/ethernet.h
+++ b/drivers/staging/rtl8712
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/ieee80211.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging/rtl8712/ieee80211.c
index d13b4d5..8918654 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging
Signed-off-by: Parth Sane
---
drivers/staging/rtl8712/hal_init.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 17d2b5f..afa7fe78 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712
> On 20-Mar-2016, at 10:03 PM, Roger H Newell wrote:
>
>
> On Mar 20, 2016 1:21 PM, "Parth Sane" wrote:
> >
> >
> > > On 20-Mar-2016, at 9:18 PM, Joe Perches wrote:
> > >
> > > On Sun, 2016-03-20 at 14:33 +, Parth San
> Fixed Multiple FSF address checkpatch warnings to conform to kernel coding
> style.
>
> Parth Sane (5):
> staging: rtl8712: Fixed FSF address warning in basic_types.h
> staging: rtl8712: Fixed FSF address warning in drv_types.h
> staging: rtl9712: Fixed FSF address
Fixed checkpatch check caused by FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/ethernet.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ethernet.h
b/drivers/staging
Fixed checkpatch warning caused due to FSF address block.
Linux already has a copy of the GPL, so as per checkpatch this address block is
unnecessary.
Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
Fixed checkpatch check caused by FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/basic_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/basic_types.h
b/drivers
Fixed checkpatch warning caused due to FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message.
drivers/staging/rtl8712/hal_init.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers
Fixed checkpatch check caused by FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers
Fixed checkpatch warning caused to FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v2:
- Added commit message
drivers/staging/rtl8712/ieee80211.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/ethernet.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/ieee80211.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712
Fixed checkpatch warning after removing FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/basic_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging
Fixed Multiple FSF address checkpatch warnings to conform to kernel coding
style.
Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl8712: Fixed FSF address warning in ethernet.h
staging
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/drv_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane
---
Changes in v3:
- Fixed subject
- Fixed commit message
drivers/staging/rtl8712/hal_init.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712
51 matches
Mail list logo