Re: [PATCHv5 11/11] fbdev: ssd1307fb: Add blank mode

2015-03-25 Thread Olliver Schinagl
Hey Thomas, On 24-03-15 22:23, Thomas Niederprüm wrote: This patch adds ssd1307fb_blank() to make the framebuffer capable of blanking. Signed-off-by: Thomas Niederprüm --- drivers/video/fbdev/ssd1307fb.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/video/fbdev/

Re: [PATCHv5 04/11] fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT

2015-03-25 Thread Olliver Schinagl
;prechargep2)) + par->prechargep2 = 0; Why set the default to 0 here? The datasheet sets it to 0x2 by default for example. + + par->seg_remap = !of_property_read_bool(node, "solomon,segment-no-remap"); + par->com_seq = of_property_read_bool(node, "solomo

[PATCH] gpio: correctly use const char * const

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl On my previous patch I was overly hasty and made the suffixes string array const char const *suffixes, instaed of const char * const suffixes. This patch corrects that Signed-off-by: Olliver Schinagl --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 0/4] Let leds use named gpios

2015-01-21 Thread Olliver Schinagl
s and if that fails, fall back to standard gpios for the users of devm_get_gpiod_from_child. Olliver Schinagl (4): gpio: use sizeof() instead of hardcoded values gpio: add parameter to allow the use named gpios leds: Let the binding document example for leds-gpio follow the gpio bin

[PATCH v2 1/4] gpio: use sizeof() instead of hardcoded values

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl gpiolib uses a fixed string for the suffixes and defines it at 32 bytes. Later in the code snprintf is used with this fixed value of 32. Using sizeof() is safer in case the size for the suffixes is ever changed. Signed-off-by: Olliver Schinagl --- drivers/gpio/gpiolib.c

[PATCH v2 2/4] gpio: add parameter to allow the use named gpios

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl The gpio binding document says that new code should always use named gpios. Patch 40b73183 added support to parse a list of gpios from child nodes, but does not make it possible to use named gpios. This patch adds the con_id property and implements it is done in gpiolib.c

[PATCH v2 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl In the gpio bindings documents it is requested to use the marco's in include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led drivers don't seem to form an exception, so update the example in the document bindings. Signed-off-by: Olliver Schinagl

[PATCH v2 4/4] leds: no longer use unnamed gpios

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl The gpio document says we should not use unnamed bindings for gpios. This patch uses the 'led-' prefix to the gpios and updates code and documents. Because the devm_get_gpiod_from_child() falls back to using old-style unnamed gpios, we can update the code first,

Re: [PATCH v1 2/4] gpio: add parameter to allow the use named gpios

2015-01-21 Thread Olliver Schinagl
Hey Alexandre, On 01/19/2015 05:04 AM, Alexandre Courbot wrote: On Wed, Jan 7, 2015 at 6:08 PM, Olliver Schinagl wrote: From: Olliver Schinagl The gpio binding document says that new code should always use named gpios. Patch 40b73183 added support to parse a list of gpios from child nodes

[PATCH] hrtimer: add hrtimer_start_now()

2015-01-21 Thread Olliver Schinagl
From: Olliver Schinagl When using a hrtimer for repeating periodic ticks, hrtimer_forward_now() is often used. Quite possibly the timer loop is thus probably fully controlled by hrtimer_forward_now() and we don't really care when the timer is started. With hrtimer_start() we need to d

Re: [PATCH v2 4/4] leds: no longer use unnamed gpios

2015-01-22 Thread Olliver Schinagl
Hey Rojhalat, On 22-01-15 10:32, Rojhalat Ibrahim wrote: On Wednesday 21 January 2015 22:33:48 Olliver Schinagl wrote: From: Olliver Schinagl The gpio document says we should not use unnamed bindings for gpios. This patch uses the 'led-' prefix to the gpios and updates code and

Re: [PATCH] hrtimer: add hrtimer_start_now()

2015-01-22 Thread Olliver Schinagl
Hey Thomas, On 22-01-15 12:01, Thomas Gleixner wrote: On Thu, 22 Jan 2015, Olliver Schinagl wrote: From: Olliver Schinagl When using a hrtimer for repeating periodic ticks, hrtimer_forward_now() is often used. Quite possibly the timer loop is thus probably fully controlled by

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-20 Thread Olliver Schinagl
Hey Ricardo, On 19-04-16 15:42, Ricardo Ribalda Delgado wrote: Hi again On Tue, Apr 19, 2016 at 3:27 PM, Olliver Schinagl wrote: Hey Ricardo, Without actually looking at the code right now, but the driver does a read/modify/write on the register, and a register is shared among several leds

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-20 Thread Olliver Schinagl
Hey Ricardo, On 20-04-16 10:01, Ricardo Ribalda Delgado wrote: Hi Ollivier On Wed, Apr 20, 2016 at 9:21 AM, Olliver Schinagl wrote: What I am propossing is at probe(): replace: if (pdata) { /* Configure output: open-drain or totem pole (push-pull) */ if (pdata->out

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-20 Thread Olliver Schinagl
On 20-04-16 10:56, Ricardo Ribalda Delgado wrote: Hi On Wed, Apr 20, 2016 at 10:51 AM, Olliver Schinagl wrote: As I said before, the reason for this proposal is that the code NEVER clears PCA963X_MODE2_DMBLNK, only sets it. Unfortunately I do not have the HW to test this change. The code

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-20 Thread Olliver Schinagl
Hey, On 20-04-16 11:17, Ricardo Ribalda Delgado wrote: Hello again On Wed, Apr 20, 2016 at 11:06 AM, Olliver Schinagl wrote: The devil is in the details :) :) Saving mode2 sounds like a good compromise then. But I still believe that we should limit the lock to ledout. No matter what we

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-22 Thread Olliver Schinagl
Hi Ricardo, On 20-04-16 11:17, Ricardo Ribalda Delgado wrote: Hello again On Wed, Apr 20, 2016 at 11:06 AM, Olliver Schinagl wrote: The devil is in the details :) :) Saving mode2 sounds like a good compromise then. But I still believe that we should limit the lock to ledout. No matter

Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted

2016-04-22 Thread Olliver Schinagl
Hey Rob, On 21-04-16 17:07, Rob Herring wrote: On Tue, Apr 19, 2016 at 09:40:49AM +0200, Olliver Schinagl wrote: When leds are connected in a totem-pole configuration, they can be connected either in a active-high, or active-low manor. The driver currently always assumes active-high. This

Re: [PATCH 5/6] leds: pca963x: Inform the output that it is inverted

2016-04-22 Thread Olliver Schinagl
On April 22, 2016 3:09:35 PM CEST, Rob Herring wrote: >On Fri, Apr 22, 2016 at 7:38 AM, Olliver Schinagl >wrote: >> Hey Rob, >> >> On 21-04-16 17:07, Rob Herring wrote: >>> >>> On Tue, Apr 19, 2016 at 09:40:49AM +0200, Olliver Schinagl wrote: >>

[PATCHv1 0/2] mmc: Move broken-hpi also to the chipset level

2016-04-19 Thread Olliver Schinagl
those should in theory be removed from the boards in question in a separate patch when in agreement, as technically, the eMMC module supports HPI just fine and thus the we are lying about what really is broken. This was tested on an OLinuXino Lime2 with 4GB industrial grade Micron eMMC flash. Ol

[PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Olliver Schinagl
n-hpi, which allows us to mark a broken hpi implementation on the host level. Signed-off-by: Olliver Schinagl --- drivers/mmc/core/host.c | 2 ++ drivers/mmc/core/mmc.c | 2 +- include/linux/mmc/host.h | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/hos

[PATCH 2/2] mmc: sunxi: Mark the HPI of the mmc controller broken by default

2016-04-19 Thread Olliver Schinagl
So far it seems all sunxi MMC controllers have a broken HPI. Until proved otherwise, mark all sunxi mmc controllers as having a broken HPI. Signed-off-by: Olliver Schinagl --- drivers/mmc/host/sunxi-mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH 1/6] leds: pca963x: Alphabetize headers

2016-04-19 Thread Olliver Schinagl
Re-order headers so they are in alphabetical order. Signed-off-by: Olliver Schinagl --- drivers/leds/leds-pca963x.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c index 407eba1..8dabf7a 100644 --- a

[PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-19 Thread Olliver Schinagl
does some cleanups to please checkpatch, and removes a few magic values. Olliver Schinagl (6): leds: pca963x: Alphabetize headers leds: pca963x: Lock i2c r/w access leds: pca963x: Add defines and remove some magic values leds: pca963x: Reduce magic values leds: pca963x: Inform the output

[PATCH 3/6] leds: pca963x: Add defines and remove some magic values

2016-04-19 Thread Olliver Schinagl
This patch adds some more defines so that the driver can receive a little more future work. These new defines are then used throughout the existing code the remove some magic values. This patch does not produce any binary changes. Signed-off-by: Olliver Schinagl --- drivers/leds/leds-pca963x.c

[PATCH 2/6] leds: pca963x: Lock i2c r/w access

2016-04-19 Thread Olliver Schinagl
A pca963x device can have multiple leds with a single i2c channel to access them. Some of the registers are shared between each other. To ensure all i2c operations are atomic within an instance, we move some mutex locks slightly around to guard these access. Signed-off-by: Olliver Schinagl

[PATCH 5/6] leds: pca963x: Inform the output that it is inverted

2016-04-19 Thread Olliver Schinagl
or rather, that the behavior is inverted to what is normally expected. Signed-off-by: Olliver Schinagl --- Documentation/devicetree/bindings/leds/pca963x.txt | 1 + drivers/leds/leds-pca963x.c| 20 +--- include/linux/platform_data/leds-pca963x.h | 1

[PATCH 6/6] leds: pca963x: Remove whitespace and checkpatch problems

2016-04-19 Thread Olliver Schinagl
introduce any binary changes. Signed-off-by: Olliver Schinagl --- drivers/leds/leds-pca963x.c | 53 - 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c index 85dd506..5c4bf77 100644 --- a

[PATCH 4/6] leds: pca963x: Reduce magic values

2016-04-19 Thread Olliver Schinagl
This patch uses the newly introduced defines to further reduce magic values and magic shifts. These changes have a slightly bigger impact as they do introduce binary changes. There should be no logical changes however. Signed-off-by: Olliver Schinagl --- drivers/leds/leds-pca963x.c | 32

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-19 Thread Olliver Schinagl
whole set. Olliver On 04/19/2016 09:40 AM, Olliver Schinagl wrote: Using the pca963x for a while, I noticed something that may look like some i2c accessing issues where sometimes data was incorrectly written to the bus, possibly because we where not properly locking the i2c reads. Thoug

Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Olliver Schinagl
Hi Ulf, On 19-04-16 11:29, Ulf Hansson wrote: On 19 April 2016 at 09:12, Olliver Schinagl wrote: In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc device as to having an broken HPI implementation. After talking some with Hans, we now think it is actually the mmc

Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Olliver Schinagl
Hey Jaehoon, On 19-04-16 11:49, Jaehoon Chung wrote: Hi On 04/19/2016 06:42 PM, Olliver Schinagl wrote: Hi Ulf, On 19-04-16 11:29, Ulf Hansson wrote: On 19 April 2016 at 09:12, Olliver Schinagl wrote: In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc device as to

Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Olliver Schinagl
Hey Sergei, On 19-04-16 12:52, Sergei Shtylyov wrote: Hello. On 4/19/2016 10:12 AM, Olliver Schinagl wrote: In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc scripts/checkpatch.pl now enforces certain commit citing style, the commit summary should be specified too

Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

2016-04-19 Thread Olliver Schinagl
Hey Hans, On 19-04-16 13:22, Hans de Goede wrote: Hi, On 19-04-16 11:42, Olliver Schinagl wrote: Hi Ulf, On 19-04-16 11:29, Ulf Hansson wrote: On 19 April 2016 at 09:12, Olliver Schinagl wrote: In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc device as to having an

Re: [PATCHv1 0/6] leds: pca9653x: support inverted outputs and cleanups

2016-04-19 Thread Olliver Schinagl
lusive/easy to use. But I can remove unused defines if desired. For PCA963X_LEDOUT_LDR. Do not forget the parenthesis around led_num. Also replace %4 with &3 to be consisten.t Yeah, i'll check and fix that. Regards! On Tue, Apr 19, 2016 at 11:39 AM, Olliver Schinagl wrote

Re: [PATCH 04/10] pwm: core: use bitops

2015-11-06 Thread Olliver Schinagl
red or not. Olliver On 06-11-15 15:46, Thierry Reding wrote: On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote: From: Olliver Schinagl The pwm header defines bits manually while there is a nice bitops.h with a BIT() macro. Use the BIT() macro to set bits in pwm.h Signed-off-by: Ollive

Re: [PATCH 08/10] pwm: core: add pulse feature to the PWM framework

2015-11-06 Thread Olliver Schinagl
Hey Thierry, On 06-11-15 16:18, Thierry Reding wrote: On Mon, Oct 26, 2015 at 10:32:39PM +0100, Olliver Schinagl wrote: From: Olliver Schinagl Some hardware PWM's have the possibility to only send out one (or more) pulses. This can be quite a useful feature in case one wants or needs o

Re: [PATCH 08/10] pwm: core: add pulse feature to the PWM framework

2015-11-06 Thread Olliver Schinagl
Hey Thierry, On 06-11-15 17:05, Thierry Reding wrote: On Fri, Nov 06, 2015 at 04:46:54PM +0100, Olliver Schinagl wrote: Hey Thierry, On 06-11-15 16:18, Thierry Reding wrote: On Mon, Oct 26, 2015 at 10:32:39PM +0100, Olliver Schinagl wrote: From: Olliver Schinagl Some hardware PWM's

Re: [PATCH] regulator: axp20x: Get rid of AXP20X_xxx_START/END/STEPS defines

2019-02-20 Thread Olliver Schinagl
Hey Axel, On February 20, 2019 5:50:13 PM GMT+01:00, Axel Lin wrote: >The AXP20X_xxx_START/END/STEPS defines make the code hard to read and >very hard to check the linear range settings because it needs to check >the defines one-by-one. >The original code without the defines is very good in reada

Re: [PATCH] regulator: axp20x: Get rid of AXP20X_xxx_START/END/STEPS defines

2019-02-22 Thread Olliver Schinagl
On 21-02-2019 10:42, Mark Brown wrote: > On Thu, Feb 21, 2019 at 08:22:53AM +0800, Axel Lin wrote: >> Olliver Schinagl 於 2019年2月21日 週四 上午6:57寫道: >>> On February 20, 2019 5:50:13 PM GMT+01:00, Axel Lin >>> wrote: >>>> The AXP20X_xxx_START/END/STEPS

Re: [PATCH] regulator: axp20x: Get rid of AXP20X_xxx_START/END/STEPS defines

2019-02-23 Thread Olliver Schinagl
On 23-02-2019 13:54, Axel Lin wrote: >> I will not disagree that it may be extra work to look up the define >> (especially if there is no tool tip or split view in the editor) but >> reading the whole lot of code, with only the magic values, you still >> have to look up the meaning of each magic va

Re: [PATCH 1/1] ARM: dts: sunxi: Add a olinuxino-lime2-emmc

2016-07-15 Thread Olliver Schinagl
On 15-07-16 10:39, stefan.mavrod...@gmail.com wrote: Hi Olliver, Why are you using nRST signal? What I mean is this pin is inactive on this eMMC chip. To use the signal byte 162 of ECSD registers should be written. Then that sounds like a bug in the mmc layer I would say (or a missing attribute

Re: [PATCH 1/2] pwm: sunxi: allow the pwm to finish its pulse before disable

2017-01-03 Thread Olliver Schinagl
Hey Maxime, Happy new year! I'm sorry that I missed your previous mail! I completely looked over it. Sorry! On 12-12-16 13:24, Maxime Ripard wrote: On Thu, Dec 08, 2016 at 02:23:39PM +0100, Olliver Schinagl wrote: Hey Maxime, first off, also sorry for the slow delay :) (pun not int

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Olliver Schinagl
Hey Alexandre, I've sent several patches regarding pwm a while ago, sadly you never responded [0]. So I guess this is a follow up from that? I couldn't quickly find the resubmitted version however. Anyway, see below for my comments. On 03-01-17 15:57, Alexandre Belloni wrote: Most of the ca

Re: How to handle quirky behavior with boards.

2017-03-03 Thread Olliver Schinagl
tleast function properly according to its parameters? Olliver On 01-03-17 14:58, Olliver Schinagl wrote: Hey all, We found a bug in the design of a board that we use. This board (Olimex OLinuXino Lime2) features a PMIC (AXP209) and has an LDO, LDO3, that needs special treatment. The bug is

How to handle quirky behavior with boards.

2017-03-01 Thread Olliver Schinagl
Hey all, We found a bug in the design of a board that we use. This board (Olimex OLinuXino Lime2) features a PMIC (AXP209) and has an LDO, LDO3, that needs special treatment. The bug is, that there is too much capacitance on the output of LDO3, which causes the PMIC to shutdown when enabelin

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-02-20 Thread Olliver Schinagl
Hey Alexandre, Sorry for the very slow reply. We just bought a house so have been offline for 6+ weeks! On 03-01-17 17:44, Alexandre Belloni wrote: On 03/01/2017 at 16:56:16 +0100, Olliver Schinagl wrote : Hey Alexandre, I've sent several patches regarding pwm a while ago, sadly you

Re: gpios search behaviour for gpio from _DSD

2015-09-26 Thread Olliver Schinagl
Hey Mika, Thanks for your reply. On 24-09-15 10:43, Mika Westerberg wrote: On Thu, Sep 24, 2015 at 09:25:06AM +0200, Olliver Schinagl wrote: Hey list, Mika, With commit 0d9a693cc86 the following snippet of code was added: + /* Try first from _DSD */ + for (i = 0; i < ARRAY_S

[RFC] pwm: core: unsigned or signed ints for pwm_config

2015-09-29 Thread Olliver Schinagl
Hey Thierry, list I'm going over the pwm core and notice that in the pwm header, duty_ns and period_ns is internally stored as an unsigned int. struct pwm_device { const char *label; unsigned long flags; unsigned int hwpwm; unsigned int pwm; struct pwm_chip *chip; void

[PATCH 1/1] gpio: gpiolib: fix identation

2015-09-24 Thread Olliver Schinagl
From: Olliver Schinagl Just a very small cosmetical indentation fix, no code changes Signed-off-by: Olliver Schinagl --- drivers/gpio/gpiolib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 980c1f8..5ef9ac2 100644 --- a/drivers

gpios search behaviour for gpio from _DSD

2015-09-24 Thread Olliver Schinagl
Hey list, Mika, With commit 0d9a693cc86 the following snippet of code was added: + /* Try first from _DSD */ + for (i = 0; i < ARRAY_SIZE(suffixes); i++) { + if (con_id && strcmp(con_id, "gpios")) { + snprintf(propname, sizeof(propname), "%s-%s", +

Re: [PATCH 1/1] gpio: gpiolib: fix identation

2015-09-24 Thread Olliver Schinagl
Appologies! I should not do this early in the morning. It is indeed a copy/paste fail (and not noticing the missing minus) from the section above i was working on. I'm sorry for the noise! Olliver On 24-09-15 09:17, Alexandre Courbot wrote: On Thu, Sep 24, 2015 at 4:14 PM, Olliver Sch

Re: [linux-sunxi] MMC clock gating broken on a20

2015-08-12 Thread Olliver Schinagl
iver On 12-08-15 13:40, Olliver Schinagl wrote: Hey all, I'm noticing the exact same thing using hans's sunxi-wip from a few days ago. I did see a patch from you about this very issue I belive mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff but can't find it in any of the rep

[PATCH v2] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Olliver Schinagl
enabling/disabling the clock took so more data can be collected from other systems. Signed-off-by: Michal Suchanek Signed-off-by: Olliver Schinagl --- drivers/mmc/host/sunxi-mmc.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sun

Re: [linux-sunxi] Re: [PATCH resend 1/3] mmc: sunxi: fix timeout in sunxi_mmc_oclk_onoff

2015-08-12 Thread Olliver Schinagl
While I can't speak for Michal obviously, I left the debugging bit (in my v2 that i sent 2 minutes ago) as both you and Hans where content with it back then and both acked it. Michal, feel free to send the v3 without the debug info, unless you want me to do it ;) Olliver On 12-08-15 14:32,

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Olliver Schinagl
Hey, On 12-08-15 14:35, Hans de Goede wrote: Hi, On 12-08-15 14:23, Michal Suchanek wrote: When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable automatic hardware controlled clock gating on the mmc interface. Signed-off-by: Michal Suchanek In general this looks good, but I wo

Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating.

2015-08-12 Thread Olliver Schinagl
:19, Olliver Schinagl wrote: Hey, On 12-08-15 14:35, Hans de Goede wrote: Hi, On 12-08-15 14:23, Michal Suchanek wrote: When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable automatic hardware controlled clock gating on the mmc interface. Signed-off-by: Michal Suchanek In general t

Re: [PATCH v2] serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt

2017-03-29 Thread Olliver Schinagl
Hey Douglas, On 07-02-17 00:30, Douglas Anderson wrote: On a Rockchip rk3399-based board during suspend/resume testing, we found that we could get the console UART into a state where it would print this to the console a lot: serial8250: too much work for irq42 Followed eventually by: NMI wa

Re: [PATCH v2] serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt

2017-03-29 Thread Olliver Schinagl
Hey Andy, On 29-03-17 11:11, Andy Shevchenko wrote: On Wed, Mar 29, 2017 at 10:58 AM, Olliver Schinagl wrote: On 07-02-17 00:30, Douglas Anderson wrote: First of all I didn't get why people from Cc list are suddenly disappeared. Check your mail client settings. Returning back some of

[PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
ic value/mask. Some very minor code cleanups, such as including the bitops header for DW_UART_MCR_SIRE, use the BIT() macro as suggested by checkpatc and removed a whitespace to match other invocations. Signed-off-by: Olliver Schinagl --- drivers/tty/serial/8250/8250_dw.c | 25 +

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Hey Doug, On 29-03-17 17:50, Doug Anderson wrote: Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bit check with quite a wide mask. To be concise with the

Re: [PATCH] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Hey Doug, On 29-03-17 19:10, Olliver Schinagl wrote: Hey Doug, On 29-03-17 17:50, Doug Anderson wrote: Hi, On Wed, Mar 29, 2017 at 3:04 AM, Olliver Schinagl wrote: Commit 424d79183af0 ("serial: 8250_dw: Avoid "too much work" from bogus rx timeout interrupt") added a bi

[PATCHv2] serial: 8250_dw: Minor code cleanup

2017-03-29 Thread Olliver Schinagl
Some very minor code cleanups, such as including the bitops header for DW_UART_MCR_SIRE, use the BIT() macro as suggested by checkpatch and removed a white space to match other invocations. Signed-off-by: Olliver Schinagl --- Changes since v1: Split up these non-code changing changes into a

[PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-29 Thread Olliver Schinagl
IR_EXT_MASK for these two bits. This patch then goes over all UART_IIR_* users and changes the code from bitfield checking, to ID checking instead. Signed-off-by: Olliver Schinagl --- Note, that I do not have all this hardware and used the fact that UART_IIR_* yields ID's rather then bitfiel

[PATCH] serial: tegra: Map the iir register to default defines

2017-03-29 Thread Olliver Schinagl
The tegra serial IP seems to be following the common layout and the interrupt ID's match up nicely. Replace the magic values to match the common serial_reg defines, with the addition of the Tegra unique End of Data interrupt. Signed-off-by: Olliver Schinagl --- Note I do not own any

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-29 Thread Olliver Schinagl
On March 30, 2017 8:15:29 AM CEST, Vignesh R wrote: >Hi, > >On Thursday 30 March 2017 12:14 AM, Olliver Schinagl wrote: >> diff --git a/include/uapi/linux/serial_reg.h >b/include/uapi/linux/serial_reg.h >> index 5db76880b4ad..489522389a10 100644 >> --- a/include/ua

Re: [PATCH] serial: tegra: Map the iir register to default defines

2017-03-30 Thread Olliver Schinagl
Hey Jon, On March 30, 2017 3:42:19 PM CEST, Jon Hunter wrote: > >On 29/03/17 19:48, Olliver Schinagl wrote: >> The tegra serial IP seems to be following the common layout and the >> interrupt ID's match up nicely. Replace the magic values to match the >> common

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-30 Thread Olliver Schinagl
Hey Vignesh, On March 30, 2017 9:57:19 AM CEST, Vignesh R wrote: > > >On Thursday 30 March 2017 12:13 PM, Olliver Schinagl wrote: >> >> >> On March 30, 2017 8:15:29 AM CEST, Vignesh R wrote: >>> Hi, >>> >>> On Thursday 30 March 2017 12:14

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-31 Thread Olliver Schinagl
Hey Ted, On 30-03-17 16:11, Theodore Ts'o wrote: While you're fixing this, there's a bug in samples/vfio-mdev/mtty.c: u8 ier = mdev_state->s[index].uart_reg[UART_IER]; *buf = 0; mutex_lock(&mdev_state->rxtx_lock); /* Interrupt pri

Re: [PATCH] serial: tegra: Map the iir register to default defines

2017-03-31 Thread Olliver Schinagl
7;ll turn it into a set. Again, sorry for the inconvenience, Olliver -Original Message- From: Laxman Dewangan Sent: Thursday, March 30, 2017 3:48 PM To: Olliver Schinagl ; Greg Kroah-Hartman ; Jiri Slaby ; Stephen Warren ; Thierry Reding ; Alexandre Courbot Cc: linux-ser...@vger.

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-31 Thread Olliver Schinagl
Hey Andy, On 30-03-17 11:56, Andy Shevchenko wrote: On Wed, 2017-03-29 at 20:44 +0200, Olliver Schinagl wrote: It seems that at some point, someone made the assumption that the UART Interrupt ID Register was a bitfield and started to check if certain bits where set. Actually however the

Re: [linux-sunxi] [PATCH v5 2/6] clk: sunxi-ng: Add sun4i/sun7i CCU driver

2017-07-13 Thread Olliver Schinagl
Hey Priit, On 07/13/17 21:23, Priit Laes wrote: > On Mon, Jul 10, 2017 at 11:45:32AM +0200, Olliver Schinagl wrote: >> Hi Pleas, >> >> again, but this time with content :) >> >> On 04-07-17 22:04, Priit Laes wrote: >>> Introduce a clock controller dri

Re: [linux-sunxi] [PATCH v5 1/6] clk: sunxi-ng: div: Add support for fixed post-divider

2017-07-10 Thread Olliver Schinagl
Hey Plaes, On 04-07-17 22:04, Priit Laes wrote: SATA clock on sun4i/sun7i is of type (parent) / M / 6 where 6 is fixed post-divider. Signed-off-by: Priit Laes --- drivers/clk/sunxi-ng/ccu_div.c | 18 -- drivers/clk/sunxi-ng/ccu_div.h | 3 ++- 2 files changed, 18 insertions(+)

Re: [linux-sunxi] [PATCH v5 2/6] clk: sunxi-ng: Add sun4i/sun7i CCU driver

2017-07-10 Thread Olliver Schinagl
Hi Pleas, again, but this time with content :) On 04-07-17 22:04, Priit Laes wrote: Introduce a clock controller driver for sun4i A10 and sun7i A20 series SoCs. Signed-off-by: Priit Laes --- drivers/clk/sunxi-ng/Kconfig | 14 +- drivers/clk/sunxi-ng/Makefile |1

Re: [linux-sunxi] [PATCH v5 5/6] ARM: sun7i: Convert to CCU

2017-07-10 Thread Olliver Schinagl
Hi Pleas, On 04-07-17 22:05, Priit Laes wrote: Convert sun7i-a20.dtsi to new CCU driver. Tested on Cubietruck. Signed-off-by: Priit Laes --- arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++- 1 file changed, 84 insertions(+), 635 deletions(-) diff --git a/arch/arm/boot

Re: [linux-sunxi] [PATCH v5 6/6] ARM: sun4i: Convert to CCU

2017-07-10 Thread Olliver Schinagl
Hi Pritt, On 04-07-17 22:05, Priit Laes wrote: Convert sun4i-a10.dtsi to new CCU driver. Tested on Gemei G9 tablet. Signed-off-by: Priit Laes --- arch/arm/boot/dts/sun4i-a10.dtsi | 646 +++- 1 file changed, 73 insertions(+), 573 deletions(-) diff --git a/arch/arm

Re: [linux-sunxi] [PATCH v5 5/6] ARM: sun7i: Convert to CCU

2017-07-10 Thread Olliver Schinagl
Hi Maxime, On 10-07-17 13:55, Maxime Ripard wrote: On Mon, Jul 10, 2017 at 01:23:51PM +0200, Olliver Schinagl wrote: Hi Pleas, On 04-07-17 22:05, Priit Laes wrote: Convert sun7i-a20.dtsi to new CCU driver. Tested on Cubietruck. Signed-off-by: Priit Laes --- arch/arm/boot/dts/sun7i-a20

Re: [linux-sunxi] [PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

2017-07-10 Thread Olliver Schinagl
Hey Jonathan, since I reported this to you on IRC, it's only fair that you can have my: Tested-by: Olliver Schinagl For those interessted, I've tested it on an Olimex OLinuXino Lime2 with their 4.3 LCD. Olliver On 10-07-17 08:55, Jonathan Liu wrote: The drm_driver lastclose c

Re: [linux-sunxi] Designware UART bug

2017-05-04 Thread Olliver Schinagl
Hey Tim, On 04-05-17 05:51, Tim Kryger wrote: On Wed, May 3, 2017 at 8:40 AM, Olliver Schinagl wrote: Hey Tim, Ok, so as far as I understand (from the datasheet) the intended way to do this would be to check for the BUSY IRQ & USR[0] IRQ and if it is busy, (re-write) the LCR. We no lo

Designware UART bug

2017-05-03 Thread Olliver Schinagl
Hey Jamie, Several years ago you wrote the glue-code [0] for the DW 8250 IP. Over the years various 'fixes' have been applied to resolve certain 'weird' problems that Tim tried to fix with [1]. After going over the datasheets and code with a comb several times now, I think I may have found o

Re: [linux-sunxi] Designware UART bug

2017-05-03 Thread Olliver Schinagl
Hey Chen-Yu On 03-05-17 12:40, Chen-Yu Tsai wrote: On Wed, May 3, 2017 at 6:17 PM, Olliver Schinagl wrote: Hey Jamie, Several years ago you wrote the glue-code [0] for the DW 8250 IP. Over the years various 'fixes' have been applied to resolve certain 'weird' problems t

Re: [linux-sunxi] Designware UART bug

2017-05-03 Thread Olliver Schinagl
Hey Tim, On 03-05-17 16:22, Tim Kryger wrote: On Wed, May 3, 2017 at 4:26 AM, Olliver Schinagl wrote: Hey Chen-Yu On 03-05-17 12:40, Chen-Yu Tsai wrote: On Wed, May 3, 2017 at 6:17 PM, Olliver Schinagl wrote: Hey Jamie, Several years ago you wrote the glue-code [0] for the DW 8250 IP

Re: [linux-sunxi] [PATCH v3 00/12] ASoC: Add I2S support for Allwinner H3 SoCs

2017-07-31 Thread Olliver Schinagl
Hey Marcus, On 29-07-17 16:17, codekip...@gmail.com wrote: From: Marcus Cooper Hi All, please find attached a series of patches to bring i2s support to the Allwinner H3 SoC. This has been tested with the following setups: A20 Olimex EVB connected to a pcm5102 But that's not an H3 is it? :)

Re: [PATCH 1/2] pwm: sunxi: allow the pwm to finish its pulse before disable

2016-09-06 Thread Olliver Schinagl
Hi Maxime!, On za, 2016-08-27 at 00:19 +0200, Maxime Ripard wrote: > On Thu, Aug 25, 2016 at 07:50:10PM +0200, Olliver Schinagl wrote: > > > > When we inform the PWM block to stop toggeling the output, we may > > end up > > in a state where the output is not wha

Re: [PATCH] leds-pca963x: add bindings to invert polarity

2016-09-06 Thread Olliver Schinagl
Hi Anders, On ma, 2016-09-05 at 13:02 +0200, Anders Darander wrote: > Hi, > > * Olliver Schinagl [160504 10:10]: > > > > On 04-05-16 09:55, Anders Darander wrote: > > > > > > * Jacek Anaszewski [160504 09:28]: > > > > > > >

<    1   2