On 07/10/13 22:05, Greg Kroah-Hartman wrote:
Hi all,
Hey Greg,
Guenter and Oliver have been pointing out a few limitations of the
driver core's ability to create files properly (i.e. in a way that
doesn't race with userspace.) The driver core allows this, but it
doesn't export that ability t
On 11-07-13 08:28, Greg Kroah-Hartman wrote:
On Wed, Jul 10, 2013 at 10:23:57PM -0700, Guenter Roeck wrote:
On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote:
Hi all,
Here's the second iteration of the patchset to add better attribute
group support to the driver core and sysfs
ed" part of the driver model, and not
something just "tacked on".
However when only using binary attributes it warns and doesn't create
anything. The attached patch fixes that.
Reported-by: Oliver Schinagl
If I may be so bold and ask to change my e-mail address to
that would
name
struct file;
>From 003ab7a74ff689daa6934e7bc50c498b2d35a1cc Mon Sep 17 00:00:00 2001
From: Oliver Schinagl
Date: Thu, 11 Jul 2013 13:48:18 +0200
Subject: [PATCH] sysfs: add more helper macro's for (bin_)attribute(_groups)
With the recent changes to sysfs there's various helpe
file;
>From a67de9f026363ce821c72a807d98830abece3cf7 Mon Sep 17 00:00:00 2001
From: Oliver Schinagl
Date: Thu, 11 Jul 2013 13:57:42 +0200
Subject: [PATCH] sysfs: use file mode defines from stat.h
With the last patches stat.h was included to the header, and thus those
permission defines should be used.
Sign
On 07/11/13 19:06, Greg Kroah-Hartman wrote:
On Thu, Jul 11, 2013 at 01:58:29PM +0200, Oliver Schinagl wrote:
On 11-07-13 02:36, Greg Kroah-Hartman wrote:
To make it easier for driver subsystems to work with attribute groups,
create the ATTRIBUTE_GROUPS macro to remove some of the repetitive
On 07/11/13 22:26, Greg Kroah-Hartman wrote:
On Thu, Jul 11, 2013 at 10:09:11PM +0200, Oliver Schinagl wrote:
On 07/11/13 19:06, Greg Kroah-Hartman wrote:
On Thu, Jul 11, 2013 at 01:58:29PM +0200, Oliver Schinagl wrote:
On 11-07-13 02:36, Greg Kroah-Hartman wrote:
To make it easier for
From: Oliver Schinagl
Having the interrupt tables documented in the kernel documentation is useful as
a quick reference.
Oliver Schinagl (1):
ARM: sunxi: doc: Add sun7i (A20) interrupt table
.../interrupt-controller/sunxi/sun7i-a20.txt | 102 +
1 file changed, 102
From: Oliver Schinagl
This patch adds some documentation about the Allwinner sun7i (A20) using
the GIC.
Signed-off-by: Oliver Schinagl
---
.../interrupt-controller/sunxi/sun7i-a20.txt | 102 +
1 file changed, 102 insertions(+)
create mode 100644
Documentation
From: Oliver Schinagl
I've tried to incoperate all requests/issues but as always could have possibly
missed some. I've talked to a few people, maxime mostly about the return vs
goto and he said it was up to me, and have choosen to stick with the goto for
the error handling.
Chang
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses, seeds the kernel entropy and exports them as a sysfs node.
These fuses are most likly to be programmed at the factory, encoding
things like Chip ID, some sort of serial number etc
From: Oliver Schinagl
This patch shall add support for the sunxi-sid driver to the device table for
sun4i and sun5i.
Signed-off-by: Oliver Schinagl
---
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
2 files changed, 10 insertions(+)
diff --git a/arch
On 06/15/13 04:14, Andy Shevchenko wrote:
On Sat, Jun 15, 2013 at 2:16 AM, Oliver Schinagl
wrote:
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses, seeds the kernel entropy and exports them as a sysfs node.
These fuses are most
On 15-06-13 12:28, Tomasz Figa wrote:
Hi,
Some comments inline.
Thank you
On Saturday 15 of June 2013 01:16:20 Oliver Schinagl wrote:
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses, seeds the kernel entropy and exports them
On 17-06-13 13:25, Russell King - ARM Linux wrote:
On Mon, Jun 17, 2013 at 12:36:47PM +0200, Oliver Schinagl wrote:
On 15-06-13 12:28, Tomasz Figa wrote:
What is this version thingy?
Is there a versioning scheme defined for this driver? Do you expect it to
be changed every modification of
On 17-06-13 13:51, Maxime Ripard wrote:
On Mon, Jun 17, 2013 at 12:36:47PM +0200, Oliver Schinagl wrote:
On 15-06-13 12:28, Tomasz Figa wrote:
+#define DRV_VERSION "1.0"
What is this version thingy?
Is there a versioning scheme defined for this driver? Do you expect it to
be cha
On 17-06-13 14:51, Tomasz Figa wrote:
On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote:
On 15-06-13 12:28, Tomasz Figa wrote:
Hi,
Some comments inline.
Thank you
You're welcome. :)
On Saturday 15 of June 2013 01:16:20 Oliver Schinagl wrote:
From: Oliver Schinagl
Allwinne
On 17-06-13 15:23, Tomasz Figa wrote:
On Monday 17 of June 2013 15:10:47 Oliver Schinagl wrote:
On 17-06-13 14:51, Tomasz Figa wrote:
On Monday 17 of June 2013 12:36:47 Oliver Schinagl wrote:
On 15-06-13 12:28, Tomasz Figa wrote:
Now we pass this array to add_randomness(array, 16). So
o please try to be gentle
Oliver Schinagl (1):
Add sunxi-sid to dts for sun4i and sun5i
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
2 files changed, 10 insertions(+)
--
1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe
From: Oliver Schinagl
This patch shall add support for the sunxi-sid driver to the device table for
sun4i and sun5i.
Signed-off-by: Oliver Schinagl
---
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
2 files changed, 10 insertions(+)
diff --git a/arch
From: Oliver Schinagl
This patch shall add support for the sunxi-sid driver to the device table for
sun4i and sun5i.
Signed-off-by: Oliver Schinagl
---
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
2 files changed, 10 insertions(+)
diff --git a/arch
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses, seeds the kernel entropy and exports them as a sysfs node.
These fuses are most likly to be programmed at the factory, encoding
things like Chip ID, some sort of serial number etc
en tested on a Cubieboard 1
This is my very first driver so please try to be gentle
Oliver Schinagl (2):
Initial support for Allwinner's Security ID fuses
Add sunxi-sid to dts for sun4i and sun5i
arch/arm/boot/dts/sun4i-a10.dtsi | 5 ++
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
From: Oliver Schinagl
This should add support for the sunxi-sid driver to the device table for sun4i
and sun5i
Signed-off-by: Oliver Schinagl
---
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
2 files changed, 10 insertions(+)
diff --git a/arch/arm
From: Oliver Schinagl
Changes from v1:
* Renamed the sys-fs exported key to eeprom, since it really a read-only eeprom
* Removed mention of sun[67]i since we haven't tested those
* Fixed up mistakes in comments
* Removed PAGE_SIZE references, since this is a binary only driver
* Removed l
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses, seeds the kernel entropy and exports them as a sysfs node.
These fuses are most likly to be programmed at the factory, encoding
things like Chip ID, some sort of serial number etc
On 06/02/13 17:09, Russell King - ARM Linux wrote:
On Sun, Jun 02, 2013 at 04:58:49PM +0200, Oliver Schinagl wrote:
+#include
We have an include file called linux/io.h. Please use linux/*.h files which
include asm/*.h files in preference to directly using asm/*.h.
In fact, no driver should
Hey Greg,
On 06/24/13 18:04, Greg KH wrote:
On Mon, Jun 24, 2013 at 11:29:42AM +0200, Maxime Ripard wrote:
Hi Greg,
On Mon, Jun 17, 2013 at 03:58:47PM -0700, Greg KH wrote:
On Mon, Jun 17, 2013 at 10:59:37PM +0200, Oliver Schinagl wrote:
[..]
+static int __init sunxi_sid_probe(struct
On 06/24/13 20:15, Greg KH wrote:
On Mon, Jun 24, 2013 at 07:11:35PM +0200, Oliver Schinagl wrote:
Hey Greg,
On 06/24/13 18:04, Greg KH wrote:
On Mon, Jun 24, 2013 at 11:29:42AM +0200, Maxime Ripard wrote:
Hi Greg,
On Mon, Jun 17, 2013 at 03:58:47PM -0700, Greg KH wrote:
On Mon, Jun 17
On 24-06-13 23:46, Greg KH wrote:
On Mon, Jun 24, 2013 at 11:21:16PM +0200, Oliver Schinagl wrote:
On 06/24/13 20:15, Greg KH wrote:
On Mon, Jun 24, 2013 at 07:11:35PM +0200, Oliver Schinagl wrote:
Hey Greg,
On 06/24/13 18:04, Greg KH wrote:
On Mon, Jun 24, 2013 at 11:29:42AM +0200, Maxime
On 06/06/13 21:16, Andy Shevchenko wrote:
Thank you andy for your review, I do have a few questions/comments if
you don't mind.
On Sun, Jun 2, 2013 at 5:58 PM, Oliver Schinagl wrote:
From: Oliver Schinagl
+ if (likely((SID_SIZE))) {
Extra braces.
Use antipattern here.
Wh
Hello all,
While waiting/working in comments I realized/was reminded that there
where a few things I hadn't addressed. I'll try to go over all the
missing bits to be sure to answer all questions before submitting the
hopefully final version. This because I wouldn't want anybody to think
I'm u
Hey Greg,
Thanks for the blog post :) it was very helpful and at least something
good came from the less-nice bit of the discussion, but:
On 26-06-13 19:51, Greg KH wrote:
On Wed, Jun 26, 2013 at 10:32:09AM +0200, Oliver Schinagl wrote:
On 24-06-13 23:46, Greg KH wrote:
On Mon, Jun 24
On 06-07-13 10:10, Maxime Ripard wrote:
I'll send a v5. Do you have any additionnal comments on those patches to
avoid wasting more electrons?
Pff, we all know Maxime's electrons are free
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
Greg,
Haven't heard anything about this v2 patch, I know you are very busy but
with the merge window closing today/yesterday just wondering about the
status of it all.
Oliver
On 11-07-13 22:55, Oliver Schinagl wrote:
On 07/11/13 22:26, Greg Kroah-Hartman wrote:
On Thu, Jul 11, 2013
On 07/06/13 21:36, Greg KH wrote:
On Fri, Jul 05, 2013 at 09:24:47AM +0200, Oliver Schinagl wrote:
The other 'broken' drivers that where linked earlier, also use the
BINARY attributes.
So Greg, if you could be so kind and give me an example how to
implement this properly, I am a
On 07/16/13 08:41, Greg KH wrote:
On Mon, Jul 15, 2013 at 11:16:19PM +0200, Oliver Schinagl wrote:
With your latest patches for binary attributes and your blog post, I
thought that you want to create your binary attributes before the probe
function, to avoid the userspace race. To do that, we
, Jul 15, 2013 at 11:16:19PM +0200, Oliver Schinagl wrote:
So using these new patches for binary attributes, how can I pass data
between my driver and the sysfs files using a platform_driver? Or are
other 'hacks' needed and using the .groups attribute from
platform_driver->device_driv
On 30-07-13 16:20, Greg KH wrote:
On Tue, Jul 30, 2013 at 03:22:55PM +0200, Oliver Schinagl wrote:
Let me go look at how I can make this work "easier", give me a few days.
Not wanting to be rude, but it has been a little more then a few
days, any progress? Just want to know what
Note, I'm not qualified nor important or anything really to be part of
this discussion or mud slinging this may turn into, but I do fine some
flaws in the reasoning here that If not pointed out, may get grossly
overlooked.
On 06-05-13 06:09, Robert Hancock wrote:
On 05/05/2013 06:27 AM, Luke
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses and exports them as a sysfs node. Also a symbol is exported
for in-kernel useage.
While initially these fuses are used to somewhat determin the chipID, these
appear to be writeable
From: Oliver Schinagl
This should add support for the sunxi-sid driver to the device table for sun4i
and sun5i
Signed-off-by: Oliver Schinagl
---
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
2 files changed, 10 insertions(+)
diff --git a/arch/arm
for known chips.
This is my very first driver so please try to be gentle ;)
Oliver Schinagl (2):
Initial support for Allwinner's Security ID fuses
Add sunxi-sid to dts for sun4i and sun5i
arch/arm/boot/dts/sun4i-a10.dtsi | 5 +
arch/arm/boot/dts/sun5i-a13.dtsi | 5 +
drivers/misc/eepro
On 05/17/13 15:45, Arnd Bergmann wrote:
On Friday 17 May 2013 15:35:43 Oliver Schinagl wrote:
+static struct bin_attribute sid_bin_attr = {
+ .attr = {
+ .name = "key",
+ .mode = S_IRUGO,
+ },
+ .size = SUNXI_SID_SIZE,
+ .read
On 05/17/13 23:18, Maxime Ripard wrote:
Hi Oliver,
Le 17/05/2013 15:35, Oliver Schinagl a écrit :
From: Oliver Schinagl
Allwinner has electric fuses (efuse) on their line of chips. This driver
reads those fuses and exports them as a sysfs node. Also a symbol is exported
for in-kernel useage
On 05/23/13 09:56, Linus Walleij wrote:
On Fri, May 17, 2013 at 3:35 PM, Oliver Schinagl
wrote:
(...)
While initially these fuses are used to somewhat determin the chipID, these
appear to be writeable by the user and thus can be used for other purpouses.
For example storing a 128 bit root key
On 05/23/13 14:12, Lars Poeschel wrote:
Hi Oliver!
As you are not the first one asking for the status of the pwm sysfs
interface I post my answer to the linux-kernel list in hope others will
benefit.
On Thursday 23 May 2013 at 11:07:39, Oliver Schinagl wrote:
Hi lars,
I have trouble seeing
On 05/23/13 16:58, Maxime Ripard wrote:
On Thu, May 23, 2013 at 10:10:17AM +0200, Oliver Schinagl wrote:
Then, i'm not sure if the driver is the best for this to be loaded?
Maxime, what do you think? Personally I would feel more in having
this in the mach-sunxi/core.c bit, but then again,
On 05/18/13 19:19, Oliver Schinagl wrote:
+
+
+/* We read the entire key, using a look up table. Returned is only the
+ * requested byte. This is of course slower then it could be and uses 4 times
+ * more reads as needed but keeps code a little simpler.
+ */
+u8 sunxi_sid_read_byte(const int
On 05/25/13 14:22, Maxime Ripard wrote:
Hi Oliver,
On Fri, May 24, 2013 at 11:50:38PM +0200, Oliver Schinagl wrote:
On 05/18/13 19:19, Oliver Schinagl wrote:
+
+
+/* We read the entire key, using a look up table. Returned is only the
+ * requested byte. This is of course slower then it could
Hey Tejun Heo,
On 04-12-13 13:32, Tejun Heo wrote:
On Wed, Dec 04, 2013 at 01:10:53PM +0100, oli...@schinagl.nl wrote:
From: Oliver Schinagl
The Allwinner sunxi platforms have patched in the following to enable
DMA. This patch enables DMA controllers for the SUNXI Architecture.
Signed-off
On 04-12-13 13:26, Mark Rutland wrote:
On Wed, Dec 04, 2013 at 12:10:54PM +, oli...@schinagl.nl wrote:
From: Oliver Schinagl
This patch adds support for the sunxi series of SoC's by allwinner. It
plugs into the ahci-platform framework.
Note: Currently it uses a somewhat hackish app
On 04-12-13 13:37, Tejun Heo wrote:
On Wed, Dec 04, 2013 at 01:10:54PM +0100, oli...@schinagl.nl wrote:
From: Oliver Schinagl
This patch adds support for the sunxi series of SoC's by allwinner. It
plugs into the ahci-platform framework.
Note: Currently it uses a somewhat hackish app
On 04-12-13 13:47, Sergei Shtylyov wrote:
Hello.
On 04-12-2013 16:10, oli...@schinagl.nl wrote:
From: Oliver Schinagl
The Allwinner sunxi platforms have patched in the following to enable
DMA. This patch enables DMA controllers for the SUNXI Architecture.
Signed-off-by: Olliver
On 15-12-13 20:04, Tejun Heo wrote:
Hello, Hans.
On Sun, Dec 15, 2013 at 08:00:20PM +0100, Hans de Goede wrote:
I think it would be a good idea to merge ahci upstream using the
ahci_imx.c method for now. You already indicated that you were not against
doing that for now.
Well, the thing is not
On 06-12-13 10:01, Thomas Petazzoni wrote:
Dear Tejun Heo,
On Wed, 4 Dec 2013 08:23:12 -0500, Tejun Heo wrote:
But again, point me (for dummies ;) in the right direction and I'll
work on it with some help.
Richard and Shawn recently worked on ahci_imx. Can you guys please
talk with each oth
56 matches
Mail list logo