Re: [PATCH 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-30 Thread Oleksandr Dmytryshyn
On 05/29/2013 08:22 PM, Kevin Hilman wrote: Oleksandr Dmytryshyn writes: Starting from the OMAP chips with version2 registers scheme there are 2 registers (I2C_IRQENABLE_SET and I2C_IRQENABLE_CLR) to manage interrupts instead of the older OMAP chips with old scheme which have only one

Re: [PATCH 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-30 Thread Oleksandr Dmytryshyn
On 05/30/2013 05:18 PM, Kevin Hilman wrote: Oleksandr Dmytryshyn writes: On 05/29/2013 08:22 PM, Kevin Hilman wrote: Oleksandr Dmytryshyn writes: Starting from the OMAP chips with version2 registers scheme there are 2 registers (I2C_IRQENABLE_SET and I2C_IRQENABLE_CLR) to manage

[PATCH v2 0/1] i2c: omap: correct usage of the interrupt enable register

2013-05-30 Thread Oleksandr Dmytryshyn
E register. But with my patch interrupts are disabled in the omap_i2c_runtime_suspend() function. Next patch fixes it. Patch is based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git tag: v3.10-rc2 Verified on OMAP4430. Oleksandr Dmytryshyn (1): i2c: omap: correct usage of the

[PATCH v2 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-30 Thread Oleksandr Dmytryshyn
addresses, the interrupt enabling procedure is unchanged. Signed-off-by: Oleksandr Dmytryshyn --- drivers/i2c/busses/i2c-omap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e02f9e3..2419899

Re: [PATCH v2 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Oleksandr Dmytryshyn
On 05/30/2013 07:46 PM, Kevin Hilman wrote: Oleksandr Dmytryshyn writes: If the i2c controller during suspend will generate an interrupt, it can lead to unpredictable behaviour in the kernel. Based on the logic of the kernel code interrupts from i2c should be prohibited during suspend

[PATCH v3 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Oleksandr Dmytryshyn
addresses, the interrupt enabling procedure is unchanged. Change-Id: Ie49165990a4e7c67a4ccf2e4a66cd3b78f2e2b70 Signed-off-by: Oleksandr Dmytryshyn --- drivers/i2c/busses/i2c-omap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b

[PATCH v3 0/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Oleksandr Dmytryshyn
led in the omap_i2c_runtime_suspend() function. This has been working up until now because we've just been lucky. Next patch fixes it. Patch is based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git tag: v3.10-rc2 Verified on OMAP4430. Oleksandr Dmytryshyn (1): i2c

[PATCH v4 0/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Oleksandr Dmytryshyn
) function. This has been working up until now because we've just been lucky. Next patch fixes it. Patch is based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git tag: v3.10-rc2 Verified on OMAP4430. Oleksandr Dmytryshyn (1): i2c: omap: correct usage of the i

[PATCH v4 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-31 Thread Oleksandr Dmytryshyn
addresses, the interrupt enabling procedure is unchanged. Signed-off-by: Oleksandr Dmytryshyn --- drivers/i2c/busses/i2c-omap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e02f9e3..64c26f9

[PATCH v5] i2c: omap: correct usage of the interrupt enable register

2013-06-03 Thread Oleksandr Dmytryshyn
s based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git tag: v3.10-rc2 Verified on OMAP4430. Signed-off-by: Oleksandr Dmytryshyn --- drivers/i2c/busses/i2c-omap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2

[PATCH 0/1] i2c: omap: correct usage of the interrupt enable register

2013-05-29 Thread Oleksandr Dmytryshyn
t tag: v3.10-rc2 Verified on OMAP4430. Oleksandr Dmytryshyn (1): i2c: omap: correct usage of the interrupt enable register drivers/i2c/busses/i2c-omap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) -- 1.8.2.rc2 -- To unsubscribe from this list: send the line "u

[PATCH 1/1] i2c: omap: correct usage of the interrupt enable register

2013-05-29 Thread Oleksandr Dmytryshyn
interrupts and I2C_IRQENABLE_CLR register for disabling interrupts. Because the registers I2C_IRQENABLE_SET and I2C_IE have the same addresses, the interrupt enabling procedure is unchanged. Change-Id: Ie49165990a4e7c67a4ccf2e4a66cd3b78f2e2b70 Signed-off-by: Oleksandr Dmytryshyn --- drivers/i2c/busses