[PATCH] xen PVonHVM: fix compile warning in init_hvm_pv_info

2012-11-29 Thread Olaf Hering
:1617:11: warning: unused variable 'eax' [-Wunused-variable] Introduced by commit 9d02b43dee0d ("xen PVonHVM: use E820_Reserved area for shared_info"). Signed-off-by: Olaf Hering --- arch/x86/xen/enlighten.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH] x86: Hyper-V: register clocksource only if its advertised

2013-01-29 Thread Olaf Hering
On Tue, Jan 29, Jan Beulich wrote: > >>> On 28.01.13 at 18:44, Stefano Stabellini > >>> wrote: > > I think that Olaf made his point very clear: a feature A should only be > > enabled if the corresponding flag A is set. > > In fact it seems to me that this patch is correct on its own merits, > >

Re: [PATCH RESEND 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts

2013-01-24 Thread Olaf Hering
On Thu, Jan 24, KY Srinivasan wrote: > > Question is - considering you stated that this is supported > > starting in Win8, doesn't Hyper-V itself announce that > > capability in some explicit way? > > Thanks Jan. Unfortunately I don't think tis interrupt delivery model > is specified via a "feat

Re: [PATCH RESEND 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts

2013-01-24 Thread Olaf Hering
On Thu, Jan 24, H. Peter Anvin wrote: > Can't you discover Xen emulation by looking for Xen first? Or does Xen go > "stealth"? The current code looks at cpuid to decide what the host type is. One thing to detect a Xen host is to look for the DIM strings, which still have "Xen HVM DomU" or simil

[PATCH] x86: Hyper-V: register clocksource only if its advertised

2013-01-25 Thread Olaf Hering
easily be setting 'viridian=1' in a HVM domU .cfg file. A workaround without this patch is to boot the HVM guest with 'clocksource=jiffies'. Signed-off-by: Olaf Hering Cc: sta...@kernel.org Cc: KY Srinivasan Cc: Greg KH --- arch/x86/kernel/cpu/mshyperv.c | 3 ++- 1 file c

Re: [PATCH RESEND 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts

2013-01-25 Thread Olaf Hering
On Fri, Jan 25, Jan Beulich wrote: > >>> On 24.01.13 at 19:59, Olaf Hering wrote: > > On Thu, Jan 24, KY Srinivasan wrote: > > > > > >> > Question is - considering you stated that this is supported > >> > starting in Win8, doesn't Hype

Re: [PATCH] x86: Hyper-V: register clocksource only if its advertised

2013-01-25 Thread Olaf Hering
On Fri, Jan 25, KY Srinivasan wrote: > > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Friday, January 25, 2013 8:37 AM > > To: linux-kernel@vger.kernel.org > > Cc: Olaf Hering; sta...@kernel.org; KY Srinivasan; Greg

Re: [PATCH] x86: Hyper-V: register clocksource only if its advertised

2013-01-25 Thread Olaf Hering
On Fri, Jan 25, KY Srinivasan wrote: > My fear is that there is no guarantee that Xen would not emulate this > feature in the spirit of making Hyper-V emulation "more" complete. > Since all this problem is because Xen thinks it is running a viridian > domain (when in fact it is running Linux), I f

Re: [PATCH] x86: Hyper-V: register clocksource only if its advertised

2013-01-25 Thread Olaf Hering
On Fri, Jan 25, KY Srinivasan wrote: > Your current approach of using the "Partition Reference Counter" > feature bit is very fragile. Let us assume that future Windows guests > depend on this feature; Xen would certainly emulate this to have a > "good" emulation of Hyper-V and we are back to squa

Re: [PATCH] x86: Hyper-V: register clocksource only if its advertised

2013-01-26 Thread Olaf Hering
On Sat, Jan 26, KY Srinivasan wrote: > > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Friday, January 25, 2013 3:00 PM > > To: KY Srinivasan > > Cc: linux-kernel@vger.kernel.org; Greg KH; Jan Beulich (jbeul...@su

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-28 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: > + if (fb_get_options("hyperv_fb", &opt) || !opt || !*opt) > + strcpy(info->fix.id, "hyperv"); Here is a mismatch between video= and /proc/fb output. Both should have the same string IMO. Olaf -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: > @@ -508,6 +544,18 @@ static int __init vesafb_init(void) > int ret; > char *option = NULL; > > +#if IS_ENABLED(CONFIG_HYPERV_FB) > + /* > + * On Hyper-V both the emulated and synthetic video devices are > + * available. To avoid co

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Olaf Hering
On Tue, Feb 19, Haiyang Zhang wrote: > The emulated video device is a separate device from the synthetic video. > The synthetic driver can only take control of the synthetic video, but not > the emulated video. Please add this to the comment above. > Actually, we already have a similar mechanism

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-21 Thread Olaf Hering
On Tue, Feb 19, Haiyang Zhang wrote: > > I havent read the vesafb code, but I think it can kind of give up the > > hardware, something ata_piix can not do. > > In my test, the vesafb doesn't automatically give up the emulated video > device, > unless I add the DMI based mechanism to let it exit

Re: [PATCH] tools: hv: Fix how ifcfg-* file is created

2013-02-22 Thread Olaf Hering
On Sun, Jan 13, Tomas Hozza wrote: > -# IPADDR=ipaddr1 > -# IPADDR_1=ipaddr2 > -# IPADDR_x=ipaddry (where y = x + 1) > +# IPADDR0=ipaddr1 > +# IPADDR1=ipaddr2 > +# IPADDRx=ipaddry (where y = x + 1) Before this change it was IPADDR=, now its IPADDR0=. Furthermore, IPADDR_n was changed to IPADDRn.

Re: [PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-12 Thread Olaf Hering
On Tue, Mar 12, K. Y. Srinivasan wrote: > +static int vss_operate(int operation) > +{ > + char *fs_op; > + char cmd[512]; > + char buf[512]; > + FILE *file; > + char *p; > + char *x; > + int error; > + > + switch (operation) { > + case VSS_OP_FREEZE: > +

Re: [PATCH RESEND 5/6] Drivers: hv: balloon: Implement hot-add functionality

2013-03-13 Thread Olaf Hering
On Tue, Mar 12, K. Y. Srinivasan wrote: > Implement the memory hot-add functionality. With this, Linux guests can fully > participate in the Dynamic Memory protocol implemented in the Windows hosts. > +++ b/drivers/hv/Kconfig > @@ -15,7 +15,7 @@ config HYPERV_UTILS > > config HYPERV_BALLOON >

Re: [PATCH 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-14 Thread Olaf Hering
On Tue, Mar 12, Olaf Hering wrote: > On Tue, Mar 12, K. Y. Srinivasan wrote: > > > +static int vss_operate(int operation) > > +{ > > + char *fs_op; > > + char cmd[512]; > > + char buf[512]; > > + FILE *file; > > + char *p; > >

when to switch from early_ioremap to ioremap

2012-10-23 Thread Olaf Hering
To obtain an address to a PFN in init_hypervisor_platform (called from arch/x86/kernel/setup.c:setup_arch) I use early_ioremap. Later the address to that PFN needs to be obtained with ioremap, and early_iounmap needs to be called on the first address. When is the time to obtain and use the new po

Re: when to switch from early_ioremap to ioremap

2012-10-23 Thread Olaf Hering
On Tue, Oct 23, Yinghai Lu wrote: > Also early_ioremap has slot limitation: 4. and you should not hold one > slot too long, otherwise other users could > have problem to reach the limit. Thanks. After which init call is ioremap available anymway? Olaf -- To unsubscribe from this list: send the l

[PATCH] x86: remove obsolete comment from asm/xen/hypervisor.h

2012-10-25 Thread Olaf Hering
Signed-off-by: Olaf Hering --- arch/x86/include/asm/xen/hypervisor.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h index 66d0fff..125f344 100644 --- a/arch/x86/include/asm/xen/hypervisor.h +++ b/arch/x86/include

[PATCH] xen PVonHVM: move shared_info to reserved memory area

2012-10-25 Thread Olaf Hering
served for guest use. Older toolstacks will usually not allocate areas up to FE70, so FE70 is expected to work also with older toolstacks. Signed-off-by: Olaf Hering --- arch/x86/xen/enlighten.c | 46 ++ arch/x86/xen/suspend.c | 2 +- arch/x

Re: [Xen-devel] [PATCH] xen PVonHVM: move shared_info to reserved memory area

2012-10-25 Thread Olaf Hering
On Thu, Oct 25, Jan Beulich wrote: > >>> On 25.10.12 at 11:04, Olaf Hering wrote: > > @@ -1495,38 +1494,53 @@ asmlinkage void __init xen_start_kernel(void) > > #endif > > } > > > > -void __ref xen_hvm_init_shared_info(void) > > Was the __ref h

Re: [Xen-devel] [PATCH] xen PVonHVM: require at least Xen 3.4 as dom0

2012-10-31 Thread Olaf Hering
On Tue, Oct 30, Pasi Kärkkäinen wrote: > On Tue, Oct 30, 2012 at 05:05:05PM +0100, Olaf Hering wrote: > > The XenPVHVM extensions have not been tested much on very old > > hypervisors. At least Xen 3.4 gets some testing with the pvops kernel. > IIRC upstream Linux PVonHVM

[PATCH v5] xen PVonHVM: use E820_Reserved area for shared_info

2012-11-01 Thread Olaf Hering
s a result kexec can not be used. Signed-off-by: Olaf Hering --- v5: reword subject handle Xen3, continue to use extend_brk on old hosts v4: rebase to 3.7-rc3 v3: make xen_hvm_init_shared_info static v2: add __init to xen_hvm_set_shared_info arch/x86/xen/enligh

Re: [PATCH net,1/1] hyperv: Add support for setting MAC from within guests

2012-07-30 Thread Olaf Hering
On Tue, Jul 10, Haiyang Zhang wrote: > diff --git a/drivers/net/hyperv/rndis_filter.c > b/drivers/net/hyperv/rndis_filter.c > index 981ebb1..fbf5394 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -47,6 +48,7 @@ struct rndis_request { > struct

Re: [PATCH 13/17] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO

2012-07-30 Thread Olaf Hering
On Tue, Jul 24, K. Y. Srinivasan wrote: > +static char *kvp_get_if_name(char *guid) > +{ > + DIR *dir; > + struct dirent *entry; > + FILE*file; > + char*p, *q, *x; > + char*if_name = NULL; > + charbuf[256]; > + char *kvp_net_dir = "/sys/class/net/"; > +

Re: [PATCH 13/17] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO

2012-07-30 Thread Olaf Hering
On Tue, Jul 24, K. Y. Srinivasan wrote: > + /* > + * Set the configuration for the specified interface with > + * the information provided. Since there is no standard > + * way to configure an interface, we will have an external > + * script that does the job of configuring

[PATCH v4] xen PVonHVM: move shared_info to reserved memory area

2012-10-30 Thread Olaf Hering
served for guest use. Older toolstacks will usually not allocate areas up to FE70, so FE70 is expected to work also with older toolstacks. Signed-off-by: Olaf Hering --- v4: rebase to

[PATCH] xen PVonHVM: require at least Xen 3.4 as dom0

2012-10-30 Thread Olaf Hering
hardware. Signed-off-by: Olaf Hering --- arch/x86/xen/enlighten.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 0cc41f8..8566fa8 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen

Re: [Xen-devel] [PATCH v4] xen PVonHVM: move shared_info to reserved memory area

2012-10-30 Thread Olaf Hering
On Tue, Oct 30, Jan Beulich wrote: > >>> On 30.10.12 at 16:47, Olaf Hering wrote: > > This is a respin of 00e37bdb0113a98408de42db85be002f21dbffd3 > > ("xen PVonHVM: move shared_info to MMIO before kexec"). > > > > Currently kexec in a PVonHVM guest

Re: [Xen-devel] [PATCH v4] xen PVonHVM: move shared_info to reserved memory area

2012-10-30 Thread Olaf Hering
On Tue, Oct 30, Jan Beulich wrote: > And iirc you're doing this relocation because otherwise the newly > booting kernel image may get overwritten at an (from its > perspective) arbitrary location. What I'm trying to point out is > that the shared info structure is not the only thing (potentially)

Re: [Xen-devel] [PATCH] xen PVonHVM: require at least Xen 3.4 as dom0

2012-10-30 Thread Olaf Hering
On Tue, Oct 30, Pasi Kärkkäinen wrote: > On Tue, Oct 30, 2012 at 05:05:05PM +0100, Olaf Hering wrote: > > The XenPVHVM extensions have not been tested much on very old > > hypervisors. At least Xen 3.4 gets some testing with the pvops kernel. > > > > Require at le

Re: [Xen-devel] [PATCH] xen PVonHVM: require at least Xen 3.4 as dom0

2012-10-31 Thread Olaf Hering
On Wed, Oct 31, Ian Campbell wrote: > If I understand correctly this requirements comes from the need to > support moving the shared info page in order to support kexec? > > So could we do something more fine grained and limit only the kexec > support (and therefore the movement of the SI into th

Re: [PATCH 1/1] Drivers: hv: util: Fix a bug in version negotiation code for util services

2013-09-04 Thread Olaf Hering
On Tue, Jul 02, K. Y. Srinivasan wrote: > The current code picked the highest version advertised by the host. WS2012 R2 > has implemented a protocol version for KVP that is not compatible with prior > protocol versions of KVP. Fix the bug in the current code by explicitly > specifying > the proto

Re: [PATCH 1/1] Drivers: hv: util: Fix a bug in version negotiation code for util services

2013-09-04 Thread Olaf Hering
On Wed, Sep 04, Olaf Hering wrote: > I suggest to let callers deal with error handling. Also as a cleanup, > vmbus_prep_negotiate_resp does not make use of the negop passed to it. > So that arg can be removed. Simplify vmbus_prep_negotiate_resp. If we take the optimistic appr

Re: [PATCH 1/1] Drivers: hv: util: Fix a bug in version negotiation code for util services

2013-09-04 Thread Olaf Hering
On Wed, Sep 04, KY Srinivasan wrote: > Thanks Olaf. I would prefer that we explicitly fail the negotiations than > assume that it will succeed. > Essentially, I want the same behavior as what we had before but only for the > final version being > negotiated. If it is ok with you, I can spin up t

Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-09-27 Thread Olaf Hering
On Tue, Sep 03, K. Y. Srinivasan wrote: > Hyper-V supports a mechanism for retrieving the local APIC frequency.Use this > and bypass > the calibration code in the kernel. This would allow us to boot the Linux > kernel as a > "modern VM" on Hyper-V where many of the legacy devices (such as PIT) a

Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-09-27 Thread Olaf Hering
On Fri, Sep 27, KY Srinivasan wrote: > > This leads to build errors on 32bit: > > > > linux-3.12-rc2/arch/x86/kernel/cpu/mshyperv.c:88: undefined reference to > > `__udivdi3' > > > > Up to now I have only tested on 64bit, sorry for that. > > Thanks Olaf. I am travelling currently; I will fix it

Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard

2013-09-23 Thread Olaf Hering
On Wed, Sep 18, Dmitry Torokhov wrote: > This looks much better. Could you tell me if the patch below (on top of > yours) still works? The help text is slightly incorrect, its a dash not underscore: drivers/input/serio/hyperv-keyboard.ko Olaf -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 1/3] xen/pv-on-hvm kexec: add quirk for Xen 3.4 and shutdown watches.

2012-10-10 Thread Olaf Hering
reports like that with a sles11sp1 or sles11sp2 guest. Thats either because noone uses Xen 3.4+sles11 (or recent openSuSE) HVM guests, or because it happens to work with that combination. If the patch solves the issue: Acked-by: Olaf Hering Olaf -- To unsubscribe from this list: send the

[PATCH] xen/blkback: do not leak mode property

2012-12-03 Thread Olaf Hering
be->mode is obtained from xenbus_read, which does a kmalloc for the message body. The short string is never released, so do it on blkbk remove. Signed-off-by: Olaf Hering --- !! Not compile tested !! drivers/block/xen-blkback/xenbus.c | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [PATCH] xen/blkback: do not leak mode property

2012-12-04 Thread Olaf Hering
On Tue, Dec 04, Jan Beulich wrote: > This looks necessary but insufficient - there's nothing really > preventing backend_changed() from being called more than once > for a given device (is simply the handler of xenbus watch). Hence > I think either that function needs to be guarded against multipl

[PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be->mode. free the previous value before storing the current mode value. Signed-off-by: Olaf Hering --- !! Not compile tested !! drivers/block/xen-blkback/xenbus.c | 12 +++- 1 file changed, 7 insertions(+), 5 deleti

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Olaf Hering
On Wed, Dec 05, Jan Beulich wrote: > >>> On 05.12.12 at 11:01, Olaf Hering wrote: > > backend_changed might be called multiple times, which will leak > > be->mode. free the previous value before storing the current mode value. > > As said before - this is one po

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Olaf Hering
On Thu, Dec 06, Jan Beulich wrote: > >>> On 06.12.12 at 17:23, Olaf Hering wrote: > > On Wed, Dec 05, Jan Beulich wrote: > > > >> >>> On 05.12.12 at 11:01, Olaf Hering wrote: > >> > backend_changed might be called multiple times, which wil

[PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-11 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be->mode. Make sure it will be called only once. Remove some unneeded checks. Also the be->mode string was leaked, release the memory on device shutdown. Signed-off-by: Olaf Hering --- incorporate all comments from Jan. fo

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Olaf Hering
On Wed, Dec 12, Jan Beulich wrote: > >>> On 11.12.12 at 21:50, Olaf Hering wrote: > > backend_changed might be called multiple times, which will leak > > be->mode. Make sure it will be called only once. Remove some unneeded > > checks. Also the be->mode stri

Re: [PATCH] Tools: hv: Fix for long file names from readdir

2012-11-08 Thread Olaf Hering
On Thu, Nov 08, Tomas Hozza wrote: > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > sized buffers which could be too small to store really long names. > - char dev_id[256]; > + char dev_id[512]; Shouldnt that be PATH_MAX or similar? Olaf -- To unsubscribe from thi

Re: [PATCH net] hyperv: Fix vlan_proto setting in netvsc_recv_callback()

2013-06-14 Thread Olaf Hering
On Tue, May 28, Haiyang Zhang wrote: > Since the recent addition of 8021AD, we need to set the new field vlan_proto > in > sk_buff. Otherwise, it will trigger BUG() call in vlan_proto_idx(). > @@ -284,7 +285,7 @@ int netvsc_recv_callback(struct hv_device *device_obj, > > skb->protocol =

Re: [PATCH V2 1/1] Drivers: hv: Add a new driver to support host initiated backup

2013-03-22 Thread Olaf Hering
with attribute warn_unused_result hv_vss_daemon.c: In function 'vss_operate': hv_vss_daemon.c:47: warning: 'fs_op' may be used uninitialized in this function Signed-off-by: Olaf Hering --- a/tools/hv/hv_vss_daemon.c 2013-03-22 17:06:41.0 +0100 +++ b/tools/hv/hv_vss_daemon.

[PATCH 1/3] Tools: hv: fix warnings in hv_vss_daemon

2013-03-26 Thread Olaf Hering
o value, in function returning non-void hv_vss_daemon.c: In function 'main': hv_vss_daemon.c:130: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result hv_vss_daemon.c: In function 'vss_operate': hv_vss_daemon.c:47: warning: 'fs

[PATCH 2/3] tools: hv: fix checks for origin of netlink message in hv_vss_daemon

2013-03-26 Thread Olaf Hering
Similar to what commit 95a69adab9acfc3981c504737a2b6578e4d846ef ("tools: hv: Netlink source address validation allows DoS") does in hv_kvp_daemon, improve checks for origin of netlink connector message. Signed-off-by: Olaf Hering --- tools/hv/hv_vss_daemon.c | 8 +++- 1 file

[PATCH 3/3] tools: hv: use getmntent in hv_vss_daemon

2013-03-26 Thread Olaf Hering
As suggested by Paolo Bonzini, use getmntent instead of parsing output of mount(1). Signed-off-by: Olaf Hering --- tools/hv/hv_vss_daemon.c | 39 +-- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv

[PATCH 1/2] tools: hv: use FIFREEZE/FITHAW in hv_vss_daemon

2013-03-26 Thread Olaf Hering
As suggested by Paolo Bonzini, use ioctl instead of calling fsfreeze. Signed-off-by: Olaf Hering --- NOT runtime tested!! tools/hv/hv_vss_daemon.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv

[PATCH 2/2] tools: hv: skip iso9660 mounts in hv_vss_daemon

2013-03-26 Thread Olaf Hering
freeze does not work for iso9660 filesystems. A ENOSUPP may be catched in the freeze case, but the subsequent thaw call would fail and leads to a false error. Signed-off-by: Olaf Hering --- tools/hv/hv_vss_daemon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/hv/hv_vss_daemon.c b

[PATCH] Tools: hv: fix send/recv buffer allocation

2013-08-01 Thread Olaf Hering
allocate the needed buffers at runtime. To keep the code simple, the buffer_len includes also the nlmsghdr, although only the recv_buffer needs this extra space. Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 15 --- tools/hv/hv_vss_daemon.c | 15 --- 2 files

[PATCH] Tools: hv: check return value of daemon to fix compiler warning.

2013-08-01 Thread Olaf Hering
hv_kvp_daemon.c: In function 'main': hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 3 ++- 1 file changed, 2 insertions(+), 1 delet

[PATCH] Tools: hv: in kvp_set_ip_info free mac_addr right after usage

2013-08-01 Thread Olaf Hering
... to simplify error path in upcoming changes. Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 418ac55..ba075e5 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b

[PATCH] Tools: hv: check return value of system in hv_kvp_daemon

2013-08-01 Thread Olaf Hering
hv_kvp_daemon.c: In function 'main': hv_kvp_daemon.c:1441:8: warning: ignoring return value of 'daemon', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 6 +- 1 file changed, 5 insertions(+), 1 delet

[PATCH] Tools: hv: log errors to syslog in kvp_set_ip_info

2013-08-01 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index b96eccc..6a31ca0 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1361,7 +1361,8

[PATCH] Tools: hv: use single send+recv buffer

2013-08-06 Thread Olaf Hering
send_buffer is used only once during registration. To reduce runtime memory usage reuse the recv_buffer for registration. Also use NLMSG_LENGTH instead of NLMSG_HDRLEN to take alignment into account. Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 10 -- tools/hv

[PATCH] Tools: hv: correct payload size in netlink_send

2013-08-07 Thread Olaf Hering
. Correct the iovec size of the cn_msg to be just cn_msg + its payload. Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 2 +- tools/hv/hv_vss_daemon.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index d3bcb84

[PATCH] Tools: hv: use full nlmsghdr in netlink_send

2013-08-07 Thread Olaf Hering
There is no need to have a nlmsghdr pointer to another temporary buffer. Instead use a full struct nlmsghdr. Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 15 +-- tools/hv/hv_vss_daemon.c | 15 +-- 2 files changed, 10 insertions(+), 20 deletions(-) diff

[PATCH] Tools: hv: cache FQDN in kvp_daemon to avoid timeouts

2013-08-07 Thread Olaf Hering
value, better diagnostic for the consumer of the hostname string, remove trailing newline in error case, use snprintf to not overrun output buffer, get hostname only once and return the cached result. Signed-off-by: Olaf Hering --- tools/hv/hv_kvp_daemon.c | 19 --- 1 file changed

Re: is kexec on Xen domU possible?

2013-07-19 Thread Olaf Hering
On Fri, Jul 19, Konrad Rzeszutek Wilk wrote: > Olaf, you wouldn't have any time to look at this some more now > that Xen 4.3 is out? Currently no time to continue work on kexec for PVonHVM, sorry. Olaf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

[PATCH] Drivers: hv: remove HV_DRV_VERSION

2013-05-29 Thread Olaf Hering
red is the KVP command "IntegrationServicesVersion" which is handled by tools/hv/hv_kvp_daemon.c. To satisfy such KVP request from the host pass the current string to the daemon during KVP userland registration. Signed-off-by: Olaf Hering --- drivers/hid/hid-hyperv.c| 1 - dri

[PATCH] ata_piix: reenable MS Virtual PC guests

2012-09-18 Thread Olaf Hering
UUID: undefined, but settable Wake-up: 0x06 (Power Switch) Board Info: #2 Manufacturer: "Microsoft Corporation" Product: "Virtual Machine" Version: "7.0" Serial: "8179-1954-0187-0085-3868-2270-14" Chassis Info: #3 Manufacturer:

Re: [PATCH] unifdef linux/vt.h

2008-02-08 Thread Olaf Hering
On Fri, Jan 25, Olaf Hering wrote: > remove the newly added __KERNEL__ block from linux/vt.h Can you pick this up? The patch cant get any better. > --- a/include/linux/Kbuild > +++ b/include/linux/Kbuild > @@ -157,7 +157,6 @@ header-y += veth.h > header-y += video_decode

Re: [PATCH] unifdef linux/vt.h

2008-02-10 Thread Olaf Hering
On Fri, Feb 08, Andrew Morton wrote: > On Fri, 8 Feb 2008 18:38:10 +0100 > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > On Fri, Jan 25, Olaf Hering wrote: > > > > > remove the newly added __KERNEL__ block from linux/vt.h > > > > Can you pick th

pci_proc_init: proc_dir_entry '00' already registered

2008-02-10 Thread Olaf Hering
Current Linus tree gives this new warning during bootup: +proc_dir_entry '00' already registered +Call Trace: +[c0007b0dfba0] [c000e4b0] .show_stack+0x70/0x1bc (unreliable) +[c0007b0dfc50] [c00f2714] .proc_register+0x130/0x210 +[c0007b0dfd00] [c00f299c] .proc_mk

Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

2008-02-10 Thread Olaf Hering
> Currently, make headers_check barfs due to , which > includes, not existing. Rather than add a zillion s, export kvm.h > only if the arch actually supports it. This makes headers_install_all unreliable. linux/kvm.h will not be exported, depending on what system the libc headers will be genera

[RFC] how to mark pfn ranges as unallocatable for kexec

2012-07-20 Thread Olaf Hering
I'm working on kexec support for a ballooned (Xen PVonHVM) guests. I have a few questions about how to tweak the memory allocator. To preserve the overall memory footprint of a ballooned guest during the kexec boot the old kernel needs to "unballoon"/populate certain memory areas, and later the

Re: [PATCH 10/17] Tools: hv: Gather ipv[4,6] gateway information

2012-07-24 Thread Olaf Hering
On Tue, Jul 24, Stephen Hemminger wrote: > On Tue, 24 Jul 2012 09:01:34 -0700 > "K. Y. Srinivasan" wrote: > > > + memset(cmd, 0, sizeof(cmd)); > > + strcat(cmd, "/sbin/ip -f inet route | grep -w "); > > + strcat(cmd, if_name); > > + strcat(cmd, " | awk '/default/ {print $3 }'"); > > >

Re: [PATCH 03/17] Drivers: hv: kvp: Cleanup error handling in KVP

2012-07-25 Thread Olaf Hering
On Tue, Jul 24, K. Y. Srinivasan wrote: > +++ b/drivers/hv/hv_kvp.c > @@ -48,13 +48,24 @@ static struct { > void *kvp_context; /* for the channel callback */ > } kvp_transaction; > > +/* > + * Before we can accept KVP messages from the host, we need > + * to handshake with the user level

Re: [PATCH 1/1] Drivers: hv: Cleanup the guest ID computation

2012-07-25 Thread Olaf Hering
On Tue, Jul 24, K. Y. Srinivasan wrote: > +/* > + * The guest OS needs to register the guest ID with the hypervisor. > + * The guest ID is a 64 bit entity and the structure of this ID is > + * specified in the Hyper-V specification: > + * > + * http://msdn.microsoft.com/en-us/library/windows/ > +

Re: [PATCH V3 08/14] Tools: hv: Gather DNS information

2012-08-17 Thread Olaf Hering
On Fri, Aug 17, Ben Hutchings wrote: > On Fri, Aug 17, 2012 at 09:51:09AM -0700, Greg KH wrote: > > On Thu, Aug 16, 2012 at 06:32:19PM -0700, K. Y. Srinivasan wrote: > > > Now, gather DNS information. Invoke an external script (that can be > > > distro dependent) to gather the DNS information. > >

Re: [PATCH V3 08/14] Tools: hv: Gather DNS information

2012-08-17 Thread Olaf Hering
On Fri, Aug 17, Ben Hutchings wrote: > You are never going to have a 'works everywhere' solution for > Linux guests. The hook is the solution. > How are these distribution-specific integration scripts going > to get installed in the guesta, anyway? The packager of the daemon will write the scri

Re: [Xen-devel] incorrect layout of globals from head_64.S during kexec boot

2012-07-10 Thread Olaf Hering
On Fri, Jul 06, Olaf Hering wrote: > On Fri, Jul 06, Jan Beulich wrote: > > > > Could it be that some code tweaks the stack content used by decompress() > > > in some odd way? But that would most likely lead to a crash, not to > > > unexpected uncompressing re

Re: [Xen-devel] incorrect layout of globals from head_64.S during kexec boot

2012-07-10 Thread Olaf Hering
On Tue, Jul 10, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 10, 2012 at 11:33:27AM +0200, Olaf Hering wrote: > > On Fri, Jul 06, Olaf Hering wrote: > > > > > On Fri, Jul 06, Jan Beulich wrote: > > > > > > > > Could it be that some code tweaks

Re: [Xen-devel] [PATCH] xen/pv-on-hvm kexec: shutdown watches from old kernel

2012-07-10 Thread Olaf Hering
On Tue, Jul 10, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 10, 2012 at 02:50:03PM +0200, Olaf Hering wrote: > > Add xs_reset_watches function to shutdown watches from old kernel after > > kexec boot. The old kernel does not unregister all watches in the > > shutdown path.

Re: [Xen-devel] incorrect layout of globals from head_64.S during kexec boot

2012-07-10 Thread Olaf Hering
On Tue, Jul 10, Ian Campbell wrote: > On Tue, 2012-07-10 at 10:51 -0400, Konrad Rzeszutek Wilk wrote: > > On Tue, Jul 10, 2012 at 08:46:34AM -0600, Ian Campbell wrote: > > > On Tue, 2012-07-10 at 10:14 -0400, Konrad Rzeszutek Wilk wrote: > > > > Which brings me to another question - say we do use

Re: [Xen-devel] incorrect layout of globals from head_64.S during kexec boot

2012-07-10 Thread Olaf Hering
On Tue, Jul 10, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 10, 2012 at 05:23:08PM +0200, Olaf Hering wrote: > > I was not thinking of statically allocated pages but some new concept of > > allocating such shared pages. Shouldnt there be some dedicated area in > > the E820

Re: [PATCH] xen pv-on-hvm: add pfn_is_ram helper for kdump

2012-07-12 Thread Olaf Hering
On Thu, Jul 12, Olaf Hering wrote: > + if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a)) > + return -ENXIO; > + > + switch (a.mem_type) { > + case HVMMEM_mmio_dm: Sorry, this commit misses the required hypercall defines. I will fix it up and

Re: [Xen-devel] [PATCH] xen pv-on-hvm: add pfn_is_ram helper for kdump

2012-07-12 Thread Olaf Hering
On Thu, Jul 12, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 12, 2012 at 11:00:05AM +0200, Olaf Hering wrote: > > Register pfn_is_ram helper speed up reading /proc/vmcore in the kdump > > kernel. See commit message of 997c136f518c ("fs/proc/vmcore.c: add hook > > to read_

Re: [Xen-devel] [PATCH] xen pv-on-hvm: add pfn_is_ram helper for kdump

2012-07-12 Thread Olaf Hering
On Thu, Jul 12, Konrad Rzeszutek Wilk wrote: > > +++ b/include/xen/interface/hvm/hvm_op.h > > @@ -43,4 +43,24 @@ struct xen_hvm_pagetable_dying { > > typedef struct xen_hvm_pagetable_dying xen_hvm_pagetable_dying_t; > > DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_pagetable_dying_t); > > > > +typedef e

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-17 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: > +config HYPERV_FB This should probably be FB_HYPERB to follow the naming of all other drivers. Olaf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH V5 3/6] Tools: hv: Add an example script to configure an interface

2012-11-22 Thread Olaf Hering
On Wed, Sep 05, K. Y. Srinivasan wrote: > To keep the KVP daemon code free of distro specific details, we invoke an > external script to configure the interface. This is an example script that > was used to test the KVP code. This script has to be implemented in a Distro > specific fashion. For in

Re: [Xen-devel] [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Olaf Hering
On Wed, Dec 12, Ian Campbell wrote: > On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote: > > >>> On 11.12.12 at 21:50, Olaf Hering wrote: > > > backend_changed might be called multiple times, which will leak > > > be->mode. Make sure it will be

[PATCH] xen pv-on-hvm: add pfn_is_ram helper for kdump

2012-10-01 Thread Olaf Hering
4.2 (23298:26413986e6e0) and backported to 4.1.1. The new function is currently only enabled for reading /proc/vmcore. Later it will be used also for the kexec kernel. Since that requires more changes in the generic kernel make it static for the time being. Signed-off-by: Olaf Hering --- v2: - remov

Re: [Xen-devel] incorrect layout of globals from head_64.S during kexec boot

2012-07-06 Thread Olaf Hering
On Fri, Jul 06, Jan Beulich wrote: > > Could it be that some code tweaks the stack content used by decompress() > > in some odd way? But that would most likely lead to a crash, not to > > unexpected uncompressing results. > > Especially if the old and new kernel are using the exact same > image,

Re: race in autofs / nfs

2001-02-13 Thread Olaf Hering
On Mon, Feb 12, Olaf Hering wrote: > On Mon, Feb 12, H. Peter Anvin wrote: > > > Olaf Hering wrote: > > > > > > The autofs4.o is the culprit, it works perfect with autofs.o. > > > > > > What would happen if I stick with autofs.o now? &

Re: [ANNOUNCE] Boot log for Linux PPC64 on POWER3 hardware

2001-02-23 Thread Olaf Hering
On Fri, Feb 23, Peter Samuelson wrote: > > [Peter Bergner] > > The following is a boot log for a 64 bit port of Linux for IBM's 64 > > bit PowerPC processors. This log was made on a pSeries model 270 > > which uses a POWER3 microprocessor. > > Impressive. One question, though -- > > > starti

2.4.3-pre1 md_autodetect_dev unresolved

2001-03-03 Thread Olaf Hering
Hi, and sorry, no patch. cantaloupe:~/kernel/linuxppc_2_4 # depmod -Vae depmod version 2.4.2 depmod: *** Unresolved symbols in /lib/modules/2.4.3-pre1-SMP/kernel/drivers/md/md.o depmod: md_autodetect_dev cantaloupe:~/kernel/linuxppc_2_4 # cat /proc/version Linux version 2.4.3-pre1-SMP

up_read/up_write redefinitions in asm/semaphore.h and linux/usbdevice_fs.h

2001-01-15 Thread Olaf Hering
changed, the ppc/semaphore.h file or the linux/usbdevice_fs.h to avoid this conflict? Gruss Olaf - Forwarded message from Olaf Hering <[EMAIL PROTECTED]> ----- Date: Tue, 16 Jan 2001 04:17:43 +0100 From: Olaf Hering <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: up_read/up_writ

Re: [PATCH] 2.4.3-pre3 add PBG4 native LCD mode to modedb.c

2001-03-13 Thread Olaf Hering
On Tue, Mar 13, Jeffrey W. Baker wrote: > The attached patch adds the a new mode to the modedb, used by the ATI, > 3Dfx, and Amiga frame buffer devices. The new mode is the native, > slightly wide resolution of the new Apple laptops. It isn't obvious how > popular a mode has to be before it goe

2.4.2 freezes with bad ISOs in IDE cdroms

2001-03-20 Thread Olaf Hering
Hi, this is a bogus bugreport. The 2.4.2 kernel freezes on some machines here when I try to access (or mount) a bad self burned ISO image, in this case the boot CD with the install system. There are different case: I have an iBook and a blue&white G3. The G3 has a cmd646 controller. It freezes

Re: RE: 2.4.2 freezes with bad ISOs in IDE cdroms

2001-03-21 Thread Olaf Hering
On Wed, Mar 21, Giuliano Pochini wrote: > This happens on my blue G3 with 2.2.x too. I think it's a bug in the IDE > driver. My old 7300 (mesh) with a SCSI cd just reported a read error on > the same disk. Yes, I got that also with 2.2.18 on the G4 with cmd646. Gruss Olaf -- $ man clone BU

2.4.2 pcnet32 routing trouble

2001-03-28 Thread Olaf Hering
Hi, there is a strange "routing" bug in the pcnet32 driver. I have a 4port Ethernet card and 2 onboard connectors on an IBM B80 (pSeries 640). The machine is usualy connected via the onboard eth0 (10.10.3.21). I can bring up the interfaces on the 4port card, in this case eth5 (10.10.11.145). pin

2.4.2 cs4232 is not SMP safe

2001-03-28 Thread Olaf Hering
Hi, the current cs4232 driver is not smp safe, I get this in dmesg when I try to load it: ad1848/cs4248 codec driver Copyright (C) by Hannu Savolainen 1993-1996 at 0x534 irq 5 dma 1,0 do_IRQ waiting for irq lock (holder=0) wait_on_irq, CPU 0: irq: 1 [0 1] bh: 0 [0 0] It jumps into xmon and

  1   2   3   4   5   6   7   >