Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 1 +
include/net/tcp.h | 1 -
net/ipv4/sysctl_net_ipv4.c | 16
net/ipv4/tcp_ipv4.c| 1 +
net/ipv4/tcp_timer.c | 8
5 files changed, 14 insertions(+), 13 deletions(-)
diff --git a
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h | 2 ++
include/net/tcp.h | 1 -
net/ipv4/sysctl_net_ipv4.c | 18 +-
net/ipv4/tcp.c | 3 ++-
net/ipv4/tcp_ipv4.c| 2 ++
net/ipv4/tcp_timer.c | 4 ++--
6 files changed, 17
Signed-off-by: Nikolay Borisov
---
include/net/netns/ipv4.h| 1 +
include/net/tcp.h | 1 -
net/ipv4/inet_connection_sock.c | 7 ++-
net/ipv4/sysctl_net_ipv4.c | 14 +++---
net/ipv4/tcp_ipv4.c | 1 +
net/ipv4/tcp_timer.c| 3
Hello,
I've observed the following crash on a machine running 3.12.51:
[2711471.041886] Modules linked in: xt_length xt_state xt_pkttype xt_dscp
xt_multiport xt_set(O) ip_set_list_set(O) ip_set_hash_ip(O) ip_set(O)
act_police cls_basic sch_ingress veth dm_snapshot netconsole openvswitch gre
v
On 02/04/2016 01:32 PM, Mike Galbraith wrote:
> On Wed, 2016-02-03 at 12:58 +0200, Nikolay Borisov wrote:
>>
>> So in this case the prev/next entries do not look like corrupted, whereas
>> when manipulating the list inside detach_timer they do. This is really
>> od
On 02/04/2016 02:17 PM, Mike Galbraith wrote:
> On Thu, 2016-02-04 at 13:51 +0200, Nikolay Borisov wrote:
>>
>> On 02/04/2016 01:32 PM, Mike Galbraith wrote:
>>> On Wed, 2016-02-03 at 12:58 +0200, Nikolay Borisov wrote:
>>>>
>>>> So in this case
Hello Jiry,
On 01/05/2016 07:46 PM, Jiri Slaby wrote:
> This is the start of the stable review cycle for the 3.12.52 release.
> There are 91 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
Can you pl
On 10.06.20 г. 10:19 ч., Michał Mirosław wrote:
> Dear Developers,
>
> I found a lockdep warning in dmesg some after doing 'mdadm -S' while
> also having btrfs mounted (light to none I/O load). Disks under MD and
> btrfs are unrelated.
Huhz, I think that's genuine, because btrfs and md shared
On 3.10.20 г. 3:11 ч., Pujin Shi wrote:
> For older versions of gcc, the array = {0}; will cause warnings:
>
> fs/btrfs/tree-checker.c: In function 'check_root_item':
> fs/btrfs/tree-checker.c:1038:9: warning: missing braces around initializer
> [-Wmissing-braces]
> struct btrfs_root_item ri
On 9.05.20 г. 8:20 ч., Jia-Ju Bai wrote:
> The functions btrfs_block_group_done() and caching_thread() are
> concurrently executed at runtime in the following call contexts:
>
> Thread 1:
> btrfs_sync_file()
> start_ordered_ops()
> btrfs_fdatawrite_range()
> btrfs_writepage
oring them. This
enables diffing subsystems which generate built-in.a files.
Signed-off-by: Nikolay Borisov
---
Resending and CCing Andrew this time.
scripts/bloat-o-meter | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
index 8c965f6a9881..d7ca46c
On 28.08.20 г. 17:39 ч., Konstantin Komarov wrote:
> This patch adds NTFS Read-Write driver to fs/ntfs3.
>
> Having decades of expertise in commercial file systems development and huge
> test coverage, we at Paragon Software GmbH want to make our contribution to
> the Open Source Community by p
On 14.08.20 г. 15:29 ч., Konstantin Komarov wrote:
> This patch adds NTFS Read-Write driver to fs/ntfs3.
>
> Having decades of expertise in commercial file systems development and huge
> test coverage, we at Paragon Software GmbH want to make our contribution to
> the Open Source Community by p
data_alloc's 2nd argument is always rb::text_data_ring and that functino
always takes a struct printk_ringbuffer. Instead of passing the data
ring buffer as an argument simply make it a local variable.
Signed-off-by: Nikolay Borisov
---
kernel/printk/printk_ringbuffer.c | 9 -
1
On 10.11.20 г. 15:14 ч., John Ogness wrote:
> On 2020-11-10, Nikolay Borisov wrote:
>> data_alloc's 2nd argument is always rb::text_data_ring and that functino
>> always takes a struct printk_ringbuffer. Instead of passing the data
>> ring buffer as an argument simpl
~
> ret will not be set when olen is 0
> When olen is 0, this function does no work.
>
> So initialize ret to 0
>
> Signed-off-by: Tom Rix
And I forgot:
Reviewed-by: Nikolay Borisov
> ---
> fs/btrfs/reflink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
On 5.07.20 г. 17:20 ч., t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analysis flags a garbage return
>
> fs/btrfs/reflink.c:611:2: warning: Undefined or garbage value returned to
> caller [core.uninitialized.UndefReturn]
> return ret;
> ^~
> ret will not be
8d45a590
>
> The issue was bisected to:
>
> commit 6a3c7f5c87854e948c3c234e5f5e745c7c553722
> Author: Nikolay Borisov
> Date: Thu May 28 08:05:13 2020 +
>
> btrfs: don't balance btree inode pages from buffered write path
>
> bisection log: https
On 17.09.20 г. 4:44 ч., Dave Chinner wrote:
> On Wed, Sep 16, 2020 at 05:58:51PM +0200, Jan Kara wrote:
>> On Sat 12-09-20 09:19:11, Amir Goldstein wrote:
>>> On Tue, Jun 23, 2020 at 8:21 AM Dave Chinner wrote:
>
> So
>
> P0p1
>
> hole punch starts
On 21.09.20 г. 10:29 ч., qiang.zh...@windriver.com wrote:
> From: Zqiang
>
> When the btrfs fill super error, we should first close devices and
> then call deactivate_locked_super func to free fs_info.
>
> Signed-off-by: Zqiang
> ---
> fs/btrfs/super.c | 1 +
> 1 file changed, 1 insertion(+
care. Additionally there is already
locdep_assert_held_read, this bring asymmetry to the naming.
No functional changes.
Signed-off-by: Nikolay Borisov
---
arch/x86/events/core.c | 2 +-
drivers/infiniband/core/device.c | 2 +-
drivers/tty/tty_ldisc.c | 8
fs/
On 14.04.2017 17:07, Andrey Ryabinin wrote:
> invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0
> which doen't make any sense.
> Make invalidate_bdev() always invalidate cleancache data.
>
> Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache")
> Signed-off-by: An
On 24.03.2017 10:25, Nikolay Borisov wrote:
> register_shrinker allocates dynamic memory and thus is susceptible to failures
> under low-memory situation. Currently,get_userns ignores the return value of
> register_shrinker, potentially exposing not fully initialised object. This
> c
On 31.03.2017 22:26, Jeff Layton wrote:
> Most filesystems currently use mapping_set_error and
> filemap_check_errors for setting and reporting/clearing writeback errors
> at the mapping level. filemap_check_errors is indirectly called from
> most of the filemap_fdatawait_* functions and from
> f
[CC'ing Andrew since he seems to be taking those patches through -mm ]
On 23.06.2017 18:11, Nikolay Borisov wrote:
> wb_stat_sum disables interrupts and calls __wb_stat_sum which eventually calls
> __percpu_counter_sum. However, the percpu routine is already irq-safe.
> Simplify
&g
On 4.07.2017 14:49, Aleksa Sarai wrote:
> Several distributions mount the "proper root" as ro during initrd and
> then remount it as rw before pivot_root(2). Thus, if a rescan had been
> aborted by a previous shutdown, the rescan would never be resumed.
>
> This issue would manifest itself as s
On 10.07.2017 16:12, Nikolay Borisov wrote:
>
>
> On 4.07.2017 14:49, Aleksa Sarai wrote:
>> Several distributions mount the "proper root" as ro during initrd and
>> then remount it as rw before pivot_root(2). Thus, if a rescan had been
>> aborted by
On 2.08.2017 10:10, Nikolay Borisov wrote:
> We already get the block counts and the calculate the end block at the
> beginning of the function. Let's use the local variables for consistency and
> readability. No functional changes
>
> Signed-off-by: Nikolay Borisov
>
This flag was added by 6039257378e4 ("direct-io: add flag to allow aio
writes beyond i_size") to support XFS. However, with the rework of
XFS' DIO's path to use iomap in acdda3aae146 ("xfs: use iomap_dio_rw")
it became redundant. So let's remove it.
Signed-off-
sed. So let's remove it.
Signed-off-by: Nikolay Borisov
---
fs/direct-io.c | 6 ++
include/linux/fs.h | 3 ---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 99a81c49bce9..a8131087aa1c 100644
--- a/fs/direct-io.c
+++ b/fs/
Hello,
I'm cc'ing a bunch of people I know are well-versed in
the black arts of memory ordering!
Currently in btrfs we have roughly the following sequence:
T1:
T2:
i_size_write(inode, newsize
On 23.02.2018 17:38, Alan Cox wrote:
>> Given this is the current state of the code (it's part of btrfs) I believe
>> the following could/should be done:
>
> Is there benchmarking data to show that a custom lock is justified
> (especiaally given it's going to mean btrfs and rtlinux don't play
>
On 23.02.2018 19:31, Andrea Parri wrote:
> On Fri, Feb 23, 2018 at 02:30:22PM +0200, Nikolay Borisov wrote:
>> Hello,
>>
>> I'm cc'ing a bunch of people I know are well-versed in
>> the black arts of memory ordering!
>>
>> Currently in btrfs
requirement of a lock being held while
bumping i_dio_count.
Signed-off-by: Nikolay Borisov
---
include/linux/fs.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 511fbaabf624..90ac851930ae 100644
--- a/include/linux/fs.h
+++ b
Rewrite the final sentence of data dependency memory barrier to express
the 'after' relationship in simpler words.
Signed-off-by: Nikolay Borisov
---
Documentation/memory-barriers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/memory-barri
On 8.02.2018 13:43, Tetsuo Handa wrote:
>>From 361d37a7d36978020dfb4c11ec1f4800937ccb68 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa
> Date: Thu, 8 Feb 2018 10:35:35 +0900
> Subject: [PATCH v2] lockdep: Fix fs_reclaim warning.
>
> Dave Jones reported fs_reclaim lockdep warnings.
>
> ==
We already get the block counts and the calculate the end block at the
beginning of the function. Let's use the local variables for consistency and
readability. No functional changes
Signed-off-by: Nikolay Borisov
Reviewed-by: Jeff Moyer
---
Andrew,
Sending to you since this has
Hello Tejun,
So while running some fs tests I hit the following GPF. Btw the
warning taint flag was due to a debugging WARN_ON in btrfs 100 or so
tests ago so is unrelated to this gpf:
[ 4255.628110] general protection fault: [#1] SMP PTI
[ 4255.628303] Modules linked in:
[ 4255.628446] C
On 27.02.2018 18:05, Nikolay Borisov wrote:
> Hello Tejun,
>
> So while running some fs tests I hit the following GPF. Btw the
> warning taint flag was due to a debugging WARN_ON in btrfs 100 or so
> tests ago so is unrelated to this gpf:
>
> [ 4255.628110] general p
On 12.12.2017 09:21, Yaowei Bai wrote:
> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote:
>> On Mon, 11 Dec 2017, Yaowei Bai wrote:
>>
>>> This patchset makes some *_is_* like functions return bool because
>>> these functions only use true or false as their return values.
>>>
>>> N
On 9.12.2017 21:25, Tejun Heo wrote:
> After the recent updates to use generation number and state based
> synchronization, we can easily replace REQ_ATOM_STARTED usages by
> adding an extra state to distinguish completed but not yet freed
> state.
>
> Add MQ_RQ_COMPLETE and replace REQ_ATOM_ST
On 11.12.2017 18:00, Scott Bauer wrote:
> Signed-off-by: Scott Bauer
> ---
> Documentation/device-mapper/dm-unstripe.txt | 82
> +
> 1 file changed, 82 insertions(+)
> create mode 100644 Documentation/device-mapper/dm-unstripe.txt
>
> diff --git a/Documentation/de
On 2.08.2017 10:10, Nikolay Borisov wrote:
> We already get the block counts and the calculate the end block at the
> beginning of the function. Let's use the local variables for consistency and
> readability. No functional changes
>
> Signed-off-by: Nikolay Borisov
>
On 30.08.2017 18:00, Christoph Hellwig wrote:
> Instead of playing with the addressing limits.
>
> Signed-off-by: Christoph Hellwig
> ---
Reviewed-by: Nikolay Borisov
> fs/btrfs/send.c | 18 --
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
&g
Currently there are no ->swap_{in,out} method in address_space_operations
sructure definition, so the statement that anything is going to be proxied
through them is wrong.
Signed-off-by: Nikolay Borisov
---
Documentation/filesystems/vfs.txt | 4 +---
1 file changed, 1 insertion(+), 3 deleti
Hello Tejun,
I've hit the following problems under memory-heavy workload conditions:
First is a BUG_ON : J_ASSERT(journal_current_handle() == handle);
[ 64.261793] kernel BUG at fs/jbd2/transaction.c:1644!
[ 64.263894] invalid opcode: [#1] SMP
[ 64.266187
Hello,
This series is a report of Josef's original posting [1]. I've included
fine-grained changelog in each patch with my changes. Basically, I've forward
ported it to 4.12-rc6 and tried incorporating the feedback which was given to
every individual patch (I've included link with that informat
Reviewed-by: Tejun Heo
Signed-off-by: Nikolay Borisov
---
Changes since previous posting [1] :
- Forward ported to 4.12-rc6 kernel
I've retained the review-by tags since I didn't introduce any changes.
[1] https://patchwork.kernel.org/patch/9395213/
fs/fs-writeback.
hange the counters as well. Additionally, scale
WB_STAT_BATCH based on whether we are incrementing byte-based or page-based
counters.
Signed-off-by: Josef Bacik
Signed-off-by: Nikolay Borisov
---
Changes since previous posting [1]:
- Incorporated Jan Kara's feedback to rename __wb_write
ystem. This is also needed so things like dirty
throttling know that this is dirtyable memory as well and easily reclaimed.
This patch doesn't introduce any functional changes.
Signed-off-by: Josef Bacik
Signed-off-by: Nikolay Borisov
---
Changs since previous posting [1]:
- Forward
just pass in the bdi and super
block directly so we can avoid using mapping. This will allow us to still use
balance_dirty_pages for dirty metadata pages that are not backed by an
address_mapping.
Signed-off-by: Josef Bacik
Reviewed-by: Jan Kara
Acked-by: Tejun Heo
Signed-off-by: Nikolay Bo
__wb_stat_sum which was
just a wrapper over percpu_counter_sum_positive
Signed-off-by: Nikolay Borisov
---
include/linux/backing-dev.h | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index e9c967b86054
On 2.06.2017 02:02, Yu Zhao wrote:
> mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() have
> identical logics. Refactor code so we don't need to keep two pieces
> of code that does same thing.
>
> Signed-off-by: Yu Zhao
> ---
> mm/memcontrol.c | 71
> +---
on __ versions are just wrappers around the __ specific calls. So
the code is identical.
Reviewed-by: Nikolay Borisov
On 10.10.2017 13:48, Rakesh Pandit wrote:
> Commit a53f4f8e9c8eb ("btrfs: Don't call btrfs_start_transaction() on
> frozen fs to avoid deadlock.") started using internal calls and we
> replace them with more suitable ones.
>
> Signed-off-by: Rakesh Pandit
> ---
> fs/btrfs/super.c | 4 ++--
> 1
On 27.09.2017 23:13, Jens Axboe wrote:
> We currently it it for find_or_create_page(), which means that it
nit: Perhaps you wanted to write "We currently use it for find_..."
otherwise:
Reviewed-by: Nikolay Borisov
> cannot fail. Ensure we also pass in &#
gt; Signed-off-by: Jens Axboe
Reviewed-by: Nikolay Borisov
> ---
> drivers/md/bitmap.c | 2 +-
> fs/buffer.c | 33 ++---
> fs/ntfs/aops.c | 2 +-
> fs/ntfs/mft.c | 2 +-
> include/linux/buffer_head.h
o the last user of free_more_memory(), kill
> it off completely.
>
> Signed-off-by: Jens Axboe
Reviewed-by: Nikolay Borisov
> ---
> fs/buffer.c | 23 ---
> 1 file changed, 23 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 3b60cd84
On 8.08.2017 09:00, Byungchul Park wrote:
> On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote:
> + llist_for_each_entry_safe(cl, t, reverse, list) {
Just wondering why not using llist_for_each_entry(), or you use the
_safe version on purpose ?
>>>
>>> If I use llist_for_
We already get the block counts and the calculate the end block at the
beginning of the function. Let's use the local variables for consistency and
readability. No functional changes
Signed-off-by: Nikolay Borisov
---
fs/direct-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 dele
On 19.10.2017 22:11, Christian Brauner wrote:
> - Add a struct containing two pointer to extents and wrap both the static
> extent
> array and the struct into a union. This is done in preparation for bumping
> the
> {g,u}idmap limits for user namespaces.
> - Add brackets around anonymous un
On 23.10.2017 09:39, Nikolay Borisov wrote:
>
>
> On 19.10.2017 22:11, Christian Brauner wrote:
>> - Add a struct containing two pointer to extents and wrap both the static
>> extent
>> array and the struct into a union. This is done in preparation for bumping
&g
On 9.11.2017 05:22, NeilBrown wrote:
> d_move() will call __d_drop() and then __d_rehash()
> on the dentry being moved. This creates a small window
> when the dentry appears to be unhashed. Many tests
> of d_unhashed() are made under ->d_lock and so are safe
> from racing with this window, but
On 9.11.2017 15:08, Matthew Wilcox wrote:
> On Thu, Nov 09, 2017 at 01:41:24PM +0200, Nikolay Borisov wrote:
>> On 9.11.2017 05:22, NeilBrown wrote:
>>> @@ -493,12 +496,18 @@ void __d_drop(struct dentry *dentry)
>>> } else
>>>
From: Nikolay Borisov
In some situation it might be useful to disable checking the
kernel release. This happens when a kernel module is being rebuilt
and then probed. Without this override one has to reboot the machine
with the new kernel (and module) and then use systemtap.
To rectify the
ch in turn block
synchronize_rcu operations, which more or less de-stabilises
the whole system.
Fix this by introducing a cond_resched at the beginning
of the loop.
Signed-off-by: Nikolay Borisov
---
So this patch fixes the following:
NMI watchdog: BUG: soft lockup - CPU#10 stuck for 23s! [h
On 09/29/2016 04:14 PM, Nikolay Borisov wrote:
> From: Nikolay Borisov
>
> In some situation it might be useful to disable checking the
> kernel release. This happens when a kernel module is being rebuilt
> and then probed. Without this override one has to reboot the machine
Hello Peter,
I've emailed you before re. spurious hangs in the TTY layer, but
at that time I was running a rather old (but LTS) 3.12 kernel. Now,
I'm running a 4.4.10 and I still observe the following lock-ups.
I have multiple processes which hang with the following callstack:
[4592064.96744
Explicitly state that enabling RCU_TRACE enables more
tracepoints and not just "additional tracing".
Signed-off-by: Nikolay Borisov
---
Hello Paul,
Following our latest conversation re. enabling RCU tracing
I had to actually go and look into the code to see which
option e
On 10/05/2016 05:03 PM, Paul E. McKenney wrote:
> On Wed, Oct 05, 2016 at 10:06:21AM +0300, Nikolay Borisov wrote:
>> Explicitly state that enabling RCU_TRACE enables more
>> tracepoints and not just "additional tracing".
>>
>> Signed-off-by: Nik
On 20.08.2016 20:03, T. Smith wrote:
> The goal is to isolate causes of indeterminism when using the PREEMPT_RT
> kernel configuration with full preemption and to characterize latency and
> jitter using ftrace, any recommendations?
What hardware is it ? If it's x86 it's entirely possible you a
[SNIP]
>
> Signed-off-by: Ding Tianhong
> [ paulmck: Substituted cond_resched_rcu_qs for cond_resched. ]
This contradicts...
> Signed-off-by: Paul E. McKenney
> ---
> kernel/rcu/tree_plugin.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree
On 22.08.2016 19:44, Paul E. McKenney wrote:
> On Mon, Aug 22, 2016 at 07:19:53PM +0300, Nikolay Borisov wrote:
>>
>> [SNIP]
>>>
>>> Signed-off-by: Ding Tianhong
>>> [ paulmck: Substituted cond_resched_rcu_qs for cond_resched. ]
>>
>> This
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 442187f3c2de40bab13b8f9751b37925bede73b0
Gitweb:
https://git.kernel.org/tip/442187f3c2de40bab13b8f9751b37925bede73b0
Author:Nikolay Borisov
AuthorDate:Tue, 26 Jan 2021 12:17:21 +02:00
Commit-ID: 8c8a457a60050d5922676f81913d87e4af6fd97b
Gitweb: http://git.kernel.org/tip/8c8a457a60050d5922676f81913d87e4af6fd97b
Author: Nikolay Borisov
AuthorDate: Thu, 14 May 2015 14:31:01 +0300
Committer: Ingo Molnar
CommitDate: Thu, 14 May 2015 20:04:43 +0200
sched: Remove redundant
Commit-ID: 9ffbe8ac05dbb4ab4a4836a55a47fc6be945a38f
Gitweb: https://git.kernel.org/tip/9ffbe8ac05dbb4ab4a4836a55a47fc6be945a38f
Author: Nikolay Borisov
AuthorDate: Fri, 31 May 2019 13:06:51 +0300
Committer: Ingo Molnar
CommitDate: Mon, 17 Jun 2019 12:09:24 +0200
locking/lockdep
Commit-ID: 51de78892b1294d1521c41226a5ef215a910c25f
Gitweb: https://git.kernel.org/tip/51de78892b1294d1521c41226a5ef215a910c25f
Author: Nikolay Borisov
AuthorDate: Tue, 20 Feb 2018 15:25:08 -0800
Committer: Ingo Molnar
CommitDate: Wed, 21 Feb 2018 09:58:14 +0100
memory-barriers: Fix
Commit-ID: 08645077b7f9f7824dbaf1959b0e014a894c8acc
Gitweb: http://git.kernel.org/tip/08645077b7f9f7824dbaf1959b0e014a894c8acc
Author: Nikolay Borisov
AuthorDate: Mon, 26 Sep 2016 21:11:18 +0300
Committer: Ingo Molnar
CommitDate: Fri, 30 Sep 2016 10:56:01 +0200
x86/cmpxchg, locking
301 - 378 of 378 matches
Mail list logo
