Hello,
Running perf version 4.4.14.g0cb188d (no modification to the PMU/perf
code) I observed that "perf top" counts no cycles and produces no
output. After a bit of head scratching and testing I figured that
running "perf top -e cycles" actually works whereas the default option
is equivalent to r
On 07/20/2016 05:34 PM, Jiri Olsa wrote:
> On Wed, Jul 20, 2016 at 04:28:34PM +0300, Nikolay Borisov wrote:
>> Hello,
>>
>> Running perf version 4.4.14.g0cb188d (no modification to the PMU/perf
>> code) I observed that "perf top" counts no cycles and produ
On 06/17/2016 07:25 PM, Johannes Weiner wrote:
> The memory controller has quite a bit of state that usually outlives
> the cgroup and pins its CSS until said state disappears. At the same
> time it imposes a 16-bit limit on the CSS ID space to economically
> store IDs in the wild. Consequently,
On Wed, Sep 14, 2016 at 3:58 PM, Oleg Nesterov wrote:
> On 09/14, Nikolay Borisov wrote:
>>
>> [ 557.006656] [] dump_stack+0x6b/0xa0
>> [ 557.012737] [] warn_slowpath_common+0x95/0xe0
>> [ 557.019781] [] warn_slowpath_null+0x1a/0x20
>> [ 557.02664
On 25.09.2016 15:40, Tomasz Chmielewski wrote:
> On 2016-09-25 18:29, Tomasz Chmielewski wrote:
>
>>> I'll try to bisect.
>>
>> OK, not a kernel regression, but some config change caused it.
>> However, I'm not able to locate which change exactly.
>>
>> I'm attaching two configs which I've tried
cmpxchg contained definitions for unused (x)add_* operations, dating back
to the original ticket spinlock implementation. Nowadays these are
unused so remove them.
Signed-off-by: Nikolay Borisov
---
arch/x86/include/asm/cmpxchg.h | 44 --
1 file changed
[Added Dave Miller to see what's the status of this patch]
On 08/30/2016 12:18 PM, Miklos Szeredi wrote:
> On Tue, Aug 30, 2016 at 12:37 AM, Miklos Szeredi wrote:
>> On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote:
>
>> crash> list -H gc_inflight_list unix_sock.link -s unix_sock.inflight
On 08/24/2016 07:40 PM, Tejun Heo wrote:
> Hello, Alexander.
>
> On Wed, Aug 24, 2016 at 06:37:35PM +0200, Alexander Potapenko wrote:
>> Commit the script that symbolizes BUG messages and KASAN error reports
>> by adding file:line information to each stack frame.
>> The script is a copy of
>> ht
On 09/12/2016 04:01 PM, Oleg Nesterov wrote:
> Hi Nikolay,
>
[SNIP..]
>>
>>
>> The bug on in question is this: BUG_ON(rsp->gp_state != GP_PASSED);
>>
>> Have you seen something like that before - the kernel is fairly old 4.4.2,
>
> No... thanks, I'll try to look tomorrow.
I just re-run the tes
On 09/13/2016 05:35 PM, Nikolay Borisov wrote:
>
>
> On 09/13/2016 04:43 PM, Oleg Nesterov wrote:
>> On 09/13, Oleg Nesterov wrote:
>>>
>>> OK... perhaps the unbalanced up_write... I'll try to look at freeze/thaw
>>> code,
>>
>> Heh
On 09/13/2016 04:43 PM, Oleg Nesterov wrote:
> On 09/13, Oleg Nesterov wrote:
>>
>> OK... perhaps the unbalanced up_write... I'll try to look at freeze/thaw
>> code,
>
> Heh, yes, it looks racy or I am totally confused.
>
>> could test the debugging patch below meanwhile?
>
> Yes please. I'll
On 09/13/2016 05:38 PM, Nikolay Borisov wrote:
>
>
> On 09/13/2016 05:35 PM, Nikolay Borisov wrote:
>>
>>
>> On 09/13/2016 04:43 PM, Oleg Nesterov wrote:
>>> On 09/13, Oleg Nesterov wrote:
>>>>
>>>> OK... perhaps the unbal
On 09/13/2016 06:20 PM, Oleg Nesterov wrote:
> On 09/13, Nikolay Borisov wrote:
>>
>> On 09/13/2016 05:35 PM, Nikolay Borisov wrote:
>>>
>>> On 09/13/2016 04:43 PM, Oleg Nesterov wrote:
>>>> On 09/13, Oleg Nesterov wrote:
>>>>>
>&g
On 08/04/2016 06:29 PM, Jiri Olsa wrote:
> On Tue, Jul 26, 2016 at 02:30:46PM +0300, Nikolay Borisov wrote:
[SNIP]
>
> sorry for late response..
>
> I checked on f22 kernel and it's missing the core2 PEBs fix:
> 1424a09a9e18 perf/x86: fix PEBS issues on Intel At
Hello,
I hit the following BUG:
[1851513.239831] [ cut here ]
[1851513.240079] kernel BUG at net/unix/garbage.c:149!
[1851513.240313] invalid opcode: [#1] SMP
[1851513.248320] CPU: 37 PID: 11683 Comm: nginx Tainted: G O
4.4.14-clouder3 #26
[1851513.24
On Thu, Aug 25, 2016 at 12:40 AM, Hannes Frederic Sowa
wrote:
> On 24.08.2016 16:24, Nikolay Borisov wrote:
[SNIP]
>
> One commit which could have to do with that is
>
> commit fc64869c48494a401b1fb627c9ecc4e6c1d74b0d
> Author: Andrey Ryabinin
> Date: Wed May 18 19:19:27 2
minor nit below
On 18.07.2017 01:22, Andy Lutomirski wrote:
> We can currently blow past the stack rlimit and cause odd behavior
> if there are accounting bugs, rounding issues, or races. It's not
> clear that the odd behavior is actually a problem, but it's nicer to
> fail the exec instead of ge
ikely result in better runtime of code which deals with modifying the stat
counters.
Signed-off-by: Nikolay Borisov
---
Hello Tejun,
This patch resulted from me reading your feedback on Josef's memory
throttling prep patch https://patchwork.kernel.org/patch/9395219/ . If these
changes are m
pective of CONFIG_SNMP value.
The only difference is that the __ version takes a batch parameter.
Make this a bit more explicit by just renaming __percpu_counter_add to
percpu_counter_add_batch.
Signed-off-by: Nikolay Borisov
---
fs/btrfs/disk-io.c | 4 ++--
fs/btrfs/extent_io.c
eader since currently it's being included in all files which exhibit
this pattern. Also let's rename it to something a bit more verbose.
This patch doesn't introduce any functional changes
[1] https://patchwork.kernel.org/patch/9395205/
Signed-off-by: Nikolay Borisov
---
arch/t
of CONFIG_SMP. The only difference is that the
__ version takes a batch parameter.
Make this a bit more explicit by just renaming __percpu_counter_add to
percpu_counter_add_batch.
Signed-off-by: Nikolay Borisov
---
fs/btrfs/disk-io.c | 4 ++--
fs/btrfs/extent_io.c | 2
ance. This will likely result in better runtime of code which deals with
modifying the stat counters.
Signed-off-by: Nikolay Borisov
---
include/linux/backing-dev.h | 24 ++--
mm/page-writeback.c | 10 +-
2 files changed, 7 insertions(+), 27 deletions(-)
di
On 20.06.2017 22:37, Tejun Heo wrote:
> Hello, Nikolay.
>
> On Tue, Jun 20, 2017 at 09:02:00PM +0300, Nikolay Borisov wrote:
>> Currently the writeback statistics code uses a percpu counters to hold
>> various statistics. Furthermore we have 2 families of functions - t
On 20.06.2017 23:30, Tejun Heo wrote:
> Hello,
>
> On Tue, Jun 20, 2017 at 11:28:30PM +0300, Nikolay Borisov wrote:
>>> Heh, looks like I was confused. __percpu_counter_add() is not
>>> irq-safe. It disables preemption and uses __this_cpu_read(), so
>>> th
ance. This will likely result in better runtime of code which deals with
modifying the stat counters.
While at it also document why percpu_counter_add_batch is in fact preempt and
irq-safe since at least 3 people got confused.
Signed-off-by: Nikolay Borisov
---
Changes since v2:
* Fixed bui
On 22.06.2017 09:44, Michal Hocko wrote:
> On Tue 20-06-17 18:14:28, Nikolay Borisov wrote:
>> Currently there are a multiple files with the following code:
>> #define K(x) ((x) << (PAGE_SHIFT - 10))
>> ... some code..
>> #undef K
>>
>> This is
On 1.11.2017 01:48, Eric W. Biederman wrote:
>
> This is important so reading /proc//{uid_map,gid_map,projid_map} while
> the map is being written does not do strange things.
>
> Signed-off-by: "Eric W. Biederman"
> ---
> kernel/user_namespace.c | 6 --
> 1 file changed, 4 insertions(+),
[CCing some memory-barriers people + checkpatch maintainers]
On 1.11.2017 13:08, Eric W. Biederman wrote:
> Nikolay Borisov writes:
>
>> On 1.11.2017 01:48, Eric W. Biederman wrote:
>>>
>>> This is important so reading /proc//{uid_map,gid_map,projid_map} whil
Hello and thanks for the reply,
On 10/12/2015 04:40 PM, Jan Kara wrote:
> On Fri 09-10-15 11:03:30, Nikolay Borisov wrote:
>> On 10/09/2015 10:37 AM, Hillf Danton wrote:
>>>>>> @@ -109,8 +109,8 @@ static void ext4_finish_bio(struct bio *bio)
>>>>>&g
On 10/13/2015 11:15 AM, Jan Kara wrote:
> On Mon 12-10-15 17:51:07, Nikolay Borisov wrote:
>> Hello and thanks for the reply,
>>
>> On 10/12/2015 04:40 PM, Jan Kara wrote:
>>> On Fri 09-10-15 11:03:30, Nikolay Borisov wrote:
>>>> On 10/09/2015 10:37
On 10/13/2015 04:14 PM, Jan Kara wrote:
> On Tue 13-10-15 13:37:16, Nikolay Borisov wrote:
>>
>>
>> On 10/13/2015 11:15 AM, Jan Kara wrote:
>>> On Mon 12-10-15 17:51:07, Nikolay Borisov wrote:
>>>> Hello and thanks for the reply,
>>>>
>&g
The entry_SYSCALL_64_fastpath was checking the value of __SYSCALL_MASK,
which in turn was being set in arch/x86/include/asm/unistd.h depending on
whether CONFIG_X86_X32_ABI was set or not. This made the intention a bit
cryptic.
Juggle the code around so that the conditional compilation depends on
the value of CONFIG_X86_X32_ABI
Signed-off-by: Nikolay Borisov
---
Sending v2 as I had forgotten to add my signed-off-by line.
arch/x86/entry/entry_64.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 8cb3e43
Hello,
On one of our servers I've observed the a kernel pannic
happening with the following backtrace:
[654405.527070] BUG: unable to handle kernel paging request at 00028001
[654405.527076] IP: [] kmem_cache_alloc_node+0x99/0x1e0
[654405.527085] PGD 14bef58067 PUD 2ab358067 PMD 0
[654
rrupted.
Doing addr2line on the other paging request failures also show that the
issue is in the same function - get_freepointer:
addr2line -f -e vmlinux-4.1.6-clouder1 811824e5
get_freepointer
/home/projects/linux-stable/mm/slub.c:247
Regards,
Nikolay
On 09/07/2015 11:41 AM, Nikolay Boris
Mon, 07 Sep 2015 11:41:17 +0300, Nikolay Borisov wrote:
>
>> Hello,
>>
>> On one of our servers I've observed the a kernel pannic
>> happening with the following backtrace:
>>
>> [654405.527070] BUG: unable to handle kernel paging reques
From: Nikolay Borisov
This patch introduce the usage of the userns_nproc_* functions
where necessary to have correct accounting of the processes.
Signed-off-by: Nikolay Borisov
---
kernel/cred.c | 36 ++--
kernel/exit.c | 9 +
kernel/fork.c | 33
From: Nikolay Borisov
Hello,
This is an initial try to have nproc count apply per-userns,
rather than per the global user struct. The implementation is
really simple - a hashtable holding uid->nproc mapping for each
id inside the respective namespace. In its current form I have also
left
From: Nikolay Borisov
This patch add a simple hashtable to the user_namespace structure and
the necessary functions to work with it. The idea is to keep a
uid->nproc counts per-namespace.
Signed-off-by: Nikolay Borisov
---
include/linux/user_namespace.h | 15 +-
kernel/use
On 09/08/2015 04:58 PM, Christoph Lameter wrote:
> On Mon, 7 Sep 2015, Nikolay Borisov wrote:
>
>> Did a bit more investigation and it turns out the
>> corruption is happening in slab_alloc_node, in the
>> 'else' branch when get_freepointer is being called:
On 09/08/2015 05:27 PM, Christoph Lameter wrote:
> On Tue, 8 Sep 2015, Nikolay Borisov wrote:
>
>> Unfortunately I haven't found a way to reproduce it so the only option
>> would be to do this on a live server. However, the performance impact I
>> believe is
On 09/08/2015 06:15 PM, Christoph Lameter wrote:
> On Tue, 8 Sep 2015, Nikolay Borisov wrote:
>
>>> You have read https://www.kernel.org/doc/Documentation/vm/slub.txt?
>>
>> I've read that I'm also following the merge/nomerge thread on the DM
>> mail
On 10/13/2015 04:14 PM, Jan Kara wrote:
> On Tue 13-10-15 13:37:16, Nikolay Borisov wrote:
>>
>>
>> On 10/13/2015 11:15 AM, Jan Kara wrote:
>>> On Mon 12-10-15 17:51:07, Nikolay Borisov wrote:
>>>> Hello and thanks for the reply,
>>>>
>&g
en randomizes the superblock, thus flipping on the feature
> bits.
>
> Reported-by: Nikolay Borisov
> Signed-off-by: Darrick J. Wong
> ---
> fs/jbd2/journal.c| 12 +---
> include/linux/jbd2.h | 10 ++
> 2 files changed, 15 insertions(+), 7 deletions(-)
journal crash if someone loads a journal in no-csum
> mode and then randomizes the superblock, thus flipping on the feature
> bits.
>
> v2: Create a feature-test helper, use it everywhere.
>
> Tested-By: Nikolay Borisov
> Reported-by: Nikolay Borisov
> Signed-off
On 10/05/2015 09:21 AM, Darrick J. Wong wrote:
> On Mon, Oct 05, 2015 at 08:43:34AM +0300, Nikolay Borisov wrote:
>> It is just me or am I not seeing this feature test helper in this patch ?
>>
>> On 10/03/2015 06:46 AM, Darrick J. Wong wrote:
>>> Change the journa
ode() to btrfs_iget() and kill now obviously pointless
> ASSERT() in there.
>
> Signed-off-by: Al Viro
Reviewed-by: Nikolay Borisov
> ---
> fs/btrfs/inode.c | 24
> 1 file changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/fs/btrf
On 26.07.2018 17:37, Christoph Hellwig wrote:
> From: Palmer Dabbelt
>
> This patch adds documentation for the platform-level interrupt
> controller (PLIC) found in all RISC-V systems. This interrupt
> controller routes interrupts from all the devices in the system to each
> hart-local interr
On 23.01.2018 20:32, Steven Rostedt wrote:
> With the new ORC unwinder, ftrace stack tracing became disfunctional.
>
> One was that ORC didn't know how to handle the ftrace callbacks in
> general (which Josh fixed). The other was that ORC would just bail
> if it hit a dynamically allocated tramp
On 10.05.2017 19:47, Trond Myklebust wrote:
> Hi Linus,
>
> The following changes since commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3:
>
> Linux 4.11-rc7 (2017-04-16 13:00:18 -0700)
>
> are available in the git repository at:
>
> git://git.linux-nfs.org/projects/trondmy/linux-nfs.git ta
On 11.01.2018 13:29, Olivier Galibert wrote:
> Wasn't/Isn't the 4G/4G memory layout for 32 bits essentially KPTI?
4g/4g was never accepted upstream
>
> OG.
>
>
> On Thu, Jan 11, 2018 at 12:32 AM, Pavel Machek wrote:
>> Hi!
>>
>>> The one thing I want to do now that Meltdown and Spectre a
ilp_open (811b8a8a)
=> do_sys_open (811a64a7)
=> SyS_open (811a659e)
=> entry_SYSCALL_64_fastpath (8180009b)
Signed-off-by: Nikolay Borisov
---
Strange why __trace_stack and __ftrace_trace_stack are not part of the stack
and don't need to be filt
On 23.01.2018 01:16, Steven Rostedt wrote:
> On Mon, 22 Jan 2018 15:50:04 +0200
> Nikolay Borisov wrote:
>
>
>> diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c
>> index 27f7ad12c4b1..b721f1f3f3c0 100644
>> --- a/kernel/trace/trace_fun
On 4.01.2018 02:47, Tim Mouraveiko wrote:
> Hi,
>
> In all my years of extensive experience writing drivers and kernels, I never
> came across a situation
> where you could brick an x86 CPU. Not until recently, when I was working on
> debugging a piece of
> code and I bricked an Intel CPU.
This function returns a string with the currently in-use implementation
of the crc32c algorithm, i.e crc32c-generic (for unoptimised, generic
implementation) or crc32c-intel for the sse optimised version. This
will be used by btrfs.
Signed-off-by: Nikolay Borisov
---
include/linux/crc32c.h | 1
re or hw-accelerated)
to retain current btrfs behavior. This is mainly used for debugging purposes
and is independent.
Nikolay Borisov (2):
libcrc32c: Add crc32c_impl function
btrfs: Remove custom crc32c init code
fs/btrfs/Kconfig | 3 +--
fs/btrfs/Makefile | 2 +-
fs/
lly btrfs was switched to late_initcall which
comes after the generic crc32c implementation is initiliased. The
latter commit superseeded the former. Now that we don't have to
maintain our own code let's just remove it and switch to using the
generic implementation.
Signed-off-by: Nikol
On 8.01.2018 12:21, Timofey Titovets wrote:
> 2018-01-08 12:45 GMT+03:00 Nikolay Borisov :
>> So here is a small 2 patch set which removes btrfs' manual initialisation of
>> the lower level crc32c module. Explanation why is ok can be found in Patch
>> 2/2.
>>
&
On 10.03.2018 20:17, Andiry Xu wrote:
> From: Andiry Xu
>
> Range node specifies a range of [start, end]. and is managed by a red-black
> tree.
> NOVA uses range node to manage NVM allocator and inodes being used.
>
> Signed-off-by: Andiry Xu
> ---
> fs/nova/nova.h | 8
> fs/nova
[Adding Herbert Xu to CC since he is the maintainer of the crypto subsys
maintainer]
On 10.03.2018 20:17, Andiry Xu wrote:
> +static inline u32 nova_crc32c(u32 crc, const u8 *data, size_t len)
> +{
> + u8 *ptr = (u8 *) data;
> + u64 acc = crc; /* accumulator, crc32c value in lower 32b */
On 10.03.2018 20:17, Andiry Xu wrote:
> From: Andiry Xu
>
> NOVA divides the pmem range equally among per-CPU free lists,
> and format the red-black trees by inserting the initial free range.
>
> Signed-off-by: Andiry Xu
> ---
> fs/nova/balloc.c | 161
> +
On 10.03.2018 20:17, Andiry Xu wrote:
> From: Andiry Xu
>
> Signed-off-by: Andiry Xu
> ---
> fs/Kconfig | 2 ++
> fs/Makefile | 1 +
> fs/nova/Kconfig | 15 +++
> fs/nova/Makefile | 7 +++
> 4 files changed, 25 insertions(+)
> create mode 100644 fs/nova/Kconfig
On 23.02.2018 13:45, Nikolay Borisov wrote:
> This flag was added by 6039257378e4 ("direct-io: add flag to allow aio
> writes beyond i_size") to support XFS. However, with the rework of
> XFS' DIO's path to use iomap in acdda3aae146 ("xfs: use iomap_dio_rw
Signed-off-by: Nikolay Borisov
---
Hello,
Sending it as an RFC for the time being to see how people are going to react
and also I'd like some feedback on the mb semantics. For this purposed I've
CC'ed some memory ordering people :)
fs/btrfs/btrfs_inode.h | 17
On 6.04.2018 11:13, David Howells wrote:
> Al Viro wrote:
>
>> lookup_one_len() seriously depends upon exclusive lock
>
> In the code it says:
>
> WARN_ON_ONCE(!inode_is_locked(base->d_inode));
>
> which checks i_rwsem, but in the banner comment it says:
>
> * The caller must h
On 13.04.2018 10:32, Kohli, Gaurav wrote:
> Hi ,
>
> I have checked below code and it seems we are calling debug_object_free
> twice, ideally we should deactivate and later we
> have to destroy.
>
> 1st call -> percpu_counter_destroy->debug_percpu_counter_deactivate ->
> debug_object_free
> 2nd
On 14.03.2018 05:10, Tycho Andersen wrote:
> Hi all,
>
> I'm getting the WARN below. I think (?) what I'm doing when I get it
> is that I'm unmounting a subvolume while it's being synced (concurrent
> uses of the subvolume, at least, happy to look into it further if the
> stack trace is not so u
There are multiple places in the kernel which opencode this helper,
this patch moves it to the more generic mm.h header in preparation for
using it. No functional changes.
Signed-off-by: Nikolay Borisov
---
include/linux/mm.h| 2 ++
include/linux/mm_inline.h | 3 ---
2 files changed, 2
Multiple filesystems opencode lru_to_page. Rectify this by moving the
macro from mm_inline (which is specific to lru stuff) to the more
generic mm.h header and start using the macro where appropriate.
No functional changes.
Signed-off-by: Nikolay Borisov
Acked-by: Michal Hocko
Reviewed-by
On 30.11.18 г. 21:57 ч., Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 11:27:10AM -0800, Jarkko Sakkinen wrote:
>> In order to comply with the CoC, replace with a hug.
>>
>> Signed-off-by: Jarkko Sakkinen
>
> Since v17 of the SGX patch set, my cover letters get cut for some
> reason. I
On 30.11.18 г. 23:50 ч., Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 11:06:30PM +0200, Nikolay Borisov wrote:
>> I find it quite ridiculous that grown up people are engaging at yet
>> another coc-related conversation and are on the way to blowing it out of
>> propor
On 1.12.18 г. 8:46 ч., Frank Lee wrote:
> It seems that the trivial tree has not been maintained for some time.
> Are there aother tree to choose?
perhaps mmotm, maintained by Andrew (cc'ed)
>
> MBR,
> Yangtao
> On Sat, Dec 1, 2018 at 2:36 AM Tejun Heo wrote:
>>
>> On Mon, Nov 26, 2018 at 09
Shankara Pailoor
Reported-by: Shankara Pailoor
CC: shankarapail...@gmail.com
Signed-off-by: Nikolay Borisov
---
Hello David,
I'm sending you the patch for the issue which was originally reported and
suggested by Shankar. I won't usually got and override the original
author of a
On 31.05.2018 02:56, Yang Shi wrote:
> commit 1efff914afac8a965ad63817ecf8861a927c2ace ("fs: add
> dirtytime_expire_seconds sysctl") introduced dirtytime_expire_seconds
> knob, but there is not description about it in
> Documentation/sysctl/vm.txt.
>
> Add the description for it.
>
> Cc: Theod
All users of the aformentioned macros convert them to kbytes by
multplying. Instead, directly define the macros via the aptly named
SZ_16K/SZ_128K ones. Also remove the now redundant comments explaining
that VM_* are defined in kbytes it's obvious. No functional changes.
Signed-off-by: Ni
On 21.12.18 г. 15:24 ч., Matthew Wilcox wrote:
> On Fri, Dec 21, 2018 at 02:53:14PM +0200, Nikolay Borisov wrote:
>> All users of the aformentioned macros convert them to kbytes by
>> multplying. Instead, directly define the macros via the aptly named
>> SZ_16K/SZ_128K ones
VM_MIN_READAHEAD
Signed-off-by: Nikolay Borisov
---
block/blk-core.c | 3 +--
fs/9p/vfs_super.c | 2 +-
fs/afs/super.c | 2 +-
fs/btrfs/disk-io.c | 2 +-
fs/fuse/inode.c| 2 +-
include/linux/mm.h | 4 ++--
6 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/block/blk-core.c b/block/blk
On 9.10.2018 18:39, Lukasz Luba wrote:
> This patch add some comment related to performance impact,
> which can be really big (x3 times slower context switch).
>
> Signed-off-by: Lukasz Luba
I don't think this brings any value. lockdep is a debugging aid aimed at
developers. A developer shou
There is no reason for this function to be unexprted and it's a useful
debugging aid.
Signed-off-by: Nikolay Borisov
---
kernel/trace/trace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index bf6f1d70484d..15c7a7d01505 100644
--- a/k
On 26.05.24 г. 4:58 ч., Chen Yu wrote:
The kernel can change spinlock behavior when running as a guest. But
this guest-friendly behavior causes performance problems on bare metal.
So there's a 'virt_spin_lock_key' static key to switch between the two
modes.
The static key is always enabled by
On 19.06.24 г. 18:25 ч., Chen Yu wrote:
Hi Nikolay,
On 2024-06-18 at 11:24:42 +0300, Nikolay Borisov wrote:
On 26.05.24 г. 4:58 ч., Chen Yu wrote:
The kernel can change spinlock behavior when running as a guest. But
this guest-friendly behavior causes performance problems on bare metal
IRT_SPINLOCKS YYN Y/N
PV spinlockYNN Y/N
virt_spin_lock_key NNY N
Fixes: ce0a1b608bfc ("x86/paravirt: Silence unused native_pv_lock_init() function
warning")
Suggested-by: Dave Hansen
Suggested-by: Qiuxu
On 25.06.24 г. 17:50 ч., Chen Yu wrote:
On 2024-06-25 at 16:42:11 +0300, Nikolay Borisov wrote:
On 25.06.24 г. 15:54 ч., Chen Yu wrote:
The kernel can change spinlock behavior when running as a guest. But
this guest-friendly behavior causes performance problems on bare metal.
So there
IRT_SPINLOCKS YYN Y/N
PV spinlockYNN Y/N
virt_spin_lock_key NNY N
Fixes: ce0a1b608bfc ("x86/paravirt: Silence unused native_pv_lock_init() function
warning")
Suggested-by: Dave Hansen
Suggested-by: Qiuxu
Hi,
I've run the attached test case on a clean 4.0 and 4.0 + the patch you
referenced but in neither cases could I crash the kernel. All that was
happening was for a new namespace to be created and bash executed in it
and after some seconds I get logged out of the machine. But then I can
log-in b
Hello,
During a debugging session of my local code I encountered the following
lockdep splat but my machine did not deadlock, on subsequent repeats of
the same operations that led to this splat (enqueuing my rcu callback) I
couldn't reproduce it:
=
[ INFO: inconsist
On 3.05.2018 11:07, Anand Jain wrote:
>
>
> On 04/19/2018 03:25 PM, Nikolay Borisov wrote:
>>
>>
>> On 19.04.2018 08:32, Fengguang Wu wrote:
>>> Hello,
>>>
>>> FYI this happens in mainline kernel and at least dates back to v4.16 .
&
On 25.05.2018 10:52, Michal Hocko wrote:
> On Thu 24-05-18 09:37:18, Randy Dunlap wrote:
>> On 05/24/2018 04:43 AM, Michal Hocko wrote:
> [...]
>>> +The traditional way to avoid this deadlock problem is to clear __GFP_FS
>>> +resp. __GFP_IO (note the later implies clearing the first as well) in
>
On 25.04.2018 23:30, David Sterba wrote:
> On Wed, Apr 25, 2018 at 08:46:02AM -0700, Matthew Wilcox wrote:
>> Recently ncpfs got moved to staging. Also recently, we had some fuzzer
>> developers report bugs in hfs, which they deem a security hole because
>> Ubuntu attempts to automount an insert
On 18.04.19 г. 17:07 ч., Josef Bacik wrote:
> On Thu, Apr 18, 2019 at 03:50:00PM +0300, Nikolay Borisov wrote:
>>
>>
>> On 18.04.19 г. 14:06 ч., Pan Bian wrote:
>>> The reference count of inode is incremented by ihold. It should be
>>> dropped if not us
On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote:
> Hi,
>
> Alexei, could you tell me what is the concerning situation for bpf?
Another data point masami is that this affects bpf kprobes which are
entered via int3, alternatively if the kprobe is entered via
kprobe_ftrace_handler it works as e
On 28.01.21 г. 18:12 ч., Nikolay Borisov wrote:
>
>
> On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote:
>> Hi,
>
>
>
>>
>> Alexei, could you tell me what is the concerning situation for bpf?
>
> Another data point masami is that this affect
, for functions which can be called indirectly.
>
> CET instrumentation isn't currently necessary in the kernel, as CET is
> only supported in user space. Disable it unconditionally.
>
> Reported-by: Nikolay Borisov
> Signed-off-by: Josh Poimboeuf
Tested-by: Nikolay Borisov
Reviewed-by: Nikolay Borisov
On 29.01.21 г. 3:34 ч., Alexei Starovoitov wrote:
> On Thu, Jan 28, 2021 at 07:24:14PM +0100, Peter Zijlstra wrote:
>> On Thu, Jan 28, 2021 at 06:45:56PM +0200, Nikolay Borisov wrote:
>>> it would be placed on the __fentry__ (and not endbr64) hence it works.
>>> So p
On 29.01.21 г. 18:49 ч., Josh Poimboeuf wrote:
> Agreed, stable is a good idea. I think Nikolay saw it with GCC 9.
Yes I did, with the default Ubuntu compiler as well as the default gcc-10
compiler:
# gcc -v -Q -O2 --help=target | grep protection
gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1
oring them. This
enables diffing subsystems which generate built-in.a files.
Signed-off-by: Nikolay Borisov
---
scripts/bloat-o-meter | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
index 8c965f6a9881..d7ca46c612b3 100755
--- a/scripts/bloat-o-
ode to avoid NULL
pointer dereference")
Reviewed-by: Nikolay Borisov
>
> ---
>
> Notice that patch introducing this problem is on its way to 4.19.137-stable.
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 7befb7c12bd3..4aaa01540f89 100644
> --- a/fs/btrfs
On 3.08.20 г. 12:39 ч., Nikolay Borisov wrote:
>
>
> On 3.08.20 г. 12:35 ч., Pavel Machek wrote:
>> btrfs_get_extent() sets variable ret, but out: error path expect error
>> to be in variable err. Fix that.
>>
>> Signed-off-by: Pavel Machek (CIP)
>
>
On 8.12.20 г. 21:46 ч., Matthew Wilcox (Oracle) wrote:
> Pages being added to the page cache should already be folios, so
> turn add_to_page_cache_lru() into a wrapper. Saves hundreds of
> bytes of text.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> ---
> include/linux/pagemap.h | 13 +++-
Signed-off-by: Nikolay Borisov
---
kernel/locking/rwsem.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 kernel/locking/rwsem.h
diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h
deleted file mode 100644
index e69de29bb2d1..
--
2.25.1
1 - 100 of 378 matches
Mail list logo
